[PR #4] [MERGED] Fix: Handle GET requests correctly and improve namespacing #4

New Issue

2026-02-16T11:22:07-05:00

yindo commented

2026-02-16 11:22:07 -05:00

📋 Pull Request Information

Original PR: https://github.com/langgenius/ruby-sdk/pull/4
Author: @echoidcf
Created: 9/4/2025
Status: ✅ Merged
Merged: 9/5/2025
Merged by: @Eric-Guo

Base: main ← Head: fix-bugs

📝 Commits (2)

a46fbb9 bugfix
280d113 mini fix

📊 Changes

3 files changed (+97 additions, -91 deletions)

View changed files

📝 Gemfile.lock (+1 -1)
📝 lib/dify/client.rb (+95 -89)
📝 lib/dify/client/version.rb (+1 -1)

📄 Description

This pull request addresses a bug that caused GET requests to fail and improves the overall structure of the codebase by introducing proper namespacing. The gem version has been bumped to 0.1.1 to reflect these changes.

Changes Included:

Bug Fix: Corrected an issue in the _send_request method where GET requests would cause critical failure due to a misplaced http.request call. The fix ensures that both GET and POST requests are now handled correctly.
Refactoring: All client classes (DifyClient, CompletionClient, and ChatClient) are now properly namespaced under the Dify::Client module. This improves code organization and prevents potential naming conflicts with other gems.
Dependencies: Added explicit require "net/https" and require "json" statements to ensure all necessary libraries are loaded.
Version Bump: Increased the gem version from 0.1.0 to 0.1.1, because thing from gem install and your github are not the same.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/langgenius/ruby-sdk/pull/4 **Author:** [@echoidcf](https://github.com/echoidcf) **Created:** 9/4/2025 **Status:** ✅ Merged **Merged:** 9/5/2025 **Merged by:** [@Eric-Guo](https://github.com/Eric-Guo) **Base:** `main` ← **Head:** `fix-bugs` --- ### 📝 Commits (2) - [`a46fbb9`](https://github.com/langgenius/ruby-sdk/commit/a46fbb93ab71b30af88ae1e2eb6acf4f0ff8459d) bugfix - [`280d113`](https://github.com/langgenius/ruby-sdk/commit/280d113007e77135f5695de5b1797d11b207a27e) mini fix ### 📊 Changes **3 files changed** (+97 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `Gemfile.lock` (+1 -1) 📝 `lib/dify/client.rb` (+95 -89) 📝 `lib/dify/client/version.rb` (+1 -1) </details> ### 📄 Description This pull request addresses a bug that caused GET requests to fail and improves the overall structure of the codebase by introducing proper namespacing. The gem version has been bumped to 0.1.1 to reflect these changes. Changes Included: - Bug Fix: Corrected an issue in the _send_request method where GET requests would cause critical failure due to a misplaced http.request call. The fix ensures that both GET and POST requests are now handled correctly. - Refactoring: All client classes (DifyClient, CompletionClient, and ChatClient) are now properly namespaced under the Dify::Client module. This improves code organization and prevents potential naming conflicts with other gems. - Dependencies: Added explicit require "net/https" and require "json" statements to ensure all necessary libraries are loaded. - Version Bump: Increased the gem version from 0.1.0 to 0.1.1, because thing from gem install and your github are not the same. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

yindo added the pull-request label 2026-02-16 11:22:07 -05:00

yindo closed this issue

2026-02-16 11:22:08 -05:00

yindo referenced this issue

2026-02-16 11:22:08 -05:00

[PR #6] [MERGED] Add file upload and workflow support #6

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: langgenius/ruby-sdk#4