libretro/RetroArch
1
0 Fork 0
mirror of https://github.com/libretro/RetroArch.git synced 2026-11-07 08:36:02 -10:00
Code Issues Packages Projects Releases 1 Wiki Activity

Core updater: leave out uninstalled cores before building their paths

Browse Source 
The installed-only list parse looks each listing line up in its walk of
the libretro directory once the date and CRC have parsed, and leaves out
a core that is not installed before building its paths - a URL-encode,
a realpath and four allocations - rather than after. A libretro
directory that could not be walked still falls back to a stat of the
built path. Update Installed Cores' parse of a 242-entry listing with 40
installed cores drops from 1.2 ms to 0.8 ms warm.
This commit is contained in:
libretroadmin committed 2026-10-03 03:27:02 +02:00
1 parent 3f618f9c76
commit 882aad01a1
1 file changed
+30 -25
Download Patch File Download Diff File Expand all files Collapse all files
core_updater_list.c
+30 -25
View File
@@ -888,6 +888,31 @@ static bool core_updater_list_add_entry(
if (!core_updater_list_set_crc(&entry, crc_str))
goto error;
/* Not an error either: a core that is not installed is left
* out - before its paths are built (a URL-encode, a realpath and
* four allocations) and before its info file is read. The walk
* of the libretro directory answers that, and gives the metadata
* the CRC cache is keyed on. The line has parsed by now, so it
* counts as well-formed either way. */
if (installed_only && core_list->installed)
{
char local_name[PATH_MAX_LENGTH];
const core_updater_installed_t *installed;
strlcpy(local_name, filename_str, sizeof(local_name));
if (path_is_compressed_file(local_name))
path_remove_extension(local_name);
if (!(installed = core_updater_list_find_installed(
core_list, local_name)))
{
well_formed = true;
goto error;
}
entry.local_size = installed->size;
entry.local_mtime = installed->mtime;
entry.local_metadata = installed->metadata;
}
if (!core_updater_list_set_paths(
&entry,
path_dir_libretro,
@@ -899,31 +924,11 @@ static bool core_updater_list_add_entry(
well_formed = true;
/* Not an error either: a core that is not installed is left
* out before its info file is read. The walk of the libretro
* directory answers that, and gives the metadata the CRC cache
* is keyed on; a directory that could not be walked falls back
* to a stat. */
if (installed_only)
{
if (core_list->installed)
{
char local_name[PATH_MAX_LENGTH];
const core_updater_installed_t *installed;
strlcpy(local_name, filename_str, sizeof(local_name));
if (path_is_compressed_file(local_name))
path_remove_extension(local_name);
if (!(installed = core_updater_list_find_installed(
core_list, local_name)))
goto error;
entry.local_size = installed->size;
entry.local_mtime = installed->mtime;
entry.local_metadata = installed->metadata;
}
else if (!path_is_valid(entry.local_core_path))
goto error;
}
/* A libretro directory that could not be walked: a stat each */
if ( installed_only
&& !core_list->installed
&& !path_is_valid(entry.local_core_path))
goto error;
if (!core_updater_list_set_core_info(
&entry,