twinaphex
637cff628f
* Simplify RARCH_CTL_IS_CORE_LOADED
...
* Create specialized function path_basename_nocompression
2021-04-11 17:27:31 +02:00
twinaphex
3841fecc59
Cleanups
2021-04-11 17:01:13 +02:00
twinaphex
f1cf5ceb82
(input drivers) Cut down on code duplication
2021-04-11 16:31:46 +02:00
twinaphex
40c39de5e3
Move old_libretro_device/old_analog_dpad_mode to global struct
2021-04-11 16:02:47 +02:00
twinaphex
0087be2a53
Cleanup input_remapping_load_file/input_remapping_save_file - none
...
of these huge char arrays were needed, wrong size being passed
to snprintf, fill_pathname_join, k loop variable unneeded, etc.
2021-04-11 14:36:51 +02:00
twinaphex
d9cacc0b8c
Other cleanups - wrong size being passed to snprintf for s3, etc.
2021-04-11 14:18:14 +02:00
twinaphex
370751551f
Some further optimizations - key_strings doesn't need to be inside
...
the loop
2021-04-11 14:11:12 +02:00
twinaphex
ac8e1b88e4
input_remapping_load_file/input_remapping_save_file - char arrays
...
were way too big
2021-04-11 14:03:03 +02:00
twinaphex
aa0a9f18d5
Fix crash that could happen after loading a remap file manually -
...
config file was being freed at the end of input_remapping_load_file
when the menu_cbs_ok.c function was still using it afterwards - move
the config_file_free outside of the function and free manually
afterwards when we're done
2021-04-11 13:48:25 +02:00
twinaphex
05a2623875
(udev input) Cut down on code duplication
2021-04-11 06:37:49 +02:00
twinaphex
1f506615d3
(x11_input.c) Cut down on code duplication
2021-04-11 06:29:36 +02:00
twinaphex
bc08e325ce
Travis buildfix
2021-04-11 02:22:35 +02:00
twinaphex
a8f410ed40
slang_preprocess_parse_parameters - get rid of one local variable
2021-04-11 01:49:41 +02:00
twinaphex
f29a4b51cc
Put this behind VULKAN_DEBUG ifdef
2021-04-11 00:15:06 +02:00
twinaphex
924b5830ba
(shader_gl_core) Remove std::string usage and std::to_string usage
2021-04-11 00:09:40 +02:00
twinaphex
ab877c429f
(Qt) Use string append() where possible
2021-04-10 23:57:31 +02:00
Autechre
97e5e6beee
Merge pull request #12256 from Jamiras/cheevos_local_addr_warning
...
(cheevos) attempt to silence return-local-addr warning
2021-04-10 23:43:47 +02:00
Jamiras
5530b7022f
attempt to silence return-local-addr warning
2021-04-10 14:51:41 -06:00
twinaphex
0aa266a6ca
build_stage_source - use std::string reserve and append, significantly
...
faster
2021-04-10 22:11:26 +02:00
Autechre
0b52823f2c
Merge pull request #12255 from libretro/destl
...
Destl
2021-04-10 22:10:53 +02:00
twinaphex
1273536752
Reduce get_semantic_name down to one version
2021-04-10 21:46:04 +02:00
twinaphex
59449600ad
Cleanup retroarch_menu_running_finished
2021-04-10 21:04:00 +02:00
twinaphex
c392a475ee
Cleanups
2021-04-10 20:51:19 +02:00
twinaphex
d024ff553f
Cleanups
2021-04-10 20:47:04 +02:00
twinaphex
b5d49b9e79
Avoid std::string allocations when possible (pt. 1)
2021-04-10 20:19:30 +02:00
twinaphex
f0fa3c5861
(slang C++ files) take out using namespace std, explicitly refer to
...
std namespace
2021-04-10 19:42:59 +02:00
twinaphex
966dd62551
Fix warnings local variable hides parameter of the same name
2021-04-10 19:28:30 +02:00
twinaphex
ca5ce839ce
Small cleanups to button input handling code - several parameters
...
were no longer used
2021-04-10 19:06:56 +02:00
twinaphex
760fc6b3f7
Simplify button_is_pressed
2021-04-10 18:44:10 +02:00
twinaphex
372f939cc9
Simplify input_keys_pressed
2021-04-10 18:25:50 +02:00
twinaphex
5df321fcaa
Cleanups
2021-04-10 18:19:20 +02:00
Autechre
10c9d485c4
Merge pull request #12254 from repojohnray/valgrind
...
Fix issue detected by valgrind
2021-04-10 17:52:45 +02:00
repojohnray
8f3e02e49c
Fix issue detected by valgrind
...
==27741== Conditional jump or move depends on uninitialised value(s)
==27741== at 0x6080F5: strlcpy_retro__ (compat_strl.c:38)
==27741== by 0x60818A: strlcat_retro__ (compat_strl.c:60)
==27741== by 0x49EDD7: fill_pathname_join_special_ext (file_path.c:843)
==27741== by 0x4C78C8: config_load_remap (configuration.c:3765)
==27741== by 0x4386FF: command_event_init_core (retroarch.c:12601)
==27741== by 0x43B15E: command_event (retroarch.c:14000)
==27741== by 0x468863: retroarch_main_init (retroarch.c:35231)
==27741== by 0x487AED: content_load (task_content.c:607)
==27741== by 0x48A3D3: task_load_content_internal (task_content.c:2068)
==27741== by 0x48A6AD: task_push_load_content_from_cli (task_content.c:2162)
==27741== by 0x43D66E: rarch_main (retroarch.c:15300)
==27741== by 0x43D6ED: main (retroarch.c:15398)
==27741== Uninitialised value was created by a stack allocation
==27741== at 0x4C7730: config_load_remap (configuration.c:3721)
2021-04-10 17:30:56 +02:00
twinaphex
8b197e49bb
accessibility_speak_priority - no longer dependent on settings pointer
2021-04-10 14:59:34 +02:00
twinaphex
200983f938
is_narrator_running -don't pass entire settings pointer
2021-04-10 14:24:41 +02:00
twinaphex
dd7fe2e7e0
Cleanups
2021-04-10 14:19:52 +02:00
twinaphex
1e94070dca
Simplify driver_adjust_system_rates
2021-04-10 13:39:47 +02:00
twinaphex
40ab6f839a
Some cleanups to driver_adjust_system_rates
2021-04-10 13:32:27 +02:00
twinaphex
43cb646870
Turn video_driver_monitor_adjust_system_rates into pure function
2021-04-10 13:22:12 +02:00
twinaphex
d1d9f96ab3
Turn audio_driver_monitor_adjust_system_rates into pure function
2021-04-10 13:11:01 +02:00
twinaphex
d910f520d9
Don't pass entire settings pointer if we just need a few settings variables
...
to read
2021-04-10 13:03:53 +02:00
twinaphex
5ca666acee
Cleanups, don't try to pass settings pointer to functions unless we have to
2021-04-10 03:01:25 +02:00
twinaphex
338c2eb2f0
Settings cleanups
2021-04-10 01:51:28 +02:00
twinaphex
deccc4d8c6
Some refactors
2021-04-10 00:54:40 +02:00
twinaphex
204eaf0e76
Don't grab settings pointer inside video_driver_frame
2021-04-08 20:01:59 +02:00
twinaphex
421dbb19c2
Don't pass settings pointer if we just need a couple of variables
...
that we won't mutate
2021-04-08 19:45:30 +02:00
twinaphex
808f326209
Cleanups
2021-04-08 19:24:19 +02:00
twinaphex
9c5f365b2b
Cleanups
2021-04-08 18:37:09 +02:00
twinaphex
f7a5833cb0
Turn bunch of functions static
2021-04-08 18:33:46 +02:00
twinaphex
0d549fd42b
Merge netplay_init.c into netplay_io.c
2021-04-08 18:16:24 +02:00