Commit Graph

61004 Commits

Author SHA1 Message Date
libretroadmin
f994c0b371 Get rid of superfluous wrapper function config_entry_exists 2022-07-19 21:00:40 +02:00
libretroadmin
4b5c7856e6 Remove some more explicit NULL-termination when we're calling a
string function that calls strlcpy under the hood
2022-07-19 20:43:12 +02:00
libretroadmin
a23231525d (Android) frontend_android_get_version_sdk - use strtol again - this
time assign the return value to the dereferenced pointer
2022-07-19 10:59:32 +02:00
libretroadmin
62fd667f41 (netplay_frontend.c) Remove unused variable 2022-07-19 10:35:38 +02:00
LibretroAdmin
29774f5b7a
Small opts (#14186)
* (joypad_connection) Small optimizations -
* Turn functions static where possible
* Hose strlen call out of loop

* (input_driver.c) General cleanups:
* Some small code/style nits

task_screenshot.c:
* Move widget callback function for screenshots to task_screenshot.c

(file_path.c):
* Turn get_pathname_num_slashes into static function
* path_linked_list_free - always returns true, so get rid of return value
* path_linked_list_new - fix function signature
* path_get_archive_delim - do not NULL-terminate string, already done by strlcpy later on

General:
* Slight optimizations - use int/size_t for loop counter variable instead of unsigned
* Take advantage of fact that strlcpy already NULL-terminates, so don't do this explicitly
outside if we're just going to end up calling strlcpy/fill_pathname_join on it anyway
2022-07-19 10:01:33 +02:00
LibretroAdmin
87240556ea
Should fix Android strtol regression (when converting from sscanf) (#14183) 2022-07-18 04:38:52 +02:00
libretroadmin
fbd765f167 Change menu_setting.c back 2022-07-18 03:11:38 +02:00
libretroadmin
a64f0332f9 Replace sscanf call in frontend_unix_get_os 2022-07-18 02:10:40 +02:00
libretroadmin
8f37c2e3c2 Don't call config_set_bool, call config_set_string directly 2022-07-18 01:59:32 +02:00
LibretroAdmin
71eb74d256
Update .gitlab-ci.yml - don't make ctr-legacy and djgpp depend on build pipeline pass
Set needs to []
2022-07-17 21:23:53 +02:00
Cthulhu-throwaway
83ed9a5980
(Network) Implement binary network streams (#14180) 2022-07-17 19:43:48 +02:00
libretroadmin
de6c077e4d (menu_cbs_get_value.c) Small nits 2022-07-17 19:23:46 +02:00
libretroadmin
66ea402de8 We already check if descriptor is empty beforehand 2022-07-17 19:15:37 +02:00
libretroadmin
a39532f19d (menu_cbs_get_value) Try to prevent assignments to string buffer if not needed 2022-07-17 18:59:21 +02:00
libretroadmin
610292db61 Replace more trivial sscanf usage with strtol 2022-07-17 18:38:28 +02:00
libretroadmin
c89f6cf0a9 Replace more trivial usage of sscanf 2022-07-17 18:33:54 +02:00
libretroadmin
08cccc811c Some slight optimizations of menu callback functions - better variable
scoping
2022-07-17 18:09:28 +02:00
libretroadmin
c3483654c9 Revert back to sscanf for versions of MSVC prior to MSVC2013 - prior
to MSVC2013, MSVC did not yet support strtof
2022-07-17 17:37:22 +02:00
libretroadmin
3ebfcbc7c7 setting_set_with_string_representation - avoid sscanf for trivial
operations when we can use strtol/strtoul/strtof
2022-07-17 09:46:27 +02:00
libretroadmin
27704a18de Remove unused core_info_hw_api_supported 2022-07-17 08:10:01 +02:00
libretroadmin
113b9e96d1 Miscellaneous cleanups to VFS layers:
* Indents
* Simplifications
2022-07-17 07:29:00 +02:00
libretroadmin
e4b33fd0e6 (formats/json/rjson.c) Get rid of some implicit strlens and pass
size parameter to the functions instead˜
2022-07-17 06:58:22 +02:00
libretroadmin
0a12062e1c Remove unnecessary content_crc in bsv_movie_init_playback 2022-07-17 04:26:49 +02:00
github-actions
dec0ee87d5 Fetch translations from Crowdin 2022-07-17 00:12:04 +00:00
Jacob
78c286471f
Fixed typos in README.md (#14181)
In the requirements the section about Direct3D 11 had some typos
2022-07-16 22:01:15 +02:00
libretroadmin
f990fa86fa (Freetype) Prevent potential free issue on WiiU - play it safe for
now until further clarified what is going on
2022-07-15 19:28:21 +02:00
libretroadmin
b56b447f08 Fix these two memory errors that popped up with ASAN -
* Argument base for qsort cannot be NULL
* When system_count is 0 or less, early return out of explore_load_icons
2022-07-15 19:16:21 +02:00
libretroadmin
c570e657c1 (CDROM) Fix memory leak caught with asan - buf passed to filestream_read_file
was not being freed after we were done with it (we are done with it after iterating
over the string list)
2022-07-15 19:00:59 +02:00
libretroadmin
5e13851a7a (Freetype) Fix severe memory leaks that happened after using FT_New_Memory_Face -
according to documentation note - 'You must not deallocate memory before calling
FT_Done_Face' - so store a pointer to the font data and then free it after calling
FT_Done_Face
2022-07-15 18:57:02 +02:00
libretroadmin
675ff6b9b6 net_http_send_str - reduce the amount of times strlen is called by
hardcoding the length when we feed the function a constant string
(with STRLEN_CONST)
2022-07-15 17:37:30 +02:00
libretroadmin
4b1766cf61 Silence more -Wdocumentation warnings 2022-07-15 01:12:04 +02:00
libretroadmin
eb2c3e35d4 Silence some of the warnings being generated by Objective-C 2022-07-15 00:33:08 +02:00
libretroadmin
c7c42409f1 Revert "Attempt to silence warnings by casting to socklen_t"
This reverts commit 6c8f649b02.
2022-07-14 22:51:17 +02:00
libretroadmin
6c8f649b02 Attempt to silence warnings by casting to socklen_t 2022-07-14 21:27:34 +02:00
Cthulhu-throwaway
f5d46681c2
(UWP) Enable core downloader/updater (#14173) 2022-07-14 15:21:49 +02:00
github-actions
c5c5e7539f Fetch translations from Crowdin 2022-07-13 00:14:08 +00:00
libretroadmin
37bb66ef6e (Freetype) Fix warnings 'local variable hides a parameter of the same name' 2022-07-12 22:37:17 +02:00
Cthulhu-throwaway
98ca6232aa
(String) Some function fixes (#14171) 2022-07-12 22:32:58 +02:00
libretroadmin
c4fb055fdb Cleanups:
* Combine early return and assignment lines
* use path_basename_nocompression when possible
* Move variables to proper scope
2022-07-12 20:44:00 +02:00
libretroadmin
f7194e167f use path_basename_nocompression where it is safe to do so 2022-07-12 19:14:12 +02:00
libretroadmin
69ddf03c91 Remove unused return variables 2022-07-12 18:00:33 +02:00
libretroadmin
ec70bb84ca Remove unused variable 2022-07-12 17:31:47 +02:00
libretroadmin
83655420f6 file_list_prepend just a thin wrapper around file_list_insert - get
rid of it and just pass 0 as the last argument instead
2022-07-12 16:56:44 +02:00
libretroadmin
06e1b6a68f Revert "Move strftime_am_pm to libretro-common rtime.c, remove duplicate"
This reverts commit 99186b1056.
2022-07-12 03:31:42 +02:00
libretroadmin
99186b1056 Move strftime_am_pm to libretro-common rtime.c, remove duplicate
functions
2022-07-12 03:29:16 +02:00
Cthulhu-throwaway
f39df40728
(String) Do not assume char is unsigned (#14168) 2022-07-12 02:55:56 +02:00
github-actions
33386787b6 Fetch translations from Crowdin 2022-07-12 00:11:49 +00:00
libretroadmin
01d68fdb7e Remove unused fill_pathname_basedir_noext 2022-07-12 00:09:22 +02:00
libretroadmin
293722ac38 Get rid of fill_pathname_join_concat_ext 2022-07-11 22:01:20 +02:00
libretroadmin
b7926605f4 Remove fill_short_pathname_representation 2022-07-11 21:40:09 +02:00