== DETAILS
This should fix#6025.
After confirming that dummying out the init block of the HID subsystem
driver eliminated the crash, I narrowed it down to the event loop.
And that's when I noticed that, when the thread consumes the event,
it doesn't free it.
Oops.
Updated the event loop to free the event after it has been processed.
== TESTING
Local build, was able to load multiple ROMs in succession where prior
I was getting the system memory errors.
I've #if 0'd out a call to HIDRead that is still getting deadlocked,
because it slows down the startup/shutdown process.
== DETAILS
The joypad driver was only copying the first 16 bits when executing
get_buttons(). The touchpad button is bit 19, so as a result
RETRO_DEVICE_ID_POINTER_PRESSED would never fire.
We fix this for now by copying 32 bits.
== TESTING
Will need someone to verify. I don't have a core handy that leverages
the pointer device state functionality.
== DETAILS
@r-type got me the link to the fixed-fixed version.
Which was actually closer to where I was originally!
So:
- Revert the previous commit
- Apply the actual changes needed to fix the problem
- Bring in and fix the logging code from the previous implementation
== TESTING
- Verified that top-left is -0x7fff,-0x7fff and that bottom-right is
0x7fff, 0x7fff.
== REVIEW
@QuarkTheAwesome @r-type @twinaphex
Fixes the following -Werror warnings with C89_BUILD=1 and clang.
gfx/common/x11_common.c:407:17: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
Status status = 0;
^
libretro-common/formats/libchdr/chd.c:639:12: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
uint8_t *sector = &dest[framenum * CD_FRAME_SIZE];
^
libretro-common/formats/libchdr/chd.c:723:12: warning: ISO C90 forbids mixing declarations and code [-Wdeclaration-after-statement]
uint8_t *sector = &dest[framenum * CD_FRAME_SIZE];
^
Fixes these two compile errors with C89_BUILD=1
configuration.c:2028:9: error: ISO C90 forbids mixing declarations and code [-Werror,-Wdeclaration-after-statement]
bool has_application_data =
^
1 error generated.
make: *** [Makefile:164: obj-unix/configuration.o] Error 1
In file included from menu/widgets/menu_osk.c:42:
menu/widgets/menu_osk_utf8_pages.h:62:94: error: no newline at end of file [-Werror,-Wnewline-eof]
"ヤ","ユ","ヨ","ワ","ヲ","ァ","ィ","ゥ","ェ","ォ","⊕"};
^
1 error generated.
make: *** [Makefile:163: obj-unix/menu/widgets/menu_osk.o] Error 1
