Commit Graph

61071 Commits

Author SHA1 Message Date
LibretroAdmin
eaae2aec46 Increase the size of formatted_number to 16 so we no longer get
-Wformat-truncation warnings (state slot would be way too big though
regardless, even the current cap at 999 is ridiculous)
2022-08-27 15:45:49 +02:00
LibretroAdmin
0c7408ee16 (EGL) Buildfix 2022-08-27 15:43:16 +02:00
LibretroAdmin
bbf93812a5 (EGL) Turn some EGL functions static 2022-08-27 15:35:08 +02:00
LibretroAdmin
25b76fdb54 input_keyboard_osk_event_append and others: don't call strlen
implicitly, always leave it up to caller
font_driver_get_message_width - try to avoid scenario where 'len'
is 0
2022-08-27 15:13:56 +02:00
LibretroAdmin
f34f4d060c (video_shader_get_type_from_ext) remove strlen call 2022-08-27 14:29:37 +02:00
LibretroAdmin
19c72a413f (gfx_thumbnail_path.c) Cache localized string
(menu_displaylist.c) Some optimizations:
* Make sure val_d is never bigger than 16, it should just
contain a number. 16 is more than plenty (and probably too big even)
* Hose val_d out of loops if its value never changes inside the loop
* Attempt to avoid calling msg_hash_to_str inside loops unnecessarily
2022-08-27 13:20:29 +02:00
LibretroAdmin
87de6bda46 (input_autoconfigure_disconnect_handler) Simplify some code 2022-08-27 09:22:20 +02:00
LibretroAdmin
b200ab6f8f Simplify code, and no longer have to deal with GCC suppression of warnings 2022-08-27 09:07:55 +02:00
LibretroAdmin
388183d971 (menu_displaylist)
* Don't attempt to call msg_hash_to_str in a loop, cache it once outside
inside a local variable
* Do away with some spurious snprintf usage for RGUI (truncation does not matter
as pointed out by jdgleaver, so we needn't be concerned)
2022-08-27 09:02:43 +02:00
LibretroAdmin
c0221ae340 Fix typo 2022-08-27 07:59:22 +02:00
LibretroAdmin
61e24132bf (task_save.c) Simplification in control flow
(snprintf) Try to reduce or simplify snprintf calls, only tend to
use it for processing integers/numbers and avoid it for regular
string concatenation (NOTE: we try to be a bit safer about it to
address earlier cited criticism, although we don't consider concatenating
3 or 4 characters at the end to be insecure)
(msg_hash_to_str) Try to avoid duplicate calls to the same localized
string when we can just cache the results once instead locally
2022-08-27 07:55:02 +02:00
github-actions
45b05ea3db Fetch translations from Crowdin 2022-08-27 00:12:27 +00:00
LibretroAdmin
f3c13cf669 * (cheat_manager_save) Reduce amount of snprintf calls from 4 to 1 2022-08-26 23:35:45 +02:00
LibretroAdmin
8f47621857 (libretro-common) Remove unused jsonsax files - we use rjson now instead 2022-08-26 17:38:34 +02:00
LibretroAdmin
c3a1c578b6 Prefer to use string_starts_with_size/string_ends_with_size (less strlen
calls)
2022-08-26 17:27:55 +02:00
LibretroAdmin
be9b4031d9 Remove some 'Unused variable' warnings 2022-08-26 17:10:45 +02:00
LibretroAdmin
a47ccd81ed (video_shader_parse.c) Don't keep recreating formatted_num unnecessarily
when we already have it
2022-08-26 16:37:24 +02:00
sonninnos
1f048dd358
(XMB+Ozone) Core option category icon refinements (#14354) 2022-08-26 16:11:36 +02:00
LibretroAdmin
7507e20703 Revert "(RJSON) Combine multiple consecutive rjsonwriter_raw calls into one"
This reverts commit 82efa5a3d6.
2022-08-26 14:44:29 +02:00
LibretroAdmin
82efa5a3d6 (RJSON) Combine multiple consecutive rjsonwriter_raw calls into one
- significantly reduces the amount of function calls
2022-08-26 13:55:52 +02:00
LibretroAdmin
dfe712da95 (Steam) Buildfix 2022-08-26 12:58:06 +02:00
LibretroAdmin
842121ca16 (Steam) restore to original code 2022-08-26 12:38:53 +02:00
LibretroAdmin
205b9f862f (CTR) Buildfix/ fix typo 2022-08-26 11:49:27 +02:00
LibretroAdmin
29caa95f7e (platform_unix.c) Use safer 'fill_pathname_join_special' for assembling
file path names instead of snprintf
(ctr_gfx.c) Use strlcpy instead of snprintf where possible
(ctr_gfx.c) Use snprintf instead of sprintf where possible
(ctr_gfx.c) Some general style nits
2022-08-26 10:43:42 +02:00
LibretroAdmin
b8b3fe55fe Turn Advanced Settings on by default, this entire filtering of
settings will need a complete rethink anyways
2022-08-26 10:06:03 +02:00
LibretroAdmin
62fffe726c Steam buildfix #3 2022-08-26 09:57:34 +02:00
LibretroAdmin
112a350789 (Steam) Buildfix #2 2022-08-26 09:39:40 +02:00
LibretroAdmin
1b07e2bdce (Steam) Buildfix 2022-08-26 09:37:22 +02:00
sonninnos
de67f174bf
(XMB) Fix icons in 'Load Content' Favorites (#14353) 2022-08-26 08:35:12 +02:00
LibretroAdmin
9535c5c0ad Optimize menu_displaylist_parse_core_options_dropdown_list:
* Hose val_d snprintf outside of loop
* Make it smaller
2022-08-26 00:02:04 +02:00
LibretroAdmin
d67cb22c7f (menu_setting.c) Replace trivial usage of snprintf with strlcpy (where it only printed a
string and nothing else, or similar simple usage)
2022-08-25 19:56:44 +02:00
LibretroAdmin
ee16c4558d Forgot to add compat_strldup.c to Wii and WiiU salamanders 2022-08-25 17:02:05 +02:00
LibretroAdmin
1a646d17e0 Add compat_strldup.c to Salamander versions 2022-08-25 17:00:23 +02:00
LibretroAdmin
288b2da13e Create separate file compat_strldup.c since compat_strl.c is not
getting built-in for Apple targets at all
2022-08-25 16:50:12 +02:00
LibretroAdmin
625e63c3cc Simplify DEFAULT_FILL_TITLE_MACRO 2022-08-25 16:42:46 +02:00
LibretroAdmin
575e331fd1 If we already know the length of the string, use strldup instead.
Avoids the internal strlen call inside strdup, and strdup is a deprecated
function starting from MSVC2005 anyways.

NOTE: Do NOT pass STRLEN_CONST as n parameter to strldup, it needs to
be at least +1 character higher than the strlen return value of the same
string
2022-08-25 16:31:54 +02:00
LibretroAdmin
5bb3fbab93 Fix mistake in prior commit - should be concatenated to string 2022-08-25 15:17:31 +02:00
LibretroAdmin
6caa139700 (cheevos.c) Fix some function prototypes for C
Rewrite some snprintfs as strlcpy/strlcat/manual assignment - only
use snprintf if we actually need the formatting
2022-08-25 15:08:02 +02:00
LibretroAdmin
15fe258c1b Reduce snprintf calls 2022-08-25 13:03:08 +02:00
LibretroAdmin
1b181185c2 Simplify override_shader_values - entry variable never used 2022-08-25 08:51:55 +02:00
LibretroAdmin
a1f5a03551 (libretrodb) Replace strncpy 2022-08-25 08:32:02 +02:00
LibretroAdmin
f5ac33c0b6 Simplify task_database_cue.c code -
* Was copying pre_game_id into several memory buffers for no real reason,
gets rid of some unnecessary strncpy calls this way too
2022-08-25 07:15:27 +02:00
LibretroAdmin
88187e7ef2 * Start getting rid of strncpy
* steam.c - cleanups:
  * Use string_to_lower from libretro-common/stdstring.c instead of
    its own version
  * Some stylistic changes
  * Rewrite strncpy calls into strlcpy/strlcat/manual assignment
  * Make it C89 compliant
  * Some unused variables
2022-08-25 06:51:39 +02:00
LibretroAdmin
8017410098 task_database_cue_get_token - correct to 'if (rv < 0)' instead 2022-08-25 05:52:42 +02:00
LibretroAdmin
c841e191f7 (task_database_cue.c) Put this conditional back 2022-08-25 05:36:48 +02:00
LibretroAdmin
da13fb0f48 Don't include errno.h in files that don't justify its use 2022-08-25 05:19:30 +02:00
LibretroAdmin
39241699a0 Drop errno dependency in database_cue_get_token - was some legacy
code that is probably not needed
2022-08-25 04:51:00 +02:00
LibretroAdmin
93babdd6f7 Remove mono_crash.mem.413585.1.blob 2022-08-25 04:43:51 +02:00
lucasmr
808fc7f389
Refactor task_database_cue.c (#14349) 2022-08-25 04:42:23 +02:00
sonninnos
8fd0961c9a
Show playlist entry as 'Quick Menu' header title (#14350) 2022-08-25 04:41:14 +02:00