Merge pull request #63 from sunlollyking/serialization-quirks

libretro: report that states are incomplete

.cirrus.yml

@@ -1,23 +0,0 @@
-freebsd-x86_64-binaries_task:
-    freebsd_instance:
-        image_family: freebsd-12-2
-
-    setup_script:
-        - pkg install --yes gmake gdb gcc8 pkgconf sdl2 openal-soft gtk3 gtksourceview3 libXv zip
-
-    compile_script:
-        - gmake -C bsnes local=false
-
-    package_script:
-        - mkdir bsnes-nightly
-        - mkdir bsnes-nightly/Database
-        - mkdir bsnes-nightly/Firmware
-        - cp -a bsnes/out/bsnes bsnes-nightly/bsnes
-        - cp -a bsnes/Database/* bsnes-nightly/Database
-        - cp -a shaders bsnes-nightly/Shaders
-        - cp -a GPLv3.txt bsnes-nightly
-        - cp -a extras/* bsnes-nightly
-        - zip -r bsnes-nightly.zip bsnes-nightly
-
-    bsnes-nightly_artifacts:
-        path: "bsnes-nightly.zip"

.github/workflows/build.yml

@@ -34,6 +34,24 @@ jobs:
         name: bsnes-${{ matrix.os.name }}
         path: bsnes/out/bsnes*
 
+  build-freebsd:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - uses: vmactions/freebsd-vm@v1
+      with:
+        release: "14.3"
+        usesh: true
+        prepare: |
+          pkg install --yes gmake gdb gcc14 pkgconf sdl2 openal-soft gtk3 gtksourceview3 libXv zip
+        run: |
+          gmake -j4 -C bsnes local=false
+    - name: Upload
+      uses: actions/upload-artifact@v4
+      with:
+        name: bsnes-freebsd
+        path: bsnes/out/bsnes*
+
   release:
     if: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/')
     # Prevent multiple conflicting release jobs from running at once.
@@ -41,6 +59,7 @@ jobs:
     runs-on: ubuntu-latest
     needs:
     - build
+    - build-freebsd
     steps:
     - uses: actions/checkout@v4
       with:
@@ -68,7 +87,7 @@ jobs:
           chmod +x ${bindir}/${program}-macos/${program}.app/Contents/MacOS/${program}
         done
 
-        for os in ubuntu windows macos
+        for os in ubuntu windows macos freebsd
         do
           mkdir "${os}"
           cd "${os}"

Makefile

@@ -233,7 +233,7 @@ else ifeq ($(platform), wiiu)
    CC = $(DEVKITPPC)/bin/powerpc-eabi-gcc$(EXE_EXT)
    CXX = $(DEVKITPPC)/bin/powerpc-eabi-g++$(EXE_EXT)
    AR = $(DEVKITPPC)/bin/powerpc-eabi-ar$(EXE_EXT)
-   ENDIANNESS_DEFINES += -DGEKKO -DWIIU -DHW_RVL -mwup -mcpu=750 -meabi -mhard-float -DMSB_FIRST
+   ENDIANNESS_DEFINES += -DGEKKO -DWIIU -DHW_RVL -D__wiiu__ -mcpu=750 -meabi -mhard-float -DMSB_FIRST
    FLAGS += -U__INT32_TYPE__ -U __UINT32_TYPE__ -D__INT32_TYPE__=int
 
    EXTRA_INCLUDES := -I$(DEVKITPRO)/libogc/include

bsnes/emulator/emulator.hpp

@@ -34,7 +34,7 @@ namespace Emulator {
   static const string Version   = "115";
   static const string Copyright = "bsnes team";
   static const string License   = "GPLv3 or later";
-  static const string Website   = "https://bsnes.dev";
+  static const string Website   = "https://github.com/bsnes-emu/bsnes/";
 
   //incremented only when serialization format changes
   static const string SerializerVersion = "115.1";

bsnes/gb/.gitattributes

@@ -7,4 +7,5 @@ HexFiend/* linguist-vendored
 Core/*.h linguist-language=C
 SDL/*.h linguist-language=C
 Windows/*.h linguist-language=C
+XdgThumbnailer/*.h linguist-language=C
 Cocoa/*.h linguist-language=Objective-C

bsnes/gb/.github/FUNDING.yml

@@ -0,0 +1,3 @@
+# These are supported funding model platforms
+
+github: LIJI32

bsnes/gb/.github/actions/install_deps.sh

@@ -1,10 +1,10 @@
 case `echo $1 | cut -d '-' -f 1` in
         ubuntu)
                 sudo apt-get -qq update
-                sudo apt-get install -yq bison libpng-dev pkg-config libsdl2-dev
+                sudo apt-get install -yq bison libpng-dev pkg-config libsdl2-dev libgdk-pixbuf2.0-dev
                 (
                 cd `mktemp -d`
-                curl -L https://github.com/rednex/rgbds/archive/v0.4.0.zip > rgbds.zip
+                curl -L https://github.com/rednex/rgbds/archive/v0.6.0.zip > rgbds.zip
                 unzip rgbds.zip
                 cd rgbds-*
                 make -sj
@@ -12,9 +12,22 @@ case `echo $1 | cut -d '-' -f 1` in
                 cd ..
                 rm -rf *
                 )
+                
+                (
+                cd `mktemp -d`
+                curl -L https://github.com/BR903/cppp/archive/refs/heads/master.zip > cppp.zip
+                unzip cppp.zip
+                cd cppp-*
+                make -sj
+                sudo make install
+                cd ..
+                rm -rf *
+                )
+                
+                
                 ;;
         macos)
-                brew install rgbds sdl2
+                brew install rgbds sdl2 cppp
                 ;;
         *)
                 echo "Unsupported OS"

bsnes/gb/.github/actions/sanity_tests.sh

@@ -1,3 +1,5 @@
+#!/bin/sh
+
 set -e
 
 ./build/bin/tester/sameboy_tester --jobs 5 \
@@ -7,7 +9,7 @@ set -e
 --dmg --length 45 .github/actions/dmg_sound-2.gb \
 --dmg --length 20 .github/actions/oam_bug-2.gb
 
-mv .github/actions/dmg{,-mode}-acid2.bmp
+mv .github/actions/dmg-acid2.bmp .github/actions/dmg-mode-acid2.bmp
 
 ./build/bin/tester/sameboy_tester \
 --dmg --length 10  .github/actions/dmg-acid2.gb 
@@ -16,10 +18,10 @@ set +e
 
 FAILED_TESTS=`
 shasum .github/actions/*.bmp | grep -E -v \(\
-5283564df0cf5bb78a7a90aff026c1a4692fd39e\ \ .github/actions/cgb-acid2.bmp\|\
+64c3fd9a5fe9aee40fe15f3371029c0d2f20f5bc\ \ .github/actions/cgb-acid2.bmp\|\
 dbcc438dcea13b5d1b80c5cd06bda2592cc5d9e0\ \ .github/actions/cgb_sound.bmp\|\
 0caadf9634e40247ae9c15ff71992e8f77bbf89e\ \ .github/actions/dmg-acid2.bmp\|\
-a732077f98f43d9231453b1764d9f797a836924d\ \ .github/actions/dmg-mode-acid2.bmp\|\
+fbdb5e342bfdd2edda3ea5601d35d0ca60d18034\ \ .github/actions/dmg-mode-acid2.bmp\|\
 c9e944b7e01078bdeba1819bc2fa9372b111f52d\ \ .github/actions/dmg_sound-2.bmp\|\
 f0172cc91867d3343fbd113a2bb98100074be0de\ \ .github/actions/oam_bug-2.bmp\
 \)`

bsnes/gb/.github/actions/update_libretro.sh

@@ -0,0 +1,30 @@
+set -ex
+
+git fetch --tags
+LATEST=$(git tag --sort=-creatordate | grep "^v" | grep -v libretro | head -n 1)
+
+if [ $(git tag -l "$LATEST"-libretro) ]; then
+    echo "The libretro branch is already up-to-date"
+    exit 0
+fi
+
+git config --global --add --bool push.autoSetupRemote true
+git config --global user.name 'Libretro Updater'
+git config --global user.email '<>'
+
+cp libretro/gitlab-ci.yml .gitlab-ci.yml
+
+echo "Switching to tag $LATEST"
+git branch --delete libretro || true
+git checkout tags/$LATEST -b libretro
+
+echo "Building boot ROMs..."
+make -j bootroms
+
+echo "Updating branch"
+mv build/bin/BootROMs BootROMs/prebuilt
+git add BootROMs/prebuilt/* .gitlab-ci.yml
+git commit -m "Update libretro branch to $LATEST"
+git tag "$LATEST"-libretro
+git push --force
+git push --tags

bsnes/gb/.github/workflows/libretro.yml

@@ -0,0 +1,28 @@
+name: "libretro branch update"
+
+on:
+  push:
+    branches:
+      - master
+
+jobs:
+  libretro-prebuilt-update:
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest]
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v3
+        name: Checkout
+        with:
+          repository: LIJI32/SameBoy
+          token: ${{ secrets.WEBSITETOKEN }}
+          submodules: false
+      - name: Install Deps
+        shell: bash
+        run: |
+          ./.github/actions/install_deps.sh ${{ matrix.os }}
+      - name: Build Boot ROMs and Push
+        run: |
+          ./.github/actions/update_libretro.sh

bsnes/gb/.github/workflows/sanity.yml

@@ -1,36 +1,44 @@
 name: "Bulidability and Sanity"
-on: push
+on:
+  push:
+    branches:
+      - master
+      - '*'
+      - '!libretro'
 
 jobs:
   sanity:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-latest, ubuntu-latest, ubuntu-18.04]
+        os: [macos-latest, ubuntu-latest, ubuntu-22.04]
         cc: [gcc, clang]
         include:
         - os: macos-latest
           cc: clang
-          extra_target: cocoa
+          extra_targets: cocoa ios-ipa ios-deb
         exclude:
         - os: macos-latest
           cc: gcc
     runs-on: ${{ matrix.os }}
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install deps
         shell: bash
         run: |
           ./.github/actions/install_deps.sh ${{ matrix.os }}
       - name: Build
         run: |
-          ${{ matrix.cc }} -v; (make -j sdl tester libretro ${{ matrix.extra_target }} CONF=release CC=${{ matrix.cc }} || (echo "==== Build Failed ==="; make sdl tester libretro ${{ matrix.extra_target }} CONF=release CC=${{ matrix.cc }}))
+          ${{ matrix.cc }} -v; (make -j all CONF=release CC=${{ matrix.cc }} || (echo "==== Build Failed ==="; make all CONF=release CC=${{ matrix.cc }}))
       - name: Sanity tests
         shell: bash
         run: |
           ./.github/actions/sanity_tests.sh
       - name: Upload binaries
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
           name: sameboy-canary-${{ matrix.os }}-${{ matrix.cc }}
-          path: build/bin
+          path: |
+            build/bin
+            build/lib
+            build/include

bsnes/gb/AppleCommon/GBAudioClient.h

@@ -5,8 +5,8 @@
 @property (nonatomic, strong) void (^renderBlock)(UInt32 sampleRate, UInt32 nFrames, GB_sample_t *buffer);
 @property (nonatomic, readonly) UInt32 rate;
 @property (nonatomic, readonly, getter=isPlaying) bool playing;
--(void) start;
--(void) stop;
--(id) initWithRendererBlock:(void (^)(UInt32 sampleRate, UInt32 nFrames, GB_sample_t *buffer)) block
+- (void)start;
+- (void)stop;
+- (id)initWithRendererBlock:(void (^)(UInt32 sampleRate, UInt32 nFrames, GB_sample_t *buffer)) block
               andSampleRate:(UInt32) rate;
 @end

bsnes/gb/AppleCommon/GBAudioClient.m

@@ -23,7 +23,7 @@ static OSStatus render(
     AudioComponentInstance audioUnit;
 }
 
--(id) initWithRendererBlock:(void (^)(UInt32 sampleRate, UInt32 nFrames, GB_sample_t *buffer)) block
+- (id)initWithRendererBlock:(void (^)(UInt32 sampleRate, UInt32 nFrames, GB_sample_t *buffer)) block
               andSampleRate:(UInt32) rate
 {
     if (!(self = [super init])) { 
@@ -35,30 +35,43 @@ static OSStatus render(
     // kAudioUnitSubType_DefaultOutput on Mac OS X)
     AudioComponentDescription defaultOutputDescription;
     defaultOutputDescription.componentType = kAudioUnitType_Output;
+#if TARGET_OS_IPHONE
+    defaultOutputDescription.componentSubType = kAudioUnitSubType_RemoteIO;
+#else
     defaultOutputDescription.componentSubType = kAudioUnitSubType_DefaultOutput;
+#endif
     defaultOutputDescription.componentManufacturer = kAudioUnitManufacturer_Apple;
     defaultOutputDescription.componentFlags = 0;
     defaultOutputDescription.componentFlagsMask = 0;
 
     // Get the default playback output unit
     AudioComponent defaultOutput = AudioComponentFindNext(NULL, &defaultOutputDescription);
-    NSAssert(defaultOutput, @"Can't find default output");
+    if (!defaultOutput) {
+        NSLog(@"Can't find default output");
+        return nil;
+    }
 
     // Create a new unit based on this that we'll use for output
     OSErr err = AudioComponentInstanceNew(defaultOutput, &audioUnit);
-    NSAssert1(audioUnit, @"Error creating unit: %hd", err);
+    if (!audioUnit) {
+        NSLog(@"Error creating unit: %hd", err);
+        return nil;
+    }
 
     // Set our tone rendering function on the unit
     AURenderCallbackStruct input;
     input.inputProc = (void*)render;
-    input.inputProcRefCon = (__bridge void * _Nullable)(self);
+    input.inputProcRefCon = (__bridge void *)(self);
     err = AudioUnitSetProperty(audioUnit,
                                kAudioUnitProperty_SetRenderCallback,
                                kAudioUnitScope_Input,
                                0,
                                &input,
                                sizeof(input));
-    NSAssert1(err == noErr, @"Error setting callback: %hd", err);
+    if (err) {
+        NSLog(@"Error setting callback: %hd", err);
+        return nil;
+    }
 
     AudioStreamBasicDescription streamFormat;
     streamFormat.mSampleRate = rate;
@@ -76,9 +89,16 @@ static OSStatus render(
                                 0,
                                 &streamFormat,
                                 sizeof(AudioStreamBasicDescription));
-    NSAssert1(err == noErr, @"Error setting stream format: %hd", err);
+    
+    if (err) {
+        NSLog(@"Error setting stream format: %hd", err);
+        return nil;
+    }
     err = AudioUnitInitialize(audioUnit);
-    NSAssert1(err == noErr, @"Error initializing unit: %hd", err);
+    if (err) {
+        NSLog(@"Error initializing unit: %hd", err);
+        return nil;
+    }
 
     self.renderBlock = block;
     _rate = rate;
@@ -89,7 +109,10 @@ static OSStatus render(
 -(void) start
 {
     OSErr err = AudioOutputUnitStart(audioUnit);
-    NSAssert1(err == noErr, @"Error starting unit: %hd", err);
+    if (err) {
+        NSLog(@"Error starting unit: %hd", err);
+        return;
+    }
     _playing = true;
 
 }

bsnes/gb/AppleCommon/GBViewBase.h

@@ -0,0 +1,36 @@
+#import <TargetConditionals.h>
+
+#if TARGET_OS_IPHONE
+#define NSView UIView
+#import <UIKit/UIKit.h>
+#else
+#import <Cocoa/Cocoa.h>
+#endif
+
+#import <Core/gb.h>
+
+typedef enum {
+    GB_FRAME_BLENDING_MODE_DISABLED,
+    GB_FRAME_BLENDING_MODE_SIMPLE,
+    GB_FRAME_BLENDING_MODE_ACCURATE,
+    GB_FRAME_BLENDING_MODE_ACCURATE_EVEN = GB_FRAME_BLENDING_MODE_ACCURATE,
+    GB_FRAME_BLENDING_MODE_ACCURATE_ODD,
+} GB_frame_blending_mode_t;
+
+@interface GBViewBase : NSView
+{
+    @public
+    GB_gameboy_t *_gb;
+}
+
+@property (nonatomic) GB_gameboy_t *gb;
+@property (nonatomic) GB_frame_blending_mode_t frameBlendingMode;
+@property (nonatomic, strong) NSView *internalView;
+- (void) flip;
+- (uint32_t *) pixels;
+- (void)screenSizeChanged;
+- (void) createInternalView;
+- (uint32_t *)currentBuffer;
+- (uint32_t *)previousBuffer;
+- (instancetype)mirroredView;
+@end

bsnes/gb/AppleCommon/GBViewBase.m

@@ -0,0 +1,121 @@
+#import "GBViewBase.h"
+
+@implementation GBViewBase
+{
+    uint32_t *_imageBuffers[3];
+    unsigned _currentBuffer;
+    GB_frame_blending_mode_t _frameBlendingMode;
+    bool _oddFrame;
+    GBViewBase *_parent;
+    __weak GBViewBase *_child;
+}
+
+- (void)screenSizeChanged
+{
+    if (_parent) return;
+    if (_imageBuffers[0]) free(_imageBuffers[0]);
+    if (_imageBuffers[1]) free(_imageBuffers[1]);
+    if (_imageBuffers[2]) free(_imageBuffers[2]);
+    
+    size_t buffer_size = sizeof(_imageBuffers[0][0]) * GB_get_screen_width(_gb) * GB_get_screen_height(_gb);
+    
+    _imageBuffers[0] = calloc(1, buffer_size);
+    _imageBuffers[1] = calloc(1, buffer_size);
+    _imageBuffers[2] = calloc(1, buffer_size);
+}
+
+- (void)flip
+{
+    if (_parent) return;
+    _currentBuffer = (_currentBuffer + 1) % self.numberOfBuffers;
+    _oddFrame = GB_is_odd_frame(_gb);
+    [_child flip];
+}
+
+- (unsigned) numberOfBuffers
+{
+    assert(!_parent);
+    return _frameBlendingMode? 3 : 2;
+}
+
+- (void) createInternalView
+{
+    assert(false && "createInternalView must not be inherited");
+}
+
+- (uint32_t *)currentBuffer
+{
+    if (GB_unlikely(_parent)) {
+        return [_parent currentBuffer];
+    }
+    return _imageBuffers[_currentBuffer];
+}
+
+- (uint32_t *)previousBuffer
+{
+    if (GB_unlikely(_parent)) {
+        return [_parent previousBuffer];
+    }
+    return _imageBuffers[(_currentBuffer + 2) % self.numberOfBuffers];
+}
+
+- (uint32_t *) pixels
+{
+    assert(!_parent);
+    return _imageBuffers[(_currentBuffer + 1) % self.numberOfBuffers];
+}
+
+- (void) setFrameBlendingMode:(GB_frame_blending_mode_t)frameBlendingMode
+{
+    _frameBlendingMode = frameBlendingMode;
+    [self setNeedsDisplay];
+    [_child setNeedsDisplay];
+}
+
+- (GB_frame_blending_mode_t)frameBlendingMode
+{
+    if (GB_unlikely(_parent)) {
+        return [_parent frameBlendingMode];
+    }
+    if (_frameBlendingMode == GB_FRAME_BLENDING_MODE_ACCURATE) {
+        if (!_gb || GB_is_sgb(_gb)) {
+            return GB_FRAME_BLENDING_MODE_SIMPLE;
+        }
+        return _oddFrame ? GB_FRAME_BLENDING_MODE_ACCURATE_ODD : GB_FRAME_BLENDING_MODE_ACCURATE_EVEN;
+    }
+    return _frameBlendingMode;
+}
+
+- (void)dealloc
+{
+    if (_parent) return;
+    free(_imageBuffers[0]);
+    free(_imageBuffers[1]);
+    free(_imageBuffers[2]);
+}
+
+#if !TARGET_OS_IPHONE
+- (void)setNeedsDisplay
+{
+    [self setNeedsDisplay:true];
+}
+#endif
+
+- (void)setGb:(GB_gameboy_t *)gb
+{
+    assert(!_parent);
+    _gb = gb;
+    if (_child) {
+        _child->_gb = gb;
+    }
+}
+
+- (instancetype)mirroredView
+{
+    if (_child) return _child;
+    GBViewBase *ret = [[self.class alloc] initWithFrame:self.bounds];
+    ret->_parent = self;
+    ret->_gb = _gb;
+    return _child = ret;
+}
+@end

bsnes/gb/AppleCommon/GBViewMetal.h

@@ -0,0 +1,11 @@
+#import <TargetConditionals.h>
+#import <MetalKit/MetalKit.h>
+#if TARGET_OS_IPHONE
+#import "../iOS/GBView.h"
+#else
+#import "../Cocoa/GBView.h"
+#endif
+
+@interface GBViewMetal : GBView<MTKViewDelegate>
++ (bool) isSupported;
+@end

bsnes/gb/AppleCommon/GBViewMetal.m

@@ -1,7 +1,9 @@
 #import <CoreImage/CoreImage.h>
 #import "GBViewMetal.h"
 #pragma clang diagnostic ignored "-Wpartial-availability"
-
+#if !TARGET_OS_IPHONE
+#import "../Cocoa/NSObject+DefaultsObserver.h"
+#endif
 
 static const vector_float2 rect[] =
 {
@@ -13,27 +15,33 @@ static const vector_float2 rect[] =
 
 @implementation GBViewMetal
 {
-    id<MTLDevice> device;
-    id<MTLTexture> texture, previous_texture;
-    id<MTLBuffer> vertices;
-    id<MTLRenderPipelineState> pipeline_state;
-    id<MTLCommandQueue> command_queue;
-    id<MTLBuffer> frame_blending_mode_buffer;
-    id<MTLBuffer> output_resolution_buffer;
-    vector_float2 output_resolution;
+    id<MTLDevice> _device;
+    id<MTLTexture> _texture, _previousTexture;
+    id<MTLBuffer> _vertices;
+    id<MTLRenderPipelineState> _pipelineState;
+    id<MTLCommandQueue> _commandQueue;
+    id<MTLBuffer> _frameBlendingModeBuffer;
+    id<MTLBuffer> _outputResolutionBuffer;
+    vector_float2 _outputResolution;
+    id<MTLCommandBuffer> _commandBuffer;
+    bool _waitedForFrame;
+    _Atomic unsigned _pendingFrames;
 }
 
 + (bool)isSupported
 {
+#if TARGET_OS_IPHONE
+    return true;
+#else
     if (MTLCopyAllDevices) {
         return [MTLCopyAllDevices() count];
     }
     return false;
+#endif
 }
-
 - (void) allocateTextures
 {
-    if (!device) return;
+    if (!_device) return;
     
     MTLTextureDescriptor *texture_descriptor = [[MTLTextureDescriptor alloc] init];
     
@@ -42,39 +50,44 @@ static const vector_float2 rect[] =
     texture_descriptor.width = GB_get_screen_width(self.gb);
     texture_descriptor.height = GB_get_screen_height(self.gb);
     
-    texture = [device newTextureWithDescriptor:texture_descriptor];
-    previous_texture = [device newTextureWithDescriptor:texture_descriptor];
+    _texture = [_device newTextureWithDescriptor:texture_descriptor];
+    _previousTexture = [_device newTextureWithDescriptor:texture_descriptor];
 
 }
 
 - (void)createInternalView
 {
-    MTKView *view = [[MTKView alloc] initWithFrame:self.frame device:(device = MTLCreateSystemDefaultDevice())];
+    MTKView *view = [[MTKView alloc] initWithFrame:self.frame device:(_device = MTLCreateSystemDefaultDevice())];
     view.delegate = self;
     self.internalView = view;
     view.paused = true;
     view.enableSetNeedsDisplay = true;
     view.framebufferOnly = false;
     
-    vertices = [device newBufferWithBytes:rect
+    _vertices = [_device newBufferWithBytes:rect
                                    length:sizeof(rect)
                                   options:MTLResourceStorageModeShared];
     
     static const GB_frame_blending_mode_t default_blending_mode = GB_FRAME_BLENDING_MODE_DISABLED;
-    frame_blending_mode_buffer = [device newBufferWithBytes:&default_blending_mode
+    _frameBlendingModeBuffer = [_device newBufferWithBytes:&default_blending_mode
                                           length:sizeof(default_blending_mode)
                                          options:MTLResourceStorageModeShared];
     
-    output_resolution_buffer = [device newBufferWithBytes:&output_resolution
-                                                   length:sizeof(output_resolution)
+    _outputResolutionBuffer = [_device newBufferWithBytes:&_outputResolution
+                                                   length:sizeof(_outputResolution)
                                                   options:MTLResourceStorageModeShared];
     
-    output_resolution = (simd_float2){view.drawableSize.width, view.drawableSize.height};
+    _outputResolution = (simd_float2){view.drawableSize.width, view.drawableSize.height};
+    /* TODO: NSObject+DefaultsObserver can replace the less flexible `addDefaultObserver` in iOS */
+#if TARGET_OS_IPHONE
     [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(loadShader) name:@"GBFilterChanged" object:nil];
     [self loadShader];
+#else
+    [self observeStandardDefaultsKey:@"GBFilter" selector:@selector(loadShader)];
+#endif
 }
 
-- (void) loadShader
+- (void)loadShader
 {
     NSError *error = nil;
     NSString *shader_source = [NSString stringWithContentsOfFile:[[NSBundle mainBundle] pathForResource:@"MasterShader"
@@ -95,7 +108,7 @@ static const vector_float2 rect[] =
 
     MTLCompileOptions *options = [[MTLCompileOptions alloc] init];
     options.fastMathEnabled = true;
-    id<MTLLibrary> library = [device newLibraryWithSource:shader_source
+    id<MTLLibrary> library = [_device newLibraryWithSource:shader_source
                                                    options:options
                                                      error:&error];
     if (error) {
@@ -115,19 +128,19 @@ static const vector_float2 rect[] =
     pipeline_state_descriptor.colorAttachments[0].pixelFormat = ((MTKView *)self.internalView).colorPixelFormat;
     
     error = nil;
-    pipeline_state = [device newRenderPipelineStateWithDescriptor:pipeline_state_descriptor
+    _pipelineState = [_device newRenderPipelineStateWithDescriptor:pipeline_state_descriptor
                                                              error:&error];
     if (error)  {
         NSLog(@"Failed to created pipeline state, error %@", error);
         return;
     }
     
-    command_queue = [device newCommandQueue];
+    _commandQueue = [_device newCommandQueue];
 }
 
 - (void)mtkView:(MTKView *)view drawableSizeWillChange:(CGSize)size
 {
-    output_resolution = (vector_float2){size.width, size.height};
+    _outputResolution = (vector_float2){size.width, size.height};
     dispatch_async(dispatch_get_main_queue(), ^{
         [(MTKView *)self.internalView draw];
     });
@@ -135,90 +148,110 @@ static const vector_float2 rect[] =
 
 - (void)drawInMTKView:(MTKView *)view
 {
+#if !TARGET_OS_IPHONE
     if (!(view.window.occlusionState & NSWindowOcclusionStateVisible)) return;
+#endif
     if (!self.gb) return;
-    if (texture.width  != GB_get_screen_width(self.gb) ||
-        texture.height != GB_get_screen_height(self.gb)) {
+    if (_texture.width  != GB_get_screen_width(self.gb) ||
+        _texture.height != GB_get_screen_height(self.gb)) {
         [self allocateTextures];
     }
     
     MTLRegion region = {
         {0, 0, 0},         // MTLOrigin
-        {texture.width, texture.height, 1} // MTLSize
+        {_texture.width, _texture.height, 1} // MTLSize
     };
+    
+    /* Don't start rendering if the previous frame hasn't finished yet. Either wait, or skip the frame */
+    if (_commandBuffer && _commandBuffer.status != MTLCommandBufferStatusCompleted) {
+        if (_waitedForFrame) return;
+        [_commandBuffer waitUntilCompleted];
+        _waitedForFrame = true;
+    }
+    else {
+        _waitedForFrame = false;
+    }
 
-    [texture replaceRegion:region
+    GB_frame_blending_mode_t mode = [self frameBlendingMode];
+    
+    [_texture replaceRegion:region
                mipmapLevel:0
                  withBytes:[self currentBuffer]
-               bytesPerRow:texture.width * 4];
-    if ([self frameBlendingMode]) {
-        [previous_texture replaceRegion:region
+               bytesPerRow:_texture.width * 4];
+
+    if (mode) {
+        [_previousTexture replaceRegion:region
                             mipmapLevel:0
                               withBytes:[self previousBuffer]
-                            bytesPerRow:texture.width * 4];
+                            bytesPerRow:_texture.width * 4];
     }
-    
-    MTLRenderPassDescriptor *render_pass_descriptor = view.currentRenderPassDescriptor;
-    id<MTLCommandBuffer> command_buffer = [command_queue commandBuffer];
-
-    if (render_pass_descriptor != nil) { 
-        *(GB_frame_blending_mode_t *)[frame_blending_mode_buffer contents] = [self frameBlendingMode];
-        *(vector_float2 *)[output_resolution_buffer contents] = output_resolution;
-
-        id<MTLRenderCommandEncoder> render_encoder =
-            [command_buffer renderCommandEncoderWithDescriptor:render_pass_descriptor];
         
-        [render_encoder setViewport:(MTLViewport){0.0, 0.0,
-            output_resolution.x,
-            output_resolution.y,
+    MTLRenderPassDescriptor *renderPassDescriptor = view.currentRenderPassDescriptor;
+    _commandBuffer = [_commandQueue commandBuffer];
+
+    if (renderPassDescriptor) {
+        *(GB_frame_blending_mode_t *)[_frameBlendingModeBuffer contents] = mode;
+        *(vector_float2 *)[_outputResolutionBuffer contents] = _outputResolution;
+
+        id<MTLRenderCommandEncoder> renderEncoder =
+            [_commandBuffer renderCommandEncoderWithDescriptor:renderPassDescriptor];
+        
+        [renderEncoder setViewport:(MTLViewport){0.0, 0.0,
+            _outputResolution.x,
+            _outputResolution.y,
             -1.0, 1.0}];
         
-        [render_encoder setRenderPipelineState:pipeline_state];
+        [renderEncoder setRenderPipelineState:_pipelineState];
         
-        [render_encoder setVertexBuffer:vertices
+        [renderEncoder setVertexBuffer:_vertices
                                  offset:0
                                 atIndex:0];
         
-        [render_encoder setFragmentBuffer:frame_blending_mode_buffer
+        [renderEncoder setFragmentBuffer:_frameBlendingModeBuffer
                                    offset:0
                                   atIndex:0];
         
-        [render_encoder setFragmentBuffer:output_resolution_buffer
+        [renderEncoder setFragmentBuffer:_outputResolutionBuffer
                                    offset:0
                                   atIndex:1];
         
-        [render_encoder setFragmentTexture:texture
+        [renderEncoder setFragmentTexture:_texture
                                   atIndex:0];
         
-        [render_encoder setFragmentTexture:previous_texture
+        [renderEncoder setFragmentTexture:_previousTexture
                                    atIndex:1];
         
-        [render_encoder drawPrimitives:MTLPrimitiveTypeTriangleStrip
+        [renderEncoder drawPrimitives:MTLPrimitiveTypeTriangleStrip
                           vertexStart:0
                           vertexCount:4];
         
-        [render_encoder endEncoding];
+        [renderEncoder endEncoding];
         
-        [command_buffer presentDrawable:view.currentDrawable];
+        [_commandBuffer presentDrawable:view.currentDrawable];
     }
     
     
-    [command_buffer commit];
+    [_commandBuffer commit];
 }
 
 - (void)flip
 {
     [super flip];
+    if (_pendingFrames == 2) return;
+    _pendingFrames++;
     dispatch_async(dispatch_get_main_queue(), ^{
-        [(MTKView *)self.internalView setNeedsDisplay:true];
+        [(MTKView *)self.internalView draw];
+        _pendingFrames--;
     });
 }
 
+#if !TARGET_OS_IPHONE
 - (NSImage *)renderToImage
 {
     CIImage *ciImage = [CIImage imageWithMTLTexture:[[(MTKView *)self.internalView currentDrawable] texture]
                                             options:@{
-                                                kCIImageColorSpace: (__bridge_transfer id)CGColorSpaceCreateDeviceRGB()
+                                                kCIImageColorSpace: (__bridge_transfer id)CGColorSpaceCreateDeviceRGB(),
+                                                kCIImageProperties: [NSNull null]
                                             }];
     ciImage = [ciImage imageByApplyingTransform:CGAffineTransformTranslate(CGAffineTransformMakeScale(1, -1),
                                                                            0, ciImage.extent.size.height)];
@@ -228,5 +261,6 @@ static const vector_float2 rect[] =
     CGImageRelease(cgImage);
     return ret;
 }
+#endif
 
 @end

bsnes/gb/BESS.md

@@ -22,9 +22,9 @@ BESS works by appending a detectable footer at the end of an existing save state
 BESS uses a block format where each block contains the following header:
 
 | Offset | Content                               |
-|--------|---------------------------------------|
-| 0      | A four-letter ASCII identifier        |
-| 4      | Length of the block, excluding header |
+|--------|-----------------------------------------------------------|
+| 0      | A four-letter ASCII identifier                            |
+| 4      | Length of the block as a 32-bit integer, excluding header |
 
 Every block is followed by another block, until the END block is reached. If an implementation encounters an unsupported block, it should be completely ignored (Should not have any effect and should not trigger a failure). 
 
@@ -89,7 +89,7 @@ The values of memory-mapped registers should be written 'as-is' to memory as if
 * Unused register bits have Don't-Care values which should be ignored
 * If the model is CGB or newer, the value of KEY0 (FF4C) must be valid as it determines DMG mode
     * Bit 2 determines DMG mode. A value of 0x04 usually denotes DMG mode, while a value of `0x80` usually denotes CGB mode.
-* Sprite priority is derived from KEY0 (FF4C) instead of OPRI (FF6C) because OPRI can be modified after booting, but only the value of OPRI during boot ROM execution takes effect
+* Object priority is derived from KEY0 (FF4C) instead of OPRI (FF6C) because OPRI can be modified after booting, but only the value of OPRI during boot ROM execution takes effect
 * If a register doesn't exist on the emulated model (For example, KEY0 (FF4C) on a DMG), its value should be ignored.
 * BANK (FF50) should be 0 if the boot ROM is still mapped, and 1 otherwise, and must be valid.
 * Implementations should not start a serial transfer when writing the value of SB
@@ -176,6 +176,48 @@ The length of this block is 0x11 bytes long and it follows the following structu
 | 0x0E   | Scheduled alarm time days (16-bit)                    |
 | 0x10   | Alarm enabled flag (8-bits, either 0 or 1)            |
 
+#### TPP1 block
+The TPP1 block uses the `'TPP1'` identifier, and is an optional block that is used while emulating a TPP1 cartridge to store RTC information. This block can be omitted if the ROM header does not specify the inclusion of a RTC.
+
+The length of this block is 0x11 bytes long and it follows the following structure:
+
+| Offset | Content                                               |
+|--------|-------------------------------------------------------|
+| 0x00   | UNIX timestamp at the time of the save state (64-bit) |
+| 0x08   | The current RTC data (4 bytes)                        |
+| 0x0C   | The latched RTC data (4 bytes)                        |
+| 0x10   | The value of the MR4 register (8-bits)                |
+
+
+#### MBC7 block
+The MBC7 block uses the `'MBC7'` identifier, and is an optional block that is used while emulating an MBC7 cartridge to store the EEPROM communication state and motion control state.
+
+The length of this block is 0xA bytes long and it follows the following structure:
+
+| Offset | Content                                               |
+|--------|-------------------------------------------------------|
+| 0x00   | Flags (8-bits)                                        |
+| 0x01   | Argument bits left (8-bits)                           |
+| 0x02   | Current EEPROM command (16-bits)                      |
+| 0x04   | Pending bits to read (16-bits)                        |
+| 0x06   | Latched gyro X value (16-bits)                        |
+| 0x08   | Latched gyro Y value (16-bits)                        |
+
+The meaning of the individual bits in flags are:
+ * Bit 0: Latch ready; set after writing `0x55` to `0xAX0X` and reset after writing `0xAA` to `0xAX1X`
+ * Bit 1: EEPROM DO line
+ * Bit 2: EEPROM DI line
+ * Bit 3: EEPROM CLK line
+ * Bit 4: EEPROM CS line
+ * Bit 5: EEPROM write enable; set after an `EWEN` command, reset after an `EWDS` command
+ * Bits 6-7: Unused.
+
+The current EEPROM command field has bits pushed to its LSB first, padded with zeros. For example, if the ROM clocked a single `1` bit, this field should contain `0b1`; if the ROM later clocks a `0` bit, this field should contain `0b10`.
+
+If the currently transmitted command has an argument, the "Argument bits left" field should contain the number argument bits remaining. Otherwise, it should contain 0.
+
+The "Pending bits to read" field contains the pending bits waiting to be shifted into the DO signal, MSB first, padded with ones.
+
 #### SGB block
 
 The SGB block uses the `'SGB '` identifier, and is an optional block that is only used while emulating an SGB or SGB2 *and* SGB commands enabled. Implementations must not save this block on other models or when SGB commands are disabled, and should assume SGB commands are disabled if this block is missing.
@@ -214,4 +256,4 @@ Other than previously specified required fail conditions, an implementation is f
 * An invalid length of MBC (not a multiple of 3)
 * A write outside the $0000-$7FFF and $A000-$BFFF ranges in the MBC block
 * An SGB block on a save state targeting another model
-* An END block with non-zero length
+* An END block with non-zero length

bsnes/gb/BootROMs/agb_boot.asm

@@ -1,2 +1,2 @@
-AGB EQU 1
-include "cgb_boot.asm"
+DEF AGB = 1
+include "cgb_boot.asm"

bsnes/gb/BootROMs/cgb0_boot.asm

@@ -0,0 +1,2 @@
+DEF CGB0 = 1
+include "cgb_boot.asm"

bsnes/gb/BootROMs/cgb_boot_fast.asm

@@ -1,2 +1,2 @@
-FAST EQU 1
-include "cgb_boot.asm"
+DEF FAST = 1
+include "cgb_boot.asm"

bsnes/gb/BootROMs/dmg_boot.asm

@@ -1,12 +1,15 @@
 ; SameBoy DMG bootstrap ROM
-; Todo: use friendly names for HW registers instead of magic numbers
-SECTION "BootCode", ROM0[$0]
+
+include "sameboot.inc"
+
+SECTION "BootCode", ROM0[$0000]
 Start:
 ; Init stack pointer
-    ld sp, $fffe
+    ld sp, $FFFE
 
 ; Clear memory VRAM
-    ld hl, $8000
+    ld hl, _VRAM
+    xor a
 
 .clearVRAMLoop
     ldi [hl], a
@@ -14,24 +17,25 @@ Start:
     jr z, .clearVRAMLoop
 
 ; Init Audio
-    ld a, $80
-    ldh [$26], a
-    ldh [$11], a
-    ld a, $f3
-    ldh [$12], a
-    ldh [$25], a
+    ld a, AUDENA_ON
+    ldh [rNR52], a
+    assert AUDENA_ON == AUDLEN_DUTY_50
+    ldh [rNR11], a
+    ld a, $F3
+    ldh [rNR12], a ; Envelope $F, decreasing, sweep $3
+    ldh [rNR51], a ; Channels 1+2+3+4 left, channels 1+2 right
     ld a, $77
-    ldh [$24], a
+    ldh [rNR50], a ; Volume $7, left and right
 
 ; Init BG palette
-    ld a, $54
-    ldh [$47], a
+    ld a, %01_01_01_00
+    ldh [rBGP], a
 
 ; Load logo from ROM.
 ; A nibble represents a 4-pixels line, 2 bytes represent a 4x4 tile, scaled to 8x8.
 ; Tiles are ordered left to right, top to bottom.
-    ld de, $104 ; Logo start
-    ld hl, $8010 ; This is where we load the tiles in VRAM
+    ld de, NintendoLogo
+    ld hl, _VRAM + $10 ; This is where we load the tiles in VRAM
 
 .loadLogoLoop
     ld a, [de] ; Read 2 rows
@@ -40,88 +44,92 @@ Start:
     call DoubleBitsAndWriteRow
     inc de
     ld a, e
-    xor $34 ; End of logo
+    xor LOW(NintendoLogoEnd)
     jr nz, .loadLogoLoop
 
 ; Load trademark symbol
     ld de, TrademarkSymbol
-    ld c,$08
+    ld c, TrademarkSymbolEnd - TrademarkSymbol
 .loadTrademarkSymbolLoop:
-    ld a,[de]
+    ld a, [de]
     inc de
-    ldi [hl],a
+    ldi [hl], a
     inc hl
     dec c
     jr nz, .loadTrademarkSymbolLoop
 
 ; Set up tilemap
-    ld a,$19      ; Trademark symbol
-    ld [$9910], a ; ... put in the superscript position
-    ld hl,$992f   ; Bottom right corner of the logo
-    ld c,$c       ; Tiles in a logo row
+    ld a, $19                           ; Trademark symbol tile ID
+    ld [_SCRN0 + 8 * SCRN_VX_B + 16], a ; ... put in the superscript position
+    ld hl, _SCRN0 + 9 * SCRN_VX_B + 15  ; Bottom right corner of the logo
+    ld c, 12                            ; Tiles in a logo row
 .tilemapLoop
     dec a
     jr z, .tilemapDone
     ldd [hl], a
     dec c
     jr nz, .tilemapLoop
-    ld l,$0f ; Jump to top row
+    ld l, $0F ; Jump to top row
     jr .tilemapLoop
 .tilemapDone
 
     ld a, 30
-    ldh [$ff42], a
-    
-    ; Turn on LCD
-    ld a, $91
-    ldh [$40], a
+    ldh [rSCY], a
 
-    ld d, (-119) & $FF
+    ; Turn on LCD
+    ld a, LCDCF_ON | LCDCF_BLK01 | LCDCF_BGON
+    ldh [rLCDC], a
+
+    ld d, LOW(-119)
     ld c, 15
-    
+
 .animate
     call WaitFrame
     ld a, d
     sra a
     sra a
-    ldh [$ff42], a
+    ldh [rSCY], a
     ld a, d
     add c
     ld d, a
     ld a, c
     cp 8
     jr nz, .noPaletteChange
-    ld a, $A8
-    ldh [$47], a
+    ld a, %10_10_10_00
+    ldh [rBGP], a
 .noPaletteChange
     dec c
     jr nz, .animate
-    ld a, $fc
-    ldh [$47], a
-    
+    ld a, %11_11_11_00
+    ldh [rBGP], a
+
     ; Play first sound
     ld a, $83
     call PlaySound
     ld b, 5
     call WaitBFrames
     ; Play second sound
-    ld a, $c1
+    ld a, $C1
     call PlaySound
-    
+
 
 
 ; Wait ~1 second
     ld b, 60
     call WaitBFrames
-    
+
 ; Set registers to match the original DMG boot
-    ld hl, $01B0
+IF DEF(MGB)
+    lb hl, BOOTUP_A_MGB, %10110000
+ELSE
+    lb hl, BOOTUP_A_DMG, %10110000
+ENDC
     push hl
     pop af
-    ld hl, $014D
-    ld bc, $0013
-    ld de, $00D8
-    
+    ld hl, HeaderChecksum
+    lb bc, 0, LOW(rNR13) ; $0013
+    lb de, 0, $D8        ; $00D8
+
 ; Boot the game
     jp BootGame
 
@@ -148,7 +156,7 @@ DoubleBitsAndWriteRow:
 
 WaitFrame:
     push hl
-    ld hl, $FF0F
+    ld hl, rIF
     res 0, [hl]
 .wait
     bit 0, [hl]
@@ -163,15 +171,26 @@ WaitBFrames:
     ret
 
 PlaySound:
-    ldh [$13], a
-    ld a, $87
-    ldh [$14], a
+    ldh [rNR13], a
+    ld a, AUDHIGH_RESTART | $7
+    ldh [rNR14], a
     ret
 
 
 TrademarkSymbol:
-db $3c,$42,$b9,$a5,$b9,$a5,$42,$3c
+    pusho
+    opt b.X
+    db %..XXXX..
+    db %.X....X.
+    db %X.XXX..X
+    db %X.X..X.X
+    db %X.XXX..X
+    db %X.X..X.X
+    db %.X....X.
+    db %..XXXX..
+    popo
+TrademarkSymbolEnd:
 
-SECTION "BootGame", ROM0[$fe]
+SECTION "BootGame", ROM0[$00FE]
 BootGame:
-    ldh [$50], a
+    ldh [rBANK], a ; unmap boot ROM

bsnes/gb/BootROMs/mgb_boot.asm

@@ -0,0 +1,2 @@
+DEF MGB = 1
+include "dmg_boot.asm"

bsnes/gb/BootROMs/pb12.c

@@ -5,7 +5,7 @@
 #include <unistd.h>
 #include <assert.h>
 
-void opts(uint8_t byte, uint8_t *options)
+static void opts(uint8_t byte, uint8_t *options)
 {
     *(options++) = byte | ((byte << 1) & 0xff);
     *(options++) = byte & (byte << 1);
@@ -13,7 +13,7 @@ void opts(uint8_t byte, uint8_t *options)
     *(options++) = byte & (byte >> 1);
 }
 
-void write_all(int fd, const void *buf, size_t count) {
+static void write_all(int fd, const void *buf, size_t count) {
     while (count) {
         ssize_t written = write(fd, buf, count);
         if (written < 0) {
@@ -25,7 +25,7 @@ void write_all(int fd, const void *buf, size_t count) {
     }
 }
 
-int main()
+int main(void)
 {
     static uint8_t source[0x4000];
     size_t size = read(STDIN_FILENO, &source, sizeof(source));
@@ -87,7 +87,7 @@ int main()
         prev[1] = byte;
         if (bits >= 8) {
             uint8_t outctl = control >> (bits - 8);
-            assert(outctl != 1);
+            assert(outctl != 1); // 1 is reserved as the end byte
             write_all(STDOUT_FILENO, &outctl, 1);
             write_all(STDOUT_FILENO, literals, literals_size);
             bits -= 8;

bsnes/gb/BootROMs/sameboot.inc

@@ -0,0 +1,40 @@
+IF !DEF(SAMEBOY_INC)
+DEF SAMEBOY_INC EQU 1
+
+include "hardware.inc"
+
+DEF rKEY0 EQU $FF4C
+DEF rBANK EQU $FF50
+
+DEF rJOYP EQU rP1
+
+
+MACRO lb ; r16, high, low
+    ld \1, LOW(\2) << 8 | LOW(\3)
+ENDM
+
+
+MACRO header_section ; name, address
+    PUSHS
+    SECTION "\1", ROM0[\2]
+    \1:
+    POPS
+ENDM
+    header_section EntryPoint,       $0100
+    header_section NintendoLogo,     $0104
+    header_section NintendoLogoEnd,  $0134
+    header_section Title,            $0134
+    header_section ManufacturerCode, $013F
+    header_section CGBFlag,          $0143
+    header_section NewLicenseeCode,  $0144
+    header_section SGBFlag,          $0146
+    header_section CartridgeType,    $0147
+    header_section ROMSize,          $0148
+    header_section RAMSize,          $0149
+    header_section DestinationCode,  $014A
+    header_section OldLicenseeCode,  $014B
+    header_section MaskRomVersion,   $014C
+    header_section HeaderChecksum,   $014D
+    header_section GlobalChecksum,   $014E
+
+ENDC

bsnes/gb/BootROMs/sgb2_boot.asm

@@ -1,2 +1,2 @@
-SGB2 EQU 1
-include "sgb_boot.asm"
+DEF SGB2 = 1
+include "sgb_boot.asm"

bsnes/gb/BootROMs/sgb_boot.asm

@@ -1,12 +1,15 @@
 ; SameBoy SGB bootstrap ROM
-; Todo: use friendly names for HW registers instead of magic numbers
-SECTION "BootCode", ROM0[$0]
+
+include "sameboot.inc"
+
+SECTION "BootCode", ROM0[$0000]
 Start:
 ; Init stack pointer
-    ld sp, $fffe
+    ld sp, $FFFE
 
 ; Clear memory VRAM
-    ld hl, $8000
+    ld hl, _VRAM
+    xor a
 
 .clearVRAMLoop
     ldi [hl], a
@@ -14,24 +17,25 @@ Start:
     jr z, .clearVRAMLoop
 
 ; Init Audio
-    ld a, $80
-    ldh [$26], a
-    ldh [$11], a
-    ld a, $f3
-    ldh [$12], a
-    ldh [$25], a
+    ld a, AUDENA_ON
+    ldh [rNR52], a
+    assert AUDENA_ON == AUDLEN_DUTY_50
+    ldh [rNR11], a
+    ld a, $F3
+    ldh [rNR12], a ; Envelope $F, decreasing, sweep $3
+    ldh [rNR51], a ; Channels 1+2+3+4 left, channels 1+2 right
     ld a, $77
-    ldh [$24], a
+    ldh [rNR50], a ; Volume $7, left and right
 
 ; Init BG palette to white
-    ld a, $0
-    ldh [$47], a
+    ld a, %00_00_00_00
+    ldh [rBGP], a
 
 ; Load logo from ROM.
 ; A nibble represents a 4-pixels line, 2 bytes represent a 4x4 tile, scaled to 8x8.
 ; Tiles are ordered left to right, top to bottom.
-    ld de, $104 ; Logo start
-    ld hl, $8010 ; This is where we load the tiles in VRAM
+    ld de, NintendoLogo
+    ld hl, _VRAM + $10 ; This is where we load the tiles in VRAM
 
 .loadLogoLoop
     ld a, [de] ; Read 2 rows
@@ -40,111 +44,124 @@ Start:
     call DoubleBitsAndWriteRow
     inc de
     ld a, e
-    xor $34 ; End of logo
+    xor LOW(NintendoLogoEnd)
     jr nz, .loadLogoLoop
 
 ; Load trademark symbol
     ld de, TrademarkSymbol
-    ld c,$08
+    ld c, TrademarkSymbolEnd - TrademarkSymbol
 .loadTrademarkSymbolLoop:
-    ld a,[de]
+    ld a, [de]
     inc de
-    ldi [hl],a
+    ldi [hl], a
     inc hl
     dec c
     jr nz, .loadTrademarkSymbolLoop
 
 ; Set up tilemap
-    ld a,$19      ; Trademark symbol
-    ld [$9910], a ; ... put in the superscript position
-    ld hl,$992f   ; Bottom right corner of the logo
-    ld c,$c       ; Tiles in a logo row
+    ld a, $19                           ; Trademark symbol tile ID
+    ld [_SCRN0 + 8 * SCRN_VX_B + 16], a ; ... put in the superscript position
+    ld hl, _SCRN0 + 9 * SCRN_VX_B + 15  ; Bottom right corner of the logo
+    ld c, 12                            ; Tiles in a logo row
 .tilemapLoop
     dec a
     jr z, .tilemapDone
     ldd [hl], a
     dec c
     jr nz, .tilemapLoop
-    ld l,$0f ; Jump to top row
+    ld l, $0F ; Jump to top row
     jr .tilemapLoop
 .tilemapDone
 
     ; Turn on LCD
-    ld a, $91
-    ldh [$40], a
+    ld a, LCDCF_ON | LCDCF_BLK01 | LCDCF_BGON
+    ldh [rLCDC], a
+
+    ld a, $F1 ; Packet magic, increases by 2 for every packet
+    ldh [hCommand], a
+    ld hl, NintendoLogo ; Header start
 
-    ld a, $f1 ; Packet magic, increases by 2 for every packet
-    ldh [$80], a
-    ld hl, $104 ; Header start
-    
     xor a
     ld c, a ; JOYP
 
 .sendCommand
     xor a
-    ld [c], a
+    ldh [c], a
     ld a, $30
-    ld [c], a
-    
-    ldh a, [$80]
+    ldh [c], a
+
+    ldh a, [hCommand]
     call SendByte
     push hl
-    ld b, $e
+
+    ld b, 14
     ld d, 0
-    
 .checksumLoop
     call ReadHeaderByte
     add d
     ld d, a
     dec b
     jr nz, .checksumLoop
-    
+
     ; Send checksum
     call SendByte
     pop hl
-    
-    ld b, $e
+
+    ld b, 14
 .sendLoop
     call ReadHeaderByte
     call SendByte
     dec b
     jr nz, .sendLoop
-    
+
     ; Done bit
     ld a, $20
-    ld [c], a
+    ldh [c], a
     ld a, $30
-    ld [c], a
-    
+    ldh [c], a
+
+    ; Wait 4 frames
+    ld e, 4
+    ld a, 1
+    ldh [rIE], a
+    xor a
+.waitLoop
+    ldh [rIF], a
+    halt
+    nop
+    dec e
+    jr nz, .waitLoop
+    ldh [rIE], a
+
     ; Update command
-    ldh a, [$80]
+    ldh a, [hCommand]
     add 2
-    ldh [$80], a
-    
+    ldh [hCommand], a
+
     ld a, $58
     cp l
     jr nz, .sendCommand
-    
+
     ; Write to sound registers for DMG compatibility
-    ld c, $13
-    ld a, $c1
-    ld [c], a
+    ld c, LOW(rNR13)
+    ld a, $C1
+    ldh [c], a
     inc c
-    ld a, 7
-    ld [c], a
-    
+    ld a, $7
+    ldh [c], a
+
     ; Init BG palette
-    ld a, $fc
-    ldh [$47], a
-    
+    ld a, %11_11_11_00
+    ldh [rBGP], a
+
 ; Set registers to match the original SGB boot
 IF DEF(SGB2)
-    ld a, $FF
+    ld a, BOOTUP_A_MGB
 ELSE
-    ld a, 1
+    ld a, BOOTUP_A_DMG
 ENDC
-    ld hl, $c060
-    
+    ld hl, $C060
+
 ; Boot the game
     jp BootGame
 
@@ -168,9 +185,9 @@ SendByte:
     jr c, .zeroBit
     add a ; 10 -> 20
 .zeroBit
-    ld [c], a
+    ldh [c], a
     ld a, $30
-    ld [c], a
+    ldh [c], a
     dec d
     ret z
     jr .loop
@@ -195,19 +212,24 @@ DoubleBitsAndWriteRow:
     inc hl
     ret
 
-WaitFrame:
-    push hl
-    ld hl, $FF0F
-    res 0, [hl]
-.wait
-    bit 0, [hl]
-    jr z, .wait
-    pop hl
-    ret
-
 TrademarkSymbol:
-db $3c,$42,$b9,$a5,$b9,$a5,$42,$3c
+    pusho
+    opt b.X
+    db %..XXXX..
+    db %.X....X.
+    db %X.XXX..X
+    db %X.X..X.X
+    db %X.XXX..X
+    db %X.X..X.X
+    db %.X....X.
+    db %..XXXX..
+    popo
+TrademarkSymbolEnd:
 
-SECTION "BootGame", ROM0[$fe]
+SECTION "BootGame", ROM0[$00FE]
 BootGame:
-    ldh [$50], a
+    ldh [rBANK], a
+
+SECTION "HRAM", HRAM[_HRAM]
+hCommand:
+    ds 1

bsnes/gb/CONTRIBUTING.md

@@ -24,7 +24,7 @@ SameBoy's main target compiler is Clang, but GCC is also supported when targetin
 
 ### Third Party Libraries and Tools
 
-Avoid adding new required dependencies; run-time and compile-time dependencies alike. Most importantly, avoid linking against GPL licensed libraries (LGPL libraries are fine), so SameBoy can retain its MIT license.
+Avoid adding new required dependencies; run-time and compile-time dependencies alike. Most importantly, avoid linking against GPL licensed libraries (LGPL libraries are fine), so SameBoy can retain its Expat license.
 
 ### Spacing, Indentation and Formatting
 

bsnes/gb/Cocoa/AppDelegate.m

@@ -1,449 +0,0 @@
-#import "AppDelegate.h"
-#include "GBButtons.h"
-#include "GBView.h"
-#include <Core/gb.h>
-#import <Carbon/Carbon.h>
-#import <JoyKit/JoyKit.h>
-#import <WebKit/WebKit.h>
-
-#define UPDATE_SERVER "https://sameboy.github.io"
-
-static uint32_t color_to_int(NSColor *color)
-{
-    color = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
-    return (((unsigned)(color.redComponent * 0xFF)) << 16) |
-           (((unsigned)(color.greenComponent * 0xFF)) << 8) |
-           ((unsigned)(color.blueComponent * 0xFF));
-}
-
-@implementation AppDelegate
-{
-    NSWindow *preferences_window;
-    NSArray<NSView *> *preferences_tabs;
-    NSString *_lastVersion;
-    NSString *_updateURL;
-    NSURLSessionDownloadTask *_updateTask;
-    enum {
-        UPDATE_DOWNLOADING,
-        UPDATE_EXTRACTING,
-        UPDATE_WAIT_INSTALL,
-        UPDATE_INSTALLING,
-        UPDATE_FAILED,
-    } _updateState;
-    NSString *_downloadDirectory;
-}
-
-- (void) applicationDidFinishLaunching:(NSNotification *)notification
-{
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    for (unsigned i = 0; i < GBButtonCount; i++) {
-        if ([[defaults objectForKey:button_to_preference_name(i, 0)] isKindOfClass:[NSString class]]) {
-            [defaults removeObjectForKey:button_to_preference_name(i, 0)];
-        }
-    }
-    [[NSUserDefaults standardUserDefaults] registerDefaults:@{
-                                                              @"GBRight": @(kVK_RightArrow),
-                                                              @"GBLeft": @(kVK_LeftArrow),
-                                                              @"GBUp": @(kVK_UpArrow),
-                                                              @"GBDown": @(kVK_DownArrow),
-
-                                                              @"GBA": @(kVK_ANSI_X),
-                                                              @"GBB": @(kVK_ANSI_Z),
-                                                              @"GBSelect": @(kVK_Delete),
-                                                              @"GBStart": @(kVK_Return),
-
-                                                              @"GBTurbo": @(kVK_Space),
-                                                              @"GBRewind": @(kVK_Tab),
-                                                              @"GBSlow-Motion": @(kVK_Shift),
-
-                                                              @"GBFilter": @"NearestNeighbor",
-                                                              @"GBColorCorrection": @(GB_COLOR_CORRECTION_EMULATE_HARDWARE),
-                                                              @"GBHighpassFilter": @(GB_HIGHPASS_REMOVE_DC_OFFSET),
-                                                              @"GBRewindLength": @(10),
-                                                              @"GBFrameBlendingMode": @([defaults boolForKey:@"DisableFrameBlending"]? GB_FRAME_BLENDING_MODE_DISABLED : GB_FRAME_BLENDING_MODE_ACCURATE),
-                                                              
-                                                              @"GBDMGModel": @(GB_MODEL_DMG_B),
-                                                              @"GBCGBModel": @(GB_MODEL_CGB_E),
-                                                              @"GBSGBModel": @(GB_MODEL_SGB2),
-                                                              @"GBRumbleMode": @(GB_RUMBLE_CARTRIDGE_ONLY),
-                                                              
-                                                              @"GBVolume": @(1.0),
-                                                              }];
-    
-    [JOYController startOnRunLoop:[NSRunLoop currentRunLoop] withOptions:@{
-        JOYAxes2DEmulateButtonsKey: @YES,
-        JOYHatsEmulateButtonsKey: @YES,
-    }];
-    
-    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"GBNotificationsUsed"]) {
-        [NSUserNotificationCenter defaultUserNotificationCenter].delegate = self;
-    }
-    
-    [self askAutoUpdates];
-    
-    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"GBAutoUpdatesEnabled"]) {
-        [self checkForUpdates];
-    }
-    
-    if ([[NSProcessInfo processInfo].arguments containsObject:@"--update-launch"]) {
-        [NSApp activateIgnoringOtherApps:true];
-    }
-}
-
-- (IBAction)toggleDeveloperMode:(id)sender
-{
-    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
-    [defaults setBool:![defaults boolForKey:@"DeveloperMode"] forKey:@"DeveloperMode"];
-}
-
-- (IBAction)switchPreferencesTab:(id)sender
-{
-    for (NSView *view in preferences_tabs) {
-        [view removeFromSuperview];
-    }
-    NSView *tab = preferences_tabs[[sender tag]];
-    NSRect old = [_preferencesWindow frame];
-    NSRect new = [_preferencesWindow frameRectForContentRect:tab.frame];
-    new.origin.x = old.origin.x;
-    new.origin.y = old.origin.y + (old.size.height - new.size.height);
-    [_preferencesWindow setFrame:new display:true animate:_preferencesWindow.visible];
-    [_preferencesWindow.contentView addSubview:tab];
-}
-
-- (BOOL)validateMenuItem:(NSMenuItem *)anItem
-{
-    if ([anItem action] == @selector(toggleDeveloperMode:)) {
-        [(NSMenuItem *)anItem setState:[[NSUserDefaults standardUserDefaults] boolForKey:@"DeveloperMode"]];
-    }
-    
-    if (anItem == self.linkCableMenuItem) {
-        return [[NSDocumentController sharedDocumentController] documents].count > 1;
-    }
-    return true;
-}
-
-- (void)menuNeedsUpdate:(NSMenu *)menu
-{
-    NSMutableArray *items = [NSMutableArray array];
-    NSDocument *currentDocument = [[NSDocumentController sharedDocumentController] currentDocument];
-    
-    for (NSDocument *document in [[NSDocumentController sharedDocumentController] documents]) {
-        if (document == currentDocument) continue;
-        NSMenuItem *item = [[NSMenuItem alloc] initWithTitle:document.displayName action:@selector(connectLinkCable:) keyEquivalent:@""];
-        item.representedObject = document;
-        item.image = [[NSWorkspace sharedWorkspace] iconForFile:document.fileURL.path];
-        [item.image setSize:NSMakeSize(16, 16)];
-        [items addObject:item];
-    }
-    menu.itemArray = items;
-}
-
-- (IBAction) showPreferences: (id) sender
-{
-    NSArray *objects;
-    if (!_preferencesWindow) {
-        [[NSBundle mainBundle] loadNibNamed:@"Preferences" owner:self topLevelObjects:&objects];
-        NSToolbarItem *first_toolbar_item = [_preferencesWindow.toolbar.items firstObject];
-        _preferencesWindow.toolbar.selectedItemIdentifier = [first_toolbar_item itemIdentifier];
-        preferences_tabs = @[self.emulationTab, self.graphicsTab, self.audioTab, self.controlsTab, self.updatesTab];
-        [self switchPreferencesTab:first_toolbar_item];
-        [_preferencesWindow center];
-#ifndef UPDATE_SUPPORT
-        [_preferencesWindow.toolbar removeItemAtIndex:4];
-#endif
-    }
-    [_preferencesWindow makeKeyAndOrderFront:self];
-}
-
-- (BOOL)applicationOpenUntitledFile:(NSApplication *)sender
-{
-    [self askAutoUpdates];
-    /* Bring an existing panel to the foreground */
-    for (NSWindow *window in [[NSApplication sharedApplication] windows]) {
-        if ([window isKindOfClass:[NSOpenPanel class]]) {
-            [(NSOpenPanel *)window makeKeyAndOrderFront:nil];
-            return true;
-        }
-    }
-    [[NSDocumentController sharedDocumentController] openDocument:self];
-    return true;
-}
-
-- (void)userNotificationCenter:(NSUserNotificationCenter *)center didActivateNotification:(NSUserNotification *)notification
-{
-    [[NSDocumentController sharedDocumentController] openDocumentWithContentsOfFile:notification.identifier display:true];
-}
-
-- (void)updateFound
-{
-    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@UPDATE_SERVER "/raw_changes"] completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
-        
-        NSColor *linkColor = [NSColor colorWithRed:0.125 green:0.325 blue:1.0 alpha:1.0];
-        if (@available(macOS 10.10, *)) {
-            linkColor = [NSColor linkColor];
-        }
-        
-        NSString *changes = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
-        NSRange cutoffRange = [changes rangeOfString:@"<!--(" GB_VERSION ")-->"];
-        if (cutoffRange.location != NSNotFound) {
-            changes = [changes substringToIndex:cutoffRange.location];
-        }
-        
-        NSString *html = [NSString stringWithFormat:@"<!DOCTYPE html><html><head><title></title>"
-                          "<style>html {background-color:transparent; color: #%06x; line-height:1.5} a:link, a:visited{color:#%06x; text-decoration:none}</style>"
-                          "</head><body>%@</body></html>",
-                          color_to_int([NSColor textColor]),
-                          color_to_int(linkColor),
-                          changes];
-        
-        if ([(NSHTTPURLResponse *)response statusCode] == 200) {
-            dispatch_async(dispatch_get_main_queue(), ^{
-                NSArray *objects;
-                [[NSBundle mainBundle] loadNibNamed:@"UpdateWindow" owner:self topLevelObjects:&objects];
-                self.updateChanges.preferences.standardFontFamily = [NSFont systemFontOfSize:0].familyName;
-                self.updateChanges.preferences.fixedFontFamily = @"Menlo";
-                self.updateChanges.drawsBackground = false;
-                [self.updateChanges.mainFrame loadHTMLString:html baseURL:nil];
-            });
-        }
-    }] resume];
-}
-
-- (NSArray *)webView:(WebView *)sender contextMenuItemsForElement:(NSDictionary *)element defaultMenuItems:(NSArray *)defaultMenuItems
-{
-    // Disable reload context menu
-    if ([defaultMenuItems count] <= 2) {
-        return nil;
-    }
-    return defaultMenuItems;
-}
-
-- (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame
-{
-    static dispatch_once_t onceToken;
-    dispatch_once(&onceToken, ^{
-        sender.mainFrame.frameView.documentView.enclosingScrollView.drawsBackground = true;
-        sender.mainFrame.frameView.documentView.enclosingScrollView.backgroundColor = [NSColor textBackgroundColor];
-        sender.policyDelegate = self;
-        [self.updateWindow center];
-        [self.updateWindow makeKeyAndOrderFront:nil];
-    });
-}
-
-- (void)webView:(WebView *)webView decidePolicyForNavigationAction:(NSDictionary *)actionInformation request:(NSURLRequest *)request frame:(WebFrame *)frame decisionListener:(id<WebPolicyDecisionListener>)listener
-{
-    [listener ignore];
-    [[NSWorkspace sharedWorkspace] openURL:[request URL]];
-}
-
-- (void)checkForUpdates
-{
-#ifdef UPDATE_SUPPORT
-    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@UPDATE_SERVER "/latest_version"] completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
-        dispatch_async(dispatch_get_main_queue(), ^{
-            [self.updatesSpinner stopAnimation:nil];
-            [self.updatesButton setEnabled:true];
-        });
-        if ([(NSHTTPURLResponse *)response statusCode] == 200) {
-            NSString *string = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
-            NSArray <NSString *> *components = [string componentsSeparatedByString:@"|"];
-            if (components.count != 2) return;
-            _lastVersion = components[0];
-            _updateURL = components[1];
-            if (![@GB_VERSION isEqualToString:_lastVersion] &&
-                ![[[NSUserDefaults standardUserDefaults] stringForKey:@"GBSkippedVersion"] isEqualToString:_lastVersion]) {
-                [self updateFound];
-            }
-        }
-    }] resume];
-#endif
-}
-
-- (IBAction)userCheckForUpdates:(id)sender
-{
-    if (self.updateWindow) {
-        [self.updateWindow makeKeyAndOrderFront:sender];
-    }
-    else {
-        [[NSUserDefaults standardUserDefaults] setObject:nil forKey:@"GBSkippedVersion"];
-        [self checkForUpdates];
-        [sender setEnabled:false];
-        [self.updatesSpinner startAnimation:sender];
-    }
-}
-
-- (void)askAutoUpdates
-{
-#ifdef UPDATE_SUPPORT
-    if (![[NSUserDefaults standardUserDefaults] boolForKey:@"GBAskedAutoUpdates"]) {
-        NSAlert *alert = [[NSAlert alloc] init];
-        alert.messageText = @"Should SameBoy check for updates when launched?";
-        alert.informativeText = @"SameBoy is frequently updated with new features, accuracy improvements, and bug fixes. This setting can always be changed in the preferences window.";
-        [alert addButtonWithTitle:@"Check on Launch"];
-        [alert addButtonWithTitle:@"Don't Check on Launch"];
-        
-        [[NSUserDefaults standardUserDefaults] setBool:[alert runModal] == NSAlertFirstButtonReturn forKey:@"GBAutoUpdatesEnabled"];
-        [[NSUserDefaults standardUserDefaults] setBool:true forKey:@"GBAskedAutoUpdates"];
-    }
-#endif
-}
-
-- (IBAction)skipVersion:(id)sender
-{
-    [[NSUserDefaults standardUserDefaults] setObject:_lastVersion forKey:@"GBSkippedVersion"];
-    [self.updateWindow performClose:sender];
-}
-
-- (IBAction)installUpdate:(id)sender
-{
-    [self.updateProgressSpinner startAnimation:nil];
-    self.updateProgressButton.title = @"Cancel";
-    self.updateProgressButton.enabled = true;
-    self.updateProgressLabel.stringValue = @"Downloading update...";
-    _updateState = UPDATE_DOWNLOADING;
-    _updateTask = [[NSURLSession sharedSession] downloadTaskWithURL: [NSURL URLWithString:_updateURL] completionHandler:^(NSURL *location, NSURLResponse *response, NSError *error) {
-        _updateTask = nil;
-        dispatch_sync(dispatch_get_main_queue(), ^{
-            self.updateProgressButton.enabled = false;
-            self.updateProgressLabel.stringValue = @"Extracting update...";
-            _updateState = UPDATE_EXTRACTING;
-        });
-        
-        _downloadDirectory = [[[NSFileManager defaultManager] URLForDirectory:NSItemReplacementDirectory
-                                                                     inDomain:NSUserDomainMask
-                                                            appropriateForURL:[[NSBundle mainBundle] bundleURL]
-                                                                       create:true
-                                                                        error:nil] path];
-        NSTask *unzipTask;
-        if (!_downloadDirectory) {
-            dispatch_sync(dispatch_get_main_queue(), ^{
-                self.updateProgressButton.enabled = false;
-                self.updateProgressLabel.stringValue = @"Failed to extract update.";
-                _updateState = UPDATE_FAILED;
-                self.updateProgressButton.title = @"Close";
-                self.updateProgressButton.enabled = true;
-                [self.updateProgressSpinner stopAnimation:nil];
-            });
-        }
-        
-        unzipTask = [[NSTask alloc] init];
-        unzipTask.launchPath = @"/usr/bin/unzip";
-        unzipTask.arguments = @[location.path, @"-d", _downloadDirectory];
-        [unzipTask launch];
-        [unzipTask waitUntilExit];
-        if (unzipTask.terminationStatus != 0 || unzipTask.terminationReason != NSTaskTerminationReasonExit) {
-            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
-            dispatch_sync(dispatch_get_main_queue(), ^{
-                self.updateProgressButton.enabled = false;
-                self.updateProgressLabel.stringValue = @"Failed to extract update.";
-                _updateState = UPDATE_FAILED;
-                self.updateProgressButton.title = @"Close";
-                self.updateProgressButton.enabled = true;
-                [self.updateProgressSpinner stopAnimation:nil];
-            });
-            return;
-        }
-        
-        dispatch_sync(dispatch_get_main_queue(), ^{
-            self.updateProgressButton.enabled = false;
-            self.updateProgressLabel.stringValue = @"Update ready, save your game progress and click Install.";
-            _updateState = UPDATE_WAIT_INSTALL;
-            self.updateProgressButton.title = @"Install";
-            self.updateProgressButton.enabled = true;
-            [self.updateProgressSpinner stopAnimation:nil];
-        });
-    }];
-    [_updateTask resume];
-    
-    self.updateProgressWindow.preventsApplicationTerminationWhenModal = false;
-    [self.updateWindow beginSheet:self.updateProgressWindow completionHandler:^(NSModalResponse returnCode) {
-        [self.updateWindow close];
-    }];
-}
-
-- (void)performUpgrade
-{
-    self.updateProgressButton.enabled = false;
-    self.updateProgressLabel.stringValue = @"Instaling update...";
-    _updateState = UPDATE_INSTALLING;
-    self.updateProgressButton.enabled = false;
-    [self.updateProgressSpinner startAnimation:nil];
-    dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
-        NSString *executablePath = [[NSBundle mainBundle] executablePath];
-        NSString *contentsPath = [[[NSBundle mainBundle] bundlePath] stringByAppendingPathComponent:@"Contents"];
-        NSString *contentsTempPath = [[[NSBundle mainBundle] bundlePath] stringByAppendingPathComponent:@"TempContents"];
-        NSString *updateContentsPath = [_downloadDirectory stringByAppendingPathComponent:@"SameBoy.app/Contents"];
-        NSError *error = nil;
-        [[NSFileManager defaultManager] moveItemAtPath:contentsPath toPath:contentsTempPath error:&error];
-        if (error) {
-            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
-            _downloadDirectory = nil;
-            dispatch_sync(dispatch_get_main_queue(), ^{
-                self.updateProgressButton.enabled = false;
-                self.updateProgressLabel.stringValue = @"Failed to install update.";
-                _updateState = UPDATE_FAILED;
-                self.updateProgressButton.title = @"Close";
-                self.updateProgressButton.enabled = true;
-                [self.updateProgressSpinner stopAnimation:nil];
-            });
-            return;
-        }
-        [[NSFileManager defaultManager] moveItemAtPath:updateContentsPath toPath:contentsPath error:&error];
-        if (error) {
-            [[NSFileManager defaultManager] moveItemAtPath:contentsTempPath toPath:contentsPath error:nil];
-            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
-            _downloadDirectory = nil;
-            dispatch_sync(dispatch_get_main_queue(), ^{
-                self.updateProgressButton.enabled = false;
-                self.updateProgressLabel.stringValue = @"Failed to install update.";
-                _updateState = UPDATE_FAILED;
-                self.updateProgressButton.title = @"Close";
-                self.updateProgressButton.enabled = true;
-                [self.updateProgressSpinner stopAnimation:nil];
-            });
-            return;
-        }
-        [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
-        [[NSFileManager defaultManager] removeItemAtPath:contentsTempPath error:nil];
-        _downloadDirectory = nil;
-        atexit_b(^{
-            execl(executablePath.UTF8String, executablePath.UTF8String, "--update-launch", NULL);
-        });
-        
-        dispatch_async(dispatch_get_main_queue(), ^{
-            [NSApp terminate:nil];
-        });
-    });
-}
-
-- (IBAction)updateAction:(id)sender
-{
-    switch (_updateState) {
-        case UPDATE_DOWNLOADING:
-            [_updateTask cancelByProducingResumeData:nil];
-            _updateTask = nil;
-            [self.updateProgressWindow close];
-            break;
-        case UPDATE_WAIT_INSTALL:
-            [self performUpgrade];
-            break;
-        case UPDATE_EXTRACTING:
-        case UPDATE_INSTALLING:
-            break;
-        case UPDATE_FAILED:
-            [self.updateProgressWindow close];
-            break;
-    }
-}
-
-- (void)dealloc
-{
-    if (_downloadDirectory) {
-        [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
-    }
-}
-
-- (IBAction)nop:(id)sender
-{
-}
-@end

bsnes/gb/Cocoa/AudioRecordingAccessoryView.xib

@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="14868" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
+    <dependencies>
+        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="14868"/>
+        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
+    </dependencies>
+    <objects>
+        <customObject id="-2" userLabel="File's Owner" customClass="Document">
+            <connections>
+                <outlet property="audioFormatButton" destination="knX-AW-zt5" id="fKt-eI-H0y"/>
+                <outlet property="audioRecordingAccessoryView" destination="c22-O7-iKe" id="XD8-Gi-qOC"/>
+            </connections>
+        </customObject>
+        <customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
+        <customObject id="-3" userLabel="Application" customClass="NSObject"/>
+        <customView id="c22-O7-iKe">
+            <rect key="frame" x="0.0" y="0.0" width="354" height="36"/>
+            <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+            <subviews>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="Atq-RE-328">
+                    <rect key="frame" x="18" y="10" width="56" height="16"/>
+                    <autoresizingMask key="autoresizingMask"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" alignment="right" title="Format:" id="dso-NS-JlD">
+                        <font key="font" metaFont="system"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <popUpButton verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="knX-AW-zt5">
+                    <rect key="frame" x="81" y="4" width="256" height="25"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <popUpButtonCell key="cell" type="push" title="Apple AIFF" bezelStyle="rounded" alignment="left" lineBreakMode="truncatingTail" state="on" borderStyle="borderAndBezel" tag="1" imageScaling="proportionallyDown" inset="2" selectedItem="M3Z-UN-VKZ" id="tLM-Di-Dy3">
+                        <behavior key="behavior" lightByBackground="YES" lightByGray="YES"/>
+                        <font key="font" metaFont="system"/>
+                        <menu key="menu" id="gqn-SL-AA5">
+                            <items>
+                                <menuItem title="Apple AIFF" state="on" tag="1" id="M3Z-UN-VKZ"/>
+                                <menuItem title="RIFF WAVE" tag="2" id="zA0-Np-4XD"/>
+                                <menuItem title="Raw PCM (Stereo 96KHz, 16-bit LE)" id="r9J-4k-XH5"/>
+                            </items>
+                        </menu>
+                    </popUpButtonCell>
+                    <connections>
+                        <action selector="audioFormatChanged:" target="-2" id="I1k-d9-afp"/>
+                    </connections>
+                </popUpButton>
+            </subviews>
+            <point key="canvasLocation" x="75" y="19"/>
+        </customView>
+    </objects>
+</document>

bsnes/gb/Cocoa/BigSurToolbar.h

@@ -1,6 +1,4 @@
 #import <Cocoa/Cocoa.h>
-#ifndef BigSurToolbar_h
-#define BigSurToolbar_h
 
 /* Backport the toolbarStyle property to allow compilation with older SDKs*/
 #ifndef __MAC_10_16
@@ -26,5 +24,3 @@ typedef NS_ENUM(NSInteger, NSWindowToolbarStyle) {
 @end
 
 #endif
-
-#endif

bsnes/gb/Cocoa/CheatSearch.xib

@@ -0,0 +1,253 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="24093.7" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
+    <dependencies>
+        <deployment identifier="macosx"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="24093.7"/>
+        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
+    </dependencies>
+    <objects>
+        <customObject id="-2" userLabel="File's Owner" customClass="GBCheatSearchController">
+            <connections>
+                <outlet property="addCheatButton" destination="o1I-5D-V4k" id="lRE-uQ-vul"/>
+                <outlet property="conditionField" destination="XN7-BO-THS" id="vzh-y2-CcN"/>
+                <outlet property="conditionTypeButton" destination="6RO-h8-lZ8" id="5wx-NY-lbK"/>
+                <outlet property="dataTypeButton" destination="5Db-vP-S60" id="wdR-m7-fEI"/>
+                <outlet property="operandField" destination="Q42-Vu-TJW" id="hRn-67-UmU"/>
+                <outlet property="resultsLabel" destination="wbN-MX-lEy" id="gJB-fD-eKK"/>
+                <outlet property="tableView" destination="fSU-85-fVM" id="1kO-kP-yBb"/>
+                <outlet property="window" destination="QvC-M9-y7g" id="g09-DO-GsE"/>
+            </connections>
+        </customObject>
+        <customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
+        <customObject id="-3" userLabel="Application" customClass="NSObject"/>
+        <window title="Cheat Search" allowsToolTipsWhenApplicationIsInactive="NO" autorecalculatesKeyViewLoop="NO" releasedWhenClosed="NO" animationBehavior="default" id="QvC-M9-y7g" customClass="GBPanel">
+            <windowStyleMask key="styleMask" titled="YES" closable="YES" miniaturizable="YES" resizable="YES"/>
+            <rect key="contentRect" x="196" y="240" width="480" height="372"/>
+            <rect key="screenRect" x="0.0" y="0.0" width="2560" height="1415"/>
+            <value key="minSize" type="size" width="480" height="372"/>
+            <value key="maxSize" type="size" width="480" height="99999"/>
+            <view key="contentView" wantsLayer="YES" id="EiT-Mj-1SZ">
+                <rect key="frame" x="0.0" y="0.0" width="480" height="372"/>
+                <autoresizingMask key="autoresizingMask"/>
+                <subviews>
+                    <scrollView fixedFrame="YES" autohidesScrollers="YES" horizontalLineScroll="24" horizontalPageScroll="10" verticalLineScroll="24" verticalPageScroll="10" usesPredominantAxisScrolling="NO" translatesAutoresizingMaskIntoConstraints="NO" id="Fvf-Co-5Ga">
+                        <rect key="frame" x="-1" y="155" width="482" height="218"/>
+                        <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
+                        <clipView key="contentView" drawsBackground="NO" id="1kJ-HR-keu">
+                            <rect key="frame" x="1" y="1" width="480" height="216"/>
+                            <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
+                            <subviews>
+                                <tableView verticalHuggingPriority="750" allowsExpansionToolTips="YES" tableStyle="plain" alternatingRowBackgroundColors="YES" columnReordering="NO" columnResizing="NO" multipleSelection="NO" autosaveColumns="NO" rowHeight="24" headerView="oyv-sh-ulk" id="fSU-85-fVM">
+                                    <rect key="frame" x="0.0" y="0.0" width="480" height="188"/>
+                                    <autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
+                                    <size key="intercellSpacing" width="17" height="0.0"/>
+                                    <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
+                                    <color key="gridColor" name="gridColor" catalog="System" colorSpace="catalog"/>
+                                    <tableColumns>
+                                        <tableColumn identifier="AutomaticTableColumnIdentifier.0" editable="NO" width="143" minWidth="40" maxWidth="1000" id="8z0-o5-dNI">
+                                            <tableHeaderCell key="headerCell" lineBreakMode="truncatingTail" borderStyle="border" title="Address">
+                                                <color key="textColor" name="headerTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" name="headerColor" catalog="System" colorSpace="catalog"/>
+                                            </tableHeaderCell>
+                                            <textFieldCell key="dataCell" controlSize="large" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" title="Text Cell" id="bmG-fw-HDR" customClass="GBCenteredTextCell">
+                                                <font key="font" metaFont="system"/>
+                                                <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
+                                            </textFieldCell>
+                                            <tableColumnResizingMask key="resizingMask" resizeWithTable="YES" userResizable="YES"/>
+                                        </tableColumn>
+                                        <tableColumn identifier="AutomaticTableColumnIdentifier.1" editable="NO" width="143" minWidth="40" maxWidth="1000" id="mBc-yv-f00">
+                                            <tableHeaderCell key="headerCell" lineBreakMode="truncatingTail" borderStyle="border" title="Previous Value">
+                                                <color key="textColor" name="headerTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" name="headerColor" catalog="System" colorSpace="catalog"/>
+                                            </tableHeaderCell>
+                                            <textFieldCell key="dataCell" controlSize="large" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" title="Text Cell" id="BSe-S3-KNH" customClass="GBCenteredTextCell">
+                                                <font key="font" metaFont="system"/>
+                                                <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
+                                            </textFieldCell>
+                                            <tableColumnResizingMask key="resizingMask" resizeWithTable="YES" userResizable="YES"/>
+                                        </tableColumn>
+                                        <tableColumn width="143" minWidth="10" maxWidth="3.4028234663852886e+38" id="F7j-ck-3H0">
+                                            <tableHeaderCell key="headerCell" lineBreakMode="truncatingTail" borderStyle="border" alignment="left" title="Current Value">
+                                                <color key="textColor" name="headerTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" white="0.0" alpha="0.0" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
+                                            </tableHeaderCell>
+                                            <textFieldCell key="dataCell" controlSize="large" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" alignment="left" title="Text Cell" id="wjH-Ei-6hv" customClass="GBCenteredTextCell">
+                                                <font key="font" metaFont="system"/>
+                                                <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+                                                <color key="backgroundColor" name="controlBackgroundColor" catalog="System" colorSpace="catalog"/>
+                                            </textFieldCell>
+                                            <tableColumnResizingMask key="resizingMask" resizeWithTable="YES" userResizable="YES"/>
+                                        </tableColumn>
+                                    </tableColumns>
+                                    <connections>
+                                        <outlet property="dataSource" destination="-2" id="Yqt-V5-OkG"/>
+                                        <outlet property="delegate" destination="-2" id="TRM-gh-TG4"/>
+                                    </connections>
+                                </tableView>
+                            </subviews>
+                            <nil key="backgroundColor"/>
+                        </clipView>
+                        <scroller key="horizontalScroller" hidden="YES" wantsLayer="YES" verticalHuggingPriority="750" horizontal="YES" id="ZbQ-IG-kyP">
+                            <rect key="frame" x="1" y="201" width="480" height="16"/>
+                            <autoresizingMask key="autoresizingMask"/>
+                        </scroller>
+                        <scroller key="verticalScroller" hidden="YES" wantsLayer="YES" verticalHuggingPriority="750" horizontal="NO" id="wK3-8v-kAQ">
+                            <rect key="frame" x="224" y="17" width="15" height="102"/>
+                            <autoresizingMask key="autoresizingMask"/>
+                        </scroller>
+                        <tableHeaderView key="headerView" wantsLayer="YES" id="oyv-sh-ulk">
+                            <rect key="frame" x="0.0" y="0.0" width="480" height="28"/>
+                            <autoresizingMask key="autoresizingMask"/>
+                        </tableHeaderView>
+                    </scrollView>
+                    <button verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="KdM-lW-WbP">
+                        <rect key="frame" x="371" y="24" width="96" height="32"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+                        <buttonCell key="cell" type="push" title="Search" bezelStyle="rounded" alignment="center" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="t4Y-Ud-mJm">
+                            <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
+                            <font key="font" metaFont="system"/>
+                        </buttonCell>
+                        <connections>
+                            <action selector="search:" target="-2" id="7pG-JY-vEF"/>
+                        </connections>
+                    </button>
+                    <textField focusRingType="none" horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="fTv-nr-5FT">
+                        <rect key="frame" x="6" y="95" width="124" height="17"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" alignment="right" title="Search Condition:" id="9C2-Xp-JIA">
+                            <font key="font" metaFont="system"/>
+                            <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                        </textFieldCell>
+                    </textField>
+                    <textField focusRingType="none" horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="vMd-zb-8jT">
+                        <rect key="frame" x="6" y="64" width="124" height="17"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" alignment="right" title="Expression:" id="Jgg-sA-jjs">
+                            <font key="font" metaFont="system"/>
+                            <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                        </textFieldCell>
+                    </textField>
+                    <popUpButton verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="5Db-vP-S60">
+                        <rect key="frame" x="133" y="120" width="197" height="25"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <popUpButtonCell key="cell" type="push" title="8-Bit" bezelStyle="rounded" alignment="left" lineBreakMode="truncatingTail" state="on" borderStyle="borderAndBezel" imageScaling="proportionallyDown" inset="2" selectedItem="al4-Jb-OJB" id="dkg-V5-wsX">
+                            <behavior key="behavior" lightByBackground="YES" lightByGray="YES"/>
+                            <font key="font" metaFont="message"/>
+                            <menu key="menu" id="e5r-qR-pg7">
+                                <items>
+                                    <menuItem title="8-Bit" state="on" id="al4-Jb-OJB"/>
+                                    <menuItem title="16-Bit" tag="1" id="G2m-fU-8Lt"/>
+                                    <menuItem title="16-Bit (Big Endian)" tag="3" id="JRa-DB-dyG"/>
+                                </items>
+                            </menu>
+                        </popUpButtonCell>
+                    </popUpButton>
+                    <popUpButton verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="6RO-h8-lZ8">
+                        <rect key="frame" x="133" y="89" width="197" height="25"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <popUpButtonCell key="cell" type="push" title="Is Equal To…" bezelStyle="rounded" alignment="left" lineBreakMode="truncatingTail" state="on" borderStyle="borderAndBezel" imageScaling="proportionallyDown" inset="2" selectedItem="Vfb-Dg-Jkb" id="DPm-QO-c64">
+                            <behavior key="behavior" lightByBackground="YES" lightByGray="YES"/>
+                            <font key="font" metaFont="message"/>
+                            <menu key="menu" id="Kg9-Rd-1GQ">
+                                <items>
+                                    <menuItem title="Any" id="cEg-eI-4hb"/>
+                                    <menuItem title="Is Equal To…" state="on" id="Vfb-Dg-Jkb"/>
+                                    <menuItem title="Is Different From…" id="JDg-d9-5Ux"/>
+                                    <menuItem title="Is Greater Than…" id="Rir-w0-737"/>
+                                    <menuItem title="Is Equal or Greater Than…" id="Lvo-pV-Syt"/>
+                                    <menuItem title="Is Less Than…" id="VUW-DY-2cI"/>
+                                    <menuItem title="Is Equal or Less Than…" id="rDN-UF-tIo"/>
+                                    <menuItem title="Did Change" id="JdI-CW-E8H"/>
+                                    <menuItem title="Did Not Change" id="sWc-Yz-Cve"/>
+                                    <menuItem title="Did Increase" id="LHF-Lf-7tK"/>
+                                    <menuItem title="Did Decrease" id="8s2-8n-aQO"/>
+                                    <menuItem title="Custom…" id="8xc-2v-YQj"/>
+                                </items>
+                            </menu>
+                        </popUpButtonCell>
+                        <connections>
+                            <action selector="conditionChanged:" target="-2" id="KF9-vz-yNC"/>
+                        </connections>
+                    </popUpButton>
+                    <textField focusRingType="none" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="Q42-Vu-TJW">
+                        <rect key="frame" x="334" y="93" width="126" height="21"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" continuous="YES" sendsActionOnEndEditing="YES" borderStyle="bezel" title="$0" drawsBackground="YES" usesSingleLineMode="YES" id="WDs-GG-7Lc">
+                            <font key="font" metaFont="system"/>
+                            <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                            <allowedInputSourceLocales>
+                                <string>NSAllRomanInputSourcesLocaleIdentifier</string>
+                            </allowedInputSourceLocales>
+                        </textFieldCell>
+                        <connections>
+                            <action selector="search:" target="-2" id="BDa-5j-qEz"/>
+                            <outlet property="delegate" destination="-2" id="1bO-hp-igc"/>
+                        </connections>
+                    </textField>
+                    <textField focusRingType="none" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="XN7-BO-THS">
+                        <rect key="frame" x="136" y="62" width="324" height="21"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" selectable="YES" editable="YES" enabled="NO" sendsActionOnEndEditing="YES" borderStyle="bezel" title="new == ($0)" drawsBackground="YES" usesSingleLineMode="YES" id="Krh-8w-4ug">
+                            <font key="font" metaFont="system"/>
+                            <color key="textColor" name="controlTextColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                            <allowedInputSourceLocales>
+                                <string>NSAllRomanInputSourcesLocaleIdentifier</string>
+                            </allowedInputSourceLocales>
+                        </textFieldCell>
+                        <connections>
+                            <action selector="search:" target="-2" id="sv5-eX-Kb9"/>
+                        </connections>
+                    </textField>
+                    <button verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="tBa-6c-9AY">
+                        <rect key="frame" x="13" y="24" width="96" height="32"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+                        <buttonCell key="cell" type="push" title="Reset" bezelStyle="rounded" alignment="center" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="Pge-SU-Y1n">
+                            <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
+                            <font key="font" metaFont="system"/>
+                        </buttonCell>
+                        <connections>
+                            <action selector="reset:" target="-2" id="KCy-Ob-tlg"/>
+                        </connections>
+                    </button>
+                    <textField focusRingType="none" horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="wbN-MX-lEy">
+                        <rect key="frame" x="-3" y="4" width="486" height="14"/>
+                        <autoresizingMask key="autoresizingMask" widthSizable="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" controlSize="small" lineBreakMode="clipping" alignment="center" title="Status" id="CM3-4U-qao">
+                            <font key="font" metaFont="smallSystem"/>
+                            <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                        </textFieldCell>
+                    </textField>
+                    <button verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="o1I-5D-V4k">
+                        <rect key="frame" x="264" y="24" width="110" height="32"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+                        <buttonCell key="cell" type="push" title="Add Cheat" bezelStyle="rounded" alignment="center" enabled="NO" borderStyle="border" imageScaling="proportionallyDown" inset="2" id="GGV-nm-ASn">
+                            <behavior key="behavior" pushIn="YES" lightByBackground="YES" lightByGray="YES"/>
+                            <font key="font" metaFont="system"/>
+                        </buttonCell>
+                        <connections>
+                            <action selector="addCheat:" target="-2" id="7ax-kM-TeV"/>
+                        </connections>
+                    </button>
+                    <textField focusRingType="none" horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="veO-Qn-0Sz">
+                        <rect key="frame" x="6" y="126" width="124" height="17"/>
+                        <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
+                        <textFieldCell key="cell" scrollable="YES" lineBreakMode="clipping" sendsActionOnEndEditing="YES" alignment="right" title="Data Type:" id="KuT-rz-eHm">
+                            <font key="font" metaFont="system"/>
+                            <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                            <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                        </textFieldCell>
+                    </textField>
+                </subviews>
+            </view>
+            <contentBorderThickness minY="22"/>
+            <point key="canvasLocation" x="161" y="182"/>
+        </window>
+    </objects>
+</document>

bsnes/gb/Cocoa/Document.h

@@ -1,61 +1,98 @@
 #import <Cocoa/Cocoa.h>
-#include "GBView.h"
-#include "GBImageView.h"
-#include "GBSplitView.h"
-#include "GBVisualizerView.h"
-#include "GBOSDView.h"
+#import "GBView.h"
+#import "GBImageView.h"
+#import "GBSplitView.h"
+#import "GBVisualizerView.h"
+#import "GBCPUView.h"
+#import "GBOSDView.h"
+#import "GBDebuggerButton.h"
+
+enum model {
+    MODEL_NONE,
+    MODEL_DMG,
+    MODEL_CGB,
+    MODEL_AGB,
+    MODEL_SGB,
+    MODEL_MGB,
+    MODEL_AUTO,
+    
+    MODEL_QUICK_RESET = -1,
+};
 
 @class GBCheatWindowController;
+@class GBPaletteView;
+@class GBObjectView;
 
-@interface Document : NSDocument <NSWindowDelegate, GBImageViewDelegate, NSTableViewDataSource, NSTableViewDelegate, NSSplitViewDelegate>
-@property (nonatomic, readonly) GB_gameboy_t *gb;
-@property (nonatomic, strong) IBOutlet GBView *view;
-@property (nonatomic, strong) IBOutlet NSTextView *consoleOutput;
-@property (nonatomic, strong) IBOutlet NSPanel *consoleWindow;
-@property (nonatomic, strong) IBOutlet NSTextField *consoleInput;
-@property (nonatomic, strong) IBOutlet NSWindow *mainWindow;
-@property (nonatomic, strong) IBOutlet NSView *memoryView;
-@property (nonatomic, strong) IBOutlet NSPanel *memoryWindow;
-@property (nonatomic, readonly) GB_gameboy_t *gameboy;
-@property (nonatomic, strong) IBOutlet NSTextField *memoryBankInput;
-@property (nonatomic, strong) IBOutlet NSToolbarItem *memoryBankItem;
-@property (nonatomic, strong) IBOutlet GBImageView *tilesetImageView;
-@property (nonatomic, strong) IBOutlet NSPopUpButton *tilesetPaletteButton;
-@property (nonatomic, strong) IBOutlet GBImageView *tilemapImageView;
-@property (nonatomic, strong) IBOutlet NSPopUpButton *tilemapPaletteButton;
-@property (nonatomic, strong) IBOutlet NSPopUpButton *tilemapMapButton;
-@property (nonatomic, strong) IBOutlet NSPopUpButton *TilemapSetButton;
-@property (nonatomic, strong) IBOutlet NSButton *gridButton;
-@property (nonatomic, strong) IBOutlet NSTabView *vramTabView;
-@property (nonatomic, strong) IBOutlet NSPanel *vramWindow;
-@property (nonatomic, strong) IBOutlet NSTextField *vramStatusLabel;
-@property (nonatomic, strong) IBOutlet NSTableView *paletteTableView;
-@property (nonatomic, strong) IBOutlet NSTableView *spritesTableView;
-@property (nonatomic, strong) IBOutlet NSPanel *printerFeedWindow;
-@property (nonatomic, strong) IBOutlet NSImageView *feedImageView;
-@property (nonatomic, strong) IBOutlet NSTextView *debuggerSideViewInput;
-@property (nonatomic, strong) IBOutlet NSTextView *debuggerSideView;
-@property (nonatomic, strong) IBOutlet GBSplitView *debuggerSplitView;
-@property (nonatomic, strong) IBOutlet NSBox *debuggerVerticalLine;
-@property (nonatomic, strong) IBOutlet NSPanel *cheatsWindow;
-@property (nonatomic, strong) IBOutlet GBCheatWindowController *cheatWindowController;
-@property (nonatomic, readonly) Document *partner;
-@property (nonatomic, readonly) bool isSlave;
-@property (strong) IBOutlet NSView *gbsPlayerView;
-@property (strong) IBOutlet NSTextField *gbsTitle;
-@property (strong) IBOutlet NSTextField *gbsAuthor;
-@property (strong) IBOutlet NSTextField *gbsCopyright;
-@property (strong) IBOutlet NSPopUpButton *gbsTracks;
-@property (strong) IBOutlet NSButton *gbsPlayPauseButton;
-@property (strong) IBOutlet NSButton *gbsRewindButton;
-@property (strong) IBOutlet NSSegmentedControl *gbsNextPrevButton;
-@property (strong) IBOutlet GBVisualizerView *gbsVisualizer;
-@property (strong) IBOutlet GBOSDView *osdView;
+@interface Document : NSDocument <NSWindowDelegate, GBImageViewDelegate, NSSplitViewDelegate>
+@property (readonly) GB_gameboy_t *gb;
+@property IBOutlet GBView *view;
+@property IBOutlet NSTextView *consoleOutput;
+@property IBOutlet NSPanel *consoleWindow;
+@property IBOutlet NSTextField *consoleInput;
+@property IBOutlet NSWindow *mainWindow;
+@property IBOutlet NSView *memoryView;
+@property IBOutlet NSPanel *memoryWindow;
+@property (readonly) GB_gameboy_t *gameboy;
+@property IBOutlet NSTextField *memoryBankInput;
+@property IBOutlet NSToolbarItem *memoryBankItem;
+@property IBOutlet NSPopUpButton *memorySpaceButton;
+@property IBOutlet GBImageView *tilesetImageView;
+@property IBOutlet NSPopUpButton *tilesetPaletteButton;
+@property IBOutlet GBImageView *tilemapImageView;
+@property IBOutlet NSPopUpButton *tilemapPaletteButton;
+@property IBOutlet NSPopUpButton *tilemapMapButton;
+@property IBOutlet NSPopUpButton *TilemapSetButton;
+@property IBOutlet NSButton *gridButton;
+@property IBOutlet NSTabView *vramTabView;
+@property IBOutlet NSPanel *vramWindow;
+@property IBOutlet NSTextField *vramStatusLabel;
+@property IBOutlet GBPaletteView *paletteView;
+@property IBOutlet GBObjectView *objectView;
+@property IBOutlet NSPanel *printerFeedWindow;
+@property IBOutlet NSProgressIndicator *printerSpinner;
+@property IBOutlet NSImageView *feedImageView;
+@property IBOutlet NSTextView *debuggerSideViewInput;
+@property IBOutlet NSTextView *debuggerSideView;
+@property IBOutlet GBSplitView *debuggerSplitView;
+@property IBOutlet NSBox *debuggerVerticalLine;
+@property IBOutlet NSPanel *cheatsWindow;
+@property IBOutlet GBCheatWindowController *cheatWindowController;
+@property (readonly) Document *partner;
+@property (readonly) bool isSlave;
+@property IBOutlet NSView *gbsPlayerView;
+@property IBOutlet NSTextField *gbsTitle;
+@property IBOutlet NSTextField *gbsAuthor;
+@property IBOutlet NSTextField *gbsCopyright;
+@property IBOutlet NSPopUpButton *gbsTracks;
+@property IBOutlet NSButton *gbsPlayPauseButton;
+@property IBOutlet NSButton *gbsRewindButton;
+@property IBOutlet NSSegmentedControl *gbsNextPrevButton;
+@property IBOutlet GBVisualizerView *gbsVisualizer;
+@property IBOutlet GBOSDView *osdView;
+@property (readonly) GB_oam_info_t *oamInfo;
+@property uint8_t oamCount;
+@property uint8_t oamHeight;
+@property IBOutlet NSView *audioRecordingAccessoryView;
+@property IBOutlet NSPopUpButton *audioFormatButton;
+@property IBOutlet NSVisualEffectView *debuggerSidebarEffectView API_AVAILABLE(macos(10.10));
 
--(uint8_t) readMemory:(uint16_t) addr;
--(void) writeMemory:(uint16_t) addr value:(uint8_t)value;
--(void) performAtomicBlock: (void (^)())block;
--(void) connectLinkCable:(NSMenuItem *)sender;
--(int)loadStateFile:(const char *)path noErrorOnNotFound:(bool)noErrorOnFileNotFound;
+@property IBOutlet GBDebuggerButton *debuggerContinueButton;
+@property IBOutlet GBDebuggerButton *debuggerNextButton;
+@property IBOutlet GBDebuggerButton *debuggerStepButton;
+@property IBOutlet GBDebuggerButton *debuggerFinishButton;
+@property IBOutlet GBDebuggerButton *debuggerBackstepButton;
+
+@property IBOutlet NSScrollView *debuggerScrollView;
+@property IBOutlet NSView *debugBar;
+
+@property IBOutlet GBCPUView *cpuView;
+@property IBOutlet NSTextField *cpuCounter;
+
++ (NSImage *) imageFromData:(NSData *)data width:(NSUInteger) width height:(NSUInteger) height scale:(double) scale;
+- (void) performAtomicBlock: (void (^)())block;
+- (void) connectLinkCable:(NSMenuItem *)sender;
+- (int)loadStateFile:(const char *)path noErrorOnNotFound:(bool)noErrorOnFileNotFound;
+- (NSString *)captureOutputForBlock: (void (^)())block;
+- (NSFont *)debuggerFontOfSize:(unsigned)size;
 @end
 

bsnes/gb/Cocoa/GBApp.h

@@ -1,7 +1,8 @@
 #import <Cocoa/Cocoa.h>
 #import <WebKit/WebKit.h>
+#import <JoyKit/JoyKit.h>
 
-@interface AppDelegate : NSObject <NSApplicationDelegate, NSUserNotificationCenterDelegate, NSMenuDelegate, WebUIDelegate, WebPolicyDelegate, WebFrameLoadDelegate>
+@interface GBApp : NSApplication <NSApplicationDelegate, NSUserNotificationCenterDelegate, NSMenuDelegate, WebUIDelegate, WebPolicyDelegate, WebFrameLoadDelegate, JOYListener>
 
 @property (nonatomic, strong) IBOutlet NSWindow *preferencesWindow;
 @property (nonatomic, strong) IBOutlet NSView *graphicsTab;
@@ -21,5 +22,6 @@
 @property (strong) IBOutlet NSButton *updateProgressButton;
 @property (strong) IBOutlet NSWindow *updateProgressWindow;
 @property (strong) IBOutlet NSProgressIndicator *updateProgressSpinner;
+- (void)updateThemesDefault:(bool)overwrite;
 @end
 

bsnes/gb/Cocoa/GBApp.m

@@ -0,0 +1,817 @@
+#import "GBApp.h"
+#import "GBButtons.h"
+#import "GBView.h"
+#import "Document.h"
+#import "GBJoyConManager.h"
+#import <Core/gb.h>
+#import <Carbon/Carbon.h>
+#import <JoyKit/JoyKit.h>
+#import <WebKit/WebKit.h>
+#import <mach-o/dyld.h>
+#include <sys/mount.h>
+#include <sys/xattr.h>
+
+#define UPDATE_SERVER "https://sameboy.github.io"
+
+@interface NSToolbarItem(private)
+- (NSButton *)_view;
+@end
+
+static uint32_t color_to_int(NSColor *color)
+{
+    color = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
+    return (((unsigned)(color.redComponent * 0xFF)) << 16) |
+           (((unsigned)(color.greenComponent * 0xFF)) << 8) |
+           ((unsigned)(color.blueComponent * 0xFF));
+}
+
+@implementation GBApp
+{
+    NSArray<NSView *> *_preferencesTabs;
+    NSString *_lastVersion;
+    NSString *_updateURL;
+    NSURLSessionDownloadTask *_updateTask;
+    enum {
+        UPDATE_DOWNLOADING,
+        UPDATE_EXTRACTING,
+        UPDATE_WAIT_INSTALL,
+        UPDATE_INSTALLING,
+        UPDATE_FAILED,
+    } _updateState;
+    NSString *_downloadDirectory;
+    AuthorizationRef _auth;
+    bool _simulatingMenuEvent;
+}
+
+- (void) applicationDidFinishLaunching:(NSNotification *)notification
+{
+    // Refresh icon if launched via a software update
+    if (@available(macOS 26.0, *)) {
+        // Severely broken on macOS 26
+    }
+    else {
+        NSImage *icon = [[NSWorkspace sharedWorkspace] iconForFile:[[NSBundle mainBundle] bundlePath]];
+        icon.size = [NSApplication sharedApplication].applicationIconImage.size;
+        [NSApplication sharedApplication].applicationIconImage = icon;
+    }
+    
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    for (unsigned i = 0; i < GBKeyboardButtonCount; i++) {
+        if ([[defaults objectForKey:button_to_preference_name(i, 0)] isKindOfClass:[NSString class]]) {
+            [defaults removeObjectForKey:button_to_preference_name(i, 0)];
+        }
+    }
+    
+    bool hasSFMono = false;
+    if (@available(macOS 10.15, *)) {
+        hasSFMono = [[NSFont monospacedSystemFontOfSize:12 weight:NSFontWeightRegular].displayName containsString:@"SF"];
+    }
+    [[NSUserDefaults standardUserDefaults] registerDefaults:@{
+                                                              @"GBRight": @(kVK_RightArrow),
+                                                              @"GBLeft": @(kVK_LeftArrow),
+                                                              @"GBUp": @(kVK_UpArrow),
+                                                              @"GBDown": @(kVK_DownArrow),
+
+                                                              @"GBA": @(kVK_ANSI_X),
+                                                              @"GBB": @(kVK_ANSI_Z),
+                                                              @"GBSelect": @(kVK_Delete),
+                                                              @"GBStart": @(kVK_Return),
+
+                                                              @"GBTurbo": @(kVK_Space),
+                                                              @"GBRewind": @(kVK_Tab),
+                                                              @"GBSlow-Motion": @(kVK_Shift),
+
+                                                              @"GBFilter": @"NearestNeighbor",
+                                                              @"GBColorCorrection": @(GB_COLOR_CORRECTION_MODERN_BALANCED),
+                                                              @"GBHighpassFilter": @(GB_HIGHPASS_ACCURATE),
+                                                              @"GBRewindLength": @(120),
+                                                              @"GBFrameBlendingMode": @([defaults boolForKey:@"DisableFrameBlending"]? GB_FRAME_BLENDING_MODE_DISABLED : GB_FRAME_BLENDING_MODE_ACCURATE),
+                                                              
+                                                              @"GBDMGModel": @(GB_MODEL_DMG_B),
+                                                              @"GBCGBModel": @(GB_MODEL_CGB_E),
+                                                              @"GBAGBModel": @(GB_MODEL_AGB_A),
+                                                              @"GBSGBModel": @(GB_MODEL_SGB2),
+                                                              @"GBRumbleMode": @(GB_RUMBLE_CARTRIDGE_ONLY),
+                                                              
+                                                              @"GBVolume": @(1.0),
+                                                              
+                                                              @"GBMBC7JoystickOverride": @NO,
+                                                              @"GBMBC7AllowMouse": @YES,
+                                                              
+                                                              @"GBJoyConAutoPair": @YES,
+                                                              @"GBJoyConsDefaultsToHorizontal": @YES,
+                                                              
+                                                              @"GBEmulatedModel": @(MODEL_AUTO),
+                                                              
+                                                              @"GBDebuggerFont": hasSFMono? @"SF Mono" : @"Menlo",
+                                                              @"GBDebuggerFontSize": @12,
+                                                              
+                                                              @"GBColorPalette": @1,
+                                                              @"GBTurboCap": @0,
+                                                              
+                                                              // Default themes
+                                                              @"GBThemes": @{
+                                                                      @"Canyon": @{
+                                                                              @"BrightnessBias": @0.1227009965823247,
+                                                                              @"Colors": @[@0xff0c1e20, @0xff122b91, @0xff466aa2, @0xfff1efae, @0xfff1efae],
+                                                                              @"DisabledLCDColor": @NO,
+                                                                              @"HueBias": @0.01782661816105247,
+                                                                              @"HueBiasStrength": @1,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Desert": @{
+                                                                              @"BrightnessBias": @0.0,
+                                                                              @"Colors": @[@0xff302f3e, @0xff576674, @0xff839ba4, @0xffb1d0d2, @0xffb7d7d8],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.10087773904382469,
+                                                                              @"HueBiasStrength": @0.062142056772908363,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Evening": @{
+                                                                              @"BrightnessBias": @-0.10168700106441975,
+                                                                              @"Colors": @[@0xff362601, @0xff695518, @0xff899853, @0xffa6e4ae, @0xffa9eebb],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.60027079191058874,
+                                                                              @"HueBiasStrength": @0.33816297305747867,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Fog": @{
+                                                                              @"BrightnessBias": @0.0,
+                                                                              @"Colors": @[@0xff373c34, @0xff737256, @0xff9da386, @0xffc3d2bf, @0xffc7d8c6],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.55750435756972117,
+                                                                              @"HueBiasStrength": @0.18424738545816732,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Green Slate": @{
+                                                                              @"BrightnessBias": @0.2210012227296829,
+                                                                              @"Colors": @[@0xff343117, @0xff6a876f, @0xff98b4a1, @0xffc3daca, @0xffc8decf],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.1887667975388467,
+                                                                              @"HueBiasStrength": @0.1272283345460892,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Green Tea": @{
+                                                                              @"BrightnessBias": @-0.4946326622596153,
+                                                                              @"Colors": @[@0xff1a1d08, @0xff1d5231, @0xff3b9774, @0xff97e4c6, @0xffa9eed1],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.1912955007245464,
+                                                                              @"HueBiasStrength": @0.3621708039314516,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Lavender": @{
+                                                                              @"BrightnessBias": @0.10072476038566,
+                                                                              @"Colors": @[@0xff2b2a3a, @0xff8c507c, @0xffbf82a8, @0xffe9bcce, @0xffeec3d3],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.7914529587142169,
+                                                                              @"HueBiasStrength": @0.2498168498277664,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Magic Eggplant": @{
+                                                                              @"BrightnessBias": @0.0,
+                                                                              @"Colors": @[@0xff3c2136, @0xff942e84, @0xffc7699d, @0xfff1e4b0, @0xfff6f9b2],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.87717878486055778,
+                                                                              @"HueBiasStrength": @0.65018052788844627,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Mystic Blue": @{
+                                                                              @"BrightnessBias": @-0.3291049897670746,
+                                                                              @"Colors": @[@0xff3b2306, @0xffa27807, @0xffd1b523, @0xfff6ebbe, @0xfffaf1e4],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.5282051088288426,
+                                                                              @"HueBiasStrength": @0.7699633836746216,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Pink Pop": @{
+                                                                              @"BrightnessBias": @0.624908447265625,
+                                                                              @"Colors": @[@0xff28140a, @0xff7c42cb, @0xffaa83de, @0xffd1ceeb, @0xffd5d8ec],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.9477411056868732,
+                                                                              @"HueBiasStrength": @0.80024421215057373,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Radioactive Pea": @{
+                                                                              @"BrightnessBias": @-0.48079556772908372,
+                                                                              @"Colors": @[@0xff215200, @0xff1f7306, @0xff169e34, @0xff03ceb8, @0xff00d4d1],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.3795131972111554,
+                                                                              @"HueBiasStrength": @0.34337649402390436,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Rose": @{
+                                                                              @"BrightnessBias": @0.2727272808551788,
+                                                                              @"Colors": @[@0xff001500, @0xff4e1fae, @0xff865ac4, @0xffb7e6d3, @0xffbdffd4],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.9238900924101472,
+                                                                              @"HueBiasStrength": @0.9957716464996338,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Seaweed": @{
+                                                                              @"BrightnessBias": @-0.28532744023904377,
+                                                                              @"Colors": @[@0xff3f0015, @0xff426532, @0xff58a778, @0xff95e0df, @0xffa0e7ee],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.2694067480079681,
+                                                                              @"HueBiasStrength": @0.51565612549800799,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                                      @"Twilight": @{
+                                                                              @"BrightnessBias": @-0.091789093625498031,
+                                                                              @"Colors": @[@0xff3f0015, @0xff461286, @0xff6254bd, @0xff97d3e9, @0xffa0e7ee],
+                                                                              @"DisabledLCDColor": @YES,
+                                                                              @"HueBias": @0.0,
+                                                                              @"HueBiasStrength": @0.49710532868525897,
+                                                                              @"Manual": @NO,
+                                                                      },
+                                                              },
+                                                              
+                                                              @"NSToolbarItemForcesStandardSize": @YES, // Forces Monterey to resepect toolbar item sizes
+                                                              @"NSToolbarItemWarnOnMinMaxSize": @NO, // Not going to use Constraints, Apple
+                                                              }];
+    
+    [JOYController startOnRunLoop:[NSRunLoop currentRunLoop] withOptions:@{
+        JOYAxes2DEmulateButtonsKey: @YES,
+        JOYHatsEmulateButtonsKey: @YES,
+    }];
+    
+    [GBJoyConManager sharedInstance]; // Starts handling Joy-Cons
+    
+    [JOYController registerListener:self];
+    
+    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"GBNotificationsUsed"]) {
+        [NSUserNotificationCenter defaultUserNotificationCenter].delegate = self;
+    }
+    
+    [self askAutoUpdates];
+    
+    if ([[NSUserDefaults standardUserDefaults] boolForKey:@"GBAutoUpdatesEnabled"]) {
+        [self checkForUpdates];
+    }
+    
+    if ([[NSProcessInfo processInfo].arguments containsObject:@"--update-launch"]) {
+        [NSApp activateIgnoringOtherApps:true];
+    }
+    
+    if (![[[NSUserDefaults standardUserDefaults] stringForKey:@"GBThemesVersion"] isEqualToString:@(GB_VERSION)]) {
+        [self updateThemesDefault:false];
+        [[NSUserDefaults standardUserDefaults] setObject:@(GB_VERSION) forKey:@"GBThemesVersion"];
+    }
+}
+
+- (void)updateThemesDefault:(bool)overwrite
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSMutableDictionary *currentThemes = [defaults dictionaryForKey:@"GBThemes"].mutableCopy;
+    [defaults removeObjectForKey:@"GBThemes"];
+    NSMutableDictionary *defaultThemes = [defaults dictionaryForKey:@"GBThemes"].mutableCopy;
+    if (![[NSUserDefaults standardUserDefaults] stringForKey:@"GBThemesVersion"]) {
+        // Force update the Pink Pop theme, it was glitchy in 1.0
+        [currentThemes removeObjectForKey:@"Pink Pop"];
+    }
+    if (overwrite) {
+        [currentThemes addEntriesFromDictionary:defaultThemes];
+        [defaults setObject:currentThemes forKey:@"GBThemes"];
+    }
+    else {
+        [defaultThemes addEntriesFromDictionary:currentThemes];
+        [defaults setObject:defaultThemes forKey:@"GBThemes"];
+    }
+}
+
+- (IBAction)toggleDeveloperMode:(id)sender
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    [defaults setBool:![defaults boolForKey:@"DeveloperMode"] forKey:@"DeveloperMode"];
+}
+
+- (IBAction)switchPreferencesTab:(id)sender
+{
+    for (NSView *view in _preferencesTabs) {
+        [view removeFromSuperview];
+    }
+    NSView *tab = _preferencesTabs[[sender tag]];
+    NSRect old = [_preferencesWindow frame];
+    NSRect new = [_preferencesWindow frameRectForContentRect:tab.frame];
+    new.origin.x = old.origin.x;
+    new.origin.y = old.origin.y + (old.size.height - new.size.height);
+    [_preferencesWindow setFrame:new display:true animate:_preferencesWindow.visible];
+    [_preferencesWindow.contentView addSubview:tab];
+}
+
+- (BOOL)validateMenuItem:(NSMenuItem *)anItem
+{
+    if ([anItem action] == @selector(toggleDeveloperMode:)) {
+        [(NSMenuItem *)anItem setState:[[NSUserDefaults standardUserDefaults] boolForKey:@"DeveloperMode"]];
+    }
+    
+    if (anItem == self.linkCableMenuItem) {
+        return [[NSDocumentController sharedDocumentController] documents].count > 1;
+    }
+    return true;
+}
+
+- (void)menuNeedsUpdate:(NSMenu *)menu
+{
+    NSMutableArray *items = [NSMutableArray array];
+    NSDocument *currentDocument = [[NSDocumentController sharedDocumentController] currentDocument];
+    
+    for (NSDocument *document in [[NSDocumentController sharedDocumentController] documents]) {
+        if (document == currentDocument) continue;
+        NSMenuItem *item = [[NSMenuItem alloc] initWithTitle:document.displayName action:@selector(connectLinkCable:) keyEquivalent:@""];
+        item.representedObject = document;
+        item.image = [[NSWorkspace sharedWorkspace] iconForFile:document.fileURL.path];
+        [item.image setSize:NSMakeSize(16, 16)];
+        [items addObject:item];
+    }
+    [menu removeAllItems];
+    for (NSMenuItem *item in items) {
+        [menu addItem:item];
+    }
+}
+
+- (IBAction) showPreferences: (id) sender
+{
+    NSArray *objects;
+    if (!_preferencesWindow) {
+        [[NSBundle mainBundle] loadNibNamed:@"Preferences" owner:self topLevelObjects:&objects];
+        NSToolbarItem *first_toolbar_item = [_preferencesWindow.toolbar.items firstObject];
+        _preferencesWindow.toolbar.selectedItemIdentifier = [first_toolbar_item itemIdentifier];
+        _preferencesTabs = @[self.emulationTab, self.graphicsTab, self.audioTab, self.controlsTab, self.updatesTab];
+        [self switchPreferencesTab:first_toolbar_item];
+        [_preferencesWindow center];
+#ifndef UPDATE_SUPPORT
+        [_preferencesWindow.toolbar removeItemAtIndex:4];
+#endif
+        for (unsigned i = _preferencesWindow.toolbar.items.count; i--;) {
+            [_preferencesWindow.toolbar.items[i] _view].imageScaling = NSImageScaleNone;
+        }
+    }
+    [_preferencesWindow makeKeyAndOrderFront:self];
+}
+
+- (BOOL)applicationOpenUntitledFile:(NSApplication *)sender
+{
+    [self askAutoUpdates];
+    /* Bring an existing panel to the foreground */
+    for (NSWindow *window in [[NSApplication sharedApplication] windows]) {
+        if ([window isKindOfClass:[NSOpenPanel class]]) {
+            [(NSOpenPanel *)window makeKeyAndOrderFront:nil];
+            return true;
+        }
+    }
+    [[NSDocumentController sharedDocumentController] openDocument:self];
+    return true;
+}
+
+- (void)userNotificationCenter:(NSUserNotificationCenter *)center didActivateNotification:(NSUserNotification *)notification
+{
+    [[NSDocumentController sharedDocumentController] openDocumentWithContentsOfFile:notification.identifier display:true];
+}
+
+- (void)updateFound
+{
+    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@UPDATE_SERVER "/raw_changes"] completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
+        
+        NSColor *linkColor = [NSColor colorWithRed:0.125 green:0.325 blue:1.0 alpha:1.0];
+        if (@available(macOS 10.10, *)) {
+            linkColor = [NSColor linkColor];
+        }
+        
+        NSString *changes = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
+        NSRange cutoffRange = [changes rangeOfString:@"<!--(" GB_VERSION ")-->"];
+        if (cutoffRange.location != NSNotFound) {
+            changes = [changes substringToIndex:cutoffRange.location];
+        }
+        
+        NSString *html = [NSString stringWithFormat:@"<!DOCTYPE html><html><head><title></title>"
+                          "<style>html {background-color:transparent; color: #%06x; line-height:1.5} a:link, a:visited{color:#%06x; text-decoration:none}</style>"
+                          "</head><body>%@</body></html>",
+                          color_to_int([NSColor textColor]),
+                          color_to_int(linkColor),
+                          changes];
+        
+        if ([(NSHTTPURLResponse *)response statusCode] == 200) {
+            dispatch_async(dispatch_get_main_queue(), ^{
+                NSArray *objects;
+                [[NSBundle mainBundle] loadNibNamed:@"UpdateWindow" owner:self topLevelObjects:&objects];
+                if (@available(macOS 10.11, *)) {
+                    self.updateChanges.preferences.standardFontFamily = @"-apple-system";
+                }
+                else if (@available(macOS 10.10, *)) {
+                    self.updateChanges.preferences.standardFontFamily = @"Helvetica Neue";
+                }
+                else {
+                    self.updateChanges.preferences.standardFontFamily = @"Lucida Grande";
+                }
+                if (@available(macOS 10.15, *)) {
+                    self.updateChanges.preferences.fixedFontFamily = [NSFont monospacedSystemFontOfSize:12 weight:NSFontWeightRegular].displayName;
+                }
+                else {
+                    self.updateChanges.preferences.fixedFontFamily = @"Menlo";
+                }
+                self.updateChanges.drawsBackground = false;
+                [self.updateChanges.mainFrame loadHTMLString:html baseURL:nil];
+            });
+        }
+    }] resume];
+}
+
+- (NSArray *)webView:(WebView *)sender contextMenuItemsForElement:(NSDictionary *)element defaultMenuItems:(NSArray *)defaultMenuItems
+{
+    // Disable reload context menu
+    if ([defaultMenuItems count] <= 2) {
+        return nil;
+    }
+    return defaultMenuItems;
+}
+
+- (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame
+{
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        sender.mainFrame.frameView.documentView.enclosingScrollView.drawsBackground = true;
+        sender.mainFrame.frameView.documentView.enclosingScrollView.backgroundColor = [NSColor textBackgroundColor];
+        sender.policyDelegate = self;
+        [self.updateWindow center];
+        [self.updateWindow makeKeyAndOrderFront:nil];
+    });
+}
+
+- (void)webView:(WebView *)webView decidePolicyForNavigationAction:(NSDictionary *)actionInformation request:(NSURLRequest *)request frame:(WebFrame *)frame decisionListener:(id<WebPolicyDecisionListener>)listener
+{
+    [listener ignore];
+    [[NSWorkspace sharedWorkspace] openURL:[request URL]];
+}
+
+- (void)checkForUpdates
+{
+#ifdef UPDATE_SUPPORT
+    [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@UPDATE_SERVER "/latest_version"] completionHandler:^(NSData *data, NSURLResponse *response, NSError *error) {
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [self.updatesSpinner stopAnimation:nil];
+            [self.updatesButton setEnabled:true];
+        });
+        if ([(NSHTTPURLResponse *)response statusCode] == 200) {
+            NSString *string = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
+            NSArray <NSString *> *components = [string componentsSeparatedByString:@"|"];
+            if (components.count != 2) return;
+            _lastVersion = components[0];
+            _updateURL = components[1];
+            if (![@GB_VERSION isEqualToString:_lastVersion] &&
+                ![[[NSUserDefaults standardUserDefaults] stringForKey:@"GBSkippedVersion"] isEqualToString:_lastVersion]) {
+                [self updateFound];
+            }
+        }
+    }] resume];
+#endif
+}
+
+- (IBAction)userCheckForUpdates:(id)sender
+{
+    if (self.updateWindow) {
+        [self.updateWindow makeKeyAndOrderFront:sender];
+    }
+    else {
+        [[NSUserDefaults standardUserDefaults] setObject:nil forKey:@"GBSkippedVersion"];
+        [self checkForUpdates];
+        [sender setEnabled:false];
+        [self.updatesSpinner startAnimation:sender];
+    }
+}
+
+- (void)askAutoUpdates
+{
+#ifdef UPDATE_SUPPORT
+    if (![[NSUserDefaults standardUserDefaults] boolForKey:@"GBAskedAutoUpdates"]) {
+        NSAlert *alert = [[NSAlert alloc] init];
+        alert.messageText = @"Should SameBoy check for updates when launched?";
+        alert.informativeText = @"SameBoy is frequently updated with new features, accuracy improvements, and bug fixes. This setting can always be changed in the preferences window.";
+        [alert addButtonWithTitle:@"Check on Launch"];
+        [alert addButtonWithTitle:@"Don't Check on Launch"];
+        
+        [[NSUserDefaults standardUserDefaults] setBool:[alert runModal] == NSAlertFirstButtonReturn forKey:@"GBAutoUpdatesEnabled"];
+        [[NSUserDefaults standardUserDefaults] setBool:true forKey:@"GBAskedAutoUpdates"];
+    }
+#endif
+}
+
+- (IBAction)skipVersion:(id)sender
+{
+    [[NSUserDefaults standardUserDefaults] setObject:_lastVersion forKey:@"GBSkippedVersion"];
+    [self.updateWindow performClose:sender];
+}
+
+- (bool)executePath:(NSString *)path withArguments:(NSArray <NSString *> *)arguments
+{
+    if (!_auth) {
+        NSTask *task = [[NSTask alloc] init];
+        task.launchPath = path;
+        task.arguments = arguments;
+        [task launch];
+        [task waitUntilExit];
+        return task.terminationStatus == 0 && task.terminationReason == NSTaskTerminationReasonExit;
+    }
+    
+    char *argv[arguments.count + 1];
+    argv[arguments.count] = NULL;
+    for (unsigned i = 0; i < arguments.count; i++) {
+        argv[i] = (char *)arguments[i].UTF8String;
+    }
+    
+    return AuthorizationExecuteWithPrivileges(_auth, path.UTF8String, kAuthorizationFlagDefaults, argv, NULL) == errAuthorizationSuccess;
+}
+
+- (void)deauthorize
+{
+    if (_auth) {
+        AuthorizationFree(_auth, kAuthorizationFlagDefaults);
+        _auth = nil;
+    }
+}
+
+- (IBAction)installUpdate:(id)sender
+{
+    bool needsAuthorization = false;
+    if ([self executePath:@"/usr/sbin/spctl" withArguments:@[@"--status"]]) { // Succeeds when GateKeeper is on
+        // GateKeeper is on, we need to --add ourselves as root, else we might get a GateKeeper crash
+        needsAuthorization = true;
+    }
+    else if (access(_dyld_get_image_name(0), W_OK)) {
+        // We don't have write access, so we need authorization to update as root
+        needsAuthorization = true;
+    }
+    
+    if (needsAuthorization && !_auth) {
+        AuthorizationCreate(NULL, kAuthorizationEmptyEnvironment, kAuthorizationFlagPreAuthorize | kAuthorizationFlagInteractionAllowed, &_auth);
+        // Make sure we can modify the bundle
+        if (![self executePath:@"/usr/sbin/chown" withArguments:@[@"-R", [NSString stringWithFormat:@"%d:%d", getuid(), getgid()], [NSBundle mainBundle].bundlePath]]) {
+            [self deauthorize];
+            return;
+        }
+    }
+    
+    [self.updateProgressSpinner startAnimation:nil];
+    self.updateProgressButton.title = @"Cancel";
+    self.updateProgressButton.enabled = true;
+    self.updateProgressLabel.stringValue = @"Downloading update…";
+    _updateState = UPDATE_DOWNLOADING;
+    _updateTask = [[NSURLSession sharedSession] downloadTaskWithURL: [NSURL URLWithString:_updateURL] completionHandler:^(NSURL *location, NSURLResponse *response, NSError *error) {
+        _updateTask = nil;
+        dispatch_sync(dispatch_get_main_queue(), ^{
+            self.updateProgressButton.enabled = false;
+            self.updateProgressLabel.stringValue = @"Extracting update…";
+            _updateState = UPDATE_EXTRACTING;
+        });
+        
+        _downloadDirectory = [[[NSFileManager defaultManager] URLForDirectory:NSItemReplacementDirectory
+                                                                     inDomain:NSUserDomainMask
+                                                            appropriateForURL:[[NSBundle mainBundle] bundleURL]
+                                                                       create:true
+                                                                        error:nil] path];
+        if (!_downloadDirectory) {
+            [self deauthorize];
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                self.updateProgressButton.enabled = false;
+                self.updateProgressLabel.stringValue = @"Failed to extract update.";
+                _updateState = UPDATE_FAILED;
+                self.updateProgressButton.title = @"Close";
+                self.updateProgressButton.enabled = true;
+                [self.updateProgressSpinner stopAnimation:nil];
+            });
+            return;
+        }
+        
+        NSTask *unzipTask;
+        unzipTask = [[NSTask alloc] init];
+        unzipTask.launchPath = @"/usr/bin/unzip";
+        unzipTask.arguments = @[location.path, @"-d", _downloadDirectory];
+        [unzipTask launch];
+        [unzipTask waitUntilExit];
+        if (unzipTask.terminationStatus != 0 || unzipTask.terminationReason != NSTaskTerminationReasonExit) {
+            [self deauthorize];
+            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                self.updateProgressButton.enabled = false;
+                self.updateProgressLabel.stringValue = @"Failed to extract update.";
+                _updateState = UPDATE_FAILED;
+                self.updateProgressButton.title = @"Close";
+                self.updateProgressButton.enabled = true;
+                [self.updateProgressSpinner stopAnimation:nil];
+            });
+            return;
+        }
+        
+        dispatch_sync(dispatch_get_main_queue(), ^{
+            self.updateProgressButton.enabled = false;
+            self.updateProgressLabel.stringValue = @"Update ready, save your game progress and click Install.";
+            _updateState = UPDATE_WAIT_INSTALL;
+            self.updateProgressButton.title = @"Install";
+            self.updateProgressButton.enabled = true;
+            [self.updateProgressSpinner stopAnimation:nil];
+        });
+    }];
+    [_updateTask resume];
+    
+    self.updateProgressWindow.preventsApplicationTerminationWhenModal = false;
+    [self.updateWindow beginSheet:self.updateProgressWindow completionHandler:^(NSModalResponse returnCode) {
+        [self.updateWindow close];
+    }];
+}
+
+- (void)performUpgrade
+{
+    self.updateProgressButton.enabled = false;
+    self.updateProgressLabel.stringValue = @"Instaling update…";
+    _updateState = UPDATE_INSTALLING;
+    self.updateProgressButton.enabled = false;
+    [self.updateProgressSpinner startAnimation:nil];
+    dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
+        NSString *executablePath = [[NSBundle mainBundle] executablePath];
+        NSString *contentsPath = [[[NSBundle mainBundle] bundlePath] stringByAppendingPathComponent:@"Contents"];
+        NSString *contentsTempPath = [[[NSBundle mainBundle] bundlePath] stringByAppendingPathComponent:@"TempContents"];
+        NSString *updateContentsPath = [_downloadDirectory stringByAppendingPathComponent:@"SameBoy.app/Contents"];
+        NSError *error = nil;
+        [[NSFileManager defaultManager] moveItemAtPath:contentsPath toPath:contentsTempPath error:&error];
+        if (error) {
+            [self deauthorize];
+            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
+            _downloadDirectory = nil;
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                self.updateProgressButton.enabled = false;
+                self.updateProgressLabel.stringValue = @"Failed to install update.";
+                _updateState = UPDATE_FAILED;
+                self.updateProgressButton.title = @"Close";
+                self.updateProgressButton.enabled = true;
+                [self.updateProgressSpinner stopAnimation:nil];
+            });
+            return;
+        }
+        [[NSFileManager defaultManager] moveItemAtPath:updateContentsPath toPath:contentsPath error:&error];
+        if (error) {
+            [self deauthorize];
+            [[NSFileManager defaultManager] moveItemAtPath:contentsTempPath toPath:contentsPath error:nil];
+            [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
+            _downloadDirectory = nil;
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                self.updateProgressButton.enabled = false;
+                self.updateProgressLabel.stringValue = @"Failed to install update.";
+                _updateState = UPDATE_FAILED;
+                self.updateProgressButton.title = @"Close";
+                self.updateProgressButton.enabled = true;
+                [self.updateProgressSpinner stopAnimation:nil];
+            });
+            return;
+        }
+        [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
+        [[NSFileManager defaultManager] removeItemAtPath:contentsTempPath error:nil];
+        
+        // Remove the quarantine flag so we don't have to escape translocation
+        NSString *bundlePath = [NSBundle mainBundle].bundlePath;
+        removexattr(bundlePath.UTF8String, "com.apple.quarantine", 0);
+        for (NSString *path in [[NSFileManager defaultManager] enumeratorAtPath:bundlePath]) {
+            removexattr([bundlePath stringByAppendingPathComponent:path].UTF8String, "com.apple.quarantine", 0);
+        };
+        
+        _downloadDirectory = nil;
+        atexit_b(^{
+            execl(executablePath.UTF8String, executablePath.UTF8String, "--update-launch", NULL);
+        });
+        
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [NSApp terminate:nil];
+        });
+    });
+}
+
+- (IBAction)updateAction:(id)sender
+{
+    switch (_updateState) {
+        case UPDATE_DOWNLOADING:
+            [_updateTask cancelByProducingResumeData:nil];
+            _updateTask = nil;
+            [self.updateProgressWindow close];
+            break;
+        case UPDATE_WAIT_INSTALL:
+            [self performUpgrade];
+            break;
+        case UPDATE_EXTRACTING:
+        case UPDATE_INSTALLING:
+            break;
+        case UPDATE_FAILED:
+            [self.updateProgressWindow close];
+            break;
+    }
+}
+
+- (void)orderFrontAboutPanel:(id)sender
+{
+    // NSAboutPanelOptionApplicationIcon is not available prior to 10.13, but the key is still there and working.
+    [[NSApplication sharedApplication] orderFrontStandardAboutPanelWithOptions:@{
+        @"ApplicationIcon": [NSImage imageNamed:@"Icon"]
+    }];
+}
+
+- (void)controller:(JOYController *)controller buttonChangedState:(JOYButton *)button
+{
+    if (!button.isPressed) return;
+    NSDictionary *mapping = [[NSUserDefaults standardUserDefaults] dictionaryForKey:@"JoyKitInstanceMapping"][controller.uniqueID];
+    if (!mapping) {
+        mapping = [[NSUserDefaults standardUserDefaults] dictionaryForKey:@"JoyKitNameMapping"][controller.deviceName];
+    }
+    
+    JOYButtonUsage usage = ((JOYButtonUsage)[mapping[n2s(button.uniqueID)] unsignedIntValue]) ?: -1;
+    if (!mapping && usage >= JOYButtonUsageGeneric0) {
+        usage = GB_inline_const(JOYButtonUsage[], {JOYButtonUsageY, JOYButtonUsageA, JOYButtonUsageB, JOYButtonUsageX})[(usage - JOYButtonUsageGeneric0) & 3];
+    }
+    
+    if (usage == GBJoyKitHotkey1 || usage == GBJoyKitHotkey2) {
+        if (_preferencesWindow && self.keyWindow == _preferencesWindow) {
+            return;
+        }
+        if (![[NSUserDefaults standardUserDefaults] boolForKey:@"GBAllowBackgroundControllers"] && !self.keyWindow) {
+            return;
+        }
+
+        NSString *keyEquivalent = [[NSUserDefaults standardUserDefaults] stringForKey:usage == GBJoyKitHotkey1? @"GBJoypadHotkey1" : @"GBJoypadHotkey2"];
+        NSEventModifierFlags flags = NSEventModifierFlagCommand;
+        if ([keyEquivalent hasPrefix:@"^"]) {
+            flags |= NSEventModifierFlagShift;
+            [keyEquivalent substringFromIndex:1];
+        }
+        _simulatingMenuEvent = true;
+        [[NSApplication sharedApplication] sendEvent:[NSEvent keyEventWithType:NSEventTypeKeyDown
+                                                                                 location:(NSPoint){0,}
+                                                                            modifierFlags:flags
+                                                                                timestamp:0
+                                                                             windowNumber:0
+                                                                                  context:NULL
+                                                                               characters:keyEquivalent
+                                                              charactersIgnoringModifiers:keyEquivalent
+                                                                                isARepeat:false
+                                                                                  keyCode:0]];
+        _simulatingMenuEvent = false;
+    }
+}
+
+- (NSWindow *)keyWindow
+{
+    NSWindow *ret = [super keyWindow];
+    if (!ret && _simulatingMenuEvent) {
+        ret = [(Document *)self.orderedDocuments.firstObject mainWindow];
+    }
+    return ret;
+}
+
+- (NSWindow *)mainWindow
+{
+    NSWindow *ret = [super mainWindow];
+    if (!ret && _simulatingMenuEvent) {
+        ret = [(Document *)self.orderedDocuments.firstObject mainWindow];
+    }
+    return ret;
+}
+
+- (IBAction)openDebuggerHelp:(id)sender
+{
+    [[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:@"https://sameboy.github.io/debugger/"]];
+}
+
+- (IBAction)openSponsor:(id)sender
+{
+    [[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:@"https://github.com/sponsors/LIJI32"]];
+}
+
+- (void)dealloc
+{
+    if (_downloadDirectory) {
+        [[NSFileManager defaultManager] removeItemAtPath:_downloadDirectory error:nil];
+    }
+}
+
+- (IBAction)nop:(id)sender
+{
+}
+
+/* This runs before C constructors. If we need to escape translocation, we should
+   do it ASAP to minimize our launch time. */
+
++ (void)load
+{
+    if (@available(macOS 10.12, *)) {
+        /* Detect and escape translocation so we can safely update ourselves */
+        if ([[[NSBundle mainBundle] bundlePath] containsString:@"/AppTranslocation/"]) {
+            const char *mountPath = [[[[NSBundle mainBundle] bundlePath] stringByDeletingLastPathComponent] stringByDeletingLastPathComponent].UTF8String;
+            struct statfs *mntbuf;
+            int mntsize = getmntinfo(&mntbuf, MNT_NOWAIT);
+            for (unsigned i = 0; i < mntsize; i++) {
+                if (strcmp(mntbuf[i].f_mntonname, mountPath) == 0) {
+                    NSBundle *origBundle = [NSBundle bundleWithPath:@(mntbuf[i].f_mntfromname)];
+                    
+                    execl(origBundle.executablePath.UTF8String, origBundle.executablePath.UTF8String, NULL);
+                    break;
+                }
+            }
+        }
+    }
+}
+@end

bsnes/gb/Cocoa/GBButtons.h

@@ -1,7 +1,4 @@
-#ifndef GBButtons_h
-#define GBButtons_h
-
-typedef enum : NSUInteger {
+typedef enum {
     GBRight,
     GBLeft,
     GBUp,
@@ -10,14 +7,24 @@ typedef enum : NSUInteger {
     GBB,
     GBSelect,
     GBStart,
+    GBRapidA,
+    GBRapidB,
     GBTurbo,
     GBRewind,
     GBUnderclock,
-    GBButtonCount,
-    GBGameBoyButtonCount = GBStart + 1,
+    GBHotkey1,
+    GBHotkey2,
+    GBTotalButtonCount,
+    GBKeyboardButtonCount =  GBUnderclock + 1,
+    GBPerPlayerButtonCount = GBRapidB + 1,
 } GBButton;
 
-extern NSString const *GBButtonNames[GBButtonCount];
+#define GBJoyKitHotkey1 JOYButtonUsageGeneric0 + 0x100
+#define GBJoyKitHotkey2 JOYButtonUsageGeneric0 + 0x101
+#define GBJoyKitRapidA JOYButtonUsageGeneric0 + 0x102
+#define GBJoyKitRapidB JOYButtonUsageGeneric0 + 0x103
+
+extern NSString const *GBButtonNames[GBTotalButtonCount];
 
 static inline NSString *n2s(uint64_t number)
 {
@@ -31,5 +38,3 @@ static inline NSString *button_to_preference_name(GBButton button, unsigned play
     }
     return [NSString stringWithFormat:@"GB%@", GBButtonNames[button]];
 }
-
-#endif

bsnes/gb/Cocoa/GBButtons.m

@@ -1,4 +1,4 @@
 #import <Foundation/Foundation.h>
 #import "GBButtons.h"
 
-NSString const *GBButtonNames[] = {@"Right", @"Left", @"Up", @"Down", @"A", @"B", @"Select", @"Start", @"Turbo", @"Rewind", @"Slow-Motion"};
+NSString const *GBButtonNames[] = {@"Right", @"Left", @"Up", @"Down", @"A", @"B", @"Select", @"Start", @"Rapid A", @"Rapid B", @"Turbo", @"Rewind", @"Slow-Motion", @"Hotkey 1", @"Hotkey 2"};

bsnes/gb/Cocoa/GBCPUView.h

@@ -0,0 +1,5 @@
+#import <Cocoa/Cocoa.h>
+
+@interface GBCPUView : NSView
+- (void)addSample:(double)sample;
+@end

bsnes/gb/Cocoa/GBCPUView.m

@@ -0,0 +1,126 @@
+#import "GBCPUView.h"
+
+#define SAMPLE_COUNT 0x100 // ~4 seconds
+
+@implementation GBCPUView
+{
+    double _samples[SAMPLE_COUNT];
+    size_t _position;
+}
+
+- (void)drawRect:(NSRect)dirtyRect
+{
+    CGRect bounds = self.bounds;
+    NSSize size = bounds.size;
+    unsigned factor = [[self.window screen] backingScaleFactor];
+    
+    NSBitmapImageRep *maskBitmap = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes:NULL
+                                                                           pixelsWide:(unsigned)size.width * factor
+                                                                           pixelsHigh:(unsigned)size.height * factor
+                                                                        bitsPerSample:8
+                                                                      samplesPerPixel:2
+                                                                             hasAlpha:true
+                                                                             isPlanar:false
+                                                                       colorSpaceName:NSDeviceWhiteColorSpace
+                                                                          bytesPerRow:size.width * 2 * factor
+                                                                         bitsPerPixel:16];
+    
+
+    
+    NSGraphicsContext *mainContext = [NSGraphicsContext currentContext];
+    
+    
+    NSColor *greenColor, *redColor;
+    if (@available(macOS 10.10, *)) {
+        greenColor = [NSColor systemGreenColor];
+        redColor = [NSColor systemRedColor];
+    }
+    else {
+        greenColor = [NSColor colorWithRed:3.0 / 16 green:0.5 blue:5.0 / 16 alpha:1.0];
+        redColor = [NSColor colorWithRed:13.0 / 16 green:0.25 blue:0.25 alpha:1.0];
+    }
+    
+
+    NSBitmapImageRep *colorBitmap = [[NSBitmapImageRep alloc] initWithBitmapDataPlanes:NULL
+                                                                            pixelsWide:SAMPLE_COUNT
+                                                                            pixelsHigh:1
+                                                                         bitsPerSample:8
+                                                                       samplesPerPixel:3
+                                                                              hasAlpha:false
+                                                                              isPlanar:false
+                                                                        colorSpaceName:NSDeviceRGBColorSpace
+                                                                           bytesPerRow:SAMPLE_COUNT * 4
+                                                                          bitsPerPixel:32];
+
+    unsigned lastFill = 0;
+    NSBezierPath *line = [NSBezierPath bezierPath];
+    bool isRed = false;
+    {
+        double sample = _samples[_position % SAMPLE_COUNT];
+        [line moveToPoint:NSMakePoint(0,
+                                      (sample * (size.height - 1) + 0.5) * factor)];
+        isRed = sample == 1;
+    }
+    
+    
+    [NSGraphicsContext setCurrentContext:[NSGraphicsContext graphicsContextWithBitmapImageRep:colorBitmap]];
+    for (unsigned i = 1; i < SAMPLE_COUNT; i++) {
+        double sample = _samples[(i + _position) % SAMPLE_COUNT];
+        [line lineToPoint:NSMakePoint(size.width * i * factor / (SAMPLE_COUNT - 1),
+                                      (sample * (size.height - 1) + 0.5) * factor)];
+        
+        if (isRed != (sample == 1)) {
+            // Color changed
+            [(isRed? redColor : greenColor) setFill];
+            NSRectFill(CGRectMake(lastFill, 0, i - lastFill, 1));
+            lastFill = i;
+            
+            isRed ^= true;
+        }
+    }
+    [(isRed? redColor : greenColor) setFill];
+    NSRectFill(CGRectMake(lastFill, 0, SAMPLE_COUNT - lastFill, 1));
+    
+    NSBezierPath *fill = [line copy];
+    [fill lineToPoint:NSMakePoint(size.width * factor, 0)];
+    [fill lineToPoint:NSMakePoint(0, 0)];
+    
+    NSColor *strokeColor = [NSColor whiteColor];
+    NSColor *fillColor = [strokeColor colorWithAlphaComponent:1 / 3.0];
+    
+    [NSGraphicsContext setCurrentContext:[NSGraphicsContext graphicsContextWithBitmapImageRep:maskBitmap]];
+    [fillColor setFill];
+    [fill fill];
+    
+    [strokeColor setStroke];
+    [line setLineWidth:factor];
+    [line stroke];
+    
+    CGContextRef maskContext = CGContextRetain([NSGraphicsContext currentContext].graphicsPort);
+    [NSGraphicsContext setCurrentContext:mainContext];
+    CGContextSaveGState(mainContext.graphicsPort);
+    
+    CGImageRef maskImage = CGBitmapContextCreateImage(maskContext);
+    CGContextClipToMask(mainContext.graphicsPort, bounds, maskImage);
+    CGImageRelease(maskImage);
+    
+    NSImage *colors = [[NSImage alloc] initWithSize:NSMakeSize(SAMPLE_COUNT, 1)];
+    [colors addRepresentation:colorBitmap];
+    [colors drawInRect:bounds];
+    
+    CGContextRestoreGState(mainContext.graphicsPort);
+    CGContextRelease(maskContext);
+    
+    
+    [super drawRect:dirtyRect];
+}
+
+- (void)addSample:(double)sample
+{
+    _samples[_position++] = sample;
+    if (_position == SAMPLE_COUNT) {
+        _position = 0;
+    }
+}
+
+@end

bsnes/gb/Cocoa/GBCenteredTextCell.h

@@ -0,0 +1,5 @@
+#import <Cocoa/Cocoa.h>
+
+@interface GBCenteredTextCell : NSTextFieldCell
+
+@end

bsnes/gb/Cocoa/GBCenteredTextCell.m

@@ -0,0 +1,29 @@
+#import "GBCenteredTextCell.h"
+
+@implementation GBCenteredTextCell
+- (void)drawInteriorWithFrame:(NSRect)cellFrame inView:(NSView *)controlView
+{
+    double height = round([self.attributedStringValue size].height);
+    cellFrame.origin.y += (cellFrame.size.height - height) / 2;
+    cellFrame.size.height = height;
+    [super drawInteriorWithFrame:cellFrame inView:controlView];
+}
+
+
+- (void)selectWithFrame:(NSRect)rect inView:(NSView *)controlView editor:(NSText *)textObj delegate:(id)delegate start:(NSInteger)selStart length:(NSInteger)selLength
+{
+    double height = round([self.attributedStringValue size].height);
+    rect.origin.y += (rect.size.height - height) / 2;
+    rect.size.height = height;
+    [super selectWithFrame:rect inView:controlView editor:textObj delegate:delegate start:selStart length:selLength];
+}
+
+- (void)editWithFrame:(NSRect)rect inView:(NSView *)controlView editor:(NSText *)textObj delegate:(id)delegate event:(NSEvent *)event
+{
+    double height = round([self.attributedStringValue size].height);
+    rect.origin.y += (rect.size.height - height) / 2;
+    rect.size.height = height;
+    [super editWithFrame:rect inView:controlView editor:textObj delegate:delegate event:event];
+
+}
+@end

bsnes/gb/Cocoa/GBCheatSearchController.h

@@ -0,0 +1,8 @@
+#import <AppKit/AppKit.h>
+#import "Document.h"
+
+@interface GBCheatSearchController<NSTableViewDelegate, NSTableViewDataSource, NSControlTextEditingDelegate> : NSObject
+@property IBOutlet NSWindow *window;
+@property IBOutlet NSTableView *tableView;
++ (instancetype)controllerWithDocument:(Document *)document;
+@end

bsnes/gb/Cocoa/GBCheatSearchController.m

@@ -0,0 +1,234 @@
+#import "GBCheatSearchController.h"
+#import "GBWarningPopover.h"
+#import "GBCheatWindowController.h"
+#import "GBPanel.h"
+
+@interface GBCheatSearchController() <NSTableViewDelegate, NSTableViewDataSource>
+@property IBOutlet NSPopUpButton *dataTypeButton;
+@property IBOutlet NSPopUpButton *conditionTypeButton;
+@property IBOutlet NSTextField *operandField;
+@property IBOutlet NSTextField *conditionField;
+@property IBOutlet NSTextField *resultsLabel;
+@property (strong) IBOutlet NSButton *addCheatButton;
+@end
+
+@implementation GBCheatSearchController
+{
+    __weak Document *_document;
+    size_t _resultCount;
+    GB_cheat_search_result_t *_results;
+    GBPanel *_window;
+}
+
++ (instancetype)controllerWithDocument:(Document *)document
+{
+    GBCheatSearchController *ret = [[self alloc] init];
+    ret->_document = document;
+    NSArray *objects;
+    [[NSBundle mainBundle] loadNibNamed:@"CheatSearch" owner:ret topLevelObjects:&objects];
+    ret->_resultsLabel.stringValue = @"";
+    ret->_resultsLabel.cell.backgroundStyle = NSBackgroundStyleRaised;
+    ret->_window.ownerWindow = document.mainWindow;
+    return ret;
+}
+
+- (IBAction)reset:(id)sender
+{
+    _dataTypeButton.enabled = true;
+    [_document performAtomicBlock:^{
+        GB_cheat_search_reset(_document.gb);
+    }];
+    _resultCount = 0;
+    if (_results) {
+        free(_results);
+        _results = NULL;
+    }
+    [_tableView reloadData];
+    _resultsLabel.stringValue = @"";
+}
+
+- (IBAction)search:(id)sender
+{
+    // Dispatch to work around firstResponder oddities
+    dispatch_async(dispatch_get_main_queue(), ^{
+        if ([sender isKindOfClass:[NSTextField class]]) {
+            // Action sent by losing focus rather than pressing enter
+            if (![sender currentEditor]) return;
+        }
+        _dataTypeButton.enabled = false;
+        [_document performAtomicBlock:^{
+            __block bool success = false;
+            NSString *error = [_document captureOutputForBlock:^{
+                success = GB_cheat_search_filter(_document.gb, _conditionField.stringValue.UTF8String, _dataTypeButton.selectedTag);
+            }];
+            if (!success) {
+                dispatch_async(dispatch_get_main_queue(), ^{
+                    [GBWarningPopover popoverWithContents:error onView:_conditionField];
+                    NSBeep();
+                });
+                return;
+            }
+            _resultCount = GB_cheat_search_result_count(_document.gb);
+            _results = malloc(sizeof(*_results) * _resultCount);
+            GB_cheat_search_get_results(_document.gb, _results);
+        }];
+        if (_resultCount == 0) {
+            _dataTypeButton.enabled = true;
+            _resultsLabel.stringValue = @"No results.";
+        }
+        else {
+            _resultsLabel.stringValue = [NSString stringWithFormat:@"%@ result%s",
+                                         [NSNumberFormatter localizedStringFromNumber:@(_resultCount)
+                                                                          numberStyle:NSNumberFormatterDecimalStyle],
+                                         _resultCount > 1? "s" : ""];
+        }
+        [_tableView reloadData];
+    });
+}
+
+- (IBAction)conditionChanged:(id)sender
+{
+    unsigned index = [_conditionTypeButton indexOfSelectedItem];
+    _conditionField.enabled = index == 11;
+    _operandField.enabled = index >= 1 && index <= 6;
+    switch ([_conditionTypeButton indexOfSelectedItem]) {
+        case 0: _conditionField.stringValue = @"1"; break;
+        case 1: _conditionField.stringValue = [NSString stringWithFormat:@"new == (%@)", _operandField.stringValue]; break;
+        case 2: _conditionField.stringValue = [NSString stringWithFormat:@"new != (%@)", _operandField.stringValue]; break;
+        case 3: _conditionField.stringValue = [NSString stringWithFormat:@"new > (%@)", _operandField.stringValue]; break;
+        case 4: _conditionField.stringValue = [NSString stringWithFormat:@"new >= (%@)", _operandField.stringValue]; break;
+        case 5: _conditionField.stringValue = [NSString stringWithFormat:@"new < (%@)", _operandField.stringValue]; break;
+        case 6: _conditionField.stringValue = [NSString stringWithFormat:@"new <= (%@)", _operandField.stringValue]; break;
+        case 7: _conditionField.stringValue = @"new != old"; break;
+        case 8: _conditionField.stringValue = @"new == old"; break;
+        case 9: _conditionField.stringValue = @"new > old"; break;
+        case 10: _conditionField.stringValue = @"new < old"; break;
+    }
+}
+
+- (NSInteger)numberOfRowsInTableView:(NSTableView *)tableView
+{
+    return _resultCount;
+}
+
+- (uint8_t *)addressForRow:(unsigned)row
+{
+    uint8_t *base;
+    uint32_t offset;
+    if (_results[row].addr < 0xc000) {
+        base = GB_get_direct_access(_document.gb, GB_DIRECT_ACCESS_CART_RAM, NULL, NULL);
+        offset = (_results[row].addr & 0x1FFF) + _results[row].bank * 0x2000;
+    }
+    else if (_results[row].addr < 0xe000) {
+        base = GB_get_direct_access(_document.gb, GB_DIRECT_ACCESS_RAM, NULL, NULL);
+        offset = (_results[row].addr & 0xFFF) + _results[row].bank * 0x1000;
+    }
+    else {
+        base = GB_get_direct_access(_document.gb, GB_DIRECT_ACCESS_HRAM, NULL, NULL);
+        offset = (_results[row].addr & 0x7F);
+    }
+    return base + offset;
+}
+
+- (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    switch ([[tableView tableColumns] indexOfObject:tableColumn]) {
+        case 0:
+            return [NSString stringWithFormat:@"$%02x:$%04x", _results[row].bank, _results[row].addr];
+        case 1:
+            if (_dataTypeButton.selectedTag & GB_CHEAT_SEARCH_DATA_TYPE_16BIT) {
+                return [NSString stringWithFormat:@"$%04x", _results[row].value];
+            }
+            return [NSString stringWithFormat:@"$%02x", _results[row].value];
+        default: {
+            const uint8_t *data = [self addressForRow:row];
+            GB_cheat_search_data_type_t dataType = _dataTypeButton.selectedTag;
+            uint16_t value = data[0];
+            if (!(dataType & GB_CHEAT_SEARCH_DATA_TYPE_16BIT)) {
+                return [NSString stringWithFormat:@"$%02x", value];
+            }
+            value |= data[1] << 8;
+            if ((dataType & GB_CHEAT_SEARCH_DATA_TYPE_BE_BIT)) {
+                value = __builtin_bswap16(value);
+            }
+            return [NSString stringWithFormat:@"$%04x", value];
+        }
+    }
+}
+
+- (void)tableView:(NSTableView *)tableView setObjectValue:(NSString *)object forTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    [_document performAtomicBlock:^{
+        __block bool success = false;
+        __block uint16_t value;
+        NSString *error = [_document captureOutputForBlock:^{
+            success = !GB_debugger_evaluate(_document.gb, object.UTF8String, &value, NULL);
+        }];
+        if (!success) {
+            dispatch_async(dispatch_get_main_queue(), ^{
+                [GBWarningPopover popoverWithContents:error onView:tableView];
+                NSBeep();
+            });
+            return;
+        }
+        uint8_t *dest = [self addressForRow:row];
+        GB_cheat_search_data_type_t dataType = _dataTypeButton.selectedTag;
+        if (dataType & GB_CHEAT_SEARCH_DATA_TYPE_BE_BIT) {
+            value = __builtin_bswap16(value);
+        }
+        dest[0] = value;
+        if (dataType & GB_CHEAT_SEARCH_DATA_TYPE_16BIT) {
+            dest[1] = value >> 8;
+        }
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [tableView reloadData];
+        });
+    }];
+}
+
+- (void)controlTextDidChange:(NSNotification *)obj
+{
+    [self conditionChanged:nil];
+}
+
+- (IBAction)addCheat:(id)sender
+{
+    GB_cheat_search_result_t *result = _results + _tableView.selectedRow;
+    uint8_t *data = [self addressForRow:_tableView.selectedRow];
+    GB_cheat_search_data_type_t dataType = _dataTypeButton.selectedTag;
+    size_t rowToSelect = 0;
+    GB_get_cheats(_document.gb, &rowToSelect);
+    [_document performAtomicBlock:^{
+        GB_add_cheat(_document.gb,
+                     (dataType & GB_CHEAT_SEARCH_DATA_TYPE_16BIT)? "New Cheat (Part 1)" : "New Cheat",
+                     result->addr, result->bank,
+                     *data,
+                     0, false,
+                     true);
+        if (dataType & GB_CHEAT_SEARCH_DATA_TYPE_16BIT) {
+            GB_add_cheat(_document.gb,
+                         (dataType & GB_CHEAT_SEARCH_DATA_TYPE_16BIT)? "New Cheat (Part 2)" : "New Cheat",
+                         result->addr + 1, result->bank,
+                         data[1],
+                         0, false,
+                         true);
+        }
+        GB_set_cheats_enabled(_document.gb, true);
+    }];
+    [_document.cheatsWindow makeKeyAndOrderFront:nil];
+    [_document.cheatWindowController.cheatsTable reloadData];
+    [_document.cheatWindowController.cheatsTable selectRow:rowToSelect byExtendingSelection:false];
+    [_document.cheatWindowController.cheatsTable.delegate tableViewSelectionDidChange:nil];
+}
+
+- (void)tableViewSelectionDidChange:(NSNotification *)notification
+{
+    _addCheatButton.enabled = _tableView.numberOfSelectedRows != 0;
+}
+
+- (void)dealloc
+{
+    if (_results) free(_results);
+}
+
+@end

bsnes/gb/Cocoa/GBCheatTextFieldCell.m

@@ -6,7 +6,7 @@
 
 @implementation GBCheatTextView
 
-- (bool)_insertText:(NSString *)string replacementRange:(NSRange)range
+- (bool)_internalInsertText:(NSString *)string replacementRange:(NSRange)range
 {
     if (range.location == NSNotFound) {
         range = self.selectedRange;
@@ -60,19 +60,19 @@
             return true;
         }
         if (([string isEqualToString:@"$"] || [string isEqualToString:@":"]) && range.length == 0 && range.location == 0) {
-            if ([self _insertText:@"$00:" replacementRange:range]) {
+            if ([self _internalInsertText:@"$00:" replacementRange:range]) {
                 self.selectedRange = NSMakeRange(1, 2);
                 return true;
             }
         }
         if ([string isEqualToString:@":"] && range.length + range.location == self.string.length) {
-            if ([self _insertText:@":$0" replacementRange:range]) {
+            if ([self _internalInsertText:@":$0" replacementRange:range]) {
                 self.selectedRange = NSMakeRange(self.string.length - 2, 2);
                 return true;
             }
         }
         if ([string isEqualToString:@"$"]) {
-            if ([self _insertText:@"$0" replacementRange:range]) {
+            if ([self _internalInsertText:@"$0" replacementRange:range]) {
                 self.selectedRange = NSMakeRange(range.location + 1, 1);
                 return true;
             }
@@ -88,8 +88,10 @@
 
 - (void)insertText:(id)string replacementRange:(NSRange)replacementRange
 {
-    if (![self _insertText:string replacementRange:replacementRange]) {
-        NSBeep();
+    if (![self _internalInsertText:string replacementRange:replacementRange]) {
+        if (![self _internalInsertText:[@"$" stringByAppendingString:string] replacementRange:replacementRange]) {
+            NSBeep();
+        }
     }
 }
 

bsnes/gb/Cocoa/GBCheatWindowController.m

@@ -42,7 +42,7 @@
     return nil;
 }
 
-- (nullable id)tableView:(NSTableView *)tableView objectValueForTableColumn:(nullable NSTableColumn *)tableColumn row:(NSInteger)row
+- (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
 {
     size_t cheatCount;
     GB_gameboy_t *gb = self.document.gameboy;
@@ -58,7 +58,7 @@
                 return @NO;
                 
             case 2:
-                return @"Add Cheat...";
+                return @"Add Cheat…";
             
             case 3:
                 return @"";
@@ -92,14 +92,18 @@
                             self.importCodeField.stringValue.UTF8String,
                             self.importDescriptionField.stringValue.UTF8String,
                             true)) {
-            self.importCodeField.stringValue = @"";
-            self.importDescriptionField.stringValue = @"";
-            [self.cheatsTable reloadData];
-            [self tableViewSelectionDidChange:nil];
+            dispatch_async(dispatch_get_main_queue(), ^{
+                self.importCodeField.stringValue = @"";
+                self.importDescriptionField.stringValue = @"";
+                [self.cheatsTable reloadData];
+                [self tableViewSelectionDidChange:nil];
+            });
         }
         else {
-            NSBeep();
-            [GBWarningPopover popoverWithContents:@"This code is not a valid GameShark or GameGenie code" onView:self.importCodeField];
+            dispatch_async(dispatch_get_main_queue(), ^{
+                NSBeep();
+                [GBWarningPopover popoverWithContents:@"This code is not a valid GameShark or Game Genie code" onView:self.importCodeField];
+            });
         }
     }];
 }

bsnes/gb/Cocoa/GBColorCell.h

@@ -1,5 +0,0 @@
-#import <Cocoa/Cocoa.h>
-
-@interface GBColorCell : NSTextFieldCell
-
-@end

bsnes/gb/Cocoa/GBColorCell.m

@@ -1,49 +0,0 @@
-#import "GBColorCell.h"
-
-static inline double scale_channel(uint8_t x)
-{
-    x &= 0x1f;
-    return x / 31.0;
-}
-
-@implementation GBColorCell
-{
-    NSInteger _integerValue;
-}
-
-- (void)setObjectValue:(id)objectValue
-{
-    _integerValue = [objectValue integerValue];
-    uint8_t r = _integerValue & 0x1F,
-            g = (_integerValue >> 5) & 0x1F,
-            b = (_integerValue >> 10) & 0x1F;
-    super.objectValue = [[NSAttributedString alloc] initWithString:[NSString stringWithFormat:@"$%04x", (uint16_t)(_integerValue & 0x7FFF)] attributes:@{
-        NSForegroundColorAttributeName: r * 3 + g * 4 + b * 2 > 120? [NSColor blackColor] : [NSColor whiteColor],
-        NSFontAttributeName: [NSFont userFixedPitchFontOfSize:12]
-    }];
-}
-
-- (NSInteger)integerValue
-{
-    return _integerValue;
-}
-
-- (int)intValue
-{
-    return (int)_integerValue;
-}
-
-
-- (NSColor *) backgroundColor
-{
-    /* Todo: color correction */
-    uint16_t color = self.integerValue;
-    return [NSColor colorWithRed:scale_channel(color) green:scale_channel(color >> 5) blue:scale_channel(color >> 10) alpha:1.0];
-}
-
-- (BOOL)drawsBackground
-{
-    return true;
-}
-
-@end

bsnes/gb/Cocoa/GBColorTextCell.h

@@ -0,0 +1,5 @@
+#import <Cocoa/Cocoa.h>
+
+@interface GBColorTextCell : NSTextFieldCell
+
+@end

bsnes/gb/Cocoa/GBColorTextCell.m

@@ -0,0 +1,19 @@
+#import "GBColorTextCell.h"
+
+@implementation GBColorTextCell
+
+- (void)drawWithFrame:(NSRect)cellFrame inView:(NSView *)controlView
+{
+    [self.backgroundColor set];
+    NSRectFill(cellFrame);
+    
+    NSBezierPath *path = [NSBezierPath bezierPathWithRect:cellFrame];
+    path.lineWidth = 2;
+    
+[[NSColor colorWithWhite:0 alpha:0.25] setStroke];
+    [path addClip];
+    [path stroke];
+    
+    [self drawInteriorWithFrame:cellFrame inView:controlView];
+}
+@end

bsnes/gb/Cocoa/GBDebuggerButton.h

@@ -0,0 +1,7 @@
+#import <Cocoa/Cocoa.h>
+
+@class GBDocument;
+@interface GBDebuggerButton : NSButton
+@property (weak) IBOutlet NSTextField *textField;
+@end
+

bsnes/gb/Cocoa/GBDebuggerButton.m

@@ -0,0 +1,49 @@
+#import "GBDebuggerButton.h"
+
+@implementation GBDebuggerButton
+{
+    NSTrackingArea *_trackingArea;
+}
+- (instancetype)initWithCoder:(NSCoder *)coder
+{
+    self = [super initWithCoder:coder];
+    self.toolTip = self.title;
+    self.imagePosition = NSImageOnly; // Newer versions of AppKit refuse to respect the value from the nib file
+    return self;
+}
+
+- (void)mouseEntered:(NSEvent *)event
+{
+    if (@available(macOS 10.10, *)) {
+        NSDictionary *attributes = @{
+            NSForegroundColorAttributeName: [NSColor colorWithWhite:1.0 alpha:0.5],
+            NSFontAttributeName: self.textField.font
+        };
+        self.textField.placeholderAttributedString =
+            [[NSAttributedString alloc] initWithString:self.alternateTitle attributes:attributes];
+    }
+}
+
+- (void)mouseExited:(NSEvent *)event
+{
+    if (@available(macOS 10.10, *)) {
+        if ([self.textField.placeholderAttributedString.string isEqualToString:self.alternateTitle]) {
+            self.textField.placeholderAttributedString = nil;
+        }
+    }
+}
+
+- (void)updateTrackingAreas
+{
+    [super updateTrackingAreas];
+    if (_trackingArea) {
+        [self removeTrackingArea:_trackingArea];
+    }
+    
+    _trackingArea = [ [NSTrackingArea alloc] initWithRect:[self bounds]
+                                                  options:NSTrackingMouseEnteredAndExited | NSTrackingActiveAlways
+                                                    owner:self
+                                                 userInfo:nil];
+    [self addTrackingArea:_trackingArea];
+}
+@end

bsnes/gb/Cocoa/GBDeleteButtonCell.h

@@ -0,0 +1,5 @@
+#import <Cocoa/Cocoa.h>
+
+@interface GBDeleteButtonCell : NSButtonCell
+
+@end

bsnes/gb/Cocoa/GBDeleteButtonCell.m

@@ -0,0 +1,30 @@
+#import "GBDeleteButtonCell.h"
+
+@implementation GBDeleteButtonCell
+
+// Image scaling is broken on some older macOS versions
+- (void)drawImage:(NSImage *)image withFrame:(NSRect)frame inView:(NSView *)controlView
+{
+    double size = 13;
+    unsigned offset = 1;
+    if (@available(macOS 10.10, *)) {
+        size = 15;
+        offset = 0;
+    }
+    frame.origin.x += round((frame.size.width - size) / 2) + offset;
+    frame.origin.y += round((frame.size.height - size) / 2) - offset;
+    frame.size.width = frame.size.height = size;
+    [super drawImage:image withFrame:frame inView:controlView];
+}
+
+- (void)drawInteriorWithFrame:(NSRect)cellFrame inView:(NSView *)controlView
+{
+    [self drawImage:self.image withFrame:cellFrame inView:controlView];
+}
+
+-(void)drawBezelWithFrame:(NSRect)frame inView:(NSView *)controlView
+{
+    
+}
+
+@end

bsnes/gb/Cocoa/GBDisabledButton.h

@@ -0,0 +1,5 @@
+#import <Cocoa/Cocoa.h>
+
+@interface GBDisabledButton : NSButton
+
+@end

bsnes/gb/Cocoa/GBDisabledButton.m

@@ -0,0 +1,8 @@
+#import "GBDisabledButton.h"
+
+@implementation GBDisabledButton
+- (void)mouseDown:(NSEvent *)event
+{
+    
+}
+@end

bsnes/gb/Cocoa/GBGLShader.m

@@ -163,7 +163,7 @@ void main(void) {\n\
 
     /* OpenGL is black magic. Closing one view causes others to be completely black unless we reload their shaders */
     /* We're probably not freeing thing in the right place. */
-    [[NSNotificationCenter defaultCenter] postNotificationName:@"GBFilterChanged" object:nil];
+    [[NSNotificationCenter defaultCenter] postNotificationName:@"GBFilterChanged$DefaultsObserver" object:nil];
 }
 
 + (GLuint)shaderWithContents:(NSString*)contents type:(GLenum)type

bsnes/gb/Cocoa/GBHexStatusBarRepresenter.h

@@ -0,0 +1,10 @@
+#import <Core/gb.h>
+#import <HexFiend/HFRepresenter.h>
+
+
+@interface GBHexStatusBarRepresenter : HFRepresenter
+@property GB_gameboy_t *gb;
+@property (nonatomic) bool useDecimalLength;
+@property (nonatomic) uint16_t bankForDescription;
+@property (nonatomic) uint16_t baseAddress;
+@end

bsnes/gb/Cocoa/GBHexStatusBarRepresenter.m

@@ -0,0 +1,220 @@
+#import "GBHexStatusBarRepresenter.h"
+#import <HexFiend/HFFunctions.h>
+
+@interface GBHexStatusBarView : NSView
+{
+    NSCell *_cell;
+    NSSize _cellSize;
+    GBHexStatusBarRepresenter *_representer;
+    NSDictionary *_cellAttributes;
+    bool _registeredForAppNotifications;
+}
+
+- (void)setRepresenter:(GBHexStatusBarRepresenter *)rep;
+- (void)setString:(NSString *)string;
+
+@end
+
+
+@implementation GBHexStatusBarView
+
+- (void)_sharedInitStatusBarView
+{
+    NSMutableParagraphStyle *style = [[NSParagraphStyle defaultParagraphStyle] mutableCopy];
+    [style setAlignment:NSCenterTextAlignment];
+    style.lineBreakMode = NSLineBreakByTruncatingTail;
+    _cellAttributes = @{
+        NSForegroundColorAttributeName: [NSColor windowFrameTextColor],
+        NSFontAttributeName: [NSFont labelFontOfSize:[NSFont smallSystemFontSize]],
+        NSParagraphStyleAttributeName: style,
+    };
+    _cell = [[NSCell alloc] initTextCell:@""];
+    [_cell setAlignment:NSCenterTextAlignment];
+    [_cell setBackgroundStyle:NSBackgroundStyleRaised];
+}
+
+- (instancetype)initWithFrame:(NSRect)frame
+{
+    self = [super initWithFrame:frame];
+    [self _sharedInitStatusBarView];
+    return self;
+}
+
+- (instancetype)initWithCoder:(NSCoder *)coder
+{
+    self = [super initWithCoder:coder];
+    [self _sharedInitStatusBarView];
+    return self;
+}
+
+- (BOOL)isFlipped
+{
+    return true;
+}
+
+- (void)setRepresenter:(GBHexStatusBarRepresenter *)rep
+{
+    _representer = rep;
+}
+
+- (void)setString:(NSString *)string
+{
+    [_cell setAttributedStringValue:[[NSAttributedString alloc] initWithString:string attributes:_cellAttributes]];
+    _cellSize = [_cell cellSize];
+    [self setNeedsDisplay:true];
+}
+
+- (void)drawRect:(NSRect)clip
+{
+    NSRect bounds = [self bounds];
+    NSRect cellRect = NSMakeRect(NSMinX(bounds), HFCeil(NSMidY(bounds) - _cellSize.height / 2), NSWidth(bounds), _cellSize.height);
+    [_cell drawWithFrame:cellRect inView:self];
+}
+
+- (void)setFrame:(NSRect)frame
+{
+    [super setFrame:frame];
+    [self.window setContentBorderThickness:frame.origin.y + frame.size.height forEdge:NSMinYEdge];
+}
+
+- (void)mouseDown:(NSEvent *)event
+{
+    _representer.useDecimalLength ^= true;
+}
+
+- (void)windowDidChangeKeyStatus:(NSNotification *)note
+{
+    [self setNeedsDisplay:true];
+}
+
+- (void)viewDidMoveToWindow
+{
+    HFRegisterViewForWindowAppearanceChanges(self, @selector(windowDidChangeKeyStatus:), !_registeredForAppNotifications);
+    _registeredForAppNotifications = true;
+    [self.window setContentBorderThickness:self.frame.origin.y + self.frame.size.height forEdge:NSMinYEdge];
+    [super viewDidMoveToWindow];
+}
+
+- (void)viewWillMoveToWindow:(NSWindow *)newWindow
+{
+    HFUnregisterViewForWindowAppearanceChanges(self, NO);
+    [super viewWillMoveToWindow:newWindow];
+}
+
+- (void)dealloc
+{
+    HFUnregisterViewForWindowAppearanceChanges(self, _registeredForAppNotifications);
+}
+
+@end
+
+@implementation GBHexStatusBarRepresenter
+
+- (instancetype)init
+{
+    self = [super init];
+    return self;
+}
+
+- (NSView *)createView {
+    GBHexStatusBarView *view = [[GBHexStatusBarView alloc] initWithFrame:NSMakeRect(0, 0, 100, 18)];
+    [view setRepresenter:self];
+    [view setAutoresizingMask:NSViewWidthSizable];
+    return view;
+}
+
+- (NSString *)describeLength:(unsigned long long)length
+{
+    if (self.useDecimalLength) {
+        return [NSString stringWithFormat:@"%llu byte%s", length, length == 1 ? "" : "s"];
+    }
+    return [NSString stringWithFormat:@"$%llX byte%s", length, length == 1 ? "" : "s"];
+}
+
+- (NSString *)describeOffset:(unsigned long long)offset isRangeEnd:(bool)isRangeEnd
+{
+    if (!_gb) {
+        return [NSString stringWithFormat:@"$%llX", offset];
+    }
+    return @(GB_debugger_describe_address(_gb, offset + _baseAddress, offset < 0x4000? -1 :_bankForDescription, false, isRangeEnd));
+}
+
+
+- (NSString *)stringForEmptySelectionAtOffset:(unsigned long long)offset length:(unsigned long long)length
+{
+    return [self describeOffset:offset isRangeEnd:false];
+}
+
+- (NSString *)stringForSingleByteSelectionAtOffset:(unsigned long long)offset length:(unsigned long long)length
+{
+    return [NSString stringWithFormat:@"Byte %@ selected", [self describeOffset:offset isRangeEnd:false]];
+}
+
+- (NSString *)stringForSingleRangeSelection:(HFRange)range length:(unsigned long long)length
+{
+    return [NSString stringWithFormat:@"Range %@ to %@ selected (%@)",
+            [self describeOffset:range.location isRangeEnd:false],
+            [self describeOffset:range.location + range.length isRangeEnd:true],
+            [self describeLength:range.length]];
+}
+
+
+- (void)updateString
+{
+    NSString *string = nil;
+    HFController *controller = [self controller];
+    if (controller) {
+        unsigned long long length = [controller contentsLength];
+        NSArray *ranges = [controller selectedContentsRanges];
+        NSUInteger rangeCount = [ranges count];
+        if (rangeCount == 1) {
+            HFRange range = [ranges[0] HFRange];
+            if (range.length == 0) {
+                string = [self stringForEmptySelectionAtOffset:range.location length:length];
+            }
+            else if (range.length == 1) {
+                string = [self stringForSingleByteSelectionAtOffset:range.location length:length];
+            }
+            else {
+                string = [self stringForSingleRangeSelection:range length:length];
+            }
+        }
+        else {
+            string = @"Multiple ranges selected";
+        }
+    }
+    if (! string) string = @"";
+    [[self view] setString:string];
+}
+
+- (void)setUseDecimalLength:(bool)useDecimalLength
+{
+    _useDecimalLength = useDecimalLength;
+    [self updateString];
+}
+
+- (void)setBaseAddress:(uint16_t)baseAddress
+{
+    _baseAddress = baseAddress;
+    [self updateString];
+}
+
+- (void) setBankForDescription:(uint16_t)bankForDescription
+{
+    _bankForDescription = bankForDescription;
+    [self updateString];
+}
+
+- (void)controllerDidChange:(HFControllerPropertyBits)bits
+{
+    if (bits & (HFControllerContentLength | HFControllerSelectedRanges)) {
+        [self updateString];
+    }
+}
+
++ (NSPoint)defaultLayoutPosition
+{
+    return NSMakePoint(0, -1);
+}
+
+@end

bsnes/gb/Cocoa/GBHueSliderCell.h

@@ -0,0 +1,9 @@
+#import <Cocoa/Cocoa.h>
+
+@interface NSSlider (GBHueSlider)
+-(NSColor *)colorValue;
+@end
+
+@interface GBHueSliderCell : NSSliderCell
+-(NSColor *)colorValue;
+@end

bsnes/gb/Cocoa/GBHueSliderCell.m

@@ -0,0 +1,125 @@
+#import "GBHueSliderCell.h"
+
+@interface NSSliderCell(privateAPI)
+- (double)_normalizedDoubleValue;
+@end
+
+@implementation GBHueSliderCell
+{
+    bool _drawingTrack;
+}
+
+-(NSColor *)colorValue
+{
+    double hue = self.doubleValue / 360.0;
+    double r = 0, g = 0, b =0 ;
+    double t = fmod(hue * 6, 1);
+    switch ((int)(hue  * 6) % 6) {
+        case 0:
+            r = 1;
+            g = t;
+            break;
+        case 1:
+            r = 1 - t;
+            g = 1;
+            break;
+        case 2:
+            g = 1;
+            b = t;
+            break;
+        case 3:
+            g = 1 - t;
+            b = 1;
+            break;
+        case 4:
+            b = 1;
+            r = t;
+            break;
+        case 5:
+            b = 1 - t;
+            r = 1;
+            break;
+    }
+    return [NSColor colorWithRed:r green:g blue:b alpha:1.0];
+}
+
+-(void)drawKnob:(NSRect)knobRect
+{
+    [super drawKnob:knobRect];
+    NSBezierPath *path = nil;
+    if (@available(macos 26.0, *)) {
+        NSRect peekRect = knobRect;
+        peekRect.size.height /= 2;
+        peekRect.size.width -= peekRect.size.height;
+        peekRect.origin.x += peekRect.size.height / 2;
+        peekRect.origin.y += peekRect.size.height / 2;
+        path = [NSBezierPath bezierPathWithRoundedRect:peekRect xRadius:peekRect.size.height / 2 yRadius:peekRect.size.height / 2];
+    }
+    else {
+        NSRect peekRect = knobRect;
+        peekRect.size.width /= 2;
+        peekRect.size.height = peekRect.size.width;
+        peekRect.origin.x += peekRect.size.width / 2;
+        peekRect.origin.y += peekRect.size.height / 2;
+        path = [NSBezierPath bezierPathWithOvalInRect:peekRect];
+
+    }
+    NSColor *color = self.colorValue;
+    if (!self.enabled) {
+        color = [color colorWithAlphaComponent:0.5];
+    }
+    [color setFill];
+    [path fill];
+    [[NSColor colorWithWhite:0 alpha:0.25] setStroke];
+    [path setLineWidth:0.5];
+    [path stroke];
+}
+
+-(double)_normalizedDoubleValue
+{
+    if (_drawingTrack) return 0;
+    return [super _normalizedDoubleValue];
+}
+
+-(void)drawBarInside:(NSRect)rect flipped:(BOOL)flipped
+{
+    if (!self.enabled) {
+        [super drawBarInside:rect flipped:flipped];
+        return;
+    }
+    
+    _drawingTrack = true;
+    [super drawBarInside:rect flipped:flipped];
+    _drawingTrack = false;
+    
+    NSGradient *gradient = [[NSGradient alloc] initWithColors:@[
+        [NSColor redColor],
+        [NSColor yellowColor],
+        [NSColor greenColor],
+        [NSColor cyanColor],
+        [NSColor blueColor],
+        [NSColor magentaColor],
+        [NSColor redColor],
+    ]];
+    
+    rect.origin.y += rect.size.height / 2 - 0.5;
+    rect.size.height = 1;
+    rect.size.width -= 2;
+    rect.origin.x += 1;
+    [[NSColor redColor] set];
+    NSRectFill(rect);
+    
+    rect.size.width -= self.knobThickness + 2;
+    rect.origin.x += self.knobThickness / 2 - 1;
+    
+    [gradient drawInRect:rect angle:0];
+}
+
+@end
+
+@implementation NSSlider (GBHueSlider)
+- (NSColor *)colorValue
+{
+    return ((GBHueSliderCell *)self.cell).colorValue;
+}
+@end

bsnes/gb/Cocoa/GBImageCell.h

@@ -1,5 +0,0 @@
-#import <Cocoa/Cocoa.h>
-
-@interface GBImageCell : NSImageCell
-
-@end

bsnes/gb/Cocoa/GBImageCell.m

@@ -1,10 +0,0 @@
-#import "GBImageCell.h"
-
-@implementation GBImageCell
-- (void)drawWithFrame:(NSRect)cellFrame inView:(NSView *)controlView
-{
-    CGContextRef context = [[NSGraphicsContext currentContext] graphicsPort];
-    CGContextSetInterpolationQuality(context, kCGInterpolationNone);
-    [super drawWithFrame:cellFrame inView:controlView];
-}
-@end

bsnes/gb/Cocoa/GBImageView.m

@@ -10,18 +10,18 @@
 }
 @end
 
-@implementation GBImageView
-{
-    NSTrackingArea *trackingArea;
-}
+@interface GBGridView : NSView
+@end
+
+@implementation GBGridView
+
 - (void)drawRect:(NSRect)dirtyRect
 {
-    CGContextRef context = [[NSGraphicsContext currentContext] graphicsPort];
-    CGContextSetInterpolationQuality(context, kCGInterpolationNone);
-    [super drawRect:dirtyRect];
-    CGFloat y_ratio = self.frame.size.height / self.image.size.height;
-    CGFloat x_ratio = self.frame.size.width / self.image.size.width;
-    for (GBImageViewGridConfiguration *conf in self.verticalGrids) {
+    GBImageView *parent = (GBImageView *)self.superview;
+
+    CGFloat y_ratio = parent.frame.size.height / parent.image.size.height;
+    CGFloat x_ratio = parent.frame.size.width / parent.image.size.width;
+    for (GBImageViewGridConfiguration *conf in parent.verticalGrids) {
         [conf.color set];
         for (CGFloat y = conf.size * y_ratio; y < self.frame.size.height; y += conf.size * y_ratio) {
             NSBezierPath *line = [NSBezierPath bezierPath];
@@ -32,7 +32,7 @@
         }
     }
     
-    for (GBImageViewGridConfiguration *conf in self.horizontalGrids) {
+    for (GBImageViewGridConfiguration *conf in parent.horizontalGrids) {
         [conf.color set];
         for (CGFloat x = conf.size * x_ratio; x < self.frame.size.width; x += conf.size * x_ratio) {
             NSBezierPath *line = [NSBezierPath bezierPath];
@@ -43,11 +43,12 @@
         }
     }
     
-    if (self.displayScrollRect) {
-        NSBezierPath *path = [NSBezierPath bezierPathWithRect:CGRectInfinite];
+    if (parent.displayScrollRect) {
+        // CGRectInfinite in NSBezierPath is broken in newer macOS versions
+        NSBezierPath *path = [NSBezierPath bezierPathWithRect:CGRectMake(-0x4000, -0x4000, 0x8000, 0x8000)];
         for (unsigned x = 0; x < 2; x++) {
             for (unsigned y = 0; y < 2; y++) {
-                NSRect rect = self.scrollRect;
+                NSRect rect = parent.scrollRect;
                 rect.origin.x *= x_ratio;
                 rect.origin.y *= y_ratio;
                 rect.size.width *= x_ratio;
@@ -56,7 +57,7 @@
                 
                 rect.origin.x -= self.frame.size.width * x;
                 rect.origin.y += self.frame.size.height * y;
-
+                
                 
                 NSBezierPath *subpath = [NSBezierPath bezierPathWithRect:rect];
                 [path appendBezierPath:subpath];
@@ -72,36 +73,62 @@
         [path stroke];
     }
 }
+@end
+
+@implementation GBImageView
+{
+    NSTrackingArea *_trackingArea;
+    GBGridView *_gridView;
+    NSRect _scrollRect;
+}
+
+- (instancetype)initWithCoder:(NSCoder *)coder
+{
+    self = [super initWithCoder:coder];
+    self.wantsLayer = true;
+    _gridView = [[GBGridView alloc] initWithFrame:self.bounds];
+    _gridView.autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
+    [self addSubview:_gridView];
+    return self;
+}
+
+-(void)viewWillDraw
+{
+    [super viewWillDraw];
+    for (CALayer *layer in self.layer.sublayers) {
+        layer.magnificationFilter = kCAFilterNearest;
+    }
+}
 
 - (void)setHorizontalGrids:(NSArray *)horizontalGrids
 {
     self->_horizontalGrids = horizontalGrids;
-    [self setNeedsDisplay];
+    [_gridView setNeedsDisplay:true];
 }
 
 - (void)setVerticalGrids:(NSArray *)verticalGrids
 {
     self->_verticalGrids = verticalGrids;
-    [self setNeedsDisplay];
+    [_gridView setNeedsDisplay:true];
 }
 
 - (void)setDisplayScrollRect:(bool)displayScrollRect
 {
     self->_displayScrollRect = displayScrollRect;
-    [self setNeedsDisplay];
+    [_gridView setNeedsDisplay:true];
 }
 
 - (void)updateTrackingAreas
 {
-    if (trackingArea != nil) {
-        [self removeTrackingArea:trackingArea];
+    if (_trackingArea != nil) {
+        [self removeTrackingArea:_trackingArea];
     }
     
-    trackingArea = [ [NSTrackingArea alloc] initWithRect:[self bounds]
+    _trackingArea = [ [NSTrackingArea alloc] initWithRect:[self bounds]
                                                  options:NSTrackingMouseEnteredAndExited | NSTrackingActiveAlways | NSTrackingMouseMoved
                                                    owner:self
                                                 userInfo:nil];
-    [self addTrackingArea:trackingArea];
+    [self addTrackingArea:_trackingArea];
 }
 
 - (void)mouseExited:(NSEvent *)theEvent
@@ -124,4 +151,17 @@
     }
 }
 
+- (void)setScrollRect:(NSRect)scrollRect
+{
+    if (memcmp(&scrollRect, &_scrollRect, sizeof(scrollRect)) != 0) {
+        _scrollRect = scrollRect;
+        [_gridView setNeedsDisplay:true];
+    }
+}
+
+- (NSRect)scrollRect
+{
+    return _scrollRect;
+}
+
 @end

bsnes/gb/Cocoa/GBJoyConManager.h

@@ -0,0 +1,12 @@
+#import <Foundation/Foundation.h>
+#import <AppKit/AppKit.h>
+#import <JoyKit/JoyKit.h>
+
+@interface GBJoyConManager : NSObject<JOYListener, NSTableViewDataSource, NSTableViewDelegate>
++ (instancetype)sharedInstance;
+- (IBAction)autopair:(id)sender;
+
+@property (nonatomic) bool arrangementMode;
+@property (weak) IBOutlet NSTableView *tableView;
+@end
+

bsnes/gb/Cocoa/GBJoyConManager.m

@@ -0,0 +1,313 @@
+#import "GBJoyConManager.h"
+#import "GBTintedImageCell.h"
+#import <objc/runtime.h>
+
+@implementation GBJoyConManager
+{
+    GBTintedImageCell *_tintedImageCell;
+    NSImageCell *_imageCell;
+    NSMutableDictionary<NSString *, NSString *> *_pairings;
+    NSMutableDictionary<NSString *, NSNumber *> *_gripSettings;
+    bool _unpairing;
+}
+
++ (instancetype)sharedInstance
+{
+    static GBJoyConManager *manager = nil;
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        manager = [[super allocWithZone:nil] _init];
+    });
+    return manager;
+}
+
+- (NSArray <JOYController *> *)joycons
+{
+    NSMutableArray *ret = [[JOYController allControllers] mutableCopy];
+    for (JOYController *controller in [JOYController allControllers]) {
+        if (controller.joyconType == JOYJoyConTypeNone) {
+            [ret removeObject:controller];
+        }
+    }
+    return ret;
+}
+
++ (instancetype)allocWithZone:(struct _NSZone *)zone
+{
+    return [self sharedInstance];
+}
+
++ (instancetype)alloc
+{
+    return [self sharedInstance];
+}
+
+- (instancetype)init
+{
+    return [self.class sharedInstance];
+}
+
+- (instancetype) _init
+{
+    self = [super init];
+    _imageCell = [[NSImageCell alloc] init];
+    _tintedImageCell = [[GBTintedImageCell alloc] init];
+    if (@available(macOS 10.14, *)) {
+        _tintedImageCell.tint = [NSColor controlAccentColor];
+    }
+    else {
+        _tintedImageCell.tint = [NSColor selectedMenuItemColor];
+    }
+    _pairings = [[[NSUserDefaults standardUserDefaults] dictionaryForKey:@"GBJoyConPairings"] ?: @{} mutableCopy];
+    _gripSettings  = [[[NSUserDefaults standardUserDefaults] dictionaryForKey:@"GBJoyConGrips"] ?: @{} mutableCopy];
+
+    // Sanity check the pairings
+    for (NSString *key in _pairings) {
+        if (![_pairings[_pairings[key]] isEqualToString:key]) {
+            [_pairings removeAllObjects];
+            break;
+        }
+    }
+    
+    [JOYController registerListener:self];
+    for (JOYController *controller in [JOYController allControllers]) {
+        [self controllerConnected:controller];
+    }
+    
+    return self;
+}
+
+- (NSInteger)numberOfRowsInTableView:(NSTableView *)tableView
+{
+    return self.joycons.count;
+}
+
+- (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    if (row >= [self numberOfRowsInTableView:tableView]) return nil;
+    
+    unsigned columnIndex = [[tableView tableColumns] indexOfObject:tableColumn];
+    JOYController *controller = self.joycons[row];
+    switch (columnIndex) {
+        case 0: {
+            switch (controller.joyconType) {
+                case JOYJoyConTypeNone:
+                    return nil;
+                case JOYJoyConTypeLeft:
+                    return [NSImage imageNamed:[NSString stringWithFormat:@"%sJoyConLeftTemplate", controller.usesHorizontalJoyConGrip? "Horizontal" :""]];
+                case JOYJoyConTypeRight:
+                    return [NSImage imageNamed:[NSString stringWithFormat:@"%sJoyConRightTemplate", controller.usesHorizontalJoyConGrip? "Horizontal" :""]];
+                case JOYJoyConTypeDual:
+                    return [NSImage imageNamed:@"JoyConDualTemplate"];
+            }
+        }
+        case 1: {
+            NSMutableAttributedString *ret = [[NSMutableAttributedString alloc] initWithString:controller.deviceName
+                                                                                    attributes:@{NSFontAttributeName:
+                                                                                                     [NSFont systemFontOfSize:[NSFont systemFontSize]]}];
+
+            [ret appendAttributedString:[[NSAttributedString alloc] initWithString:[@"\n" stringByAppendingString:controller.uniqueID]
+                                                                        attributes:@{NSFontAttributeName:
+                                                                                         [NSFont systemFontOfSize:[NSFont smallSystemFontSize]],
+                                                                                     NSForegroundColorAttributeName:[NSColor disabledControlTextColor]}]];
+            return ret;
+        }
+        case 2:
+            return @([(_gripSettings[controller.uniqueID] ?: @(-1)) unsignedIntValue] + 1);
+    }
+    return nil;
+}
+
+- (void)updateGripForController:(JOYController *)controller
+{
+    NSNumber *grip = _gripSettings[controller.uniqueID];
+    if (!grip) {
+        controller.usesHorizontalJoyConGrip = [[NSUserDefaults standardUserDefaults] boolForKey:@"GBJoyConsDefaultsToHorizontal"];
+        return;
+    }
+    controller.usesHorizontalJoyConGrip = [grip unsignedIntValue] == 1;
+}
+
+- (void)tableView:(NSTableView *)tableView setObjectValue:(id)object forTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    unsigned columnIndex = [[tableView tableColumns] indexOfObject:tableColumn];
+    if (columnIndex != 2) return;
+    if (row >= [self numberOfRowsInTableView:tableView]) return;
+    JOYController *controller = self.joycons[row];
+    if (controller.joyconType == JOYJoyConTypeDual) {
+        return;
+    }
+    switch ([object unsignedIntValue]) {
+        case 0:
+            [_gripSettings removeObjectForKey:controller.uniqueID];
+            break;
+        case 1:
+            _gripSettings[controller.uniqueID] = @(0);
+            break;
+        case 2:
+            _gripSettings[controller.uniqueID] = @(1);
+            break;
+    }
+    [[NSUserDefaults standardUserDefaults] setObject:_gripSettings forKey:@"GBJoyConGrips"];
+    [self updateGripForController:controller];
+}
+
+- (NSCell *)tableView:(NSTableView *)tableView dataCellForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    if (row >= [self numberOfRowsInTableView:tableView]) return [[NSCell alloc] init];
+
+    unsigned columnIndex = [[tableView tableColumns] indexOfObject:tableColumn];
+    if (columnIndex == 2) {
+        JOYCombinedController *controller = (JOYCombinedController *)self.joycons[row];
+        if (controller.joyconType == JOYJoyConTypeDual) {
+            NSButtonCell *cell = [[NSButtonCell alloc] initTextCell:@"Separate Joy-Cons"];
+            cell.bezelStyle = NSBezelStyleRounded;
+            cell.action = @selector(invoke);
+            id block = ^(void) {
+                dispatch_async(dispatch_get_main_queue(), ^{
+                    for (JOYController *child in controller.children) {
+                        [_pairings removeObjectForKey:child.uniqueID];
+                    }
+                    [[NSUserDefaults standardUserDefaults] setObject:_pairings forKey:@"GBJoyConPairings"];
+                    _unpairing = true;
+                    [controller breakApart];
+                    _unpairing = false;
+                });
+            };
+            // To retain the block
+            objc_setAssociatedObject(cell, @selector(breakApart), block, OBJC_ASSOCIATION_RETAIN);
+            cell.target = block;
+            return cell;
+        }
+    }
+    if (columnIndex == 0) {
+        JOYController *controller = self.joycons[row];
+        for (JOYButton *button in controller.buttons) {
+            if (button.isPressed) {
+                return _tintedImageCell;
+            }
+        }
+        return _imageCell;
+    }
+    return nil;
+}
+
+- (void)controllerConnected:(JOYController *)controller
+{
+    [self updateGripForController:controller];
+    for (JOYController *partner in [JOYController allControllers]) {
+        if ([partner.uniqueID isEqualToString:_pairings[controller.uniqueID]]) {
+            [self pairJoyCon:controller withJoyCon:partner];
+            break;
+        }
+    }
+    if (controller.joyconType == JOYJoyConTypeLeft || controller.joyconType == JOYJoyConTypeRight) {
+        [self autopair:nil];
+    }
+    if (_arrangementMode) {
+        [self.tableView reloadData];
+    }
+}
+
+- (IBAction)autopair:(id)sender
+{
+    if (_unpairing) return;
+    if (![[NSUserDefaults standardUserDefaults] boolForKey:@"GBJoyConAutoPair"]) return;
+    NSArray<JOYController *> *controllers = [[JOYController allControllers] copy];
+    for (JOYController *first in controllers) {
+        if (_pairings[first.uniqueID]) continue; // Has an established partner
+        if (first.joyconType != JOYJoyConTypeLeft) continue;
+        for (JOYController *second in controllers) {
+            if (_pairings[second.uniqueID]) continue; // Has an established partner
+            if (second.joyconType != JOYJoyConTypeRight) continue;
+            [self pairJoyCon:first withJoyCon:second];
+            break;
+        }
+    }
+    if (_arrangementMode) {
+        [self.tableView reloadData];
+    }
+}
+
+- (void)controllerDisconnected:(JOYController *)controller
+{
+    if (_arrangementMode) {
+        [self.tableView reloadData];
+    }
+}
+
+- (BOOL)tableView:(NSTableView *)tableView shouldEditTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    unsigned columnIndex = [[tableView tableColumns] indexOfObject:tableColumn];
+    return columnIndex == 2;
+}
+
+- (JOYCombinedController *)pairJoyCon:(JOYController *)first withJoyCon:(JOYController *)second
+{
+    if (first.joyconType != JOYJoyConTypeLeft && first.joyconType != JOYJoyConTypeRight) return nil; // Not a Joy-Con
+    if (second.joyconType != JOYJoyConTypeLeft && second.joyconType != JOYJoyConTypeRight) return nil; // Not a Joy-Con
+    if (first.joyconType == second.joyconType) return nil; // Not a sensible pair
+    
+    _pairings[first.uniqueID] = second.uniqueID;
+    _pairings[second.uniqueID] = first.uniqueID;
+    first.usesHorizontalJoyConGrip = false;
+    second.usesHorizontalJoyConGrip = false;
+    [[NSUserDefaults standardUserDefaults] setObject:_pairings forKey:@"GBJoyConPairings"];
+    return [[JOYCombinedController alloc] initWithChildren:@[first, second]];
+}
+
+- (void)controller:(JOYController *)controller buttonChangedState:(JOYButton *)button
+{
+    if (!_arrangementMode) return;
+    if (controller.joyconType == JOYJoyConTypeNone) return;
+    [self.tableView setNeedsDisplay:true];
+    if (controller.joyconType != JOYJoyConTypeLeft && controller.joyconType != JOYJoyConTypeRight) return;
+    if (button.usage != JOYButtonUsageL1 && button.usage != JOYButtonUsageR1) return;
+    
+    
+    // L or R were pressed on a single Joy-Con, try and pair available Joy-Cons
+    JOYController *left = nil;
+    JOYController *right = nil;
+    for (JOYController *controller in [JOYController allControllers]) {
+        if (!left && controller.joyconType == JOYJoyConTypeLeft) {
+            for (JOYButton *button in controller.buttons) {
+                if (button.usage == JOYButtonUsageL1 && button.isPressed) {
+                    left = controller;
+                    break;
+                }
+            }
+        }
+        if (!right && controller.joyconType == JOYJoyConTypeRight) {
+            for (JOYButton *button in controller.buttons) {
+                if (button.usage == JOYButtonUsageR1 && button.isPressed) {
+                    right = controller;
+                    break;
+                }
+            }
+        }
+        if (left && right) {
+            [self pairJoyCon:left withJoyCon:right];
+            return;
+        }
+    }
+}
+
+- (IBAction)toggleHorizontalDefault:(NSButton *)sender
+{
+    for (JOYController *controller in self.joycons) {
+        [self updateGripForController:controller];
+    }
+    if (_arrangementMode) {
+        [self.tableView reloadData];
+    }
+}
+
+- (void)setArrangementMode:(bool)arrangementMode
+{
+    _arrangementMode = arrangementMode;
+    if (arrangementMode) {
+        [self.tableView reloadData];
+    }
+}
+
+@end

bsnes/gb/Cocoa/GBMemoryByteArray.m

@@ -1,4 +1,3 @@
-#define GB_INTERNAL // Todo: Some memory accesses are being done using the struct directly
 #import "GBMemoryByteArray.h"
 #import "GBCompleteByteSlice.h"
 
@@ -32,69 +31,110 @@
     }
 }
 
+- (uint16_t)base
+{
+    switch (_mode) {
+        case GBMemoryEntireSpace: return 0;
+        case GBMemoryROM: return 0;
+        case GBMemoryVRAM: return 0x8000;
+        case GBMemoryExternalRAM: return 0xA000;
+        case GBMemoryRAM: return 0xC000;
+    }
+}
+
 - (void)copyBytes:(unsigned char *)dst range:(HFRange)range
 {
-    __block uint16_t addr = (uint16_t) range.location;
-    __block unsigned long long length = range.length;
-    if (_mode == GBMemoryEntireSpace) {
-        while (length) {
-            *(dst++) = [_document readMemory:addr++];
-            length--;
-        }
+    // Do everything in 0x1000 chunks, never cross a 0x1000 boundary
+    if ((range.location & 0xF000) != ((range.location + range.length) & 0xF000)) {
+        size_t partial = 0x1000 - (range.location & 0xFFF);
+        [self copyBytes:dst + partial range:HFRangeMake(range.location + partial, range.length - partial)];
+        range.length = partial;
     }
-    else {
-        [_document performAtomicBlock:^{
-            unsigned char *_dst = dst;
-            uint16_t bank_backup = 0;
-            GB_gameboy_t *gb = _document.gameboy;
-            switch (_mode) {
-                case GBMemoryROM:
-                    bank_backup = gb->mbc_rom_bank;
-                    gb->mbc_rom_bank = self.selectedBank;
-                    break;
-                case GBMemoryVRAM:
-                    bank_backup = gb->cgb_vram_bank;
-                    if (GB_is_cgb(gb)) {
-                        gb->cgb_vram_bank = self.selectedBank;
+    range.location += self.base;
+    
+    GB_gameboy_t *gb = _document.gameboy;
+
+    switch (range.location >> 12) {
+        case 0x0:
+        case 0x1:
+        case 0x2:
+        case 0x3: {
+            uint16_t bank;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_ROM0, NULL, &bank);
+            memcpy(dst, data + bank * 0x4000 + range.location, range.length);
+            break;
+        }
+        case 0x4:
+        case 0x5:
+        case 0x6:
+        case 0x7: {
+            uint16_t bank;
+            size_t size;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_ROM, &size, &bank);
+            if (_mode != GBMemoryEntireSpace) {
+                bank = self.selectedBank & (size / 0x4000 - 1);
+            }
+            memcpy(dst, data + bank * 0x4000 + range.location - 0x4000, range.length);
+            break;
+        }
+        case 0x8:
+        case 0x9: {
+            uint16_t bank;
+            size_t size;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_VRAM, &size, &bank);
+            if (_mode != GBMemoryEntireSpace) {
+                bank = self.selectedBank & (size / 0x2000 - 1);
+            }
+            memcpy(dst, data + bank * 0x2000 + range.location - 0x8000, range.length);
+            break;
+        }
+        case 0xA:
+        case 0xB: {
+            // Some carts are special, use memory read directly in full mem mode
+            if (_mode == GBMemoryEntireSpace) {
+        case 0xF:
+        slow_path:
+                [_document performAtomicBlock:^{
+                    for (unsigned i = 0; i < range.length; i++) {
+                        dst[i] = GB_safe_read_memory(gb, range.location + i);
                     }
-                    addr += 0x8000;
-                    break;
-                case GBMemoryExternalRAM:
-                    bank_backup = gb->mbc_ram_bank;
-                    gb->mbc_ram_bank = self.selectedBank;
-                    addr += 0xA000;
-                    break;
-                case GBMemoryRAM:
-                    bank_backup = gb->cgb_ram_bank;
-                    if (GB_is_cgb(gb)) {
-                        gb->cgb_ram_bank = self.selectedBank;
-                    }
-                    addr += 0xC000;
-                    break;
-                default:
-                    assert(false);
+                }];
+                break;
             }
-            while (length) {
-                *(_dst++) = [_document readMemory:addr++];
-                length--;
+            else {
+                uint16_t bank;
+                size_t size;
+                uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_CART_RAM, &size, &bank);
+                bank = self.selectedBank & (size / 0x2000 - 1);
+                if (size == 0) {
+                    memset(dst, 0xFF, range.length);
+                }
+                else if (range.location + range.length - 0xA000 > size)  {
+                    goto slow_path;
+                }
+                else {
+                    memcpy(dst, data + bank * 0x2000 + range.location - 0xA000, range.length);
+                }
+                break;
             }
-            switch (_mode) {
-                case GBMemoryROM:
-                    gb->mbc_rom_bank = bank_backup;
-                    break;
-                case GBMemoryVRAM:
-                    gb->cgb_vram_bank = bank_backup;
-                    break;
-                case GBMemoryExternalRAM:
-                    gb->mbc_ram_bank = bank_backup;
-                    break;
-                case GBMemoryRAM:
-                    gb->cgb_ram_bank = bank_backup;
-                    break;
-                default:
-                    assert(false);
+        }
+        case 0xC:
+        case 0xE: {
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_RAM, NULL, NULL);
+            memcpy(dst, data + (range.location & 0xFFF), range.length);
+            break;
+        }
+            
+        case 0xD: {
+            uint16_t bank;
+            size_t size;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_RAM, &size, &bank);
+            if (_mode != GBMemoryEntireSpace) {
+                bank = self.selectedBank & (size / 0x1000 - 1);
             }
-        }];
+            memcpy(dst, data + bank * 0x1000 + range.location - 0xD000, range.length);
+            break;
+        }
     }
 }
 
@@ -113,65 +153,104 @@
     return ret;
 }
 
-- (void)insertByteSlice:(HFByteSlice *)slice inRange:(HFRange)lrange
+- (void)insertByteSlice:(HFByteSlice *)slice inRange:(HFRange)range
 {
-    if (slice.length != lrange.length) return; /* Insertion is not allowed, only overwriting. */
-    [_document performAtomicBlock:^{
-        uint16_t addr = (uint16_t) lrange.location;
-        uint16_t bank_backup = 0;
-        GB_gameboy_t *gb = _document.gameboy;
-        switch (_mode) {
-            case GBMemoryROM:
-                bank_backup = gb->mbc_rom_bank;
-                gb->mbc_rom_bank = self.selectedBank;
+    if (slice.length != range.length) return; /* Insertion is not allowed, only overwriting. */
+    // Do everything in 0x1000 chunks, never cross a 0x1000 boundary
+    if ((range.location & 0xF000) != ((range.location + range.length) & 0xF000)) {
+        size_t partial = 0x1000 - (range.location & 0xFFF);
+        if (slice.length - partial) {
+            [self insertByteSlice:[slice subsliceWithRange:HFRangeMake(partial, slice.length - partial)]
+                            inRange:HFRangeMake(range.location + partial, range.length - partial)];
+        }
+        range.length = partial;
+    }
+    range.location += self.base;
+    
+    GB_gameboy_t *gb = _document.gameboy;
+    
+    
+    switch (range.location >> 12) {
+        case 0x0:
+        case 0x1:
+        case 0x2:
+        case 0x3:
+        case 0x4:
+        case 0x5:
+        case 0x6:
+        case 0x7: {
+            return; // ROM not writeable
+        }
+        case 0x8:
+        case 0x9: {
+            uint16_t bank;
+            size_t size;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_VRAM, &size, &bank);
+            if (_mode != GBMemoryEntireSpace) {
+                bank = self.selectedBank & (size / 0x2000 - 1);
+            }
+            uint8_t sliceData[range.length];
+            [slice copyBytes:sliceData range:HFRangeMake(0, range.length)];
+            memcpy(data + bank * 0x2000 + range.location - 0x8000, sliceData, range.length);
+            break;
+        }
+        case 0xA:
+        case 0xB: {
+            // Some carts are special, use memory write directly in full mem mode
+            if (_mode == GBMemoryEntireSpace) {
+        case 0xF:
+        slow_path:
+                [_document performAtomicBlock:^{
+                    uint8_t sliceData[range.length];
+                    [slice copyBytes:sliceData range:HFRangeMake(0, range.length)];
+                    for (unsigned i = 0; i < range.length; i++) {
+                        GB_write_memory(gb, range.location + i, sliceData[i]);
+                    }
+                }];
                 break;
-            case GBMemoryVRAM:
-                bank_backup = gb->cgb_vram_bank;
-                if (GB_is_cgb(gb)) {
-                    gb->cgb_vram_bank = self.selectedBank;
+            }
+            else {
+                uint16_t bank;
+                size_t size;
+                uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_CART_RAM, &size, &bank);
+                bank = self.selectedBank & (size / 0x2000 - 1);
+                if (size == 0) {
+                    // Nothing to write to
                 }
-                addr += 0x8000;
-                break;
-            case GBMemoryExternalRAM:
-                bank_backup = gb->mbc_ram_bank;
-                gb->mbc_ram_bank = self.selectedBank;
-                addr += 0xA000;
-                break;
-            case GBMemoryRAM:
-                bank_backup = gb->cgb_ram_bank;
-                if (GB_is_cgb(gb)) {
-                    gb->cgb_ram_bank = self.selectedBank;
+                else if (range.location + range.length - 0xA000 > size)  {
+                    goto slow_path;
+                }
+                else {
+                    uint8_t sliceData[range.length];
+                    [slice copyBytes:sliceData range:HFRangeMake(0, range.length)];
+                    memcpy(data + bank * 0x2000 + range.location - 0xA000, sliceData, range.length);
                 }
-                addr += 0xC000;
-                break;
-            default:
                 break;
+            }
         }
-        uint8_t values[lrange.length];
-        [slice copyBytes:values range:HFRangeMake(0, lrange.length)];
-        uint8_t *src = values;
-        unsigned long long length = lrange.length;
-        while (length) {
-            [_document writeMemory:addr++ value:*(src++)];
-            length--;
+        case 0xC:
+        case 0xE: {
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_RAM, NULL, NULL);
+            uint8_t sliceData[range.length];
+            [slice copyBytes:sliceData range:HFRangeMake(0, range.length)];
+            memcpy(data + (range.location & 0xFFF), sliceData, range.length);
+            break;
         }
-        switch (_mode) {
-            case GBMemoryROM:
-                gb->mbc_rom_bank = bank_backup;
-                break;
-            case GBMemoryVRAM:
-                gb->cgb_vram_bank = bank_backup;
-                break;
-            case GBMemoryExternalRAM:
-                gb->mbc_ram_bank = bank_backup;
-                break;
-            case GBMemoryRAM:
-                gb->cgb_ram_bank = bank_backup;
-                break;
-            default:
-                break;
+            
+        case 0xD: {
+            uint16_t bank;
+            size_t size;
+            uint8_t *data = GB_get_direct_access(gb, GB_DIRECT_ACCESS_RAM, &size, &bank);
+            if (_mode != GBMemoryEntireSpace) {
+                bank = self.selectedBank & (size / 0x1000 - 1);
+            }
+            uint8_t sliceData[range.length];
+            [slice copyBytes:sliceData range:HFRangeMake(0, range.length)];
+
+            memcpy(data + bank * 0x1000 + range.location - 0xD000, sliceData, range.length);
+            break;
         }
-    }];
+    }
 }
 
 @end

bsnes/gb/Cocoa/GBObjectView.h

@@ -0,0 +1,6 @@
+#import <Cocoa/Cocoa.h>
+#import "Document.h"
+
+@interface GBObjectView : NSView
+- (void)reloadData:(Document *)document;
+@end

bsnes/gb/Cocoa/GBObjectView.m

@@ -0,0 +1,134 @@
+#import "GBObjectView.h"
+
+@interface GBObjectViewItem : NSObject
+@property IBOutlet NSView *view;
+@property IBOutlet NSImageView *image;
+@property IBOutlet NSTextField *oamAddress;
+@property IBOutlet NSTextField *position;
+@property IBOutlet NSTextField *attributes;
+@property IBOutlet NSTextField *tile;
+@property IBOutlet NSTextField *tileAddress;
+@property IBOutlet NSImageView *warningIcon;
+@property IBOutlet NSBox *verticalLine;
+@end
+
+@implementation GBObjectViewItem
+{
+    @public
+    uint32_t _lastImageData[128];
+    uint8_t _lastHeight;
+}
+@end
+
+@implementation GBObjectView
+{
+    NSMutableArray<GBObjectViewItem *> *_items;
+}
+
+- (instancetype)initWithCoder:(NSCoder *)coder
+{
+    self = [super initWithCoder:coder];
+    _items = [NSMutableArray array];
+    CGFloat height = self.frame.size.height;
+    for (unsigned i = 0; i < 40; i++) {
+        GBObjectViewItem *item = [[GBObjectViewItem alloc] init];
+        [_items addObject:item];
+        [[NSBundle mainBundle] loadNibNamed:@"GBObjectViewItem" owner:item topLevelObjects:nil];
+        item.view.hidden = true;
+        [self addSubview:item.view];
+        [item.view setFrameOrigin:NSMakePoint((i % 4) * 120, height - (i / 4 * 68) - 68)];
+        item.oamAddress.toolTip = @"OAM address";
+        item.position.toolTip = @"Position";
+        item.attributes.toolTip = @"Attributes";
+        item.tile.toolTip = @"Tile index";
+        item.tileAddress.toolTip = @"Tile address";
+        item.warningIcon.toolTip = @"Dropped: too many objects in line";
+        if ((i % 4) == 3) {
+            [item.verticalLine removeFromSuperview];
+        }
+        item.view.autoresizingMask = NSViewMaxXMargin | NSViewMinYMargin;
+    }
+    return self;
+}
+
+- (void)reloadData:(Document *)document
+{
+    GB_oam_info_t *info = document.oamInfo;
+    uint8_t length = document.oamCount;
+    bool cgb = GB_is_cgb(document.gb);
+    uint8_t height = document.oamHeight;
+    NSFont *font = [document debuggerFontOfSize:11];
+    NSFont *boldFont = [[NSFontManager sharedFontManager] convertFont:font toHaveTrait:NSBoldFontMask];
+    
+    for (unsigned i = 0; i < 40; i++) {
+        GBObjectViewItem *item = _items[i];
+        if (i >= length) {
+            item.view.hidden = true;
+        }
+        else {
+            item.view.hidden = false;
+            
+            item.oamAddress.font = boldFont;
+            item.position.font = font;
+            item.attributes.font = font;
+            item.tile.font = font;
+            item.tileAddress.font = font;
+            
+            item.oamAddress.stringValue = [NSString stringWithFormat:@"$%04X", info[i].oam_addr];
+            item.position.stringValue = [NSString stringWithFormat:@"(%d, %d)",
+                                         ((signed)(unsigned)info[i].x) - 8,
+                                         ((signed)(unsigned)info[i].y) - 16];
+            item.tile.stringValue = [NSString stringWithFormat:@"$%02X", info[i].tile];
+            item.tileAddress.stringValue = [NSString stringWithFormat:@"$%04X", 0x8000 + info[i].tile * 0x10];
+            item.warningIcon.hidden = !info[i].obscured_by_line_limit;
+            if (cgb) {
+                item.attributes.stringValue = [NSString stringWithFormat:@"%c%c%c%d%d",
+                                               info[i].flags & 0x80? 'P' : '-',
+                                               info[i].flags & 0x40? 'Y' : '-',
+                                               info[i].flags & 0x20? 'X' : '-',
+                                               info[i].flags & 0x08? 1 : 0,
+                                               info[i].flags & 0x07];
+            }
+            else {
+                item.attributes.stringValue = [NSString stringWithFormat:@"%c%c%c%d",
+                                               info[i].flags & 0x80? 'P' : '-',
+                                               info[i].flags & 0x40? 'Y' : '-',
+                                               info[i].flags & 0x20? 'X' : '-',
+                                               info[i].flags & 0x10? 1 : 0];
+            }
+            size_t imageSize =  8 * 4 * height;
+            if (height == item->_lastHeight && memcmp(item->_lastImageData, info[i].image, imageSize) == 0) {
+                continue;
+            }
+            memcpy(item->_lastImageData, info[i].image, imageSize);
+            item->_lastHeight = height;
+            item.image.image = [Document imageFromData:[NSData dataWithBytesNoCopy:info[i].image
+                                                                            length:64 * 4 * 2
+                                                                      freeWhenDone:false]
+                                                 width:8
+                                                height:height
+                                                 scale:32.0 / height];
+        }
+    }
+    
+    NSRect frame = self.frame;
+    CGFloat newHeight = MAX(68 * ((length + 3) / 4), self.superview.frame.size.height);
+    frame.origin.y -= newHeight - frame.size.height;
+    frame.size.height = newHeight;
+    self.frame = frame;
+}
+
+- (void)drawRect:(NSRect)dirtyRect
+{
+    if (@available(macOS 10.14, *)) {
+        [[NSColor alternatingContentBackgroundColors].lastObject setFill];
+    }
+    else {
+        [[NSColor colorWithDeviceWhite:0.96 alpha:1] setFill];
+    }
+    NSRect frame = self.frame;
+    for (unsigned i = 1; i <= 5; i++) {
+        NSRectFill(NSMakeRect(0, frame.size.height - i * 68 * 2, frame.size.width, 68));
+    }
+}
+@end

bsnes/gb/Cocoa/GBObjectViewItem.xib

@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<document type="com.apple.InterfaceBuilder3.Cocoa.XIB" version="3.0" toolsVersion="21507" targetRuntime="MacOSX.Cocoa" propertyAccessControl="none" useAutolayout="YES" customObjectInstantitationMethod="direct">
+    <dependencies>
+        <deployment identifier="macosx"/>
+        <plugIn identifier="com.apple.InterfaceBuilder.CocoaPlugin" version="21507"/>
+        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
+    </dependencies>
+    <objects>
+        <customObject id="-2" userLabel="File's Owner" customClass="GBObjectViewItem">
+            <connections>
+                <outlet property="attributes" destination="AVH-lh-aVu" id="F5l-vc-9YB"/>
+                <outlet property="image" destination="GWF-Vk-eLx" id="cQa-lM-SqU"/>
+                <outlet property="oamAddress" destination="HiB-x7-HCb" id="LLX-HU-t00"/>
+                <outlet property="position" destination="bxJ-ig-rox" id="woq-X2-lCK"/>
+                <outlet property="tile" destination="Kco-1J-bKc" id="C8u-jH-bCh"/>
+                <outlet property="tileAddress" destination="ptE-vl-9HD" id="9K3-Oq-1vs"/>
+                <outlet property="verticalLine" destination="Q91-eq-oeo" id="6kc-qh-cFx"/>
+                <outlet property="view" destination="c22-O7-iKe" id="50f-xf-9Gg"/>
+                <outlet property="warningIcon" destination="dQV-cO-218" id="Rxi-Wq-Upl"/>
+            </connections>
+        </customObject>
+        <customObject id="-1" userLabel="First Responder" customClass="FirstResponder"/>
+        <customObject id="-3" userLabel="Application" customClass="NSObject"/>
+        <customView id="c22-O7-iKe">
+            <rect key="frame" x="0.0" y="0.0" width="120" height="68"/>
+            <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+            <subviews>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="Kco-1J-bKc">
+                    <rect key="frame" x="44" y="4" width="58" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" selectable="YES" alignment="left" title="$32" id="Aps-81-wR7">
+                        <font key="font" size="11" name="Menlo-Regular"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="ptE-vl-9HD">
+                    <rect key="frame" x="0.0" y="4" width="44" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" selectable="YES" alignment="center" title="$8320" id="t2G-E2-vt5">
+                        <font key="font" size="11" name="Menlo-Regular"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="bxJ-ig-rox">
+                    <rect key="frame" x="44" y="36" width="76" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" selectable="YES" title="(32,16)" id="oac-yZ-h47">
+                        <font key="font" size="11" name="Menlo-Regular"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="AVH-lh-aVu">
+                    <rect key="frame" x="44" y="20" width="76" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" selectable="YES" title="---04" id="tJX-6t-5Kx">
+                        <font key="font" size="11" name="Menlo-Regular"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <textField horizontalHuggingPriority="251" verticalHuggingPriority="750" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="HiB-x7-HCb">
+                    <rect key="frame" x="44" y="52" width="76" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <textFieldCell key="cell" lineBreakMode="clipping" selectable="YES" alignment="left" title="$FE32" id="ysm-jq-PKy">
+                        <font key="font" size="11" name="Menlo-Bold"/>
+                        <color key="textColor" name="labelColor" catalog="System" colorSpace="catalog"/>
+                        <color key="backgroundColor" name="textBackgroundColor" catalog="System" colorSpace="catalog"/>
+                    </textFieldCell>
+                </textField>
+                <imageView horizontalHuggingPriority="251" verticalHuggingPriority="251" id="GWF-Vk-eLx" customClass="GBImageView">
+                    <rect key="frame" x="2" y="24" width="40" height="40"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                    <imageCell key="cell" refusesFirstResponder="YES" alignment="left" id="AJz-KH-eeo"/>
+                </imageView>
+                <imageView horizontalHuggingPriority="251" verticalHuggingPriority="251" fixedFrame="YES" translatesAutoresizingMaskIntoConstraints="NO" id="dQV-cO-218">
+                    <rect key="frame" x="100" y="4" width="16" height="16"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMinX="YES" flexibleMaxY="YES"/>
+                    <imageCell key="cell" refusesFirstResponder="YES" alignment="left" imageScaling="proportionallyDown" image="NSCaution" id="TQB-Vp-9Jm"/>
+                </imageView>
+                <box horizontalHuggingPriority="750" fixedFrame="YES" boxType="separator" translatesAutoresizingMaskIntoConstraints="NO" id="Q91-eq-oeo">
+                    <rect key="frame" x="116" y="4" width="5" height="60"/>
+                    <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMinY="YES"/>
+                </box>
+            </subviews>
+            <point key="canvasLocation" x="132" y="149"/>
+        </customView>
+    </objects>
+    <resources>
+        <image name="NSCaution" width="32" height="32"/>
+    </resources>
+</document>

bsnes/gb/Cocoa/GBOpenGLView.m

@@ -1,6 +1,7 @@
 #import "GBOpenGLView.h"
 #import "GBView.h"
-#include <OpenGL/gl.h>
+#import "NSObject+DefaultsObserver.h"
+#import <OpenGL/gl.h>
 
 @implementation GBOpenGLView
 
@@ -27,13 +28,13 @@
 
 - (instancetype)initWithFrame:(NSRect)frameRect pixelFormat:(NSOpenGLPixelFormat *)format
 {
-    [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(filterChanged) name:@"GBFilterChanged" object:nil];
-    return [super initWithFrame:frameRect pixelFormat:format];
-}
+    __unsafe_unretained GBOpenGLView *weakSelf = self;
+    self = [super initWithFrame:frameRect pixelFormat:format];
+    [self observeStandardDefaultsKey:@"GBFilter" withBlock:^(id newValue) {
+        weakSelf.shader = nil;
+        [weakSelf setNeedsDisplay:true];
 
-- (void) filterChanged
-{
-    self.shader = nil;
-    [self setNeedsDisplay:true];
+    }];
+    return self;
 }
 @end

bsnes/gb/Cocoa/GBPaletteEditorController.h

@@ -0,0 +1,20 @@
+#import <AppKit/AppKit.h>
+#import <Core/gb.h>
+
+@interface GBPaletteEditorController : NSObject<NSTableViewDataSource, NSTableViewDelegate>
+@property (weak) IBOutlet NSColorWell *colorWell0;
+@property (weak) IBOutlet NSColorWell *colorWell1;
+@property (weak) IBOutlet NSColorWell *colorWell2;
+@property (weak) IBOutlet NSColorWell *colorWell3;
+@property (weak) IBOutlet NSColorWell *colorWell4;
+@property (weak) IBOutlet NSButton *disableLCDColorCheckbox;
+@property (weak) IBOutlet NSButton *manualModeCheckbox;
+@property (weak) IBOutlet NSSlider *brightnessSlider;
+@property (weak) IBOutlet NSSlider *hueSlider;
+@property (weak) IBOutlet NSSlider *hueStrengthSlider;
+@property (weak) IBOutlet NSTableView *themesList;
+@property (weak) IBOutlet NSMenu *menu;
+@property (weak) IBOutlet NSSegmentedControl *segmentControl;
+@property IBOutlet NSMenu *segmentMenu;
++ (const GB_palette_t *)userPalette;
+@end

bsnes/gb/Cocoa/GBPaletteEditorController.m

@@ -0,0 +1,414 @@
+#import "GBPaletteEditorController.h"
+#import "GBHueSliderCell.h"
+#import "GBApp.h"
+#import <Core/gb.h>
+
+#define MAGIC 'SBPL'
+
+typedef struct __attribute__ ((packed)) {
+    uint32_t magic;
+    bool manual:1;
+    bool disabled_lcd_color:1;
+    unsigned padding:6;
+    struct GB_color_s colors[5];
+    int32_t brightness_bias;
+    uint32_t hue_bias;
+    uint32_t hue_bias_strength;
+} theme_t;
+
+static double blend(double from, double to, double position)
+{
+    return from * (1 - position) + to * position;
+}
+
+@implementation NSColor (GBColor)
+
+- (struct GB_color_s)gbColor
+{
+    NSColor *sRGB = [self colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
+    return (struct GB_color_s){round(sRGB.redComponent * 255), round(sRGB.greenComponent * 255), round(sRGB.blueComponent * 255)};
+}
+
+- (uint32_t)intValue
+{
+    struct GB_color_s color = self.gbColor;
+    return (color.r << 0) | (color.g << 8) | (color.b << 16) | 0xFF000000;
+}
+
+@end
+
+@implementation GBPaletteEditorController
+
+- (NSArray<NSColorWell *> *)colorWells
+{
+    return @[_colorWell0, _colorWell1, _colorWell2, _colorWell3, _colorWell4];
+}
+
+- (void)updateEnabledControls
+{
+    if (self.manualModeCheckbox.state) {
+        _brightnessSlider.enabled = false;
+        _hueSlider.enabled = false;
+        _hueStrengthSlider.enabled = false;
+        _colorWell1.enabled = true;
+        _colorWell2.enabled = true;
+        _colorWell3.enabled = true;
+        if (!(_colorWell4.enabled = self.disableLCDColorCheckbox.state)) {
+            _colorWell4.color = _colorWell3.color;
+        }
+    }
+    else {
+        _colorWell1.enabled = false;
+        _colorWell2.enabled = false;
+        _colorWell3.enabled = false;
+        _colorWell4.enabled = true;
+        _brightnessSlider.enabled = true;
+        _hueSlider.enabled = true;
+        _hueStrengthSlider.enabled = true;
+        [self updateAutoColors];
+    }
+}
+
+- (NSColor *)autoColorAtPositon:(double)position
+{
+    NSColor *first = [_colorWell0.color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
+    NSColor *second = [_colorWell4.color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]];
+    double brightness = 1 / pow(4, (_brightnessSlider.doubleValue - 128) / 128.0);
+    position = pow(position, brightness);
+    NSColor *hue = _hueSlider.colorValue;
+    double bias = _hueStrengthSlider.doubleValue / 256.0;
+    double red = 1 / pow(4, (hue.redComponent * 2 - 1) * bias);
+    double green = 1 / pow(4, (hue.greenComponent * 2 - 1) * bias);
+    double blue = 1 / pow(4, (hue.blueComponent * 2 - 1) * bias);
+    NSColor *ret = [NSColor colorWithRed:blend(first.redComponent, second.redComponent, pow(position, red))
+                                   green:blend(first.greenComponent, second.greenComponent, pow(position, green))
+                                    blue:blend(first.blueComponent, second.blueComponent, pow(position, blue))
+                                   alpha:1.0];
+    return ret;
+}
+
+- (IBAction)updateAutoColors:(id)sender
+{
+    if (!self.manualModeCheckbox.state) {
+        [self updateAutoColors];
+    }
+    else {
+        [self savePalette:sender];
+    }
+}
+
+- (void)updateAutoColors
+{
+    if (_disableLCDColorCheckbox.state) {
+        _colorWell1.color = [self autoColorAtPositon:8 / 25.0];
+        _colorWell2.color = [self autoColorAtPositon:16 / 25.0];
+        _colorWell3.color = [self autoColorAtPositon:24 / 25.0];
+    }
+    else {
+        _colorWell1.color = [self autoColorAtPositon:1 / 3.0];
+        _colorWell2.color = [self autoColorAtPositon:2 / 3.0];
+        _colorWell3.color = _colorWell4.color;
+    }
+    [self savePalette:nil];
+}
+
+- (IBAction)disabledLCDColorCheckboxChanged:(id)sender
+{
+    [self updateEnabledControls];
+}
+
+- (IBAction)manualModeChanged:(id)sender
+{
+    [self updateEnabledControls];
+}
+
+- (IBAction)updateColor4:(id)sender
+{
+    if (!self.disableLCDColorCheckbox.state) {
+        self.colorWell4.color = self.colorWell3.color;
+    }
+    [self savePalette:self];
+}
+
+- (NSInteger)numberOfRowsInTableView:(NSTableView *)tableView
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSDictionary *themes = [defaults dictionaryForKey:@"GBThemes"];
+    if (themes.count == 0) {
+        [defaults setObject:@"Untitled Palette" forKey:@"GBCurrentTheme"];
+        [self savePalette:nil];
+        return 1;
+    }
+    return themes.count;
+}
+
+-(void)tableView:(NSTableView *)tableView setObjectValue:(id)object forTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    NSString *oldName = [self tableView:tableView objectValueForTableColumn:tableColumn row:row];
+    if ([oldName isEqualToString:object]) {
+        return;
+    }
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSMutableDictionary *themes = [[defaults dictionaryForKey:@"GBThemes"] ?: @{} mutableCopy];
+    NSString *newName = object;
+    unsigned i = 2;
+    if (!newName.length) {
+        newName = @"Untitled Palette";
+    }
+    while (themes[newName]) {
+        newName = [NSString stringWithFormat:@"%@ %d", object, i];
+    }
+    themes[newName] = themes[oldName];
+    [themes removeObjectForKey:oldName];
+    if ([oldName isEqualToString:[defaults stringForKey:@"GBCurrentTheme"]]) {
+        [defaults setObject:newName forKey:@"GBCurrentTheme"];
+    }
+    [defaults setObject:themes forKey:@"GBThemes"];
+    [tableView reloadData];
+    [self awakeFromNib];
+}
+
+- (IBAction)deleteTheme:(id)sender
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSString *name = [defaults stringForKey:@"GBCurrentTheme"];
+    NSMutableDictionary *themes = [[defaults dictionaryForKey:@"GBThemes"] ?: @{} mutableCopy];
+    [themes removeObjectForKey:name];
+    [defaults setObject:themes forKey:@"GBThemes"];
+    [_themesList reloadData];
+    [self awakeFromNib];
+}
+
+- (void)tableViewSelectionDidChange:(NSNotification *)notification
+{
+    NSString *name = [self tableView:nil objectValueForTableColumn:nil row:_themesList.selectedRow];
+    [[NSUserDefaults standardUserDefaults] setObject:name forKey:@"GBCurrentTheme"];
+    [self loadPalette];
+    [[NSNotificationCenter defaultCenter] postNotificationName:@"GBColorPaletteChanged" object:nil];
+}
+
+- (void)tableViewSelectionIsChanging:(NSNotification *)notification
+{
+    [self tableViewSelectionDidChange:notification];
+}
+
+- (void)awakeFromNib
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSDictionary *themes = [defaults dictionaryForKey:@"GBThemes"];
+    NSString *theme = [defaults stringForKey:@"GBCurrentTheme"];
+    if (theme && themes[theme]) {
+        unsigned index = [[themes.allKeys sortedArrayUsingSelector:@selector(localizedCaseInsensitiveCompare:)] indexOfObject:theme];
+        [_themesList selectRowIndexes:[NSIndexSet indexSetWithIndex:index] byExtendingSelection:false];
+        [_themesList scrollRowToVisible:index];
+    }
+    else {
+        [_themesList selectRowIndexes:[NSIndexSet indexSetWithIndex:0] byExtendingSelection:false];
+        [_themesList scrollRowToVisible:0];
+    }
+    [self tableViewSelectionDidChange:nil];
+    if (@available(macOS 10.10, *)) {
+        _themesList.enclosingScrollView.contentView.automaticallyAdjustsContentInsets = false;
+        _themesList.enclosingScrollView.contentView.contentInsets = NSEdgeInsetsMake(0, 0, 10, 0);
+    }
+}
+
+- (IBAction)addTheme:(id)sender
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSDictionary *themes = [defaults dictionaryForKey:@"GBThemes"];
+    NSString *newName = @"Untitled Palette";
+    unsigned i = 2;
+    while (themes[newName]) {
+        newName = [NSString stringWithFormat:@"Untitled Palette %d", i++];
+    }
+    [defaults setObject:newName forKey:@"GBCurrentTheme"];
+    [self savePalette:sender];
+    [_themesList reloadData];
+    [self awakeFromNib];
+}
+
+- (id)tableView:(NSTableView *)tableView objectValueForTableColumn:(NSTableColumn *)tableColumn row:(NSInteger)row
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSDictionary *themes = [defaults dictionaryForKey:@"GBThemes"];
+    return [themes.allKeys sortedArrayUsingSelector:@selector(localizedCaseInsensitiveCompare:)][row];
+}
+
+- (void)loadPalette
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSDictionary *theme = [defaults dictionaryForKey:@"GBThemes"][[defaults stringForKey:@"GBCurrentTheme"]];
+    NSArray *colors = theme[@"Colors"];
+    if (colors.count == 5) {
+        unsigned i = 0;
+        for (NSNumber *color in colors) {
+            uint32_t c = [color unsignedIntValue];
+            self.colorWells[i++].color = [NSColor colorWithRed:(c & 0xFF) / 255.0
+                                                       green:((c >> 8) & 0xFF) / 255.0
+                                                        blue:((c >> 16) & 0xFF) / 255.0
+                                                       alpha:1.0];
+        }
+    }
+    _disableLCDColorCheckbox.state = [theme[@"DisabledLCDColor"] boolValue];
+    _manualModeCheckbox.state = [theme[@"Manual"] boolValue];
+    _brightnessSlider.doubleValue = [theme[@"BrightnessBias"] doubleValue] * 128 + 128;
+    _hueSlider.doubleValue = [theme[@"HueBias"] doubleValue] * 360;
+    _hueStrengthSlider.doubleValue = [theme[@"HueBiasStrength"] doubleValue] * 256;
+    [self updateEnabledControls];
+}
+
+- (IBAction)savePalette:(id)sender
+{
+    NSDictionary *theme = @{
+        @"Colors":
+            @[@(_colorWell0.color.intValue),
+              @(_colorWell1.color.intValue),
+              @(_colorWell2.color.intValue),
+              @(_colorWell3.color.intValue),
+              @(_colorWell4.color.intValue)],
+        @"DisabledLCDColor": _disableLCDColorCheckbox.state? @YES : @NO,
+        @"Manual": _manualModeCheckbox.state? @YES : @NO,
+        @"BrightnessBias": @((_brightnessSlider.doubleValue - 128) / 128.0),
+        @"HueBias": @(_hueSlider.doubleValue / 360.0),
+        @"HueBiasStrength": @(_hueStrengthSlider.doubleValue / 256.0)
+    };
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    NSMutableDictionary *themes = [[defaults dictionaryForKey:@"GBThemes"] ?: @{} mutableCopy];
+    themes[[defaults stringForKey:@"GBCurrentTheme"]] = theme;
+    [defaults setObject:themes forKey:@"GBThemes"];
+    [[NSNotificationCenter defaultCenter] postNotificationName:@"GBColorPaletteChanged" object:nil];
+}
+
++ (const GB_palette_t *)userPalette
+{
+    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+    switch ([defaults integerForKey:@"GBColorPalette"]) {
+        case 1: return &GB_PALETTE_DMG;
+        case 2: return &GB_PALETTE_MGB;
+        case 3: return &GB_PALETTE_GBL;
+        default: return &GB_PALETTE_GREY;
+        case -1: {
+            static GB_palette_t customPalette;
+            NSArray *colors = [defaults dictionaryForKey:@"GBThemes"][[defaults stringForKey:@"GBCurrentTheme"]][@"Colors"];
+            if (colors.count == 5) {
+                unsigned i = 0;
+                for (NSNumber *color in colors) {
+                    uint32_t c = [color unsignedIntValue];
+                    customPalette.colors[i++] = (struct GB_color_s) {c, c >> 8, c >> 16};
+                }
+            }
+            return &customPalette;
+        }
+    }
+}
+
+- (IBAction)export:(id)sender
+{
+    NSSavePanel *savePanel = [NSSavePanel savePanel];
+    [savePanel setAllowedFileTypes:@[@"sbp"]];
+    savePanel.nameFieldStringValue = [NSString stringWithFormat:@"%@.sbp", [[NSUserDefaults standardUserDefaults] stringForKey:@"GBCurrentTheme"]];
+    if ([savePanel runModal] == NSModalResponseOK) {
+        theme_t theme = {0,};
+        theme.magic = MAGIC;
+        theme.manual = _manualModeCheckbox.state;
+        theme.disabled_lcd_color = _disableLCDColorCheckbox.state;
+        unsigned i = 0;
+        for (NSColorWell *well in self.colorWells) {
+            theme.colors[i++] = well.color.gbColor;
+        }
+        theme.brightness_bias = (_brightnessSlider.doubleValue - 128) * (0x40000000 / 128);
+        theme.hue_bias = round(_hueSlider.doubleValue * (0x80000000 / 360.0));
+        theme.hue_bias_strength = (_hueStrengthSlider.doubleValue) * (0x80000000 / 256);
+        size_t size = sizeof(theme);
+        if (theme.manual) {
+            size = theme.disabled_lcd_color? 5 + 5 * sizeof(theme.colors[0]) : 5 + 4 * sizeof(theme.colors[0]);
+        }
+        [[NSData dataWithBytes:&theme length:size] writeToURL:savePanel.URL atomically:false];
+    }
+}
+
+- (IBAction)import:(id)sender
+{
+    NSOpenPanel *openPanel = [NSOpenPanel openPanel];
+    [openPanel setAllowedFileTypes:@[@"sbp"]];
+    if ([openPanel runModal] == NSModalResponseOK) {
+        NSData *data = [NSData dataWithContentsOfURL:openPanel.URL];
+        theme_t theme = {0,};
+        memcpy(&theme, data.bytes, MIN(sizeof(theme), data.length));
+        if (theme.magic != MAGIC) {
+            NSBeep();
+            return;
+        }
+        _manualModeCheckbox.state = theme.manual;
+        _disableLCDColorCheckbox.state = theme.disabled_lcd_color;
+        unsigned i = 0;
+        for (NSColorWell *well in self.colorWells) {
+            well.color = [NSColor colorWithRed:theme.colors[i].r / 255.0
+                                         green:theme.colors[i].g / 255.0
+                                          blue:theme.colors[i].b / 255.0
+                                         alpha:1.0];
+            i++;
+        }
+        if (!theme.disabled_lcd_color) {
+            _colorWell4.color = _colorWell3.color;
+        }
+        _brightnessSlider.doubleValue = theme.brightness_bias / (0x40000000 / 128.0) + 128;
+        _hueSlider.doubleValue = theme.hue_bias / (0x80000000 / 360.0);
+        _hueStrengthSlider.doubleValue = theme.hue_bias_strength / (0x80000000 / 256.0);
+        
+        NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
+        NSDictionary *themes = [defaults dictionaryForKey:@"GBThemes"];
+        NSString *baseName = openPanel.URL.lastPathComponent.stringByDeletingPathExtension;
+        NSString *newName = baseName;
+        i = 2;
+        while (themes[newName]) {
+            newName = [NSString stringWithFormat:@"%@ %d", baseName, i++];
+        }
+        [defaults setObject:newName forKey:@"GBCurrentTheme"];
+        [self savePalette:sender];
+        [self.themesList reloadData];
+        [self awakeFromNib];
+    }
+}
+
+- (IBAction)segmentAction:(NSSegmentedControl *)sender
+{
+    switch (sender.selectedSegment) {
+        case 0: [self addTheme:sender]; return;
+        case 1: [self deleteTheme:sender]; return;
+        case 3: {
+            NSSize buttonSize = _segmentControl.bounds.size;
+            [_segmentMenu popUpMenuPositioningItem:_segmentMenu.itemArray.lastObject
+                                        atLocation:NSMakePoint(buttonSize.width,
+                                                               0)
+                                            inView:sender];
+            return;
+        }
+    }
+}
+
+- (IBAction)restoreDefaultPalettes:(id)sender
+{
+    [(GBApp *)NSApp updateThemesDefault:true];
+    [self awakeFromNib];
+}
+
+- (IBAction)done:(NSButton *)sender
+{
+    [sender.window.sheetParent endSheet:sender.window];
+}
+
++ (instancetype)alloc
+{
+    static id singleton = nil;
+    if (singleton) return singleton;
+    return (singleton = [super allocWithZone:nil]);
+}
+
++ (instancetype)allocWithZone:(struct _NSZone *)zone
+{
+    return [self alloc];
+}
+
+@end

bsnes/gb/Cocoa/GBPaletteView.h

@@ -0,0 +1,6 @@
+#import <Cocoa/Cocoa.h>
+#import "Document.h"
+
+@interface GBPaletteView : NSView
+- (void)reloadData:(Document *)document;
+@end