Fix warnings fix based on Alcaro's comments

nall/dsp/resample/lib/sinc.hpp

@@ -11,8 +11,8 @@ typedef float resample_samp_t;
 #if defined(__SSE__)
   #define SINCRESAMPLE_USE_SSE 1
   #ifndef __x86_64__
-    // Apple's clang doesn't have this extension on -arch i386
-    #if !defined(__APPLE__) && !defined(__clang__)
+    // clang may not have this extension (Apple's certainly doesn't)
+    #ifndef __clang__
       #undef RESAMPLE_SSEREGPARM
       #define RESAMPLE_SSEREGPARM __attribute__((sseregparm))
     #endif

nall/file.hpp

@@ -198,7 +198,7 @@ struct file : varint {
     case index::relative:
         if (offset < 0 && -offset > req_offset)
             req_offset = 0;             //cannot seek before start of file
-		else
+        else
             req_offset += offset;
         break;
     }

nall/string/markup/node.hpp

@@ -59,7 +59,7 @@ struct Node {
       case Comparator::LE: side = rule.split<1>("<="); break;
       case Comparator::GT: side = rule.split<1> (">"); break;
       case Comparator::GE: side = rule.split<1>(">="); break;
-      default: /* Shouldn't happen? */ break;
+      default: break;
       }
 
       string data = text();
@@ -76,9 +76,10 @@ struct Node {
       case Comparator::LE: if(numeral(data) <= numeral(side(1))) continue; break;
       case Comparator::GT: if(numeral(data)  > numeral(side(1))) continue; break;
       case Comparator::GE: if(numeral(data) >= numeral(side(1))) continue; break;
-      default: /* Shouldn't happen? */ break;
+      default: break;
       }
 
+      /* NOT REACHED */
       return false;
     }
 

processor/r65816/opcode_misc.cpp

@@ -77,8 +77,7 @@ L   op_io();
 }
 
 void R65816::op_wai() {
-  regs.wai = true;
-  while(regs.wai) {
+  while((regs.wai = true)) {
 L   op_io();
   }
   op_io();

sfc/chip/armdsp/armdsp.cpp

@@ -39,8 +39,7 @@ void ArmDSP::enter() {
 }
 
 void ArmDSP::step(unsigned clocks) {
-  if(bridge.timer && --bridge.timer == 0)
-    ;
+  if(bridge.timer) --bridge.timer;
   Coprocessor::step(clocks);
   synchronize_cpu();
 }

sfc/chip/bsx/bsx.cpp

@@ -32,7 +32,7 @@ uint8 BSXCartridge::memory_access(bool write, Memory& memory, unsigned addr, uin
   if(write == 0) return memory_read(memory, addr);
   memory_write(memory, addr, data);
 
-  // Return value on write isn't specified, let's fix that
+  // byuu returned nothing here (causing C++ to return 0)
   return 0;
 }
 

sfc/chip/epsonrtc/epsonrtc.cpp

@@ -166,7 +166,7 @@ uint8 EpsonRTC::read(unsigned addr) {
     return ready << 7;
   }
 
-  // NOT REACHED
+  // TODO: byuu returned nothing if addr == 3
   return 0;
 }
 

sfc/chip/sa1/memory/memory.cpp

@@ -100,7 +100,7 @@ uint8 SA1::vbr_read(unsigned addr) {
     return iram.read(addr & 2047);
   }
 
-  // NOT REACHED
+  // TODO: invalid address, what does real hardware do here?
   return 0;
 }
 

sfc/chip/superfx/memory/memory.cpp

@@ -25,7 +25,7 @@ uint8 SuperFX::bus_read(unsigned addr) {
     return ram.read(addr & ram_mask);
   }
 
-  // NOT REACHED
+  // TODO: invalid address, what does real hardware do?
   return 0;
 }
 

sfc/controller/controller.cpp

@@ -35,8 +35,8 @@ void Controller::synchronize_cpu() {
 bool Controller::iobit() {
   if (port == Controller::Port1)
     return cpu.pio() & 0x40;
-
-  return cpu.pio() & 0x80;
+  else
+    return cpu.pio() & 0x80;
 }
 
 void Controller::iobit(bool data) {

sfc/system/video.cpp

@@ -122,7 +122,7 @@ void Video::update() {
     }
     break;
   default:
-	break;
+    break;
   }
 
   uint32_t* data = (uint32_t*)ppu.output;