The tree asks for macOS 11 and then uses std::format on floating point,
which libc++ implements through std::to_chars - marked available from
13.3. Every macOS build fails on it:
formatter_floating_point.h:74:30: error: 'to_chars' is unavailable:
introduced in macOS 13.3
The deployment target is set here, so passing MACOSX_DEPLOYMENT_TARGET to
the build does not help.
Held to NDK 26: x86_64 is the ABI that compiles dynarmic's x64 backend, and
its mcl headers do not survive the clang in NDK 29. arm64-v8a never reaches
that code, so it stays where it is.
The previous fix defined FMT_USE_CONSTEVAL=0, but that macro does not
exist in the pinned fmt 10.1.1 (it was introduced in fmt 11.x), so the
define was inert and the Android arm64 build kept failing on Clang 21
with the same 'call to consteval function ... is not a constant
expression' errors in fmt's os.cc/format.cc.
fmt 10.1.1 gates the consteval FMT_STRING/basic_format_string path
solely on FMT_CONSTEVAL, wrapped in '#ifndef FMT_CONSTEVAL'. Pre-define
FMT_CONSTEVAL empty so that block (which also sets FMT_HAS_CONSTEVAL) is
skipped and the basic_format_string ctor drops to the non-consteval
check_format_string() fallback.
Verified against the pinned fmt source (commit 2dd4fa8) with clang 21.1.8
building src/format.cc and src/os.cc: reproduces the failure unpatched,
FMT_USE_CONSTEVAL=0 leaves all errors, FMT_CONSTEVAL= compiles both TUs
clean. gcc-11 (linux-x64) and MSVC/MinGW paths remain untouched.
The NDK bump to r29 (PR #135) moved the Android arm64 toolchain to
Clang 21, which enforces the stricter consteval evaluation rules from
P2564. That breaks the bundled fmt 10.1.1: every FMT_STRING use in
fmt's own os.cc and format.cc now fails with
call to consteval function
'fmt::basic_format_string<...>::basic_format_string<FMT_COMPILE_STRING, 0>'
is not a constant expression
Force the non-consteval fallback (FMT_USE_CONSTEVAL=0) on Clang so
basic_format_string is instantiated as constexpr rather than consteval.
This keeps the pinned fmt submodule untouched and leaves the gcc-11
(linux-x64) and MSVC/MinGW paths unaffected. Format-string validation
and runtime behaviour are unchanged for well-formed strings.
* boss: Implement some NsData header and read commands.
Co-authored-by: Rokkubro <[email protected]>
* boss: Move opening ext data to common function and improve logging.
---------
Co-authored-by: Rokkubro <[email protected]>
* feat(android-hotkeys): Introduce hotkey support for Android app
* android: Fix settings not saving for layout options - screen swap + layout.
* android: Fix `from` method to default to "DEFAULT" if passed an invalid method (and also not be based on ordering)
* android: PR response - name to togglePause