libretro/pcsx2
1
0
Fork 0
mirror of https://github.com/libretro/pcsx2.git synced 2024-12-24 02:34:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
9,382 Commits 4 Branches 0 Tags 171 MiB
625c4a9a05
Commit Graph

4197 Commits

Author SHA1 Message Date
Gregory Hainaut
ed3052dea5 gsdx: remove various assertion 
Useless or wrong assertion
 2016-11-08 18:58:10 +01:00
Jonathan Li
a283e95fed cmake: Add cdvdgigaherz and dependencies 
Only new dependency is libudev.
 2016-11-07 00:08:23 +00:00
Jonathan Li
16b6cc41a4 cdvdgigaherz:linux: Add config and GUI code 2016-11-07 00:08:23 +00:00
Jonathan Li
747f4dc3fe cdvdgigaherz:linux: Add initial IOCtlSrc implementation 2016-11-07 00:08:23 +00:00
Jonathan Li
f13f50779c cdvdgigaherz: Export plugin interface when using gcc/clang 2016-11-07 00:08:23 +00:00
Jonathan Li
363b581926 cdvdgigaherz: ifdef Windows specific stuff 2016-11-07 00:08:23 +00:00
Jonathan Li
1573f513ce cdvdgigaherz: Move lba_to_msf to header 
Also use proper inline keyword.
 2016-11-07 00:08:23 +00:00
Jonathan Li
ae0577bc16 cdvdgigaherz: Fix write-strings warnings 
Too bad I can't change PS2Edef.h to use a const char*.

Also remove SVN_MOD ifdef from version string.
 2016-11-07 00:08:23 +00:00
Jonathan Li
cccf216dbb cdvdgigaherz: Use C++11 threads instead of Win32 threads 2016-11-07 00:08:23 +00:00
Jonathan Li
d872c0560a cdvdgigaherz: Use unique_ptr for src 2016-11-07 00:08:23 +00:00
Jonathan Li
f8f79788e4 cdvdgigaherz: Use condition variables for event waiting 
Also use atomics for thread exit variables.
 2016-11-07 00:08:23 +00:00
Jonathan Li
f678ff8cfd cdvdgigaherz: Replace critical section with mutex 2016-11-07 00:08:23 +00:00
Jonathan Li
b1850f2465 cdvdgigaherz: Move dllmain to a Windows only file 2016-11-07 00:08:23 +00:00
Jonathan Li
d7866831ae cdvdgigaherz: Use Unicode on Windows 2016-11-07 00:08:23 +00:00
Jonathan Li
5917bf31c3 cdvdgigaherz: Remove old config code 2016-11-07 00:08:23 +00:00
Jonathan Li
59247c7838 cdvdgigaherz: Switch to using the new settings system 
Also refactor the default drive selection and GUI code so optical drive
detection is shared.

Note: This breaks the current config, but there's only one setting
anyway.
 2016-11-07 00:08:23 +00:00
Jonathan Li
dce3c57e6a cdvdgigaherz: Add portable setting class 
Can load/save inis (though functionality is very basic).
 2016-11-07 00:08:23 +00:00
Jonathan Li
9c440ab6b7 cdvdgigaherz: Use bool return for ReadSectors* 
More readable.
 2016-11-07 00:08:23 +00:00
Jonathan Li
fc085c1758 cdvdgigaherz: Improve IOCtlSrc::ReadSectors2048 
Don't use a RAW_READ_INFO struct when only the LARGE_INTEGER member is
used. Use SetFilePointerEx which is slightly simpler and doesn't require
checking GetLastError() in some circumstances to check whether the read
has actually failed.

Also use a mutex to prevent simultaneous access from both the read
thread and the keepalive thread to prevent overlapping SetFilePointerEx
calls from causing the wrong data to be read.

And print error messages should a failure occur.
 2016-11-07 00:08:23 +00:00
Jonathan Li
fdd6ea3651 cdvdgigaherz: Simplify SetSpindleSpeed 
Also set the max drive speed to 4x DVD and 24xCD (down from 8x DVD and
36x CD) - it seems to reduce pausing slightly since the drive doesn't
require as much time to spin up to the desired speed.
 2016-11-07 00:08:23 +00:00
Jonathan Li
1834b7d0f9 cdvdgigaherz: Get disc info when disc is first ready 
Also set the disc speed at the correct time - CDROM SET SPEED only stays
in effect till the disc is removed.

Also fix a memleak in CDVDopen when the drive cannot be accessed.
 2016-11-07 00:08:23 +00:00
Jonathan Li
95b98c5a38 cdvdgigaherz: Use a formatted TOC instead of a raw TOC 
It's simpler and provides almost the same information. The only
information that might be lost is the first track specific track type.
 2016-11-07 00:08:23 +00:00
Jonathan Li
327515366f cdvdgigaherz: Don't calculate the track length 
Not really necessary.

Also fix 2 off-by-ones.
 2016-11-07 00:08:23 +00:00
Jonathan Li
1f60e3101e cdvdgigaherz: Reduce disc info ioctl calls 
It's rather unnecessary to use the same ioctls multiple times per disc
when the info returned doesn't change. Just use each ioctl once and
read/calculate all the necessary info all at onace.

This also fixes an issue where the IOCTL_DVD_START_SESSION ioctl is
repeatedly used if the returned session ID is 0. The previous code
assumed that 0 was not a valid session ID and would repeatedly use the
ioctl to obtain a non-zero session ID. However, 0 is a valid session ID,
and it seems IOCTL_DVD_START_SESSION can repeatedly return a 0 session
ID even if the corresponding IOCTL_DVD_END_SESSION has not been called.
In our case, a DVD session is only necessary for DVD detection and
reading the physical format information. This fix seems to alter drive
speed behaviour.
 2016-11-07 00:08:23 +00:00
Jonathan Li
f8e474a1c5 cdvdgigaherz: s/device/m_device/ 2016-11-07 00:08:23 +00:00
Jonathan Li
8f11049c9f cdvdgigaherz: Remove non-SPTI raw sector reading code 
There doesn't seem to be any issues calling CreateFile with
GENERIC_WRITE access (which is necessary for SPTI) on a standard user
account, so the SPTI code should work in all cases.
 2016-11-07 00:08:23 +00:00
Jonathan Li
f314c2a4d9 cdvdgigaherz: Simplify Q subchannel relative offset calculation 
That way there's no need to calculate the track length for each track.
 2016-11-07 00:08:23 +00:00
FlatOutPS2
5d90afe648 LilyPad: Add separate bindings for each pad type (#1609) 
Adds separate bindings for each of the pad types (DualShock2,
Guitar,Pop'n Music). This allows the user to change the button
configuration to better suit the Guitar and Pop'n Music pads without
messing up the bindings already setup for the DS2.

Close #1576.
 2016-11-06 21:59:19 +00:00
Gregory Hainaut
5ff9e94a2e gsdx linux: align mipmapping gui option on Windows 2016-11-06 16:39:40 +01:00
Gregory Hainaut
107251e099 gsdx: sort crc game list 2016-11-06 16:30:51 +01:00
Akash
1547dd4215 GSDX-UI: Add Mipmap combobox 
Mipmapping is now supported on hardware renderers thanks to Gregory. Please report any observed hardware mipmapping issues on the forums (http://forums.pcsx2.net/Thread-New-feature-Needs-testing-GSdx-HW-mode-Experimental-mipmap-support) as potentially the HW mipmap code might still have some bugs.
 2016-11-05 22:19:32 +05:30
Akash
58ed49f3c9 GSDX: Clean up warnings on MSVC 
* Explicitly cast w_pages and h_pages into uint32.
* Prevent signed/unsigned comparison by converting lod into unsigned integer, honestly how coud a mipmapping level be negative?
 2016-11-05 10:28:04 +01:00
Gregory Hainaut
758cf25888 gsdx: wrap bp for block ptr 
Fix massive flickering of Beyond Good&Evil on SW renderer (HW happily overflow)
 2016-11-04 23:03:12 +01:00
Gregory Hainaut
3d65312999 gsdx hw: remove old assert 
Code is working fine with all formats
 2016-11-04 23:02:49 +01:00
Akash
437afbbbf3 GSDX-PCRTC: Move Saturation hack to displayrect() 
Fixes custom resolution scaling on Tribes aerial assault.
 2016-11-01 17:54:46 +01:00
Akash
b871c6b46f GSDX-TextureCache: Generalize scaling equation 
Previously the dedicated custom resolution scaling equation was ignored for the second SetScale() call, generalizing the equations will also fix the DMC scaling issue on custom resolution. Also remove unnecessary checks for null on scale factors. The possibility for having a null scale factor value only exists on custom resolution and it will only happen on cases where the output circuit isn't ready yet. So the ideal way would be to handle all the required conditions of output circuit on "m_renderer->CanUpscale()" itself.
 2016-11-01 17:54:46 +01:00
Akash
055f236aa5 GSVector: Add constructor to dispatch same values 2016-11-01 17:54:46 +01:00
Gregory Hainaut
aa4b2d9f3a gsdx sw: wrap GS memory 
Cost ought to remain small. Worst case is 2 extra "and" operation by group of pixels in scanline renderer

I think PixelAddressN functions are mostly call in the init.
 2016-11-01 13:33:11 +01:00
Pseudonym
233f66db5e Fixed effects area wrapping calculation, which was always buggy but this 
wasn't evident until additional addresses were precalculated.
Not expected to improve compatibility.
 2016-11-01 11:12:41 +00:00
Jonathan Li
ba557e20a4 gsdx:recorder:unix: Fix thread leaking 2016-10-28 18:33:50 +01:00
Jonathan Li
7ab5cb20c8 gsdx: Don't close threads twice 
CloseThread is called in the GSJobQueue destructor, so don't call it
again in the GSThread destructor.

Fixes #392, which was caused by a use after free.

Also prevents pthread_join() from being called twice for each thread
on non-Windows operating systems, which is undefined behaviour.
 2016-10-28 18:33:35 +01:00
Jonathan Li
bc7aa1a500 spu2-x:freebsd: Enable SDL backends 
portaudio currently isn't providing me with sound, even though it did
before.
 2016-10-27 22:03:49 +01:00
Jonathan Li
86a6f5d67c cdvdgigaherz: s/itob/dec_to_bcd/ 
There's no need to have 2 ways to convert a u8 to a binary coded
decimal. Remove the macro version.
 2016-10-26 22:11:40 +01:00
Jonathan Li
852ed21e88 cdvdgigaherz: Remove no drive support 
It's the same as "No disc" or having no disc in the drive.
 2016-10-26 17:30:28 +01:00
Jonathan Li
c023d7676a cdvdgigaherz: Remove Source base class 
Also remove virtuals from IOCtlSrc.
 2016-10-26 17:30:27 +01:00
Jonathan Li
9f6c6d9917 cdvdgigaherz: Don't use GetFileSizeEx to get disk size 
It doesn't seem to work for disks, and IOCTL_DISK_GET_LENGTH_INFO
usually succeeds instead.
 2016-10-26 17:30:23 +01:00
Jonathan Li
9c643ae9ca cdvdgigaherz: Remove CDVDabout and SysMessage 
It's not accessible from PCSX2. More importantly, I don't want to port
it.
 2016-10-26 17:30:21 +01:00
Jonathan Li
fb3580efa1 cdvdgigaherz: Remove unneeded code 2016-10-26 17:30:16 +01:00
Gregory Hainaut
5dfb7d63dc gsdx: wrap gs page/block instead to skip them 
Fix FMV of Thrillville when coupled with wrap_gs_mem = 1
 2016-10-25 22:49:05 +02:00
Gregory Hainaut
db4b4fb166 gsdx ogl: keep a separate log for sw 2016-10-25 22:00:41 +02:00
Gregory Hainaut
cedc8aae44 gsdx: implement a shared memory to emulate the wrapping of the gs memory 
Code can be enabled with "wrap_gs_mem = 1". Code only allow a single shared memory but
I don't think we need more anyway.

Linux only, Kernel panic expected with the HW renderer.

Fix FMV on Silent Hill 3 with the SW renderer
 2016-10-25 20:29:38 +02:00
Gregory Hainaut
42b51611af gsdx: don't dump debug file if not requested 2016-10-25 17:10:57 +02:00
sudonim1
820462dbc0 Merge pull request #1635 from sudonim1/reverb 
SPU2-X: Reverb rewrite
 2016-10-24 17:17:48 +01:00
Gregory Hainaut
e80ca0fa92 gsdx ogl: of course some driver don't work with GL_ARB_enhanced_layouts 
Windows and (AMD or Intel)
 2016-10-23 12:48:23 +02:00
Gregory Hainaut
885ef7a46f gsdx ogl: reduce complexity of driver detection 2016-10-23 12:43:50 +02:00
Gregory Hainaut
565cb70875 gsdx ogl: don't request arb_texture_barrier for the SW renderer 
Allow[1] to use the mesa software emulated driver to test EGL.

[1] also need export MESA_EXTENSION_OVERRIDE="GL_ARB_buffer_storage"
 2016-10-23 12:13:57 +02:00
Pseudonym
1668392988 SPU2-X: Mass reverb register renaming. Hopefully I didn't screw up the 
cross-channel reflection registers.
 2016-10-22 19:16:11 +01:00
Pseudonym
9a51820dec SPU2-X: Experimental reverb based on Dr. Hell's 
http://drhell.web.fc2.com/ps1/ and/or Martin Korth's
http://problemkaputt.de/psx-spx.htm reverse engineering.
Negate final reverb output (don't know why but it's an
improvement when comparing the waveform).
 2016-10-22 19:16:11 +01:00
Gregory Hainaut
01f0f436ac gsdx linux replayer: allow to repack gs dump 
linux_replay = -N will save N first frames to a new gs dump

Save disk space & debug time
 2016-10-22 13:22:28 +02:00
Gregory Hainaut
99c43881df gsdx egl: report an error if we fail to bind the openGL API 
It seems Nvidia added openGL support in 355 (whereas I have 352 on debian).

I don't know the status on AMD.
 2016-10-22 13:22:28 +02:00
Gregory Hainaut
d4a163e9cc spu2: improve format consistency 2016-10-22 13:22:28 +02:00
Pseudonym
1f44c4be2f SPU2-X: PSX games should be able to read ENDX correctly now, which is 
important functionality for many sound engines.
Fixed two other obvious errors in the psx compatibility merge, probably
inconsequential.
 2016-10-20 04:17:03 +01:00
Gregory Hainaut
8fdf973e66 gsdx glsl: add basic support of GL_ARB_enhanced_layouts (GL4.4) 
Hardcode location of interface to the location 0. If I understand the
spec correctly (unlikely), variable in interface will get successive
location.

Goal is to reduce driver work. Instead to compute some location based on
name matching approach (and silly validation), the driver can now use
static allocation.

Tests on future Mesa 13 are welcome
 2016-10-19 23:03:39 +02:00
Gregory Hainaut
b1f2d27ddf gsdx: move Haunting Ground CRC to dx level 2016-10-19 21:10:44 +02:00
Gregory Hainaut
264b764d6e gsdx tc: improve haunting ground hack to remove the bloom effect 
Just clear the buffer. The generic solution will be a copy from buffer A
to buffer B But it requires
1/ a big buffer A (otherwise it would overflow)
2/ a line width rescaling (+ the upscaling mess support)
 2016-10-19 19:31:32 +02:00
Gregory Hainaut
c2cf8e528c gsdx ogl: tekken5: only trigger channel effect shader when frame buffer is a single page 
Fix missing model regression.
 2016-10-17 19:34:55 +02:00
Clang Format
604d3bac3c clang format: set SpacesBeforeTrailingComments to 1 2016-10-16 21:42:31 +02:00
Akash
8945ace3f7 GSDX-UI: Remove Trilinear options at some cases 
Currently the Trilinear option only works on OpenGL. Remove it from combobox when other renderers are used.
 2016-10-16 17:36:30 +01:00
Akash
45be4626f6 GSDX: Add an enum for texture filtering 
Also re-order the combobox to make it look consistent with the tooltip description.
 2016-10-16 17:36:30 +01:00
Gregory Hainaut
cc4cc342c2 gsdx hw: add a special sub target invalidation for haunting ground 
Fix a wrong blending/blooming

Based on CRC to reduce impact on others games (speed)
 2016-10-16 17:32:57 +02:00
Gregory Hainaut
31248da3d1 gsdx sw: Fix 16 bits date test on SSE build 
AVX Builds were fixed in this commit a1a842b07f
 2016-10-16 16:48:23 +02:00
Gregory Hainaut
defdd27987 gsdx: set m_nativeres to true in replayer 
Otherwise you can't compare draw call between native and upscaled
 2016-10-16 16:48:23 +02:00
Robert Neumann
f5e096a66f spu2x: indicate pitch modulation and noise enabled status in the visual debugger 2016-10-16 14:15:12 +02:00
Gregory Hainaut
c284459382 gsdx tc: allow to search old depth/color in texture cache 
But give higher priority to recent buffer.

Fix cut scene issue in Jak II (and potentially various game when EE/VU hacks are used)
 2016-10-15 18:08:00 +02:00
Gregory Hainaut
7bb201a1d2 gsdx tc: move code to allow to lookup an older target if none was found 
Next step is to enable it by uncommenting line 452
 2016-10-14 22:03:29 +02:00
Gregory Hainaut
24684033ca gsdx: enable clut_load_before_draw option on Harley Davidson (CRC hack) 
At least the game is good until we find how the HW really behave
 2016-10-14 20:47:18 +02:00
Gregory Hainaut
2c0a4ac906 gsdx ogl: add an extra debug log level 
Avoid too much log
 2016-10-14 20:46:58 +02:00
Gregory Hainaut
3c30db965d gsdx gui: add a combo box on linux (below Interlace) 
3 states are off/half/full. I'm too lazy to create a better combo box.

The hack option will be removed when Windows GUI is ready
 2016-10-14 19:26:58 +02:00
Gregory Hainaut
37a1230c01 gsdx: reduce code duplication for key event 2016-10-14 19:26:58 +02:00
Gregory Hainaut
a4658eac24 gsdx hw: allow overlapping of texture (alpha) and framebuffer (RGB) 
Fix HUD on Berserk

v2: use fbmask instead of hacking the target format to 24 bits.
 2016-10-14 19:26:27 +02:00
Gregory Hainaut
25e76d0564 gsdx ogl: use an invalid value for stencil state 
Fix shadow in WWE Smackdown Vs Raw 2006
 2016-10-14 19:01:18 +02:00
Gregory Hainaut
51c64fcbe6 gsdx sw: trick GetFeedbackOutput to handle basic merge loopback 
It is enough for Xenosaga.
 2016-10-14 18:13:20 +02:00
Gregory Hainaut
deb2ed3d09 gsdx ogl: reimplement merge circuit to support feedback write 2016-10-14 18:13:20 +02:00
Gregory Hainaut
06055add5c gsdx merge: get a new buffer for the feedback write 2016-10-14 18:13:20 +02:00
Gregory Hainaut
317a464278 gsdx shader: RGB => YUV conversion 
Required for write feedback emulation
 2016-10-14 18:13:20 +02:00
Jason Brown
6ef5607d99 gsdx shader: add a shader to render text for OSD 
Gregory: code extracted from the OSD PR to reduce conflict
 2016-10-14 18:13:20 +02:00
Jason Brown
d84d30fe87 gsdx: Add color component to OGL shaders 2016-10-14 18:13:20 +02:00
Gregory Hainaut
7ca9ca9465 gsdx: new parameter for merge virtual function 
* Add full PMODE register to replace slbg/mmod
* Add full EXTBUF register (will allow to emulate write feedback)
* Add a third source (which will actually be the destination of the
  write feedback)
 2016-10-14 18:13:20 +02:00
FlatOutPS2
357dcdb55e GSdx: Move alpha stencil hack back to original location 
Avoids skipping the alpha stencil hack.
 2016-10-14 16:36:17 +02:00
Gregory Hainaut
fbf7ccbdda gsdx: by default new will throw std::bad_alloc 
So catch/use it and don't bother with GSDXErrorOOM
 2016-10-13 20:44:59 +02:00
Gregory Hainaut
c440c7c93a gsdx gui: update the filter combox box with new trilinear options 
OpenGL only

v2: update setting tooltip based on turtleli feedback
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
5ced9c1f19 gsdx mipmap:ogl: plug trilinear/mipmap2 option 
mipmap option 3. Actually maybe a separate tri-linear option will be better

m_mipmap == 2 => use manual PS2 trilinear/mipmap
Otherwise
m_filter == 3 => always use full automatic trilinear interpolation
m_filter == 4 => use automatic trilinear interpolation when PS2 uses mipmap
m_filter == 5 => like 4 but force bilinear interpolation inside layer
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
c2777ff989 gsdx state: split IsMipmapActive in 2 pieces 
This way we can test if a draw call requires a triliner filtering.
It will be used in next commit to implement automatic trilinear
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
1b9b47dd6a gsdx mipmap:ogl: add capabilities to automatically generate mipmap layer 2016-10-13 20:16:38 +02:00
Gregory Hainaut
510eccd471 gsdx mipmap: enable fully tri-linear filtering 
(when mipmap > 1)
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
a8a2db8eb1 gsdx mipmap:ogl: extend HW sampler with tri-linear filtering 
v2:
* use nice enum
* use bilinear info when there is no mipmap (more accurate)
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
335d7f3ae5 gsdx: add a nice enum for min filter 2016-10-13 20:16:38 +02:00
Gregory Hainaut
7ea0e90678 gsdx mipmap:ogl: extend shader to support trilinear filtering 2016-10-13 20:16:38 +02:00
Gregory Hainaut
d185a85a07 gsdx ogl: replace simple_sample variable by the opposite shader_emulated_sampler 
It feels easier to read this way
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
ae441e6a2c gsdx mipmap:HW: Update all valid texture layers 2016-10-13 20:16:38 +02:00
Gregory Hainaut
5d593dd948 gsdx mipmap:HW: save state of both min&max lod values 2016-10-13 20:16:38 +02:00
Gregory Hainaut
15b1d8d3f0 gsdx mipmap:tc: add code to update a single layer of a mipmap 2016-10-13 20:16:38 +02:00
Gregory Hainaut
dbb4bdf59f gsdx mipmap:ogl: add GL_TEXTURE mipmap support 
* Allocate more memory for extra layers
* Allow to upload data in any layers
 2016-10-13 20:16:38 +02:00
Gregory Hainaut
76bd968c59 gsdx mipmap: extend texture/cache to support a layer parameter 2016-10-13 20:16:38 +02:00
Gregory Hainaut
b695e0065a gsdx mipmap: use a 3 state option 2016-10-13 20:16:38 +02:00
Jonathan Li
679f3347bb cdvdgigaherz: Read raw CD sectors one by one (#1590) 
A multi sector raw disk sector read that reads data from two tracks of
different types will not complete successfully. Reading the sectors one
at a time should fix the issue.
 2016-10-10 22:33:15 +01:00
Clang Format
039573b133 clang-format spu2x 
Note: it doesn't play well with define around forceinline (might need to fix the inline btw)
And a single macro in RegTable.cpp
 2016-10-10 20:41:24 +02:00
Robert
36631f2270 remove a useless define 
cosmetics

more cosmetics

some more cosmetics? sure!

whitespaces

whiterspaces
 2016-10-09 20:10:53 +02:00
Robert
95fe77a594 bad merge fix 2016-10-09 16:15:19 +02:00
Robert Neumann
19a8ed8b25 psxmode: Spu2x: more native SPU2 reghandlers. first "working" reverb! (everything before was just random data) 2016-10-09 15:52:47 +02:00
Robert Neumann
ee05137415 psxmode: Spu2x: add reverb register handling, fix a problem with the address translation, re-enable "VMIXEL" writing (which should just be named Echo/Effect ON or EON really) 2016-10-09 15:52:47 +02:00
Robert Neumann
1ec70f1df3 psxmode: Spu2x now working correctly. Kudos to pseudonym. Took him 30 minutes to fix this! 2016-10-09 15:52:46 +02:00
Robert Neumann
08b6edae80 psxmode: further spu2x work 2016-10-09 15:52:45 +02:00
Robert
3aabc1adbf spu2x work 1 2016-10-09 15:52:05 +02:00
Gregory Hainaut
9af34cc611 gsdx tc: miss a set scaling call 
Likely impact issue #83/#694
 2016-10-09 13:07:08 +02:00
Gregory Hainaut
3b733930fe gsdx: UserHacks_TextureInsideRt must be disabled by default 
Likely a bad copy/past
 2016-10-09 12:13:37 +02:00
Gregory Hainaut
344636d88e gsdx ogl: attach input texture before copy 
Help to ensure with copy the good texture in debugger
 2016-10-08 23:42:39 +02:00
Gregory Hainaut
22ebdcf1cf gsdx debug: create a nice dump function for kernel gs registers 
Add missing register
 2016-10-08 23:42:39 +02:00
Andreas
ab228c8484 Added missing CRC for Grand Theft Auto San Andreas. 2016-10-08 18:38:50 +03:00
FlatOutPS2
db853b4462 GSdx: Add Jak 2 US CRC to GSCrc list. 
Fixes issue: https://github.com/PCSX2/pcsx2/issues/1603
 2016-10-07 13:14:15 +03:00
Gregory Hainaut
574a807678 gsdx tc: new hack to extract texture from rt 
UserHacks_TextureInsideRt = 1 (don't look at Jak)
 2016-10-07 01:43:04 +02:00
Gregory Hainaut
8873b27eb8 gsdx: let's keep the new clut option off 
There are still issue with virtua fighter (albeit my dump is better...)
 2016-10-06 22:05:03 +02:00
Gregory Hainaut
79666b26c0 gsdx sw: restore the const reference 
It was removed for PSX hack which was removed a couple of commits ago
 2016-10-06 20:02:22 +02:00
Gregory Hainaut
c66004bbb2 gsdx: hidden option to better support dual context clut 
Option is on by default. Just a safety net in case of regression

Fix clut issue on virtua fighter (SW) and harley davidson (SW/HW).
 2016-10-06 19:08:21 +02:00
Gregory Hainaut
9cd4984f7c gsdx debug: more log 2016-10-06 18:56:31 +02:00
Gregory Hainaut
d827497403 gsdx: let's handle illegal 4 bits format too 
In doubt if some games use them.
 2016-10-05 22:07:49 +02:00
Gregory Hainaut
9b93c07339 gsdx: Handle illegal 8 bits format. Found the most silly GS dev trick 
Fix Berserk #1526 Well done guys but we're more clever than you ;)

So instead to mask the color channels as any guy that RTFM, they decided to use the illegal 8H frame format
 2016-10-05 22:07:43 +02:00
Gregory Hainaut
6fd46eb36a gsdx: move the validation of the texture format before the draw call 
Avoid false positive when game write dummy stuff
 2016-10-05 22:07:23 +02:00
Pseudonym
a0629587be gsdx memory: implement read texture of PS GPU24 
convert the swizzled block as tightly packed 24 bits RGB

Then convert scanline to standard 32 bits RGBA

The HW renderer requires the preload data hack
 2016-10-05 21:59:42 +02:00
Gregory Hainaut
1c900e780a gsdx memory: add a PS GPU 24 bits format 
Same swizzle as 16 bits. But contains tightly packed RGB pixels.
 2016-10-05 21:06:38 +02:00
Gregory Hainaut
1cc696ab31 gsdx hw: update TEST.ATE field after ATE optimization 
Otherwise DoFirstPass/DoSecondPass will give you result based on pre-ATE optimization

Close #1607
 2016-10-05 09:43:24 +02:00
Gregory Hainaut
3653a7746a gsdx psxmode: small hack to "see" video until we found a better solution 2016-10-05 09:43:24 +02:00
Gregory Hainaut
677f890c5c gsdx debug: static GSState::s_n 
This way you can access the current draw call anywhere. Very useful for debug.
 2016-10-05 09:43:24 +02:00
Gregory Hainaut
61333ecb40 gsdx debug: trace register access 
I didn't include high frequency register such as vertex stuff

main goal is to give the possibility to trace the texture/clut update
 2016-10-05 09:43:24 +02:00
Gregory Hainaut
1b8d6a38e7 Merge pull request #1586 from PCSX2/gsdx-refresh-gui-options 
Gsdx refresh gui options
 2016-10-04 18:30:48 +02:00
Gregory Hainaut
354aa6831b gsdx ogl: brain hang in the middle of the line 
Only impact if bilinear is forced
 2016-10-03 18:52:02 +02:00
Gregory Hainaut
5b72fab2e4 gsdx ogl: depth regression from 866173a481 
Only mask depth if the min value is too big

Issue #1602
 2016-10-03 18:32:54 +02:00
Gregory Hainaut
3be055a366 gsdx hw: remove code to detect an effect 
It was a tentative to emulate GTA radiosity but the new hack is more generic
 2016-10-02 18:29:23 +02:00
Gregory Hainaut
49c44db635 gsdx:dx: make filtering right 
WMS/WMT 2 is the region clamping mode.

Hw unit can't emulate it right so it can give you bad filtering (Fix #1025)

Note: I only did the fix because I wanted to remove the TEXA hack. Otherwise
it is still recommended to use openGL
 2016-10-02 18:21:52 +02:00
Gregory Hainaut
7f4791fa85 gsdx hw: improve no_ds detection 
Support ZTST_NEVER as no depth read => psx mode speed boost
Use zm/fm to reduce further depth lookup
 2016-10-02 18:21:52 +02:00
Gregory Hainaut
c3ac3ecbe7 gsdx hw: move try alpha test at the beginning 
Will allow to use alpha test optimization to better optimize depth lookup

Require to do clut handling before
 2016-10-02 18:21:52 +02:00
Gregory Hainaut
dc365e066d gsdx tc: remove old plain TEXA hack 
It must work fine without it now.

From the google code comments:

It would be nice to test those games
* Ar Tonelico 2 (line in sprite regression?)
* breath of fire dragon quarter (overlayed user interface in the game)

v2: update Dx code to use the good format
 2016-10-02 18:21:52 +02:00
Gregory Hainaut
cf13cccb1e gsdx: avoid useless spamming of INVALID PSM in release build 2016-10-02 18:21:41 +02:00
Gregory Hainaut
955a69b16e gsdx ogl: fix GT4 regression (wrong texture on timing) 2016-10-02 12:16:48 +02:00
Gregory Hainaut
c7c6566bca gsdx hw: of course the full Jak series will kill me 2016-10-02 11:57:09 +02:00
Gregory Hainaut
b6638d4eec gsdx hw: forgot to comment an unused variable 
Keep the code in case, we better solution is found to validate the depth/frame format
 2016-10-02 10:18:15 +02:00
Gregory Hainaut
3996fbe365 gsdx hw: reduce conplexity around TryAlphaTest 
* As sw renderer, don't bother to bypass it when it is ATST_ALWAYS
* Don't update the ATE register value
=> It is a really bad idea. Next draw call will be wrong if TEST register isn't written.
The TryAlphaTest context could have been updated
 2016-10-01 19:20:49 +02:00
Gregory Hainaut
c5f086b385 gsdx ate: separate the code that depends on TEST.AFAIL 
Easier to read and allow a switch optimization

Add a shortcut for the common ATST_ALWAYS case
 2016-10-01 19:20:38 +02:00
Gregory Hainaut
4612b79575 gsdx: add a warning on vertex trace 
Due to a division by 2, depth lsb bit is always 0

I'm not sure it is critical but let's keep a note for the future
 2016-10-01 19:16:44 +02:00
Gregory Hainaut
d1e07295e7 gsdx linux: add the missing gui option for unscale point/line primitive 2016-10-01 19:16:44 +02:00
Gregory Hainaut
5e1064da55 gsdx: remove the safe accurate blending hack 
V2: Integrate Flatout patch to do the Window side
 2016-10-01 19:15:52 +02:00
Gregory Hainaut
f77c1900fa gsdx tc: always clear a new depth buffer 
Random data isn't a good idea for a depth buffer. It can cause flickering. (Jak2 FMV)

Hopefully it won't impact too much the speed.
 2016-10-01 19:00:17 +02:00
Gregory Hainaut
9c84712640 gsdx hw: enable palette read back on Jak2 2016-10-01 18:47:21 +02:00
Gregory Hainaut
5d93a392e4 gsdx hw: xman half screen correction 2016-09-30 22:25:24 +02:00
Gregory Hainaut
29c25bc375 gsdx clut: disable some assertions often fired 2016-09-30 22:24:38 +02:00
Gregory Hainaut
34686394a6 gsdx hw: add an hack for Jak3 
I'm disappointed...

Read back palette written by the GPU. Avoid strange color on the skin.
 2016-09-30 19:22:16 +02:00
Gregory Hainaut
df2f8684d6 gsdx: improve TC cache log 2016-09-30 19:18:58 +02:00
Gregory Hainaut
8d24aa2b39 gsdx: GoW2 half screen bug 
... Seriously ...
 2016-09-30 19:15:25 +02:00
Gregory Hainaut
fc32b749dd onepad: fix a pad regression on odin sphere 2016-09-30 10:25:14 +02:00
Gregory Hainaut
8d4fadb3c8 Revert "gsdx state: TEX0 write behavior might depends on the context" 
This reverts commit b34243fa7b.

Unfortunately we have a regression on GT4. I'm doomed
 2016-09-28 20:00:56 +02:00
Gregory Hainaut
90ad9cf668 gsdx hw mipmap: tune the rounding + remove previous hack 
GS really uses an invalid texture located at 0.

Improve the rounding for R&C. The idea is to avoid the corner case were only
the corner of the triangle touch the 7/16 edge.
 2016-09-28 19:41:12 +02:00
Gregory Hainaut
adb8be3287 gsdx: add/update comment 
Need to investigate why the number of vertex is different in upscaled resolution
 2016-09-28 19:41:12 +02:00
Gregory Hainaut
749037346c gsdx: report an error if PSM is invalid 2016-09-28 19:41:12 +02:00
Gregory Hainaut
fea31f7422 gsdx: don't use virtual when it is useless 2016-09-28 19:41:11 +02:00
Gregory Hainaut
97172f5e51 gsdx debug: count draw call in a different way 
* Always do +1 before the draw call
* Prefix texture name with i (as input) to keep them before the FB

Goal is to ensure that all renderers share the same draw call value.
 2016-09-28 19:41:11 +02:00
Gregory Hainaut
b34243fa7b gsdx state: TEX0 write behavior might depends on the context 
Game: harley davidson
* write tex0 ctx0
* write tex0 ctx1
* draw  ctx 0

Previous GSdx behavior will load the clut every write of TEX0. In the
above case the draw will take the wrong clut.

To be honest, it could be a wrong emulation on the EE core emulation.
The hardware likely got a single clut (1KB cache is quite expensive)
So clut loading must be skipped if the context is wrong.

Next draw will use the ctx1 clut so I apply TEX0 when the context is switched

Please test harley davidson :)

v2: detect context switch from UpdateContext function
V3: always set m_env.CTXT[i].offset.tex, avoid crash (Thanks to FlatOutPS2 that spot the issue)
V4: move bad psm correction code (rebase put it in the wrong place)
 2016-09-27 10:04:09 +02:00
Gregory Hainaut
e0961d81a0 gsdx HW: use after free crash 
Free bt
3 0xe676d194 in ~Source ../plugins/GSdx/GSTextureCache.cpp:1526
4 0xe676d194 in GSTextureCache::SourceMap::RemoveAt(GSTextureCache::Source*) ../plugins/GSdx/GSTextureCache.cpp:1990
5 0xe676f0fe in GSTextureCache::IncAge() ../plugins/GSdx/GSTextureCache.cpp:1022

Use bt
0 0xe6772a83 in GSTextureCache::LookupSource(GIFRegTEX0 const&, GIFRegTEXA const&, GSVector4i const&) ../plugins/GSdx/GSTextureCache.cpp:204
1 0xe66b0c9f in GSRendererHW::Draw() ../plugins/GSdx/GSRendererHW.cpp:579
2 0xe66fb43e in GSState::FlushPrim() ../plugins/GSdx/GSState.cpp:1509

Hypothesis the m_map array of list contains an invalid pointer
It is populated GSTextureCache::SourceMap::Add based on the coverage. The coverage is based on the offset.
So offset is potentially wrong. As mipmap code hack the offset value. It would be a nice culprit.

This commit avoids a potential bad transition between MIPMAP (which
overwrite the "offset") and the base layer (which wrongly keep an old "offset")

Conclusion, pray for my soul as it is very hard to reproduce
 2016-09-26 20:34:38 +02:00
Gregory Hainaut
04d82d8127 gsdx: size doesn't count but 0.625 might change your life :p 2016-09-26 19:42:07 +02:00
Gregory Hainaut
be9995bd1e gsdx mipmap: improve robustness to avoid potential crash 2016-09-26 09:27:03 +02:00
Gregory Hainaut
ebb2a8ad5a gsdx debug: Add DISABLE_WIP_ASSERTION 
To easily disable assertion on codes that only require investigation
 2016-09-25 20:00:51 +02:00
Gregory Hainaut
ca4f265ce6 gsdx debug: dump mipmap register could be useful now :) 2016-09-25 20:00:51 +02:00
Gregory Hainaut
ef9a144437 gsdx hw: extra trick for the mipmap 
Ratchet & Clank (the third) uses an address of 0 for invalid mipmap.

It would be very awkward to put the middle layer of texture in start of
memory. So let's use this information to correct the lod.

It make the game more robust on the lod rounding
 2016-09-25 11:54:00 +02:00
Gregory Hainaut
78b2848622 gsdx: factorize the TEX0 generation for mipmap 2016-09-25 11:51:48 +02:00
Gregory Hainaut
ccd9ce1728 gsdx hack: move tales of legendia hack to full move 
Also remove the OI hack which is handled by the generic double half clear
 2016-09-25 10:17:08 +02:00
Gregory Hainaut
e229dc1549 gsdx hack: move Resident Evil 4 to full level 
The CRC hack removes the fog, without the hack the screen turns green with D3D,, but the fog emulates correctly on OGL with hardware depth.
 2016-09-25 10:13:21 +02:00
Gregory Hainaut
ad8a84a532 gsdx hw: reduce hack of Spyro series 
Based on the comment, it ought to be fixed with previous commit.
 2016-09-25 10:08:55 +02:00
Gregory Hainaut
7f871b0cc6 gsdx hw: remove various CRC hack that ought to be fixed with previous commit 
* SpidermanWoS
* TyTasmanianTiger
* TyTasmanianTiger2
* DigimonRumbleArena2
* XmenOriginsWolverine
* CallofDutyFinalFronts
* GoW2 (only in openGL)
 2016-09-25 10:08:54 +02:00
Gregory Hainaut
1e343084e2 gsdx hw: group the double half clear with gs mem clear hack 
It avoid redundant check of the GS context

You can disable the extra clear with UserHacks_DisableGsMemClear = 1
 2016-09-25 10:08:54 +02:00
Gregory Hainaut
6c6ed5f443 gsdx ogl: trigger the special RW framebuffer shader when only Alpha is written (#1588) 
* gsdx ogl: trigger the special RW framebuffer shader when only Alpha is written

It will work for both Jak and Ratchet&Clank and without CRC
 2016-09-25 10:05:44 +02:00
Gregory Hainaut
6e2bf98d5f gsdx hw: round mipmap lod value 
Will avoid some corruption based on distance/angle
 2016-09-24 20:05:39 +02:00
Gregory Hainaut
719982e4a3 gsdx hw: forget to update a parameter 
OMG, fixes various mipmap issues
 2016-09-24 18:57:47 +02:00
Gregory Hainaut
76494e5f9c gsdx hw: add an userhack for hw mipmap 2016-09-24 12:39:31 +02:00
Gregory Hainaut
e38aba0dff gsdx: rename SW texture dump filename 
* Use texraw for the unconverted texture (keep index fmt)
  => avoid bad filename order with the multiple texture layers
* add the real mipmap address
* Use a nice string format
 2016-09-24 09:15:40 +02:00
Gregory Hainaut
d89b09427f gsdx: gl logging is only available in MTGS thread 
Fix crash in debug build
 2016-09-22 17:54:44 +02:00
Gregory Hainaut
b00ae974d2 gsdx ogl: fix bad interaction between accurate blending and geometry shader 
Recent optimization allow to use triangle to render sprite even when gs is supported

close #1574
 2016-09-20 09:30:24 +02:00
Jonathan Li
c64e8f944e cdvdgigaherz: Fix printf sign mismatch warnings 
Fixes warning C6340: printf sign mismatch

Only remaining warnings for cdvdGigaherz (using level 4 warning
settings) are:
C6258: TerminateThread does not allow proper thread clean up
C4201: nonstandard extension used: nameless struct/union (from the
lo/hi u128 struct in common/include/Pcsx2Types.h)
 2016-09-20 01:24:23 +01:00
Jonathan Li
57d029f34a cdvdgigaherz: Use INT_PTR for dialog handler return type 
BOOL is not the correct return type (though it works for 32-bit).
 2016-09-20 01:23:47 +01:00
Jonathan Li
0ca36e8943 cdvdgigaherz: Fix value truncation warnings 
Fixes warning C4244: conversion to smaller data type, possible loss of
data.
 2016-09-20 00:47:15 +01:00
Jonathan Li
a61aa8ff0b cdvdgigaherz: Remove unreachable return 
Fixes warning C4702: unreachable code
 2016-09-20 00:46:33 +01:00
Clang Format
2967d5d3f1 cdvdgigaherz: Reformat with clang-format 2016-09-19 19:53:00 +01:00
Jonathan Li
60da39712c cdvdgigaherz: Remove unused code/macros/variables/etc 
The SPTI code is unused, and it's simpler to just use the Windows
ioctls/API if they work (only raw disk sector reading is an issue and
the SPTI workaround is already in place).
 2016-09-19 19:50:55 +01:00
Gregory Hainaut
b91bd3ea01 gsdx dx/gl: fix potential bug in alpha test handling 
Depth test must remain disabled if write were masked.

Bug was detected on ICO (sea/sky) but the previous commit removes
the wrong ATE draw call.
 2016-09-19 08:56:49 +02:00
Gregory Hainaut
6966e08306 gsdx: move alpha test optimization in base class 
One code for all renderers :)
 2016-09-19 08:48:32 +02:00
Gregory Hainaut
38b77397e0 gsdx hw: remove custom Ty Tasmanian Tiger / Simposons OI hack 
Replaced by the generic OI_DoubleHalfClear. If OI_DoubleHalfClear is fast/safe enough, it
will enabled by default in the future.
 2016-09-18 18:50:16 +02:00
Gregory Hainaut
6558317a7e gsdx: s/m_eq.xzyf & 4/m_eq.z/ 
Much better this way
 2016-09-18 18:50:15 +02:00
Gregory Hainaut
7a40b27931 gsdx CRC: move GTA hack to full level 
You can now emulate the radiosity effect with the UserHacks_AutoFlush hack.
 2016-09-18 18:50:15 +02:00
Gregory Hainaut
0f387a8e3c Merge pull request #1535 from PCSX2/clang-tidy-macro-parenthesis 
clang-tidy: use parenthesis around macro parameters
 2016-09-18 18:48:04 +02:00
Jonathan Li
15fbd6fbf4 cdvdgigaherz: Remove ISO file reader (#1569) 
It doesn't support dual layer ISO images, and the ini has to be edited
manually so it loads an ISO image ("$" has to be prepended to the ISO
path as well). The PCSX2 internal ISO file reader is probably better in
most/all aspects and I don't think it's worth copying the logic from
PCSX2 into the plugin.
 2016-09-18 18:38:21 +02:00
Gregory Hainaut
310f13a2f7 gsdx ogl: only use geometry shader to convert big enough draw call (#1554) 
gsdx ogl: only use geometry shader to convert big enough draw call

The purpose of geometry shader is to reduce bandwidth (72 bytes by sprite)
and CPU load.

Unfortunately it increases CPU load due to extra shader validations.

So geometry shader will only be enabled for draw call with more than
16 sprites (arbitrarily, smallest number before shadow hearts plummet)

v2: don't disable geometry shader in replayer.
It is easier to spot sprite rendering and to manually read vertex info.
 2016-09-18 16:58:02 +02:00
Gregory Hainaut
2a60264e40 gsdx replayer: improve error message when file is corrupted 2016-09-18 16:52:35 +02:00