mirror of
https://github.com/libretro/scummvm.git
synced 2024-12-13 12:39:56 +00:00
SAGA: Add comments about possibly race conditions to timer callbacks.
(cherry picked from commit 93f627441ac68e7a4c3e7f748a7b6f999bd9c96a)
This commit is contained in:
parent
a5b9df120d
commit
01020089da
@ -332,6 +332,9 @@ void Interface::saveReminderCallback(void *refCon) {
|
||||
}
|
||||
|
||||
void Interface::updateSaveReminder() {
|
||||
// CHECKME: This is potentially called from a different thread because it is
|
||||
// called from a timer callback. However, it does not seem to take any
|
||||
// precautions to avoid race conditions.
|
||||
if (_active && _panelMode == kPanelMain) {
|
||||
_saveReminderState = _saveReminderState % _vm->getDisplayInfo().saveReminderNumSprites + 1;
|
||||
drawStatusBar();
|
||||
|
@ -224,6 +224,9 @@ void Music::musicVolumeGaugeCallback(void *refCon) {
|
||||
}
|
||||
|
||||
void Music::musicVolumeGauge() {
|
||||
// CHECKME: This is potentially called from a different thread because it is
|
||||
// called from a timer callback. However, it does not seem to take any
|
||||
// precautions to avoid race conditions.
|
||||
int volume;
|
||||
|
||||
_currentVolumePercent += 10;
|
||||
|
@ -399,6 +399,9 @@ void Puzzle::hintTimerCallback(void *refCon) {
|
||||
}
|
||||
|
||||
void Puzzle::solicitHint() {
|
||||
// CHECKME: This is potentially called from a different thread because it is
|
||||
// called from a timer callback. However, it does not seem to take any
|
||||
// precautions to avoid race conditions.
|
||||
int i;
|
||||
|
||||
_vm->_actor->setSpeechColor(1, kITEColorBlack);
|
||||
|
@ -276,6 +276,9 @@ void Render::fpsTimerCallback(void *refCon) {
|
||||
}
|
||||
|
||||
void Render::fpsTimer() {
|
||||
// CHECKME: This is potentially called from a different thread because it is
|
||||
// called from a timer callback. However, it does not seem to take any
|
||||
// precautions to avoid race conditions.
|
||||
_fps = _renderedFrameCount;
|
||||
_renderedFrameCount = 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user