libretro/scummvm
1
0
Fork 0
mirror of https://github.com/libretro/scummvm.git synced 2024-12-15 22:28:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

SCI3: Fix script abort during startup on Big Endian platforms

Browse Source 
svn-id: r55525
This commit is contained in:
Lars Skovlund 2011-01-25 10:21:44 +00:00
parent b52859323c
commit e1a9c866bf
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engines/sci/engine/object.cpp
View File

@ -244,7 +244,11 @@ void Object::initSelectorsSci3(const byte *buf) {
for (int bit = 2; bit < 32; ++bit) {
int value = READ_SCI11ENDIAN_UINT16(seeker + bit * 2);
if (typeMask & (1 << bit)) { // Property
propertyIds[propertyCounter] = groupBaseId + bit;
// We really shouldn't be doing endianness conversion here;
// instead, propertyIds should be converted to a Common::Array, like _baseMethod already is
// This interim solution fixes playing SCI3 PC games on Big Endian platforms
// but would likely fail with Mac versions of the same games...
propertyIds[propertyCounter] = TO_LE_16(groupBaseId + bit);
_variables[propertyCounter] = make_reg(0, value);
propertyOffsets[propertyCounter] = (seeker + bit * 2) - buf;
++propertyCounter;