Commit Graph

9 Commits

Author SHA1 Message Date
Adrian Frühwirth
00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Johannes Schickel
6563171e7b NEVERHOOD: Make GPL headers consisten in themselves. 2014-02-18 02:39:36 +01:00
Sven Hesse
989ea7cb56 JANITORIAL: Remove trailing whitespace 2013-07-14 19:01:47 +02:00
Torbjörn Andersson
7c18021c52 NEVERHOOD: Handle invalid save_slot more gracefully on startup
If the specificed savegame doesn't exist, start the game from the
beginning. Before, it would just hang. The error handling is still
quite primitive, though.
2013-06-28 19:32:59 +02:00
johndoe123
8749efdea8 NEVERHOOD: Add game-internal savegame delete menu
- Rename Widget::addSprite to Widget::initialize
2013-05-08 20:47:43 +02:00
johndoe123
379a8cbbe0 NEVERHOOD: Add support for loading/saving games with the game's own menu
- Add LoadGameMenu class
2013-05-08 20:47:42 +02:00
johndoe123
30178e46e5 NEVERHOOD: Implement savegame loading via GMM (in-game saving/loading still TODO) 2013-05-08 20:47:39 +02:00
johndoe123
99e15e4005 NEVERHOOD: More work on saveload, saving works, loading not yet (from the GMM, in-game isn't finished yet) 2013-05-08 20:47:38 +02:00
johndoe123
c182688e44 NEVERHOOD: Add saveload skeleton (doesn't actually do anything yet) 2013-05-08 20:47:38 +02:00