809 Commits

Author SHA1 Message Date
elasota
1daf4126f7 CINE: Fix signed/unsigned mismatch 2023-07-08 22:02:00 +03:00
Walter Agazzi
e123a2316d CINE: Check for track 19 instead of track 1 for FW
The CD version of Future Wars contains 29 audio tracks, but
only the last 11 are used. Checking for track19 instead of track1
allows removal of the unused files without triggering the
"missing cd audio" warning.
Fixes TRAC #14347
2023-04-07 16:06:50 +02:00
macca8
201bed6634 CINE: Use slot test to test where save is stored
As an interim measure, also reinstate the setAutosave(true) call in querySaveMetaInfos() for the dummy autosave, though I suspect the call to create the dummy autosave should only appear in listSaves(), since there's no save file attached for autosave testing, so no possible data loss (potential fix [#13432](https://bugs.scummvm.org/ticket/13432)).
2023-03-05 23:19:40 +01:00
Eugene Sandulenko
979644c5a0
CINE: Use checkExtendedSaves() 2022-11-27 14:36:27 +01:00
Cameron Cawley
bf02991f02 CINE: Move the engine options into the MetaEngine subclass 2022-11-16 23:58:54 +01:00
Hubert Maier
37cd232edb
CINE: Correct spelling mistake
miniscule -> minuscule
2022-10-27 15:56:09 +02:00
Le Philousophe
b75ecadf56 CINE: Don't use unsafe sprintf and vsprintf 2022-10-23 22:46:19 +02:00
Le Philousophe
c618b7fe91 CINE: Don't use unsafe strcat and strcpy 2022-10-23 22:46:19 +02:00
Donovan Watteau
bf5e489567 JANITORIAL: Fix "to to" and "if if" typos in some comments 2022-09-11 17:45:25 +02:00
Donovan Watteau
27f9a460b5 JANITORIAL: Fix "the the" and similar typos 2022-07-29 19:36:40 +03:00
Cameron Cawley
f3b094e53f ENGINES: Change the MetaEngineDetection interface to match MetaEngine 2022-07-23 23:31:58 +02:00
Cameron Cawley
a020300701 ENGINES: Remove use of getEngineId() in MetaEngine subclasses 2022-07-20 11:54:19 +02:00
Donovan Watteau
7ffa660a44 CINE: Remove the comment about an old PalmOS compiler
The problematic compiler wouldn't be able to compile any C++11 code,
and the PalmOS port has been removed more than 10 years ago anyway.

Looking at the following original commits

- 3ed2192923a146ee4b3f0784396d8e5479d68778
- 420569626c84be5242237125745a117a6ff9a8b9
- 17fef2950718cc38fb7f7bfc1f634ed1b7491eaf

it appears that this workaround was actually meant to be kept, in the
end, so just remove the comment itself.
2022-05-25 19:07:30 +03:00
Donovan Watteau
5b1ec56f96 JANITORIAL: Fix some lost or outdated URLs in comments 2022-05-19 07:57:31 +03:00
Torbjörn Andersson
e06f3c9a5a GUI: Allow game option checkboxes to be disabled
Depending on other game option checkboxes. This is used to
enable/disable the semi-smooth scrolling checkboxes for FM Towns Loom,
since it's only used when smooth scrolling is enabled.
2022-04-21 11:07:17 +02:00
Thunderforge
fd129ebc0c JANITORIAL: "Mac OS X" and "OS X" to "macOS" in comments
Apple's desktop operating system was formerly called "Mac OS X" and "OS X", but since 2016 it has been called "macOS" (starting with version 10.12).

Changing across all comments and documentation to use this current terminology, except in cases where the historical versions are explicitly referenced. No code changes are made; we should consider changing those in future PRs.
2022-01-29 14:15:05 +01:00
Eugene Sandulenko
abea37c9bb
ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
Eugene Sandulenko
3f90dbc7fa
CINE: Fix clang warnings 2021-12-01 00:05:33 +01:00
Orgad Shaneh
0b818ad3f6 CINE: Use nullptr
Using clang-tidy modernize-use-nullptr
2021-11-14 15:51:59 +02:00
Orgad Shaneh
ee57380de7 ENGINES: JANITORIAL: Remove 'virtual' when override is specified 2021-11-14 14:32:04 +02:00
Orgad Shaneh
3919f53326 ENGINES: Replace new[]/memset with new[]() 2021-11-10 19:53:15 +01:00
Alexandre Detiste
6044504762 JANITORIAL: typos
some in the variable names, some in the comments;
no change for the strings that interract with original games assets
2021-10-31 20:46:31 +01:00
Orgad Shaneh
fe104cc337 ENGINES: Use MetaEngine consistently for getting autosave slot
The autosave refactoring that was done in
7adad5aaf5831dc5adcee140f38aacc4a5db2518 used g_engine for identifying the
autosave slot. This worked for in-game save/load, but doesn't fit when
called from the launcher.

Fix by passing MetaEngine to SaveStateDescriptor ctor and using it for this
query.

Amends 7adad5aaf5831dc5adcee140f38aacc4a5db2518.
2021-10-24 16:46:06 +02:00
Kari Salminen
5a46547b7e CINE: Add detection for French patched FW CD
Add detection for Future Wars CD version with French translation patch
applied.

Closes #12490
2021-09-06 22:13:24 +01:00
Kari Salminen
73b109b035 CINE: OS: Fix crash before entering secret base
Check that the filename can be found in the volume entries map before
trying to dereference it.

Fixes #11723
2021-09-04 23:14:18 +02:00
Kari Salminen
294ed169f9 CINE: OS: Fix space missing in verb line
Fixes #11687
2021-09-04 23:14:18 +02:00
Kari Salminen
865e3d6179 CINE: OS: Add detection for Italian Amiga version
Closes #12812
2021-09-04 23:14:18 +02:00
Kari Salminen
b3ef35c7e0 CINE: Keep overflowing message box inside screen
First calculate maximum used Y position in drawMessage
and then reposition the message box to stay inside the
main screen.

Fixes bug #11708
2021-09-04 23:14:18 +02:00
Cameron Cawley
74129492ba CINE: Avoid using static objects with destructors 2021-09-02 21:41:14 +03:00
Orgad Shaneh
7adad5aaf5 ENGINES: Streamline auto-save write/delete protection
Some engines call setAutosave and some don't. isAutosave is used to
determine if a saved game is an autosave, but in fact, on most cases it
just falls back to comparing the name to "Autosave".

This is wrong for several reasons:
* Older versions of ScummVM used Autosave 0.
* The name "Autosave" is translated, so if you change the language, it
  won't be detected.

Instead of relying on the name, use the well-known getAutosaveSlot() from
Engine/MetaEngine.

Fixes #12735.
2021-08-23 13:34:35 +02:00
Max Horn
2f1f8f502e DEVTOOLS: move credits from devtools/credits.pl to engines
This employs a "lazy" approach: the "format" for the credits stays
exactly as it was, i.e., perl code. Of course one may want to change
this to another format (e.g. YAML, JSON, XML; or also shell script or
AWK, like `configure.engine` uses). But I deliberately kept it simple,
to get a minimal change that is easy to verify. Any further changes to
e.g. the format can be layered atop this.
2021-08-05 00:01:46 +02:00
antoniou79
04642eef8a ENGINES: Replace checkCD with isolated partial methods
This is PR #3018 "rebased" on the current HEAD, after the conflicts with PR #3003 and me botching the rebase in that PR

Old PR is here: https://github.com/scummvm/scummvm/pull/3018
2021-07-27 20:51:57 +02:00
Paul Gilbert
005561d305 COMMON: Increase Stream pos, seek, size from int32 to int64 2021-07-08 18:24:28 -07:00
trembyle
09c0b319b8 CINE: Use less generic file for detection
The filename `demo` was used to detect the Operation Stealth Amiga
demo. This would often produce false matches when the same filename
was present in data files for other engines, especially Mac Director.

We can use the filename `demo_os` instead. This is the file used for
the DOS demo (with a different md5).
2021-06-29 23:08:33 +02:00
sluicebox
8e1d90f8e4 ALL: Remove clearAllDebugChannels() from Engine dtors 2021-06-14 12:42:38 -05:00
ysj1173886760
c80dd052d7 CINE: move debug channels to metaEngineDetection 2021-05-22 01:34:57 +02:00
Orgad Shaneh
a05e54f00c JANITORIAL: Remove trailing whitespaces 2021-05-04 11:46:30 +03:00
Eugene Sandulenko
5e7fe2dc57
JANITORIAL: Replace spaces in indentation with tabs 2021-04-15 21:20:36 +02:00
Cameron Cawley
a1890ede9c BASE: Avoid calling PluginMan.getEngineFromMetaEngine where possible 2021-04-05 15:33:23 +01:00
D G Turner
f8f0f09ef2 CINE: Fix GCC Compiler Warnings
These are mainly signed vs. unsigned comparison warnings apart from
a set, but unused variable in the main loop code which can be removed.
2021-03-17 21:53:28 +00:00
Paul Gilbert
ae4da8bce0 ENGINES: Make creation of savegame thumbnails an overrideable method 2021-03-07 09:34:33 -08:00
sluicebox
93eeffc84d JANITORIAL: Update old bug tracker numbers 2021-03-03 02:15:05 +02:00
Cameron Cawley
4ced49acd4 ENGINES: Changed AdvancedMetaEngine::createInstance to return a Common::Error 2020-12-04 20:57:14 +00:00
Eugene Sandulenko
e4f1351d05 CINE: Use AD_ENTRY2s in the detection tables 2020-11-28 13:49:16 +01:00
Eugene Sandulenko
5936026209 ALL: Clarify POTFILES, remove redundant common/translations.h includes 2020-11-10 03:03:49 +01:00
Eugene Sandulenko
7ff34bc9ec PLUGINS: MetaEngineStatic -> MetaEngineDetection 2020-10-11 23:14:39 +02:00
Eugene Sandulenko
7ea6781043 PLUGINS: PLUGIN_TYPE_METAENGINE -> PLUGIN_TYPE_ENGINE_DETECTION 2020-10-11 23:12:32 +02:00
Cameron Cawley
baa1a49122 CINE: Fix warning 2020-10-10 21:26:41 +01:00
aryanrawlani28
992abce74a ENGINES: Rename getMetaEngine helpers
- getME -> getMetaEngineStatic (static parts)
- getMEC -> getMetaEngine (dynamic parts)
2020-10-03 14:56:36 +02:00
aryanrawlani28
d26bbe521c ENGINES: ALL: Finish renaming ME & AME classes
- ME -> MetaEngineStatic (static parts)
- MEC -> MetaEngine (dynamic parts)
2020-10-03 14:56:36 +02:00