344 Commits

Author SHA1 Message Date
antoniou79
52eee0c696 SKY: Ensure _systemVars is freed when quiting the game
Returning to launcher via ScummVM popup menu would retain the values of _systemVars

This would cause relaunching the game (after returning back to launcher) to have wrong value for eg. pastIntro, thus allowing "Save" from the ScummVM popup menu during the intro sequence.
2020-07-29 17:27:20 +03:00
antoniou79
18ba1461e0 SKY: Fix loading the wrong saved file from ScummVM menu 2020-07-25 16:53:41 +03:00
antoniou79
55136a8f7e SKY: Prevent manual save to slot 0
Slot 0 is reserved for autosave but ScummVM in-game would allow saving on it

This was causing segmentation fault (_selectedGame would overflow and also saveGameTexts would be indexed with a -1 index
2020-07-21 16:57:38 +03:00
Thanasis Antoniou
09b6e7bfaf SKY: Correct invalid comment and code for default volume 2020-05-28 16:19:55 +03:00
Thanasis Antoniou
a8b00b8992 SKY: Fix music volume not syncing with ConfMan
For the case that the music volume is set via the native options menu (F5)
2020-05-28 15:55:25 +03:00
mataniko
581a6ec7d6 JANITORIAL: Rename kSupportsRTL to kSupportsReturnToLauncher 2020-05-12 10:36:38 +02:00
mataniko
06242a712b JANITORIAL: Rename EVENT_RTL
Now that ScummVM is adding RTL support, the EVENT_RTL should be disambigious that it is for returning to launcher
2020-05-12 10:36:38 +02:00
Bastien Bouclet
eba793f3fd SKY: Implement keymapper integration 2020-02-20 20:06:37 +01:00
Paul Gilbert
958cb05295 SKY: Removed bulk of engine-specific autosave code
There's still some specific code remaining to keep the way the
existing autosave is handled the same, even though it now saves
it to slot 0, rather than with a .asd extension
2020-02-16 15:44:28 -08:00
Paul Gilbert
a00e44ba6c ENGINES: Merge saveGameState virtual methods into a single one 2020-02-16 15:44:28 -08:00
Paul Gilbert
b396e56bd0 SKY: Refactor to use Engine debugger 2020-02-16 13:07:19 +02:00
Thanasis Antoniou
a2692be730 SKY: Play intro music (Adlib emulator) at proper volume 2020-02-16 00:41:13 +02:00
Bastien Bouclet
88414a32ae SKY: Remove duplicate override keywords 2020-02-09 12:58:19 +01:00
Bastien Bouclet
c2d95628ff SKY: Add override keywords 2020-02-09 12:43:16 +01:00
Eugene Sandulenko
cbafa4cc2c SKY: Added override keywords 2020-02-05 16:14:36 +01:00
Paul Gilbert
5b80320525 ENGINES: Adding override keyword to hasFeature methods 2020-02-04 20:04:11 -08:00
Eugene Sandulenko
88ae01298e SKY: Added override keywords 2020-01-31 14:23:41 +01:00
Cameron Cawley
f2b9f7bb76 BACKENDS: Remove the Windows CE port 2019-11-17 22:33:56 +01:00
Bastien Bouclet
bb813719b5 ENGINES: Change targets to have an 'engine ID'
The engine ID identifies which engine should be used to launch the target.
Also remove the 'single ID' system. Different games from engines that used
that system now have different game IDs.

Also-By: Matthew Hoops <clone2727@gmail.com>
2019-11-03 11:43:00 +01:00
Bastien Bouclet
4b42112721 ENGINES: Add an engine ID to all the engines 2019-11-03 11:43:00 +01:00
D G Turner
ba6834c96e SKY: Fix Missing Default Switch Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-10-20 01:53:57 +01:00
Cameron Cawley
bcef809e61 WINCE: Fix compilation 2019-04-15 08:06:39 +03:00
Lothar Serra Mari
f4fa6efad1 SKY: Add defines for delay(); 2019-02-16 22:47:55 +02:00
Lothar Serra Mari
1dec8d7668 SKY: Decrease cursor redraw delay in menu 2019-02-16 22:47:55 +02:00
Bastien Bouclet
9a4c0ae281 ENGINES: Normalize the getName() result of metaengines
Also-By: Matthew Hoops <clone2727@gmail.com>
2018-12-10 06:47:27 +01:00
Torbjörn Andersson
0ffb057b66 SKY: Show full 320x200px in intro where possible
This commit adds a workaround to unlock existing fullscreen images in
the intro of Beneath a Steel Sky.
The original engine clips the whole intro to 320x192 (the common game
format) even though some images exist as 320x200 in the game data files.
This workaround whitelists all images which actually are 320x200px and
displays them as must have originally been intended.

Fixes Trac#7559.
2018-07-03 10:13:34 +00:00
Bastien Bouclet
1dcb8076db ENGINES: Remove usage of C++11 extended initializer lists 2018-05-10 09:26:26 +02:00
Bastien Bouclet
90b78c5446 ENGINES: Merge GameDescriptor and DetectedGame 2018-05-10 09:04:23 +02:00
Bastien Bouclet
1de5aca585 ENGINES: Set the GameDescriptor decription in the constructor 2018-05-10 09:04:23 +02:00
Bastien Bouclet
643c24db75 ENGINES: Change MetaEngine::listSupportedGames to return plain game descriptors 2018-05-10 09:04:23 +02:00
Bastien Bouclet
8fb149e3c7 ENGINES: Change MetaEngine::findGame to return a plain game descriptor 2018-05-10 09:04:23 +02:00
Bastien Bouclet
cf1ebf2951 ENGINES: Add unknown game variants to the game detector results 2018-05-10 09:04:23 +02:00
Lothar Serra Mari
451cf2304f ENGINES: Show the unknown Game dialog only when the detector is launched by the Add Game feature 2018-04-29 21:47:10 +01:00
Colin Snover
c21eccb517 SKY: Fix setSub incorrectly falling through to subsequent cases 2017-12-08 12:41:16 -06:00
Colin Snover
8e829371c9 SKY: Fix unaligned pointer dereferences
Dereferencing an unaligned pointer will cause a memory fault on
at least older ARM and SPARC architectures, and is warned about
starting in Clang 4.
2017-12-08 07:55:56 +00:00
Colin Snover
a8eddb2fc4 SKY: Fix use of deallocated stack memory
FSNode::getName returns a String object, not a reference, so the
pointer from c_str is valid only until the end of the statement.
2017-11-10 23:22:25 -06:00
Colin Snover
432fd522d2 ENGINES: Remove default1x scaler flag
This flag is removed for a few reasons:

* Engines universally set this flag to true for widths > 320,
  which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
  since its behaviour was almost completely undocumented and users
  would need to figure out that they'd need an explicit non-default
  scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
  deciding how the backend may choose to render its virtual screen.
  The choice of rendering behaviour belongs to the user, and the
  backend, in that order.

A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
2017-10-07 12:30:29 -05:00
Torbjörn Andersson
70a2ca8b7d JANITORIAL: Silence more GCC 7 warnings
All these fall through were marked as deliberate, so again I've only
changed the comment to silence GCC.
2017-08-06 13:30:51 +02:00
Eugene Sandulenko
0e5788f4e3 Merge pull request #866 from BenCastricum/editing
ALL: Unify messages concerning engine data files
2016-12-17 12:45:38 +01:00
Robert Göffringmann
5781568fe6 Fixed collision detection, now it actually corresponds with the original
asm code.
Certain width attributes of the two objects being checked were flipped.
I guess this may render a couple of hacky workarounds not
necessary anymore.
2016-12-11 05:12:51 +01:00
Ben Castricum
ebaab44cd1 ALL: Leave out instructions for engine data issues 2016-12-08 13:38:56 +01:00
Ben Castricum
55512414dd ALL: Change instructions for engine data file issues
The engine data files should be included in the package, so downloading
may not be the best suggestion. Instead refer to the README.
2016-12-06 14:16:37 +01:00
Ben Castricum
e1ec91b69a ALL: Unify 'missing engine data' message 2016-12-05 21:04:50 +01:00
Eugene Sandulenko
dead4aa014 JANITORIAL: Remove trailing spaces 2016-10-09 14:59:58 +02:00
Alexander Tkachev
b665fc933d ALL: Make simpleSaveNames() a MetaEngineFeature
Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.

As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
ab1d160ec8 ALL: Add MetaEngine::simpleSaveNames()
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
2016-08-24 16:07:55 +06:00
lavosspawn
e40b4850f7 Modified compact implementation to work around bug
https://sourceforge.net/p/scummvm/bugs/2687/
when playing Beneath a Steel Sky with our (slightly broken) sky.cpt
2016-07-21 19:14:46 +02:00
Ben Castricum
315ad620af SKY: change "savegame" into "saved game" 2016-07-01 07:34:28 +02:00
Eugene Sandulenko
33abb6118f ALL: Change main engine header guard defines to <directory>_<engine>_H
Recently we started to use this as new semantics, although in the past
we used simly <engine>_H. Now these guard defines are consistent with
rest of the files which are used in the engines.
2016-05-17 18:21:30 +02:00
Eugene Sandulenko
b83672070a SKY: Add safety check 2016-05-14 11:42:43 +02:00