980 Commits

Author SHA1 Message Date
Matthew Hoops
740b6e8fbd IMAGE: Move all ImageDecoders to image/ 2014-02-28 00:27:28 -05:00
Johannes Schickel
8fc7d60feb SCI: Make GPL headers consistent in themselves. 2014-02-18 02:39:37 +01:00
Filippos Karapetis
ed400d57fc SCI: Fix NS rect calculation in GK1 (and SCI32 in general)
This fixes the regressions caused by refactoring in SCI32. Thanks to
Timo Korvola for tracking down the issue and providing an initial
patch in bug #6452
2014-02-17 12:00:17 +02:00
D G Turner
ac4087856f ALL: Remove optimization unstable code on checking for null after new.
These issues were identified by the STACK tool.

By default, the C++ new operator will throw an exception on allocation
failure, rather than returning a null pointer.

The result is that testing the returned pointer for null is redundant
and _may_ be removed by the compiler. This is thus optimization
unstable and may result in incorrect behaviour at runtime.

However, we do not use exceptions as they are not supported by all
compilers and may be disabled.

To make this stable without removing the null check, you could qualify
the new operator call with std::nothrow to indicate that this should
return a null, rather than throwing an exception.

However, using (std::nothrow) was not desirable due to the Symbian
toolchain lacking a <new> header.
A global solution to this was also not easy by redefining "new" as "new
(std::nothrow)" due to custom constructors in NDS toolchain and various
common classes.

Also, this would then need explicit checks for OOM adding to all new
usages as per C malloc which is untidy.

For now to remove this optimisation unstable code is best as it is
likely to not be present anyway, and OOM will cause a system library
exception instead, even without exceptions enabled in the application
code.
2014-01-15 02:36:19 +00:00
Martin Kiewitz
488375effa SCI: fix sci1early+ ega picture issues
also remove hacks for kq5ega + sq4ega
2013-12-26 16:44:51 +01:00
Martin Kiewitz
f369170043 SCI: floodfill reverted, was sci1early difference
fixes sq4 floppy properly
2013-12-26 11:39:01 +01:00
Martin Kiewitz
fd80030f76 SCI: portraits cleanup + show base picture at end 2013-12-24 23:59:22 +01:00
Martin Kiewitz
a4bde6dade SCI: injecting "dual" view into King's Quest 6 CD
for dual mode (text+speech at the same time)
2013-12-24 23:31:17 +01:00
Martin Kiewitz
a72d7d3932 SCI: injecting "dual" view into Laura Bow 2 CD
for dual mode (text+speech at the same time)
2013-12-24 22:24:42 +01:00
Martin Kiewitz
8b3efba40f SCI: change floodfill fix for sq4
behaviour wasn't changed in SCI1, instead it seems that SSCI draws overlays to separate memory and then copies them over. Previous commit caused regression in qfg1vga (funny room)
2013-12-24 10:39:42 +01:00
Martin Kiewitz
c2a2a760e9 SCI: change floodfill to fix sq4 ship taking off
fixes bug #6446
2013-12-23 23:41:35 +01:00
Martin Kiewitz
60de25fb69 SCI: debug code to print out kq6 raw lipsync data 2013-12-18 20:51:50 +01:00
Martin Kiewitz
693d5e6625 SCI: rave support (KQ6 hires portrait lip sync)
Thanks to wjp and [md5] for helping
2013-12-11 08:25:23 +01:00
Filippos Karapetis
fa2ea4fc61 SCI: Add handling for the RAVE resource type, found in KQ6CD
This contains the sync data in the Windows version of KQ6CD.
Note that currently the sync36 resource is 2 bytes bigger
(it contains 2 bytes from the RAVE resource). Some test code
has also been added to dump the RAVE sync resources
2013-12-10 01:41:15 +02:00
Filippos Karapetis
59e6341e35 SCI: Make a note about pic 390 in the blacklisted SQ4CD NRS patch 1.2 2013-10-02 12:25:10 +03:00
m-kiewitz
fa41ee132b SCI: fix for heap corruption during lsl3 ending 2013-09-21 22:35:53 +02:00
Filippos Karapetis
0885a003c5 SCI: Fix bug #3614914 - "SCI: Castle of Dr Brain Spanish crashes after Computer Room"
Ignore the unused x/y displacement fields of cels embedded in pics.
Dr. Brain Spanish, pic 261 contains garbage in these fields (probably
left overs)
2013-08-19 06:30:50 +03:00
Johannes Schickel
dbda889e63 SCI: Take advantage of Surface::getPixels. 2013-08-03 04:02:52 +02:00
Johannes Schickel
dd67e9f099 SCI: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:33 +02:00
Filippos Karapetis
2088a77388 SCI: Add a hack to fix the inventory in GK1
For some reason, the top left nsRect coordinates get swapped in the GK1
inventory screen, investigate why
2013-07-30 04:21:51 +03:00
Sven Hesse
989ea7cb56 JANITORIAL: Remove trailing whitespace 2013-07-14 19:01:47 +02:00
Filippos Karapetis
d530985a6b SCI: Avoid using g_sci for usesOldGfxFunctions() in the GfxPorts class 2013-06-21 13:19:37 +03:00
Filippos Karapetis
5b25c40c40 SCI: Fix a non-initialized variable in GfxScreen - CID 1003105 2013-05-01 01:51:12 +03:00
Filippos Karapetis
012a5ef040 SCI: Fix a non-initialized variable in GfxCursor - CID 1003112 2013-05-01 01:51:12 +03:00
Filippos Karapetis
3012aaa14f SCI: Fix a non-initialized variable in GfxControls16 - CID 1003114 2013-05-01 01:51:11 +03:00
Filippos Karapetis
2d90cc4ac3 SCI: Fix a non-initialized variable in GfxMenu - CID 1003110 2013-05-01 01:51:11 +03:00
Filippos Karapetis
619baf67ae SCI: Initialize some members of GfxPaint16 - CID 1010057 2013-05-01 01:51:10 +03:00
Filippos Karapetis
d840aa4dec SCI: Change wording for the cursor position workarounds 2013-04-28 23:31:10 +03:00
Filippos Karapetis
46ebf37ec9 SCI: Change wording for bug/further info references 2013-04-27 14:04:27 +03:00
Filippos Karapetis
41e02baff1 SCI: Fix scaling in the back room of the bookstore in GK1 2013-04-25 02:36:03 +03:00
Max Horn
51bde6ced5 SCI: Remove a bunch of unused private member variables
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Matthew Hoops
8a50d87445 SCI: Fix potential memory leak with Mac cursor's hotspot 2013-04-16 11:14:04 -04:00
Matthew Hoops
6c1b019056 SCI: Fix mac cursor memory leak 2013-04-16 11:09:30 -04:00
Willem Jan Palenstijn
0250fd8ee1 SCI: Fix hunk entry leak 2013-04-15 21:46:09 +02:00
Filippos Karapetis
51b1ec3139 SCI: Fix drawing in SCI21 hires games without breaking lowres SCI2/SCI21 games 2013-03-28 20:28:51 +02:00
Willem Jan Palenstijn
2d1fd3b554 ALL: Fix typo (existant->existent) 2013-02-23 22:07:32 +01:00
Filippos Karapetis
31aec8c581 SCI: Some more work on scaling in SCI32 2013-01-13 17:28:09 +02:00
Filippos Karapetis
41725ab743 SCI: Fix the night time palette in QFG4 2013-01-11 02:24:18 +02:00
Filippos Karapetis
81d614e63a SCI: More proper handling of scaling and global scaling in SCI32
This fixes several scaling related problems in QFG4 and SQ6
2013-01-11 02:24:18 +02:00
Filippos Karapetis
cf3890b79a SCI: Remove obsolete comment and code 2013-01-11 02:24:18 +02:00
Filippos Karapetis
13ec242a2c SCI: Disable modification of object NS rects in SCI32
This fixes the sliders in QFG4 without introducing any regressions,
as the objects are still drawn on screen using the per-frame adjusted
coordinates
2013-01-11 02:24:17 +02:00
D G Turner
77a9f01454 SCI: Amended fix for palette related compiler warnings. 2012-11-26 21:08:39 +00:00
Filippos Karapetis
9c510c1b52 SCI: Fix warnings 2012-11-26 11:27:02 +02:00
Filippos Karapetis
fb0788d12f SCI: Properly reset the palVary signal when loading (bug #3575569) 2012-11-15 14:57:55 +02:00
Filippos Karapetis
3b5e92d4f3 SCI: Fix bug #3575569 - "SCI: QFG1VGA: Palette/hue bug after loading"
We make sure that any leftover palVary timers are removed when
loading. This is an edge case, but it won't hurt to remove these
timers just in case
2012-11-07 18:11:09 +02:00
Filippos Karapetis
a73e3f44ad SCI: Add a workaround for the large text boxes in Freddy Pharkas CD
Fixes bug #3575276 - "SCI: Freddy Pharkas: Text sometimes drawn/erased
incorrectly"
2012-10-08 22:47:27 +03:00
Johannes Schickel
89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Matthew Hoops
857b92f8ff Merge pull request #268 from clone2727/video-rewrite
VideoDecoder upgrade & partial rewrite
2012-08-26 15:41:56 -04:00
Filippos Karapetis
a391599403 SCI: Update a comment 2012-08-21 11:55:21 +03:00
Filippos Karapetis
7d436622a8 SCI: More work on kRemapColors
This implements some more color remap-based palette effects, found in QFG4
2012-08-21 03:32:23 +03:00