Commit Graph

1300 Commits

Author SHA1 Message Date
D G Turner
4be7972561 HDB: Fix Missing Default Switch Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-12-03 22:12:24 +00:00
Bastien Bouclet
9c8bd056d6 ENGINES: Stop using 'single id' 2019-11-03 11:43:00 +01:00
Bastien Bouclet
4b42112721 ENGINES: Add an engine ID to all the engines 2019-11-03 11:43:00 +01:00
Henrik "Henke37" Andersson
37293f5b3f HDB: Using the class keyword makes the intended use clearer. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
b62b3ab859 HDB: No need to restate that member functions are indeed part of the class. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
1d9e7568fd HDB: Have a return value if the needed codec isn't included in the build. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
5675a00d8f HDB: Bail if the music stream couldn't be created. 2019-10-11 18:10:46 +02:00
Henrik "Henke37" Andersson
89b20bbb86 HDB: Factor out the song code into the Song class, avoiding a lot of duplicate code. 2019-10-11 18:10:46 +02:00
Hubert Maier
79b70f9cf5 JANITORIAL: Keep copyright "sign" upper-case like the rest of the engines 2019-10-08 09:19:06 +02:00
Eugene Sandulenko
9e2bcfbf79 HDB: Remove ADGF_TESTING flag 2019-10-04 23:01:08 +02:00
Henrik "Henke37" Andersson
61e7069169 HDB: The engine does not use mid, mark the games as such. 2019-09-29 19:34:16 +03:00
jepael
f702537820 HDB: Fix Shadowed Variable Compiler Warning 2019-09-26 20:01:24 +01:00
Strangerke
3996676c45 HDB: Fix issue in stylusDown 2019-09-22 14:01:51 +02:00
sluicebox
a76c476b19 HDB: Use fabs instead of abs for doubles
Fixes VS2015 build
2019-09-21 16:27:58 -07:00
D G Turner
d7972603e7 HDB: Fix Game Breaking Bug in Right Mouse Button Handling
The right mouse button (which is the "Use" button for throwing gems etc.)
function sets the Button B flag in the _buttons flag field, but never
cleared it. This resulted in blocking of setting of movement waypoints
with the left button and thus locked up the player character.

You could avoid this by using the "Return" key which is also mapped to
use, but this would only be possible on desktop ports or with a virtual
keyboard.

This commit fixes the mouse handling code to clear the flag and thus
avoids future bug reports.
2019-09-22 00:11:51 +01:00
Eugene Sandulenko
9d028ac4ac HDB: Guard for corrupted sound data 2019-09-20 21:55:08 +02:00
sluicebox
52166aa3b1 HDB: Fix missing semicolon 2019-09-19 02:05:25 -07:00
Strangerke
0344e0adce HDB: Simplify some code 2019-09-19 08:10:49 +02:00
Strangerke
cd2f87942f HDB: Fix another regression in inventory 2019-09-19 08:04:34 +02:00
Strangerke
cb61f2e7c6 HDB: Fix regression introduced in 35ff6ad 2019-09-19 00:32:08 +02:00
Strangerke
10a74b2e6c HDB: Turn a couple of arrays into static const 2019-09-16 23:11:40 +02:00
Strangerke
35ff6adfd5 HDB: Fix some more uninitialized variables 2019-09-16 23:06:17 +02:00
D G Turner
8a65f44311 HDB: Remove Another Fixed Size String Buffer
This reduces the scope for buffer overflow issues.
2019-09-15 00:03:11 +01:00
D G Turner
8555657207 HDB: Improve String Code Usage in HDB Engine Code 2019-09-14 03:03:17 +01:00
D G Turner
076514da3f HDB: Improve String Buffer Usage in AI Inventory Code 2019-09-14 02:47:55 +01:00
D G Turner
8fe7f80d0c HDB: Replace Unecessary Buffer in AI Inventory Code 2019-09-14 02:38:53 +01:00
D G Turner
64e2a21a17 HDB: Avoid String Buffer Overruns from Save Load Code 2019-09-14 02:27:06 +01:00
D G Turner
817bcc4c24 HDB: Remove Fixed String Buffer Usage in Window Code 2019-09-14 02:12:13 +01:00
D G Turner
7064698b60 HDB: Removed Fixed String Buffer from AI Player Code
This is replaced by simpler Common::String equivalent.
2019-09-14 02:01:57 +01:00
D G Turner
0d498a2036 HDB: Remove More Fixed Sized String Buffers in Menu Code 2019-09-14 01:43:09 +01:00
D G Turner
04d522121b HDB: Remove Fixed Sized String Buffers in Menu Code
These are replaced by Common::String usage.
2019-09-14 01:22:25 +01:00
D G Turner
117733ad0a HDB: Fix More GCC Compiler Warnings 2019-09-14 00:07:47 +01:00
D G Turner
c0d6a8fc7a HDB: Further Fixes for GCC Compiler Warnings 2019-09-13 23:06:32 +01:00
D G Turner
c01598484e HDB: Fix Some GCC Compiler Warnings
These were of the type memset of a complex structure.
2019-09-13 22:41:41 +01:00
D G Turner
b940fb7588 HDB: Fix Major Memory Leak in File Manager Class 2019-09-13 21:50:55 +01:00
D G Turner
df940b17af HDB: Close Memory Leaks in Sound Class 2019-09-13 21:20:19 +01:00
D G Turner
6f265805ec HDB: Ensure Demos are Indicated in ScummVM GUI Launcher List 2019-09-13 20:33:55 +01:00
D G Turner
ec677b3fe9 HDB: Fix Crash on Invalid Sound String Pointers
This was causing a crash with buffer overflow on Windows builds, but
diagnosing with Valgrind showed invalid strings being accessed in the
sound code. Some analysis showed that these were mainly the reference
to c_str() buffers from a local heap Common::String which was out of
scope and thus destructed, giving an invalid pointer.

The fix here also simplifies the code as well as avoiding this issue.
2019-09-13 20:14:22 +01:00
sluicebox
76ddbe7bd9 HDB: Fix empty string test 2019-09-10 16:20:19 -07:00
Strangerke
299c28e93e HDB: Remove useless check on array vs null 2019-09-09 23:22:22 +02:00
Strangerke
5e0fa2a71c HDB: Fix more uninitialized variables in Gfx and Window 2019-09-09 23:16:26 +02:00
Strangerke
0e04da2cc8 HDB: Fix more uninitialized variables in ai-init 2019-09-09 22:47:27 +02:00
Strangerke
9de42a143a HDB: Fix a pointer to local variable outside of scope 2019-09-09 22:30:17 +02:00
Strangerke
590285a890 HDB: Reduce the scope of some more variables 2019-09-08 22:15:50 +02:00
Strangerke
feafd2a956 HDB: Remove unused static in setButtons 2019-09-08 22:15:15 +02:00
Bastien Bouclet
997e15878a HDB: Fix out of bounds read in HDBGame::setInMapName 2019-09-08 19:55:23 +02:00
Strangerke
b1db45b718 HDB: Remove useless returns 2019-09-07 22:49:07 +02:00
Strangerke
d99ba0a126 HDB: Fix some array compared to nullptr, reduce some variable scopes 2019-09-07 19:47:36 +02:00
Strangerke
49fe42cc33 HDB: Remove useless existence checks on entityName 2019-09-07 01:25:32 +02:00
Strangerke
db58be617b HDB: Replace some unsafe strcpy by strncpy 2019-09-07 00:40:01 +02:00