Commit Graph

20 Commits

Author SHA1 Message Date
aryanrawlani28
03f3f01740 GUI: Simplify code for UnknownGameDialogs when generating bug tracker URL. 2020-08-30 14:43:41 +02:00
aryanrawlani28
e5445fb901 GUI: U32: Small improvements/fixes
- Remove = operator in String, which compared to a U32String.
- Let implicit cast take care of results from getResultString, so in-future easy to spot new changes.
- Use uint32 for each char when encodingUrlStrings, to avoid unsafe comparision.
2020-08-30 14:43:41 +02:00
aryanrawlani28
01176e43f7 GUI: U32: Use unicode based generateGameReport correctly in all places
- UnknownGameDialog: Use u32 for gameReport dependant functions
2020-08-30 14:43:41 +02:00
aryanrawlani28
d12c6c4338 GUI: U32: Code cleanup
- Remove extra parantheses leftover from temp code
- SaveLoadDialog - do not encode when setting labels
- Remove mapping variable from ThemeEngine::loadScalableFont (and use default 0)
- Remove incorrect u32 constructor wrapper from confman.set in eventrecorder.cpp
2020-08-30 14:43:41 +02:00
aryanrawlani28
f800ca4ada GUI: U32: Convert majority of code to use U32
This commit also includes some additional major changes.

- Return U32String from TransMan getTranslation()
- Change tooltips to be U32Strings
- Remove temporary code of convertToU32String
- U32 Support various dialogs (Browser, FileBrowser, Messages, Chooser, etc)
- U32 for music plugins
- U32 for OSD messages
- Add some helper functions to ustr.cpp
- Change default tooltips from nullptr & 0 -> ""
- Some runtime exceptions may occur when changing languages due to incorrect String::Format
2020-08-30 14:43:41 +02:00
aryanrawlani28
aafade4507 GUI: U32: Shift most widgets to draw with u32
- ButtonWidgets (Button, Radio, Checkbox, dropdown)
- StaticTextWidgets
- PopUpWidgets
- Tabs
- Add a temporary overloaded drawDDText function to make other widgets draw normally
2020-08-30 14:43:41 +02:00
Bastien Bouclet
6e1abf064a GUI: Use nullptr instead of 0 or NULL where appropriate 2020-01-19 15:08:37 +01:00
Bastien Bouclet
eb28c5a092 GUI: Use a dialog theme layout for the unknown game dialog 2020-01-04 10:56:25 +01:00
Bastien Bouclet
bb813719b5 ENGINES: Change targets to have an 'engine ID'
The engine ID identifies which engine should be used to launch the target.
Also remove the 'single ID' system. Different games from engines that used
that system now have different game IDs.

Also-By: Matthew Hoops <clone2727@gmail.com>
2019-11-03 11:43:00 +01:00
D G Turner
30c366ee5d GUI: Add Missing Switch Default Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-10-03 06:03:46 +01:00
Bastien Bouclet
c5b92bcb2e GUI: Better integration for the unknown game dialog when adding games
* The list of candidates now includes unknown variants. When an unknown
variant is selected, the unknown game dialog is shown.
* On the unknown game dialog, users are given the choice to add the game
when that is possible, or to cancel.

The goal of those changes is to make the unknown game dialog less
confusing for users, especially when both known and unknown games
variants are found.
2019-05-12 11:44:51 +03:00
D G Turner
ae7acf1099 GUI: Fix Compiler Warning in Unknown Game Dialog
This is a signed vs. unsigned comparison warning from GCC.
2019-05-03 00:43:03 +01:00
Thierry Crozat
e4218e2e1d GUI: Do not abuse the engine name query item to provide a summary
The redirect rule on the web site expected only two query items, one
with the engine name and another one with the description. However it
was a bit lax in its regex and we could pass additional query items
as part of either the engine name or description. The unknown game
dialog was abusing it to pass a summary.

The rewrite rule for the URL on the web site has now been fixed to
avoid such abuse. And instead it also adds a summary. So the
unknown name dialog should no longer provide one.
2019-04-29 22:50:53 +01:00
Lothar Serra Mari
08a5feb1ee GUI: Add "Summary" to bug reports generated by the unknown game dialog 2019-04-29 21:10:12 +02:00
Thierry Crozat
623bef19a5 GUI: Enable report button in unknown game dialog 2019-04-28 23:30:17 +01:00
Thierry Crozat
74577f9892 GUI: Update code to access the bug tracker in the unknown game dialog
The code is still disabled, but it is now in a working state and
can be tested by removing the #if 0 and changing the URL to a test
server with a redirect rule.
2019-04-27 02:42:16 +01:00
D G Turner
efcd857083 GUI: Fix Mouse Wheel Input for Unknown Game Dialog.
This should also fix this for other instances of ScrollContainer, though
the dialogs / widgets may require the same change.

This fixes bug Trac #10741.
2018-10-11 05:52:02 +01:00
Thierry Crozat
201b347ebd GUI: Improve layout update for UnknownGameDialog
Previously the dialog was not resized and was just recentered on
the screen when the overlay size changed. Now it is properly
resized as well.
2018-05-28 22:21:10 +01:00
Thierry Crozat
42cd3e9596 GUI: Use ScrollContainerWidget in unknown game dialog
This should fix issues when the text to display in the dialog is
too big to fit on the screen.
2018-05-28 22:21:10 +01:00
Thierry Crozat
44bc04e0d9 GUI: Move UnknownGameDialog to gui 2018-05-28 20:55:00 +01:00