342 Commits

Author SHA1 Message Date
Max Horn
4ccce19876 ENGINES: Enhance namespace comments a bit
svn-id: r53484
2010-10-15 12:48:19 +00:00
Paul Gilbert
168670acb2 TINSEL: Fix for #3087863 - Code analysis warnings
svn-id: r53471
2010-10-15 08:52:22 +00:00
Max Horn
2db927c223 TINSEL: Remove redundant '_Windows' check
svn-id: r52932
2010-09-28 19:06:03 +00:00
Johannes Schickel
6588398ce6 MIDI: Send a reset MIDI device signal on startup.
This is currently done in the engine code. I adapted AGI, AGOS, DRACI,
GROOVIE, LURE, MADE, QUEEN, SAGA, SKY, TINSEL and TOUCHE to send a reset
device on startup. The sound output still works fine (started up a game
from every engine), so this should hopefully not introduce any regressions.

As far as I can tell it seems that SCUMM does send a proper device reset, so
I did not touch it. KYRA only sends a proper reset for MT-32 currently. I am
not sure about SCI though.

This fixes bug #3066826 "SIMON: MIDI notes off when using RTL after SCI".

svn-id: r52736
2010-09-15 22:00:20 +00:00
Eugene Sandulenko
f7f5a561eb TINSEL: Remove unused variable
svn-id: r52684
2010-09-12 14:18:40 +00:00
Paul Gilbert
70fed746df TINSEL: Fix for #3032780 - Mute not respected in DW1
svn-id: r52674
2010-09-11 05:28:54 +00:00
Paul Gilbert
77c43f4d0d TINSEL: Fix for #3032778 - Mute not respected in DW2
svn-id: r52673
2010-09-11 04:32:53 +00:00
Eugene Sandulenko
99c9ba697c TINSEL: Fix bug #3032780: "DW: Mute setting does not work"
Bug #3032778 was fixed too as it is the duplicate.
Since there is no engine-specific logic, rely on superclass'
setupSoundSettings(), and use it on startup too.

svn-id: r52374
2010-08-25 07:41:35 +00:00
Filippos Karapetis
83c8ed97e3 TINSEL: Code cleanup, fixed potentially undefined behavior
svn-id: r52338
2010-08-24 13:31:44 +00:00
Filippos Karapetis
3082354fa4 TINSEL: Adjusted the commented out music debug code for the latest changes to
the lookup tables

svn-id: r52333
2010-08-24 12:45:19 +00:00
Filippos Karapetis
808e36541e TINSEL: Removed the hardcoded MIDI offset arrays.
MIDI offsets for the enhanced music soundtrack
are now calculated on the fly

svn-id: r52331
2010-08-24 12:27:22 +00:00
Eugene Sandulenko
cb93679ea2 TINSEL: Fixed final track mapping to Ench soundtrack.
For some reason it referred to non-existent 3141. Changed it to
correct 3142.

svn-id: r52324
2010-08-24 09:47:04 +00:00
Eugene Sandulenko
95748c07cc TINSEL: Partial fix for MIDI in German release.
Bug #2827022: "DW: Enhanced music doesn't work". This release
has completely different MIDI.DAT file. So far offsets and detection
for this version were added. The mapping has to be confirmed with
James Woodcock.

svn-id: r52323
2010-08-24 09:46:17 +00:00
Eugene Sandulenko
4a0cdf00e1 TINSEL: fix warning
svn-id: r52149
2010-08-17 11:01:41 +00:00
Max Horn
1d4c82885d DEBUGGER: Simplify how our console debugger works / is used
* Remove _isAttached member var and isAttached method
* Engines now always call the onFrame method; whether it does
  something is decided by the debugger class resp. its subclasses
* Make detach() protected instead of private, so that subclasses
  can invoke it
* Remove _detach_now member var (call detach() instead).
* Rename _frame_countdown to _frameCountdown and properly
  document it.
* Add more doxygen comments
* Cleanup

svn-id: r50963
2010-07-17 18:38:42 +00:00
Torbjörn Andersson
bcb4c49a03 Cleanup.
svn-id: r50924
2010-07-16 03:14:03 +00:00
Max Horn
4f914e7a9f TINSEL: Replace global object s_rectList by a TinselEngine member var
svn-id: r50834
2010-07-12 23:19:33 +00:00
Johannes Schickel
bf2b059a63 Silence possible use of uninitialized variable warning in g++.
svn-id: r50501
2010-06-29 18:20:10 +00:00
Torbjörn Andersson
5997307081 Fixed GCC warnings. (Same warning twice, actually.)
svn-id: r50383
2010-06-27 17:06:26 +00:00
Paul Gilbert
b6b4247335 Workaround that corrects some bad frame data in the Russian version that was causing the several game crashes
svn-id: r50372
2010-06-27 11:16:49 +00:00
Paul Gilbert
b161310193 Script workaround fix for bug #2917661 - Crash when interacting with D'Blah
svn-id: r50360
2010-06-27 01:06:51 +00:00
Florian Kagerer
c35e350531 AUDIO: get rid of MDT_PREFER_MIDI since it should be sufficient to either select MDT_PREFER_MT32 or MDT_PREFER_GM
svn-id: r50288
2010-06-25 20:51:57 +00:00
Max Horn
bbad3f333a Patch #1956501: "GUI/LAUNCHER: Midi device selection"
svn-id: r50128
2010-06-21 21:36:36 +00:00
Eugene Sandulenko
44a39ffbc6 AdvancedDetector: Add new parameter directoryGlobs.
Without this parameter mass detection gave tons of false alarms.
Use globbing for narrowing down the depth search.

svn-id: r49788
2010-06-15 10:59:23 +00:00
Eugene Sandulenko
d5c3cda8c5 Moved tinsel detection tables to separate file.
svn-id: r49694
2010-06-15 10:15:29 +00:00
Eugene Sandulenko
4d517ed0e9 Extended advancedDetector with depth parameter.
Now AD can search nested directories. By default it is turned off,
but there is new parameter to ADParameters struct. Usually value
of 2 is good enough for all purposes.

svn-id: r49653
2010-06-14 14:50:23 +00:00
Paul Gilbert
c253a57e47 Bugfix for #2974817 - Mad Drongo Animation Malfunction
svn-id: r49447
2010-06-06 01:12:41 +00:00
Johannes Schickel
5bb4fadc4c Fix change in r49356, Common::strlcpy should only be used on zero terminated source strings.
The original code change with r49086 did only aimed at zero terminating
the szFilename string (as the comment suggests), so I now changed it
to use memcpy and a manual placement of the terminating zero.

svn-id: r49357
2010-05-31 18:05:39 +00:00
David Turner
d1da820a75 Fix for DW2 engine abort with message "Cannot find file hienergy.sc!".
Bug introduced by r49086 change which could trim the last character of filenames.

svn-id: r49356
2010-05-31 15:16:46 +00:00
Johannes Schickel
62717eafc4 Replace some strncpy usages with Common::strlcpy.
svn-id: r49086
2010-05-18 18:16:47 +00:00
Max Horn
970745e60c Move DebugChannel related code to new header
svn-id: r48935
2010-05-04 11:59:22 +00:00
Max Horn
b3e404109c Move initGraphics and initCommonGFX from to new header.
These functions are only used internally be Engine subclasses, and
by moving them to a separate header we can reduce indirect header
dependencies.

svn-id: r48934
2010-05-04 11:58:12 +00:00
Max Horn
5568a8473b Get rid of Engine::_gameDataDir.
This greatly reduces indirect dependencies on several header files
from common.

svn-id: r48933
2010-05-04 11:56:52 +00:00
Max Horn
a5aedb73be TINSEL: Avoid global constructor for clickPos
svn-id: r48841
2010-04-28 22:23:00 +00:00
Max Horn
460d69e885 COMMON: Move DebugChannel stuff into a new DebugMan singleton
svn-id: r48821
2010-04-27 21:40:52 +00:00
Willem Jan Palenstijn
6f4063fd5f Fix warning
svn-id: r48817
2010-04-27 20:14:56 +00:00
Max Horn
f103f01284 TINSEL: Change cdGraphStream to a Common::File pointer,
to not rely on global constructors

svn-id: r48765
2010-04-21 21:23:08 +00:00
Max Horn
6d80424908 Fix warnings when FLAC&MP3&VORBIS is disabled; also fixes leak in Tinsel
svn-id: r48696
2010-04-17 23:57:50 +00:00
Max Horn
ae3962ce36 Fix for bug #2987895: "DW2: graphical errors in video on Windows"
svn-id: r48665
2010-04-16 11:00:13 +00:00
Ori Avtalion
2fc9d6845b Apply patch #2982163 - CONFIG: Use HE keyword instead of HB for the Hebrew language
svn-id: r48645
2010-04-12 21:21:06 +00:00
Max Horn
a1840bd573 AUDIO: Rename Mixer::playInputStream to playStream
svn-id: r48637
2010-04-12 09:14:17 +00:00
Johannes Schickel
de3dd04005 Commit of the updated version of Fingolfin's patch for bug #2981788 "TINSEL: Build with -O2 broken".
svn-id: r48534
2010-04-05 07:22:34 +00:00
Max Horn
cac0ac66e2 COMMON: Get rid of Common::StringList
svn-id: r48287
2010-03-18 15:54:40 +00:00
Max Horn
75de0ebccb TINSEL: Change SaveSceneSsData from char* to SAVED_DATA*
svn-id: r48285
2010-03-18 15:39:56 +00:00
Max Horn
d78dba3bca COMMON: Move Common::RandomSource to common/random.*
svn-id: r48279
2010-03-18 15:07:11 +00:00
Paul Gilbert
f4bf67cd21 Increased the default Discworld 2 double-click time from 0.33 seconds to 0.55 seconds (from 6 to 10 frames)
svn-id: r48255
2010-03-14 03:40:16 +00:00
Yotam Barnoy
ef330ed9b4 Patch for bug 2943361 by littleboy, adding full kb modifier support to all engines + GUI and proper keypad handling
svn-id: r48101
2010-02-21 04:04:13 +00:00
Fabio Battaglia
8502d9248e tinsel: Add detection for Discworld 1 floppy EUR version
svn-id: r48088
2010-02-19 12:33:58 +00:00
Max Horn
9de580aa6e TINSEL: Cleanup the 'script workaround' code a bit.
* Rewrap comments to 72 columns
* Add some references to relevant bug tracker items
* Use sizeof instead of handcoding array lengths, which is error prone
  and tedious
* Move definition of WorkaroundEntry from pcode.h to pcode.cpp
* Define FRAGMENT_WORD to make fragment code a bit more readable,
  and also encoding of 16 bit words into it less error prone
* Make all code fragments static

svn-id: r48065
2010-02-15 10:01:26 +00:00
Paul Gilbert
86163d5a6c Script workaround fix for DW1, for being able to give the whistle back to the pirate before the parrot
svn-id: r47987
2010-02-08 10:02:18 +00:00