2719 Commits

Author SHA1 Message Date
Eugene Sandulenko
874939ae89 COMMON: Make XCode 5.0.1 happier 2013-10-27 22:45:49 +02:00
Matthew Hoops
eef7f9f46b COMMON: Fix the NE group icon resource type 2013-10-27 13:15:17 -04:00
D G Turner
a1998abed4 COMMON: Fix missing arjDecoder class variable init. CID 1002929
This fixes a couple of these variables by removing them as they
are unused or set-but-unused variables.
2013-10-05 07:02:18 +01:00
Eugene Sandulenko
e11da51202 COMMON: Make Coverity 6.6.1 happier
Apparently their tools do not include __has_feature clang extension.
I've submitted the bugreport to them but in the meantime let's have this
define in the system.
2013-09-27 11:06:22 +03:00
Filippos Karapetis
dca513dc20 COMMON: Expand the warnings thrown for broken DCL compressed data
The Russian translated versions of Neverhood have invalid unpacked
sizes for some compressed resources. This helps in identifying their
resource parameters more easily
2013-09-26 10:46:09 +03:00
Eugene Sandulenko
c55411a032 COMMON: Shut more Coverity warnings in coroutines. 2013-09-21 22:45:43 +03:00
Eugene Sandulenko
91bcfb290a COMMON: Use unused variables in coroutine macros.
This should fix couple of hundreds of Coverity detected defects.
2013-09-21 09:49:17 +03:00
Johannes Schickel
7c2660c97e COMMON: Add setVal to ConfigManager::Domain.
This fixes compilation in the keymapper.
2013-08-13 00:11:46 +02:00
Johannes Schickel
818d3981e3 Merge pull request #377 from lordhoto/config-manager-cleanup
Config Manager Cleanup
2013-08-12 14:30:22 -07:00
Johannes Schickel
f7d3b06711 COMMON: Get rid of write version of ConfigManager::getGameDomains.
This can be abused to insert Domains into the game domains without any checks.
Instead, only write iterator access is given.
2013-08-12 01:33:29 +02:00
Johannes Schickel
0dae60a357 COMMON: Remove commented out include in config-manager.h. 2013-08-08 16:32:41 +02:00
Johannes Schickel
6da6e4e686 COMMON: Remove outdated comments on INIFile.
These very old comments claimed that ConfigManager uses INIFile. This is not
true however. Thus removing them should clear things up a little bit.
2013-08-08 16:30:38 +02:00
Johannes Schickel
63750d6780 COMMON: Rename ConfigFile to INIFile.
This clears up that 'ConfigFile' is actually a class handling only INI-files.
2013-08-08 16:28:38 +02:00
Johannes Schickel
774d53045d COMMON: Do not let ConfigManager::Domain inherit from StringMap.
Instead we provide wrapper functionality now. Intuitively a Domain is not a
simple StringMap.
2013-08-08 03:14:23 +02:00
Johannes Schickel
4790a4abd5 COMMON: Define all Unix98/BSD math constants in scummsys.h.
This should fix compilation on mingw64 with --enable-c++11 and also make sure
the constants are present on other systems for the uncommon case they might be
missing.
2013-08-02 20:02:02 +02:00
D G Turner
17ccd18ed3 COMMON: Add comment explaining reason for defining math constants. 2013-08-02 06:23:52 +01:00
D G Turner
26a9b528da COMMON: Move definition of math constants to scummsys header.
This should have no effect on common/math.h as scummsys is included at
the top anyway, but this will fix compilation on some toolchains when
strict ANSI language compliance is enabled i.e. -std=c++11, rather than
-std=gnu11.

This causes an issue as a side effect is to set a guard which disables
various non-standard defines in the system headers i.e. the M_PI and
M_SQRT1_2 constant definitions in the MinGW x86_64 toolchain on
buildbot.

By moving this into scummsys.h after the point of system math.h
inclusion, we can ensure that M_PI etc. are always present.
2013-07-31 06:18:58 +01:00
Johannes Schickel
2f9b7ba686 COMMON: Enforce formatting guidelines a bit more in util.h. 2013-07-30 21:02:01 +02:00
Eugene Sandulenko
67af740f3a COMMON: Revert last commit as rightfully pointed out by fuzze. 2013-07-29 12:30:47 +03:00
Eugene Sandulenko
351af76f9b COMMON: Added copy constructors and copier to Rect and Point. 2013-07-29 12:25:57 +03:00
Eugene Sandulenko
2c812ade01 Merge pull request #353 from clone2727/eventrec_timer_fix
ALL: Don't use EventRecorder at all when not compiled in
2013-07-18 08:15:28 -07:00
Eugene Sandulenko
9572bc6e30 RECORDER: Fix wrong argument order 2013-07-15 14:31:34 +03:00
Sven Hesse
989ea7cb56 JANITORIAL: Remove trailing whitespace 2013-07-14 19:01:47 +02:00
Eugene Sandulenko
aaaf466c71 RECORDER: Fix CID 1046886. Uninit class variables. 2013-07-14 19:03:29 +03:00
Matthew Hoops
1f6894ab25 COMMON: Cleanup the MacResManager a bit 2013-07-11 23:45:19 -04:00
Matthew Hoops
4a7e4e5b22 ALL: Don't use EventRecorder at all when not compiled in 2013-07-06 23:54:45 -04:00
Eugene Sandulenko
3490091ba2 RECORDER: Fix tests compilation. Patch by D G Turner 2013-07-06 07:31:28 +03:00
Filippos Karapetis
ecc43c9b92 Revert "COMMON: Fix crash when the keymapper and the event recorder are enabled"
This reverts commit 93987d999c61221bda3da548c8c81f5d6d906a12.
2013-07-05 03:05:54 +03:00
Filippos Karapetis
93987d999c COMMON: Fix crash when the keymapper and the event recorder are enabled
DefaultEventManager registers a keymapper that is supposed to be
auto-freed. However, the event recorder then sets itself as a new
keymapper, but because the autofree flag is already set,
registerMapper() ends up deleting the event recorder itself. Setting
the autofree flag before actually freeing the mapper fixes the issue
and prevents ScummVM from crashing on startup
2013-07-05 02:56:12 +03:00
Johannes Schickel
71b031be12 COMMON: Initialize EventDispatcher::_autoFreeMapper.
This fixes a branching on uninitialized variable reported by valgrind on
startup.
2013-07-05 01:45:09 +02:00
Eugene Sandulenko
49210a803a Merge pull request #331 from sev-/gsoc2012-eventsrecorder
GSoC2012: Event Recorder (reworked)
2013-07-04 04:58:54 -07:00
Johannes Schickel
a00c3e75b0 Merge pull request #342 from RichieSams/addDeleteRangeStringMethod
COMMON: Add erase method to String class
2013-07-01 05:18:49 -07:00
richiesams
e1ff60da7a COMMON: Add erase method to String class 2013-06-20 15:40:25 -05:00
Matthew Hoops
8dace22f97 COMMON: Fix custom NE resource type names 2013-06-09 21:18:33 -04:00
Willem Jan Palenstijn
dd003b6a28 COMMON: Add basic documentation for RDFT 2013-06-08 22:03:22 +02:00
Johannes Schickel
bc358b77a8 COMMON: Improve comment in CosineTable::CosineTable.
This commit changes the comment to use the same variable names as we do in the
code. Furthermore, it also makes the comment a bit easier to grasp.
2013-06-08 21:56:48 +02:00
Johannes Schickel
4da5d11e1f COMMON: Try to document the SineTable/CosineTable table entries. 2013-06-08 21:56:48 +02:00
Johannes Schickel
4efc9b152c COMMON: Save memory by allocating only required entries in Cosine-/SineTable.
The tables only contain (2^bitPrecision)/2 entries. The code allocated twice
as many entries previously.
2013-06-08 21:47:52 +02:00
Johannes Schickel
21f87070af COMMON: Fix regression in SineTable creation.
This is a regression from f4ba8a6485b097a8ef1e2004d1af127243f379f1. The
commit replaced the static cosine and sine tables with dynamically created
ones. In the process of that a copy&paste error happened which made the sine
table use the layout of the cosine table. This commit now changes the
dynamically created sine tables to conform to the layout of the previous
static tables.
2013-06-08 21:47:51 +02:00
Alyssa Milburn
7840b5e4b9 COMMON: Add depth/flat parameters to addSubDirectoryMatching. 2013-06-06 21:41:14 +02:00
Eugene Sandulenko
f59512c47e RECORDER: Implement Events Recorder 2013-05-17 00:18:09 +03:00
Matthew Hoops
0031c41db8 COMMON: Change kPlatformPC to kPlatformDOS
"PC" was very ambiguous and now it matches what we show in the GUI.

This also corrects sword2's platform to Windows.
2013-05-02 18:43:10 -04:00
Alyssa Milburn
ace04a92a2 COMMON: Add ConfigFile::addSection function. 2013-04-19 00:22:07 +02:00
Willem Jan Palenstijn
b8df8203c5 COMMON: Don't use parserError for non-parser errors 2013-04-16 19:13:30 +02:00
Sven Hesse
ef26df5877 COMMON: Remove useless member variable FFT:_permutation 2013-04-15 18:21:29 +02:00
Thierry Crozat
33a29ca61c COMMON: Fix assert condition in String::setChar() 2013-03-20 20:10:13 +00:00
Paul Gilbert
86306893c8 Merge pull request #309 from dreammaster/hopkins
Hopkins FBI Pull Request
2013-02-24 06:36:26 -08:00
Willem Jan Palenstijn
2d1fd3b554 ALL: Fix typo (existant->existent) 2013-02-23 22:07:32 +01:00
Dreammaster
bb3285d933 Merge branch 'master' into hopkins 2013-02-15 08:25:09 -05:00
Johannes Schickel
2f73d64e80 Merge pull request #305 from giucam/bufferedseekable
Make BufferedSeekableReadStream use the buffer with SEEK_SET and SEEK_END
2013-01-28 08:43:52 -08:00