76 Commits

Author SHA1 Message Date
antoniou79
bd39fd3ec9 SKY: Prevent GMM save or load if control panel is open
It was especially buggy when trying to save from GMM while the save panel of the game is open.
2022-01-18 12:33:16 +00:00
antoniou79
85064d6553 SKY: Prevent saving empty string as name
From the in-game Save panel.

Saving empty string is still allowed from the ScummVM GMM and it's translated to current date time.
There's a minor glitch there with the '/' character being shown as the wrong glyph in BaSS save/restore panel.
Also note, we keep the behavior of the original, so a string of blanks is still allowed as a save name.
2022-01-18 12:33:16 +00:00
antoniou79
51cdcb8766 SKY: Fix saving names for non selected save slots
We use a dirty string buffer to temporary store the edited text for the selected slot
2022-01-18 12:33:16 +00:00
Eugene Sandulenko
abea37c9bb
ALL: Update ScummVM project license to GPLv3+ 2021-12-26 18:48:43 +01:00
antoniou79
52eee0c696 SKY: Ensure _systemVars is freed when quiting the game
Returning to launcher via ScummVM popup menu would retain the values of _systemVars

This would cause relaunching the game (after returning back to launcher) to have wrong value for eg. pastIntro, thus allowing "Save" from the ScummVM popup menu during the intro sequence.
2020-07-29 17:27:20 +03:00
antoniou79
18ba1461e0 SKY: Fix loading the wrong saved file from ScummVM menu 2020-07-25 16:53:41 +03:00
antoniou79
55136a8f7e SKY: Prevent manual save to slot 0
Slot 0 is reserved for autosave but ScummVM in-game would allow saving on it

This was causing segmentation fault (_selectedGame would overflow and also saveGameTexts would be indexed with a -1 index
2020-07-21 16:57:38 +03:00
Thanasis Antoniou
a8b00b8992 SKY: Fix music volume not syncing with ConfMan
For the case that the music volume is set via the native options menu (F5)
2020-05-28 15:55:25 +03:00
Bastien Bouclet
eba793f3fd SKY: Implement keymapper integration 2020-02-20 20:06:37 +01:00
Paul Gilbert
958cb05295 SKY: Removed bulk of engine-specific autosave code
There's still some specific code remaining to keep the way the
existing autosave is handled the same, even though it now saves
it to slot 0, rather than with a .asd extension
2020-02-16 15:44:28 -08:00
Cameron Cawley
f2b9f7bb76 BACKENDS: Remove the Windows CE port 2019-11-17 22:33:56 +01:00
Lothar Serra Mari
f4fa6efad1 SKY: Add defines for delay(); 2019-02-16 22:47:55 +02:00
Lothar Serra Mari
1dec8d7668 SKY: Decrease cursor redraw delay in menu 2019-02-16 22:47:55 +02:00
Ben Castricum
315ad620af SKY: change "savegame" into "saved game" 2016-07-01 07:34:28 +02:00
Eugene Sandulenko
b83672070a SKY: Add safety check 2016-05-14 11:42:43 +02:00
Eugene Sandulenko
b3a238a750 SKY: Safer string manipulation 2016-05-12 14:42:12 +02:00
Eugene Sandulenko
701120cabd SKY: Two more adjustments to Russian BASS 2016-04-18 08:18:17 +02:00
Eugene Sandulenko
44a49dbec5 SKY: Proper support for Russian BASS 2016-04-17 12:44:18 +02:00
Eugene Sandulenko
83c7702198 SKY: Added localized quit message for Russian translation 2016-04-16 23:39:38 +02:00
Johannes Schickel
bd08fe9d5c SKY: Make GPL headers consistent in themselves. 2014-02-18 02:39:38 +01:00
D G Turner
3acc3837e1 SKY: Minor formatting fix. 2012-03-30 01:57:56 +01:00
Eric Culp
2fe60082e8 SKY: Allow game to be loaded from main menu dialog while in-game control panel is open. Fixes bug #3448294 2012-03-28 19:09:12 -04:00
Willem Jan Palenstijn
9ffe3e11d9 Merge pull request #182 from fingolfin/forbid-ctype
ALL: Avoid using is* macros from ctype.h
2012-02-21 11:33:32 -08:00
Max Horn
4f8665fc83 COMMON: Move isFoo functions to namespace Common, add doxygen comments 2012-02-20 16:18:27 +01:00
Tarek Soliman
a4798602d7 JANITORIAL: Fix missing whitespace in pointer cast
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'

This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
2012-02-15 10:07:10 -06:00
Max Horn
658080deed ALL: Avoid using is* macros from ctype.h
On some systems, passing signed chars to macros like isspace() etc. lead
to a runtime error. Hence, mark these macros as forbidden by default,
and introduce otherwise equivalent alternatives for them.
2012-02-15 16:51:37 +01:00
Willem Jan Palenstijn
54ede63fcc BASS: Reduce code duplication in autosave code 2012-02-13 21:31:41 +01:00
Willem Jan Palenstijn
87e85e17cb BASS: Fix savegame corruption
When using the GMM or autosaves, _savedMouse and _savedCharSet were
never set. See bug #3487117.
2012-02-13 21:28:32 +01:00
Willem Jan Palenstijn
c7a5d31f05 BASS: Report savegame errors when saving by pressing enter
This makes error handling consistent between mouse and keyboard.
2012-02-13 21:21:42 +01:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion
9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Max Horn
84184aabc0 ALL: colour -> color 2011-04-14 14:12:35 +02:00
dhewg
d83a83ef50 JANITORIAL: Remove/comment unused vars
Found by GCC 4.6's -Wunused-but-set-variable
2011-03-29 21:57:56 +02:00
Max Horn
cac0ac66e2 COMMON: Get rid of Common::StringList
svn-id: r48287
2010-03-18 15:54:40 +00:00
Torbjörn Andersson
72eb9ec9ea Fixed a bunch of cppcheck warnings. Mostly about checking if a pointer is null
before freeing it, which isn't necessary.

svn-id: r46941
2010-01-03 19:37:43 +00:00
Max Horn
51933629d1 Changed foo(void) to foo() in almost all non-backend source files
svn-id: r45616
2009-11-02 21:54:57 +00:00
Max Horn
cbea1a1193 Added more GCC_PRINTF attributes, and fixed resulting warnings in format strings
svn-id: r42054
2009-07-03 10:40:49 +00:00
Torbjörn Andersson
0999534749 The error() and warning() functions add ! and newline automatically. (I didn't
look at debug() and debugC(), since I'm really bored with this now. :-)

svn-id: r41061
2009-05-31 10:02:16 +00:00
Johannes Schickel
b3c6751b9b Strip trailing whitespaces in the whole code base.
svn-id: r40867
2009-05-24 15:17:42 +00:00
Max Horn
65b5d31814 COMMON: Removed Stream::ioFailed() and clearIOFailed(), as they are deprecated; however, retained ioFailed in SeekableReadStream and File for now (so for now this mainly affects WriteStream subclasses)
svn-id: r40725
2009-05-19 11:42:14 +00:00
Joost Peters
0c681f85a4 cleanup
svn-id: r39147
2009-03-06 00:41:46 +00:00
Joost Peters
f051fbb9d8 Formatting changes / consistency
svn-id: r36304
2009-02-13 16:55:16 +00:00
Max Horn
716f88f571 Avoid using g_engine if possible
svn-id: r36149
2009-01-30 16:04:39 +00:00
Max Horn
9b160804ab Renamed Engine::quit to Engine::shouldQuit (previously, it was easily confused with Engine::quitGame); also cleaned up engine.h a bit
svn-id: r34700
2008-09-30 12:27:38 +00:00
Christopher Page
2d31207a81 Fixed some memory leaks
svn-id: r33846
2008-08-13 20:27:39 +00:00
Christopher Page
4198ee9623 Merged revisions 33188-33189,33191-33193,33196,33198,33202-33203,33206,33210,33212,33218-33220,33222,33224-33226,33229-33243,33246,33248-33250,33252,33258-33261,33263,33266,33270,33272-33283,33285,33287-33290,33295-33298,33321,33325-33330,33332-33335,33337-33340,33342,33345,33347,33349-33350,33352-33357,33359-33367,33369-33371,33373,33375-33377,33379-33380,33383-33385,33387-33389,33392-33394,33400-33402,33404-33405,33407-33410,33412-33416,33418-33419,33425-33427,33432,33436-33438,33444,33446,33452-33453,33455-33459,33463-33464,33466-33471,33473-33474,33478,33490,33492,33495-33496,33509-33512,33518-33519,33522-33527,33529-33530,33537,33541,33544,33546,33550,33552-33554,33556,33558,33561-33562,33565,33568,33570,33574,33576,33578-33581,33584-33587,33590,33596,33604-33611,33614-33615,33617-33618,33620-33621 via svnmerge from
https://scummvm.svn.sourceforge.net/svnroot/scummvm/scummvm/trunk
 

svn-id: r33624
2008-08-04 22:34:07 +00:00
Torbjörn Andersson
dcecff4829 Fixed bug that prevented upper-case letters from being used in savegame names.
Apparently, strchr(..., 0) will find the string terminator - at least for me -
and when that's added to the name, it will terminate the string.

svn-id: r33565
2008-08-03 09:41:10 +00:00
Christopher Page
a6e1d6bd3d SKY works with the new GMM implementation, also updated gui/newgui.cpp and prevented pushEvent from pushing more than one EVENT_QUIT into the artificialEventQueue
svn-id: r33041
2008-07-13 20:41:39 +00:00
Christopher Page
27c427add2 Scumm and sky now use the new _quit flag
svn-id: r32775
2008-06-25 03:17:01 +00:00
Max Horn
d31ca4982e Add support for --list-saves to the sky engine
svn-id: r30987
2008-02-27 16:07:38 +00:00