Eugene Sandulenko
940b2a20f1
Revert "COMMON: Change way the Singleton instances are instantiated"
...
This reverts commit eefa72afa1978a9dea10f5b1833fcc8f58a3468e.
With this patch ConfigManager is broken.
2017-07-10 21:17:41 +02:00
Thierry Crozat
eefa72afa1
COMMON: Change way the Singleton instances are instantiated
...
This fixes tons of warnings with clang from a recent xcode version on
macOS (and possibly other systems) complaining that an instantiation
of _singleton is required but no definition is available.
2017-07-10 21:11:20 +02:00
D G Turner
b779f20502
CLOUD: Fix GCC Unused Variable Warning.
...
This variable is not used as the constructors for the storage type
classes store the resulting objects into the Cloud Manager using
replaceStorage(this) instead.
2017-02-28 20:42:17 +00:00
D G Turner
df84aee6a3
CLOUD: Add FIXME comment.
...
This is generating a compiler warning for set-but-unused, but it looks
as if this is meant to be used in some way i.e. code is unfinished or
orphaned.
2017-01-10 05:19:13 +00:00
D G Turner
32809534fd
CLOUD: Fix Remaining Shadowing Compiler Warnings.
2017-01-10 05:15:56 +00:00
D G Turner
ace486cef4
CLOUD: Fix Various Shadowing Compiler Warnings from errorCallback.
2017-01-10 04:45:22 +00:00
Thierry Crozat
8906868ee0
CLOUD: Use OSDMessageQueue to post OSD messages from the cloud thread
2016-10-29 15:13:32 +01:00
Bastien Bouclet
c1070e6929
CLOUD: Don't error out when PNG support is not enabled
2016-10-20 19:21:56 +02:00
Bastien Bouclet
1a1a5b5f69
CLOUD: Change the cloud icon to be updated by the main thread
...
The cloud manager registers itself as an event source as a mean to be polled
periodically by the GUI or engine code. The periodical polling is used to
update the OSD icon indicating background sync activity.
Also move the cloud icon from ConnectionManager to CloudManager,
allowing to decouple icon handling from network connections updates.
2016-09-18 17:54:12 +02:00
Thierry Crozat
a87a702eb2
ALL: Homogeneize use of 'saved game' in messages
2016-09-18 16:40:34 +01:00
Thierry Crozat
973df9d2fd
CLOUD: Fix compilation for integer constant too large for 'long' type
...
Hopefully all ports we have support LL constants. Otherwise we will
have to find a different way to fix this.
2016-09-17 21:45:46 +01:00
Bastien Bouclet
4d68b93aba
CLOUD: Switch to the new OSD API
2016-09-13 20:29:09 +02:00
Eugene Sandulenko
fab199d37e
JANITORIAL: Make GPL headers uniform
2016-09-03 12:46:38 +02:00
Peter Bozsó
02a997e468
CLOUD: Remove unused includes
2016-08-24 16:07:55 +06:00
Eugene Sandulenko
0558ba423c
CLOUD: Fix warnings
2016-08-24 16:07:55 +06:00
Alexander Tkachev
37859a9203
CLOUD: Fix Requests
...
Remove unnecessary JSON warnings, fix a few places.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
bb529e6fd0
CLOUD: Update SavesSyncRequest
...
Add JSON checks in the callback.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
d5aca1f4fa
CLOUD: Update OneDriveUploadRequest
...
More JSON checks.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
fc8e29d583
CLOUD: Update OneDrive
...
Added JSON checks.
New jsonContainsObject() method added to CurlJsonRequest.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
d34b9b91ad
CLOUD: Update GoogleDriveUploadRequest
...
JSON checks in callback.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
a381e06fda
CLOUD: Update GoogleDriveStorage
...
More JSON checks in callbacks.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
b3aa9f663f
CLOUD: Update DropboxUploadRequest
...
JSON checks.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
364c74df93
CLOUD: Update DropboxStorage
...
JSON checks added.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
6be736b5ed
CLOUD: Update Dropbox Requests
...
Adding more JSON checks there.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
a2e0199727
CLOUD: Update BoxUploadRequest
...
More JSON checks there.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
166d1121e5
CLOUD: Update TokenRefreshers
...
Box's, Google Drive's and OneDrive's token refreshing requests have more
JSON checks now.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
9d96d40b3d
CLOUD: Add JSON-related checks in BoxStorage
2016-08-24 16:07:55 +06:00
Alexander Tkachev
0b97aff866
CLOUD: Minor TODO fix
2016-08-24 16:07:55 +06:00
Alexander Tkachev
6dd10f3a68
CLOUD: Add KEY/SECRET override code
...
The following constants must be defined if ENABLE_RELEASE is:
* RELEASE_DROPBOX_KEY,
* RELEASE_DROPBOX_SECRET,
* RELEASE_ONEDRIVE_KEY,
* RELEASE_ONEDRIVE_SECRET,
* RELEASE_GOOGLE_DRIVE_KEY,
* RELEASE_GOOGLE_DRIVE_SECRET,
* RELEASE_BOX_KEY,
* RELEASE_BOX_SECRET.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
15c6772ff7
ALL: Fix debug, warning and error usage
...
Added prefixes, used debug(9).
2016-08-24 16:07:55 +06:00
Alexander Tkachev
d57e0c89b5
CLOUD: #define all OAuth2/API-related URLs
2016-08-24 16:07:55 +06:00
Alexander Tkachev
f3959e1401
CLOUD: Upload ListDirectory Requests
...
Lots of checks to avoid JSON-related segfaults added.
2016-08-24 16:07:55 +06:00
Eugene Sandulenko
f95073f008
CLOUD: JANITORIAL: More whitespace fixes
2016-08-24 16:07:55 +06:00
Eugene Sandulenko
eb268cd14f
CLOUD: Fix warning
2016-08-24 16:07:55 +06:00
Eugene Sandulenko
d57fca4665
CLOUD: JANITORIAL: Fix code formatting
2016-08-24 16:07:55 +06:00
Alexander Tkachev
cccfe7c247
CLOUD: Update BoxListDirectoryByIdRequest
...
It now uses special CurlJsonRequest static methods to check whether JSON
is an object, has a string or integer parameter.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
43c940c985
CLOUD: Updated BoxListDirectoryByIdRequest
...
It now checks for all keys in JSON to avoid segfaults and prints
warnings if passed keys are missing or have wrong types.
2016-08-24 16:07:55 +06:00
Eugene Sandulenko
876b8616af
CLOUD: Fix format warning
2016-08-24 16:07:55 +06:00
Alexander Tkachev
758f46ddf0
CLOUD: Fix FolderDownloadRequest TODO
2016-08-24 16:07:55 +06:00
Alexander Tkachev
a30d0d1994
CLOUD: Update DownloadRequest's TODO
...
We need a way to reopen DumpFile if we want DownloadRequest to support
restarting.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
5f9beb76cd
CLOUD: Fix HTTP response code TODOs
2016-08-24 16:07:55 +06:00
Alexander Tkachev
bd8f2ed825
CLOUD: Fix some TODOs in CloudManager
...
"No Storage connected!" error message is passed to the error callback
now when there is no Storage connected to the CloudManager.
2016-08-24 16:07:55 +06:00
Peter Bozsó
8c62993769
CLOUD: Remove remove() from BoxStorage
2016-08-24 16:07:55 +06:00
Alexander Tkachev
efebb5b90d
CLOUD: Remove DropboxStorage::remove()
2016-08-24 16:07:55 +06:00
Peter Bozsó
9254df2d96
CLOUD: Fix code formatting
2016-08-24 16:07:55 +06:00
Alexander Tkachev
772d8ee42b
CLOUD: Fix redirect_uri
selection code
...
Now it's not hardcoded based on USE_SDL_NET, but one or another value is
used depending on currently selected LocalWebserver's port.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
438ba985a4
JANITORIAL: Remove spaces at the end of the line
...
I knew there were some, but I wanted to fix them once, instead of doing
it all the time.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
b180c73675
CLOUD: Do some refactoring/cleanup
...
Nothing really major.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
a449ddce15
CLOUD: Fix Cppcheck warnings
2016-08-24 16:07:55 +06:00
Alexander Tkachev
b1264df120
CLOUD: Check whether Storage is working when replacing it
...
We do that in CloudManager::replaceStorage(), but I've tried to
eliminate such possibility by adding a check in the StorageWizardDialog.
2016-08-24 16:07:55 +06:00