129006 Commits

Author SHA1 Message Date
athrxx
bd1dbecde9 TTS: (ENGINES) - add support for tts enable function
The new option only works as intended if the engine that have TTS support apply their own settings. It cannot be globally implemented before and after runGame(), since the engines don't all use the same config manager variables (sometimes "tts_enabled_speech", "tts_enabled" or "tts_narrator, sometimes more than one of these).
2022-04-26 21:08:41 +03:00
athrxx
eb29aea4b4 TTS: (Windows) - implement better way to disable the option
Currently, the text-to-speech manager will try to update the voices whenever TextToSpeechManager::pushState()/popState() is called. This causes lags of 4 - 5 seconds on Windows. Also, a warning is triggered each time. This commit prevents that from happening if the tts option is not enabled.

This commit currently affects only Windows. Other backends don't make use of the new _enabled setting. I don't know if it would make sense for any of these and I also wouldn't be able to test it.
2022-04-26 21:08:41 +03:00
athrxx
5cba8f9242 Revert "GUI: honor tts_enabled option in some more places"
This reverts commit 5969a2667a85b81a8b78b75fdf6d2d5364068155.
2022-04-26 21:08:41 +03:00
Torbjörn Andersson
ff1957196d SCUMM: Fix draft name in "drafts" debug command
It's "Straw Into Gold", not "Straw to Gold".
2022-04-26 18:04:15 +02:00
Torbjörn Andersson
f66d898dee SCUMM: Clean up Smirk close-up workarounds
I decided I prefer an empty if clause (which I find easier to read than
inverting the whole condition) than a premature break.
2022-04-26 14:45:30 +02:00
Torbjörn Andersson
f0e3cfd78d SCUMM: Fix regression from splitting Mac Indy3 into its own entry
I accidentally put the platform in the features field, telling the SCUMM
engine that this game used AKOS costumes. Oops!
2022-04-26 12:29:37 +02:00
Paul Gilbert
2d21a7dfde AGS: Removed couple of unused constants
From upstream 223fdb3d4ccfc0a6d0c437ac9fbb25a6095d3d42
2022-04-25 22:18:21 -07:00
Paul Gilbert
1ab42991d1 AGS: Added more event constants, clarified couple event calls
From upstream ae6862f7917832ebc5f2314561938c01725ac8a2
2022-04-25 22:11:42 -07:00
Paul Gilbert
22bcba88f5 AGS: Fixed RoomObject animation loosing parameters
From upstream a46cef76f8b268c26011965ee6ffcd5b97b7c8ab
2022-04-25 22:02:05 -07:00
Paul Gilbert
194dc7bafa AGS: Fixed game events not cleared inside blocking action
From upstream 6a71d858819787001ad50516acae7164537bb02f
2022-04-25 22:00:14 -07:00
Paul Gilbert
e60335a58a AGS: In log config fixed missing group letter id for "script"
From upstream 8d5bb8ad1cc6ef79e0c6b8c60ba0d48751bd659e
2022-04-25 21:58:49 -07:00
Paul Gilbert
741405aa3f AGS: Fixed potential use of uninitialized vars
From upstream 17235c31bad1df1cc23f46c7617023ab62e52e21
2022-04-25 21:57:01 -07:00
Paul Gilbert
85684cbae6 AGS: Fixed couple of "unreachable code" warnings
From upstream bb63e9c58c74f0bbcb78e208d33c5e365b743525
2022-04-25 21:53:56 -07:00
Paul Gilbert
357679d2a8 AGS: Fixing unimplemented cases in switches
From upstream f2bb0d055344197b6e4ed537c3107fe0c9784e50
2022-04-25 21:50:33 -07:00
Paul Gilbert
a6f42ad1ab AGS: Fixing various "unused va/arg" warnings + removed empty funcs
From upstream 61771ecd638338806c40d0da2bf1addea06cac90
2022-04-25 21:44:40 -07:00
Paul Gilbert
d0e8eba2c4 AGS: In DialogOptions changed index fields from char to int
From upstream 0db875df33a293797e176a0cbeefd60beeb92b14
2022-04-25 20:08:44 -07:00
Paul Gilbert
a633e9d72f AGS: Fixing various type-cast warnings
From upstream 6c42c7331e96386721f28c92ec3cb4cd039e10cd
2022-04-25 20:06:19 -07:00
Paul Gilbert
5b291a5ef0 AGS: Typecast warning fixes in data serialization
From upstream f781cb76a806f9ffcd9d29c51441eaab0136e598
2022-04-25 19:47:02 -07:00
Paul Gilbert
7b13f47d04 AGS: Fixing unimplemented cases in switches
From upstream 55345ca2b19598aeac2362d726fcaf15adf698fd
2022-04-25 19:37:00 -07:00
Paul Gilbert
f2399dc15c AGS: Fixing various "unused variable/arg" warnings
From upstream 4b3c27c1a2b39d6c6b089adee111c6889d19ad0e
2022-04-25 19:17:26 -07:00
Paul Gilbert
0be3602b44 AGS: In ScriptAudioClip changed index fields from char to unsigned
From upstream 012853058ecd3eb06abf51ad76f150d727dbad5e
2022-04-25 18:47:12 -07:00
Paul Gilbert
250190e997 AGS: Fixing various type-cast warnings
From upstream 82e89d3c3dccfa0aba0b18c1aa544130ac7e6902
2022-04-25 18:47:12 -07:00
Paul Gilbert
07e74fdd72 AGS: Typecast warning fixes in data serialization
From upstream efed621fda5adabac8937b8d0ca64e537fabdfeb
2022-04-25 18:47:08 -07:00
elasota
5cb75fdaec COMMON: Remove implicit bool conversion from WeakPtr 2022-04-25 18:20:19 -07:00
elasota
a1f2121bb8 COMMON: Remove empty BasePtrTrackerDeletionImpl destructor 2022-04-25 18:20:19 -07:00
elasota
2432c67426 COMMON: Fix double destruction when using a deleter. 2022-04-25 18:20:19 -07:00
elasota
22b72dba52 COMMON: Remove BasePtr base class from SharedPtr and WeakPtr. Fix missing refCount method in SharedPtr. 2022-04-25 18:20:19 -07:00
elasota
c8d0186752 COMMON: Fix WeakPtr missing copy constructor 2022-04-25 18:20:19 -07:00
elasota
be5a7cb8e7 COMMON: Fix up WeakPtr logic 2022-04-25 18:20:19 -07:00
elasota
bd23944fd1 COMMON: Fix SharedPtr natvis 2022-04-25 18:20:19 -07:00
elasota
9fa32ac47d COMMON: Fix WeakPtr preventing object deletion 2022-04-25 18:20:19 -07:00
Torbjörn Andersson
d0ac6fc453 SCUMM: Clean up DOTT Chron-O-John workaround a bit
With the last set of adjustments, it no longer seems necessary to check
which frame of the lid animation is being drawn. I count that as a win!
2022-04-25 09:51:51 +02:00
Torbjörn Andersson
a8b5d65fb8
SCUMM: Work around DOTT glitch when Bernard looks out of Chron-O-John
When Bernard turns his head inside the Chron-O-John during the DOTT
intro, part of the Chron-O-John is mirrored along with Bernard's face.
This is probably because the opening of the lid is part of the actor
animation.

This causes a visible glitch when Bernard is facing to the left side of
the screen. We fix that by always keeping the same mirroring for the
Chron-O-John and adjusting Bernard's head by a few pixels.
2022-04-25 10:16:18 +03:00
SupSuper
601d9dc7d4 CREATE_PROJECT: Warning flag -Wall already includes -Wimplicit 2022-04-25 06:59:13 +01:00
SupSuper
18ebbdcf99 CREATE_PROJECT: Don't add GCC warnings to MSVC CMake 2022-04-25 06:46:28 +01:00
SupSuper
d2ad40a7a1 CREATE_PROJECT: Fix missing prefix in CMake engines 2022-04-25 06:28:40 +01:00
D G Turner
a6a3b324bf AGS: Fix Signed vs. Unsigned Comparison GCC Compiler Warning 2022-04-25 01:30:15 +01:00
Paul Gilbert
78312259b7 AGS: Typecast warning fixes in (de)compression functions
From upstream ba8dae7788e764516d07511b00b36f904131b327
2022-04-24 16:00:06 -07:00
Paul Gilbert
67628b9c6a AGS: Suppress endless "unused param" warnings in script api
From upstream b4a5ec72c059bc3c65e89a45a8b1218068a2015a
2022-04-24 16:00:05 -07:00
Paul Gilbert
043f80a237 AGS: Avoid using global "game" in game_init because it's possible
From upstream 4041a18e7c1744aa59773da19de40b51bdc78a49
2022-04-24 16:00:05 -07:00
Paul Gilbert
608389c4c5 AGS: made SystemImports index an unsigned value
From upstream 30b8f4016c815f01b49398ddb697b454f1565218
2022-04-24 16:00:05 -07:00
Paul Gilbert
9533c0e028 AGS: Made script module index an unsigned value
From upstream bd4e65677eb0319ff746e519ee40016000a4f4f9
2022-04-24 16:00:04 -07:00
Paul Gilbert
14cffd13e7 AGS: Use String::NoIndex instead of -1 where necessary
From upstream 56275cb1f58f630082f3f51ab8e2c0ab5b021b16
2022-04-24 16:00:04 -07:00
Paul Gilbert
4cab476394 AGS: in String use constant NoIndex instead of nps
From upstream aca0285937f96002b76d61f4c1cc6f3a11242c2c
2022-04-24 16:00:04 -07:00
Paul Gilbert
8d261dd92f AGS: Corrected naimng style of RoomObject::NO_VIEW constant
From upstream ff544cda911ab036be44171a1b97b8a52e943758
2022-04-24 16:00:03 -07:00
Paul Gilbert
a1a0323d28 AGS: Removed few redundant function args
From upstream 4c80a7fb3afdfd8d7b82f16b7aeac5418565f608
2022-04-24 16:00:03 -07:00
Paul Gilbert
d83c6bb947 AGS: In route_finder fixed local vars overriding each other names
From upstream 02543b871783e88cb76418d6adad37ae3db10e89
2022-04-24 16:00:02 -07:00
Paul Gilbert
6b1c43f90b AGS: Do explicit type cast in FileReadRawChar and FileWriteRawChar
From upstream e3eb59bd4d72148a762ac93d0df36a56e101f257
2022-04-24 16:00:02 -07:00
Paul Gilbert
f27e782b23 AGS: Use constant to setup "no view" in RoomObjects instead of -1
From upstream a1f74944a7e3c058deb8b12680c5b9aba19dee5a
2022-04-24 16:00:01 -07:00
athrxx
b63bc6bfd6 SCUMM: (ZAK/FM-TOWNS) - fix bug no. 13399
(Counter door remains in closed status even though the Caponian just opened it)
2022-04-24 23:39:09 +02:00