29697 Commits

Author SHA1 Message Date
Strangerke
cbf85da3f3 HOPKINS: Simplify code in checkSounds() 2013-04-19 08:10:30 +02:00
Strangerke
398b4353a6 HOPKINS: Remove dead code and out of bound access in SoundManager 2013-04-19 08:05:29 +02:00
Strangerke
6de13b475e HOPKINS: Fix missing break in ScriptManager. CID 1003759 2013-04-19 00:51:00 +02:00
Alyssa Milburn
02d81911cd MOHAWK: Add LB function name aliases. 2013-04-19 00:48:41 +02:00
Strangerke
16259a52e3 HOPKINS: Remove dead code in ScriptManager 2013-04-19 00:46:49 +02:00
Alyssa Milburn
aa140c4982 MOHAWK: Fix bug in View::setModule (thanks ST). 2013-04-19 00:46:11 +02:00
Alyssa Milburn
ba9efd5c40 MOHAWK: Allow skipping LB videos, plus other video bits. 2013-04-19 00:42:28 +02:00
Alyssa Milburn
73d6294619 MOHAWK: Some LB bytecode improvements. 2013-04-19 00:36:45 +02:00
Alyssa Milburn
541a0b8c69 MOHAWK: Implement LB's kTokenEval. 2013-04-19 00:32:49 +02:00
Alyssa Milburn
aa1fe8a161 MOHAWK: Implement kLBXDataFileAddSection/SetKey. 2013-04-19 00:25:18 +02:00
Strangerke
d7a4a12b67 HUGO: Initialize variables in Hugo engine constructor. CID 1002886 2013-04-19 00:21:37 +02:00
Strangerke
caa04fb8bf JANITORIAL: Add a CRLF at the end of the file to fix compilation using MSVC (complete previous commit) 2013-04-19 00:02:51 +02:00
Strangerke
69dd65aa93 JANITORIAL: Add a CRLF at the end of the file to fix compilation using MSVC 2013-04-19 00:00:25 +02:00
Max Horn
34aaac0a1e AGI: Silence another clang var
Reading an array without using the resulting value has no effect.
In any case, this code still looks like it may be broken, so somebody
who knows more about AGI should perhaps investigate this closer.
2013-04-18 23:50:21 +02:00
Max Horn
2a10f6a97f WINTERMUTE: Do not us char literals to index an array
This silences a clang warning
2013-04-18 23:50:20 +02:00
Max Horn
055b86ea18 HOPKINS: Replace non-ASCII characters by octal string literals
This silences a clang warning. It seems like a good idea, too: non-ASCII
chars in string constants are prone to break as a result of (possibly
unintentional) encoding conversions (which one can configure git to
perform).
2013-04-18 23:50:20 +02:00
Max Horn
51bde6ced5 SCI: Remove a bunch of unused private member variables
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Max Horn
b791edabf7 ENGINES: Remove a bunch of unused private member variables
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Max Horn
cdfd5f85c8 ENGINES: Silence clang warning about unused private member _vm
This affects the Console / debugger classes of multiple engines.
An alternative solution would have been to remove the unused _vm
member vars. However, it seems likely that in the future, the _vm
member could be useful for methods added to the console. So instead,
we add a simple assert(_vm) to silence the clang warning.
2013-04-18 23:50:19 +02:00
Max Horn
4fb289e346 AGI: Get rid of unused SoundMgr parameters 2013-04-18 23:50:19 +02:00
athrxx
78ba3210a5 KYRA: (LOL) - fix bug in last commit for scene_lol.cpp 2013-04-18 22:15:25 +02:00
Einar Johan Trøan Sømåen
6c55213cd5 WINTERMUTE: Add 'override' to most Script-related functions. 2013-04-18 18:04:51 +02:00
Einar Johan Trøan Sømåen
b6242d0ea5 WINTERMUTE: Use int32 instead of int in classes. 2013-04-18 17:45:50 +02:00
Max Horn
4a55f52818 SWORD25: Silence warning in the Lua code
This fixes warnings like this that crop up when compiling sword25
with Apple clang 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
2013-04-18 17:09:32 +02:00
athrxx
2b8cb1c1f0 KYRA: (EOB) - silence warning about improper use of negative value in gui_eob.cpp 2013-04-18 16:10:55 +02:00
athrxx
2f6d47059b KYRA: (EOB) - fix possible null ptr dereference in gui_eob.cpp 2013-04-18 16:10:54 +02:00
athrxx
b04059cd23 KYRA: (LOL) - add comment in gui_lol.cpp 2013-04-18 16:10:52 +02:00
athrxx
3d91f3239e KYRA: (LOL) - add assert in items_lol.cpp (should silence warning about possible out of bounds access) 2013-04-18 16:10:51 +02:00
athrxx
3ac156422e KYRA: (LOL) - fix warning about possible out of bounds access in lol.cpp 2013-04-18 16:10:49 +02:00
athrxx
2bdfa47ec0 KYRA: (EOB) - remove unused variable in scene_eob.cpp 2013-04-18 16:10:48 +02:00
athrxx
9b74a7bd65 KYRA: (LOL) - fix possible null ptr dereference in scene_lol.cpp 2013-04-18 16:10:46 +02:00
athrxx
d2d2ed1303 KYRA: (EOB) - remove dead code in screen_eob.cpp 2013-04-18 16:10:45 +02:00
athrxx
5ed0770401 KYRA: (HOF) - fix possible null ptr dereference in sequences_hof.cpp 2013-04-18 16:10:43 +02:00
athrxx
06962db454 KYRA: (HOF) - fix possible out of bounds array access 2013-04-18 16:10:42 +02:00
athrxx
d3419f6a31 KYRA: (EOB) - add assert in sprites_eob.cpp (might fix warning about possible null ptr deref) 2013-04-18 16:10:40 +02:00
athrxx
0a623ecdec KYRA: (EOB) - fix potential null ptr dereference in sprites_eob.cpp 2013-04-18 16:10:39 +02:00
athrxx
2c973a6bff KYRA: (EOB) - fix warning (Logically dead code) in sprites_eob.cpp 2013-04-18 16:10:38 +02:00
athrxx
4021a04269 KYRA: (LOL) - fix warning (Unused pointer value) in sprites_lol.cpp 2013-04-18 16:10:36 +02:00
athrxx
9fdc70de36 KYRA: (LOL) - add comment in sprites_lol.cpp 2013-04-18 16:10:35 +02:00
athrxx
3e9f4943d2 KYRA: (EOB) - add comment in timer_eob.cpp 2013-04-18 16:10:33 +02:00
Willem Jan Palenstijn
e4a9717434 AGI: Fix typo in issetv opcode
This fixes bug #3611262
2013-04-18 14:53:34 +02:00
Einar Johan Trøan Sømåen
a00c372f9e WINTERMUTE: Get Renderer from BaseEngine, not BaseGame in BaseClasses. 2013-04-18 12:31:27 +02:00
Einar Johan Trøan Sømåen
8bcaf3e06c WINTERMUTE: Use BaseEngine for Logging, not _gameRef in base-classes. 2013-04-18 12:24:42 +02:00
Einar Johan Trøan Sømåen
a4f7763579 WINTERMUTE: Avoid including BaseGame in PartEmitter. 2013-04-18 12:17:58 +02:00
Einar Johan Trøan Sømåen
e5b2107704 WINTERMUTE: Avoid including BaseGame in BaseSoundManager. 2013-04-18 12:15:05 +02:00
Einar Johan Trøan Sømåen
32ace5f9d2 WINTERMUTE: Avoid including BaseGame in BaseFader. 2013-04-18 12:13:12 +02:00
Einar Johan Trøan Sømåen
8f25b651e8 WINTERMUTE: Split the timers from BaseGame into a separate class. 2013-04-18 12:10:40 +02:00
Einar Johan Trøan Sømåen
7ee757366b WINTERMUTE: Avoid including BaseGame in BaseViewport. 2013-04-18 11:19:26 +02:00
Einar Johan Trøan Sømåen
a8f4f20f38 WINTERMUTE: Avoid including BaseGame in BaseFrame. 2013-04-18 11:13:32 +02:00
Einar Johan Trøan Sømåen
4783d643f6 WINTERMUTE: Constify AdRotLevel 2013-04-18 10:13:02 +02:00