12 Commits

Author SHA1 Message Date
Adrian Frühwirth
00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Eugene Sandulenko
87eef75a26 MACVENTURE: Provide copyright notice for WebVenture by Sean Kasun, and fix GPL headers 2016-09-03 11:16:02 +02:00
Borja Lorente
b7b258474f MACVENTURE: Add creation date and playtime to savegames 2016-08-21 16:42:19 +02:00
Borja Lorente
0d868742d4 MACVENTURE: Add thumbnail to savegames 2016-08-21 16:19:55 +02:00
Borja Lorente
1210f05842 MACVENTURE: Fix upper limit in savefile names 2016-08-21 13:19:08 +02:00
Borja Lorente
19c7bcf9d4 MACVENTURE: Fix formatting 2016-08-19 16:30:24 +02:00
Borja Lorente
b1eb6da6fa MACVENTURE: Add prefixes to error messages 2016-08-19 16:30:23 +02:00
Borja Lorente
cb4650247f MACVENTURE: Fix segfault when saving 2016-08-14 19:01:00 +02:00
Borja Lorente
f0dde375c1 MACVENTURE: Add missing methods for runtime load 2016-08-14 19:00:37 +02:00
Borja Lorente
0acdf0c459 MACVENTURE: Implement savefile deletion 2016-08-14 19:00:37 +02:00
Borja Lorente
9ab6ce04a1 MACVENTURE: Change GUI to accept ScummVM dialogs 2016-08-14 19:00:36 +02:00
Borja Lorente
b7b4862e4c MACVENTURE: Add metadata to savegames 2016-08-14 19:00:36 +02:00