1373 Commits

Author SHA1 Message Date
Eugene Sandulenko
8484b4b148 PARALLACTION: Make sure overridden methods are not used. Fixes compiler warning 2013-11-03 12:20:40 +02:00
Eugene Sandulenko
18b7c5fd9c PARALLACTION: Pass big value by reference rather than copying. CID 1003923 2013-11-03 12:20:39 +02:00
Eugene Sandulenko
a7055e75d1 PARALLACTION: Comment out unused assignment. CID 1002508 2013-10-08 00:11:18 +03:00
Johannes Schickel
378387c903 I18N: Move specification of engine specific files to enginedir/POTFILES.
This allows to keep the engines to specfiy the files for translation close to
the engine sources itself.

Thanks to criezy for his suggestion on this approach.
2013-08-12 17:54:31 +02:00
Johannes Schickel
d06cbe9043 PARALLACTION: Do not set Surface::pixels directly anymore. 2013-08-03 04:14:08 +02:00
Johannes Schickel
ccaf4d865c PARALLACTION: Take advantage of Surface::getPixels. 2013-08-03 04:02:51 +02:00
Johannes Schickel
d82741a3c8 PARALLACTION: Prefer getBasePtr over direct Surface::pixels access. 2013-08-03 02:52:33 +02:00
Matthew Hoops
0031c41db8 COMMON: Change kPlatformPC to kPlatformDOS
"PC" was very ambiguous and now it matches what we show in the GUI.

This also corrects sword2's platform to Windows.
2013-05-02 18:43:10 -04:00
Max Horn
b791edabf7 ENGINES: Remove a bunch of unused private member variables
All instances uncovered by clang warnings.
2013-04-18 23:50:20 +02:00
Alyssa Milburn
1dc58b0b2a PARALLACTION: Fix BRA amiga inventory item cursors. 2013-04-17 23:20:55 +02:00
Alyssa Milburn
1eefd6301b PARALLACTION: Don't use an invalid array index. 2013-04-17 23:20:31 +02:00
Alyssa Milburn
c9ccba01df PARALLACTION: Add some sanity checks to SoundMan_br::execute. 2013-04-17 23:20:13 +02:00
Alyssa Milburn
a514927381 PARALLACTION: Fix buffer size in unpackBackground. 2013-04-17 23:19:47 +02:00
Alyssa Milburn
98934898cf PARALLACTION: Use strlcpy instead of strncpy. 2013-04-17 23:17:22 +02:00
Willem Jan Palenstijn
e7b38a7c2a PARALLACTION: Cleanup 2013-04-15 20:35:43 +02:00
Johannes Schickel
98cfb57dd3 PARALLACTION: Fix a const cast warning. 2013-01-06 20:34:26 +01:00
Tomas Jakobsson
548b505b68 PARALLACTION: Update to new IFFDecoder for ILBM images 2013-01-06 20:04:45 +01:00
D G Turner
8bf5a61278 PARALLACTION: Mask unused, but set variable warning, by debug().
This variable is likely to be used in the future if the associated
TODO is implemented, so this warning is inhibited by adding a debug()
output statement.
2012-11-19 23:33:02 +00:00
Filippos Karapetis
a297ae6195 PARALLACTION: Add a workaround for the end credits of NS
The game scripts try to show a non-existing frame. We set it to an existing one
here. Part of the fixes for bug #5866
2012-09-28 01:49:37 +03:00
Filippos Karapetis
17b42b5570 PARALLACTION: Add a workaround for the end credits of NS
The end credits reference a version of Dino called "Dinor", which makes the
engine look for a non-existing file. We set the name to "dino", as it should be
in this case, so that the engine loads the correct file. Part of the fixes for
bug #5866
2012-09-28 01:47:38 +03:00
Filippos Karapetis
a1969ae268 PARALLACTION: Add a missing return statement
The final credits screen has no background, it just reuses the background of the
final scene. Part of the fixes for bug #5866
2012-09-28 01:44:06 +03:00
Filippos Karapetis
864b4acdf1 PARALLACTION: Fix a script bug in the end of the multilingual DOS version of NS
The mouse cursor is incorrectly hidden outside the final cave in NS because of
a script bug. A workaround is added to fix that screen and the final screen in
order to make it playable. Part of fixes for bug #5866
2012-09-28 01:40:43 +03:00
Alyssa Milburn
41d337c549 PARALLACTION: Clean up global variables a bit. 2012-09-27 22:41:51 +02:00
Alyssa Milburn
d7b74ed5b1 PARALLACTION: Remove unused function. 2012-09-27 22:33:04 +02:00
Alyssa Milburn
a081ae78ee PARALLACTION: Add custom Adlib driver for BRA.
Thanks to peres for working out how it works in the original engine.
Also, fix the length of MIDI events so it works properly.
2012-09-22 13:20:58 +02:00
Alyssa Milburn
f08978a075 JANITORIAL: Remove underscores from MidiParser variable names. 2012-09-07 23:04:34 +02:00
Johannes Schickel
d98b462190 PARALLACTION: Fix delete[] formatting. 2012-07-25 21:10:43 +02:00
Johannes Schickel
7c5cf1b400 GUI: Add helper to SaveLoadChooser, which uses the currently active target.
This reduces the code duplication in all client code, which formerly duplicated
the querying of the plugin, game id etc. and now simply calls the newly added
method runModalWithCurrentTarget() on a SaveLoadChooser object.
2012-06-10 04:53:17 +02:00
Johannes Schickel
9b05f4e103 PARALLACTION: Do not call close on a SaveLoadChooser. 2012-06-10 04:19:57 +02:00
Johannes Schickel
15046a7529 GUI: Get rid of SaveLoadChooser::setSaveMode.
We already pass the title and process button name to the constructor of
SaveLoadChooser and then do not offer any way of changing it, thus changing
the edit mode of the chooser is kind of pointless and was never actually used.
Instead we pass the mode on SaveLoadChooser construction now.
2012-06-10 04:19:45 +02:00
Joel Teichroeb
1d0904197f PARALLACTION: Fix spelling of length 2012-04-04 21:23:00 -07:00
Christoph Mallon
d21cef4117 JANITORIAL: Avoid the ugly operator invocation syntax. 2012-03-13 15:43:23 +01:00
Willem Jan Palenstijn
9ffe3e11d9 Merge pull request #182 from fingolfin/forbid-ctype
ALL: Avoid using is* macros from ctype.h
2012-02-21 11:33:32 -08:00
Max Horn
4f8665fc83 COMMON: Move isFoo functions to namespace Common, add doxygen comments 2012-02-20 16:18:27 +01:00
Tarek Soliman
a4798602d7 JANITORIAL: Fix missing whitespace in pointer cast
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'

This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
2012-02-15 10:07:10 -06:00
Tarek Soliman
921f602ab8 JANITORIAL: Fix whitespace in pointer template arg 2012-02-15 10:07:08 -06:00
Max Horn
658080deed ALL: Avoid using is* macros from ctype.h
On some systems, passing signed chars to macros like isspace() etc. lead
to a runtime error. Hence, mark these macros as forbidden by default,
and introduce otherwise equivalent alternatives for them.
2012-02-15 16:51:37 +01:00
Tarek Soliman
edc5249772 JANITORIAL: Fix template definition whitespace 2012-02-10 21:17:27 -06:00
Andrea Corna
a6ec4f70da COMMON: Make more members of Archive constant. 2011-12-13 17:55:57 +01:00
Johannes Schickel
3ad89a0d18 PARALLACTION: Fix memset size parameter. 2011-11-03 02:26:45 +01:00
Eugene Sandulenko
e1a311a236 PARALLACTION: Fix warnings. Fix nasty out-of-scope bug in parallaction_br.cpp 2011-11-03 00:48:14 +00:00
Eugene Sandulenko
32972a5ffb AD: Switched rest of the engines to new GUIO 2011-10-23 17:53:13 +01:00
Filippos Karapetis
2883ebc40e PARALLACTION: Fixed bugs #2880939 and #3135868
A regression from commit 774773b. Many thanks to digitall for bisecting
2011-10-01 01:10:30 +03:00
Filippos Karapetis
0c468901e1 PARALLACTION: Code formatting (and trying to keep clone2727 happy! :P ) 2011-09-29 02:17:11 +03:00
Filippos Karapetis
57177e98aa PARALLACTION: Fixed bug #2969915 - "NIPPON: Disguise changing back and forth"
A regression from commit 18b48c7. The name of the normal Donna actor is
"donna", whereas it's "donnatras" for the disguised one, so strstr()
seems to be wrong here. This fixes the bug and it shouldn't cause any
further regressions. Also, changed the relevant code to conform to our
code convention guidelines - it's quite a bad idea to not enclose a
whole big code block in brackets, as it becomes hard to read.
2011-09-29 02:00:31 +03:00
Filippos Karapetis
a9214ac7a2 PARALLACTION: Updated the fix for script bug #2969913 to a workaround 2011-09-28 15:34:58 +03:00
Filippos Karapetis
7aad29572d PARALLACTION: Fixed bug #2969913 - "NIPPON: Katana graphics not shown (regression)" 2011-09-28 14:10:52 +03:00
D G Turner
0d3c6fddae PARALLACTION: Add Graphics Debug Output. Minor Whitespace Fixes.
This adds debug output for graphics object access to help with
investigation of bug #2969913 i.e. "NIPPON: Katana graphics not shown
(regression)" as well as cleanup of whitespace in this class.
2011-09-02 06:14:20 +01:00
D G Turner
d13a9270a7 PARALLACTION: Correct Previous Commit to Coding Conventions. 2011-08-24 01:42:19 +01:00
D G Turner
5a0680af52 PARALLACTION: Improve safety of PathBuffer Accesses in Pathfinding. 2011-08-24 00:58:05 +01:00