1326 Commits

Author SHA1 Message Date
D G Turner
076514da3f HDB: Improve String Buffer Usage in AI Inventory Code 2019-09-14 02:47:55 +01:00
D G Turner
8fe7f80d0c HDB: Replace Unecessary Buffer in AI Inventory Code 2019-09-14 02:38:53 +01:00
D G Turner
64e2a21a17 HDB: Avoid String Buffer Overruns from Save Load Code 2019-09-14 02:27:06 +01:00
D G Turner
817bcc4c24 HDB: Remove Fixed String Buffer Usage in Window Code 2019-09-14 02:12:13 +01:00
D G Turner
7064698b60 HDB: Removed Fixed String Buffer from AI Player Code
This is replaced by simpler Common::String equivalent.
2019-09-14 02:01:57 +01:00
D G Turner
0d498a2036 HDB: Remove More Fixed Sized String Buffers in Menu Code 2019-09-14 01:43:09 +01:00
D G Turner
04d522121b HDB: Remove Fixed Sized String Buffers in Menu Code
These are replaced by Common::String usage.
2019-09-14 01:22:25 +01:00
D G Turner
117733ad0a HDB: Fix More GCC Compiler Warnings 2019-09-14 00:07:47 +01:00
D G Turner
c0d6a8fc7a HDB: Further Fixes for GCC Compiler Warnings 2019-09-13 23:06:32 +01:00
D G Turner
c01598484e HDB: Fix Some GCC Compiler Warnings
These were of the type memset of a complex structure.
2019-09-13 22:41:41 +01:00
D G Turner
b940fb7588 HDB: Fix Major Memory Leak in File Manager Class 2019-09-13 21:50:55 +01:00
D G Turner
df940b17af HDB: Close Memory Leaks in Sound Class 2019-09-13 21:20:19 +01:00
D G Turner
6f265805ec HDB: Ensure Demos are Indicated in ScummVM GUI Launcher List 2019-09-13 20:33:55 +01:00
D G Turner
ec677b3fe9 HDB: Fix Crash on Invalid Sound String Pointers
This was causing a crash with buffer overflow on Windows builds, but
diagnosing with Valgrind showed invalid strings being accessed in the
sound code. Some analysis showed that these were mainly the reference
to c_str() buffers from a local heap Common::String which was out of
scope and thus destructed, giving an invalid pointer.

The fix here also simplifies the code as well as avoiding this issue.
2019-09-13 20:14:22 +01:00
sluicebox
76ddbe7bd9 HDB: Fix empty string test 2019-09-10 16:20:19 -07:00
Strangerke
299c28e93e HDB: Remove useless check on array vs null 2019-09-09 23:22:22 +02:00
Strangerke
5e0fa2a71c HDB: Fix more uninitialized variables in Gfx and Window 2019-09-09 23:16:26 +02:00
Strangerke
0e04da2cc8 HDB: Fix more uninitialized variables in ai-init 2019-09-09 22:47:27 +02:00
Strangerke
9de42a143a HDB: Fix a pointer to local variable outside of scope 2019-09-09 22:30:17 +02:00
Strangerke
590285a890 HDB: Reduce the scope of some more variables 2019-09-08 22:15:50 +02:00
Strangerke
feafd2a956 HDB: Remove unused static in setButtons 2019-09-08 22:15:15 +02:00
Bastien Bouclet
997e15878a HDB: Fix out of bounds read in HDBGame::setInMapName 2019-09-08 19:55:23 +02:00
Strangerke
b1db45b718 HDB: Remove useless returns 2019-09-07 22:49:07 +02:00
Strangerke
d99ba0a126 HDB: Fix some array compared to nullptr, reduce some variable scopes 2019-09-07 19:47:36 +02:00
Strangerke
49fe42cc33 HDB: Remove useless existence checks on entityName 2019-09-07 01:25:32 +02:00
Strangerke
db58be617b HDB: Replace some unsafe strcpy by strncpy 2019-09-07 00:40:01 +02:00
Strangerke
220ef998bb HDB: Fix song 2 fading volume 2019-09-07 00:19:24 +02:00
Strangerke
82c47d75cd HDB: Fix the check for no free sound handle 2019-09-06 22:28:37 +02:00
Strangerke
555cd7d33e HDB: Fix potential out of bound 2019-09-06 22:25:33 +02:00
Strangerke
cf001b1116 HDB: Turn _voicesOn into a boolean 2019-09-06 22:14:12 +02:00
Strangerke
44de7e8d5e HDB: Fix uninitialized variables in gfx 2019-09-06 22:08:12 +02:00
Strangerke
bfb1d6d059 HDB: Remove unused variables in menu 2019-09-06 21:51:55 +02:00
Strangerke
caa870bc25 HDB: Fix uninitialized variables in ai_init and menu 2019-09-06 21:46:21 +02:00
Strangerke
1c8a7800da HDB: More missing initializations 2019-09-06 08:16:04 +02:00
Strangerke
5b01ca8694 HDB: Reduce the scope of some variables 2019-09-06 08:16:04 +02:00
Strangerke
d1b9e1db7a HDB: Initialize some more uninitialized variables. 2019-09-06 08:16:04 +02:00
Strangerke
a9be9c1453 HDB: Small loop changes in sound 2019-09-06 00:44:54 +02:00
Strangerke
27e852e17a HDB: Simplify some code by using CLIP() 2019-09-06 00:44:01 +02:00
Strangerke
9ed4c340a2 HDB: Fix uninitialized variable in sound 2019-09-06 00:32:39 +02:00
Eugene Sandulenko
5224112ea5 HDB: Build engine by default 2019-09-06 00:00:40 +02:00
Strangerke
9bb66c7059 HDB: Fix some unintended sign extensions 2019-09-05 21:13:20 +02:00
D G Turner
d74724eee0 HDB: Fix GCC Compiler Warnings for Set-But-Unused Variables 2019-09-05 18:10:31 +01:00
D G Turner
541689eeb2 HDB: Add Missing Initializer in Sound Class
This fixes CID 1404916.
2019-09-05 08:47:02 +01:00
Eugene Sandulenko
6905c54b1e HDB: Set engine to testing 2019-09-04 23:35:01 +02:00
D G Turner
cb88db65cd HDB: Fix Some GCC Compiler Warnings 2019-09-04 19:47:15 +01:00
Eugene Sandulenko
a7e30d0e7f HDB: Fix compilation on Amiga 2019-09-03 21:08:13 +02:00
Eugene Sandulenko
100ea9ff0e HDB: Fix warnings 2019-09-03 17:17:35 +02:00
Eugene Sandulenko
373002d303 HDB: Added debug output for map loading 2019-09-03 17:17:35 +02:00
Eugene Sandulenko
abbe16bf01 HDB: Do not write config on every launch 2019-09-03 17:17:35 +02:00
Eugene Sandulenko
32969d3d7e HDB: Fix monkeystone star triggers 2019-09-03 17:17:35 +02:00