19749 Commits

Author SHA1 Message Date
David Turner
f96c8f6e39 CINE: Fix CollisionPage Uninitialised Reads in Operation Stealth.
The collisionPage is only initialised with values when loadCtFw() / loadCtOS() is called.
However, currently during the display of the Delphine Software Logo in Operation Stealth,
checkCollision() is called, but the collisionPage has not been loaded.
To fix the invalid reads, have added code to set the page to zero after allocation.
Shouldn't cause any issues to FW as this will load over the top anyway.

Have also added debug output around this behaviour so that if this is not sufficient i.e. a collision page load is actually missing, then this will aid investigation.

svn-id: r55071
2010-12-31 09:14:49 +00:00
David Turner
c9330fb79e CINE: Close Memory Leak in PCSoundFxPlayer.
This leakage was reported by Valgrind while playing Operation Stealth.

svn-id: r55070
2010-12-31 09:07:44 +00:00
Arnaud Boutonné
542f946155 HUGO: Fix default values in object_t structure for viewx field and followings.
This fixes some other bugs reported by D. Gray

svn-id: r55068
2010-12-30 22:07:12 +00:00
Arnaud Boutonné
1dd3142330 HUGO: Fix several bugs reported by D. Gray
svn-id: r55067
2010-12-30 21:07:38 +00:00
Bastien Bouclet
14cd97cc77 MOHAWK: Implement Myst opcodes 129 to 132, and 192 to 197, Stellar observatory buttons
svn-id: r55065
2010-12-30 13:53:14 +00:00
Bastien Bouclet
6c9a4d36ec MOHAWK: Implement Myst opcode 214, Stellar observatory initialization
svn-id: r55063
2010-12-29 19:33:49 +00:00
David Turner
7bc8fe8ef5 CINE: Fix Memory Leak in PCSoundFxPlayer.
Found this using Valgrind when loading a Future Wars savegame from the launcher.
Occurs since the load() method called stop() but this did not unload() the allocated playing
resource data unless it was still playing. Fixed in stop() by calling unload() in all cases.

svn-id: r55059
2010-12-29 09:53:58 +00:00
David Turner
fef667cbe9 CINE: Fixed mismatched deallocation in ScriptVars reported by Valgrind.
svn-id: r55058
2010-12-29 09:50:48 +00:00
Arnaud Boutonné
4a94eba80a TOON: Add mapping for upper 'ç' and for plenking, both used in french version
svn-id: r55057
2010-12-28 21:19:31 +00:00
Filippos Karapetis
7bc1ff065b SCI: Fixed script bug #3038870 - "SCI Fanmade - Demo Quest: ScummVM hangs with typo" and
removed a related FIXME

svn-id: r55056
2010-12-28 21:05:30 +00:00
Sylvain Dupont
ab01c8e5fc TOON: Fixed memory corruption in several rooms
Some mask line drawings were writing outside the buffer.

svn-id: r55055
2010-12-28 13:13:55 +00:00
Sylvain Dupont
bccf4606c9 TOON: Removed useless confusing code in conversation process part
svn-id: r55054
2010-12-28 13:11:17 +00:00
Travis Howell
ccb8a01b17 SCUMM: Correct fix for bug #3145951 - DIG: Subtitles won't turn off (regression).
svn-id: r55053
2010-12-28 06:05:57 +00:00
Travis Howell
cfbac503ad SCUMM: Another fix for bug #3145951 - DIG: Subtitles won't turn off (regression).
svn-id: r55052
2010-12-28 05:43:03 +00:00
Sylvain Dupont
1b8678d5de TOON: Path finding bug fixes
Allows Flux to walk close to Drew if really needed to prevent total path block.
Prevents path finding if the character is out of the screen

svn-id: r55051
2010-12-27 21:56:52 +00:00
Travis Howell
fe12e08dd6 SCUMM: Fix bug #3145951 - DIG: Subtitles won't turn off (regression).
svn-id: r55050
2010-12-27 14:07:53 +00:00
Travis Howell
e7e92a7577 SCUMM: Fix bug #3143039 - ACTIVITY: Circus Stormin' crash.
svn-id: r55049
2010-12-27 14:02:17 +00:00
Sylvain Dupont
f9409fc7d5 TOON: Fixed Bug #3124527 with Dungeon freeze
Bug #3089974: "TOON: Game freezes in act 2 when thrown to the prison"

Wrong pointer increment in conversation process code.

svn-id: r55047
2010-12-26 20:14:04 +00:00
Filippos Karapetis
1528a3d904 SCI: A more efficient solution for bug #3037874 (SCI high CPU usage), which will hopefully
not clash with the speed throttler. This is a more proper fix for bug #3058865, and a
partial fix for bug #3127824

svn-id: r55046
2010-12-26 15:28:02 +00:00
Matthew Hoops
f2495a42f6 MOHAWK: Move myst_saveload.* to myst_state.*
svn-id: r55045
2010-12-26 15:10:33 +00:00
Matthew Hoops
918c4febb0 MOHAWK: Fix a typo
svn-id: r55044
2010-12-26 14:58:15 +00:00
Matthew Hoops
1bbe49dba9 SCI: Silence a gcc warning
svn-id: r55043
2010-12-26 14:56:51 +00:00
Sylvain Dupont
63e58baae1 TOON: Fix problem when exiting the king cave
svn-id: r55042
2010-12-26 14:32:38 +00:00
Bastien Bouclet
6cd890aaac MOHAWK: Merge classes MystVariables and MystSaveLoad to form MystGameState
svn-id: r55041
2010-12-26 14:31:03 +00:00
David Turner
98783a15e8 HUGO: Fix MIDI Player Memory Leak in H3 Win.
svn-id: r55040
2010-12-26 13:58:39 +00:00
Florian Kagerer
8347b44fb2 KYRA FM-TOWNS: improved cd audio music fading
svn-id: r55039
2010-12-25 22:10:51 +00:00
Alyssa Milburn
64a8652cd6 MOHAWK: Add subimage drawing/caching code
svn-id: r55038
2010-12-25 19:52:54 +00:00
Alyssa Milburn
1897e5e132 MOHAWK: detect the European versions of Zoombinis
svn-id: r55037
2010-12-25 19:52:24 +00:00
Alyssa Milburn
4c0b02fe21 MOHAWK: LB CD-ROM title prefixes aren't Windows-specific
svn-id: r55036
2010-12-25 18:45:48 +00:00
Alyssa Milburn
85da9de3bf MOHAWK: detect/load the Rugrats Adventure Game
svn-id: r55035
2010-12-25 18:45:29 +00:00
Filippos Karapetis
bc9442d6d8 SCI: Fixed bug #3059860 - "LB2CD: Glitch in Act 6 coroner answer buttons"
svn-id: r55034
2010-12-24 15:53:06 +00:00
Filippos Karapetis
5e5410f891 SCI: Only sync the synonyms vocabulary if the game actually has one (thanks wjp)
svn-id: r55033
2010-12-24 14:56:04 +00:00
Filippos Karapetis
9af30a2546 SCI: Now saving/loading the list of synonyms (set by kSetSynonyms), like SSCI did
This is a more correct way of fixing bug #3037618 than in rev #55017.
- Changed replaceant/replacement to be uint16's (they're very small positive
values, usually smaller than 4096)
- Changed SynonymList to an Array (so that it can be saved/loaded)
- Removed the PQ2 script patch to Game::replay()
- Added savegame history

svn-id: r55032
2010-12-24 14:47:47 +00:00
Bastien Bouclet
938b633238 MOHAWK: Fix playing sound from aliases in Myst ME.
svn-id: r55031
2010-12-24 11:04:25 +00:00
Bastien Bouclet
04b5163228 MOHAWK: Fix Myst's combination book pages drawing at the bottom of the screen.
svn-id: r55030
2010-12-24 10:52:02 +00:00
Lars Skovlund
a03a3fd411 Fix code formatting
svn-id: r55026
2010-12-23 14:05:16 +00:00
Lars Skovlund
5b2071487f SCI: Unbreak script loading on big-endian machines. Thanks to [md5] and wjp.
svn-id: r55025
2010-12-23 14:03:58 +00:00
Yotam Barnoy
ee2b1092ab PLUGINS: switched plugin manager to inheritance rather than #defines
The reason for this was that I found issues where the wrong functions were called in EngineManager for single plugin operation. Rather than inserting more messy #defines, I preferred to change the PluginManager to use virtual functions, which also makes EngineManager simpler.

svn-id: r55024
2010-12-23 13:38:37 +00:00
Filippos Karapetis
401a8c355d SCI: Some initial work on the sound of robot videos (doesn't work yet, seems to be a problem with the encoding of the customized SOL audio files in robot videos)
svn-id: r55023
2010-12-23 13:11:10 +00:00
Filippos Karapetis
f891323f1f SCI: Fixed typo
svn-id: r55022
2010-12-23 12:54:47 +00:00
Arnaud Boutonné
8cc28b218c HUGO: Suppress two obsolete defines
svn-id: r55020
2010-12-22 23:11:41 +00:00
Arnaud Boutonné
18d3e58825 HUGO: Suppress some obsolete volume related variables
svn-id: r55019
2010-12-22 22:56:42 +00:00
Arnaud Boutonné
6d30449d5a HUGO: Implement syncSoundSettings()
svn-id: r55018
2010-12-22 22:25:52 +00:00
Filippos Karapetis
8e26ae0f92 SCI: Fixed bug #3037618 - "PQ2 : Restoring in Scuba Van causes Parser Issues"
svn-id: r55017
2010-12-22 22:18:21 +00:00
David Turner
cc30fa378e MOHAWK: Add Framework getVar() code to Myst Credits Stack Script Parser.
svn-id: r55016
2010-12-22 21:08:26 +00:00
David Turner
5e92b6049b MOHAWK: Add Framework getVar() code to Myst D'ni Age Script Parser.
svn-id: r55015
2010-12-22 21:08:02 +00:00
Arnaud Boutonné
d9cc9d5800 HUGO: Replace function comments by doxygen comments
svn-id: r55014
2010-12-22 18:25:48 +00:00
Arnaud Boutonné
51e9cdb12c HUGO: Fix little bug in sound player
Mute/unmute sound and music at the same time

svn-id: r55013
2010-12-22 17:51:07 +00:00
Johannes Schickel
c309bbde28 HUGO: Slight formatting fix.
svn-id: r55008
2010-12-22 14:23:22 +00:00
Filippos Karapetis
1d98bf484e SCI: Also reset flags when resetting the video state
svn-id: r55007
2010-12-22 14:19:38 +00:00