Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.
As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
Without this change the Apple gcc 4.0 compiler (the last version to
support the MacOS X 10.4 SDK) generate a lot of errors regarding
trying to initialise references to Sherlock::Scalpel::Talk with the
address to a Sherlock::Talk object, or about forward declarations of Sherlock::Scalpel::Talk.
Since 'w' and 'h' are members of ManagedSurface, using them as
input parameters to a method caused GCC to warn about them being
shadowed. For just about every file in the Sherlock engine...
Recently we started to use this as new semantics, although in the past
we used simly <engine>_H. Now these guard defines are consistent with
rest of the files which are used in the engines.
As far as I can tell, the lines I removed to draw the search box
are already handled by the call to makeField() above. Also, they
were drawing to the wrong surface, and one of them was in the
wrong direction, which is what triggered an assertion.
This was part regression (ManagedSurface is picky about the order
of the parameters to the line drawing functions), part bug since
it was drawing a horizontal line instead of a vertical.
This call draws a very short vertical line to separate the
rightmost "join" of the middle horizontal bar in the inventory
dialog from the scrollbar. Unless you know what you're looking
for, it's pretty hard to spot the difference.
Thanks to dreammaster for figuring out the proper fix, while I
was still trying to figure out what it was trying to draw.
This patch fixes the compile error:
format not a string literal and no
format arguments [-Werror=format-security]
Just suply "%s" as the standard format.
This way the string is not interpreted as format
which may lead to security issues.
