83 Commits

Author SHA1 Message Date
Eugene Sandulenko
20fb25d58a FULLPIPE: Renames in ExCommand 2017-12-03 23:04:58 +01:00
Bastien Bouclet
1e593a4e69 FULLPIPE: Fix out of bounds string access
abe1c65d626a8f3 changed _trackName from a char * to a Common::String,
but still tried to access the null terminator byte.
2017-11-26 08:51:36 +01:00
Colin Snover
ff96db23df FULLPIPE: Fix leaks and unnecessary extra allocations in FullpipeEngine 2017-11-18 22:35:12 +01:00
Colin Snover
72a4292727 FULLPIPE: Improve memory safety and fix leaks in sound code 2017-11-18 22:35:12 +01:00
Colin Snover
8f1d76d261 FULLPIPE: Improve memory safety and typing of NGIArchive 2017-11-18 22:35:12 +01:00
Filippos Karapetis
a93c8c5d3e Unify all string function parameters to be const Common::String &
Thanks to wjp for the suggestion
2017-03-24 00:56:11 +02:00
Filippos Karapetis
abe1c65d62 FULLPIPE: Change the sound code to use Common::String 2017-03-22 05:22:36 +02:00
Filippos Karapetis
2649e2b1fc FULLPIPE: Change genFileName() and loadFile() to use Common::String 2017-03-22 04:50:37 +02:00
Filippos Karapetis
f3e81b5f17 FULLPIPE: Use Common::String in all scene object names 2017-03-22 04:11:49 +02:00
Filippos Karapetis
907bab8a01 FULLPIPE: Remove unused variable 2016-12-20 02:06:58 +02:00
Eugene Sandulenko
6071d1b05c FULLPIPE: Restart SFX on request instead of skipping it.
This matches the original and fixes the footstep sounds.
2016-11-30 20:36:46 +01:00
Eugene Sandulenko
d712d2bcff FULLPIPE: Initial code for scene04 music 2016-11-29 19:39:04 +01:00
Eugene Sandulenko
a6d2feb8c4 FULLPIPE: Unstub setSceneMusicParameters() 2016-11-29 18:45:04 +01:00
Eugene Sandulenko
dd4f48f4d7 FULLPIPE: Unstub StopAllSoundStreams() 2016-11-29 18:45:04 +01:00
Torbjörn Andersson
75e2770fae FULLPIPE: Silence GCC warnings (mostly signed/unsigned ones) 2016-11-28 06:42:47 +01:00
Eugene Sandulenko
b5b5c4f341 FULLPIPE: Start final music 2016-11-25 18:53:16 +01:00
Eugene Sandulenko
1523f987c3 FULLPIPE: Added 4 sound channels like in original 2016-11-25 18:53:16 +01:00
Eugene Sandulenko
4d8cc0db68 FULLPIPE: Correctly restart scene audio tracks 2016-11-25 18:53:16 +01:00
Eugene Sandulenko
5eb1da42c3 FULLPIPE: Fix steps sounds 2016-10-16 23:25:38 +02:00
Eugene Sandulenko
b9b81a22c2 FULLPIPE: Make sound controls work and persistent 2016-09-11 23:18:25 +02:00
Eugene Sandulenko
0046cefd4e FULLPIPE: Fix crash on mute 2016-09-11 23:18:25 +02:00
Torbjörn Andersson
bffc1f87f9 FULLPIPE: Also free the contents of _soundList, along with it 2016-09-08 17:45:17 +02:00
Torbjörn Andersson
7db3902b44 FULLPIPE: Free _soundItems when SoundList is deleted 2016-09-08 17:24:22 +02:00
Eugene Sandulenko
26f55005b3 FULLPIPE: Rename in ExCommand structure 2016-09-04 23:54:43 +02:00
Eugene Sandulenko
b1fc0f6946 JANITORIAL: Fix whitespaces 2016-09-04 14:42:52 +02:00
Eugene Sandulenko
73d01f8521 FULLPIPE: Hid noisy warning 2016-07-31 00:31:41 +03:00
Eugene Sandulenko
6ac435099c FULLPIPE: Split all debug output by channels 2016-07-28 00:37:32 +03:00
Ori Avtalion
d32941f657 FULLPIPE: Reduce audio header dependencies 2016-04-14 17:43:56 +03:00
Filippos Karapetis
361f4d4717 FULLPIPE: Remove trailing whitespace 2014-10-28 16:22:48 +02:00
Eugene Sandulenko
263cc2873b FULLPIPE: Use safe string copying. CID 1208908 2014-06-11 23:02:58 +03:00
Eugene Sandulenko
1d53333435 FULLPIPE: Copy string safely. CID 1208909 2014-06-11 23:01:22 +03:00
Johannes Schickel
ff4c060be1 FULLPIPE: Use strlcpy instead of strncpy in some places.
strncpy does not assure that the result is 0 terminated. strlcpy does, which
makes this safer.

I only replaced strncpy usages where the memory was not allocated to the
correct size right before the strncpy usage.
2014-06-09 22:46:54 +02:00
Eugene Sandulenko
bd63ee2c4e FULLPIPE: Fix compilation 2014-06-09 22:48:34 +03:00
Eugene Sandulenko
2e30e0fc7d FULLPIPE: Safely copy string. CID 1208908 2014-06-09 22:36:01 +03:00
Eugene Sandulenko
df5ef5bf2e FULLPIPE: Safely copy strings 2014-06-09 22:34:21 +03:00
Eugene Sandulenko
5a80e828e6 FULLPIPE: Implement Sound::setPanAndVolumeByStaticAni() 2014-05-30 08:03:40 +03:00
Eugene Sandulenko
b07a833b63 FULLPIPE: Fix mistypo in FullpipeEngine::stopAllSounds() which lead to crash 2014-05-14 11:33:19 +02:00
Eugene Sandulenko
a708e4ffc9 FULLPIPE: Implement FullpipeEngine::setMusicVolume() 2014-05-03 11:22:45 +03:00
Eugene Sandulenko
2975ef3ebe FULLPIPE: Implement FullpipeEngine::stopAllSounds() 2014-05-03 11:18:47 +03:00
Eugene Sandulenko
10d3017737 FULLPIPE: Proper implementation of FullpipeEngine::stopAllSoundInstances() 2014-04-27 11:07:41 +03:00
Eugene Sandulenko
eaee951a2f FULLPIPE: Implement Sound::setPanAndVolume() 2014-04-26 23:32:27 +03:00
Eugene Sandulenko
64800b2ac2 FULLPIPE: Implement SoundList::getSoundItemById() 2014-04-26 21:58:20 +03:00
Eugene Sandulenko
533b4accb2 FULLPIPE: Fixed Sound::getVolume() 2014-04-26 21:45:41 +03:00
Eugene Sandulenko
ecdda5acdf FULLPIPE: Implement Sound() destructor 2014-04-26 17:34:24 +03:00
Eugene Sandulenko
452f939cba FULLPIPE: Implement Sound::freeSound() and Sound::stop() 2014-04-26 17:32:41 +03:00
Eugene Sandulenko
e25195d8f5 FULLPIPE: Implement Sound::play() 2014-04-26 17:00:11 +03:00
Eugene Sandulenko
4d81792b45 FULLPIPE: Implement global_messageHandler_handleSound() 2014-04-26 16:25:01 +03:00
Eugene Sandulenko
2f10c8ec55 FULLPIPE: Proper implementation of FullpipeEngine::playSound() 2014-04-26 15:06:23 +03:00
Eugene Sandulenko
ba14a54d79 FULLPIPE: Implement FullpipeEngine::setSceneMusicParameters() 2014-04-26 15:00:36 +03:00
Eugene Sandulenko
4598f48fd6 FULLPIPE: Remove redundant object casts 2014-04-26 14:47:18 +03:00