53 Commits

Author SHA1 Message Date
aryanrawlani28
68d01321d6 GUI: U32: Downscale changes of U32, fix review issues
This commit addresses a range of changes, within scummvm subproject.

- Audio files, like mididrv, remove U32String based name and identifier, because ASCII only.
- mididrv.cpp had some wrong format for warning messages, fix those
- Message dialogs were modified to use default arguments more often, but reverting back to the orignal to minimize changes.
- SetTooltip has a fake constructor that takes in a string, and use it.
- U32Format had some break statements missing, add those.
- RemapWidget: Use fake constructor for setLabel and setTooltip, to make minimal changes
- SDL: setting text in clipboard no longer uses SDL_iconv_string
- TTS: Override base class "say" with strings, so tts->say can be used with normal strings too.
- About dialog: fix incorrect code for u32string variables
- Fix some extra brackets
- Some buttons were incorrectly removed from using translated labels, revert those
- Message Dialog: Pass default and alt buttons as const references
- Saveload Dialog: Use translations in missing places, use const-references. Also, use translations in a correct manner.
- Use const references for tooltip in GraphicsWidget, EditTextWidget, error.cpp
- DomainEditTextWidget: Use U32String for text
2020-08-30 14:43:41 +02:00
aryanrawlani28
d12c6c4338 GUI: U32: Code cleanup
- Remove extra parantheses leftover from temp code
- SaveLoadDialog - do not encode when setting labels
- Remove mapping variable from ThemeEngine::loadScalableFont (and use default 0)
- Remove incorrect u32 constructor wrapper from confman.set in eventrecorder.cpp
2020-08-30 14:43:41 +02:00
aryanrawlani28
185fb72783 GUI: U32: Improve U32 code
- Revert accidentally put translations in mt32.cpp
- Use U32::format in some places earlier missed
- Add %u and %i for u32::format
- Add support for GUIErrorMsgFormat to use u32::format internally
- Use the above whereever needed
- Improve linux tts by removing redundant code
- Some places I had changed nullptr -> "". Revert this
2020-08-30 14:43:41 +02:00
aryanrawlani28
4506bcd9f3 GUI: U32: Fix compilation errors
After rebasing to get even with master, some compilation errors occured. This commit fixes that.
2020-08-30 14:43:41 +02:00
aryanrawlani28
96912f4adb GUI: U32: Rename some references of strings to use U32() & not helper method 2020-08-30 14:43:41 +02:00
aryanrawlani28
f800ca4ada GUI: U32: Convert majority of code to use U32
This commit also includes some additional major changes.

- Return U32String from TransMan getTranslation()
- Change tooltips to be U32Strings
- Remove temporary code of convertToU32String
- U32 Support various dialogs (Browser, FileBrowser, Messages, Chooser, etc)
- U32 for music plugins
- U32 for OSD messages
- Add some helper functions to ustr.cpp
- Change default tooltips from nullptr & 0 -> ""
- Some runtime exceptions may occur when changing languages due to incorrect String::Format
2020-08-30 14:43:41 +02:00
aryanrawlani28
5f2af6b93e GUI: U32: Add u32 support to Editables and Dialogs
- Editable widgets
- Lists
- SaveLoad Dialogs
- Browser Dialogs
2020-08-30 14:43:41 +02:00
aryanrawlani28
aafade4507 GUI: U32: Shift most widgets to draw with u32
- ButtonWidgets (Button, Radio, Checkbox, dropdown)
- StaticTextWidgets
- PopUpWidgets
- Tabs
- Add a temporary overloaded drawDDText function to make other widgets draw normally
2020-08-30 14:43:41 +02:00
aryanrawlani28
12a4af77bd GUI: Code cleanup 2020-06-22 00:03:02 +02:00
aryanrawlani28
38e827d1e9 GUI: RTL: Correct behaviour of predictive dialogs for rtl layout 2020-06-22 00:03:02 +02:00
aryanrawlani28
12b26cec07 GUI: RTL: Revise numeric layout in predictive dialog and flip them again 2020-06-22 00:03:02 +02:00
aryanrawlani28
345520b8cb GUI: improve predictive dialog in agi 2020-03-28 12:34:00 +01:00
Bastien Bouclet
6e1abf064a GUI: Use nullptr instead of 0 or NULL where appropriate 2020-01-19 15:08:37 +01:00
D G Turner
30c366ee5d GUI: Add Missing Switch Default Cases
These are flagged by GCC if -Wswitch-default is enabled.
2019-10-03 06:03:46 +01:00
Cameron Cawley
a873544840 DS: Fix building with AGI engine disabled 2018-04-07 09:30:07 +02:00
Bastien Bouclet
0496ede62f GUI: Implement dirty-checking for widget redraws 2018-01-27 18:12:34 +01:00
Eugene Sandulenko
b590cc2d8f GUI: Cleanup class initialization 2016-06-01 13:16:12 +02:00
Ori Avtalion
e30a94e6ff GUI: Remove 'sticky button' feature
This feature made pressed buttons wait a few moments before returning to
an unpressed state. It was half-implemented, and caused several visual
bugs. Fixes #7083.
2016-04-14 18:37:12 +03:00
Torbjörn Andersson
aded46f08b GUI: Don't crash on empty dictionary in predictive dialog 2016-02-28 15:23:24 +01:00
Torbjörn Andersson
bf5208dd3d GUI: Fix two leaks in predictive dialog 2016-02-28 15:04:11 +01:00
Johannes Schickel
b6da7c6033 GUI: Add missing _() for translation in predictivedialog.cpp. 2016-01-25 20:38:22 +01:00
Johannes Schickel
5a63ee5375 GUI: Use "button" instead of "btn" in variable names. 2016-01-24 03:41:29 +01:00
Johannes Schickel
120164ba07 GUI: Reduce scope of variable in PredictiveDialog::processButton. 2016-01-24 03:37:33 +01:00
Johannes Schickel
15012d1596 GUI: Fix typo in comment in predictivedialog.cpp. 2016-01-24 03:37:33 +01:00
Johannes Schickel
adbbe6b113 GUI: Improve naming of PredictiveDialog's members. 2016-01-24 03:37:33 +01:00
Johannes Schickel
7c687a05c7 GUI: Make PredictiveDialog::_btns a fixed size array. 2016-01-24 03:22:26 +01:00
Johannes Schickel
c72d95cbcc GUI: Add constructor instead of duplicating initialization. 2016-01-24 03:19:59 +01:00
Johannes Schickel
144765827f GUI: Improve variable naming in PredictiveDialog. 2016-01-24 03:14:09 +01:00
Johannes Schickel
66a815a214 GUI: Set PredictiveDialog's debug output to level 5+. 2016-01-24 03:10:13 +01:00
Johannes Schickel
83df1eb43b GUI: Only use image for delete when applicable in PredictiveDialog. 2016-01-24 03:06:47 +01:00
Johannes Schickel
4a092eeb64 GUI: Formatting fixes in predictivedialog.cpp. 2016-01-24 02:37:35 +01:00
Johannes Schickel
f5dfe6725a GUI: Make GPL headers consistent in themselves. 2014-02-18 02:39:35 +01:00
Eugene Sandulenko
aa2a6d7445 GUI: Skip useless assignment. CID 1002117 2013-11-03 01:28:03 +02:00
Johannes Schickel
023fedef48 GUI: Do not return current input on cancel in PredictiveDialog.
Returning the currently displayed input when you click cancel is confusing
behavior in my eyes.
2013-10-02 00:16:59 +02:00
Johannes Schickel
225a823555 GUI: Initialize PredictiveDialog::_predictiveResult.
This fixes garbage output when canceling the predictive dialog in AGI when
nothing was entered.
2013-10-02 00:16:59 +02:00
Johannes Schickel
6ace85a84d GUI: Clean up calloc use in PredictiveDialog.
Instead of manually multiplying the entry count with the entry size we simply
use both parameters of calloc as intended now.
2013-10-02 00:16:59 +02:00
Johannes Schickel
45e7ba130e GUI: Fix compilation with clang and C++11.
newDictLine is allocated with calloc in line 856 thus there is no need to
initialize any entry.
2013-10-02 00:16:59 +02:00
Eugene Sandulenko
92780a3320 GUI: Fix memory leak. CID 1003569 2013-04-24 01:16:31 +03:00
Johannes Schickel
89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Oleksiy Kurochko
24a45beceb GUI: Use pressed state in predictive dialog in keyboard mode.
This adds more visual feedback to the user.
2012-05-03 19:32:34 +03:00
Johannes Schickel
b8065a4392 GUI: Move "I18N" tagged comment to matching strings.
The strings are not marked for translation, so I am not sure why the comments
are tagged with I18N though.
2012-03-29 02:23:44 +02:00
Johannes Schickel
388e04bb6d GUI: Add TODO/FIXME to PredictiveDialog::handleTickle. 2012-03-29 02:12:32 +02:00
Johannes Schickel
a7ee1dc42b GUI: Remove unnecessary goto in PredictiveDialog code. 2012-03-29 02:08:09 +02:00
Johannes Schickel
6ed2d15c44 GUI: Take advantage of Common::String::empty. 2012-03-29 02:07:02 +02:00
Johannes Schickel
7414544121 GUI: Constify some parameters/methods in PredictiveDialog. 2012-03-29 02:05:45 +02:00
Johannes Schickel
988c3fd6c5 GUI: Make some static strings in PredictiveDialog static + const. 2012-03-29 02:00:25 +02:00
Johannes Schickel
02e77dd7b2 GUI: Don't typedef Common::String in PredictiveDialog code. 2012-03-29 01:53:09 +02:00
Johannes Schickel
f3a19ea6aa GUI: Get rid of "using namespace Common" in predictivedialog.cpp. 2012-03-29 01:50:52 +02:00
Johannes Schickel
15ff9380b5 GUI: Formatting fixes in the PredictiveDialog code. 2012-03-29 01:50:00 +02:00
D G Turner
371bc1ddc1 GUI: Fix for WinCE compile failure after predictive dialog changes.
This is probably due to a collision with WinCE toolchain system define,
so changing the enum from all capitalised to Camel Case constant style.
2012-03-25 23:29:19 +01:00