3695 Commits

Author SHA1 Message Date
Eugene Sandulenko
5dfb0c592c COMMON: Remove duplicate include 2021-03-22 00:07:45 +01:00
Eugene Sandulenko
7725f0ceed COMMON: Make WinResource::getVersionInfo more universal 2021-03-22 00:07:44 +01:00
Matthew Hoops
6b87aee941 COMMON: Ensure stddef.h is included in scummsys.h 2021-03-22 00:07:39 +01:00
Matthew Hoops
76f5c3d2f5 COMMON: Add a wrapper to read PE strings 2021-03-22 00:07:38 +01:00
Matthew Hoops
4d104c12e2 COMMON: Fix some memory leaks 2021-03-22 00:07:38 +01:00
Matthew Hoops
639a1e0120 COMMON: Add a function to read NE strings 2021-03-22 00:07:36 +01:00
Matthew Hoops
c3c188f4b6 COMMON: Add an NE version resource parser 2021-03-22 00:07:36 +01:00
Matthew Hoops
4cbcd29a94 COMMON: Fix out-of-bounds write in SZDD EXE decompression 2021-03-22 00:07:36 +01:00
Le Philousophe
db8559ff3e COMMON: Initialize _pbase_dir in all constructors
Fixes bug #12337
2021-03-20 21:04:06 +01:00
D G Turner
b8c4cd8129 COMMON: Use Correct Symbol in New String Function 2021-03-15 23:01:24 +00:00
Le Philousophe
75833aba29 COMMON: Don't use unavailable macros in unicode-bidi.h
Use Fribidi ones directly in implementation and tag the constructor as
"private"
Fix a warning on Common::CodePage
2021-03-15 16:29:28 +02:00
Orgad Shaneh
2aba99819a COMMON: Remove explicit ctors and copy assignment operator
They're equivalent to the implicit ones anyway.
2021-03-15 13:24:33 +00:00
Orgad Shaneh
2de08c0717 COMMON: Fix FriBidiParType failure on 3ds
/data/src/master/common/unicode-bidi.cpp: In member function 'void
Common::UnicodeBiDiText::initWithU32String(const Common::U32String&)':
/data/src/master/common/unicode-bidi.cpp:78:3: error: invalid conversion
from 'uint32*' {aka 'unsigned int*'} to 'FriBidiParType*' {aka 'long
unsigned int*'} [-fpermissive]
   78 |   &_pbase_dir,
      |   ^~~~~~~~~~~
      |   |
      |   uint32* {aka unsigned int*}
2021-03-14 22:18:15 +01:00
Zvika Haramaty
dc5783c910 COMMON: Add String::forEachLine and convertBiDiStringByLines
`convertBiDiStringByLines` calls the BiDi algo for each line in isolation,
and returns a joined result.
That's needed to support BiDi in AGI, and might be needed for other engines
in the future.

In order to do that, a new utility function was added:
`String::forEachLine` which gets a function as input, and its arg(s) (if it has any),
and calls the function on each line, and returns a new string which is all
concatenation of all the lines results (with '\n' added between them).
2021-03-14 18:52:36 +01:00
Martin Gerhardy
8b2e957914 COMMON: fixed clang-sanitizer warnings 2021-03-14 11:26:19 +01:00
Martin Gerhardy
5b9fa67445 COMMON: const for AchievementsManager::isAchieved 2021-03-14 11:26:19 +01:00
Martin Gerhardy
6121292934 COMMON: fixed formatting 2021-03-14 11:26:19 +01:00
D G Turner
11654c8fbf COMMON: Fix Compilation with pre-C++-11 Compilers 2021-03-13 19:44:17 +00:00
D G Turner
d91b87acbf COMMON: Fix GCC Warning for Implicit Copy Operator in Queue Class
This is emitted when -Wdeprecated-copy is enabled. The fix implemented
is to explicitly declare this to be the default copy operator.

Since this may be a latent bug, this is marked with a FIXME.
2021-03-13 12:34:19 +00:00
D G Turner
0d6e4d647a COMMON: Minor Formatting Fix in String Header 2021-03-12 19:50:49 +00:00
Thierry Crozat
50932ffb38 BUILD: Fix building with c++11 on systems without std::nullptr_t 2021-03-07 19:30:34 +00:00
Orgad Shaneh
81fd1d529b COMMON: Fix warnings on mingw build
bits/os_defines.h has #define NOMINMAX 1, which conflicts with the
non-value #define NOMINXMAX in scummsys.h.

In file included from ../scummvm/common/lua/lua.h:12,
                 from ../scummvm/common/lua/ltable.cpp:27:
../scummvm/common/scummsys.h:111: warning: "NOMINMAX" redefined
  111 |   #define NOMINMAX
      |
In file included from C:/msys64/mingw64/include/c++/10.2.0/x86_64-w64-
mingw32/bits/c++config.h:518,
                 from C:/msys64/mingw64/include/c++/10.2.0/cmath:41,
                 from C:/msys64/mingw64/include/c++/10.2.0/math.h:36,
                 from ../scummvm/common/lua/ltable.cpp:21:
C:/msys64/mingw64/include/c++/10.2.0/x86_64-w64-mingw32/bits/
os_defines.h:45: note: this is the location of the previous definition
   45 | #define NOMINMAX 1
      |

Amends commit 88f685217b1c8e7ab2c7a588677ad4744480b4a3.
2021-03-06 03:06:11 +00:00
Peter Kohaut
e59a470db3 TINSEL: Updated addional drawing routines for v3
Implemented playing of films of objects (not movies).
Fixed rendering of the main menu.
Increased the size of parameters of coroutines.
2021-03-04 20:45:32 +01:00
neuromancer
03d9efa5d0 COMMON: renamed include guard in installshieldv3 2021-03-04 02:06:59 +01:00
neuromancer
817fc1ba0c COMMON: moved include guard to the top 2021-03-04 02:06:59 +01:00
neuromancer
ccd4c9a831 PRIVATE: fixes and renamed installer_archive 2021-03-04 02:06:59 +01:00
neuromancer
78febfbd00 PRIVATE: fixed detection from assets without installing 2021-03-04 02:06:59 +01:00
SupSuper
88f685217b COMMON: Don't use Win32 MIN/MAX since ScummVM provides its own 2021-03-03 11:17:37 +00:00
SupSuper
a399be3844 COMMON: Modern MSVC has inttypes.h 2021-03-03 11:17:28 +00:00
sluicebox
93eeffc84d JANITORIAL: Update old bug tracker numbers 2021-03-03 02:15:05 +02:00
Henrik "Henke37" Andersson
6b2bf785a4 COMMON: Correctly specialize unknownKeyError for int. 2021-02-21 15:33:26 +00:00
Henrik "Henke37" Andersson
f8facede40 COMMON: Specialize unknownKeyError for const char* 2021-02-21 15:33:26 +00:00
Zvika Haramaty
03fb100226 AGI: support new WinAGI *.wag file format 2021-02-15 03:02:23 +02:00
Eugene Sandulenko
f27bf85bf7 COMMON: Fix for modern GCC 2021-02-12 00:55:16 +01:00
Henrik "Henke37" Andersson
0caeac64aa COMMON: Include the not found key in the error message 2021-02-12 00:41:23 +01:00
Henrik "Henke37" Andersson
470505cc56 COMMON: ConfMan needs getValOrDefault 2021-02-12 00:41:23 +01:00
Henrik "Henke37" Andersson
2eb52fe900 COMMON: Retire dangerous non const operator[] on ConfMan 2021-02-12 00:41:23 +01:00
Henrik "Henke37" Andersson
cc51c9a483 COMMON: ConfMan no longer hides unknown key errors 2021-02-12 00:41:23 +01:00
Henrik "Henke37" Andersson
2d6fdcaf3e COMMON: getVal no longer hides missing keys 2021-02-12 00:41:23 +01:00
Le Philousophe
d8ab567a9b COMMON: Add include guard on initializer_list.h 2021-02-08 10:54:20 +01:00
Cameron Cawley
1bfff86090 COMMON: Add replacement for isblank() 2021-02-07 11:51:03 -08:00
Le Philousophe
f8ff774b8d COMMON: Fix clang build
In C++11 standard, nullptr_t is defined in std and not in global space
2021-02-07 11:38:46 +01:00
Le Philousophe
c49f338a0b COMMON: Fix GCC deprecated-copy warning in SharedPtr 2021-02-07 10:53:38 +01:00
Paul Gilbert
1b11fe993c COMMON: Refactor c++11 using keyword from SharedPtr 2021-02-06 21:14:30 -08:00
Paul Gilbert
53656e0338 COMMON: Wrap ptr initializers using nullptr_t in USE_CXX11 2021-02-06 17:11:07 -08:00
Paul Gilbert
8f6391bb5b COMMON: Added WeakPtr class, refactored SharedPtr 2021-02-06 16:37:31 -08:00
Cameron Cawley
28086f4f8a DS: Replace outdated filesystem code 2021-02-04 01:59:14 +01:00
Martin Gerhardy
1d184f845c COMMON: removed trailing whitespaces 2021-01-03 13:06:23 +01:00
Martin Gerhardy
d69e6f2e1e COMMON: removed wild living semicolons 2021-01-03 13:06:23 +01:00
Jonathan Phénix
7d5405cea5 COMMON: Fix build warning with LLVM's scan-build 2020-12-22 01:49:55 +01:00