We broke save states along the way when we improperly switched variable
types.
The end result is also a lot of needless conversions between types.
This commit should hopefully address that, and we fixed broken save
states.
accurate anyway.)
Updating the emulator's core code to fix some issues reported by Clang/GCC.
(bios.pages was 8-bits even though cart.pages was 16-bits.
This could cause issues if a game like Bad Apple is played using the bios.)
Removing error.c/error.h, it was never used.
I'm trying to fix the signing/unsigned issues that i had introduced
a while back unfortunately (though the older code still suffered from it
to some code).
Some of it is fixed but not all of it is fixed. Ideally, this should
be switched to using 32-bits ints if possible.
One of them is a fix for a really odd bug with the proprietary z80 core :
Pause button would not work.
For some reasons, executing the irq line functions will not work if
put in a function so what i did was a bunch of macros instead.
This now works and reduces the complexity of the code kinda.
(Also inlining)
There's also a fix for the ALSA code. On the bittboy,
it woud sometimes underrun. When it does so, it becomes mute.
Fixed this by handling underruns and removing non blocking.
(Useless anyway here)
