libretro/virtualjaguar-libretro
1
0 Fork 0
mirror of https://github.com/libretro/virtualjaguar-libretro.git synced 2026-11-07 04:36:00 -10:00
Code Issues Packages Projects Releases 1 Wiki Activity

fix(windows): reject the Basic Render Driver by vendor id and name, not only by flag

Browse Source 
The hosted ARM64 runner enumerates "Microsoft Basic Render Driver"
through IDXGIFactory1 without DXGI_ADAPTER_FLAG_SOFTWARE, so the probe
accepted it as hardware and the retry ran on WARP again.  Also treat
Microsoft's vendor id 0x1414 and a description containing "Basic Render"
as software.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
This commit is contained in:
Joseph MattielloandClaude Fable 5.1 authored and GitHub committed 2026-11-01 18:09:05 -05:00
1 parent 4e39bcdd20
commit 0bb66be5cb
1 file changed
+9 -3
Download Patch File Download Diff File Expand all files Collapse all files
app/src/platform/software_gl_windows.cpp
+9 -3
View File
@@ -39,9 +39,15 @@ std::wstring hardwareD3D12Adapter() {
IDXGIAdapter1* adapter = nullptr;
for (UINT i = 0; found.empty() && factory->EnumAdapters1(i, &adapter) != DXGI_ERROR_NOT_FOUND; ++i) {
DXGI_ADAPTER_DESC1 desc = {};
if (SUCCEEDED(adapter->GetDesc1(&desc)) && !(desc.Flags & DXGI_ADAPTER_FLAG_SOFTWARE) &&
SUCCEEDED(createDevice(adapter, D3D_FEATURE_LEVEL_11_0, __uuidof(ID3D12Device), nullptr)))
found = desc.Description;
// DXGI_ADAPTER_FLAG_SOFTWARE is not reliably set on the Basic Render
// Driver (the hosted ARM64 runner enumerates it without the flag), so
// also reject Microsoft's vendor id 0x1414 and the name itself.
if (SUCCEEDED(adapter->GetDesc1(&desc))) {
const bool software = (desc.Flags & DXGI_ADAPTER_FLAG_SOFTWARE) || desc.VendorId == 0x1414 ||
std::wcsstr(desc.Description, L"Basic Render") != nullptr;
if (!software && SUCCEEDED(createDevice(adapter, D3D_FEATURE_LEVEL_11_0, __uuidof(ID3D12Device), nullptr)))
found = desc.Description;
}
adapter->Release();
adapter = nullptr;
}