microsoft/semantic-kernel
1
0
Fork 0
mirror of https://github.com/microsoft/semantic-kernel.git synced 2026-10-12 02:19:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix SKFunction.InvokeAsync to respect input when passed in explicitly. (#1757)

Browse Source 
- The defaults for `mutableContext` are `true` which make it super easy
to fall into this trap. I slammed my head against the wall for a while
until realizing that the SK InvokeAsync method wasn't properly utilizing
the `input` parameter.

---------

Co-authored-by: Shawn Callegari <[email protected]>
This commit is contained in:
N. Taylor Mullen
2023-06-29 01:25:59 +00:00
committed by GitHub
co-authored by Shawn Callegari
parent de9c202a72
commit 6a370e7d13
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.cs
+6 -10
View File
@@ -125,18 +125,14 @@ public static class SKFunctionExtensions
function.SkillName, function.Name);
}
if (mutableContext)
if (!mutableContext)
{
context.Variables.Update(input);
return function.InvokeAsync(context, settings);
// Create a copy of the context, to avoid editing the original set of variables
context = context.Clone();
}
// Create a copy of the context, to avoid editing the original set of variables
SKContext contextClone = context.Clone();
// Store the input in the context clone
contextClone.Variables.Update(input);
return function.InvokeAsync(contextClone, settings);
// Store the input in the context
context.Variables.Update(input);
return function.InvokeAsync(context, settings);
}
}