Commit Graph
8 Commits
Author SHA1 Message Date
Adarsh AcharyaandDmytro Struk ff6b4fb39b Python: Fix type error in kernel server.py (#3185)
### Description

This PR fixes #3123.
The problem was in line 147 of kernel_server.py :
[Line147](https://github.com/microsoft/semantic-kernel/blob/bdc517d0f80e0f0896a8f1fc01d4327848c74937/samples/python/kernel_http_server/utils/kernel_server.py#L147C9-L147C14)

The plan object here is plan.Plan, which is incorrect. I believe it
should be basic_planner.Plan, here :
[plan](https://github.com/microsoft/semantic-kernel/blob/bdc517d0f80e0f0896a8f1fc01d4327848c74937/python/semantic_kernel/planning/basic_planner.py#L12C7-L12C11)

### Contribution Checklist

- [ ] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <[email protected]>
2023-10-16 17:54:37 +00:00
Dmytro Struk 46e8c1e68b Python: .Net: Update dotnet notebooks to use SK 1.0.0-beta1 version (#3158)
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Resolves: https://github.com/microsoft/semantic-kernel/issues/3125
Resolves: https://github.com/microsoft/semantic-kernel/issues/2970
Resolves: https://github.com/microsoft/semantic-kernel/issues/3124

This PR contains changes in dotnet notebooks to upgrade SK package
version to `1.0.0-beta1`, necessary syntax changes in code examples and
`skills` to `plugins` renaming.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
2023-10-12 09:59:11 +00:00
Matthew Bolaños 9cd68cea2e Add deprecation warnings to samples (#2967)
### Motivation and Context

Per https://github.com/microsoft/semantic-kernel/issues/2810, we will be
deprecating the current web-based samples in favor of console apps in
the dotnet and python samples folders.

### Description

Added a deprecation warning to the samples

### Contribution Checklist

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
2023-09-26 15:12:03 +00:00
f251e654ec Python: Enable serialization for sk/orchestration (#2369)
SKFunction has been excluded for now.

Handles issues arising due to many circular imports Update
DelegateInference to handle some cases where annotation is given as a
string to avoid circular imports like in FileIOSkill.

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Abby Harrison <[email protected]>
Co-authored-by: Mark Karle <[email protected]>
Co-authored-by: Abby Harrison <[email protected]>
Co-authored-by: Lee Miller <[email protected]>
Co-authored-by: Devis Lucato <[email protected]>
2023-08-24 16:05:39 +00:00
Mark Karle c4987edf7f Python: Fix linting issues in python KernelHttpServer sample (#2102)
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Fixes linting issues missed when merging the KernelHttpServer
### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#dev-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
2023-07-20 22:50:37 +00:00
9bdeb42c9e Python: KernelHttpServer (#915)
### Motivation and Context
This is a python implementation of the KernelHttpServer. Trying to
replicate the same functionalities the C# version offers.

see: #851 

### Description

Implementation of the KernelHttpServer in python. Currently not all
applications are supported (some are missing skill implementation in
python).

Supported endpoint
- [POST] api/skills/{skillName}/invoke/{functionName}
- [GET] api/ping
- [POST] api/planner/createplan
- [POST] api/planner/execute/{maxsteps}


Here the status of each application : 

- **book-creator-webapp-react** :  Working
- **chat-summary-webapp-react** : Not working , missing
ConversationSummary skill in python
- **github-qna-webapp-react** : Not working , missing the github skill
in python
- **auth-api-webapp-react** : Not working, missing ConversationSummary
skill and TaskListSkill

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Abby Harrison <[email protected]>
Co-authored-by: Mark Karle <[email protected]>
Co-authored-by: Shawn Callegari <[email protected]>
Co-authored-by: Dmytro Struk <[email protected]>
2023-07-19 23:30:18 +00:00
Shawn Callegariandname 7a3fad9dbb Python: move kernel-syntax-examples to python/samples folder (#1650)
Moving kernel-syntax-examples to the python/samples folder.
Leaving README behind to point to the new folders (will delete in a few
sprints)

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [X] The code builds clean without any errors or warnings
- [X] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [X] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [X] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

Co-authored-by: name <email>
2023-06-23 15:19:39 +00:00
6299040bd2 Rebrand end-to-end folder under python tests (#1503)
Rebrand end-to-end folder to kernel-syntax-examples because these aren't
actually tests for the repo. They are console apps.

Addresses #1397

Co-authored-by: Alex Chao <achao@achao>
Co-authored-by: Lee Miller <[email protected]>
2023-06-20 17:29:49 +00:00