mirror of
https://github.com/microsoft/semantic-kernel.git
synced 2026-10-12 02:19:06 +00:00
David Grieve
688d4a4a1b
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Initial port of C# memory to Java. Includes VolatileMemoryStore, no others. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Introduces semantickernel-api/src/main/java/com/microsoft/semantickernel/memory and implementation in semantickernel-core/src/main/java/com/microsoft/semantickernel/memory e2e integration test provides a sample. See java/api-test/integration-tests/src/test/java/com/microsoft/semantickernel/e2e/TextEmbeddingsTest.java ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] -The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`- Java code uses AOSP style - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
56 lines
1.8 KiB
XML
56 lines
1.8 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<FindBugsFilter>
|
|
|
|
<!-- NullMemory.getInstance() may expose internal representation by returning NullMemory.DEFAULT, but NullMemory has no internal representation. -->
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.NullMemory"/>
|
|
<Method name="getInstance"/>
|
|
<Bug pattern="MS_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<!-- DefaultSemanticTextMemory(MemoryStore, EmbeddingGeneration) may expose internal representation by storing an externally mutable object into DefaultSemanticTextMemory._storage -->
|
|
<!-- TODO: This should be a temporary exclusion pending a proper fix, if possible. -->
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.DefaultSemanticTextMemory"/>
|
|
<Field name="_storage"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.orchestration.planner.DefaultSequentialPlannerSKFunction"/>
|
|
<Field name="delegate"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.Kernel$Builder"/>
|
|
<Method name="withMemoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Field name="memoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.DefaultKernel"/>
|
|
<Method name="getMemoryStore"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.memory.DefaultSemanticTextMemory$Builder"/>
|
|
<Method name="setStorage"/>
|
|
<Bug pattern="EI_EXPOSE_REP2"/>
|
|
</Match>
|
|
|
|
<Match>
|
|
<Class name="com.microsoft.semantickernel.skilldefinition.DefaultSkillCollection"/>
|
|
<Method name="getSkillCollection"/>
|
|
<Bug pattern="EI_EXPOSE_REP"/>
|
|
</Match>
|
|
|
|
</FindBugsFilter>
|