modelscope/FunASR
1
0
Fork 0
mirror of https://github.com/modelscope/FunASR.git synced 2026-10-12 02:19:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Display review-gated integration PRs clearly (#3354)

Browse Source 
Co-authored-by: LauraGPT <[email protected]>
This commit is contained in:
zhifu gao
2026-07-23 04:46:56 +08:00
committed by GitHub
co-authored by LauraGPT
parent 9eee3095c8
commit ece2849253
2 changed files with 41 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/collect_growth_metrics.py
+9 -8
View File
@@ -564,15 +564,7 @@ def recommend_integration_action(
def display_mergeable_state(integration: Dict[str, Any]) -> str:
mergeable_state = integration.get("mergeable_state")
if mergeable_state and mergeable_state != "unknown":
return str(mergeable_state)
mergeable = integration.get("mergeable")
if isinstance(mergeable, bool):
return "mergeable" if mergeable else "not mergeable"
if mergeable and str(mergeable).lower() not in {"unknown", "none"}:
return str(mergeable).lower()
checks = integration.get("checks") or {}
next_action = integration.get("next_action") or "inspect"
has_check_blocker = bool(checks.get("failed_check_runs") or checks.get("pending_check_runs"))
@@ -584,9 +576,18 @@ def display_mergeable_state(integration: Dict[str, Any]) -> str:
integration.get("known_review_gate_reason")
or integration.get("known_assisted_review_reason")
)
and (mergeable is True or mergeable_state in {"blocked", "unknown", "unstable", None})
):
return "review-gated"
if mergeable_state and mergeable_state != "unknown":
return str(mergeable_state)
if isinstance(mergeable, bool):
return "mergeable" if mergeable else "not mergeable"
if mergeable and str(mergeable).lower() not in {"unknown", "none"}:
return str(mergeable).lower()
return str(mergeable_state or mergeable or "unknown")
tests/test_collect_growth_metrics.py
+32
View File
@@ -1270,6 +1270,38 @@ def test_format_integration_markdown_marks_unknown_review_gate_as_review_gated()
) in output
def test_format_integration_markdown_marks_mergeable_blocked_review_wait_as_review_gated():
module = load_growth_metrics_module()
metrics = {
"collected_at_utc": "2026-07-02T00:00:00+00:00",
"integrations": [
{
"pr": "huggingface/transformers#46180",
"html_url": "https://github.com/huggingface/transformers/pull/46180",
"state": "open",
"mergeable": True,
"mergeable_state": "blocked",
"repo_stars": 162_000,
"repo_forks": 33_000,
"updated_at": "2026-07-22T08:50:59Z",
"updated_age_days": 0,
"next_action": "wait for maintainer review",
"known_assisted_review_reason": (
"checks are green and the remaining blocker is an active maintainer-held review thread"
),
"checks": {"state": "success", "failed_check_runs": [], "pending_check_runs": []},
}
],
}
output = module.format_integration_markdown(metrics)
assert (
"| [huggingface/transformers#46180](https://github.com/huggingface/transformers/pull/46180) | "
"162,000 | 33,000 | open | review-gated | success | 0 | 0 | 0d | wait for maintainer review | `2026-07-22T08:50:59Z` |"
) in output
def test_format_integration_markdown_lists_high_exposure_priorities_by_stars():
module = load_growth_metrics_module()
metrics = {