fix(coverage): validate boundary identifiers at request admission

.github/workflows/ghidra-bridge-sources.yml

@@ -25,7 +25,7 @@ jobs:
           node-version-file: .nvmrc
       - name: Validate the SDK pin against the provider's verified release
         run: node scripts/verify-ghidra-bridge-sources.mjs --check-sdk-pin >> "$GITHUB_ENV"
-      # The bridge probe imports only source-owned ARM, Thumb and MIPS bytes and never
+      # The bridge probe imports only source-owned ARM/Thumb bytes and never
       # executes target code. All SDK/project state stays in runner storage.
       - name: Acquire checksum-verified Ghidra SDK in isolated runner storage
         shell: bash
@@ -46,7 +46,7 @@ jobs:
           java_home_variable="JAVA_HOME_${GHIDRA_JAVA_MAJOR}_X64"
           test -n "${!java_home_variable}"
           JAVA_HOME="${!java_home_variable}" npm run verify:ghidra:bridge-sources -- --verified-sdk
-      - name: Inspect real ARM, Thumb and MIPS instruction context through the bridge
+      - name: Inspect real ARM and Thumb instruction context through the bridge
         shell: bash
         run: |
           java_home_variable="JAVA_HOME_${GHIDRA_JAVA_MAJOR}_X64"
@@ -58,21 +58,10 @@ jobs:
             -import "${probe_root}/arm-thumb.bin" -loader BinaryLoader -processor ARM:LE:32:v7 \
             -noanalysis -readOnly -deleteProject \
             -scriptPath "${GITHUB_WORKSPACE}/tests/conformance/ghidra;${GITHUB_WORKSPACE}/bridge/ghidra" \
-            -postScript ReaInstructionContextProbe.java "${GITHUB_WORKSPACE}/bridge/ghidra" \
+            -postScript ReaArmContextProbe.java "${GITHUB_WORKSPACE}/bridge/ghidra" \
             > "${probe_root}/output.log" 2>&1 || { cat "${probe_root}/output.log"; exit 1; }
           cat "${probe_root}/output.log"
           grep -F 'REA_ARM_CONTEXT_OK arm=0 thumb=1 unavailable=null (injected provider value)' "${probe_root}/output.log"
-          mkdir -p "${probe_root}/mips-project"
-          # MIPS32 addiu v0,a0,3; MIPS16 li v0,90. These bytes are never executed.
-          printf '\003\000\202\044\132\152\000\000' > "${probe_root}/mips.bin"
-          timeout 180s "${GHIDRA_INSTALL_DIR}/support/analyzeHeadless" "${probe_root}/mips-project" MipsContext \
-            -import "${probe_root}/mips.bin" -loader BinaryLoader -processor MIPS:LE:32:default \
-            -noanalysis -readOnly -deleteProject \
-            -scriptPath "${GITHUB_WORKSPACE}/tests/conformance/ghidra;${GITHUB_WORKSPACE}/bridge/ghidra" \
-            -postScript ReaInstructionContextProbe.java "${GITHUB_WORKSPACE}/bridge/ghidra" mips \
-            > "${probe_root}/mips-output.log" 2>&1 || { cat "${probe_root}/mips-output.log"; exit 1; }
-          cat "${probe_root}/mips-output.log"
-          grep -F 'REA_MIPS_CONTEXT_OK standard=0 mips16=1' "${probe_root}/mips-output.log"
       # Each probe imports source-owned bytes at 0x1000, away from the Cortex-M
       # vector symbols that ARMCortex.pspec defines at 0, and decodes them from
       # the language's default context, so M-profile Thumb state must hold at

docs/specs/README.md

@@ -26,7 +26,6 @@ for new work, roadmap granularity and producer-owned contracts.
 - [Native call source coordinates](native/call-source-locations/spec.md) ([plan](native/call-source-locations/plan.md), [tasks](native/call-source-locations/tasks.md), [verification](native/call-source-locations/verification.md))
 - [Go static string-header literal recovery](native/go-string-literals/spec.md) ([plan](native/go-string-literals/plan.md), [tasks](native/go-string-literals/tasks.md))
 - [Windows Shell Link shortcut inspection](native/windows-shortcut/spec.md) ([plan](native/windows-shortcut/plan.md), [tasks](native/windows-shortcut/tasks.md))
-- [NTFS $MFT and USN Journal inspection](native/ntfs-mft/spec.md) ([plan](native/ntfs-mft/plan.md), [tasks](native/ntfs-mft/tasks.md))
 - [Solidity terminal metadata inspection](solidity/cbor-metadata/spec.md) ([plan](solidity/cbor-metadata/plan.md), [tasks](solidity/cbor-metadata/tasks.md), [verification](solidity/cbor-metadata/verification.md))
 - [Inspect a V8 code cache container](v8/code-cache-inspection/spec.md) ([plan](v8/code-cache-inspection/plan.md), [tasks](v8/code-cache-inspection/tasks.md))
 - [Deno compile executable inventory and extraction](artifacts/deno-standalone/spec.md) ([plan](artifacts/deno-standalone/plan.md), [tasks](artifacts/deno-standalone/tasks.md))

docs/specs/native/ntfs-mft/plan.md

@@ -1,39 +0,0 @@
-# Implementation plan
-
-## Boundary and contract
-
-Follow the existing artifact readers. `src/domain/windows/ntfsMft.ts` owns FILE
-record bytes and coverage; `src/domain/artifactFormatMetadata.ts` owns the
-`ntfs-mft` result schema. `NtfsMftArtifactReader` reads the admitted file
-through `ArtifactFileSource` and exposes its facts through `formatMetadata()`.
-A record stream is its own content, so the root occurrence carries every fact
-and no members are enumerated.
-
-Recognition lives in `hasMftFileRecordSignature` and is applied in
-`classifyArtifactBytes`, next to the other unambiguous magic probes.
-
-## Incremental work and validation
-
-1. Define the first-step contract, limits and observations; add parser fixtures.
-2. Implement the FILE record header and update-sequence fixup parse with
-   explicit limitations.
-3. Add the reader, format descriptor and byte classification.
-4. Decode attribute records, then `$FILE_NAME` attributes so a record's parent
-   reference, names and timestamps become explicit; keep hard links separate.
-5. Parse `$UsnJrnl:$J` records and correlate them to records by full file
-   reference, including sequence numbers, reporting unresolved references.
-6. Document the workflow in a native Windows artifact guide.
-
-## Effects and compatibility
-
-The workflow reads one caller-selected local file. It adds no target execution,
-injection, mutation, protection recovery, network access, volume mount or live
-filesystem access, so no maintainer scope decision is required.
-`inspect_artifact` routing for every existing format is unchanged, and the new
-format id appears only for bytes whose first record carries the `FILE`
-signature.
-
-## References
-
-- https://learn.microsoft.com/en-us/windows/win32/fileio/master-file-table
-- https://github.com/libyal/libfsntfs/blob/main/documentation/New%20Technologies%20File%20System%20(NTFS).asciidoc

docs/specs/native/ntfs-mft/spec.md

@@ -1,51 +0,0 @@
-# NTFS $MFT and USN Journal inspection
-
-This specification records an implementation increment and its original problem
-statement. For current behavior and limitations, see the artifact inventory
-guide.
-
-## Problem and outcome
-
-REA has no reader for acquired NTFS metadata artifacts. An analyst holding a
-captured `$MFT` stream cannot ask which FILE records it contains, whether their
-update-sequence fixups survived acquisition, or which records are directories,
-extensions of another record, or no longer in use. Add offline, read-only
-inventory of a selected `$MFT` file, delivered in steps so each one merges on
-its own.
-
-## Requirements
-
-- Recognize a `$MFT` stream by a plausible first `FILE` record header under
-  any file name. CLI and MCP target admission route it to the artifact reader.
-- Validate each FILE record header: the `FILE` signature, sequence number, flags,
-  used and total byte counts, base record reference, and the update-sequence
-  array's offset, count and array bounds.
-- Verify the update-sequence fixups: every sector trailer the array covers must
-  hold the array's sequence number. A mismatch keeps the record's header facts
-  and is reported per record and in the metadata count.
-- Report a missing, misplaced or short update-sequence array as unverified
-  rather than as a clean record, and a trailing partial record as a byte count.
-- Report the first invalid record signature and the number of invalid slots.
-  Continue at the next slot when the stream declared a supported record size.
-  With a fallback record size, stop at the first invalid signature.
-- Bound the whole file at a fixed 512 MiB ceiling and report the ceiling as a
-  `limit` failure with its boundary.
-- Return the first 32 decoded record headers with their source offsets and the
-  number of omitted headers. Aggregate counts cover the full parsed stream.
-- Parse only the records' headers and fixups. Attributes, filenames, data
-  streams and the `$UsnJrnl:$J` journal are not decoded in this step, so no path,
-  file size, file reference correlation or change history is claimed.
-
-## Acceptance
-
-Synthesized fixtures cover a clean record, a failed fixup, a missing update
-sequence array, an array shorter than the record's sector count, extension and
-directory records, a record whose signature is wrong mid-stream, a trailing
-partial record, an undeclared record size, a 4 KiB record, a stream shorter than
-one header, bytes without the `FILE` signature, and the file-size ceiling.
-Inventory tests cover the root occurrence's metadata and the coverage status
-when a fixup fails, and classification tests cover several file names for the
-same bytes.
-
-Not covered in this step: real `$MFT` files written by a Windows host, USN
-journal records, attribute decoding, and any correlation between the two.

docs/specs/native/ntfs-mft/tasks.md

@@ -1,11 +0,0 @@
-# Tasks
-
-- [x] Define the first-step scope, contract and limits.
-- [x] Parse FILE record headers and update-sequence fixups with synthesized
-      fixtures and explicit limitations.
-- [x] Add the reader, format descriptor and byte classification.
-- [ ] Decode attribute records, then `$FILE_NAME` attributes with parent
-      references, names, hard links and timestamps.
-- [ ] Parse `$UsnJrnl:$J` records and correlate them to records by full file
-      reference.
-- [ ] Verify against real `$MFT` and journal captures from a Windows host.

scripts/ci/scopes.mjs

@@ -636,7 +636,7 @@ const PATH_SCOPES = {
     "src/ghidra/GhidraJavaProperties.ts",
     "src/ghidra/GhidraReleasePolicy.ts",
     "scripts/verify-ghidra-bridge-sources.mjs",
-    "tests/conformance/ghidra/ReaInstructionContextProbe.java",
+    "tests/conformance/ghidra/ReaArmContextProbe.java",
     "tests/conformance/ghidra/ReaComputedCallCoverageProbe.java",
     "tests/conformance/ghidra/ReaDecodeProbe.java",
     ".github/workflows/ghidra-bridge-sources.yml",

scripts/verify-qlog-captures.mjs

@@ -50,7 +50,7 @@ transport.stderr?.on("data", (bytes) => {
 const ajv = new Ajv2020({ strict: false, validateFormats: false });
 const measurements = [];
 const contract = toolContract("inspect_web_network_capture");
-const report = await withVerifierCleanup(async () => {
+await withVerifierCleanup(async () => {
   try {
     await client.connect(transport);
   } catch (cause) {
@@ -196,7 +196,7 @@ const report = await withVerifierCleanup(async () => {
     });
   }
   await client.ping();
-  return {
+  const report = {
     status: "passed",
     profile: "aioquic-1.5.0-json-0.3",
     measurements,
@@ -206,6 +206,17 @@ const report = await withVerifierCleanup(async () => {
       "No PCAP or keylog is read by this verifier; repeated STREAM coverage is not proof of retransmission or network loss.",
     ],
   };
+  await writeFile(reportPath, JSON.stringify(report, null, 2) + "\n", {
+    flag: "wx",
+    mode: 0o600,
+  });
+  console.log(
+    JSON.stringify({
+      status: report.status,
+      cases: measurements.length,
+      report: reportPath,
+    }),
+  );
 }, [
   async () => {
     await closeVerifierResources([
@@ -214,15 +225,3 @@ const report = await withVerifierCleanup(async () => {
     ]);
   },
 ]);
-
-await writeFile(reportPath, JSON.stringify(report, null, 2) + "\n", {
-  flag: "wx",
-  mode: 0o600,
-});
-console.log(
-  JSON.stringify({
-    status: report.status,
-    cases: measurements.length,
-    report: reportPath,
-  }),
-);

src/application/BinaryTargetResolver.ts

@@ -97,7 +97,6 @@ import {
   isDfuSeFile,
 } from "../domain/firmware/dfuse.js";
 import { hasFitImagesNode } from "../domain/firmware/fitImage.js";
-import { hasMftFileRecordHeader } from "../domain/windows/ntfsMft.js";
 import {
   locateEspFlashLayout,
   type EspFlashSelection,
@@ -817,7 +816,6 @@ const detectArtifactFormat = async (
     });
   if (esp === "esp-image") return "esp-image";
   if (hasFitImagesNode(magic)) return "fit";
-  if (hasMftFileRecordHeader(magic)) return "ntfs-mft";
   // Binary plists, including keyed archives, often use other extensions.
   if (hasBinaryPlistSignature(magic)) return "plist";
   const named = namedArtifactFormat(lower);
@@ -901,7 +899,6 @@ const isArchiveFormat = (
     "dfuse",
     "esp-flash-image",
     "fit",
-    "ntfs-mft",
   ].includes(format);
 
 /** Whether the leading bytes begin any executable header family, valid or not. */

src/application/binary/TargetFormatVocabularies.test.ts

@@ -135,7 +135,6 @@ const TARGETS: TargetFixtures = {
     espFlash: { selected: true, flashOffset: null, partitionTableOffset: null },
   },
   fit: { ...archive, format: "fit" },
-  "ntfs-mft": { ...archive, format: "ntfs-mft" },
   plist: { ...artifact, format: "plist" },
   javascript: { ...artifact, format: "javascript" },
   "source-map": { ...artifact, format: "source-map" },

src/artifacts/ArtifactReader.ts

@@ -215,7 +215,6 @@ export interface ArtifactReader {
     | "dfuse"
     | "esp-flash-image"
     | "fit"
-    | "ntfs-mft"
     | "file";
   entries(
     signal?: AbortSignal,

src/artifacts/DecodedRegionArtifactReader.ts

@@ -18,10 +18,7 @@ import {
   type ArtifactTraversalOptions,
 } from "./ArtifactReader.js";
 import { ArtifactResourceScope } from "./ArtifactResourceScope.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
+import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
 import { ArtifactFileSource } from "./ArtifactFileSource.js";
 import { readFileHandleChunks } from "../filesystem/readFileHandleChunks.js";
 import type { StableRegularFileDescriptor } from "../filesystem/RegularFile.js";
@@ -67,14 +64,12 @@ export const regionFileName = (start: number, end: number): string =>
  */
 export class DecodedRegionArtifactReader<Image> implements ArtifactReader {
   readonly #scope = new ArtifactResourceScope();
-  #entries = new Map<string, ArtifactEntry>();
-  #regions = new Map<string, Uint8Array>();
+  readonly #entries = new Map<string, ArtifactEntry>();
+  readonly #regions = new Map<string, Uint8Array>();
   readonly #streams = new Set<Readable>();
   readonly #source: ArtifactFileSource;
   readonly #decoding: RegionDecoding<Image>;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
+  #prepared: Promise<void> | undefined;
   /** Whole-file facts only; the region map is the sole owner of region bytes. */
   #described: Omit<DecodedRegions, "regions"> | undefined;
   #closing = false;
@@ -115,27 +110,8 @@ export class DecodedRegionArtifactReader<Image> implements ArtifactReader {
   ): AsyncIterable<ArtifactEntry> {
     await this.#scope.run(async () => {
       this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
+      this.#prepared ??= this.#prepare(signal);
+      await this.#prepared;
       await this.#source.read(signal);
     });
     const coverage = this.#described?.coverage;
@@ -254,8 +230,6 @@ export class DecodedRegionArtifactReader<Image> implements ArtifactReader {
 
   async #prepare(signal?: AbortSignal): Promise<void> {
     const described = this.#decoding.describe(await this.#decode(signal));
-    const entries = new Map<string, ArtifactEntry>();
-    const regions = new Map<string, Uint8Array>();
     let index = 0;
     for (const region of described.regions) {
       if (index % 256 === 0) await setImmediate();
@@ -274,16 +248,13 @@ export class DecodedRegionArtifactReader<Image> implements ArtifactReader {
         adapterKey: `${this.#decoding.keyPrefix}:${String(index)}`,
         formatMetadata: region.formatMetadata,
       } satisfies ArtifactEntry;
-      entries.set(entry.adapterKey, entry);
-      regions.set(entry.adapterKey, region.bytes);
+      this.#entries.set(entry.adapterKey, entry);
+      this.#regions.set(entry.adapterKey, region.bytes);
       index += 1;
     }
     const { regions: _regions, ...facts } = described;
-    await this.#source.read(signal);
-    this.#assertOpen(signal);
-    this.#entries = entries;
-    this.#regions = regions;
     this.#described = facts;
+    await this.#source.read(signal);
   }
 
   async #decode(signal?: AbortSignal): Promise<Image> {

src/artifacts/FitArtifactReader.test.ts

@@ -1,4 +1,3 @@
-import { artifactPreparationRecoveryCases } from "../../tests/fixtures/artifactReaderLifecycle.js";
 import { getEventListeners, once } from "node:events";
 import { readFile, truncate, writeFile } from "node:fs/promises";
 import { join } from "node:path";
@@ -405,38 +404,6 @@ it("keeps the cancellation reason before admission", async () => {
   }
 });
 
-it("does not publish FIT entries when final source verification fails", async () => {
-  const path = await writeFit("partial-publication.itb", FIT_EMBEDDED);
-  const control = new FitArtifactReader(path);
-  const reader = new FitArtifactReader(path);
-  const expected = await firstEntry(control);
-  const nativeRead = ArtifactFileSource.prototype.read;
-  const physical = Object.assign(
-    new Error("final source verification failed"),
-    { code: "EIO" },
-  );
-  let calls = 0;
-  const read = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementation(function (this: ArtifactFileSource, ...args) {
-      calls += 1;
-      if (calls === 4) return Promise.reject(physical);
-      return nativeRead.apply(this, args);
-    });
-  try {
-    await expect(firstEntry(reader)).rejects.toBe(physical);
-    await expect(reader.open(expected)).rejects.toMatchObject({
-      reason: "integrity",
-    });
-    read.mockRestore();
-    expect((await firstEntry(reader)).path).toBe(expected.path);
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await control.close();
-  }
-});
-
 it("keeps the cancellation reason during hash verification", async () => {
   const reader = new FitArtifactReader(
     await writeFit("hashing.itb", LARGE_FIT),
@@ -463,8 +430,6 @@ it("keeps the cancellation reason during hash verification", async () => {
       reader.entries(controller.signal)[Symbol.asyncIterator]().next(),
     ).rejects.toMatchObject({ reason: "cancelled", cause: reason });
     expect(observer).toHaveBeenCalledWith("sha256");
-    observer.mockRestore();
-    expect((await firstEntry(reader)).kind).toBe("file");
   } finally {
     observer.mockRestore();
     await reader.close();
@@ -604,8 +569,3 @@ it("preserves a final validation failure when cancellation overlaps it", async (
     await reader.close();
   }
 });
-
-artifactPreparationRecoveryCases({
-  image: () => FIT_EMBEDDED,
-  createReader: (path, admitted) => new FitArtifactReader(path, admitted),
-});

src/artifacts/FitArtifactReader.ts

@@ -13,10 +13,7 @@ import {
   type ArtifactTraversalOptions,
 } from "./ArtifactReader.js";
 import { ArtifactResourceScope } from "./ArtifactResourceScope.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
+import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
 import { ArtifactFileSource } from "./ArtifactFileSource.js";
 import {
   createFitDigest,
@@ -33,13 +30,11 @@ const FDT_HEADER_BYTES = 40;
 export class FitArtifactReader implements ArtifactReader {
   readonly format = "fit" as const;
   readonly #scope = new ArtifactResourceScope();
-  #entries = new Map<string, ArtifactEntry>();
+  readonly #entries = new Map<string, ArtifactEntry>();
   readonly #streams = new Set<Readable>();
   readonly #path: string;
   readonly #source: ArtifactFileSource;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
+  #prepared: Promise<void> | undefined;
   #metadata: FitMetadata | undefined;
   #coverage: ArtifactReaderTraversal | undefined;
   #closing = false;
@@ -71,27 +66,8 @@ export class FitArtifactReader implements ArtifactReader {
   ): AsyncIterable<ArtifactEntry> {
     await this.#scope.run(async () => {
       this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
+      this.#prepared ??= this.#prepare(signal);
+      await this.#prepared;
       await this.#source.read(signal);
     });
     if (this.#coverage !== undefined)
@@ -231,7 +207,6 @@ export class FitArtifactReader implements ArtifactReader {
       this.#path,
       initial.size,
     );
-    const entries = new Map<string, ArtifactEntry>();
     let index = 0;
     for (const image of structure.images) {
       if (index % 256 === 0) await setImmediate();
@@ -253,17 +228,15 @@ export class FitArtifactReader implements ArtifactReader {
         adapterKey: `fit:${String(image.index)}`,
         formatMetadata: image.metadata,
       } satisfies ArtifactEntry;
-      entries.set(entry.adapterKey, entry);
+      this.#entries.set(entry.adapterKey, entry);
     }
-    await this.#source.read(signal);
-    this.#assertOpen(signal);
-    this.#entries = entries;
     this.#metadata = structure.metadata;
     if (structure.limitations.length > 0)
       this.#coverage = {
         status: "complete",
         limitations: structure.limitations,
       };
+    await this.#source.read(signal);
   }
 
   /** One streamed pass per image feeds every supported digest. */

src/artifacts/HexRecordArtifactReader.test.ts

@@ -1,6 +1,3 @@
-import { artifactPreparationRecoveryCases } from "../../tests/fixtures/artifactReaderLifecycle.js";
-import { ArtifactFileSource } from "./ArtifactFileSource.js";
-import { openRegularFile } from "../filesystem/RegularFile.js";
 import { writeFile } from "node:fs/promises";
 import { join } from "node:path";
 
@@ -162,72 +159,6 @@ it("settles an active region stream when closed", async () => {
   }
 });
 
-it("retries decoded-region preparation cancelled while reading", async () => {
-  const path = await writeImage("retry.hex", INTEL_HEX_I32_GAP);
-  const admitted = await openRegularFile(path, { symlinks: "reject" });
-  const reader = new HexRecordArtifactReader(path, "intel-hex", admitted);
-  const controller = new AbortController();
-  const reason = { stage: "decoded region read" };
-  const nativeRead = admitted.handle.read.bind(admitted.handle);
-  const read = vi.spyOn(admitted.handle, "read").mockImplementation((async (
-    ...args: unknown[]
-  ) => {
-    const result = await Reflect.apply(nativeRead, admitted.handle, args);
-    controller.abort(reason);
-    return result;
-  }) as typeof admitted.handle.read);
-  try {
-    await expect(
-      reader.entries(controller.signal)[Symbol.asyncIterator]().next(),
-    ).rejects.toMatchObject({ reason: "cancelled", cause: reason });
-    read.mockRestore();
-    expect(
-      (await reader.entries()[Symbol.asyncIterator]().next()).value,
-    ).toMatchObject({ kind: "file" });
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await admitted.handle.close();
-  }
-});
-
-it("does not publish decoded regions when final source verification fails", async () => {
-  const path = await writeImage("partial.hex", INTEL_HEX_I32_GAP);
-  const control = new HexRecordArtifactReader(path, "intel-hex");
-  const reader = new HexRecordArtifactReader(path, "intel-hex");
-  const expected = (await control.entries()[Symbol.asyncIterator]().next())
-    .value!;
-  const nativeRead = ArtifactFileSource.prototype.read;
-  const physical = Object.assign(
-    new Error("final source verification failed"),
-    { code: "EIO" },
-  );
-  let calls = 0;
-  const read = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementation(function (this: ArtifactFileSource, ...args) {
-      calls += 1;
-      if (calls === 2) return Promise.reject(physical);
-      return nativeRead.apply(this, args);
-    });
-  try {
-    await expect(reader.entries()[Symbol.asyncIterator]().next()).rejects.toBe(
-      physical,
-    );
-    await expect(reader.open(expected)).rejects.toMatchObject({
-      reason: "integrity",
-    });
-    read.mockRestore();
-    expect(
-      (await reader.entries()[Symbol.asyncIterator]().next()).value,
-    ).toMatchObject({ path: expected.path });
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await control.close();
-  }
-});
-
 it("honors cancellation before admitting a file with the exact reason", async () => {
   const reader = new HexRecordArtifactReader(
     await writeImage("cancel.hex", INTEL_HEX_I32_GAP),
@@ -406,9 +337,3 @@ it("bounds copied region chunks and isolates cached bytes across opens", async (
     await reader.close();
   }
 });
-
-artifactPreparationRecoveryCases({
-  image: () => Buffer.from(INTEL_HEX_I32_GAP),
-  createReader: (path, admitted) =>
-    new HexRecordArtifactReader(path, "intel-hex", admitted),
-});

src/artifacts/NtfsMftArtifactReader.test.ts

@@ -1,211 +0,0 @@
-import { writeFile } from "node:fs/promises";
-import { join } from "node:path";
-
-import { expect, it, vi } from "vitest";
-
-import { ArtifactFileSource } from "./ArtifactFileSource.js";
-import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
-import { NtfsMftArtifactReader } from "./NtfsMftArtifactReader.js";
-
-import { MFT_DEFAULT_RECORD_BYTES } from "../domain/windows/ntfsMft.js";
-import { createTestTempDirectory } from "../../tests/fixtures/temporaryDirectory.js";
-import { scanCanonicalArtifactInventory } from "../../tests/fixtures/artifactInventory.js";
-
-/** A 1 KiB FILE record whose update sequence array covers both sectors. */
-const recordBytes = (options: {
-  readonly sequenceNumber?: number;
-  readonly flags?: number;
-  readonly index?: number;
-}): Buffer => {
-  const record = Buffer.alloc(MFT_DEFAULT_RECORD_BYTES);
-  record.write("FILE", 0, "latin1");
-  const sequenceNumber = options.sequenceNumber ?? 1;
-  record.writeUInt16LE(48, 4);
-  record.writeUInt16LE(3, 6);
-  record.writeUInt16LE(sequenceNumber, 48);
-  record.writeUInt16LE(0xa5a5, 50);
-  record.writeUInt16LE(0xa5a5, 52);
-  record.writeUInt16LE(sequenceNumber, 16);
-  record.writeUInt16LE(1, 18);
-  record.writeUInt32LE(options.index ?? 0, 44);
-  record.writeUInt16LE(56, 20);
-  record.writeUInt16LE(options.flags ?? 0x0001, 22);
-  record.writeUInt32LE(64, 24);
-  record.writeUInt32LE(0xffff_ffff, 56);
-  record.writeUInt32LE(MFT_DEFAULT_RECORD_BYTES, 28);
-  record.writeUInt16LE(sequenceNumber, 510);
-  record.writeUInt16LE(sequenceNumber, 1022);
-  return record;
-};
-
-const writeMft = async (name: string, bytes: Buffer): Promise<string> => {
-  const directory = await createTestTempDirectory("rea-ntfs-mft-");
-  const path = join(directory, name);
-  await writeFile(path, bytes);
-  return path;
-};
-
-it("reports a $MFT stream's record headers as the root occurrence", async () => {
-  const inventory = await scanCanonicalArtifactInventory(
-    await writeMft(
-      "$MFT",
-      Buffer.concat([
-        recordBytes({}),
-        recordBytes({ flags: 0x0003, index: 1 }),
-      ]),
-    ),
-  );
-  expect(inventory.manifest.root_format).toBe("ntfs-mft");
-  expect(inventory.coverage.status).toBe("complete");
-  // A record stream declares no members, so the root is its whole inventory.
-  expect(inventory.occurrences.map((row) => row.logical_path)).toEqual(["."]);
-  expect(inventory.occurrences[0]).toMatchObject({
-    artifact_format: "ntfs-mft",
-    format_metadata: {
-      kind: "ntfs-mft",
-      record_bytes: MFT_DEFAULT_RECORD_BYTES,
-      record_count: 2,
-      in_use_record_count: 2,
-      directory_record_count: 1,
-      extension_record_count: 0,
-      fixup_mismatch_count: 0,
-      fixup_unverified_record_count: 0,
-      truncated_tail_bytes: 0,
-    },
-  });
-});
-
-it("names a failed fixup in the coverage limitations", async () => {
-  const record = recordBytes({ sequenceNumber: 4 });
-  // A trailer that is not the sequence number marks the sector as not cleanly written.
-  record.writeUInt16LE(0x1234, 510);
-  const inventory = await scanCanonicalArtifactInventory(
-    await writeMft("$MFT", record),
-  );
-  expect(inventory.manifest.root_format).toBe("ntfs-mft");
-  expect(inventory.coverage.status).toBe("unknown");
-  expect(inventory.limitations).toContainEqual(
-    expect.stringMatching(/sector trailer that is not the update sequence/u),
-  );
-});
-
-it("reports an unaligned used-byte count as incomplete coverage", async () => {
-  const record = recordBytes({});
-  record.writeUInt32LE(57, 24);
-  const inventory = await scanCanonicalArtifactInventory(
-    await writeMft("$MFT", record),
-  );
-  expect(inventory.coverage.status).toBe("unknown");
-  expect(inventory.occurrences[0]?.format_metadata).toMatchObject({
-    record_headers: [{ usedBytes: 57, extentValid: false }],
-  });
-});
-
-it("reports incomplete coverage when FILE extents contradict the record slots", async () => {
-  const usedTooLarge = recordBytes({});
-  usedTooLarge.writeUInt32LE(4096, 24);
-  const totalTooSmall = recordBytes({});
-  totalTooSmall.writeUInt32LE(512, 28);
-
-  const inventory = await scanCanonicalArtifactInventory(
-    await writeMft("$MFT", Buffer.concat([usedTooLarge, totalTooSmall])),
-  );
-  expect(inventory.coverage.status).toBe("unknown");
-  expect(inventory.limitations).toContainEqual(
-    "2 FILE record(s) declare inconsistent record extents, beginning at offset 0",
-  );
-  expect(inventory.occurrences[0]?.format_metadata).toMatchObject({
-    record_count: 2,
-    fixup_mismatch_count: 0,
-    fixup_unverified_record_count: 0,
-  });
-});
-
-it("retries after final source verification fails without publishing its metadata", async () => {
-  const reader = new NtfsMftArtifactReader(
-    await writeMft("$MFT", recordBytes({})),
-  );
-  const read = ArtifactFileSource.prototype.read;
-  const spy = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementationOnce(function (this: ArtifactFileSource, signal) {
-      return read.call(this, signal);
-    })
-    .mockRejectedValueOnce(new Error("final source verification failed"));
-  try {
-    await expect(
-      reader.entries()[Symbol.asyncIterator]().next(),
-    ).rejects.toThrow("final source verification failed");
-    expect(reader.formatMetadata()).toBeUndefined();
-    await expect(
-      reader.entries()[Symbol.asyncIterator]().next(),
-    ).resolves.toMatchObject({
-      done: true,
-    });
-    expect(reader.formatMetadata()).toMatchObject({
-      kind: "ntfs-mft",
-      record_count: 1,
-    });
-  } finally {
-    spy.mockRestore();
-    await reader.close();
-  }
-});
-
-it("retries a shared preparation cancelled by another traversal", async () => {
-  const reader = new NtfsMftArtifactReader(
-    await writeMft("$MFT", recordBytes({})),
-  );
-  const controller = new AbortController();
-  let entered: () => void = () => {};
-  const started = new Promise<void>((resolve) => {
-    entered = resolve;
-  });
-  const read = ArtifactFileSource.prototype.read;
-  const spy = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementationOnce(async function (this: ArtifactFileSource, signal) {
-      entered();
-      await new Promise<void>((resolve) => {
-        signal?.addEventListener("abort", () => resolve(), { once: true });
-      });
-      assertArtifactReadActive(signal);
-      return read.call(this, signal);
-    });
-  try {
-    const cancelled = reader
-      .entries(controller.signal)
-      [Symbol.asyncIterator]()
-      .next();
-    const cancelledResult = expect(cancelled).rejects.toMatchObject({
-      reason: "cancelled",
-    });
-    await started;
-    const other = reader.entries()[Symbol.asyncIterator]().next();
-    controller.abort("cancelled first traversal");
-    await cancelledResult;
-    await expect(other).resolves.toMatchObject({ done: true });
-    expect(reader.formatMetadata()).toMatchObject({ record_count: 1 });
-  } finally {
-    controller.abort();
-    spy.mockRestore();
-    await reader.close();
-  }
-});
-
-it("revalidates the source before reusing a completed header inventory", async () => {
-  const path = await writeMft("$MFT", recordBytes({}));
-  const reader = new NtfsMftArtifactReader(path);
-  try {
-    await reader.entries()[Symbol.asyncIterator]().next();
-    await writeFile(
-      path,
-      Buffer.concat([recordBytes({}), recordBytes({ index: 1 })]),
-    );
-    await expect(
-      reader.entries()[Symbol.asyncIterator]().next(),
-    ).rejects.toMatchObject({ reason: "integrity" });
-  } finally {
-    await reader.close();
-  }
-});

src/artifacts/NtfsMftArtifactReader.ts

@@ -1,174 +0,0 @@
-import type { Readable } from "node:stream";
-
-import {
-  ntfsMftMetadataSchema,
-  type ArtifactFormatMetadata,
-} from "../domain/artifactFormatMetadata.js";
-import type { RegionDecodeFailure } from "../domain/firmware/regionDecoder.js";
-import {
-  createMftDecoder,
-  type MftInventory,
-} from "../domain/windows/ntfsMft.js";
-import {
-  ArtifactReaderFailure,
-  type ArtifactEntry,
-  type ArtifactReader,
-  type ArtifactReaderTraversal,
-  type ArtifactTraversalOptions,
-} from "./ArtifactReader.js";
-import { ArtifactResourceScope } from "./ArtifactResourceScope.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
-import { ArtifactFileSource } from "./ArtifactFileSource.js";
-import { readFileHandleChunks } from "../filesystem/readFileHandleChunks.js";
-import type { StableRegularFileDescriptor } from "../filesystem/RegularFile.js";
-
-/**
- * An MFT stream is its own content: the FILE records describe the source
- * volume, not members inside the stream, so header facts are attached to
- * the root occurrence.
- */
-export class NtfsMftArtifactReader implements ArtifactReader {
-  readonly format = "ntfs-mft" as const;
-  readonly #scope = new ArtifactResourceScope();
-  readonly #source: ArtifactFileSource;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
-  #metadata: ArtifactFormatMetadata | undefined;
-  #limitations: readonly string[] = [];
-  #closing = false;
-
-  constructor(path: string, admitted?: StableRegularFileDescriptor) {
-    this.#source = new ArtifactFileSource(path, "$MFT stream", admitted);
-  }
-
-  formatMetadata(): ArtifactFormatMetadata | undefined {
-    return this.#metadata === undefined
-      ? undefined
-      : structuredClone(this.#metadata);
-  }
-
-  async prepareContainer(
-    expectedSha256: string,
-    signal?: AbortSignal,
-  ): Promise<void> {
-    await this.#scope.run(async () => {
-      this.#assertOpen(signal);
-      await this.#source.bindSha256(expectedSha256, signal);
-    });
-  }
-
-  async *entries(
-    signal?: AbortSignal,
-    options?: ArtifactTraversalOptions,
-  ): AsyncIterable<ArtifactEntry> {
-    await this.#scope.run(async () => {
-      this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
-      this.#assertOpen(signal);
-      await this.#source.read(signal);
-    });
-    // An MFT declares no members, so the root occurrence is the whole
-    // inventory; the coverage callback reports what its parse did not establish.
-    options?.onCoverage?.(coverageOf(this.#limitations));
-  }
-
-  async open(entry: ArtifactEntry, _signal?: AbortSignal): Promise<Readable> {
-    return this.#scope.run(async () => {
-      throw new ArtifactReaderFailure(
-        "unavailable",
-        `$MFT stream declares no member to open for ${entry.path}`,
-      );
-    });
-  }
-
-  async close(): Promise<void> {
-    this.#closing = true;
-    await this.#scope.close();
-    await this.#source.close();
-    this.#metadata = undefined;
-  }
-
-  provenance(): readonly [] {
-    return [];
-  }
-
-  #assertOpen(signal?: AbortSignal): void {
-    assertArtifactReadActive(signal);
-    if (this.#closing)
-      throw new ArtifactReaderFailure(
-        "unavailable",
-        "$MFT stream reader is closed",
-      );
-  }
-
-  async #prepare(signal?: AbortSignal): Promise<void> {
-    const image = await this.#decode(signal);
-    await this.#source.read(signal);
-    this.#metadata = ntfsMftMetadataSchema.parse(image.metadata);
-    this.#limitations = image.limitations;
-  }
-
-  async #decode(signal?: AbortSignal): Promise<MftInventory> {
-    const { handle, initial } = await this.#source.read(signal);
-    const decoder = createMftDecoder(initial.size);
-    if (!decoder.ok) throw this.#failure(decoder.error);
-    if (initial.size > 0)
-      for await (const chunk of readFileHandleChunks(handle, {
-        end: initial.size - 1,
-        signal,
-        cancellationFailure: (reason) =>
-          new ArtifactReaderFailure("cancelled", "$MFT stream read cancelled", {
-            cause: reason,
-          }),
-      }) as AsyncIterable<Buffer>) {
-        this.#assertOpen(signal);
-        const written = decoder.value.write(chunk);
-        if (!written.ok) throw this.#failure(written.error);
-      }
-    const image = decoder.value.finish();
-    if (!image.ok) throw this.#failure(image.error);
-    return image.value;
-  }
-
-  #failure(failure: RegionDecodeFailure): ArtifactReaderFailure {
-    return failure.kind === "format"
-      ? new ArtifactReaderFailure(
-          "format",
-          `$MFT stream is malformed: ${failure.message}`,
-        )
-      : new ArtifactReaderFailure(
-          "limit",
-          `$MFT stream exceeds a fixed limit: ${failure.message}`,
-          failure.boundary === undefined ? {} : { boundary: failure.boundary },
-        );
-  }
-}
-
-const coverageOf = (limitations: readonly string[]): ArtifactReaderTraversal =>
-  limitations.length === 0
-    ? { status: "complete", limitations: [] }
-    : { status: "unknown", limitations };

src/artifacts/UImageArtifactReader.boundaries.test.ts

@@ -1,7 +1,4 @@
-import {
-  artifactPreparationRecoveryCases,
-  artifactReaderLifecycleCases,
-} from "../../tests/fixtures/artifactReaderLifecycle.js";
+import { artifactReaderLifecycleCases } from "../../tests/fixtures/artifactReaderLifecycle.js";
 import { writeFile } from "node:fs/promises";
 import { join } from "node:path";
 import { buffer } from "node:stream/consumers";
@@ -94,14 +91,6 @@ it("preserves cancellation during payload CRC admission", async () => {
         }
       })(),
     ).rejects.toMatchObject({ reason: "cancelled", cause: reason });
-    reads.mockRestore();
-    const recovered = await entries(reader);
-    expect(recovered).toHaveLength(1);
-    expect(
-      (await buffer(await reader.open(recovered[0]!))).equals(
-        Buffer.alloc(128 * 1024, 0x61),
-      ),
-    ).toBe(true);
   } finally {
     await reader.close();
     reads.mockRestore();
@@ -216,8 +205,3 @@ it("reports impossible over-cap component extents as malformed", async () => {
     await reader.close();
   }
 });
-
-artifactPreparationRecoveryCases({
-  image: () => buildUImage({ payload: Buffer.from("payload") }),
-  createReader: (path, admitted) => new UImageArtifactReader(path, admitted),
-});

src/artifacts/UImageArtifactReader.ts

@@ -8,10 +8,7 @@ import type {
   UImageMetadata,
 } from "../domain/artifactFormatMetadata.js";
 import { ArtifactFileSource } from "./ArtifactFileSource.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
+import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
 import {
   ArtifactReaderFailure,
   copyArtifactEntry,
@@ -50,9 +47,7 @@ export class UImageArtifactReader implements ArtifactReader {
   readonly #entries = new Map<string, UImageEntry>();
   readonly #streams = new Set<Readable>();
   readonly #source: ArtifactFileSource;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
+  #prepared: Promise<void> | undefined;
   #header: UImageMetadata | undefined;
   #closing = false;
 
@@ -80,27 +75,8 @@ export class UImageArtifactReader implements ArtifactReader {
   ): AsyncIterable<ArtifactEntry> {
     await this.#scope.run(async () => {
       this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
+      this.#prepared ??= this.#prepare(signal);
+      await this.#prepared;
       await this.#source.read(signal);
     });
     this.#assertOpen(signal);

src/artifacts/UnityFsArtifactReader.boundaries.test.ts

@@ -1,5 +1,3 @@
-import { artifactPreparationRecoveryCases } from "../../tests/fixtures/artifactReaderLifecycle.js";
-import { ArtifactFileSource } from "./ArtifactFileSource.js";
 import { truncate, writeFile } from "node:fs/promises";
 import { join } from "node:path";
 import { buffer, text } from "node:stream/consumers";
@@ -45,68 +43,6 @@ const repeatedBlock = (data: Buffer): Buffer => {
   ]);
 };
 
-it("retries UnityFs preparation cancelled during file reading", async () => {
-  const path = await fixture(buildUnityFs([{ path: "a", data: "x" }]));
-  const admitted = await openRegularFile(path, { symlinks: "reject" });
-  const reader = new UnityFsArtifactReader(path, admitted);
-  const controller = new AbortController();
-  const reason = { stage: "header read" };
-  const nativeRead = admitted.handle.read.bind(admitted.handle);
-  const read = vi.spyOn(admitted.handle, "read").mockImplementation((async (
-    ...args: unknown[]
-  ) => {
-    const result = await Reflect.apply(nativeRead, admitted.handle, args);
-    controller.abort(reason);
-    return result;
-  }) as typeof admitted.handle.read);
-  try {
-    await expect(
-      (async () => {
-        for await (const _ of reader.entries(controller.signal)) {
-        }
-      })(),
-    ).rejects.toMatchObject({ reason: "cancelled", cause: reason });
-    read.mockRestore();
-    expect((await entries(reader)).map((entry) => entry.path)).toEqual(["a"]);
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await admitted.handle.close();
-  }
-});
-
-it("does not publish UnityFs entries when final source verification fails", async () => {
-  const path = await fixture(buildUnityFs([{ path: "a", data: "x" }]));
-  const control = new UnityFsArtifactReader(path);
-  const reader = new UnityFsArtifactReader(path);
-  const expected = (await entries(control))[0]!;
-  const nativeRead = ArtifactFileSource.prototype.read;
-  const physical = Object.assign(
-    new Error("final source verification failed"),
-    { code: "EIO" },
-  );
-  let calls = 0;
-  const read = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementation(function (this: ArtifactFileSource, ...args) {
-      calls += 1;
-      if (calls === 2) return Promise.reject(physical);
-      return nativeRead.apply(this, args);
-    });
-  try {
-    await expect(entries(reader)).rejects.toBe(physical);
-    await expect(reader.open(expected)).rejects.toMatchObject({
-      reason: "integrity",
-    });
-    read.mockRestore();
-    expect((await entries(reader)).map((entry) => entry.path)).toEqual(["a"]);
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await control.close();
-  }
-});
-
 describe("UnityFS allocation and malformed-input boundaries", () => {
   it("rejects an oversized directory extending past the physical file", async () => {
     const bytes = buildUnityFs([{ path: "data", data: "x" }]);
@@ -495,8 +431,3 @@ describe("UnityFS stream capacity and cache ownership", () => {
     }
   });
 });
-
-artifactPreparationRecoveryCases({
-  image: () => buildUnityFs([{ path: "a", data: "x" }]),
-  createReader: (path, admitted) => new UnityFsArtifactReader(path, admitted),
-});

src/artifacts/UnityFsArtifactReader.ts

@@ -12,10 +12,7 @@ import {
   type ArtifactTraversalOptions,
 } from "./ArtifactReader.js";
 import { ArtifactResourceScope } from "./ArtifactResourceScope.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
+import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
 import { readArtifactFileBytes } from "./ArtifactFileRange.js";
 import type {
   ArtifactFormatMetadata,
@@ -55,12 +52,10 @@ interface UnityFsEntryState {
 export class UnityFsArtifactReader implements ArtifactReader {
   readonly format = "unityfs" as const;
   readonly #scope = new ArtifactResourceScope();
-  #entries = new Map<string, UnityFsEntryState>();
+  readonly #entries = new Map<string, UnityFsEntryState>();
   readonly #streams = new Map<Readable, AbortController>();
   readonly #source: ArtifactFileSource;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
+  #prepared: Promise<void> | undefined;
   #header: UnityFsMetadata | undefined;
   #blocks: readonly UnityFsBlock[] = [];
   #dataStart = 0;
@@ -93,27 +88,8 @@ export class UnityFsArtifactReader implements ArtifactReader {
   ): AsyncIterable<ArtifactEntry> {
     await this.#scope.run(async () => {
       this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
+      this.#prepared ??= this.#prepare(signal);
+      await this.#prepared;
       await this.#source.read(signal);
     });
     this.#assertOpen(signal);
@@ -253,7 +229,7 @@ export class UnityFsArtifactReader implements ArtifactReader {
     if (header === undefined)
       throw unityFsFormatFailure("no complete UnityFS header");
     const status = header.layout.status;
-    const metadata: UnityFsMetadata = {
+    this.#header = {
       kind: "unityfs",
       signature: "UnityFS",
       format_version: header.formatVersion,
@@ -269,12 +245,7 @@ export class UnityFsArtifactReader implements ArtifactReader {
       data_hash: null,
       directory_status: status,
     };
-    if (status !== "available") {
-      await this.#source.read(signal);
-      this.#assertOpen(signal);
-      this.#header = metadata;
-      return;
-    }
+    if (status !== "available") return;
     const { dataHash, blocks, nodes, dataStart } = await readUnityFsBlocksInfo(
       handle,
       header,
@@ -288,55 +259,44 @@ export class UnityFsArtifactReader implements ArtifactReader {
       if (streamBytes > BigInt(budget))
         throw expansionLimit("declared virtual stream", streamBytes, budget);
     }
-    const preparedMetadata: UnityFsMetadata = {
-      ...metadata,
+    this.#header = {
+      ...this.#header,
       data_hash: dataHash,
       block_count: blocks.length,
       data_start: dataStart,
     };
+    this.#dataStart = dataStart;
     // Keep the source block count above, but do not revisit zero-output rows
     // for every member. Parsed stream/compressed offsets remain authoritative.
-    const readableBlocks = blocks.filter((block) => block.uncompressedSize > 0);
-    const registered = await this.#registerNodes(
-      nodes,
-      readableBlocks,
-      budget,
-      signal,
-    );
-    await this.#source.read(signal);
-    this.#assertOpen(signal);
-    this.#header = preparedMetadata;
-    this.#dataStart = dataStart;
-    this.#blocks = readableBlocks;
+    this.#blocks = blocks.filter((block) => block.uncompressedSize > 0);
     this.#remainingDecodeBytes = budget;
-    this.#entries = registered.entries;
-    this.#remainingReadOperations = registered.remainingReadOperations;
+    await this.#registerNodes(nodes, budget, signal);
+    await this.#source.read(signal);
   }
 
   async #registerNodes(
     nodes: readonly UnityFsNode[],
-    blocks: readonly UnityFsBlock[],
     budget: number,
     signal?: AbortSignal,
-  ): Promise<{
-    entries: Map<string, UnityFsEntryState>;
-    remainingReadOperations: number;
-  }> {
-    const entries = new Map<string, UnityFsEntryState>();
+  ): Promise<void> {
     let readableBytes = 0n;
     for (let index = 0; index < nodes.length; index++) {
       if (index % 256 === 0) await setImmediate();
       this.#assertOpen(signal);
       const node = nodes[index]!;
       const firstBlock =
-        node.size === 0 ? -1 : blockEndingAfter(blocks, node.offset);
+        node.size === 0 ? -1 : blockEndingAfter(this.#blocks, node.offset);
       const lastBlock =
         node.size === 0
           ? -1
-          : blockEndingAfter(blocks, node.offset + node.size - 1);
+          : blockEndingAfter(this.#blocks, node.offset + node.size - 1);
       if (node.size !== 0 && (firstBlock < 0 || lastBlock < firstBlock))
         throw unityFsFormatFailure("member has no block range");
-      const unavailable = firstUnavailableBlock(blocks, firstBlock, lastBlock);
+      const unavailable = firstUnavailableBlock(
+        this.#blocks,
+        firstBlock,
+        lastBlock,
+      );
       const kind =
         (node.flags & 1) !== 0 ? ("directory" as const) : ("file" as const);
       if (kind === "file" && unavailable === undefined) {
@@ -371,7 +331,7 @@ export class UnityFsArtifactReader implements ArtifactReader {
           flags: node.flags,
         },
       } satisfies UnityFsEntry;
-      entries.set(adapterKey, {
+      this.#entries.set(adapterKey, {
         entry,
         firstBlock,
         lastBlock,
@@ -380,15 +340,14 @@ export class UnityFsArtifactReader implements ArtifactReader {
     }
     // Four ordinary passes over admitted blocks, nodes and plaintext chunks,
     // with a small-reader floor. Byte quotas alone cannot bound tiny-block I/O.
-    const remainingReadOperations =
+    this.#remainingReadOperations =
       4 *
       Math.max(
         1024,
-        blocks.length +
+        this.#blocks.length +
           nodes.length +
           Math.ceil(Number(readableBytes) / CHUNK_BYTES),
       );
-    return { entries, remainingReadOperations };
   }
 
   async *#memberChunks(

src/artifacts/WxapkgArtifactReader.boundaries.test.ts

@@ -1,5 +1,3 @@
-import { artifactPreparationRecoveryCases } from "../../tests/fixtures/artifactReaderLifecycle.js";
-import { ArtifactFileSource } from "./ArtifactFileSource.js";
 import { once } from "node:events";
 import { writeFile } from "node:fs/promises";
 import { join } from "node:path";
@@ -28,68 +26,6 @@ const entries = async (reader: WxapkgArtifactReader) => {
   return result;
 };
 
-it("retries Wxapkg preparation cancelled during file reading", async () => {
-  const path = await fixture(buildWxapkg([{ path: "a", data: "x" }]));
-  const admitted = await openRegularFile(path, { symlinks: "reject" });
-  const reader = new WxapkgArtifactReader(path, admitted);
-  const controller = new AbortController();
-  const reason = { stage: "header read" };
-  const nativeRead = admitted.handle.read.bind(admitted.handle);
-  const read = vi.spyOn(admitted.handle, "read").mockImplementation((async (
-    ...args: unknown[]
-  ) => {
-    const result = await Reflect.apply(nativeRead, admitted.handle, args);
-    controller.abort(reason);
-    return result;
-  }) as typeof admitted.handle.read);
-  try {
-    await expect(
-      (async () => {
-        for await (const _ of reader.entries(controller.signal)) {
-        }
-      })(),
-    ).rejects.toMatchObject({ reason: "cancelled", cause: reason });
-    read.mockRestore();
-    expect((await entries(reader)).map((entry) => entry.path)).toEqual(["a"]);
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await admitted.handle.close();
-  }
-});
-
-it("does not publish Wxapkg entries when final source verification fails", async () => {
-  const path = await fixture(buildWxapkg([{ path: "a", data: "x" }]));
-  const control = new WxapkgArtifactReader(path);
-  const reader = new WxapkgArtifactReader(path);
-  const expected = (await entries(control))[0]!;
-  const nativeRead = ArtifactFileSource.prototype.read;
-  const physical = Object.assign(
-    new Error("final source verification failed"),
-    { code: "EIO" },
-  );
-  let calls = 0;
-  const read = vi
-    .spyOn(ArtifactFileSource.prototype, "read")
-    .mockImplementation(function (this: ArtifactFileSource, ...args) {
-      calls += 1;
-      if (calls === 2) return Promise.reject(physical);
-      return nativeRead.apply(this, args);
-    });
-  try {
-    await expect(entries(reader)).rejects.toBe(physical);
-    await expect(reader.open(expected)).rejects.toMatchObject({
-      reason: "integrity",
-    });
-    read.mockRestore();
-    expect((await entries(reader)).map((entry) => entry.path)).toEqual(["a"]);
-  } finally {
-    read.mockRestore();
-    await reader.close();
-    await control.close();
-  }
-});
-
 describe("wxapkg allocation and malformed-input boundaries", () => {
   it("admits the encoded table budget before reading it", async () => {
     const bytes = buildWxapkg([{ path: "a", data: "x" }]);
@@ -372,8 +308,3 @@ describe("wxapkg stream capacity and freshness", () => {
     }
   });
 });
-
-artifactPreparationRecoveryCases({
-  image: () => buildWxapkg([{ path: "a", data: "x" }]),
-  createReader: (path, admitted) => new WxapkgArtifactReader(path, admitted),
-});

src/artifacts/WxapkgArtifactReader.ts

@@ -12,10 +12,7 @@ import {
   type ArtifactTraversalOptions,
 } from "./ArtifactReader.js";
 import { ArtifactResourceScope } from "./ArtifactResourceScope.js";
-import {
-  artifactReadCancelledBy,
-  assertArtifactReadActive,
-} from "./ArtifactFileOperation.js";
+import { assertArtifactReadActive } from "./ArtifactFileOperation.js";
 import { readArtifactFileBytes } from "./ArtifactFileRange.js";
 import type {
   ArtifactFormatMetadata,
@@ -51,12 +48,10 @@ interface WxapkgEntryState {
 export class WxapkgArtifactReader implements ArtifactReader {
   readonly format = "wxapkg" as const;
   readonly #scope = new ArtifactResourceScope();
-  #entries = new Map<string, WxapkgEntryState>();
+  readonly #entries = new Map<string, WxapkgEntryState>();
   readonly #streams = new Map<Readable, AbortController>();
   readonly #source: ArtifactFileSource;
-  #prepared:
-    | { signal: AbortSignal | undefined; promise: Promise<void> }
-    | undefined;
+  #prepared: Promise<void> | undefined;
   #header: WxapkgMetadata | undefined;
   #remainingReadOperations = 0;
   #admittedReadOperations = 0;
@@ -86,27 +81,8 @@ export class WxapkgArtifactReader implements ArtifactReader {
   ): AsyncIterable<ArtifactEntry> {
     await this.#scope.run(async () => {
       this.#assertOpen(signal);
-      for (;;) {
-        const pending = (this.#prepared ??= {
-          signal,
-          promise: this.#prepare(signal),
-        });
-        try {
-          await pending.promise;
-          break;
-        } catch (cause: unknown) {
-          if (this.#prepared === pending) this.#prepared = undefined;
-          if (
-            pending.signal !== signal &&
-            signal?.aborted !== true &&
-            artifactReadCancelledBy(cause, pending.signal)
-          ) {
-            this.#assertOpen(signal);
-            continue;
-          }
-          throw cause;
-        }
-      }
+      this.#prepared ??= this.#prepare(signal);
+      await this.#prepared;
       await this.#source.read(signal);
     });
     this.#assertOpen(signal);
@@ -225,7 +201,7 @@ export class WxapkgArtifactReader implements ArtifactReader {
     const header = await readWxapkgHeader(handle, initial.size, signal);
     if (header === undefined)
       throw wxapkgFormatFailure("no complete wxapkg header");
-    const metadata: WxapkgMetadata = {
+    this.#header = {
       kind: "wxapkg",
       info: header.layout.status === "available" ? header.info : null,
       index_length:
@@ -236,12 +212,7 @@ export class WxapkgArtifactReader implements ArtifactReader {
         header.layout.status === "available" ? header.fileCount : null,
       directory_status: header.layout.status,
     };
-    if (header.layout.status !== "available") {
-      await this.#source.read(signal);
-      this.#assertOpen(signal);
-      this.#header = metadata;
-      return;
-    }
+    if (header.layout.status !== "available") return;
     const { members } = await readWxapkgFileTable(
       handle,
       header,
@@ -249,7 +220,6 @@ export class WxapkgArtifactReader implements ArtifactReader {
       signal,
     );
     const budget = artifactExpansionBudgetBytes(initial.size);
-    const entries = new Map<string, WxapkgEntryState>();
     let declaredBytes = 0n;
     for (let index = 0; index < members.length; index++) {
       if (index % 256 === 0) await setImmediate();
@@ -264,7 +234,7 @@ export class WxapkgArtifactReader implements ArtifactReader {
           { boundary: "memory" },
         );
       const adapterKey = `wxapkg-entry:${String(index)}`;
-      entries.set(adapterKey, {
+      this.#entries.set(adapterKey, {
         entry: {
           path: member.path,
           sourcePath: member.declaredPath,
@@ -290,18 +260,14 @@ export class WxapkgArtifactReader implements ArtifactReader {
       });
     }
     // Header, table and per-chunk member reads; a small-reader floor applies.
-    const admittedReadOperations =
+    this.#admittedReadOperations =
       4 *
       Math.max(
         1024,
         members.length + Math.ceil(Number(declaredBytes) / CHUNK_BYTES),
       );
+    this.#remainingReadOperations = this.#admittedReadOperations;
     await this.#source.read(signal);
-    this.#assertOpen(signal);
-    this.#header = metadata;
-    this.#entries = entries;
-    this.#admittedReadOperations = admittedReadOperations;
-    this.#remainingReadOperations = admittedReadOperations;
   }
 
   async *#memberChunks(

src/artifacts/artifactFormats.test.ts

@@ -43,8 +43,7 @@ type FormatsWithReaders =
   | "uf2"
   | "dfuse"
   | "esp-flash-image"
-  | "fit"
-  | "ntfs-mft";
+  | "fit";
 
 const readerFormatsMatch: Equal<ArtifactReaderFormat, FormatsWithReaders> =
   true;

src/artifacts/artifactFormats.ts

@@ -40,7 +40,6 @@ import { NodeSeaArtifactReader } from "./NodeSeaArtifactReader.js";
 import type { PyInstallerAdmission } from "./pyinstaller/PyInstallerAdmission.js";
 import { PyInstallerArtifactReader } from "./PyInstallerArtifactReader.js";
 import { Uf2ArtifactReader } from "./Uf2ArtifactReader.js";
-import { NtfsMftArtifactReader } from "./NtfsMftArtifactReader.js";
 import { UImageArtifactReader } from "./UImageArtifactReader.js";
 import { UnityFsArtifactReader } from "./UnityFsArtifactReader.js";
 import { WxapkgArtifactReader } from "./WxapkgArtifactReader.js";
@@ -466,14 +465,6 @@ const NON_ZIP_FORMATS = {
     createReader: (path, options) =>
       new FitArtifactReader(path, sourceOf(options)),
   }),
-  "ntfs-mft": described("ntfs-mft", {
-    ...plain,
-    retainClassifiedSource: true,
-    readerLimitation:
-      "MFT inventory reports whole-stream counts and a bounded sample of the first 32 decoded FILE record headers, with the omitted-header count. Attributes, filenames, data streams and the $UsnJrnl:$J journal are not decoded, so no path, file size or change history is established.",
-    createReader: (path, options) =>
-      new NtfsMftArtifactReader(path, sourceOf(options)),
-  }),
   unknown: described("unknown", plain),
 } satisfies Record<
   Exclude<ArtifactFormatId, ZipPackageFormat>,

src/artifacts/inventory/ArtifactGraphConstruction.test.ts

@@ -576,28 +576,6 @@ it("classifies nested UF2 by block magics and DfuSe by prefix and suffix", () =>
   ).toMatchObject({ format: "file" });
 });
 
-it("classifies a $MFT stream by its FILE record header, under any name", () => {
-  const mft = Buffer.alloc(2_048);
-  mft.write("FILE", 0, "latin1");
-  mft.writeUInt32LE(1024, 28);
-  for (const path of ["evidence/$MFT", "evidence/mft.raw", "evidence/records"])
-    expect(classifyArtifactBytesAtPath(path, mft)).toEqual({
-      kind: "executable",
-      format: "ntfs-mft",
-    });
-});
-
-it("leaves plain content beginning with FILE unclassified as MFT", () => {
-  const text = Buffer.from(
-    "FILE is a plain text prefix, not an NTFS record header",
-  );
-  expect(
-    classifyArtifactBytesAtPath("evidence/readme.txt", text),
-  ).toMatchObject({
-    format: "file",
-  });
-});
-
 it("classifies a FIT by a /images node within the first 4 KiB", () => {
   const images = [{ name: "kernel", data: Buffer.from("kernel") }];
   const late = devicetreeFixture({

src/artifacts/inventory/ArtifactGraphConstruction.ts

@@ -11,7 +11,6 @@ import { recognizeEspImage } from "../../domain/firmware/espImage.js";
 import { hasUf2Block } from "../../domain/firmware/uf2.js";
 import { isDfuSeFile } from "../../domain/firmware/dfuse.js";
 import { hasFitImagesNode } from "../../domain/firmware/fitImage.js";
-import { hasMftFileRecordHeader } from "../../domain/windows/ntfsMft.js";
 import type { ArtifactClassificationEvidence } from "../ArtifactClassificationProbe.js";
 import { asarHeaderAdmissionFailure } from "../AsarHeader.js";
 import { hasDestinationPath } from "../ArtifactPaths.js";
@@ -623,7 +622,6 @@ export const classifyArtifactBytes = (
     return "dfuse";
   if (recognizeEspImage(prefix, fileSize) === "esp-image") return "esp-image";
   if (hasFitImagesNode(prefix)) return "fit";
-  if (hasMftFileRecordHeader(prefix)) return "ntfs-mft";
   if (hasBinaryPlistSignature(prefix)) return "plist";
   if (hasXmlPlistSignature(prefix)) return "plist";
   const fatFormat = classifyFatArtifact(evidence, fileSize);

src/artifacts/pyinstaller/MarshalSubset.test.ts

@@ -20,11 +20,6 @@ it("reads a Python 3.9 reference-flagged PYZ table", () => {
   ]);
 });
 
-it("reads marshal one-byte string tags as Latin-1", () => {
-  for (const hex of ["6101000000e9", "4101000000e9", "7a01e9", "5a01e9"])
-    expect(readMarshalSubset(bytes(hex))).toEqual({ ok: true, value: "é" });
-});
-
 it("decodes CPython marshal Unicode with surrogatepass", () => {
   expect(
     readMarshalSubset(

src/artifacts/pyinstaller/MarshalSubset.ts

@@ -168,8 +168,14 @@ const readAsciiBytes = (
 ): Result<string, PyInstallerFailure> => {
   const bytes = readBytes(cursor, length);
   if (!bytes.ok) return bytes;
-  // These tags use CPython's one-byte Unicode constructor, not an ASCII check.
-  return ok(bytes.value.toString("latin1"));
+  if (bytes.value.some((byte) => byte > 0x7f))
+    return err(
+      pyInstallerFailure(
+        "format",
+        "PYZ marshal ASCII string contains a non-ASCII byte",
+      ),
+    );
+  return ok(bytes.value.toString("ascii"));
 };
 
 const readUtf8 = (

src/domain/analysisSnapshot.ts

@@ -86,7 +86,6 @@ const formatSchema = z.enum([
   "dfuse",
   "esp-flash-image",
   "fit",
-  "ntfs-mft",
   "plist",
   "javascript",
   "source-map",

src/domain/artifactFormatMetadata.ts

@@ -1,5 +1,4 @@
 import { z } from "zod";
-import { MFT_INLINE_HEADER_LIMIT } from "./windows/ntfsMft.js";
 
 import { jsonRecordSchema } from "./jsonRecord.js";
 import { jsonValueSchema } from "./jsonValue.js";
@@ -300,56 +299,6 @@ export const hexRecordRegionMetadataSchema = z.strictObject({
   last_line: offset,
 });
 
-const ntfsFileReferenceSchema = z.strictObject({
-  recordNumber: offset,
-  sequenceNumber: offset,
-});
-const ntfsRecordHeaderSchema = z.strictObject({
-  index: offset,
-  fileOffset: offset,
-  sequenceNumber: offset,
-  hardLinkCount: offset,
-  flags: z.strictObject({
-    raw: offset,
-    names: z.array(z.string()),
-    unknownMask: offset,
-  }),
-  inUse: z.boolean(),
-  directory: z.boolean(),
-  usedBytes: offset,
-  totalBytes: offset,
-  extentValid: z.boolean(),
-  baseRecordReference: ntfsFileReferenceSchema.nullable(),
-  declaredRecordNumber: offset.nullable(),
-  recordNumberMatchesSlot: z.boolean().nullable(),
-  logFileSequenceNumber: z.string().regex(/^(?:0|[1-9][0-9]*)$/u),
-  firstAttributeOffset: offset,
-  nextAttributeId: offset,
-  fixups: z.strictObject({
-    sequenceNumber: offset,
-    entries: offset,
-    verifiedSectors: offset,
-    coveredSectors: offset,
-    mismatchSector: offset.nullable(),
-    malformed: z.boolean(),
-  }),
-});
-
-/** NTFS $MFT record-header facts; attributes, names and the USN journal are later steps. */
-export const ntfsMftMetadataSchema = z.strictObject({
-  kind: z.literal("ntfs-mft"),
-  record_bytes: offset,
-  record_count: offset,
-  in_use_record_count: offset,
-  directory_record_count: offset,
-  extension_record_count: offset,
-  fixup_mismatch_count: offset,
-  fixup_unverified_record_count: offset,
-  truncated_tail_bytes: offset,
-  record_headers: z.array(ntfsRecordHeaderSchema).max(MFT_INLINE_HEADER_LIMIT),
-  omitted_record_headers: offset,
-});
-
 /**
  * U-Boot FIT root facts. Configuration references are declared names; a
  * reference that names no image is reported as a limitation, not removed.
@@ -937,7 +886,6 @@ export const artifactFormatMetadataSchema = z.discriminatedUnion("kind", [
   espImageSignatureBlockMetadataSchema,
   uf2MetadataSchema,
   uf2RegionMetadataSchema,
-  ntfsMftMetadataSchema,
   dfuSeMetadataSchema,
   dfuSeElementMetadataSchema,
   espFlashImageMetadataSchema,
@@ -1088,10 +1036,6 @@ const declarationsByKind: {
     notCompared:
       "Its familyID and addresses are in its path, family_name is REA's label for the familyID, and its block counts and positions are layout; content comparison covers its bytes.",
   },
-  "ntfs-mft": {
-    notCompared:
-      "Its fields come from the record headers in the file's own FILE records, which content comparison covers.",
-  },
   dfuse: {
     notCompared:
       "Its fields come from the file's own prefix, target headers and suffix, which content comparison covers.",

src/domain/artifactGraph.ts

@@ -103,7 +103,6 @@ export const ARTIFACT_FORMAT_IDS = [
   "dfuse",
   "esp-flash-image",
   "fit",
-  "ntfs-mft",
   "unknown",
 ] as const;
 
@@ -125,7 +124,6 @@ const artifactContentFormatSchema = artifactFormatSchema.extract([
   "uf2",
   "dfuse",
   "fit",
-  "ntfs-mft",
   "mach-o-universal",
   "mach-o",
   "elf",

src/domain/binaryTargetTypes.ts

@@ -302,8 +302,7 @@ export type BinaryTarget =
           | "esp-image"
           | "uf2"
           | "dfuse"
-          | "fit"
-          | "ntfs-mft";
+          | "fit";
       })
   | (BinaryTargetIdentity &
       NonExecutableMetadata & {

src/domain/evidenceSubject.ts

@@ -52,7 +52,6 @@ export const evidenceSubjectFormatSchema = z.enum([
   "dfuse",
   "esp-flash-image",
   "fit",
-  "ntfs-mft",
 ]);
 
 /** Format-owned architecture declarations shared by Evidence and persisted executions. */

src/domain/javascript/childProcessOptionsRegression.test.ts

@@ -137,8 +137,7 @@ describe("child-process options detection", () => {
       ["negative-zero", `spawn("tool", [], { env: -0 })`, false],
       ["bigint-zero", `spawn("tool", [], { env: 0n })`, false],
       ["zero-float", `spawn("tool", [], { env: 0.0 })`, false],
-      ["nan", `spawn("tool", [], { env: NaN })`, false],
-      ["shadowed-nan", `((NaN) => spawn("tool", [], { env: NaN }))({})`, true],
+      ["nan", `spawn("tool", [], { env: NaN })`, true],
       ["empty-string", `spawn("tool", [], { env: "" })`, false],
       ["false", `spawn("tool", [], { env: false })`, false],
       ["empty-object", `spawn("tool", [], { env: {} })`, true],

src/domain/javascript/javascriptSemanticChildProcesses.ts

@@ -81,7 +81,7 @@ export const collectJavaScriptSemanticChildProcesses = (
       !rejectsOptionsShape(candidate, context, state),
   );
   const childProcessSpawns = candidates.map((candidate) =>
-    immutableSpawn(candidate, context, state),
+    immutableSpawn(candidate, context),
   );
   return {
     childProcessSpawns,
@@ -146,7 +146,6 @@ const collectSpawns = (
 const immutableSpawn = (
   candidate: SpawnCandidate,
   context: ChildSpawnContext,
-  state: JavaScriptSemanticAnalysisState,
 ): JavaScriptSemanticChildProcessSpawn => {
   const { options, argvCount } = spawnArguments(candidate, context);
   const command = dataEffectLiteralString(candidate.node.arguments[0]);
@@ -162,7 +161,7 @@ const immutableSpawn = (
     projectedResultBindings: candidate.projectedResultBindings,
     command,
     argvCount,
-    environmentSupplied: environmentSupplied(options, context, state),
+    environmentSupplied: environmentSupplied(options, context),
     stdioMode: stdioMode(options, candidate.method, context),
     resolution: command === null ? "partial" : "complete",
   };
@@ -444,17 +443,11 @@ const spawnArguments = (
 const environmentSupplied = (
   options: t.Node | undefined,
   context: ChildSpawnContext,
-  state: JavaScriptSemanticAnalysisState,
 ): boolean => {
   const lookup = staticObjectProperty(options, "env", context.isNullish);
   if (lookup.status !== "explicit") return false;
   const value = unwrapJavaScriptExpression(lookup.value).node;
   if (context.isNullish(value)) return false;
-  if (
-    t.isIdentifier(value, { name: "NaN" }) &&
-    isUnshadowedGlobal(value, state, "NaN")
-  )
-    return false;
   return staticJavaScriptTruthiness(value) !== false;
 };
 

src/domain/liveBinaryTargetSummary.ts

@@ -83,7 +83,6 @@ export const liveBinaryTargetSummaryVariants = [
       "uf2",
       "dfuse",
       "fit",
-      "ntfs-mft",
     ]),
     architecture: z.null(),
   }),

src/domain/reconstructionCoverage.ts

@@ -31,6 +31,9 @@ const evidenceIdSchema = prefixedDigestSchema("ev");
 const stableIdSchema = z
   .string()
   .regex(/^[A-Za-z][A-Za-z0-9._:\x2f\x2d]{0,199}$/u);
+export const reconstructionBoundaryIdSchema = stableIdSchema.describe(
+  "Exact identifier of a boundary declared in the reconstruction coverage.",
+);
 const boundedTextSchema = z.string().trim().min(1);
 
 const authoritySchema = z.enum([
@@ -158,7 +161,7 @@ const packageProofSchema = z.strictObject({
 });
 
 const boundarySchema = z.strictObject({
-  boundary_id: stableIdSchema,
+  boundary_id: reconstructionBoundaryIdSchema,
   title: z.string().trim().min(1),
   required_surface_ids: z.array(stableIdSchema).min(1),
   required_claim_ids: z.array(stableIdSchema).min(1),
@@ -204,6 +207,10 @@ export interface ParsedReconstructionCoverage {
     string,
     ReconstructionCoverageData["claims"][number]
   >;
+  readonly boundaries: ReadonlyMap<
+    string,
+    ReconstructionCoverageData["boundaries"][number]
+  >;
   readonly ownersBySurface: ReadonlyMap<
     string,
     readonly ReconstructionCoverageData["owners"][number][]
@@ -281,7 +288,7 @@ const closureReasonSchema = z.strictObject({
 });
 
 export const reconstructionClosureResultSchema = z.strictObject({
-  boundary_id: stableIdSchema,
+  boundary_id: reconstructionBoundaryIdSchema,
   status: z.enum(["partial", "failed", "unknown", "ready"]),
   summary: z.strictObject({
     required_surfaces: z.int().min(0),
@@ -311,9 +318,7 @@ export const evaluateParsedReconstructionClosure = (
   boundaryId: string,
   nowEpochMs: number,
 ): Result<ReconstructionClosureResult, AnalysisInputError> => {
-  const boundary = parsed.coverage.boundaries.find(
-    ({ boundary_id: id }) => id === boundaryId,
-  );
+  const boundary = parsed.boundaries.get(boundaryId);
   if (boundary === undefined)
     return err(
       coverageInputError(
@@ -388,7 +393,10 @@ const validateCoverageReferences = (
     ...path,
     "package_proofs",
   ]);
-  indexUnique(workspace.boundaries, "boundary_id", [...path, "boundaries"]);
+  const boundaries = indexUnique(workspace.boundaries, "boundary_id", [
+    ...path,
+    "boundaries",
+  ]);
   for (const [index, contract] of workspace.verifier_contracts.entries()) {
     const { contract_sha256: contractSha256, ...base } = contract;
     if (
@@ -464,7 +472,14 @@ const validateCoverageReferences = (
         ["residual_unknown_ids", index],
         `Coverage workspace residual unknown is missing: ${id}`,
       );
-  return { evidenceById, artifacts, surfaces, claims, ownersBySurface };
+  return {
+    evidenceById,
+    artifacts,
+    surfaces,
+    claims,
+    boundaries,
+    ownersBySurface,
+  };
 };
 
 const indexUnique = <Item extends Record<Key, string>, Key extends keyof Item>(

src/domain/reconstructionCoverageInput.ts

@@ -1,8 +1,11 @@
 import { z } from "zod";
-import { reconstructionCoverageDataSchema } from "./reconstructionCoverage.js";
+import {
+  reconstructionBoundaryIdSchema,
+  reconstructionCoverageDataSchema,
+} from "./reconstructionCoverage.js";
 
 /** Named-boundary input for inline reconstruction coverage evaluation. */
 export const reconstructionCoverageEvaluationInputSchema = z.strictObject({
   coverage: reconstructionCoverageDataSchema,
-  boundary_id: z.string().min(1),
+  boundary_id: reconstructionBoundaryIdSchema,
 });

src/domain/windows/ntfsMft.test.ts

@@ -1,478 +0,0 @@
-import { describe, expect, it } from "vitest";
-
-import {
-  MFT_DEFAULT_RECORD_BYTES,
-  MFT_MAX_FILE_BYTES,
-  createMftDecoder,
-  parseMftImage,
-} from "./ntfsMft.js";
-
-interface RecordOptions {
-  readonly sequenceNumber?: number;
-  readonly hardLinkCount?: number;
-  readonly flags?: number;
-  readonly baseRecordReference?: bigint;
-  readonly recordBytes?: number;
-  /** Write a wrong trailer value into this sector, leaving the others correct. */
-  readonly corruptSector?: number;
-  /** Truncate the update sequence array to this many entries; 0 omits it. */
-  readonly usaEntries?: number;
-  readonly usaOffset?: number;
-}
-
-/** One FILE record with a zeroed body and fixups applied the way NTFS writes them. */
-const recordOf = (options: RecordOptions = {}): Uint8Array => {
-  const recordBytes = options.recordBytes ?? MFT_DEFAULT_RECORD_BYTES;
-  const record = new Uint8Array(recordBytes);
-  const view = new DataView(record.buffer);
-  record.set(Buffer.from("FILE", "latin1"), 0);
-  const sequenceNumber = options.sequenceNumber ?? 1;
-  const sectors = recordBytes / 512;
-
-  const usaEntries = options.usaEntries ?? sectors + 1;
-  if (usaEntries > 0) {
-    const usaOffset = options.usaOffset ?? 48;
-    view.setUint16(4, usaOffset, true);
-    view.setUint16(6, usaEntries, true);
-    view.setUint16(usaOffset, sequenceNumber, true);
-    for (let sector = 0; sector < sectors; sector += 1) {
-      const trailer = sector * 512 + 510;
-      // A saved trailer is what the sector held before the fixup replaced it.
-      view.setUint16(usaOffset + 2 * (sector + 1), 0xa5a5, true);
-      view.setUint16(
-        trailer,
-        sector >= usaEntries - 1
-          ? 0xa5a5
-          : sector === options.corruptSector
-            ? 0x1234
-            : sequenceNumber,
-        true,
-      );
-    }
-  } else {
-    view.setUint16(4, 0, true);
-    view.setUint16(6, 0, true);
-  }
-
-  view.setUint16(16, sequenceNumber, true);
-  view.setUint16(18, options.hardLinkCount ?? 1, true);
-  const firstAttributeOffset =
-    Math.ceil((48 + Math.max(0, usaEntries) * 2) / 8) * 8;
-  view.setUint16(20, firstAttributeOffset, true);
-  view.setUint16(22, options.flags ?? 0x0001, true);
-  view.setUint32(24, firstAttributeOffset + 8, true);
-  view.setUint32(firstAttributeOffset, 0xffff_ffff, true);
-  view.setUint32(28, recordBytes, true);
-  view.setBigUint64(32, options.baseRecordReference ?? 0n, true);
-  view.setUint16(40, 0, true);
-  return record;
-};
-
-const streamOf = (...records: readonly Uint8Array[]): Uint8Array => {
-  const total = records.reduce((sum, record) => sum + record.length, 0);
-  const stream = new Uint8Array(total);
-  let offset = 0;
-  for (const record of records) {
-    stream.set(record, offset);
-    const view = new DataView(stream.buffer, offset, record.length);
-    if (view.getUint16(4, true) >= 48)
-      view.setUint32(44, offset / record.length, true);
-    offset += record.length;
-  }
-  return stream;
-};
-
-describe("MFT header facts", () => {
-  it("inventories a clean record's header and verified fixups", () => {
-    const parsed = parseMftImage(streamOf(recordOf({ sequenceNumber: 5 })));
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.metadata).toMatchObject({
-      kind: "ntfs-mft",
-      record_bytes: MFT_DEFAULT_RECORD_BYTES,
-      record_count: 1,
-      in_use_record_count: 1,
-      directory_record_count: 0,
-      extension_record_count: 0,
-      fixup_mismatch_count: 0,
-      fixup_unverified_record_count: 0,
-      truncated_tail_bytes: 0,
-    });
-    expect(parsed.value.records[0]).toMatchObject({
-      index: 0,
-      fileOffset: 0,
-      sequenceNumber: 5,
-      inUse: true,
-      directory: false,
-      baseRecordReference: null,
-      firstAttributeOffset: 56,
-      fixups: {
-        sequenceNumber: 5,
-        verifiedSectors: 2,
-        coveredSectors: 2,
-        mismatchSector: null,
-        malformed: false,
-      },
-    });
-    expect(parsed.value.limitations).toEqual([]);
-  });
-
-  it("identifies unrecognized flags without losing their source bits", () => {
-    const parsed = parseMftImage(recordOf({ flags: 0x8001 }));
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.metadata.record_headers[0]?.flags).toEqual({
-      raw: 0x8001,
-      names: ["in-use"],
-      unknownMask: 0x8000,
-    });
-  });
-
-  it.each([0, 49, 64, 72])(
-    "reports an invalid first attribute offset %i",
-    (offset) => {
-      const record = recordOf();
-      new DataView(record.buffer).setUint16(20, offset, true);
-      const parsed = parseMftImage(record);
-      if (!parsed.ok) throw new Error(parsed.error.message);
-      expect(parsed.value.records[0]?.extentValid).toBe(false);
-      expect(parsed.value.limitations.join(" ")).toContain("inconsistent");
-    },
-  );
-
-  it("reports a declared record number that contradicts its stream position", () => {
-    const bytes = streamOf(recordOf(), recordOf());
-    new DataView(bytes.buffer).setUint32(1024 + 44, 0, true);
-    const parsed = parseMftImage(bytes);
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.records[1]).toMatchObject({
-      index: 1,
-      declaredRecordNumber: 0,
-      recordNumberMatchesSlot: false,
-    });
-    expect(parsed.value.limitations.join(" ")).toContain(
-      "disagrees with their stream slot",
-    );
-  });
-
-  it("keeps the inline header window separate from the parsed record count", () => {
-    const parsed = parseMftImage(
-      streamOf(...Array.from({ length: 33 }, () => recordOf())),
-    );
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.metadata).toMatchObject({
-      record_count: 33,
-      omitted_record_headers: 1,
-    });
-    expect(parsed.value.metadata.record_headers).toHaveLength(32);
-    expect(parsed.value.records).toHaveLength(33);
-    expect(parsed.value.limitations).toEqual([]);
-  });
-
-  it("preserves a log sequence number above the safe integer range", () => {
-    const record = recordOf();
-    new DataView(record.buffer).setBigUint64(8, 9007199254740993n, true);
-    const parsed = parseMftImage(record);
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.records[0]?.logFileSequenceNumber).toBe(
-      "9007199254740993",
-    );
-  });
-
-  it("verifies the older FILE header without reading its fixup words as a record number", () => {
-    const oldRecord = recordOf({ usaOffset: 42 });
-    const newRecord = recordOf();
-    new DataView(newRecord.buffer).setUint32(44, 1, true);
-
-    const parsed = parseMftImage(streamOf(oldRecord, newRecord));
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.records).toMatchObject([
-      {
-        declaredRecordNumber: null,
-        fixups: { malformed: false, verifiedSectors: 2 },
-      },
-      {
-        declaredRecordNumber: 1,
-        fixups: { malformed: false, verifiedSectors: 2 },
-      },
-    ]);
-    expect(parsed.value.limitations).toEqual([]);
-  });
-});
-
-describe("MFT fixup coverage", () => {
-  it.each([0, 0xffff])(
-    "leaves reserved USA sequence %i unverified",
-    (sequenceNumber) => {
-      const parsed = parseMftImage(recordOf({ sequenceNumber }));
-      if (!parsed.ok) throw new Error(parsed.error.message);
-      expect(parsed.value.records[0]?.fixups).toMatchObject({
-        sequenceNumber,
-        verifiedSectors: 0,
-        malformed: true,
-      });
-      expect(parsed.value.metadata.fixup_unverified_record_count).toBe(1);
-      expect(parsed.value.limitations.join(" ")).toContain(
-        "invalid or incomplete",
-      );
-    },
-  );
-
-  it("keeps a record whose sector trailer is not the sequence number, and reports it", () => {
-    const parsed = parseMftImage(
-      streamOf(recordOf(), recordOf({ sequenceNumber: 9, corruptSector: 1 })),
-    );
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.records[1]?.fixups).toMatchObject({
-      sequenceNumber: 9,
-      verifiedSectors: 1,
-      mismatchSector: 1,
-    });
-    expect(parsed.value.metadata.fixup_mismatch_count).toBe(1);
-    expect(parsed.value.limitations.join(" ")).toMatch(
-      /1 record\(s\) hold a sector trailer/u,
-    );
-  });
-
-  it("treats a missing update sequence array as unverified rather than clean", () => {
-    const parsed = parseMftImage(streamOf(recordOf({ usaEntries: 0 })));
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.records[0]?.fixups).toMatchObject({
-      malformed: true,
-      mismatchSector: null,
-      coveredSectors: 0,
-    });
-    expect(parsed.value.metadata.fixup_mismatch_count).toBe(0);
-    expect(parsed.value.metadata.fixup_unverified_record_count).toBe(1);
-    expect(parsed.value.limitations.join(" ")).toMatch(
-      /invalid or incomplete update sequence array/u,
-    );
-  });
-
-  it.each([
-    [48, 4],
-    [49, 3],
-    [508, 3],
-  ])(
-    "rejects a malformed update sequence array at %i with %i entries",
-    (offset, count) => {
-      const bytes = recordOf();
-      const view = new DataView(bytes.buffer);
-      view.setUint16(4, offset, true);
-      view.setUint16(6, count, true);
-
-      const parsed = parseMftImage(bytes);
-      if (!parsed.ok) throw new Error(parsed.error.message);
-      expect(parsed.value.records[0]?.fixups).toMatchObject({
-        malformed: true,
-        verifiedSectors: 0,
-      });
-      expect(parsed.value.metadata.fixup_unverified_record_count).toBe(1);
-    },
-  );
-
-  it("counts uncovered sectors independently of a mismatched trailer", () => {
-    const parsed = parseMftImage(
-      recordOf({ recordBytes: 4096, usaEntries: 3, corruptSector: 0 }),
-    );
-    if (!parsed.ok) throw new Error(parsed.error.message);
-    expect(parsed.value.metadata).toMatchObject({
-      fixup_mismatch_count: 1,
-      fixup_unverified_record_count: 1,
-    });
-    expect(parsed.value.limitations.join(" ")).toContain(
-      "invalid or incomplete",
-    );
-  });
-
-  it("reports an array that covers fewer sectors than the record has", () => {
-    // A 4 KiB record holds eight sectors; a three-entry array leaves five unverified.
-    const parsed = parseMftImage(
-      streamOf(recordOf({ recordBytes: 4096, usaEntries: 3 })),
-    );
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.records[0]?.fixups).toMatchObject({
-      coveredSectors: 2,
-      verifiedSectors: 2,
-      mismatchSector: null,
-      malformed: false,
-    });
-    expect(parsed.value.metadata.fixup_unverified_record_count).toBe(1);
-  });
-});
-
-describe("MFT record slots", () => {
-  it("distinguishes extension records from base records", () => {
-    const parsed = parseMftImage(
-      streamOf(
-        recordOf(),
-        recordOf({
-          flags: 0x0005,
-          baseRecordReference: 0xabcd_fedc_ba98_7654n,
-        }),
-      ),
-    );
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.records[1]).toMatchObject({
-      baseRecordReference: {
-        recordNumber: 0xfedc_ba98_7654,
-        sequenceNumber: 0xabcd,
-      },
-      flags: { raw: 0x0005, names: ["in-use", "system"] },
-    });
-    expect(parsed.value.metadata.extension_record_count).toBe(1);
-  });
-
-  it("names directory records without losing the in-use flag", () => {
-    const parsed = parseMftImage(streamOf(recordOf({ flags: 0x0003 })));
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.records[0]).toMatchObject({
-      directory: true,
-      inUse: true,
-      flags: { names: ["in-use", "directory"] },
-    });
-    expect(parsed.value.metadata.directory_record_count).toBe(1);
-  });
-
-  it("skips malformed and sparse slots without renumbering valid records", () => {
-    const stream = streamOf(
-      recordOf(),
-      recordOf(),
-      new Uint8Array(MFT_DEFAULT_RECORD_BYTES),
-      recordOf(),
-    );
-    stream.set(Buffer.from("BAAD", "latin1"), MFT_DEFAULT_RECORD_BYTES);
-    const parsed = parseMftImage(stream);
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.metadata.record_count).toBe(2);
-    expect(
-      parsed.value.records.map(({ index, fileOffset }) => [index, fileOffset]),
-    ).toEqual([
-      [0, 0],
-      [3, 3 * MFT_DEFAULT_RECORD_BYTES],
-    ]);
-    expect(parsed.value.limitations).toEqual([
-      "record at 1024 does not begin with the FILE signature; 2 slot(s) without a FILE signature were found",
-    ]);
-  });
-
-  it("keeps a trailing partial record out of the inventory", () => {
-    const stream = new Uint8Array(1024 + 300);
-    stream.set(recordOf(), 0);
-    const parsed = parseMftImage(stream);
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.metadata.record_count).toBe(1);
-    expect(parsed.value.metadata.truncated_tail_bytes).toBe(300);
-    expect(parsed.value.limitations.join(" ")).toMatch(
-      /300 trailing byte\(s\)/u,
-    );
-  });
-
-  it("falls back to the default record size when record 0 declares none", () => {
-    const record = recordOf();
-    new DataView(record.buffer).setUint32(28, 0, true);
-    const parsed = parseMftImage(record);
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.recordBytes).toBe(MFT_DEFAULT_RECORD_BYTES);
-    expect(parsed.value.limitations.join(" ")).toMatch(
-      /not a supported power of two/u,
-    );
-  });
-
-  it("reads a 4 KiB record at its declared size", () => {
-    const parsed = parseMftImage(streamOf(recordOf({ recordBytes: 4096 })));
-    expect(parsed.ok).toBe(true);
-    if (!parsed.ok) return;
-    expect(parsed.value.recordBytes).toBe(4096);
-    expect(parsed.value.metadata.record_count).toBe(1);
-  });
-});
-
-describe("parseMftImage refusals and limits", () => {
-  it("refuses a file shorter than one record header", () => {
-    const parsed = parseMftImage(new Uint8Array(32));
-    expect(parsed.ok).toBe(false);
-    if (parsed.ok) return;
-    expect(parsed.error.message).toMatch(
-      /shorter than one 42-byte record header/u,
-    );
-  });
-
-  it("refuses bytes that do not start with the FILE signature", () => {
-    const parsed = parseMftImage(Buffer.alloc(2048, 0x41));
-    expect(parsed.ok).toBe(false);
-    if (parsed.ok) return;
-    expect(parsed.error.message).toMatch(
-      /does not begin with the FILE signature/u,
-    );
-  });
-
-  it("refuses a file above the fixed ceiling", () => {
-    const decoder = createMftDecoder(MFT_MAX_FILE_BYTES + 1);
-    expect(decoder.ok).toBe(false);
-    if (decoder.ok) return;
-    expect(decoder.error).toMatchObject({
-      kind: "limit",
-      boundary: "file-size",
-    });
-  });
-
-  it("refuses streams that differ from the admitted byte count", () => {
-    const stream = recordOf();
-    const short = createMftDecoder(stream.length + 1);
-    if (!short.ok) throw new Error(short.error.message);
-    expect(short.value.write(stream).ok).toBe(true);
-    expect(short.value.finish()).toMatchObject({
-      ok: false,
-      error: {
-        kind: "format",
-        message: "stream ended before the admitted file length",
-      },
-    });
-
-    const long = createMftDecoder(stream.length - 1);
-    if (!long.ok) throw new Error(long.error.message);
-    expect(long.value.write(stream)).toMatchObject({
-      ok: false,
-      error: {
-        kind: "format",
-        message: "received more bytes than the admitted file length",
-      },
-    });
-  });
-
-  it("returns the same inventory without retaining all the decoded records", () => {
-    const bytes = streamOf(...Array.from({ length: 33 }, () => recordOf()));
-    const decoder = createMftDecoder(bytes.length);
-    const parsed = parseMftImage(bytes);
-    if (!decoder.ok || !parsed.ok) throw new Error("invalid fixture");
-    expect(decoder.value.write(bytes).ok).toBe(true);
-    const inventory = decoder.value.finish();
-    if (!inventory.ok) throw new Error(inventory.error.message);
-    expect(inventory.value).not.toHaveProperty("records");
-    expect(inventory.value.metadata).toEqual(parsed.value.metadata);
-    expect(inventory.value.limitations).toEqual(parsed.value.limitations);
-  });
-
-  it("decodes the same stream through the chunked decoder", () => {
-    const stream = streamOf(recordOf(), recordOf({ flags: 0x0003 }));
-    const decoder = createMftDecoder(stream.length);
-    expect(decoder.ok).toBe(true);
-    if (!decoder.ok) return;
-    // Feed one byte past a record boundary so a chunk never aligns with a record.
-    for (const chunk of [stream.subarray(0, 1025), stream.subarray(1025)])
-      expect(decoder.value.write(chunk).ok).toBe(true);
-    const image = decoder.value.finish();
-    expect(image.ok).toBe(true);
-    if (!image.ok) return;
-    expect(image.value.metadata.record_count).toBe(2);
-    expect(image.value.metadata.directory_record_count).toBe(1);
-  });
-});

src/domain/windows/ntfsMft.ts

@@ -1,512 +0,0 @@
-import { err, ok, type Result } from "../result.js";
-import type {
-  RegionDecodeFailure,
-  RegionDecoder,
-} from "../firmware/regionDecoder.js";
-
-/** An NTFS FILE record begins with this signature. */
-const MFT_FILE_RECORD_MAGIC = "FILE";
-const MFT_FILE_RECORD_MAGIC_BYTES = 4;
-/** The shortest header worth reading: a FILE record header ends at `nextAttributeId`. */
-const NTFS_MFT_MIN_RECORD_BYTES = 42;
-
-const hasMftFileRecordSignature = (prefix: Uint8Array): boolean =>
-  prefix.length >= MFT_FILE_RECORD_MAGIC_BYTES &&
-  text(prefix.subarray(0, MFT_FILE_RECORD_MAGIC_BYTES)) ===
-    MFT_FILE_RECORD_MAGIC;
-
-/** A record's declared size is a power of two from 512 upward; 1024 is NTFS's default. */
-export const MFT_DEFAULT_RECORD_BYTES = 1024;
-const MFT_MIN_RECORD_BYTES = 512;
-const MFT_MAX_RECORD_BYTES = 65536;
-/** An update sequence array holds at least the sequence number and one fixup word. */
-const USA_MIN_ENTRIES = 2;
-/** NTFS fixes up one 512-byte sector at a time. */
-const FIXUP_SECTOR_BYTES = 512;
-/**
- * Fixed whole-file ceiling. Records are inventoried from their headers only;
- * attributes and their payloads are not decoded, so this is deliberately
- * smaller than a volume's MFT can be.
- */
-export const MFT_MAX_FILE_BYTES = 512 * 1024 * 1024;
-/** Limit the inline header sample independently of full stream coverage. */
-export const MFT_INLINE_HEADER_LIMIT = 32;
-
-/** FILE record header fields; offsets are from the record start. */
-const RECORD_HEADER = {
-  updateSequenceOffset: 4,
-  updateSequenceCount: 6,
-  logFileSequenceNumber: 8,
-  sequenceNumber: 16,
-  hardLinkCount: 18,
-  firstAttributeOffset: 20,
-  flags: 22,
-  usedBytes: 24,
-  totalBytes: 28,
-  baseRecordReference: 32,
-  nextAttributeId: 40,
-  recordNumber: 44,
-} as const;
-const RECORD_HEADER_WITH_NUMBER_BYTES = 48;
-
-const FILE_RECORD_IN_USE = 0x0001;
-const FILE_RECORD_IS_DIRECTORY = 0x0002;
-const FILE_RECORD_NAMES = new Map<number, string>([
-  [FILE_RECORD_IN_USE, "in-use"],
-  [FILE_RECORD_IS_DIRECTORY, "directory"],
-  [0x0004, "system"],
-  [0x0008, "view-index"],
-]);
-
-export interface MftRecordFixups {
-  /** The update sequence number the array's first entry holds, or 0 when absent. */
-  readonly sequenceNumber: number;
-  readonly entries: number;
-  /** Sectors whose trailer held the sequence number before a mismatch. */
-  readonly verifiedSectors: number;
-  /** Sectors the array covers; fewer than the record's sectors leaves a tail unverified. */
-  readonly coveredSectors: number;
-  /** The first sector whose trailer did not hold the sequence number, if any. */
-  readonly mismatchSector: number | null;
-  /** The array itself is missing, misplaced or too short to cover one sector. */
-  readonly malformed: boolean;
-}
-
-export interface MftFileReference {
-  readonly recordNumber: number;
-  readonly sequenceNumber: number;
-}
-
-const decodeMftFileReference = (reference: bigint): MftFileReference => ({
-  recordNumber: Number(reference & 0xffff_ffff_ffffn),
-  sequenceNumber: Number(reference >> 48n),
-});
-
-export interface MftRecord {
-  /** Zero-based ordinal of this record in the stream. */
-  readonly index: number;
-  /** File offset where the record starts. */
-  readonly fileOffset: number;
-  readonly sequenceNumber: number;
-  /** Hard link count as recorded; a zero count marks a record with no names. */
-  readonly hardLinkCount: number;
-  readonly flags: {
-    readonly raw: number;
-    readonly names: readonly string[];
-    readonly unknownMask: number;
-  };
-  readonly inUse: boolean;
-  readonly directory: boolean;
-  /** Used and allocated byte counts as declared by the FILE record. */
-  readonly usedBytes: number;
-  readonly totalBytes: number;
-  readonly extentValid: boolean;
-  /** The base record this is an extension of, or `null` for a base record. */
-  readonly baseRecordReference: MftFileReference | null;
-  /** The record number the header declares; `null` when the header predates the field. */
-  readonly declaredRecordNumber: number | null;
-  readonly recordNumberMatchesSlot: boolean | null;
-  /** `$LogFile` sequence number as recorded; no log is read. */
-  readonly logFileSequenceNumber: string;
-  /** Declared offset of the first attribute; no attribute decoding follows yet. */
-  readonly firstAttributeOffset: number;
-  /** Declared id of the next attribute; no attribute decoding follows yet. */
-  readonly nextAttributeId: number;
-  readonly fixups: MftRecordFixups;
-}
-
-export interface MftInventory {
-  readonly metadata: MftMetadata;
-  /** The record size the stream declared, or the fixed default when it did not. */
-  readonly recordBytes: number;
-  readonly limitations: readonly string[];
-}
-
-export interface MftImage extends MftInventory {
-  readonly records: readonly MftRecord[];
-}
-
-export interface MftMetadata {
-  readonly kind: "ntfs-mft";
-  readonly record_bytes: number;
-  readonly record_count: number;
-  readonly in_use_record_count: number;
-  readonly directory_record_count: number;
-  readonly extension_record_count: number;
-  readonly fixup_mismatch_count: number;
-  readonly fixup_unverified_record_count: number;
-  readonly truncated_tail_bytes: number;
-  readonly record_headers: readonly MftRecord[];
-  readonly omitted_record_headers: number;
-}
-
-const text = (ascii: Uint8Array): string =>
-  Buffer.from(ascii).toString("latin1");
-
-const failure = (
-  message: string,
-  boundary?: RegionDecodeFailure["boundary"],
-): RegionDecodeFailure => ({
-  kind: "format",
-  message,
-  ...(boundary === undefined ? {} : { boundary }),
-});
-
-const limit = (
-  message: string,
-  boundary?: RegionDecodeFailure["boundary"],
-): RegionDecodeFailure => ({
-  kind: "limit",
-  message,
-  ...(boundary === undefined ? {} : { boundary }),
-});
-
-const parseRecordFlags = (raw: number): MftRecord["flags"] => {
-  const names: string[] = [];
-  let unknownMask = raw;
-  for (const [bit, name] of FILE_RECORD_NAMES) {
-    if ((raw & bit) !== 0) names.push(name);
-    unknownMask &= ~bit;
-  }
-  return { raw, names, unknownMask };
-};
-
-const isRecordSize = (bytes: number): boolean =>
-  bytes >= MFT_MIN_RECORD_BYTES &&
-  bytes <= MFT_MAX_RECORD_BYTES &&
-  (bytes & (bytes - 1)) === 0;
-
-const updateSequenceArrayFits = (
-  offset: number,
-  entries: number,
-  sectors: number,
-): boolean =>
-  entries >= USA_MIN_ENTRIES &&
-  entries <= sectors + 1 &&
-  offset >= NTFS_MFT_MIN_RECORD_BYTES &&
-  offset % 2 === 0 &&
-  offset + entries * 2 <= FIXUP_SECTOR_BYTES - 2;
-
-/** Recognize a FILE header without requiring its trailers or attributes to verify. */
-export const hasMftFileRecordHeader = (prefix: Uint8Array): boolean => {
-  if (
-    prefix.length < NTFS_MFT_MIN_RECORD_BYTES ||
-    !hasMftFileRecordSignature(prefix)
-  )
-    return false;
-  const view = new DataView(
-    prefix.buffer,
-    prefix.byteOffset,
-    prefix.byteLength,
-  );
-  return (
-    isRecordSize(view.getUint32(RECORD_HEADER.totalBytes, true)) ||
-    updateSequenceArrayFits(
-      view.getUint16(RECORD_HEADER.updateSequenceOffset, true),
-      view.getUint16(RECORD_HEADER.updateSequenceCount, true),
-      MFT_DEFAULT_RECORD_BYTES / FIXUP_SECTOR_BYTES,
-    )
-  );
-};
-
-/**
- * Parse FILE record headers and verify their update-sequence fixups.
- *
- * Only the record structure is established: attributes, their names, the
- * filenames and the USN journal are left to later steps, so no path, timestamp
- * or file identity beyond the record itself is claimed. A record whose fixup
- * does not match keeps its header facts, because the stream still declares it,
- * and the mismatch is reported on the record and counted in the metadata.
- */
-export const parseMftImage = (
-  bytes: Uint8Array,
-): Result<MftImage, RegionDecodeFailure> => {
-  const records: MftRecord[] = [];
-  const inventory = scanMft(bytes, records);
-  return inventory.ok ? ok({ ...inventory.value, records }) : inventory;
-};
-
-const scanMft = (
-  bytes: Uint8Array,
-  retainedRecords?: MftRecord[],
-): Result<MftInventory, RegionDecodeFailure> => {
-  if (bytes.length < NTFS_MFT_MIN_RECORD_BYTES)
-    return err(
-      failure(
-        `file is ${String(bytes.length)} bytes, shorter than one ${String(NTFS_MFT_MIN_RECORD_BYTES)}-byte record header`,
-      ),
-    );
-  if (!hasMftFileRecordSignature(bytes))
-    return err(failure("record 0 does not begin with the FILE signature"));
-
-  const limitations: string[] = [];
-  const header = new DataView(bytes.buffer, bytes.byteOffset, bytes.byteLength);
-  const declaredRecordBytes = header.getUint32(RECORD_HEADER.totalBytes, true);
-  const recordBytes = isRecordSize(declaredRecordBytes)
-    ? declaredRecordBytes
-    : MFT_DEFAULT_RECORD_BYTES;
-  if (!isRecordSize(declaredRecordBytes))
-    limitations.push(
-      `record 0 declares a record size of ${String(declaredRecordBytes)} bytes, which is not a supported power of two from ${String(MFT_MIN_RECORD_BYTES)} to ${String(MFT_MAX_RECORD_BYTES)}; records were read at the ${String(MFT_DEFAULT_RECORD_BYTES)}-byte default`,
-    );
-
-  const recordHeaders: MftRecord[] = [];
-  let recordCount = 0;
-  let inUseCount = 0;
-  let directoryCount = 0;
-  let extensionCount = 0;
-  let mismatchCount = 0;
-  let unverifiedCount = 0;
-  let invalidSlots = 0;
-  let invalidExtents = 0;
-  let inconsistentRecordNumbers = 0;
-  let firstInvalidExtentOffset: number | undefined;
-  let firstInvalidOffset: number | undefined;
-  for (
-    let offset = 0;
-    offset + recordBytes <= bytes.length;
-    offset += recordBytes
-  ) {
-    if (
-      !hasMftFileRecordSignature(
-        bytes.subarray(offset, offset + MFT_FILE_RECORD_MAGIC_BYTES),
-      )
-    ) {
-      invalidSlots += 1;
-      firstInvalidOffset ??= offset;
-      if (!isRecordSize(declaredRecordBytes)) break;
-      continue;
-    }
-    const record = readRecord(bytes, offset, offset / recordBytes, recordBytes);
-    retainedRecords?.push(record);
-    if (recordHeaders.length < MFT_INLINE_HEADER_LIMIT)
-      recordHeaders.push(record);
-    recordCount += 1;
-    if (record.inUse) inUseCount += 1;
-    if (record.directory) directoryCount += 1;
-    if (record.baseRecordReference !== null) extensionCount += 1;
-    if (record.fixups.mismatchSector !== null) mismatchCount += 1;
-    if (
-      record.fixups.malformed ||
-      record.fixups.coveredSectors < recordBytes / FIXUP_SECTOR_BYTES
-    )
-      unverifiedCount += 1;
-    if (record.recordNumberMatchesSlot === false)
-      inconsistentRecordNumbers += 1;
-    if (!record.extentValid) {
-      invalidExtents += 1;
-      firstInvalidExtentOffset ??= offset;
-    }
-  }
-  if (firstInvalidOffset !== undefined)
-    limitations.push(
-      `record at ${String(firstInvalidOffset)} does not begin with the FILE signature; ${String(invalidSlots)} slot(s) without a FILE signature were found`,
-    );
-
-  if (firstInvalidExtentOffset !== undefined)
-    limitations.push(
-      `${String(invalidExtents)} FILE record(s) declare inconsistent record extents, beginning at offset ${String(firstInvalidExtentOffset)}`,
-    );
-
-  if (inconsistentRecordNumbers !== 0)
-    limitations.push(
-      `${String(inconsistentRecordNumbers)} FILE record(s) declare a record number that disagrees with their stream slot`,
-    );
-
-  const truncatedTailBytes = bytes.length % recordBytes;
-  if (truncatedTailBytes !== 0)
-    limitations.push(
-      `${String(truncatedTailBytes)} trailing byte(s) do not fill a ${String(recordBytes)}-byte record and were not parsed`,
-    );
-
-  if (mismatchCount !== 0)
-    limitations.push(
-      `${String(mismatchCount)} record(s) hold a sector trailer that is not the update sequence number; their attributes were not read and no later step should trust them`,
-    );
-  if (unverifiedCount !== 0)
-    limitations.push(
-      `${String(unverifiedCount)} record(s) carry an invalid or incomplete update sequence array; their sector trailers were not fully verified`,
-    );
-
-  const metadata: MftMetadata = {
-    kind: "ntfs-mft",
-    record_bytes: recordBytes,
-    record_count: recordCount,
-    in_use_record_count: inUseCount,
-    directory_record_count: directoryCount,
-    extension_record_count: extensionCount,
-    fixup_mismatch_count: mismatchCount,
-    fixup_unverified_record_count: unverifiedCount,
-    truncated_tail_bytes: truncatedTailBytes,
-    record_headers: recordHeaders,
-    omitted_record_headers: recordCount - recordHeaders.length,
-  };
-
-  return ok({ metadata, recordBytes, limitations });
-};
-
-const readRecord = (
-  bytes: Uint8Array,
-  fileOffset: number,
-  index: number,
-  recordBytes: number,
-): MftRecord => {
-  const record = bytes.subarray(fileOffset, fileOffset + recordBytes);
-  const view = new DataView(
-    record.buffer,
-    record.byteOffset,
-    record.byteLength,
-  );
-
-  const flags = view.getUint16(RECORD_HEADER.flags, true);
-  const baseRecordReference = view.getBigUint64(
-    RECORD_HEADER.baseRecordReference,
-    true,
-  );
-
-  const usaOffset = view.getUint16(RECORD_HEADER.updateSequenceOffset, true);
-  const fixups = verifyFixups(record, view, usaOffset);
-  const usedBytes = view.getUint32(RECORD_HEADER.usedBytes, true);
-  const totalBytes = view.getUint32(RECORD_HEADER.totalBytes, true);
-  const firstAttributeOffset = view.getUint16(
-    RECORD_HEADER.firstAttributeOffset,
-    true,
-  );
-
-  const declaredRecordNumber =
-    !fixups.malformed && usaOffset >= RECORD_HEADER_WITH_NUMBER_BYTES
-      ? view.getUint32(RECORD_HEADER.recordNumber, true)
-      : null;
-
-  return {
-    index,
-    fileOffset,
-    sequenceNumber: view.getUint16(RECORD_HEADER.sequenceNumber, true),
-    hardLinkCount: view.getUint16(RECORD_HEADER.hardLinkCount, true),
-    flags: parseRecordFlags(flags),
-    inUse: (flags & FILE_RECORD_IN_USE) !== 0,
-    directory: (flags & FILE_RECORD_IS_DIRECTORY) !== 0,
-    usedBytes,
-    totalBytes,
-    extentValid:
-      totalBytes === recordBytes &&
-      usedBytes >= NTFS_MFT_MIN_RECORD_BYTES &&
-      usedBytes % 8 === 0 &&
-      usedBytes <= totalBytes &&
-      firstAttributeOffset % 8 === 0 &&
-      firstAttributeOffset >= NTFS_MFT_MIN_RECORD_BYTES &&
-      firstAttributeOffset + 4 <= usedBytes &&
-      (fixups.malformed ||
-        firstAttributeOffset >= usaOffset + fixups.entries * 2),
-    baseRecordReference:
-      baseRecordReference === 0n
-        ? null
-        : decodeMftFileReference(baseRecordReference),
-    declaredRecordNumber,
-    recordNumberMatchesSlot:
-      declaredRecordNumber === null ? null : declaredRecordNumber === index,
-    logFileSequenceNumber: view
-      .getBigUint64(RECORD_HEADER.logFileSequenceNumber, true)
-      .toString(),
-    firstAttributeOffset,
-    nextAttributeId: view.getUint16(RECORD_HEADER.nextAttributeId, true),
-    fixups,
-  };
-};
-
-/**
- * Each sector's last two bytes are replaced on disk by the update sequence
- * number; the array's first entry is that number and the rest are the saved
- * trailer words. A sector whose trailer is not the sequence number was not
- * cleanly written, so the record's attributes cannot be trusted.
- */
-const verifyFixups = (
-  record: Uint8Array,
-  view: DataView,
-  usaOffset: number,
-): MftRecordFixups => {
-  const usaCount = view.getUint16(RECORD_HEADER.updateSequenceCount, true);
-  const sectors = Math.floor(record.length / FIXUP_SECTOR_BYTES);
-  // Entry 0 holds the sequence number, so sector n's saved trailer is entry n+1.
-  const coveredSectors = Math.max(0, usaCount - 1);
-
-  if (!updateSequenceArrayFits(usaOffset, usaCount, sectors))
-    return {
-      sequenceNumber: 0,
-      entries: usaCount,
-      verifiedSectors: 0,
-      coveredSectors: 0,
-      mismatchSector: null,
-      malformed: true,
-    };
-
-  const sequenceNumber = view.getUint16(usaOffset, true);
-  if (sequenceNumber === 0 || sequenceNumber === 0xffff)
-    return {
-      sequenceNumber,
-      entries: usaCount,
-      verifiedSectors: 0,
-      coveredSectors,
-      mismatchSector: null,
-      malformed: true,
-    };
-  for (let sector = 0; sector < coveredSectors; sector += 1) {
-    const trailerOffset = sector * FIXUP_SECTOR_BYTES + FIXUP_SECTOR_BYTES - 2;
-    if (view.getUint16(trailerOffset, true) !== sequenceNumber)
-      return {
-        sequenceNumber,
-        entries: usaCount,
-        verifiedSectors: sector,
-        coveredSectors,
-        mismatchSector: sector,
-        malformed: false,
-      };
-  }
-
-  return {
-    sequenceNumber,
-    entries: usaCount,
-    verifiedSectors: coveredSectors,
-    coveredSectors,
-    mismatchSector: null,
-    malformed: false,
-  };
-};
-
-/** Buffer the admitted input once while accepting arbitrary chunk boundaries. */
-class StreamingMftDecoder implements RegionDecoder<MftInventory> {
-  readonly #bytes: Uint8Array;
-  #written = 0;
-
-  constructor(fileBytes: number) {
-    this.#bytes = new Uint8Array(fileBytes);
-  }
-
-  write(chunk: Uint8Array): Result<void, RegionDecodeFailure> {
-    if (chunk.length > this.#bytes.length - this.#written)
-      return err(failure("received more bytes than the admitted file length"));
-    this.#bytes.set(chunk, this.#written);
-    this.#written += chunk.length;
-    return ok(undefined);
-  }
-
-  finish(): Result<MftInventory, RegionDecodeFailure> {
-    if (this.#written !== this.#bytes.length)
-      return err(failure("stream ended before the admitted file length"));
-    return scanMft(this.#bytes);
-  }
-}
-
-export const createMftDecoder = (
-  fileBytes: number,
-): Result<RegionDecoder<MftInventory>, RegionDecodeFailure> =>
-  Number.isSafeInteger(fileBytes) &&
-  fileBytes >= 0 &&
-  fileBytes <= MFT_MAX_FILE_BYTES
-    ? ok(new StreamingMftDecoder(fileBytes))
-    : err(
-        limit(
-          `file is ${String(fileBytes)} bytes, exceeding the fixed ${String(MFT_MAX_FILE_BYTES)}-byte (512 MiB) ceiling`,
-          "file-size",
-        ),
-      );

src/ghidra/GhidraFunctionValues.test.ts

@@ -1,3 +1,4 @@
+import { readFile } from "node:fs/promises";
 import { describe, expect, it } from "vitest";
 
 import type { JsonValue } from "../domain/jsonValue.js";
@@ -1119,6 +1120,25 @@ describe("Ghidra native instruction decoder context for ARM TMode and MIPS ISA_M
   });
 });
 
+describe("Ghidra bridge script processor context contract", () => {
+  it("binds TMode to ARM and ISA_MODE to MIPS in ReaGhidraBridge.java", async () => {
+    const bridgePath = new URL(
+      "../../bridge/ghidra/ReaGhidraBridge.java",
+      import.meta.url,
+    );
+    const content = await readFile(bridgePath, "utf8");
+    expect(content).toContain(
+      'currentProgram.getLanguageID().getIdAsString().startsWith("ARM:")',
+    );
+    expect(content).toContain(
+      'currentProgram.getLanguageID().getIdAsString().startsWith("MIPS:")',
+    );
+    expect(content).toContain('"TMode"');
+    expect(content).toContain('"ISA_MODE"');
+    expect(content).toContain('"ghidra-program-context"');
+  });
+});
+
 describe("Ghidra dossier nested boundary composition", () => {
   const identityLocations = [
     "caller",

src/python/PythonPycParser.test.ts

@@ -407,30 +407,6 @@ it("charges long digits to the string budget and keeps large previews bounded",
   );
 });
 
-it("reads marshal one-byte string tags as Latin-1 with Unicode identity", () => {
-  for (const tag of [0x61, 0x41, 0x7a, 0x5a]) {
-    const encoded = Buffer.concat([
-      Buffer.from([tag]),
-      tag === 0x61 || tag === 0x41 ? u32(1) : Buffer.from([1]),
-      Buffer.from([0xe9]),
-    ]);
-    const sameUnicode = marshalUnicode(Buffer.from("é", "utf8"));
-    const set = Buffer.concat([
-      Buffer.from([0x3c]),
-      u32(2),
-      encoded,
-      sameUnicode,
-    ]);
-    const report = root(parse(withConsts([encoded, set])));
-    expect(report.consts[0]).toMatchObject({
-      kind: "str",
-      value: "é",
-      bytes: 1,
-    });
-    expect(report.consts[1]).toEqual({ kind: "set", length: 1 });
-  }
-});
-
 it("decodes marshal strings with CPython surrogatepass rules", () => {
   const report = parse(
     withConsts([marshalUnicode(Buffer.from("efbbbf73eda080efbbbf", "hex"))]),
@@ -1558,36 +1534,6 @@ it("hashes a long TYPE_REF tuple chain without recursing", () => {
   expect(pythonPycSchema.safeParse(report).success).toBe(true);
 });
 
-it("hashes shallow TYPE_REF code chains without using the JavaScript stack", () => {
-  const links = 3000;
-  const codes = Array.from({ length: links }, (_, index) =>
-    marshalCode("py311", {
-      flagged: true,
-      name: "f",
-      consts: index === 0 ? [Buffer.from([0x4e])] : [marshalRef(index - 1)],
-    }),
-  );
-  const bytes = Buffer.concat([
-    pythonPycHeader(3531),
-    marshalCode("py311", {
-      constsObject: Buffer.concat([
-        Buffer.from([0x28]),
-        u32(links + 1),
-        ...codes,
-        Buffer.from([0x3c]),
-        u32(1),
-        marshalRef(links - 1),
-      ]),
-    }),
-  ]);
-  const report = parseWith(bytes, { max_objects: 65_536 });
-  expect(root(report).consts.at(-1)).toEqual({ kind: "set", length: 1 });
-  expect(report.coverage).toMatchObject({
-    status: "complete",
-    code_objects: links + 1,
-  });
-});
-
 it("rejects code CPython treats as corrupt instead of complete coverage", () => {
   const file = (
     layout: "py37" | "py38" | "py311",

src/python/PythonPycParser.ts

@@ -332,7 +332,7 @@ class MarshalReader {
   readonly #codeKeys = new WeakMap<CodeNode, string>();
   readonly #codeIdentities = new WeakMap<CodeNode, number>();
   readonly #codeEquality = new WeakMap<CodeNode, CodeEquality>();
-  /** Completed Python hashability checks per code object. */
+  /** Python hashability per code object. False while that check is in progress. */
   readonly #codeHashable = new WeakMap<CodeNode, boolean>();
   /** Tuples whose items are still being read; CPython cannot hash them yet. */
   readonly #readingTuples = new WeakSet<MarshalValue>();
@@ -436,19 +436,13 @@ class MarshalReader {
         };
       case TYPE_INTERNED:
       case TYPE_UNICODE:
-        return this.string(
-          this.nonNegativeInt32("Marshal string length"),
-          "utf8",
-        );
+        return this.utf8(this.nonNegativeInt32("Marshal string length"), false);
       case TYPE_ASCII:
       case TYPE_ASCII_INTERNED:
-        return this.string(
-          this.nonNegativeInt32("Marshal string length"),
-          "latin1",
-        );
+        return this.utf8(this.nonNegativeInt32("Marshal string length"), true);
       case TYPE_SHORT_ASCII:
       case TYPE_SHORT_ASCII_INTERNED:
-        return this.string(this.u8(), "latin1");
+        return this.utf8(this.u8(), true);
       case TYPE_TUPLE:
         return this.sequenceValue(
           "tuple",
@@ -1315,70 +1309,13 @@ class MarshalReader {
   #isCodeHashable(node: CodeNode): boolean {
     const known = this.#codeHashable.get(node);
     if (known !== undefined) return known;
-    const frames: { value: MarshalValue; finish: boolean }[] = [
-      { value: { kind: "code", value: node }, finish: false },
-    ];
-    const gray = new Set<MarshalValue | CodeNode>();
-    const complete = new Set<MarshalValue>();
-    const reject = (): false => {
-      this.#codeHashable.set(node, false);
-      return false;
-    };
-    while (frames.length > 0) {
-      this.#takeKeyStep();
-      const frame = frames.pop()!;
-      const value = frame.value;
-      const identity = value.kind === "code" ? value.value : value;
-      if (frame.finish) {
-        gray.delete(identity);
-        if (value.kind === "code") {
-          const material =
-            this.#codeEquality.get(value.value) ??
-            malformed("Code object is missing equality material.");
-          // Child code checks are now complete, so the existing tuple key
-          // walker preserves its equality and expansion budgets without recursion.
-          const hashable =
-            this.#equalityKey(material.constsTuple, "hash") !== null;
-          this.#codeHashable.set(value.value, hashable);
-          if (!hashable) return reject();
-        } else complete.add(value);
-        continue;
-      }
-      if (value.kind === "code") {
-        const cached = this.#codeHashable.get(value.value);
-        if (cached === false) return reject();
-        if (cached === true) continue;
-      } else {
-        const cached = this.#keyCache.get(value);
-        if (cached === null) return reject();
-        if (cached !== undefined || complete.has(value)) continue;
-      }
-      if (
-        gray.has(identity) ||
-        this.#readingTuples.has(value) ||
-        value.kind === "list" ||
-        value.kind === "set" ||
-        value.kind === "dict" ||
-        value.kind === "null"
-      )
-        return reject();
-      const children =
-        value.kind === "code"
-          ? [
-              (
-                this.#codeEquality.get(value.value) ??
-                malformed("Code object is missing equality material.")
-              ).constsTuple,
-            ]
-          : value.kind === "tuple" || value.kind === "frozenset"
-            ? value.items
-            : [];
-      gray.add(identity);
-      frames.push({ value, finish: true });
-      for (let index = children.length - 1; index >= 0; index -= 1)
-        frames.push({ value: children[index]!, finish: false });
-    }
-    return true;
+    this.#codeHashable.set(node, false);
+    const material =
+      this.#codeEquality.get(node) ??
+      malformed("Code object is missing equality material.");
+    const hashable = this.#equalityKey(material.constsTuple, "hash") !== null;
+    this.#codeHashable.set(node, hashable);
+    return hashable;
   }
 
   #codeIdentity(node: CodeNode): number {
@@ -1555,20 +1492,17 @@ class MarshalReader {
     );
   }
 
-  string(length: number, encoding: "latin1" | "utf8"): MarshalValue {
+  utf8(length: number, ascii: boolean): MarshalValue {
     const bytes = this.blob(length);
-    if (encoding === "latin1") {
-      // CPython reads the ASCII-tagged forms as one-byte Unicode, even when
-      // high bytes appear. Identity must agree with the UTF-8 string form.
-      const value = bytes.toString("latin1");
+    if (ascii) {
+      if (bytes.some((byte) => byte > 0x7f))
+        malformed("Marshal ASCII string contains a non-ASCII byte.");
       return {
         kind: "str",
-        value,
+        value: bytes.toString("latin1"),
         previewEnd: Math.min(length, PYTHON_PYC_CONST_PREVIEW_LIMIT),
         bytes: length,
-        raw: bytes.some((byte) => byte > 0x7f)
-          ? Buffer.from(value, "utf8")
-          : bytes,
+        raw: bytes,
       };
     }
     const decoded = decodeMarshalUtf8(bytes, PYTHON_PYC_CONST_PREVIEW_LIMIT);

src/server/environment/StateResponseCleanup.ts

@@ -1,53 +0,0 @@
-import {
-  ArtifactResourceScope,
-  type ArtifactResourceOwner,
-} from "../../artifacts/ArtifactResourceScope.js";
-
-/** Retain a cancelled response branch until its underlying cancellation settles. */
-export class StateResponseCleanup {
-  readonly #scope = new ArtifactResourceScope();
-
-  constructor(private readonly changed: () => void = () => {}) {}
-
-  get cleanupResources(): readonly string[] {
-    return this.#scope.cleanupResources;
-  }
-
-  cancel(cancel: () => Promise<void>): void {
-    let state:
-      | { status: "pending" }
-      | { status: "done" }
-      | { status: "failed"; cause: unknown } = { status: "pending" };
-    const owner: ArtifactResourceOwner = {
-      kind: "lease",
-      resource: "state response body",
-      lease: {
-        release: async () => {
-          if (state.status === "pending")
-            throw new Error("State response cancellation is still pending");
-          if (state.status === "failed") throw state.cause;
-        },
-      },
-    };
-    this.#scope.retain(owner);
-    this.changed();
-    void Promise.resolve()
-      .then(cancel)
-      .then(
-        async () => {
-          state = { status: "done" };
-          await this.#scope.release(owner);
-          this.changed();
-        },
-        (cause: unknown) => {
-          state = { status: "failed", cause };
-          this.changed();
-        },
-      )
-      .catch(() => undefined);
-  }
-
-  close(): Promise<void> {
-    return this.#scope.close();
-  }
-}

src/server/environment/environmentDataPlane.ts

@@ -1,4 +1,3 @@
-import { StateResponseCleanup } from "./StateResponseCleanup.js";
 import type { EnvironmentStateStore } from "../../application/environment/environmentStateStore.js";
 import { ArtifactResourceScope } from "../../artifacts/ArtifactResourceScope.js";
 import type { AnalysisInputError } from "../../domain/analysisErrorCore.js";
@@ -47,24 +46,17 @@ interface CallContext {
   readonly intake: StateIntake;
   readonly cancel: AbortSignal;
   readonly files: ArtifactResourceScope;
-  readonly responses: StateResponseCleanup;
 }
 
 /** `data/add`: exactly one part, whose document replaces the whole state only when it is valid and the call was not cancelled. */
 const addState = async (
-  { store, intake, cancel, files, responses }: CallContext,
+  { store, intake, cancel, files }: CallContext,
   params: unknown,
 ): Promise<RpcOutcome> => {
   const parts = isRecord(params) ? params.parts : undefined;
   if (!Array.isArray(parts) || parts.length !== 1)
     return { error: invalidParams("data/add takes exactly one part") };
-  const document = await partDocument(
-    parts[0],
-    intake,
-    cancel,
-    files,
-    responses,
-  );
+  const document = await partDocument(parts[0], intake, cancel, files);
   if (!document.ok) return { error: document.error };
   // A file read is not interruptible, so a cancellation during it is honoured here, before the state changes.
   if (cancel.aborted) return { error: CANCELLED };
@@ -109,7 +101,6 @@ export const stateDataPlane = (
   intake: StateIntake = DEFAULT_STATE_INTAKE,
   stopped: AbortSignal = new AbortController().signal,
   files: ArtifactResourceScope = new ArtifactResourceScope(),
-  responses: StateResponseCleanup = new StateResponseCleanup(),
 ): RpcMethods => {
   let previous: Promise<unknown> = Promise.resolve();
   return (method, params, signal) => {
@@ -120,7 +111,7 @@ export const stateDataPlane = (
     const next = previous.then(() =>
       cancel.aborted
         ? { error: CANCELLED }
-        : run({ store, intake, cancel, files, responses }, params),
+        : run({ store, intake, cancel, files }, params),
     );
     previous = next.catch(() => undefined);
     return next;

src/server/environment/serveEnvironment.ts

@@ -1,4 +1,3 @@
-import { StateResponseCleanup } from "./StateResponseCleanup.js";
 import type { HttpHostname } from "../../domain/httpHostname.js";
 import { STATE_INTAKE_LIMIT_BYTES } from "../../application/environment/environmentStateDocument.js";
 import {
@@ -478,8 +477,6 @@ export const serveEnvironment = async (
   };
   // A state file whose close failed stays owned here: later file reads retry it, and close reports it if it is still open.
   const stateFiles = new ArtifactResourceScope();
-  let responseStateChanged = (): void => undefined;
-  const stateResponses = new StateResponseCleanup(() => responseStateChanged());
   const served = await serveStreamableHttp({
     host,
     port,
@@ -502,7 +499,6 @@ export const serveEnvironment = async (
             },
             stopping.signal,
             stateFiles,
-            stateResponses,
           ),
     ),
     ...(logger === undefined ? {} : { logger }),
@@ -516,14 +512,11 @@ export const serveEnvironment = async (
   });
   let httpClosePending = false;
   let stateClosePending = false;
-  let responseClosePending = false;
-  let settledSuccessful = false;
   let closing: Promise<void> | undefined;
   const shutdownFailures = new Set<AnalysisError>();
   const owner: EnvironmentShutdownOwner = {
     get cleanupResources() {
       const stateResources = stateFiles.cleanupResources;
-      const responseResources = stateResponses.cleanupResources;
       return [
         ...(httpClosePending ? [served.url] : []),
         ...(stateClosePending
@@ -531,11 +524,6 @@ export const serveEnvironment = async (
             ? stateResources
             : ["environment state-file scope"]
           : []),
-        ...(responseClosePending
-          ? responseResources.length > 0
-            ? responseResources
-            : ["state response cleanup"]
-          : []),
       ];
     },
     close: () => {
@@ -543,7 +531,7 @@ export const serveEnvironment = async (
       const attempt = (async () => {
         stop();
         const failures: {
-          readonly stage: "http-server" | "state-files" | "state-responses";
+          readonly stage: "http-server" | "state-files";
           readonly cause: unknown;
         }[] = [];
         try {
@@ -560,15 +548,6 @@ export const serveEnvironment = async (
           stateClosePending = true;
           failures.push({ stage: "state-files", cause });
         }
-        try {
-          await stateResponses.close();
-          if (stateResponses.cleanupResources.length > 0)
-            throw new Error("State response cleanup remains pending");
-          responseClosePending = false;
-        } catch (cause: unknown) {
-          responseClosePending = true;
-          failures.push({ stage: "state-responses", cause });
-        }
         if (failures.length > 0) {
           retainedEnvironmentShutdowns.add(owner);
           const failure = new AnalysisOutputError(
@@ -604,7 +583,6 @@ export const serveEnvironment = async (
         retainedEnvironmentShutdowns.delete(owner);
         for (const failure of shutdownFailures) failure.resolveCleanup();
         shutdownFailures.clear();
-        settledSuccessful = true;
       })();
       closing = attempt;
       void attempt.catch(() => {
@@ -613,26 +591,6 @@ export const serveEnvironment = async (
       return attempt;
     },
   };
-  // A fetcher may hand back a response after an earlier stop completed. Keep
-  // that newly acquired body owned and make a later close observe its outcome.
-  responseStateChanged = () => {
-    if (!stopping.signal.aborted) return;
-    if (stateResponses.cleanupResources.length > 0) {
-      responseClosePending = true;
-      retainedEnvironmentShutdowns.add(owner);
-      if (settledSuccessful) {
-        settledSuccessful = false;
-        closing = undefined;
-      }
-    } else if (
-      shutdownFailures.size === 0 &&
-      !httpClosePending &&
-      !stateClosePending
-    ) {
-      responseClosePending = false;
-      retainedEnvironmentShutdowns.delete(owner);
-    }
-  };
   return ok({
     ...served,
     card,

src/server/environment/serveEnvironmentState.test.ts

@@ -1037,122 +1037,7 @@ describe("serveEnvironment with a state", () => {
       expect(missing.isError).toBe(true);
     });
   });
-});
 
-describe("state response cleanup", () => {
-  it("reports pending teed response cleanup and retries after its sibling closes", async () => {
-    let sourceCancelled = false;
-    const stream = new ReadableStream<Uint8Array>({
-      start(controller) {
-        controller.enqueue(new Uint8Array([1]));
-      },
-      cancel() {
-        sourceCancelled = true;
-      },
-    });
-    const [body, sibling] = stream.tee();
-    const environment = await serveState(
-      { source, state },
-      {
-        fetchState: async () =>
-          new Response(body, {
-            headers: { "content-length": String(STATE_INTAKE_LIMIT_BYTES + 1) },
-          }),
-      },
-    );
-    let timer: ReturnType<typeof setTimeout> | undefined;
-    try {
-      const response = await fetch(
-        new URL(ENVIRONMENT_RPC_PATH, environment.url),
-        {
-          method: "POST",
-          headers: { "content-type": "application/json" },
-          body: JSON.stringify(addByUri(1)),
-          signal: AbortSignal.timeout(10_000),
-        },
-      );
-      await expect(response.json()).resolves.toMatchObject({
-        error: { code: -32602 },
-      });
-      const closing = Promise.race([
-        environment.close(),
-        new Promise<never>((_, reject) => {
-          timer = setTimeout(
-            () => reject(new Error("server close waited for tee sibling")),
-            10_000,
-          );
-        }),
-      ]);
-      await expect(closing).rejects.toMatchObject({
-        _tag: "AnalysisOutputError",
-        cleanupIncomplete: true,
-        diagnostics: { cleanup_stages: ["state-responses"] },
-      });
-      expect(sourceCancelled).toBe(false);
-      await sibling.cancel();
-      expect(sourceCancelled).toBe(true);
-      await expect(environment.close()).resolves.toBeUndefined();
-    } finally {
-      if (timer !== undefined) clearTimeout(timer);
-      await Promise.allSettled([body.cancel(), sibling.cancel()]);
-      await environment.close();
-    }
-  });
-
-  it("retains a late response cleanup after an earlier successful stop", async () => {
-    let giveResponse!: (response: Response) => void;
-    const gate = new Promise<Response>((resolve) => {
-      giveResponse = resolve;
-    });
-    const held = heldFetcher(() => gate);
-    let release!: () => void;
-    let acknowledge!: () => void;
-    const cleanup = new Promise<void>((resolve) => {
-      release = resolve;
-    });
-    const entered = new Promise<void>((resolve) => {
-      acknowledge = resolve;
-    });
-    const environment = await serveState(
-      { source, state },
-      { fetchState: held.fetchState },
-    );
-    const answered = fetch(new URL(ENVIRONMENT_RPC_PATH, environment.url), {
-      method: "POST",
-      headers: { "content-type": "application/json" },
-      body: JSON.stringify(addByUri(1)),
-      signal: AbortSignal.timeout(10_000),
-    }).catch(() => undefined);
-    try {
-      await held.fetching;
-      await environment.close();
-      giveResponse(
-        new Response(
-          new ReadableStream<Uint8Array>({
-            cancel() {
-              acknowledge();
-              return cleanup;
-            },
-          }),
-        ),
-      );
-      await entered;
-      await expect(environment.close()).rejects.toMatchObject({
-        _tag: "AnalysisOutputError",
-        cleanupIncomplete: true,
-        diagnostics: { cleanup_stages: ["state-responses"] },
-      });
-      release();
-      await expect(environment.close()).resolves.toBeUndefined();
-    } finally {
-      release();
-      await answered;
-      await environment.close();
-    }
-  });
-});
-
-describe("serveEnvironment state file cleanup", () => {
   it("stops without waiting for a stalled download", async () => {
     const held = heldFetcher(() => new Promise<Response>(() => undefined));
     const environment = await serveState(

src/server/environment/stateIntake.test.ts

@@ -1,4 +1,3 @@
-import { StateResponseCleanup } from "./StateResponseCleanup.js";
 import { expect, it, vi } from "vitest";
 
 import { ArtifactResourceScope } from "../../artifacts/ArtifactResourceScope.js";
@@ -12,17 +11,14 @@ import {
 
 const inlineDocument = async (bytes: string) => {
   const files = new ArtifactResourceScope();
-  const responses = new StateResponseCleanup();
   try {
     return await partDocument(
       { kind: "file", file: { bytes } },
       DEFAULT_STATE_INTAKE,
       new AbortController().signal,
       files,
-      responses,
     );
   } finally {
-    await responses.close();
     await files.close();
   }
 };
@@ -83,109 +79,3 @@ it("downloads with redirects refused and the 30 s timeout by default", async ()
     fetched.mockRestore();
   }
 });
-
-it.each(["http-status", "declared-overflow", "stream-overflow"] as const)(
-  "returns %s while a teed response's other branch remains open",
-  async (scenario) => {
-    const source = new ReadableStream<Uint8Array>({
-      start(controller) {
-        controller.enqueue(
-          new Uint8Array(
-            scenario === "stream-overflow" ? STATE_INTAKE_LIMIT_BYTES + 1 : 1,
-          ),
-        );
-      },
-    });
-    const [body, sibling] = source.tee();
-    const response = new Response(body, {
-      status: scenario === "http-status" ? 503 : 200,
-      ...(scenario === "declared-overflow"
-        ? {
-            headers: { "content-length": String(STATE_INTAKE_LIMIT_BYTES + 1) },
-          }
-        : {}),
-    });
-    const files = new ArtifactResourceScope();
-    const responses = new StateResponseCleanup();
-    const operation = partDocument(
-      { kind: "file", file: { uri: "https://state.example.test/state.json" } },
-      { fetchState: async () => response, timeoutMs: 1_000 },
-      new AbortController().signal,
-      files,
-      responses,
-    );
-    let timer: ReturnType<typeof setTimeout> | undefined;
-    try {
-      const outcome = await Promise.race([
-        operation.then((result) => ({ kind: "result" as const, result })),
-        new Promise<{ kind: "deadline" }>((resolve) => {
-          timer = setTimeout(() => resolve({ kind: "deadline" }), 3_000);
-        }),
-      ]);
-      expect(outcome.kind).toBe("result");
-      expect(responses.cleanupResources).toEqual(["state response body"]);
-      await expect(responses.close()).rejects.toMatchObject({
-        reason: "unavailable",
-      });
-      if (outcome.kind === "result") {
-        expect(outcome.result).toMatchObject(
-          scenario === "http-status"
-            ? { ok: false, error: { data: { reason: "http-status" } } }
-            : {
-                ok: false,
-                error: {
-                  message: expect.stringContaining(
-                    String(STATE_INTAKE_LIMIT_BYTES),
-                  ),
-                },
-              },
-        );
-      }
-    } finally {
-      if (timer !== undefined) clearTimeout(timer);
-      await sibling.cancel();
-      await operation;
-      await responses.close();
-      await files.close();
-    }
-  },
-);
-
-it("retains the exact failure when response cancellation rejects", async () => {
-  const failure = new Error("controlled cancellation failure");
-  const body = new ReadableStream<Uint8Array>({
-    cancel() {
-      throw failure;
-    },
-  });
-  const files = new ArtifactResourceScope();
-  const responses = new StateResponseCleanup();
-  const result = await partDocument(
-    { kind: "file", file: { uri: "https://state.example.test/state.json" } },
-    {
-      fetchState: async () => new Response(body, { status: 503 }),
-      timeoutMs: 1_000,
-    },
-    new AbortController().signal,
-    files,
-    responses,
-  );
-  expect(result).toMatchObject({
-    ok: false,
-    error: { data: { reason: "http-status" } },
-  });
-  await new Promise<void>((resolve) => setImmediate(resolve));
-  const rejected: unknown = await responses
-    .close()
-    .catch((cause: unknown) => cause);
-  expect(rejected).toMatchObject({
-    reason: "unavailable",
-    cleanup: { resources: ["state response body"] },
-  });
-  expect((rejected as Error).cause).toBeInstanceOf(AggregateError);
-  expect(((rejected as Error).cause as AggregateError).errors).toContain(
-    failure,
-  );
-  expect(responses.cleanupResources).toEqual(["state response body"]);
-  await files.close();
-});

src/server/environment/stateIntake.ts

@@ -1,4 +1,3 @@
-import { StateResponseCleanup } from "./StateResponseCleanup.js";
 import { fileURLToPath } from "node:url";
 
 import { mediaTypeEssence } from "../../domain/analysisView/recordedMediaType.js";
@@ -229,7 +228,6 @@ const downloadBounds = (
 const readCapped = async (
   body: ReadableStream<Uint8Array> | null,
   bounds: DownloadBounds,
-  responses: StateResponseCleanup,
 ): Promise<Result<Buffer, RpcError>> => {
   if (body === null) return ok(Buffer.alloc(0));
   const reader = body.getReader();
@@ -242,15 +240,13 @@ const readCapped = async (
       if (done) return ok(Buffer.concat(chunks, total));
       total += value.byteLength;
       if (total > STATE_INTAKE_LIMIT_BYTES) {
-        // A tee's sibling can be caller-owned; cancelling this branch must not
-        // delay the refusal until that sibling finishes.
-        responses.cancel(() => reader.cancel());
+        await reader.cancel().catch(() => undefined);
         return err(TOO_LARGE);
       }
       chunks.push(value);
     }
   } catch {
-    responses.cancel(() => reader.cancel());
+    void reader.cancel().catch(() => undefined);
     return err(fetchFailed(bounds.failure()));
   }
 };
@@ -260,7 +256,6 @@ const downloadState = async (
   url: URL,
   intake: StateIntake,
   cancel: AbortSignal,
-  responses: StateResponseCleanup,
 ): Promise<Result<Buffer, RpcError>> => {
   const bounds = downloadBounds(intake.timeoutMs, cancel);
   const fetching = Promise.resolve().then(() =>
@@ -273,9 +268,7 @@ const downloadState = async (
     // A response that arrives after the download ended is released unread.
     void fetching
       .then(
-        (late) => {
-          if (late.body !== null) responses.cancel(() => late.body!.cancel());
-        },
+        (late) => late.body?.cancel(),
         () => undefined,
       )
       .catch(() => undefined);
@@ -283,8 +276,7 @@ const downloadState = async (
   }
   const declared = Number(response.headers.get("content-length") ?? "0");
   if (!response.ok || declared > STATE_INTAKE_LIMIT_BYTES) {
-    // Cancel this branch without waiting for a potentially independent tee sibling.
-    if (response.body !== null) responses.cancel(() => response.body!.cancel());
+    await response.body?.cancel().catch(() => undefined);
     return err(
       response.ok
         ? TOO_LARGE
@@ -294,7 +286,7 @@ const downloadState = async (
           },
     );
   }
-  return readCapped(response.body, bounds, responses);
+  return readCapped(response.body, bounds);
 };
 
 const NETWORK_SHARE = invalidParams(
@@ -323,7 +315,6 @@ const fileBytes = async (
   intake: StateIntake,
   cancel: AbortSignal,
   files: ArtifactResourceScope,
-  responses: StateResponseCleanup,
 ): Promise<Result<Uint8Array, RpcError>> => {
   if (typeof file.bytes === "string" && file.uri === undefined) {
     if (file.bytes.length > MAX_INLINE_BASE64_CHARACTERS) return err(TOO_LARGE);
@@ -342,8 +333,7 @@ const fileBytes = async (
       invalidParams("a file part carries exactly one of bytes or a uri"),
     );
   const url = new URL(file.uri);
-  if (url.protocol === "https:")
-    return downloadState(url, intake, cancel, responses);
+  if (url.protocol === "https:") return downloadState(url, intake, cancel);
   if (url.protocol !== "file:")
     return err(invalidParams("a file uri is a file:// or https:// URL"));
   const path = localFilePath(url);
@@ -356,7 +346,6 @@ export const partDocument = async (
   intake: StateIntake,
   cancel: AbortSignal,
   files: ArtifactResourceScope,
-  responses: StateResponseCleanup,
 ): Promise<Result<unknown, RpcError>> => {
   if (isRecord(part) && part.kind === "data" && isRecord(part.data))
     return ok(part.data);
@@ -373,6 +362,6 @@ export const partDocument = async (
       mediaTypeEssence(mimeType) !== "application/json")
   )
     return err(invalidParams("a file part's mimeType is application/json"));
-  const bytes = await fileBytes(part.file, intake, cancel, files, responses);
+  const bytes = await fileBytes(part.file, intake, cancel, files);
   return bytes.ok ? parseDocumentBytes(bytes.value) : bytes;
 };

tests/acceptance/applications/javascriptChildProcessStdioCli.test.ts

@@ -15,13 +15,6 @@ const cases = [
     0,
   ],
   ['spawn("control", [], {stdio:"inherit"})', "control", "inherit", 0],
-  ['spawn("global-nan-env", [], {env:NaN})', "global-nan-env", "default", 0],
-  [
-    '((NaN) => spawn("shadowed-nan-env", [], {env:NaN}))({})',
-    "shadowed-nan-env",
-    "default",
-    0,
-  ],
   [
     'spawn("spread-after", [], {stdio:"pipe",...input})',
     "spread-after",
@@ -240,12 +233,6 @@ const exportAssignmentSource = `
   export = argv;
 `;
 
-const environmentCommands = [
-  "named-argv",
-  "execfile-dynamic",
-  "shadowed-nan-env",
-];
-
 // Callback/options ambiguity cannot change exec's effective stdio.
 const opaqueExecCallbackCommands = [
   "eval-callback",
@@ -355,7 +342,7 @@ cliTest.for(["CLI", "stdio MCP"] as const)(
       expect(child.properties.stdio_mode, String(command)).toBe(mode);
       expect(child.properties.argv_count, String(command)).toBe(count);
       expect(child.properties.environment_supplied, String(command)).toBe(
-        environmentCommands.includes(String(command)),
+        ["named-argv", "execfile-dynamic"].includes(String(command)),
       );
       expect(child.identity.source_range).not.toBeNull();
       const stdio = graph.relations.filter(
@@ -390,7 +377,9 @@ cliTest.for(["CLI", "stdio MCP"] as const)(
             relation.relation === "supplies-env" &&
             relation.target_node_id === child.node_id,
         ),
-      ).toHaveLength(environmentCommands.includes(String(command)) ? 1 : 0);
+      ).toHaveLength(
+        ["named-argv", "execfile-dynamic"].includes(String(command)) ? 1 : 0,
+      );
       expect(
         graph.relations.filter(
           (relation) =>

tests/boundary/cli/cutterVerifierPlatform.test.ts

@@ -1,72 +1,81 @@
-import { readFile, readdir } from "node:fs/promises";
+import { execFile } from "node:child_process";
+import { readFile, readdir, writeFile } from "node:fs/promises";
 import { join } from "node:path";
-import { expect } from "vitest";
+import { promisify } from "node:util";
+import { expect, it } from "vitest";
 import { parse } from "yaml";
-import { resolveSwiftcCompileTimeoutMs } from "../../../src/process/DarwinProcessRunTokenReader.js";
 import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
-import { processTest } from "../../support/process/processFixture.js";
 
-const hostLabels: Partial<Record<NodeJS.Platform, string>> = {
-  linux: "linux",
-  darwin: "macOS",
-  win32: "Windows",
-};
-const hostLabel = hostLabels[process.platform];
-const preparationBudget =
-  process.platform === "darwin" ? resolveSwiftcCompileTimeoutMs() : 0;
+const execute = promisify(execFile);
 
-processTest.skipIf(hostLabel === undefined)(
-  "enforces workflow platform labels before contacting Cutter",
-  { timeout: Math.min(2_147_483_647, 2 * preparationBudget + 30_000) },
-  async ({ processes }) => {
-    const workflow = parse(
-      await readFile(".github/workflows/real-cutter.yml", "utf8"),
-    );
-    const labels = workflow.jobs["cutter-upstream"].strategy.matrix.include.map(
-      (entry: { platform: string }) => entry.platform,
-    );
-    expect(labels).toEqual(["linux", "macOS", "Windows"]);
-    const root = await createTestTempDirectory("rea-cutter-platform-");
-    // A private absent directory proves actual discovery without contacting a user's bridge.
-    const bridgeDirectory = join(root, "absent-bridge");
-    const check = async (selected: string | undefined) => {
-      const env: NodeJS.ProcessEnv = {
-        ...process.env,
-        TMPDIR: root,
-        TMP: root,
-        TEMP: root,
-        REA_CUTTER_BRIDGE_DIR: bridgeDirectory,
-      };
-      if (selected === undefined) delete env.EXPECTED_PLATFORM;
-      else env.EXPECTED_PLATFORM = selected;
-      const result = await processes.run(
-        process.execPath,
-        ["scripts/verify-real-cutter.mjs"],
-        {
-          env,
-          timeoutMs: Math.min(2_147_483_647, preparationBudget + 15_000),
-        },
-      );
-      expect(result.exitCode, result.stderr).toBe(1);
-      return result.stderr;
+it("enforces workflow platform labels before contacting Cutter", async () => {
+  const workflow = parse(
+    await readFile(".github/workflows/real-cutter.yml", "utf8"),
+  );
+  const labels = workflow.jobs["cutter-upstream"].strategy.matrix.include.map(
+    (entry: { platform: string }) => entry.platform,
+  );
+  expect(labels).toEqual(["linux", "macOS", "Windows"]);
+  const root = await createTestTempDirectory("rea-cutter-platform-");
+  const preload = join(root, "preload.mjs");
+  await writeFile(
+    preload,
+    `
+import childProcess from 'node:child_process';
+import { syncBuiltinESMExports } from 'node:module';
+Object.defineProperty(process, 'platform', { value: process.env.REA_PROBE_PLATFORM });
+childProcess.execFile = () => { throw new Error('fixture discovery reached'); };
+syncBuiltinESMExports();
+`,
+  );
+  const check = async (selected: string | undefined, actual: string) => {
+    const env: NodeJS.ProcessEnv = {
+      ...process.env,
+      TMPDIR: root,
+      TMP: root,
+      TEMP: root,
+      REA_PROBE_PLATFORM: actual,
     };
-    for (const selected of [hostLabel, undefined]) {
-      const stderr = await check(selected);
-      expect(stderr).toContain("Open upstream Cutter with the REA plugin");
-      expect(stderr).toContain("no_live_bridge_found");
-    }
-    const other = labels.find((label: string) => label !== hostLabel);
-    expect(other).toBeDefined();
-    expect(await check(other)).toContain(
-      "Cutter runner did not match its declared platform",
+    if (selected === undefined) delete env.EXPECTED_PLATFORM;
+    else env.EXPECTED_PLATFORM = selected;
+    const result: unknown = await execute(
+      process.execPath,
+      ["--import", preload, "scripts/verify-real-cutter.mjs"],
+      { env, timeout: 10_000 },
+    ).then(
+      () => {
+        throw new Error("Fixture discovery should stop the verifier");
+      },
+      (error: unknown) => error,
     );
-    expect(await check("unknown")).toContain(
-      "Unrecognized Cutter runner platform",
+    if (
+      !(result instanceof Error) ||
+      !("stderr" in result) ||
+      typeof result.stderr !== "string"
+    )
+      throw new Error("Missing verifier diagnostics");
+    return result.stderr;
+  };
+  for (const [selected, actual] of [
+    ["linux", "linux"],
+    ["macOS", "darwin"],
+    ["Windows", "win32"],
+  ] as const)
+    expect(await check(selected, actual)).toContain(
+      "fixture discovery reached",
     );
-    expect(
-      (await readdir(root)).filter((name) =>
-        name.startsWith("rea-cutter-smoke-"),
-      ),
-    ).toEqual([]);
-  },
-);
+  expect(await check("linux", "darwin")).toContain(
+    "Cutter runner did not match its declared platform",
+  );
+  expect(await check("unknown", "linux")).toContain(
+    "Unrecognized Cutter runner platform",
+  );
+  expect(await check(undefined, "linux")).toContain(
+    "fixture discovery reached",
+  );
+  expect(
+    (await readdir(root)).filter((name) =>
+      name.startsWith("rea-cutter-smoke-"),
+    ),
+  ).toEqual([]);
+});

tests/boundary/cli/reconstructionCoverageCli.test.ts

@@ -20,19 +20,38 @@ const currentCoverage = () => {
   };
 };
 
-const evaluate = async (cli: TestCli, coverage: unknown) => {
+const evaluate = async (
+  cli: TestCli,
+  coverage: unknown,
+  boundaryId = "replacement.cli",
+) => {
   const root = await createTestTempDirectory("rea-coverage-cli-");
   const input = join(root, "request.json");
-  await writeFile(
-    input,
-    JSON.stringify({ coverage, boundary_id: "replacement.cli" }),
-  );
+  await writeFile(input, JSON.stringify({ coverage, boundary_id: boundaryId }));
   return cli.run({
     arguments: ["evaluate-reconstruction-coverage", input, "--json"],
     cwd: root,
   });
 };
 
+cliTest(
+  "distinguishes malformed boundary IDs from unknown IDs",
+  async ({ cli }) => {
+    const coverage = currentCoverage();
+    for (const [boundaryId, reason] of [
+      ["replacement cli", "invalid_format"],
+      ["replacement.other", "invalid_value"],
+    ] as const) {
+      const result = await evaluate(cli, coverage, boundaryId);
+      expect(result.exitCode).toBe(1);
+      expect(result.json).toMatchObject({
+        code: "invalid_request",
+        details: { issues: [{ path: ["boundary_id"], reason }] },
+      });
+    }
+  },
+);
+
 cliTest(
   "evaluates complete inline coverage through the compiled CLI",
   async ({ cli }) => {

tests/boundary/filesystem/ciChangeScope.test.ts

@@ -783,7 +783,7 @@ it.each([
     { code: false, ghidra_bridge: true, runtime: false, package: false },
   ],
   [
-    "tests/conformance/ghidra/ReaInstructionContextProbe.java",
+    "tests/conformance/ghidra/ReaArmContextProbe.java",
     { ghidra_bridge: true, runtime: false, package: false },
   ],
   [

tests/boundary/mcp/ntfsMftAdmission.test.ts

@@ -1,84 +0,0 @@
-import { writeFile } from "node:fs/promises";
-import { join } from "node:path";
-
-import { expect } from "vitest";
-
-import { createBinarySession } from "../../../src/composition/binary.js";
-import { parseConfig } from "../../../src/config/parseConfig.js";
-import { artifactInspectionResultSchema } from "../../../src/domain/artifactInspection.js";
-import { parseEvidence } from "../../../src/domain/evidence.js";
-import { silentLogger } from "../../../src/logger.js";
-import { createServer } from "../../../src/server/createServer.js";
-import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
-import { mcpTest } from "../../support/mcp/mcpFixture.js";
-import { serveCli } from "../cli/cliServeHarness.js";
-
-const expectMftInventory = (value: unknown): void => {
-  const evidence = parseEvidence(value);
-  const inspection = artifactInspectionResultSchema.parse(
-    evidence.normalized_result,
-  );
-  const inventory = inspection.substeps[0]?.evidence.normalized_result;
-  expect(inventory?.manifest.root_format).toBe("ntfs-mft");
-  expect(inventory?.occurrences[0]?.format_metadata).toMatchObject({
-    kind: "ntfs-mft",
-    record_count: 1,
-    fixup_unverified_record_count: 0,
-    record_headers: [
-      {
-        index: 0,
-        fileOffset: 0,
-        sequenceNumber: 1,
-        declaredRecordNumber: null,
-        fixups: { verifiedSectors: 2 },
-      },
-    ],
-    omitted_record_headers: 0,
-  });
-};
-
-mcpTest(
-  "admits an MFT capture by signature through CLI and MCP",
-  async ({ mcp, onTestFinished }) => {
-    const root = await createTestTempDirectory("rea-ntfs-mft-admission-");
-    const path = join(root, "capture.bin");
-    const record = Buffer.alloc(1024);
-    record.write("FILE");
-    record.writeUInt16LE(42, 4);
-    record.writeUInt16LE(3, 6);
-    record.writeUInt16LE(1, 16);
-    record.writeUInt16LE(56, 20);
-    record.writeUInt32LE(64, 24);
-    record.writeUInt32LE(0xffff_ffff, 56);
-    record.writeUInt32LE(1024, 28);
-    record.writeUInt16LE(5, 42);
-    record.writeUInt16LE(5, 510);
-    record.writeUInt16LE(5, 1022);
-    await writeFile(path, record);
-
-    const cli = await serveCli(["inspect-artifact", path, "--json"]);
-    expect(cli.exitCode, cli.stdout).toBe(0);
-    expectMftInventory(JSON.parse(cli.stdout));
-
-    const configured = parseConfig({ REA_ANALYSIS_PROVIDER: "auto" });
-    if (!configured.ok) throw configured.error;
-    const session = createBinarySession(configured.value, silentLogger, {});
-    onTestFinished(async () => {
-      await session.close();
-    });
-    const client = await mcp.connect(
-      createServer({ kind: "session", session }),
-    );
-    const opened = await client.callTool({
-      name: "open_binary",
-      arguments: { path },
-    });
-    expect(opened.isError, JSON.stringify(opened.content)).not.toBe(true);
-    const inspected = await client.callTool({
-      name: "inspect_artifact",
-      arguments: {},
-    });
-    expect(inspected.isError, JSON.stringify(inspected.content)).not.toBe(true);
-    expectMftInventory(inspected.structuredContent);
-  },
-);

tests/boundary/mcp/reconstructionCoverageMcp.test.ts

@@ -19,6 +19,27 @@ import { createTestBinarySession } from "../../fixtures/binarySession.js";
 import { createServer } from "../../../src/server/createServer.js";
 import { observed } from "../../fixtures/analysisExecution.js";
 
+it("rejects malformed boundary identifiers at the MCP request boundary", async () => {
+  await withCoverageMcp(async ({ client }) => {
+    const result = await client.callTool({
+      name: "evaluate_reconstruction_coverage",
+      arguments: {
+        coverage: currentFixtureCoverage(),
+        boundary_id: "replacement cli",
+      },
+    });
+    expect(result.isError).toBe(true);
+    expect(parseMcpToolError(result)).toMatchObject({
+      error: {
+        code: "invalid_request",
+        details: {
+          issues: [{ path: ["boundary_id"], reason: "invalid_format" }],
+        },
+      },
+    });
+  });
+});
+
 it("uses the latest listed unknown revision when evaluating a boundary", async () => {
   await withCoverageMcp(async ({ client }) => {
     const base = currentFixtureCoverage();

tests/boundary/process/agentEvaluationCommands.test.ts

@@ -1,4 +1,4 @@
-import { readFile, stat, writeFile } from "node:fs/promises";
+import { readFile, writeFile } from "node:fs/promises";
 import { join } from "node:path";
 import { fileURLToPath } from "node:url";
 import { expect } from "vitest";
@@ -175,11 +175,7 @@ registerHooks({ load(url, context, nextLoad) {
         ),
       ],
       {
-        env: {
-          ...process.env,
-          REA_AGENT_EVAL_ROOT: parent,
-          REA_AGENT_EVAL_KEEP_FIXTURES: "false",
-        },
+        env: { ...process.env, REA_AGENT_EVAL_ROOT: parent },
         timeoutMs: 10_000,
       },
     );
@@ -194,13 +190,14 @@ registerHooks({ load(url, context, nextLoad) {
     if (incomplete) {
       expect(result.stderr).toContain("Artifact cleanup remains incomplete");
       expect(result.stderr).toContain("fixture cleanup denied");
-      expect((await stat(run)).isDirectory()).toBe(true);
+      expect(await readFile(join(run, "codex/auth.json"), "utf8")).toBe(
+        "inert fixture",
+      );
     } else {
-      await expect(stat(run)).rejects.toMatchObject({ code: "ENOENT" });
+      await expect(
+        readFile(join(run, "codex/auth.json")),
+      ).rejects.toMatchObject({ code: "ENOENT" });
     }
-    await expect(readFile(join(run, "codex/auth.json"))).rejects.toMatchObject({
-      code: "ENOENT",
-    });
   },
 );
 
@@ -277,11 +274,7 @@ registerHooks({ load(url, context, nextLoad) {
         ),
       ],
       {
-        env: {
-          ...process.env,
-          REA_AGENT_EVAL_ROOT: parent,
-          REA_AGENT_EVAL_KEEP_FIXTURES: "false",
-        },
+        env: { ...process.env, REA_AGENT_EVAL_ROOT: parent },
         timeoutMs: 10_000,
       },
     );
@@ -305,14 +298,13 @@ registerHooks({ load(url, context, nextLoad) {
     if (incomplete) {
       expect(result.stderr).toContain("Artifact cleanup remains incomplete");
       expect(result.stderr).toContain("darwin-fixture-reader");
-      expect((await stat(observed.run)).isDirectory()).toBe(true);
+      expect(
+        await readFile(join(observed.run, "codex/auth.json"), "utf8"),
+      ).toBe("inert preparation fixture");
     } else {
-      await expect(stat(observed.run)).rejects.toMatchObject({
-        code: "ENOENT",
-      });
+      await expect(
+        readFile(join(observed.run, "codex/auth.json")),
+      ).rejects.toMatchObject({ code: "ENOENT" });
     }
-    await expect(
-      readFile(join(observed.run, "codex/auth.json")),
-    ).rejects.toMatchObject({ code: "ENOENT" });
   },
 );

tests/boundary/process/releaseArtifactCanary.test.ts

@@ -1,57 +1,24 @@
+import { execFile } from "node:child_process";
 import {
   copyFile,
-  cp,
   mkdir,
   readFile,
   symlink,
   writeFile,
 } from "node:fs/promises";
-import { join, resolve } from "node:path";
-import { expect } from "vitest";
+import { dirname, join, resolve } from "node:path";
+import { promisify } from "node:util";
+import { expect, it } from "vitest";
 import { z } from "zod";
 import { createApplicationMcpHarness } from "../../fixtures/applicationMcpHarness.js";
 import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
-import { processTest } from "../../support/process/processFixture.js";
-import { resolveSwiftcCompileTimeoutMs } from "../../../src/process/DarwinProcessRunTokenReader.js";
 
-const preparationBudget =
-  process.platform === "darwin" ? resolveSwiftcCompileTimeoutMs() : 0;
-
-async function prepareController(controller: string, version: string) {
-  // The verifier loads its production-owned TypeScript source graph at runtime.
-  // Keep that graph in the isolated controller so imports cannot drift from a hand-maintained list.
-  await mkdir(join(controller, "scripts"), { recursive: true });
-  await copyFile(
-    "scripts/verify-release-artifact.mjs",
-    join(controller, "scripts/verify-release-artifact.mjs"),
-  );
-  await cp("scripts/lib", join(controller, "scripts/lib"), {
-    recursive: true,
-  });
-  await mkdir(join(controller, "bridge"), { recursive: true });
-  await cp("bridge/process", join(controller, "bridge/process"), {
-    recursive: true,
-  });
-  await cp("src", join(controller, "src"), {
-    recursive: true,
-    filter: (source) => !/\.(?:test|spec)\.[cm]?[jt]sx?$/u.test(source),
-  });
-  await writeFile(
-    join(controller, "package.json"),
-    JSON.stringify({ name: "rea-agents", version, type: "module" }),
-  );
-  await symlink(
-    resolve("node_modules"),
-    join(controller, "node_modules"),
-    process.platform === "win32" ? "junction" : "dir",
-  );
-}
+const execute = promisify(execFile);
 
 // Release rehearsal runs on Linux; the npm process adapter is also exercised on macOS.
-processTest.skipIf(process.platform === "win32")(
+it.skipIf(process.platform === "win32")(
   "fails without declared runtime, then rehearses an installed tarball and rejects catalog drift",
-  { timeout: Math.min(2_147_483_647, 3 * preparationBudget + 210_000) },
-  async ({ processes }) => {
+  async () => {
     const root = await createTestTempDirectory("rea-release-canary-");
     const candidate = join(root, "candidate");
     const controller = join(root, "controller");
@@ -109,46 +76,56 @@ if (process.argv[2] === "mcp") {
 } else { process.exitCode = 1; }
 `,
     );
-    const pack = async () => {
-      const result = await processes.run(
-        "npm",
-        ["pack", "--ignore-scripts", "--json"],
-        { cwd: candidate, timeoutMs: 30_000 },
-      );
-      expect(result.exitCode, result.stderr).toBe(0);
-      return result;
-    };
-    const packed = await pack();
+    const packed = await execute(
+      "npm",
+      ["pack", "--ignore-scripts", "--json"],
+      {
+        cwd: candidate,
+      },
+    );
     const [{ filename }] = z
       .tuple([z.object({ filename: z.string() })])
       .parse(JSON.parse(packed.stdout));
     const tarball = join(candidate, filename);
-    await prepareController(controller, version);
+    for (const file of [
+      "scripts/verify-release-artifact.mjs",
+      "scripts/lib/release-package-canary.mjs",
+      "scripts/lib/verify-package-core.mjs",
+      "scripts/lib/mcp-verifier-results.mjs",
+      "scripts/lib/verifier-run.mjs",
+    ]) {
+      const target = join(controller, file);
+      await mkdir(dirname(target), { recursive: true });
+      await copyFile(file, target);
+    }
+    await writeFile(
+      join(controller, "package.json"),
+      JSON.stringify({ name: "rea-agents", version, type: "module" }),
+    );
+    await symlink(
+      resolve("node_modules"),
+      join(controller, "node_modules"),
+      process.platform === "win32" ? "junction" : "dir",
+    );
     const invoke = (selected = tarball) =>
-      processes.run(
+      execute(
         process.execPath,
         [
           join(controller, "scripts/verify-release-artifact.mjs"),
           selected,
           version,
         ],
-        {
-          cwd: controller,
-          timeoutMs: Math.min(2_147_483_647, preparationBudget + 30_000),
-        },
+        { cwd: controller, maxBuffer: 16 * 1024 * 1024 },
       );
-    const missing = await invoke();
-    expect(missing.exitCode).toBe(1);
-    expect(missing.stderr).toContain("ERR_MODULE_NOT_FOUND");
-    expect(missing.stderr).toMatch(/dist[/\\]catalogIdentity\.js/u);
+    await expect(invoke()).rejects.toMatchObject({
+      stderr: expect.stringContaining("ERR_MODULE_NOT_FOUND"),
+    });
     await symlink(
       resolve("dist"),
       join(controller, "dist"),
       process.platform === "win32" ? "junction" : "dir",
     );
-    const successful = await invoke();
-    expect(successful.exitCode, successful.stderr).toBe(0);
-    const result = JSON.parse(successful.stdout);
+    const result = JSON.parse((await invoke()).stdout);
     expect(result).toMatchObject({
       package: "rea-agents",
       version,
@@ -167,10 +144,12 @@ if (process.argv[2] === "mcp") {
       join(candidate, "scripts/reply.json"),
       JSON.stringify(snapshot),
     );
-    await pack();
-    const drifted = await invoke();
-    expect(drifted.exitCode).toBe(1);
-    expect(drifted.stderr).toContain("invalid canonical tool catalog");
+    await execute("npm", ["pack", "--ignore-scripts", "--json"], {
+      cwd: candidate,
+    });
+    await expect(invoke()).rejects.toMatchObject({
+      stderr: expect.stringContaining("invalid canonical tool catalog"),
+    });
     await writeFile(
       join(candidate, "package.json"),
       JSON.stringify({
@@ -180,12 +159,15 @@ if (process.argv[2] === "mcp") {
         files: ["scripts"],
       }),
     );
-    const wrong = await pack();
+    const wrong = await execute("npm", ["pack", "--ignore-scripts", "--json"], {
+      cwd: candidate,
+    });
     const [{ filename: wrongFilename }] = z
       .tuple([z.object({ filename: z.string() })])
       .parse(JSON.parse(wrong.stdout));
-    const mismatched = await invoke(join(candidate, wrongFilename));
-    expect(mismatched.exitCode).toBe(1);
-    expect(mismatched.stderr).toContain("Installed package identity");
+    await expect(invoke(join(candidate, wrongFilename))).rejects.toMatchObject({
+      stderr: expect.stringContaining("Installed package identity"),
+    });
   },
+  30_000,
 );

tests/conformance/ghidra/README.md

@@ -21,12 +21,6 @@ no-overwrite CLI delivery. It checks the target and project files for changes.
   Clang/LLD/LLVM readelf/LLVM objdump; `REA_RISCV_CLANG`, `REA_RISCV_LLD`,
   `REA_RISCV_READELF` and `REA_RISCV_OBJDUMP` select existing tool commands.
 
-- `ReaInstructionContextProbe.java` inspects source-owned ARM, Thumb, MIPS32
-  and MIPS16 instructions through the production bridge in an ephemeral,
-  read-only Ghidra project. It checks exact decoder-context register names,
-  values and provenance; the ARM lane also injects an unavailable provider
-  value. The `ghidra-bridge-sources` CI job runs both processor families. The
-  input bytes are never executed.
 - `ReaDecodeProbe.java` decodes source-owned instruction bytes from a
   language's default context and checks each mnemonic, length and optional
   complete operand. The `ghidra-bridge-sources` CI job runs it for `ARM:LE:32:Cortex`,

tests/conformance/ghidra/ReaArmContextProbe.java

@@ -15,20 +15,16 @@ import java.lang.reflect.Proxy;
 import java.math.BigInteger;
 
 /** Real ARM/Thumb decoding; only the unavailable context value is injected. */
-public class ReaInstructionContextProbe extends GhidraScript {
+public class ReaArmContextProbe extends GhidraScript {
     @Override
     public void run() throws Exception {
         String[] args = getScriptArgs();
-        require(args.length == 1 || (args.length == 2 && args[1].equals("mips")), "Expected the bridge directory and optional MIPS mode");
+        require(args.length == 1, "Expected the exact production bridge directory");
         var source = GhidraScriptUtil.findScriptByName("ReaGhidraBridge.java");
         require(source != null && new File(source.getAbsolutePath()).getCanonicalFile().equals(
             new File(args[0], "ReaGhidraBridge.java").getCanonicalFile()), "Production bridge source");
         GhidraScript bridge = GhidraScriptUtil.getProvider(source).getScriptInstance(source, errorWriter);
         bridge.set(getState(), getControls());
-        if (args.length == 2) {
-            checkMips(bridge);
-            return;
-        }
         require(currentProgram.getLanguageID().getIdAsString().equals("ARM:LE:32:v7"), "ARM fixture language");
         var mode = currentProgram.getRegister("TMode");
         require(mode != null, "Real TMode register");
@@ -44,8 +40,8 @@ public class ReaInstructionContextProbe extends GhidraScript {
         space.set(null, arm.getAddressSpace());
         Method inspect = bridge.getClass().getDeclaredMethod("inspectNativeInstruction", JsonObject.class, boolean.class);
         inspect.setAccessible(true);
-        check(inspect, bridge, arm, "0", 4, "1eff2fe1", "TMode");
-        check(inspect, bridge, thumb, "1", 2, "7047", "TMode");
+        check(inspect, bridge, arm, "0", 4, "1eff2fe1");
+        check(inspect, bridge, thumb, "1", 2, "7047");
 
         // getValue includes language defaults. Inject only its unavailable result,
         // preserving the real instruction, register, language and all other APIs.
@@ -61,49 +57,26 @@ public class ReaInstructionContextProbe extends GhidraScript {
         programField.setAccessible(true);
         try {
             programField.set(bridge, program);
-            check(inspect, bridge, arm, null, 4, "1eff2fe1", "TMode");
+            check(inspect, bridge, arm, null, 4, "1eff2fe1");
         } finally {
             programField.set(bridge, original);
         }
         println("REA_ARM_CONTEXT_OK arm=0 thumb=1 unavailable=null (injected provider value)");
     }
 
-    private void checkMips(GhidraScript bridge) throws Exception {
-        require(currentProgram.getLanguageID().getIdAsString().equals("MIPS:LE:32:default"), "MIPS fixture language");
-        var mode = currentProgram.getRegister("ISA_MODE");
-        require(mode != null, "Real ISA_MODE register");
-        Address standard = currentProgram.getMemory().getMinAddress();
-        Address compressed = standard.add(4);
-        var context = currentProgram.getProgramContext();
-        context.setValue(mode, standard, standard.add(3), BigInteger.ZERO);
-        require(disassemble(standard), "MIPS32 instruction decoded");
-        // MIPS32 flow may have decoded following bytes in the default mode.
-        clearListing(compressed, compressed.add(3));
-        context.setValue(mode, compressed, compressed.add(1), BigInteger.ONE);
-        require(disassemble(compressed), "MIPS16 instruction decoded");
-        Field space = bridge.getClass().getDeclaredField("sessionDefaultAddressSpace");
-        space.setAccessible(true);
-        space.set(null, standard.getAddressSpace());
-        Method inspect = bridge.getClass().getDeclaredMethod("inspectNativeInstruction", JsonObject.class, boolean.class);
-        inspect.setAccessible(true);
-        check(inspect, bridge, standard, "0", 4, "03008224", "ISA_MODE");
-        check(inspect, bridge, compressed, "1", 2, "5a6a", "ISA_MODE");
-        println("REA_MIPS_CONTEXT_OK standard=0 mips16=1");
-    }
-
     private static void check(Method inspect, Object bridge, Address address, String mode,
-            int length, String bytes, String register) throws Exception {
+            int length, String bytes) throws Exception {
         JsonObject input = new JsonObject();
         input.add("document", JsonNull.INSTANCE);
         input.addProperty("address", "0x" + Long.toUnsignedString(address.getOffset(), 16));
         JsonObject result = (JsonObject) inspect.invoke(bridge, input, false);
-        require(result.get("status").getAsString().equals("decoded"), "Decoded bridge response: " + result);
-        require(result.get("length").getAsInt() == length, "Instruction width");
+        require(result.get("status").getAsString().equals("decoded"), "Decoded bridge response");
+        require(result.get("length").getAsInt() == length, "ARM/Thumb instruction width");
         require(result.get("bytes").getAsString().equals(bytes), "Original instruction bytes");
         var contexts = result.getAsJsonArray("decoder_context");
         require(contexts != null && contexts.size() == 1, "One retained mode context");
         var value = contexts.get(0).getAsJsonObject();
-        require(value.get("register").getAsString().equals(register), "Exact context register name");
+        require(value.get("register").getAsString().equals("TMode"), "TMode register name");
         require(value.get("source").getAsString().equals("ghidra-program-context"), "Context provenance");
         require(mode == null ? value.get("value").isJsonNull()
             : mode.equals(value.get("value").getAsString()), "Exact mode value " + mode);

tests/fixtures/artifactReaderLifecycle.ts

@@ -252,74 +252,3 @@ export const artifactReaderLifecycleCases = (setup: LifecycleFixture): void => {
     validationCases(setup);
   });
 };
-
-/** An interrupted preparation belongs to its caller, not concurrent readers. */
-export const artifactPreparationRecoveryCases = ({
-  image,
-  createReader,
-}: LifecycleFixture): void => {
-  it.each(["cancelled", "physical failure"] as const)(
-    "preserves independent preparation after %s",
-    async (scenario) => {
-      const path = await fixture(image());
-      const admitted = await openRegularFile(path, { symlinks: "reject" });
-      const reader = createReader(path, admitted);
-      const controller = new AbortController();
-      const reason = { request: "first inventory" };
-      const physical = Object.assign(new Error("controlled read failure"), {
-        code: "EIO",
-      });
-      const reached = createDeferred<void>();
-      const release = createDeferred<void>();
-      const nativeRead = admitted.handle.read.bind(admitted.handle);
-      let blocked = false;
-      const read = vi.spyOn(admitted.handle, "read").mockImplementation((async (
-        ...args: unknown[]
-      ) => {
-        const result = await Reflect.apply(nativeRead, admitted.handle, args);
-        if (!blocked) {
-          blocked = true;
-          reached.resolve();
-          await release.promise;
-          if (scenario === "physical failure") throw physical;
-        }
-        return result;
-      }) as typeof admitted.handle.read);
-      const pending: Promise<unknown>[] = [];
-      try {
-        const first = (async () => {
-          for await (const _ of reader.entries(controller.signal)) {
-          }
-        })();
-        pending.push(first);
-        void first.catch(() => undefined);
-        await awaitAcknowledgement(reached.promise, first, "preparation read");
-        const peer = entries(reader);
-        pending.push(peer);
-        void peer.catch(() => undefined);
-        controller.abort(reason);
-        release.resolve();
-        if (scenario === "physical failure") {
-          await expect(first).rejects.toBe(physical);
-          await expect(peer).rejects.toBe(physical);
-        } else {
-          await expect(first).rejects.toMatchObject({
-            reason: "cancelled",
-            cause: reason,
-          });
-          const recovered = await peer;
-          expect(recovered.length).toBeGreaterThan(0);
-          expect(
-            (await buffer(await reader.open(recovered[0]!))).length,
-          ).toBeGreaterThan(0);
-        }
-      } finally {
-        release.resolve();
-        await Promise.allSettled(pending);
-        read.mockRestore();
-        await reader.close();
-        await admitted.handle.close();
-      }
-    },
-  );
-};