fix(daemon): retain canonical diagnostics for malformed pod roots

packages/daemon/src/domain/up-command-router.ts

@@ -20,10 +20,13 @@ interface RouterFsOps {
 /** Gzip magic bytes: 0x1f 0x8b */
 const GZIP_MAGIC = Buffer.from([0x1f, 0x8b]);
 
-function isPodAwareShape(raw: unknown): boolean {
-  return raw !== null
-    && typeof raw === "object"
-    && Array.isArray((raw as Record<string, unknown>)["pods"]);
+function podSchemaOwnsDiagnostics(raw: unknown): boolean {
+  if (raw === null || typeof raw !== "object" || Array.isArray(raw)) return false;
+  const obj = raw as Record<string, unknown>;
+  if ("pods" in obj) return true;
+  // Legacy owns diagnostics only when the document declares a legacy marker;
+  // otherwise a typo in the canonical root cannot silently switch schemas.
+  return !("nodes" in obj || "schema_version" in obj);
 }
 
 /**
@@ -97,7 +100,7 @@ export class UpCommandRouter {
       // S7: a pod-shaped document belongs to the pod-aware validator even
       // when invalid. Falling through to legacy replaces an exact topology
       // diagnostic with the unrelated "nodes is required" error.
-      if (isPodAwareShape(podRaw)) {
+      if (podSchemaOwnsDiagnostics(podRaw)) {
         throw new Error(`Source is YAML but not a valid rig spec: ${podValidation.errors[0] ?? "unknown error"}`);
       }
 
@@ -157,7 +160,7 @@ export class UpCommandRouter {
       if (podVal.valid) {
         return { sourceKind: "rig_spec", sourceRef };
       }
-      if (isPodAwareShape(podRaw)) {
+      if (podSchemaOwnsDiagnostics(podRaw)) {
         throw new Error(`Source is YAML but not a valid rig spec: ${podVal.errors[0] ?? "unknown error"}. Use .yaml for rig specs or .rigbundle for bundles.`);
       }
 

packages/daemon/test/up-command-router.test.ts

@@ -214,6 +214,30 @@ edges: []
     );
   });
 
+  it.each(["typo-root.yaml", "typo-root"])(
+    "keeps a misspelled pod root on the pod validator for %s",
+    (filename) => {
+      const podSpecWithMisspelledRoot = `
+version: "0.2"
+name: typo-root
+podz:
+  - id: ops
+    label: Ops
+    members: []
+    edges: []
+edges: []
+`.trim();
+      const specPath = path.join(tmpDir, filename);
+      fs.writeFileSync(specPath, podSpecWithMisspelledRoot);
+      const router = new UpCommandRouter({ fsOps: realFsOps() });
+
+      expect(() => router.route(specPath)).toThrow(
+        'podz: unknown key "podz"; refusing the spec because normalization would otherwise discard it and alter the requested topology',
+      );
+      expect(() => router.route(specPath)).not.toThrow(/nodes is required/);
+    },
+  );
+
   // AS-T08b: legacy rig spec still accepted
   it("still routes legacy rig spec as rig_spec", () => {
     const specPath = path.join(tmpDir, "legacy.yaml");