mirror of
https://github.com/mvschwarz/openrig.git
synced 2026-11-12 16:23:00 -10:00
Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
1a52040b6b |
No files matched your search
-246
@@ -8,252 +8,6 @@ deprecations, and behavioral changes. Breaking changes are called out explicitly
|
||||
|
||||
---
|
||||
|
||||
## [0.7.13]
|
||||
|
||||
OpenRig 0.7.13 is a patch for people running their own agent teams. When you answer a runner's permission request, you now get a
|
||||
note back saying who decides it, and the runner wakes on the decision. The
|
||||
agent that reads your answers is told what an answer typed at your machine
|
||||
means and how to ask you back. `rig daemon start` tells the agent setting
|
||||
OpenRig up to offer to register you when nobody is registered yet, and a Claude
|
||||
seat whose usage-limit message states a reset time waits for it instead of being
|
||||
retried. There are fixes across delivery,
|
||||
handover and recovery, the TUI and speed, many contributed by people using
|
||||
OpenRig. In our tests, a first Claude user (with Codex absent) and a first Codex
|
||||
user each went from a fresh install to a built, independently reviewed and
|
||||
committed change. Two repairs aren't in this release: see Known limits.
|
||||
|
||||
### Before you upgrade
|
||||
|
||||
- **Back up the database, then restart the daemon:** `rig daemon stop`, copy the
|
||||
database file (`rig config get db.path` prints its path), then
|
||||
`rig daemon start`. Your agents keep running through a daemon restart; don't
|
||||
use `rig down`, which ends them. Three migrations run on the daemon's first start: 160 and 161 (for the experimental hub connector below)
|
||||
and 162 (indexes for session reads). Going back to 0.7.12 after them isn't
|
||||
established. ([#2993](https://github.com/mvschwarz/openrig/pull/2993), [#2997](https://github.com/mvschwarz/openrig/pull/2997))
|
||||
- **openrig-core is 0.1.29, and the `openrig` plugin now carries the CLI's
|
||||
version, 0.7.13.** A Codex seat can ask for hook approval after the
|
||||
upgrade; see Codex hook review after an upgrade below. ([#3034](https://github.com/mvschwarz/openrig/pull/3034), [#3064](https://github.com/mvschwarz/openrig/pull/3064))
|
||||
|
||||
### Answering your team
|
||||
|
||||
- A runner's permission answer gets a note back to you: who decides it and in
|
||||
what state, or that it's kept and the tool hasn't run. A runner waiting on
|
||||
the decision gets it within about half a second. Read that note before answering again. If
|
||||
it says your answer couldn't be passed on, follow its retry instruction or use
|
||||
the `rig seat decide-permission` command it names.
|
||||
([#3001](https://github.com/mvschwarz/openrig/pull/3001))
|
||||
- The answer a receiving agent reads now says what an answer typed at this
|
||||
machine's terminal or TUI means, to act on a clear answer with the request's
|
||||
own decision command, and how to ask you back with a new ask when it isn't
|
||||
clear. When the default receiving agent asks you back, the question reaches
|
||||
your Feed, and your reply decides. Closing a runner's request without
|
||||
deciding permits nothing. ([#3030](https://github.com/mvschwarz/openrig/pull/3030))
|
||||
- `rig daemon start` ends by telling the agent setting OpenRig up to offer to
|
||||
register you as the team's person, when the person registry can be read and
|
||||
holds nobody. The rigs skill's start step makes the same offer, and asking to
|
||||
be reachable registers you as the default person directly. In our
|
||||
fresh-install tests the setup agent passed the offer on in 5 of 6 installs,
|
||||
and a no registered nothing. Nobody is registered without your yes, and the
|
||||
exit code is unchanged.
|
||||
([#3028](https://github.com/mvschwarz/openrig/pull/3028))
|
||||
- In the change's own tests, before a first team launches, the kernel operator
|
||||
says which commands it will ask permission for and reuses a choice you've
|
||||
already made. Otherwise it makes one offer: allow just the command families
|
||||
your goal repeats, for this project only, applied on your yes. On a no, the
|
||||
team's default stays and the offer isn't repeated. It hasn't been shown to
|
||||
make a first team ask you fewer times. ([#3029](https://github.com/mvschwarz/openrig/pull/3029))
|
||||
- A connected assistant (a hosted member; experimental and off by default) shows
|
||||
whether it's checking in, against a cadence its roster entry states
|
||||
(`check_in_minutes`, or `check_in_on_request: true`): checking in, overdue, no
|
||||
check-in yet, on request, or unknown. `rig roster show` and `find` print it as
|
||||
a Check-in line. It's a status only: work for a member that isn't checking in
|
||||
still queues and rings as before. ([#3023](https://github.com/mvschwarz/openrig/pull/3023))
|
||||
|
||||
### Seats, handover and recovery
|
||||
|
||||
- A Claude seat stopped by a usage limit whose message states a reset time (for
|
||||
example "resets Nov 10, 4pm") parks its pending work until then, instead of
|
||||
being retried every few minutes. ([#2917](https://github.com/mvschwarz/openrig/pull/2917))
|
||||
- A handover whose successor was launched but not ready says it may be running,
|
||||
instead of "retry": look at the pane first. A handover also cleans up the
|
||||
retiring occupant's own claims and jobs. ([#3003](https://github.com/mvschwarz/openrig/pull/3003), [#3024](https://github.com/mvschwarz/openrig/pull/3024))
|
||||
- After `rig unclaim`, the guidance for an adopted session says to end its
|
||||
process and its tmux session, and `rig seat stop`'s help matches. A fresh
|
||||
launch after `rig unclaim` ended the server's last session reopens the server.
|
||||
([#2996](https://github.com/mvschwarz/openrig/pull/2996), [#3006](https://github.com/mvschwarz/openrig/pull/3006), [#3014](https://github.com/mvschwarz/openrig/pull/3014), [#3009](https://github.com/mvschwarz/openrig/pull/3009))
|
||||
- A handover whose successor was launched into the seat's own tmux session
|
||||
can reclaim a claim left by a removed owner, or by an archived owner whose
|
||||
latest session for that node is superseded, detached or exited; a live owner
|
||||
still refuses.
|
||||
When a seat
|
||||
with no declared route can't be woken, the finding goes to the item's creator,
|
||||
skipping a creator that is a terminal seat. ([#2869](https://github.com/mvschwarz/openrig/pull/2869), [#2987](https://github.com/mvschwarz/openrig/pull/2987), [#2995](https://github.com/mvschwarz/openrig/pull/2995))
|
||||
|
||||
### Fixes
|
||||
|
||||
- **Delivery:** Claude's auto-update failure footers, including one clipped form,
|
||||
no longer hold a send to an idle Claude seat; an unrecognised wake result reads unknown, not
|
||||
delivered; an ordinary one-time park wake is kept and retried
|
||||
while its park is current and the failed attempt typed nothing into the seat
|
||||
(an attempt whose effect is unknown needs checking, and repeating waits and
|
||||
usage-limit expiry keep their own lifecycle); a `custody-verified:` note whose target is followed by a
|
||||
period, comma or other closing punctuation now verifies it; the Pi runner pane keeps the operator's
|
||||
draft out of the stream. ([#2948](https://github.com/mvschwarz/openrig/pull/2948), [#3016](https://github.com/mvschwarz/openrig/pull/3016), [#3011](https://github.com/mvschwarz/openrig/pull/3011), [#3038](https://github.com/mvschwarz/openrig/pull/3038), [#3004](https://github.com/mvschwarz/openrig/pull/3004), [#2842](https://github.com/mvschwarz/openrig/pull/2842))
|
||||
- **Codex and Claude:** completed Codex 0.167 turns read idle, and unsupported
|
||||
versions stay unknown; a usage-limit banner with a curly apostrophe is
|
||||
detected; refocus bounds Codex context and records what it left out; an
|
||||
unreadable Claude status-line cache gets its own reason. ([#2954](https://github.com/mvschwarz/openrig/pull/2954), [#2879](https://github.com/mvschwarz/openrig/pull/2879), [#2951](https://github.com/mvschwarz/openrig/pull/2951), [#2880](https://github.com/mvschwarz/openrig/pull/2880))
|
||||
- **TUI and CLI:** instance rows are grouped by rig; for a quiet seat the
|
||||
daemon explicitly reads as unknown, the list, explorer and agent-detail status
|
||||
rows show unknown, not idle (screen motion still shows active, a daemon that
|
||||
serves no activity keeps the screen fallback, and the topology graph is
|
||||
unchanged); Feed times use the configured time zone; the
|
||||
CLI doesn't call a daemon stopped when the shell can't see its process (a
|
||||
sandbox), and says not to start another; ssh options are separated from the
|
||||
target, and the generated attach command quotes the session name. ([#2857](https://github.com/mvschwarz/openrig/pull/2857), [#3012](https://github.com/mvschwarz/openrig/pull/3012), [#3022](https://github.com/mvschwarz/openrig/pull/3022), [#2913](https://github.com/mvschwarz/openrig/pull/2913), [#2973](https://github.com/mvschwarz/openrig/pull/2973), [#2971](https://github.com/mvschwarz/openrig/pull/2971))
|
||||
- **Scope and workflows:** qualified slice reads and proof discovery are scoped
|
||||
by mission; workflow spec reads are recorded across restarts; the spec library skips
|
||||
synthetic alias entries. ([#2960](https://github.com/mvschwarz/openrig/pull/2960), [#2986](https://github.com/mvschwarz/openrig/pull/2986), [#2999](https://github.com/mvschwarz/openrig/pull/2999))
|
||||
- **Guidance and plugins:** guidance cleanup in a repository's `AGENTS.md` or
|
||||
`CLAUDE.md` removes redundant recognized copies of an OpenRig-managed block,
|
||||
including after an editor rewrapped a marker, and keeps distinct edited
|
||||
copies. A saved write record lets OpenRig identify and keep your edits; on a
|
||||
fresh start, a differing block with no write record is refreshed to OpenRig's
|
||||
text and named, while an exact resume or restore keeps it; a bundled plugin's files,
|
||||
including a binary icon, are copied byte for byte; the plugins carry https
|
||||
repository URLs and a PNG icon for Claude's plugin directory, and the Codex
|
||||
manifests link the privacy policy and terms. ([#3020](https://github.com/mvschwarz/openrig/pull/3020), [#3025](https://github.com/mvschwarz/openrig/pull/3025), [#3021](https://github.com/mvschwarz/openrig/pull/3021), [#3064](https://github.com/mvschwarz/openrig/pull/3064))
|
||||
- **Speed:** the daemon is much more responsive while it reads a project's
|
||||
proof, which now yields between missions; current-session reads for the node inventory
|
||||
use an index; the daemon's recorder and Linux clipboard discovery no longer
|
||||
wait on the main thread.
|
||||
([#2970](https://github.com/mvschwarz/openrig/pull/2970), [#2997](https://github.com/mvschwarz/openrig/pull/2997), [#3019](https://github.com/mvschwarz/openrig/pull/3019))
|
||||
- **Docs:** what `rig seat clear-attention`'s check proves, how managed
|
||||
compaction notices are routed, when the keyboard moves in herdr-app, a
|
||||
complete periodic-reminder registration, and starting one stopped kernel seat
|
||||
with `rig launch`. ([#2964](https://github.com/mvschwarz/openrig/pull/2964), [#2984](https://github.com/mvschwarz/openrig/pull/2984), [#2991](https://github.com/mvschwarz/openrig/pull/2991), [#3002](https://github.com/mvschwarz/openrig/pull/3002), [#3031](https://github.com/mvschwarz/openrig/pull/3031))
|
||||
|
||||
### Experimental
|
||||
|
||||
- **`rig network`** connects one local seat to a hub you already have.
|
||||
Experimental, unsupported and at your own risk. The connector uses the MCP
|
||||
SDK, which the installed package already included in 0.7.12. ([#2993](https://github.com/mvschwarz/openrig/pull/2993))
|
||||
|
||||
### Behaviour that changed
|
||||
|
||||
- **A runner's answer is confirmed to you.** Through 0.7.12 no note came back,
|
||||
and the runner waited for its next read. ([#3001](https://github.com/mvschwarz/openrig/pull/3001))
|
||||
- **A usage-limited Claude seat waits for its stated reset**; don't release it
|
||||
by hand on a timer. **A failed handover may have left its successor
|
||||
running**; look at the pane before retrying. ([#2917](https://github.com/mvschwarz/openrig/pull/2917), [#3003](https://github.com/mvschwarz/openrig/pull/3003))
|
||||
- **Passive SSH host status reads `unknown`.** Routine host listings no longer
|
||||
open a TCP connection to SSH hosts, because repeated probes closed without a
|
||||
handshake can make OpenSSH block real logins for a while. Hosts that used to
|
||||
read reachable now read unknown; `rig host doctor` still checks actively.
|
||||
([#2979](https://github.com/mvschwarz/openrig/pull/2979))
|
||||
- **`rig package install` leaves a guidance file alone when a recognized
|
||||
managed block has no complete marker pair,** lists it under "Left as it is:" and installs the rest, instead
|
||||
of appending a second copy. Launch and restore name such a file
|
||||
(`guidance_block_markers_damaged`). ([#3020](https://github.com/mvschwarz/openrig/pull/3020))
|
||||
|
||||
### Known limits
|
||||
|
||||
- **Not in this release:** a Codex snapshot restore or `rig up --existing` can
|
||||
write OpenRig's managed guidance into a tracked `AGENTS.md`, leaving the
|
||||
worktree modified; check `git status` after either operation.
|
||||
- **Not in this release:** a person who talks to the kernel operator first, with
|
||||
no other agent setting OpenRig up, isn't offered registration. `rig up`,
|
||||
`rig start` and `rig context` start the daemon without printing the offer
|
||||
either. Register with `rig gateway human add`. While nobody is registered, a
|
||||
later `rig daemon start` offers again, even after a no; nothing is registered
|
||||
without your yes. ([#3028](https://github.com/mvschwarz/openrig/pull/3028), [#3041](https://github.com/mvschwarz/openrig/pull/3041) isn't in this release)
|
||||
- **The hub connector isn't inert:** the daemon starts it, sweeps leftover
|
||||
credential folders and schedules local rounds even with no binding; only the
|
||||
pass to a hub is absent. Its migrations apply on upgrade. ([#2993](https://github.com/mvschwarz/openrig/pull/2993))
|
||||
- **The recorder:** a queued begin record can be lost before the durable append,
|
||||
and a stalled worker has no acknowledgement timeout. ([#3019](https://github.com/mvschwarz/openrig/pull/3019))
|
||||
- **Speed and memory:** On one performance host, whole `rig queue create`
|
||||
invocations had a median about 10.4% slower than 0.7.12 (about +29 ms). Send
|
||||
latency stayed within the comparison's unchanged range. The cause remains
|
||||
unidentified. The standard idle-memory comparison was inconclusive. A post-hoc
|
||||
analysis of the same six runs found 7.9–8.6 MiB (4.2–5.3%) higher daemon RSS
|
||||
across three matched idle windows, using the median of three arm medians per
|
||||
version. The cause and steady-state behavior remain unestablished.
|
||||
- **Draft-aware delivery ([#3076](https://github.com/mvschwarz/openrig/issues/3076)):** an automatic OpenRig notice can be left beside a
|
||||
draft started during delivery. This also concerns notices admitted by
|
||||
openrig-urgent and urgent-only modes. In the reproduced 0.7.12 Claude Code and
|
||||
Codex cases, the person's draft remained intact and no Enter was sent, but
|
||||
OpenRig's text stayed in the input. The guard and paste path are unchanged in
|
||||
this cut; a native 0.7.13 reproduction has not run.
|
||||
- **Native model pickers:** with a /model picker open, an ordinary send can act
|
||||
on the picker instead of delivering the message. In 0.7.12 tests it confirmed
|
||||
Claude Code's already-selected default and advanced Codex's model selection;
|
||||
neither message reached the model. Close or deliberately resolve the picker
|
||||
before ordinary delivery. The native 0.7.13 case has not run.
|
||||
- **Codex hook review after an upgrade:** in one test whose Codex home already
|
||||
held earlier hook approvals, `rig up --existing` stopped for hook review in
|
||||
each Codex pane; approving the hooks resumed all three conversations. A
|
||||
separate test of the same upgrade on a fresh Codex home, on another host,
|
||||
restored without review. The cause of the difference is not established.
|
||||
- **A first team with Codex installed but signed out:** a Claude user's starter
|
||||
team includes a Codex reviewer that waits for a Codex sign-in, and you aren't
|
||||
told beforehand. If Codex is installed, tell the person about the possible sign-in wait
|
||||
before the team starts; signing in first was not tested as a remedy.
|
||||
- **A first team's permission asks:** a command joined with `&&`, `;` or a pipe
|
||||
still asks unless every part is allowed, and OpenRig's own lifecycle commands
|
||||
still ask on Claude seats. ([#3029](https://github.com/mvschwarz/openrig/pull/3029))
|
||||
- **Usage-limit parking** was tested with the limit message from `claude -p`. If
|
||||
an interactive seat's limit report doesn't carry the message, the seat is
|
||||
retried as before. A reset in the past or more than 8 days away is ignored.
|
||||
([#2917](https://github.com/mvschwarz/openrig/pull/2917))
|
||||
- **Handover:** two other failures can still say "retry" while a successor may
|
||||
be running: a context delivery failure, and a Codex launch failure after an
|
||||
update prompt wasn't dismissed. Look at the pane first. ([#3003](https://github.com/mvschwarz/openrig/pull/3003))
|
||||
- **Answers:** when a receiving agent asks you back, it can stop at Claude
|
||||
Code's own permission prompt, which you don't see. A receiving agent you
|
||||
choose can still decline to act on a clear answer. A pairing requester's
|
||||
description of itself is quoted for the receiving agent, but still shown
|
||||
unquoted in the request's summary and the notices about it. The TUI's
|
||||
one-line notice after you answer can clear within a frame. ([#3030](https://github.com/mvschwarz/openrig/pull/3030), [#3001](https://github.com/mvschwarz/openrig/pull/3001))
|
||||
- **Proof reads** still pause briefly, and a whole read takes slightly longer.
|
||||
Yielding isn't a hard bound on latency or a single atomic snapshot of the
|
||||
proof. ([#2970](https://github.com/mvschwarz/openrig/pull/2970))
|
||||
- **`rig down`** keeps no stored host or boot identity, doesn't guard against
|
||||
another program running as you, and a daemon restart between losing the tmux
|
||||
server and the stop wasn't exercised. ([#2962](https://github.com/mvschwarz/openrig/pull/2962))
|
||||
- **Codex working counter:** a capture that doesn't name its pane keeps the old
|
||||
comparison, a restart that keeps both the pane and its process id isn't seen,
|
||||
and a leftover live frame can count once until it expires. ([#2980](https://github.com/mvschwarz/openrig/pull/2980))
|
||||
- **Custom blocker IDs** explain the wait, but their progress gives no event
|
||||
wake; the timer remains. ([#2983](https://github.com/mvschwarz/openrig/pull/2983))
|
||||
- **Delivery:** delivery evidence records what was known, not that the agent read
|
||||
the message, and events are best effort. A footer row OpenRig doesn't
|
||||
recognize can still hold a delivery ([#2925](https://github.com/mvschwarz/openrig/issues/2925)), and a held message's full envelope
|
||||
can stay held; clearing a draft doesn't deliver it ([#2515](https://github.com/mvschwarz/openrig/pull/2515)).
|
||||
- **Runner permission answers** were run end to end with a real receiving agent
|
||||
and the example runner, whose requesting agent was a stand-in; a model-driven
|
||||
runner waiting on a person's answer hasn't been run. ([#2934](https://github.com/mvschwarz/openrig/pull/2934))
|
||||
- **A receiving agent you choose** (`agents.operator_session`) that runs in an
|
||||
explicit or auto permission mode gets no OpenRig allowance for
|
||||
`rig host approve` or `rig host deny`, so Claude's review can refuse them.
|
||||
- **An already-running tmux server** keeps its old environment, daemon
|
||||
credentials included, until it restarts. ([#2850](https://github.com/mvschwarz/openrig/pull/2850))
|
||||
- **herdr-app views** are one-shot; following isn't claimed. **Pull relay** needs
|
||||
a connector that implements pull. ([#2744](https://github.com/mvschwarz/openrig/pull/2744), [#2844](https://github.com/mvschwarz/openrig/pull/2844))
|
||||
- **From 0.7.12:** [its known limits](https://github.com/mvschwarz/openrig/releases/tag/v0.7.12)
|
||||
still apply, except that [#2970](https://github.com/mvschwarz/openrig/pull/2970) and [#2948](https://github.com/mvschwarz/openrig/pull/2948) are now in this release,
|
||||
runner answers are confirmed and reach a waiting runner at once ([#3001](https://github.com/mvschwarz/openrig/pull/3001)),
|
||||
and `rig seat stop` no longer suggests `rig down` for an adopted session
|
||||
([#3006](https://github.com/mvschwarz/openrig/pull/3006)). They weren't re-checked for this release unless named here.
|
||||
|
||||
### Credits
|
||||
|
||||
Thanks to @Aummadour, @Kayhusk, @Coder8124, @DeryFerd, @EZotoff, @hgreene624,
|
||||
@cavalcanticampos, @ziadeh, @dajiaohuang and @billbenetti for merged
|
||||
contributions. Thanks also for the reports behind these fixes: @jamesloosli
|
||||
([#2879](https://github.com/mvschwarz/openrig/pull/2879)), @Kayhusk ([#2880](https://github.com/mvschwarz/openrig/pull/2880) and [#2951](https://github.com/mvschwarz/openrig/pull/2951)), @CaptObvious ([#2948](https://github.com/mvschwarz/openrig/pull/2948) and
|
||||
[#3016](https://github.com/mvschwarz/openrig/pull/3016)), @alperta ([#2917](https://github.com/mvschwarz/openrig/pull/2917)), @ziadeh ([#2960](https://github.com/mvschwarz/openrig/pull/2960)) and @todd-dhango ([#2984](https://github.com/mvschwarz/openrig/pull/2984)).
|
||||
|
||||
## [0.7.12]
|
||||
|
||||
OpenRig 0.7.12 is a patch for people running their own agent teams, cut from
|
||||
|
||||
+2
-2
@@ -6,9 +6,9 @@ This isn't a schedule or a promise: we release often, and an item ships when a g
|
||||
To see what's being worked on, by release and theme, open the [OpenRig roadmap board](https://github.com/users/mvschwarz/projects/1).
|
||||
Issues labelled `good first issue` are also listed on the [contribute page](https://github.com/mvschwarz/openrig/contribute).
|
||||
|
||||
## Released in 0.7.13
|
||||
## Released in 0.7.12
|
||||
|
||||
[0.7.13 is published](https://github.com/mvschwarz/openrig/releases/tag/v0.7.13): OpenRig 0.7.13 is a patch for people running their own agent teams. When you answer a runner's permission request, you now get a note back saying who decides it, and the runner wakes on the decision. See its release notes for what shipped, known issues, upgrade instructions and contributor credits.
|
||||
[0.7.12 is published](https://github.com/mvschwarz/openrig/releases/tag/v0.7.12): OpenRig 0.7.12 is a patch for people running their own agent teams. When you answer your team, by typing, clicking or qualifying an answer, the answer now goes to an agent that reads it with the question and decides. When no receiving agent is available, your answer waits. See its release notes for what shipped, known issues, upgrade instructions and contributor credits.
|
||||
|
||||
## How to help
|
||||
|
||||
|
||||
@@ -82,10 +82,9 @@ optional `evidence` (last-N pane lines, flowed through to
|
||||
`RestoreNodeResult.attentionEvidence` for `attention_required` outcomes,
|
||||
`:99–102`). This is the honest-failure shape, not a smoothed optional `error`.
|
||||
|
||||
Readiness has its own attention codes (`ATTENTION_REQUIRED_READINESS_CODES` in `runtime-adapter.ts`):
|
||||
Readiness has its own attention codes (`runtime-adapter.ts:74–87`):
|
||||
`trust_gate`, `hook_trust_gate`, `update_gate`, `login_required`, `mcp_gate`,
|
||||
`bypass_consent_gate`, `claude_resume_selection_prompt`, `claude_gated_grants_gate`,
|
||||
`codex_auth_refusal` and `codex_client_incompatible`.
|
||||
`bypass_consent_gate`, `codex_auth_refusal` and `codex_client_incompatible`.
|
||||
When `checkReady` reports one, the readiness wait returns at once and startup
|
||||
ends `attention_required`.
|
||||
|
||||
@@ -477,8 +476,7 @@ command + pane content and returns one of four honest statuses
|
||||
conversation"; it is *distinct* from `inconclusive` and `failed` (comment
|
||||
`:4–6`).
|
||||
|
||||
Other codes include `bypass_consent_gate`, `claude_gated_grants_gate` (the
|
||||
"gated grants" trust check, which is never auto-driven), `mcp_gate`, `login_required` and
|
||||
Other codes include `bypass_consent_gate`, `mcp_gate`, `login_required` and
|
||||
`returned_to_shell` for Claude, and `codex_client_incompatible`,
|
||||
`no_saved_session`, `codex_auth_refusal` and `model_selection_gate` for Codex;
|
||||
an unknown runtime gets `unsupported_runtime`. For Claude, `assessManagedProbe`
|
||||
|
||||
@@ -35,17 +35,8 @@ command. `rig ps --nodes` shows it under "Startup details (<seat>)", and
|
||||
|
||||
The attention codes that stop startup this way are `trust_gate`,
|
||||
`hook_trust_gate`, `update_gate`, `login_required`, `mcp_gate`,
|
||||
`bypass_consent_gate`, `claude_resume_selection_prompt`,
|
||||
`claude_gated_grants_gate`, `codex_auth_refusal` and `codex_client_incompatible`.
|
||||
`bypass_consent_gate`, `codex_auth_refusal` and `codex_client_incompatible`.
|
||||
They are recognized from each harness's English prompt text.
|
||||
`claude_gated_grants_gate` is Claude Code's workspace trust check that warns "This folder
|
||||
pre-approves N tool permissions" (from the folder's `.claude/settings.json`): OpenRig never
|
||||
answers it, not even with `recovery.auto_drive_provider_prompts`, because its default choice
|
||||
declines those permissions (or exits) and approving them is your call. With that setting on,
|
||||
the plain workspace trust prompt is answered only when its options are exactly "No, exit" and
|
||||
"Yes, I trust this folder": Claude Code 2.1.322 opens it on "No, exit", so OpenRig moves the
|
||||
selection down once and presses Enter only after it reads the focus on "Yes". Any other option
|
||||
set, a prompt drawn without a cursor or a focus that does not reach "Yes" gets no confirmation.
|
||||
|
||||
## Continue a Codex fork whose child ID arrived late
|
||||
|
||||
@@ -423,10 +414,10 @@ Each startup file and action specifies when it applies:
|
||||
- a launch replaces it, as launches always did, and names it (`guidance_block_refreshed_unrecorded`);
|
||||
- an exact resume or a handover leaves it, and names it as possibly stale (`guidance_block_may_be_stale`).
|
||||
|
||||
**A file keeps one copy of each distinct block text, and nothing you wrote is removed.**
|
||||
**A file keeps one copy of each block.**
|
||||
- **Touched markers:** a marker an editor or formatter rewrapped, with spaces or line breaks inside the comment, still reads as its block, and the next write puts it back in OpenRig's form.
|
||||
- **Collected copies:** a copy that repeats an earlier one exactly is removed. Beside a copy you edited, OpenRig's own unedited copies are removed too, and every different edited copy stays (`guidance_block_copies_removed`).
|
||||
- **A marker that lost its pair:** OpenRig can't tell where that block starts or ends, so it adds no copy beside it and names it (`guidance_block_markers_damaged`). Put back the missing marker or remove the partial block, and OpenRig's next write treats that block like any other. `rig package install` leaves such a file as it is, names it in its result (`notes`), and installs the rest. A marker without its pair beside a complete block is named too (`guidance_block_marker_unpaired`), and the block is written.
|
||||
- **Collected copies:** they're reduced to the first. Beside a copy you edited, OpenRig's own unedited copies and exact repeats are removed, and every different edited copy stays (`guidance_block_copies_removed`).
|
||||
- **A marker that lost its pair:** OpenRig can't tell where that block starts or ends, so it adds no copy beside it and names it (`guidance_block_markers_damaged`). Put back the missing marker or remove the partial block, and OpenRig's next write keeps one block. `rig package install` leaves such a file as it is, names it in its result (`notes`), and installs the rest. A marker without its pair beside a complete block is named too (`guidance_block_marker_unpaired`), and the block is written.
|
||||
|
||||
An exact resume doesn't type anything into the resumed conversation. So there, the restore result names the block (`guidanceNotes`), but the seat isn't told.
|
||||
|
||||
|
||||
@@ -202,8 +202,7 @@ LIFECYCLE); see the
|
||||
its startup context is still pending for `rig seat continue`.
|
||||
- **Oriented:** `verified`, `missing`, `rejected`, `n-a`, from the startup proof.
|
||||
- **Attention codes:** `trust_gate`, `hook_trust_gate`, `update_gate`, `login_required`,
|
||||
`mcp_gate`, `bypass_consent_gate`, `claude_resume_selection_prompt`,
|
||||
`claude_gated_grants_gate`, `codex_auth_refusal`, `codex_client_incompatible`.
|
||||
`mcp_gate`, `bypass_consent_gate`, `codex_auth_refusal`, `codex_client_incompatible`.
|
||||
- **Restore outcome:** `resumed`, `fresh-primed`, `awaiting-decision`, `attention_required`,
|
||||
`failed` (plus `rebuilt`, `operator_recovered` and the legacy `fresh`). A seat joined with
|
||||
`rig attach` as an external CLI reads `left_attached`: restore leaves it as it is.
|
||||
|
||||
@@ -141,9 +141,7 @@ reason when it's unknown); `rig roster show` and `find` show it as `Check-in:`,
|
||||
without `--nodes`, and when it has no rigs or nodes to show) lists every connected assistant after its table, one line
|
||||
each. That's on this host, and in the node view of an HTTP host; an SSH host's `rig ps` prints its own. An HTTP host's
|
||||
rig view and the multi-host fan-out leave the section out. When the list can't be read, for example from an older
|
||||
daemon, it says check-in is unavailable instead. Its `--json` output is unchanged. The TUI's
|
||||
instance and rig tables list them the same way after their seats, with times in the viewer's zone; when the list can't be read,
|
||||
they say check-in is unavailable, as `rig ps` does.
|
||||
daemon, it says check-in is unavailable instead. Its `--json` output is unchanged.
|
||||
When the member has unclaimed work, the standing notice described above states the same status in its `check-ins:`
|
||||
line; when that notice is filed doesn't change.
|
||||
|
||||
@@ -180,18 +178,7 @@ and nothing else is offered:
|
||||
- **Two assistants together:** a grant with `team`/`list` sees its rigs' seats with `rig_team`, and may address and hear from
|
||||
another connected assistant's seat. A grant without it never reaches a seat in the service's caller form
|
||||
(`cus-<id>-<connection>@<rig>`), so an existing connection keeps the reach it had.
|
||||
- **Messages are items:** a message is an item the receiver reads and closes, with any reply in its `resolution`. The
|
||||
sender reads that reply on the same item. Nothing wakes the sender or posts a new item for it. A separate new message is
|
||||
new work.
|
||||
- **A fair-use limit on new work:** the service can add `throttle: { new_work: true, retry_after_seconds: <n> }` to an
|
||||
active answer.
|
||||
- While it does, a `rig_queue_create` that would open a new item writes nothing. It returns `fair_use_retry_later` with
|
||||
`retryAfterSeconds` (1 to 600) and the `qitemId` to retry with.
|
||||
- A retry of a create that already landed is answered from the stored item, as before.
|
||||
- Everything else is served: reading, claiming and closing existing items (a reply in `resolution` included), and
|
||||
answering the team's questions. A separate new message or revision waits like any other new item.
|
||||
- It's never a credential refusal, and a `throttle` that can't be read is ignored.
|
||||
- The service is asked once per HTTP request (initialize and tool listing included), not once per tool call.
|
||||
- **Messages are items:** a message is an item the receiver reads and closes, and a reply is an item back to its sender.
|
||||
- **What the sender can tell, from the item it reads:**
|
||||
- **Queued:** the item exists and is `pending` with no claim.
|
||||
- **Picked up:** the receiver's claim (`in-progress`).
|
||||
|
||||
@@ -8,8 +8,6 @@ with one grant per participant. The network connector puts one selected local se
|
||||
The connector opens no port: your daemon makes every connection outward, and the hub never connects to your machine. Work the hub
|
||||
sends that participant runs on your seat, under your accounts, and the result goes back to the hub item.
|
||||
|
||||
**The network connector is experimental and unsupported.** Use it only if you choose to, at your own risk.
|
||||
|
||||
## Enroll in an account, then connect by name
|
||||
|
||||
When your hub is an account's network, enroll this daemon once with the one-time code its page shows, then connect
|
||||
|
||||
@@ -24,7 +24,7 @@ A queue row is erased in one of two ways:
|
||||
- events whose payload names it;
|
||||
- its mission-control audit rows.
|
||||
|
||||
**Copies held with someone else go only when they're the owner's.** These are outbox and inbox entries that point at the row or wake for it, and stream reader actions and dispositions that name it (including `duplicate_of`). For account deletion, the owner is the account: both of a copy's sessions must be members. Otherwise the owner is the row's own source and destination. OpenRig's own sessions (`daemon@kernel`, and any session starting `system:`), which send its wakes and notices, aren't counted when a copy has another session, so OpenRig's wake to the owner is the owner's. Any other copy is kept and listed under `keptCopies`:
|
||||
**Copies held with someone else go only when they're the owner's.** These are outbox and inbox entries that point at the row or wake for it, and stream reader actions and dispositions that name it (including `duplicate_of`). For account deletion, the owner is the account: both of a copy's sessions must be members. Otherwise the owner is the row's own source and destination. Any other copy is kept and listed under `keptCopies`:
|
||||
- `mixed`: one of its sessions is the owner's;
|
||||
- `foreign`: none of them are.
|
||||
|
||||
@@ -36,7 +36,7 @@ Name exactly one.
|
||||
|
||||
| Scope | Erases | Action |
|
||||
|---|---|---|
|
||||
| `--members <file>` | Account deletion. Every row whose source and destination are both in the file, or one in the file and the other OpenRig's own session, in any state, open work included. Add `--rig <id>` for the account rig's own records | delete |
|
||||
| `--members <file>` | Account deletion. Every row whose source and destination are both in the file, in any state, open work included. Add `--rig <id>` for the account rig's own records | delete |
|
||||
| `--ids <file>` | Exactly the listed rows. A report's `qitems` entries, or a ledger's lines, keep each entry's own action. A ledger's entries are replayed only for the batches that committed (below) | `--action delete` (default for plain ids) or `--action scrub` |
|
||||
| `--routine` | Closed rows past this daemon's retention windows (below) | scrub, then delete |
|
||||
|
||||
@@ -44,10 +44,8 @@ A file is one entry per line (blank lines and `#` comments are skipped; a line s
|
||||
|
||||
**Account deletion is exact.**
|
||||
- The members file is the account's recorded membership: the exact session names of its seats, including departed ones. List every address form the account used, such as a host-suffixed form. Names are compared as given, never by pattern, so a row addressed through an unlisted form is neither erased nor reported.
|
||||
- **OpenRig's own sessions:** `daemon@kernel` and any `system:` session send OpenRig's own wakes and notices, such as the wake for a sweep finding, a wake escalation or a health finding. They belong to no account, so a row or entry between one of them and a member is the member's and is erased. One with no member endpoint, such as an OpenRig wake to another account's seat or an entry between two of OpenRig's own sessions, is never touched.
|
||||
- **Mixed rows:** a row with one member endpoint and the other outside the account is reported under `mixed` (with which endpoint is the member) and left untouched. Deciding who owns it is a separate decision. A row rerouted out of the account while the run is under way (by a fallback, say) is kept too, and reported as `changed-during-run`.
|
||||
- **After the rows:** account deletion also removes outbox and inbox entries that no row owns between two members, or between a member and OpenRig's own session, and the members' stream items. An entry with one member endpoint and the other outside the account, or a stream item something still references, is counted and left.
|
||||
- **Runs on earlier versions** kept OpenRig's wake for a row they erased (as a mixed copy, then a mixed entry) and reported OpenRig's rows to a member as mixed. Rerunning the same command removes them.
|
||||
- **Mixed rows:** a row with exactly one member endpoint is reported under `mixed` (with which endpoint is the member) and left untouched. Deciding who owns it is a separate decision. A row rerouted out of the account while the run is under way (by a fallback, say) is kept too, and reported as `changed-during-run`.
|
||||
- **After the rows:** account deletion also removes outbox and inbox entries between two members that no row owns, and the members' stream items. An entry with one member endpoint, or a stream item something still references, is counted and left.
|
||||
|
||||
**The account's rig.** A rig's own records outlive the rig. Events are kept past rig and node deletion by design, and snapshots, node and seat records and watchdog jobs have no key that cascades. `--rig <id>`, given with `--members`, erases them:
|
||||
- the rig's events, including those of its nodes;
|
||||
@@ -96,7 +94,7 @@ The command prints one JSON report (`--json` makes it a single line):
|
||||
| `clean` | `complete`, and nothing was left: no `mixed` rows, mixed `keptCopies`, `gaps`, `unreadableEvents`, left-over entries, or rig records left or unknown. Only a clean report means the scope is fully erased. It's about this run's scope: a routine or members run's `clean` isn't affected by the ledger's other batches, and only a replay (`--ids` with a ledger) reports a batch it can't show committed, as the gap `ledger-unresolved` |
|
||||
| `error` | why the run stopped (`stage` and `message`). Everything listed in `qitems` was committed before it; the command exits 2 |
|
||||
| `qitems` | each row erased (or that would be), with its `action` and `state` |
|
||||
| `mixed` | members scope: rows with one member endpoint and the other outside the account, left untouched |
|
||||
| `mixed` | members scope: rows with one member endpoint, left untouched |
|
||||
| `keptCopies` | copies of erased rows held with someone else, kept: `table`, `id`, `qitemId`, `ownership` (`mixed` or `foreign`) |
|
||||
| `gaps` | rows not erased and why: `workflow-reference`; `not-found` for an id to scrub that doesn't exist; `changed-during-run` for a row that no longer qualified when its batch ran (reopened, rerouted out of the account, or written to so it left its window) or an absent id created since selection; `unreadable-event` for a row an unreadable event names; `ledger-unresolved` for a replayed entry whose batch can't be shown to have committed |
|
||||
| `skipped` | ids scope, a ledger replay: entries whose batch rolled back, with the batch id; not replayed |
|
||||
|
||||
@@ -76,7 +76,7 @@ Keys:
|
||||
health.context_pressure.* context-pressure warning/critical percentages (defaults 95/99)
|
||||
files.allowlist name:/abs/path,name:/abs/path
|
||||
progress.scan_roots name:/abs/path,name:/abs/path
|
||||
ui.timezone IANA timezone for the TUI's times, the Feed's included (default America/Los_Angeles; reopen TUI after changing)
|
||||
ui.timezone TUI IANA timezone (default America/Los_Angeles; reopen TUI after changing)
|
||||
ui.enabled serve the web UI and its terminal WebSocket (default off; restart the daemon)
|
||||
ui.preview.* refresh_interval_seconds, max_pins, default_lines
|
||||
ui.terminal.max_live_terminals
|
||||
|
||||
@@ -142,8 +142,7 @@ const LONG_RUNNING_TIMEOUT_MS = 45_000;
|
||||
export function downCommand(depsOverride?: DownDeps): Command {
|
||||
const cmd = new Command("down").description("Tear down a rig")
|
||||
.addHelpText("after", `
|
||||
rig down stops every agent OpenRig started in the rig: their sessions end, and any work in progress stops
|
||||
with them. A session OpenRig didn't start (adopted, bound or discovered) is left running, and rig down names it.
|
||||
rig down stops every agent in the rig: their sessions end, and any work in progress stops with them.
|
||||
Before running it, check who is working (rig ps --nodes --rig <rig>) and that the person asked for it;
|
||||
don't stop a team you didn't start unless asked. OpenRig snapshots the rig first (best-effort), and
|
||||
rig up <rig> --existing brings it back, resuming each seat's conversation where its harness allows. With
|
||||
|
||||
@@ -54,7 +54,7 @@ function line(b: Binding): string {
|
||||
* another OpenRig hub), see where each connection stands, and disconnect one. */
|
||||
export function networkCommand(depsOverride?: NetworkDeps): Command {
|
||||
const cmd = new Command("network")
|
||||
.description("Connect selected local seats to a remote hub, see their status, and disconnect them. Experimental and unsupported: use it only if you choose to, at your own risk");
|
||||
.description("Connect selected local seats to a remote hub, see their status, and disconnect them");
|
||||
const getDeps = (): NetworkDeps => depsOverride ?? { lifecycleDeps: realDeps(), clientFactory: (url: string) => new DaemonClient(url) };
|
||||
|
||||
const client = async () => {
|
||||
@@ -157,7 +157,7 @@ export function networkCommand(depsOverride?: NetworkDeps): Command {
|
||||
const b = raw as unknown as Binding;
|
||||
if (b.accountRemoval === "confirmed") return `Disconnected ${line(b)}\nThe account stopped listing ${b.participantName}, which revokes it there.`;
|
||||
if (b.accountRemoval) return `Disconnected ${line(b)}`;
|
||||
return `Disconnected ${line(b)}\nRemove the participant on the hub too: until then, the hub still lists it.`;
|
||||
return `Disconnected ${line(b)}\nRemove the participant on the hub too, so the account stops listing it.`;
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
@@ -2189,10 +2189,8 @@ Examples:
|
||||
"Name exactly one scope. What each one erases:",
|
||||
" --members every row whose source and destination are both members, in any state, deleted with its transitions,",
|
||||
" outbox and inbox copies, stream actions, events and audit rows; then member-to-member outbox and inbox",
|
||||
" entries no row owns, and the members' stream items. OpenRig's own sessions (daemon@kernel, system:*)",
|
||||
" belong to no account, so its wakes and notices to a member are erased too. A row with one member",
|
||||
" endpoint and the other outside the account is reported under mixed and left untouched. With --rig,",
|
||||
" also the rig's own events, snapshots and node and seat records.",
|
||||
" entries no row owns, and the members' stream items. A row with one member endpoint is reported under",
|
||||
" mixed and left untouched. With --rig, also the rig's own events, snapshots and node and seat records.",
|
||||
" --ids the listed rows, deleted or scrubbed (a report's qitems entries keep their action); a deleted id",
|
||||
" that's already gone keeps (or regains) its id marker.",
|
||||
" --routine closed rows (done, canceled, denied, handed-off) past the windows, aged from when they closed.",
|
||||
|
||||
@@ -1022,8 +1022,8 @@ Example:
|
||||
}
|
||||
if (opts.json) return;
|
||||
const state = res.data.state;
|
||||
console.log(state === "answered" ? `Decided: ${res.data.optionId}. A runner waiting on the request gets it now; one that isn't gets it at its next read.`
|
||||
: state === "refused" ? "Decided: refused. A runner waiting on the request gets the refusal now; one that isn't gets it at its next read."
|
||||
console.log(state === "answered" ? `Decided: ${res.data.optionId}. The runner gives it to its agent at its next read.`
|
||||
: state === "refused" ? "Decided: refused. The runner gives its agent the refusal at its next read."
|
||||
: `Nothing was decided: the request is ${state}.`);
|
||||
});
|
||||
|
||||
|
||||
@@ -9,8 +9,7 @@
|
||||
//
|
||||
// With --grant-service, grants come from an external grant service instead and the token file is never read: each
|
||||
// request's key is checked with that service (openrig.grant/v1) for this daemon's instance, every answer but active is
|
||||
// refused, and an external caller reaches only what its grant names (externalScope in mcp-server.ts). An active answer's
|
||||
// fair-use throttle holds back only that caller's new work (rig_queue_create), never the request.
|
||||
// refused, and an external caller reaches only what its grant names (externalScope in mcp-server.ts).
|
||||
//
|
||||
// The endpoint serves both protocol revisions: 2026-07-28 per request, and 2025's initialize and exchanges statelessly.
|
||||
import http from "node:http";
|
||||
@@ -232,18 +231,6 @@ const unavailable = (log: string): Refusal => ({
|
||||
|
||||
const strings = (value: unknown): value is string[] => Array.isArray(value) && value.every((item) => typeof item === "string" && item !== "");
|
||||
|
||||
/** An active answer's optional fair-use limit on new work (`throttle`): the seconds until new work is accepted again,
|
||||
* rounded up and kept within 1..600, undefined when there is none, or "unusable" when it can't be read. */
|
||||
function fairUseThrottle(value: unknown): number | undefined | "unusable" {
|
||||
if (value === undefined || value === null) return undefined;
|
||||
if (typeof value !== "object" || Array.isArray(value)) return "unusable";
|
||||
const { new_work: newWork, retry_after_seconds: seconds } = value as Record<string, unknown>;
|
||||
if (typeof newWork !== "boolean") return "unusable";
|
||||
if (!newWork) return undefined;
|
||||
if (typeof seconds !== "number" || !Number.isFinite(seconds)) return "unusable";
|
||||
return Math.min(600, Math.max(1, Math.ceil(seconds)));
|
||||
}
|
||||
|
||||
/** One request's caller from the grant service's answer for its key. A refusal never falls back to the token file or
|
||||
* the env's seat. */
|
||||
async function grantServiceCaller(service: GrantServiceOptions, url: URL, key: string, instance: string): Promise<{ seat: string; access: McpAccess; principal: McpPrincipal } | Refusal> {
|
||||
@@ -287,16 +274,11 @@ async function grantServiceCaller(service: GrantServiceOptions, url: URL, key: s
|
||||
if (person !== undefined && person !== null && !personId) {
|
||||
console.error(`rig mcp serve --http: grant ${grant.id} names an unusable person.entity_id, so this connection isn't offered the person tools (rig_question_*)`);
|
||||
}
|
||||
// The service's fair-use limit, when it sets one, holds back only new work (rig_queue_create). One that can't be read is
|
||||
// ignored: it never refuses the request or reads as a credential problem.
|
||||
const throttle = fairUseThrottle(body.throttle);
|
||||
if (throttle === "unusable") console.error(`rig mcp serve --http: grant ${grant.id} answered an unusable throttle, so it's ignored`);
|
||||
// The principal the daemon records beside this caller's rows. A version that isn't a finite number is left out (a v1
|
||||
// answer sends a number).
|
||||
const version = Number.isFinite(grant.version) ? { version: grant.version as number } : {};
|
||||
return { seat, access: { principal: principal.id, owner: false, rigs, roots, workspace: false,
|
||||
external: { objects, grant: { id: grant.id, ...version }, ...(personId ? { person: personId } : {}),
|
||||
...(typeof throttle === "number" ? { throttle: { retryAfterSeconds: throttle } } : {}) } },
|
||||
external: { objects, grant: { id: grant.id, ...version }, ...(personId ? { person: personId } : {}) } },
|
||||
principal: { source: "grant-service", id: principal.id, grant: grant.id, ...version } };
|
||||
}
|
||||
|
||||
|
||||
@@ -432,17 +432,6 @@ function outOfScope(what: string, hint?: string): TextResult {
|
||||
return errorResult(JSON.stringify({ ok: false, error: "out_of_scope", message }), "out_of_scope", message);
|
||||
}
|
||||
|
||||
/** A new create the grant service's fair-use limit holds back: nothing was written, and it says when to retry with the same
|
||||
* id. `unread`: whether an earlier create with this id was saved couldn't be read. */
|
||||
function fairUseRetryLater(qitemId: string, retryAfterSeconds: number, unread: boolean): TextResult {
|
||||
const earlier = unread ? ` Whether an earlier attempt with this id was saved is unknown: check rig_queue_show with qitemId ${qitemId} before retrying.` : "";
|
||||
const message = `OpenRig: this account has reached its fair-use limit for new work just now. Nothing was created by this call.${earlier}`
|
||||
+ ` Retry after ${retryAfterSeconds} seconds with the same qitemId ${qitemId}. Work you already have continues as usual: read, claim, answer and`
|
||||
+ " close it, and to reply to an item addressed to you, put the reply in its resolution when you close it.";
|
||||
return errorResult(message, "fair_use_retry_later", message,
|
||||
{ retryable: true, retryAfterSeconds, qitemId, outcome: "not_written", ...(unread ? { earlierAttempt: "unknown" } : {}) });
|
||||
}
|
||||
|
||||
/** A file the daemon read through a shared root, as text from offset: at most CONTEXT_TEXT_LIMIT characters, with
|
||||
* nextOffset when more of what the daemon read remains, and its byte cut when the file was longer than the daemon reads. */
|
||||
function artifactView(source: string, read: FileRead, offset: number): Record<string, unknown> {
|
||||
@@ -518,10 +507,8 @@ export type McpAccessClass = "work" | "workspace" | "owner" | "person";
|
||||
export type McpAccess = {
|
||||
principal: string; owner: boolean; rigs: readonly string[]; roots: readonly string[]; workspace: boolean;
|
||||
/** An external caller's grant: the object/action pairs it names (openrig.grant/v1 `objects`), the grant it answered
|
||||
* with, `person`, the gateway entity id of the person the grant service vouches owns this connection, and `throttle`,
|
||||
* the service's fair-use limit on new work for this request: the seconds before a new create is accepted again. */
|
||||
external?: { objects: Readonly<Record<string, readonly string[]>>; grant?: { id: string; version?: number | string }; person?: string;
|
||||
throttle?: { retryAfterSeconds: number } };
|
||||
* with, and `person`, the gateway entity id of the person the grant service vouches owns this connection. */
|
||||
external?: { objects: Readonly<Record<string, readonly string[]>>; grant?: { id: string; version?: number | string }; person?: string };
|
||||
};
|
||||
|
||||
/** The tool each external object/action pair offers. A pair not listed here offers nothing. */
|
||||
@@ -651,7 +638,7 @@ const EXTERNAL_PERSON_INSTRUCTIONS = [
|
||||
|
||||
/** For an external grant that names claim and update: how it works the items addressed to it, messages included. */
|
||||
const EXTERNAL_INBOX_INSTRUCTIONS = [...SHARED_INSTRUCTIONS,
|
||||
"Items addressed to your seat are yours: rig_queue_list with owned set lists them. For each, claim it (rig_queue_claim), do it, then close it done with closure reason no-follow-on and the answer in resolution (rig_queue_update); the sender reads that answer on the same item. A message is an item too: read it and close it done, with your reply in resolution when it needs one; its sender reads that reply on the same item. Nothing promises to wake you, so check your items again.",
|
||||
"Items addressed to your seat are yours: rig_queue_list with owned set lists them. For each, claim it (rig_queue_claim), do it, then close it done with closure reason no-follow-on and the answer in resolution (rig_queue_update); the sender reads that answer on the same item. A message is an item too: read it, close it done, and reply, when it needs one, with a new item to its sender. Nothing promises to wake you, so check your items again.",
|
||||
].join("\n");
|
||||
|
||||
function instructionsFor(access: McpAccess | undefined, frontDoor = false): string {
|
||||
@@ -1415,19 +1402,6 @@ export function createMcpServer(client: DaemonClient, options: { seat?: string;
|
||||
}
|
||||
}
|
||||
const id = qitemId ?? `qitem-${new Date().toISOString().replace(/\D/g, "").slice(0, 14)}-${randomBytes(8).toString("hex")}`;
|
||||
// The grant service's fair-use limit holds back new work only. A retry of a create that already landed isn't new
|
||||
// work: the daemon answers it from the stored row, so it goes through as before.
|
||||
const throttle = access?.external?.throttle;
|
||||
if (throttle) {
|
||||
let landed: boolean | undefined = false;
|
||||
if (qitemId) {
|
||||
try {
|
||||
const existing = await client.get(`/api/queue/${encodeURIComponent(qitemId)}`);
|
||||
landed = existing.status < 400 ? true : existing.status === 404 ? false : undefined;
|
||||
} catch { landed = undefined; }
|
||||
}
|
||||
if (landed !== true) return fairUseRetryLater(id, throttle.retryAfterSeconds, landed === undefined);
|
||||
}
|
||||
// With no seat, the task goes to its destination as from the unknown sender, with the note at the top of its body.
|
||||
const note = unknownSenderNote("task");
|
||||
try {
|
||||
|
||||
@@ -1045,94 +1045,6 @@ describe("rig mcp serve --http --grant-service on the daemon's routes", () => {
|
||||
expect((await asExternal("rig_queue_create", { destination: "lead@team-a", body: "far", qitemId: far })).text).not.toContain("other-host");
|
||||
});
|
||||
|
||||
describe("a fair-use throttle on an active answer", () => {
|
||||
const ALL = { queue: ["create", "show", "list", "claim", "update"] };
|
||||
const throttled = (throttle: unknown) => (): [number, unknown] => [200, active({ objects: ALL, throttle })];
|
||||
|
||||
it("holds back only new creates, which write nothing and say when to retry with the same id; a replay, claim, update, show and list are served", async () => {
|
||||
answer = () => [200, active({ objects: ALL })];
|
||||
const { url } = await listen();
|
||||
const ask = await connect(url);
|
||||
const landed = { destination: "lead@team-a", body: "First task", qitemId: "qitem-landed" };
|
||||
expect((await ask("rig_queue_create", landed)).isError).toBe(false);
|
||||
const theirs = (await create("lead@team-a", CALLER, "A task for the assistant")).qitemId;
|
||||
answer = throttled({ new_work: true, retry_after_seconds: 30 });
|
||||
const before = rows();
|
||||
for (const args of [
|
||||
{ destination: "lead@team-a", body: "New work" },
|
||||
{ destination: "lead@team-a", body: "New work", qitemId: "qitem-new" },
|
||||
{ destination: "lead@team-a", body: "Improve it", revises: landed.qitemId },
|
||||
] as Array<Record<string, string>>) {
|
||||
const held = await ask("rig_queue_create", args);
|
||||
expect(held.isError).toBe(true);
|
||||
expect(held.structured).toMatchObject({ ok: false, code: "fair_use_retry_later", retryable: true, retryAfterSeconds: 30, outcome: "not_written" });
|
||||
expect(held.structured.earlierAttempt).toBeUndefined();
|
||||
expect(held.text).toContain("Nothing was created by this call.");
|
||||
expect(held.text).toContain(`Retry after 30 seconds with the same qitemId ${held.structured.qitemId}.`);
|
||||
if (args.qitemId) expect(held.structured.qitemId).toBe(args.qitemId);
|
||||
}
|
||||
expect(rows()).toBe(before);
|
||||
expect(repo.getById("qitem-new")).toBeFalsy();
|
||||
const replay = await ask("rig_queue_create", landed);
|
||||
expect(replay.isError).toBe(false);
|
||||
expect(replay.structured.qitemId).toBe(landed.qitemId);
|
||||
expect((await ask("rig_queue_claim", { qitemId: theirs })).isError).toBe(false);
|
||||
expect((await ask("rig_queue_update", { qitemId: theirs, state: "done", closureReason: "no-follow-on", resolution: "Done" })).isError).toBe(false);
|
||||
expect(repo.getById(theirs)).toMatchObject({ state: "done", resolution: "Done" });
|
||||
expect((await ask("rig_queue_show", { qitemId: landed.qitemId })).isError).toBe(false);
|
||||
expect((await ask("rig_queue_list", {})).isError).toBe(false);
|
||||
expect(rows()).toBe(before);
|
||||
// Once the service lifts it, the same retry lands.
|
||||
answer = () => [200, active({ objects: ALL })];
|
||||
expect((await ask("rig_queue_create", { destination: "lead@team-a", body: "New work", qitemId: "qitem-new" })).isError).toBe(false);
|
||||
expect(rows()).toBe(before + 1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
["a string", "yes"],
|
||||
["a list", [true]],
|
||||
["new_work as text", { new_work: "true", retry_after_seconds: 30 }],
|
||||
["a delay as text", { new_work: true, retry_after_seconds: "30" }],
|
||||
["no delay", { new_work: true }],
|
||||
])("ignores a throttle it can't read (%s): nothing is refused, and the log says so", async (_label, throttle) => {
|
||||
const logged = vi.spyOn(console, "error").mockImplementation(() => {});
|
||||
answer = throttled(throttle);
|
||||
const { url } = await listen();
|
||||
const ask = await connect(url);
|
||||
expect((await ask("rig_queue_create", { destination: "lead@team-a", body: "Served" })).isError).toBe(false);
|
||||
expect(rows()).toBe(1);
|
||||
expect(logged.mock.calls.some(([line]) => String(line).includes("answered an unusable throttle, so it's ignored"))).toBe(true);
|
||||
logged.mockRestore();
|
||||
});
|
||||
|
||||
it("serves everything when new_work is false, and keeps a delay within 1 to 600 seconds, rounded up", async () => {
|
||||
answer = throttled({ new_work: false, retry_after_seconds: 30 });
|
||||
const { url } = await listen();
|
||||
const ask = await connect(url);
|
||||
expect((await ask("rig_queue_create", { destination: "lead@team-a", body: "Served" })).isError).toBe(false);
|
||||
for (const [given, kept] of [[0, 1], [-5, 1], [12.2, 13], [9000, 600]]) {
|
||||
answer = throttled({ new_work: true, retry_after_seconds: given });
|
||||
expect((await ask("rig_queue_create", { destination: "lead@team-a", body: "Held" })).structured.retryAfterSeconds).toBe(kept);
|
||||
}
|
||||
expect(rows()).toBe(1);
|
||||
});
|
||||
|
||||
it.each([
|
||||
["answers an error", () => new Response(JSON.stringify({ error: "boom" }), { status: 500, headers: { "Content-Type": "application/json" } })],
|
||||
["answers a body it can't parse", () => new Response("{", { status: 200, headers: { "Content-Type": "application/json" } })],
|
||||
])("writes nothing, and says an earlier attempt is unknown, when the check of whether the id landed %s", async (_label, failure) => {
|
||||
answer = throttled({ new_work: true, retry_after_seconds: 5 });
|
||||
const { url } = await listen();
|
||||
const ask = await connect(url);
|
||||
broken = (req) => req.method === "GET" && new URL(req.url).pathname === "/api/queue/qitem-unread" ? failure() : undefined;
|
||||
const held = await ask("rig_queue_create", { destination: "lead@team-a", body: "Maybe", qitemId: "qitem-unread" });
|
||||
broken = undefined;
|
||||
expect(held.structured).toMatchObject({ code: "fair_use_retry_later", outcome: "not_written", earlierAttempt: "unknown", qitemId: "qitem-unread" });
|
||||
expect(held.text).toContain("Whether an earlier attempt with this id was saved is unknown");
|
||||
expect(rows()).toBe(0);
|
||||
});
|
||||
});
|
||||
|
||||
it("a task parked on an internal child reads blocked, with no child id, owner or state anywhere", async () => {
|
||||
const { asExternal, asLead, mine } = await externalAndLead();
|
||||
const child = await create("lead@team-a", "qa@team-b", "SECRET child");
|
||||
|
||||
@@ -50,8 +50,6 @@ describe("agent network increment A: OAuth-connected assistants work with each o
|
||||
let serviceUrl: string;
|
||||
/** What each connection's grant names, by key; a key set to "revoked" is answered revoked. */
|
||||
let grants: Map<string, Record<string, string[]> | "revoked">;
|
||||
/** The keys whose active answer carries the grant service's fair-use throttle on new work. */
|
||||
let throttled: Set<string>;
|
||||
const closers: Array<() => Promise<void>> = [];
|
||||
const saved = { home: process.env.OPENRIG_HOME, session: process.env.OPENRIG_SESSION_NAME };
|
||||
|
||||
@@ -67,7 +65,6 @@ describe("agent network increment A: OAuth-connected assistants work with each o
|
||||
daemonUrl = `http://127.0.0.1:${(daemon.address() as AddressInfo).port}`;
|
||||
setSelfHostId(INSTANCE);
|
||||
grants = new Map([[A.key, NETWORK], [B.key, NETWORK]]);
|
||||
throttled = new Set();
|
||||
service = http.createServer((req, res) => {
|
||||
req.resume();
|
||||
req.on("end", () => {
|
||||
@@ -75,8 +72,7 @@ describe("agent network increment A: OAuth-connected assistants work with each o
|
||||
const who = key === A.key ? A : key === B.key ? B : null;
|
||||
const objects = who ? grants.get(who.key) : undefined;
|
||||
const body = !who || !objects ? { schema: SCHEMA, status: "unknown" }
|
||||
: objects === "revoked" ? { schema: SCHEMA, status: "revoked" }
|
||||
: { ...active(who, objects), ...(throttled.has(who.key) ? { throttle: { new_work: true, retry_after_seconds: 20 } } : {}) };
|
||||
: objects === "revoked" ? { schema: SCHEMA, status: "revoked" } : active(who, objects);
|
||||
res.writeHead(200, { "Content-Type": "application/json" }).end(JSON.stringify(body));
|
||||
});
|
||||
});
|
||||
@@ -117,7 +113,7 @@ describe("agent network increment A: OAuth-connected assistants work with each o
|
||||
const result = await client.callTool({ name, arguments: args });
|
||||
return { isError: result.isError === true, structured: result.structuredContent as Record<string, any>, text: (result.content as Array<{ text: string }>)[0]?.text ?? "" };
|
||||
};
|
||||
return Object.assign(call, { tools: async () => (await client.listTools()).tools.map((tool) => tool.name).sort(), instructions: () => client.getInstructions() });
|
||||
return Object.assign(call, { tools: async () => (await client.listTools()).tools.map((tool) => tool.name).sort() });
|
||||
}
|
||||
|
||||
const rows = () => (db.prepare("SELECT COUNT(*) AS n FROM queue_items").get() as { n: number }).n;
|
||||
@@ -178,42 +174,6 @@ describe("agent network increment A: OAuth-connected assistants work with each o
|
||||
expect((await a("rig_queue_show", { qitemId: reply })).text).toContain("Agreed; I'll review the fix.");
|
||||
});
|
||||
|
||||
it("under a fair-use throttle, B answers A's message on the same item and A reads that answer through its own grant; B's separate new message waits", async () => {
|
||||
const served = await listen();
|
||||
const a = await connect(served.url, A);
|
||||
const b = await connect(served.url, B);
|
||||
expect(b.instructions()).toContain("with your reply in resolution when it needs one; its sender reads that reply on the same item");
|
||||
expect(b.instructions()).not.toContain("with a new item to its sender");
|
||||
const message = createdId(await a("rig_queue_create", { destination: B.seat, summary: "Which fix first?", body: "Smaller fix or the full one?", tags: ["message"] }));
|
||||
throttled.add(B.key);
|
||||
const before = rows();
|
||||
expect((await b("rig_queue_list", { owned: true })).text).toContain(message);
|
||||
expect((await b("rig_queue_claim", { qitemId: message })).isError).toBe(false);
|
||||
expect((await b("rig_queue_update", { qitemId: message, state: "done", closureReason: "no-follow-on", resolution: "The smaller fix first." })).isError).toBe(false);
|
||||
const separate = await b("rig_queue_create", { destination: A.seat, summary: "Also", body: "One more thing.", tags: ["message"] });
|
||||
expect(separate).toMatchObject({ isError: true, structured: { code: "fair_use_retry_later", retryAfterSeconds: 20, outcome: "not_written" } });
|
||||
expect(rows()).toBe(before);
|
||||
// A, the sender, isn't throttled, and reads B's answer on its own item through its own grant's ordinary show and list.
|
||||
const answered = await a("rig_queue_show", { qitemId: message });
|
||||
expect(answered.structured.item).toMatchObject({ state: "done", resolution: "The smaller fix first.", destinationSession: B.seat });
|
||||
expect((await a("rig_queue_list", { mine: true, all: true })).text).toContain("The smaller fix first.");
|
||||
});
|
||||
|
||||
it("under a fair-use throttle, A answers the lead's message on the same item and the lead reads it on its ordinary read; A's new item to the lead waits", async () => {
|
||||
const served = await listen();
|
||||
const a = await connect(served.url, A);
|
||||
const message = (await repo.create({ sourceSession: LEAD, destinationSession: A.seat, body: "Can you take the review?", nudge: false } as never)).qitemId;
|
||||
throttled.add(A.key);
|
||||
const before = rows();
|
||||
expect((await a("rig_queue_claim", { qitemId: message })).isError).toBe(false);
|
||||
expect((await a("rig_queue_update", { qitemId: message, state: "done", closureReason: "no-follow-on", resolution: "Yes, after lunch." })).isError).toBe(false);
|
||||
expect((await a("rig_queue_create", { destination: LEAD, body: "Starting the review." })).structured).toMatchObject({ code: "fair_use_retry_later", outcome: "not_written" });
|
||||
expect(rows()).toBe(before);
|
||||
const read = await fetch(`${daemonUrl}/api/queue/${encodeURIComponent(message)}`, { headers: { "X-OpenRig-Session": LEAD } });
|
||||
expect(read.status).toBe(200);
|
||||
expect(await read.json()).toMatchObject({ sourceSession: LEAD, state: "done", resolution: "Yes, after lunch." });
|
||||
});
|
||||
|
||||
it("B hands work on to the team and reads the team's result; A's task and B's task are separate items, each with its own result", async () => {
|
||||
const served = await listen();
|
||||
const b = await connect(served.url, B);
|
||||
|
||||
@@ -1278,8 +1278,7 @@ reaching them is ordinary work rather than an escalation.
|
||||
- **The `relay` gateway connector** carries a registered person's questions, updates and notices to a
|
||||
bridge process you run, over loopback HTTP, and takes their replies back with the sender resolved
|
||||
against their bindings. It's off until a person has a relay binding (`rig gateway human add <id> …
|
||||
--binding "relay:<connectorRef>:file:<absolute env file>:primary:handle=<alias>"`). The handle is how
|
||||
their replies are matched to them: a binding without one is outbound-only. The bridge, with its reach to
|
||||
--binding "relay:<connectorRef>:file:<absolute env file>:primary"`), and the bridge, with its reach to
|
||||
any messaging platform, is yours (`docs/reference/gateway-relay.md`).
|
||||
- **`rig gateway channel add <id> --display-name <name> --binding
|
||||
slack:<connectorRef>:<secretsRef>:<channelId>`** — a Slack shared channel as one participant,
|
||||
@@ -1598,11 +1597,8 @@ your circumstances is configuration, and the ones that are not, another agent ca
|
||||
without that storage), so don't copy them by hand; read the `plugin_skill_*` warnings if one
|
||||
is missing. TDD is no longer a default skill.
|
||||
- **`on_restore: follow_source`** on a spec's `resources.skills[]` entry refreshes that skill from its source when
|
||||
a Claude or Codex seat is restored, keeping its conversation, while the seat's copy is still what OpenRig wrote: an
|
||||
edited, unrecorded or linked copy is kept and named, and a source that can't be read leaves the saved copy.
|
||||
`keep_saved`, the default, keeps the saved copy, but a missing file comes back only from a source that still has the
|
||||
bytes OpenRig wrote: a file whose source changed after `rig down` stays missing, named in the restore's warnings,
|
||||
even when the rest of the skill (its `SKILL.md`, say) is unchanged.
|
||||
a Claude or Codex seat is restored, keeping its conversation; `keep_saved`, the default, keeps the saved copy, but a
|
||||
skill whose source changed after `rig down` comes back missing, named in the restore's warnings.
|
||||
- **`rig startup-proof submit`** — answer an explicitly selected authenticated startup challenge.
|
||||
Startup adds no proof exercise by default. Declare `startup_proof` with `authenticated` or
|
||||
`none` in the applicable startup layers; see `docs/reference/rig-spec.md#startup-block/startup-proof-selection`.
|
||||
|
||||
@@ -16,7 +16,7 @@ import type {
|
||||
} from "../domain/runtime-adapter.js";
|
||||
import { resolveConcreteHint } from "../domain/runtime-adapter.js";
|
||||
import type { ProjectionPlan, ProjectionEntry } from "../domain/projection-planner.js";
|
||||
import { assessNativeResumeProbe, claudeTrustPromptFocus, hasClaudeDrawnInput } from "../domain/native-resume-probe.js";
|
||||
import { assessNativeResumeProbe, hasClaudeDrawnInput } from "../domain/native-resume-probe.js";
|
||||
import { resumeProbeEvidence } from "../domain/native-resume-probe-evidence.js";
|
||||
import { resolveReadinessTimeoutMs } from "../domain/readiness-timeout.js";
|
||||
import { subtreeNamesClaudeExecutable, claudeCommandSessionToken, listNativeProcesses, observeClaudeDelivery, observeClaudePaneProcess, observeClaudePaneRuntime, observeCodexPaneProcess, verifyClaudePaneProcess, verifyCodexPaneProcess, verifyPaneIdleShell, type ClaudeLaunchedProcess, type NativeProcessLister } from "../domain/native-process-lineage.js";
|
||||
@@ -709,10 +709,6 @@ export class ClaudeCodeAdapter implements RuntimeAdapter {
|
||||
const checkEvery = 5;
|
||||
let attempts = windowAttempts;
|
||||
let slowStart = false;
|
||||
// #2820 item 2: the trust prompt's selection was moved from "No, exit" (once: its two options wrap), and the prompt
|
||||
// was confirmed (once: a frame drawn before Claude took the Enter still shows the prompt).
|
||||
let trustMoved = false;
|
||||
let trustEntered = false;
|
||||
|
||||
for (let attempt = 0; attempt < attempts; attempt++) {
|
||||
const paneCommand = await this.tmux.getPaneCommand(tmuxSession);
|
||||
@@ -753,25 +749,9 @@ export class ClaudeCodeAdapter implements RuntimeAdapter {
|
||||
slowStart = false;
|
||||
break;
|
||||
}
|
||||
// #2820 item 2: Enter confirms the focused option, and Claude Code 2.1.322 opens this prompt on "No, exit". So
|
||||
// Enter goes once, and only with the focus read on "Yes, I trust this folder" of the plain prompt's two options.
|
||||
// On "No, exit" the selection moves down once (the two options wrap: a second Down would go back) and the next
|
||||
// polls wait to see the focus on "Yes". A screen with no key to send (another option set, no cursor, a focus
|
||||
// that never reaches "Yes") gets no confirmation; in the longer wait it ends at once, as without the auto-drive.
|
||||
const focus = claudeTrustPromptFocus(paneContent);
|
||||
const key = focus === "yes" && !trustEntered ? "Enter" : focus === "no" && !trustMoved ? "Down" : null;
|
||||
if (!key) {
|
||||
if (slowStart && !trustMoved && !trustEntered) {
|
||||
slowStart = false;
|
||||
break;
|
||||
}
|
||||
await this.sleep(200);
|
||||
continue;
|
||||
}
|
||||
if (key === "Enter") trustEntered = true; else trustMoved = true;
|
||||
const keyResult = await this.tmux.sendKeys(tmuxSession, [key]);
|
||||
if (!keyResult.ok) {
|
||||
return { ok: false, error: `Claude trust prompt auto-drive failed: ${keyResult.message}`,
|
||||
const enterResult = await this.tmux.sendKeys(tmuxSession, ["Enter"]);
|
||||
if (!enterResult.ok) {
|
||||
return { ok: false, error: `Claude trust prompt auto-drive failed: ${enterResult.message}`,
|
||||
probe: await resumeProbeEvidence(probe, paneContent, this.tmux, tmuxSession) };
|
||||
}
|
||||
await this.sleep(200);
|
||||
|
||||
@@ -12,7 +12,6 @@ import { networkReceiptsSchema } from "./migrations/161_network_receipts.js";
|
||||
import { sessionAddressReadIndexesSchema } from "./migrations/162_session_address_read_indexes.js";
|
||||
import { networkInstallationsSchema } from "./migrations/163_network_installations.js";
|
||||
import { queueItemsReplyToIndexSchema } from "./migrations/164_queue_items_reply_to_index.js";
|
||||
import { queueListReadIndexesSchema } from "./migrations/166_queue_list_read_indexes.js";
|
||||
import { activityGrantsSchema } from "./migrations/143_activity_grants.js";
|
||||
import { environmentBindingsSchema } from "./migrations/144_environment_bindings.js";
|
||||
import { nodePermissionsToSchema } from "./migrations/145_node_permissions_to.js";
|
||||
@@ -332,5 +331,4 @@ export const ALL_MIGRATIONS: Migration[] = [
|
||||
sessionAddressReadIndexesSchema,
|
||||
networkInstallationsSchema,
|
||||
queueItemsReplyToIndexSchema,
|
||||
queueListReadIndexesSchema,
|
||||
];
|
||||
@@ -1,18 +0,0 @@
|
||||
import type { Migration } from "../migrate.js";
|
||||
|
||||
/** Bound queue selection by its existing order, and notification reads by their eligible history. */
|
||||
export const queueListReadIndexesSchema: Migration = {
|
||||
name: "166_queue_list_read_indexes.sql",
|
||||
sql: `
|
||||
CREATE INDEX IF NOT EXISTS idx_queue_items_created
|
||||
ON queue_items(ts_created DESC);
|
||||
CREATE INDEX IF NOT EXISTS idx_queue_items_active_created
|
||||
ON queue_items(CASE WHEN state IN ('pending', 'in-progress', 'blocked') THEN 0 ELSE 1 END, ts_created DESC);
|
||||
CREATE INDEX IF NOT EXISTS idx_queue_items_active_updated
|
||||
ON queue_items(CASE WHEN state IN ('pending', 'in-progress', 'blocked') THEN 0 ELSE 1 END, ts_updated DESC);
|
||||
CREATE INDEX IF NOT EXISTS idx_queue_transitions_owner_notification_qitem
|
||||
ON queue_transitions(qitem_id, transition_id DESC) WHERE owner_notification_level IS NOT NULL;
|
||||
CREATE INDEX IF NOT EXISTS idx_queue_transitions_archive_owner_notification_qitem
|
||||
ON queue_transitions_archive(qitem_id, transition_id DESC) WHERE owner_notification_level IS NOT NULL;
|
||||
`,
|
||||
};
|
||||
@@ -136,24 +136,6 @@ export function assessNativeResumeProbe(
|
||||
detail: "Claude is at a resume-selection prompt; an operator must choose the conversation to continue.",
|
||||
};
|
||||
}
|
||||
// #2820 item 2: the gated-grants backstop is never answered by OpenRig (not even with
|
||||
// recovery.auto_drive_provider_prompts): its default choice declines the folder's pre-approved tool permissions or
|
||||
// exits, and approving them is the person's call. Checked before the plain trust prompt, whose texts it shares.
|
||||
const gatedGrants = claudeGatedGrantsPrompt(paneContent);
|
||||
if (gatedGrants === "live") {
|
||||
return {
|
||||
status: "attention_required",
|
||||
code: "claude_gated_grants_gate",
|
||||
detail: `Claude is at its workspace trust check that warns "This folder pre-approves N tool permissions" (from the folder's .claude/settings.json)${focusedChoice(paneContent)}. Review and choose in the seat's pane. OpenRig does not approve or bypass this review. No input was sent.`,
|
||||
};
|
||||
}
|
||||
if (gatedGrants === "partial") {
|
||||
return {
|
||||
status: "inconclusive",
|
||||
code: "awaiting_runtime",
|
||||
detail: "Claude is still drawing its workspace trust check for the folder's pre-approved tool permissions.",
|
||||
};
|
||||
}
|
||||
if (looksLikeClaudeTrustPrompt(paneContent)) {
|
||||
return {
|
||||
status: "inconclusive",
|
||||
@@ -361,112 +343,9 @@ function looksLikeClaudeBypassConsentPrompt(paneContent: string): boolean {
|
||||
return /\b(?:in|running in) Bypass Permissions mode\./.test(lines.slice(0, -3).join(" ").replace(/\s+/g, " "));
|
||||
}
|
||||
|
||||
// Claude Code's "gated grants" backstop (2.1.319+, #2820 item 2). Its marks, which the plain workspace trust prompt
|
||||
// lacks: the warning that the folder's .claude/settings.json pre-approves tool permissions, and the option that
|
||||
// declines them. Its default choice declines them ("No, continue without these permissions") or exits ("No, exit").
|
||||
// The marks are read on the whitespace-joined screen too, so a row that a narrow pane wraps still counts.
|
||||
const CLAUDE_GATED_GRANTS_MARK = /This folder pre-approves \d+ tool permissions?\b|No, continue without these permissions/;
|
||||
// One row of the backstop's marks, or of a part of one that a narrow pane wrapped.
|
||||
const CLAUDE_GATED_GRANTS_MARK_ROW = /This folder pre-approves\b|No, continue without\b|without these permissions\b/;
|
||||
const CLAUDE_TRUST_FOOTER = "Enter to confirm · Esc to cancel";
|
||||
const CLAUDE_TRUST_YES = "Yes, I trust this folder";
|
||||
const CLAUDE_TRUST_EXIT = "No, exit";
|
||||
// An option row of Claude's select: an optional cursor (❯ or ›), an optional "1." and a "Yes, …" or "No, …" label.
|
||||
const CLAUDE_TRUST_OPTION_ROW = /^\s*([❯›]\s*)?(?:\d+\.\s+)?((?:Yes|No), .*?)\s*$/;
|
||||
|
||||
/** The gated-grants backstop on Claude's current screen (claudeCurrentRows): "live" when it is complete ("Enter to
|
||||
* confirm · Esc to cancel" is the last drawn row, with "Yes, I trust this folder" above it); "partial" while it is
|
||||
* still being drawn; null when the current screen has none. A backstop left in the scrollback above a session that
|
||||
* started is not current. The "Accessing workspace:" heading is not required: a long permission list can push it
|
||||
* out of the capture. */
|
||||
function claudeGatedGrantsPrompt(paneContent: string): "live" | "partial" | null {
|
||||
const rows = claudeCurrentRows(paneContent);
|
||||
if (!hasClaudeGatedGrantsMark(rows)) return null;
|
||||
const mark = rows.map(row => CLAUDE_GATED_GRANTS_MARK_ROW.test(row)).lastIndexOf(true);
|
||||
const drawn = rows.slice(Math.max(mark, 0)).filter(row => row.trim()).map(row => row.trim());
|
||||
if (drawn.at(-1) !== CLAUDE_TRUST_FOOTER) return "partial";
|
||||
return drawn.some(row => CLAUDE_TRUST_OPTION_ROW.exec(row)?.[2] === CLAUDE_TRUST_YES) ? "live" : "partial";
|
||||
}
|
||||
|
||||
/** A mark of the gated-grants backstop in these rows: on their whitespace-joined text, so a row that a narrow pane
|
||||
* wrapped still counts, or on a single row, so a warning still being drawn ("This folder pre-approves 2 tool" before
|
||||
* the next row) counts too. */
|
||||
function hasClaudeGatedGrantsMark(rows: string[]): boolean {
|
||||
return CLAUDE_GATED_GRANTS_MARK.test(rows.join(" ").replace(/\s+/g, " "))
|
||||
|| rows.some(row => CLAUDE_GATED_GRANTS_MARK_ROW.test(row));
|
||||
}
|
||||
|
||||
/** The rows Claude drew after its last own element (input frame, header or reply): the screen a prompt is on now.
|
||||
* Text above a session that started (a scrollback, a reply quoting a prompt's words) never decides what is current,
|
||||
* and neither does a draft in the input box: an input frame ends at its closing rule. */
|
||||
function claudeCurrentRows(paneContent: string): string[] {
|
||||
const rows = claudeWithoutDrafts(paneContent.trimEnd().split(/\r?\n/));
|
||||
let current = rows;
|
||||
for (let at = rows.length - 1; at >= 0; at--) {
|
||||
if (!claudeDrawnAfter(rows.slice(at))) continue;
|
||||
const framed = CLAUDE_INPUT_RULE.test(rows[at]!) && /^\s*❯/.test(rows[at + 1] ?? "");
|
||||
const closing = framed ? rows.findIndex((row, index) => index > at + 1 && CLAUDE_INPUT_RULE.test(row)) : -1;
|
||||
current = rows.slice((closing >= 0 ? closing : at) + 1);
|
||||
break;
|
||||
}
|
||||
// An input frame still being drawn (its opening rule and the ❯ row, no closing rule yet) holds a draft, not a dialog.
|
||||
const opening = current.findIndex((row, index) => CLAUDE_INPUT_RULE.test(row) && /^\s*❯/.test(current[index + 1] ?? ""));
|
||||
return opening >= 0 ? current.slice(0, opening) : current;
|
||||
}
|
||||
|
||||
/** These rows with the text of every draft in Claude's input frames blanked (the ❯ kept), so a rule, a reply or a
|
||||
* header pasted into a draft never reads as Claude's own UI. Claude draws the frame's rules from column 0 and a
|
||||
* draft's continuation rows indented under the ❯, so a frame opens at a column-0 rule over the ❯ row and the first
|
||||
* column-0 rule after it closes the frame; a frame with no closing rule yet holds a draft to the end. A frame quoted
|
||||
* in a reply is indented like the reply: it blanks nothing. */
|
||||
function claudeWithoutDrafts(rows: string[]): string[] {
|
||||
const shown = [...rows];
|
||||
for (let at = 0; at < rows.length; at++) {
|
||||
if (!CLAUDE_FRAME_RULE.test(rows[at]!) || !/^\s*❯/.test(rows[at + 1] ?? "")) continue;
|
||||
const closing = rows.findIndex((row, index) => index > at + 1 && CLAUDE_FRAME_RULE.test(row));
|
||||
const end = closing >= 0 ? closing : rows.length;
|
||||
shown[at + 1] = rows[at + 1]!.replace(/❯.*$/, "❯");
|
||||
for (let index = at + 2; index < end; index++) shown[index] = "";
|
||||
at = end - 1;
|
||||
}
|
||||
return shown;
|
||||
}
|
||||
|
||||
/** ", with \"<label>\" highlighted" for the detail of the gated-grants gate, or nothing when no option is focused. */
|
||||
function focusedChoice(paneContent: string): string {
|
||||
const label = claudeFocusedOption(paneContent);
|
||||
return label ? `, with "${label}" highlighted` : "";
|
||||
}
|
||||
|
||||
/** The label of the focused option on Claude's current screen (the row with ❯ or ›), if one is drawn. */
|
||||
function claudeFocusedOption(paneContent: string): string | null {
|
||||
const focused = claudeCurrentRows(paneContent).map(row => CLAUDE_TRUST_OPTION_ROW.exec(row)).filter(match => match?.[1]);
|
||||
return focused.at(-1)?.[2] ?? null;
|
||||
}
|
||||
|
||||
/** The focus of Claude's plain workspace trust prompt (#2820 item 2), read from its last 12 drawn rows. An allowlist:
|
||||
* "yes" or "no" only when the prompt's options are exactly "No, exit" and "Yes, I trust this folder" (in either
|
||||
* order, numbered or not) and one of them carries the cursor (❯ or ›): "yes" on "Yes, I trust this folder", "no" on
|
||||
* "No, exit" (Claude Code 2.1.322 opens the plain prompt there). Anything else is "unknown": another option set (the
|
||||
* gated-grants backstop's "No, continue without these permissions" included), no cursor, or more than one. */
|
||||
export function claudeTrustPromptFocus(paneContent: string): "yes" | "no" | "unknown" {
|
||||
const rows = paneContent.trimEnd().split(/\r?\n/).filter(row => row.trim()).slice(-12);
|
||||
const options = rows.map(row => CLAUDE_TRUST_OPTION_ROW.exec(row)).filter(match => match !== null);
|
||||
const labels = options.map(match => match[2]);
|
||||
if (labels.length !== 2 || !labels.includes(CLAUDE_TRUST_YES) || !labels.includes(CLAUDE_TRUST_EXIT)) return "unknown";
|
||||
const focused = options.filter(match => match[1]);
|
||||
if (focused.length !== 1) return "unknown";
|
||||
return focused[0]![2] === CLAUDE_TRUST_YES ? "yes" : "no";
|
||||
}
|
||||
|
||||
function looksLikeClaudeTrustPrompt(paneContent: string): boolean {
|
||||
// #2820 item 2: read on Claude's current screen only, and a screen with the backstop's marks is never the plain
|
||||
// trust prompt, even still drawn: pressing Enter on it would decline the folder's grants or exit.
|
||||
const current = claudeCurrentRows(paneContent);
|
||||
const text = current.join("\n");
|
||||
return text.includes("Accessing workspace:")
|
||||
&& text.includes("Yes, I trust this folder")
|
||||
&& !hasClaudeGatedGrantsMark(current);
|
||||
return paneContent.includes("Accessing workspace:")
|
||||
&& paneContent.includes("Yes, I trust this folder");
|
||||
}
|
||||
|
||||
// Claude's resume-selection prompt appears when `claude --resume` finds multiple
|
||||
@@ -549,8 +428,6 @@ function claudeDrawnAfter(rows: string[]): boolean {
|
||||
|
||||
// On a named session Claude labels the frame's top rule (`─────…── probe-claude@rig ─`), so a rule may carry text after a space.
|
||||
const CLAUDE_INPUT_RULE = /^\s*─{3,}(?:\s.*)?$/;
|
||||
// The same rule drawn from column 0, as Claude draws its frame: a rule indented like a draft's row is the draft's.
|
||||
const CLAUDE_FRAME_RULE = /^─{3,}(?:\s.*)?$/;
|
||||
|
||||
/** Claude's input frame: a rule, the ❯ row directly under it, and another rule below. A composer holding a draft that
|
||||
* starts with "1." looks like a numbered option row; the frame is what tells them apart. */
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
import { createHash, randomUUID } from "node:crypto";
|
||||
import { appendFileSync, closeSync, openSync, readSync, statSync } from "node:fs";
|
||||
import type Database from "better-sqlite3";
|
||||
import { isOpenRigSender, OPENRIG_SENDER } from "../lib/pane-envelope.js";
|
||||
|
||||
/**
|
||||
* Queue erasure: the maintained way to remove queue content, for closed-work retention and account deletion on a
|
||||
@@ -14,13 +13,11 @@ import { isOpenRigSender, OPENRIG_SENDER } from "../lib/pane-envelope.js";
|
||||
* The row's own copies follow it: its transitions, live and archived; events whose payload names it; its
|
||||
* mission-control audit rows. Copies another party holds (outbox and inbox entries, stream reader actions and
|
||||
* dispositions) go only when they're the owner's: both endpoints the account's (members scope) or the row's own
|
||||
* (other scopes). Others are kept and reported. OpenRig's own sessions (`daemon@kernel`, `system:*`), which send its
|
||||
* wakes and notices, are no one's: a row, copy or entry is judged by its other sessions, and needs one of them.
|
||||
* (other scopes). Others are kept and reported.
|
||||
*
|
||||
* Scope is exact. Account deletion takes the account's recorded membership (exact session names): a row between two
|
||||
* members, or between a member and OpenRig, is deleted, whatever its state; a row with one member endpoint and the
|
||||
* other outside the account is reported as mixed and left untouched. Named with the account's rig, it also removes
|
||||
* the rig's own records that outlive the rig. Routine
|
||||
* Scope is exact. Account deletion takes the account's recorded membership (exact session names): a row whose two
|
||||
* endpoints are both members is deleted, whatever its state; a row with one member endpoint is reported as mixed and
|
||||
* left untouched. Named with the account's rig, it also removes the rig's own records that outlive the rig. Routine
|
||||
* retention touches only closed rows (done, canceled, denied, handed-off; never failed or open work), aged from the
|
||||
* start of their final closed state. A row a workflow still references is reported, never erased.
|
||||
*
|
||||
@@ -98,8 +95,7 @@ export interface EraseReport {
|
||||
error?: { stage: Stage; message: string };
|
||||
/** rows erased (applied, committed) or that would be (dry run) */
|
||||
qitems: Array<{ qitemId: string; action: EraseAction; state: string }>;
|
||||
/** members scope: rows with one member endpoint and the other outside the account (OpenRig's own isn't), left
|
||||
* untouched */
|
||||
/** members scope: rows with exactly one member endpoint, left untouched */
|
||||
mixed: Array<{ qitemId: string; memberEndpoint: "source" | "destination" }>;
|
||||
/** rows not erased, and why: a workflow references them; (ids scope) no such row to scrub; the row changed after
|
||||
* selection so it no longer qualifies (reopened, rerouted out of the account, written to out of its window, or an
|
||||
@@ -120,8 +116,7 @@ export interface EraseReport {
|
||||
unreadableEvents: Array<{ seq: number; qitemIds: string[] }>;
|
||||
/** copies erased with the rows, or that would be */
|
||||
linked: { transitions: number; archivedTransitions: number; outbox: number; inbox: number; events: number; streamActions: number; missionControl: number };
|
||||
/** members scope: entries no queue row owns between members, or a member and OpenRig; mixed ones are counted and
|
||||
* left */
|
||||
/** members scope: entries between members that no queue row owns; mixed ones are counted and left */
|
||||
unlinked?: { outbox: number; inbox: number; streamItems: number; mixedEntries: number; referencedStreamItems: number };
|
||||
/** members scope with rig: whether the rig was found and verified, its records erased and left per table, the
|
||||
* tables whose records can't be counted (an unverified removed rig), and when its erasure completed */
|
||||
@@ -430,9 +425,6 @@ export async function eraseQueue(db: Database.Database, opts: EraseOptions): Pro
|
||||
const ledgerReason = (action: EraseAction) => scope.kind === "routine" && action === "scrub" ? "retention-content" : reason;
|
||||
const memberSet = new Set(scope.kind === "members" ? scope.members : []);
|
||||
const members = JSON.stringify([...memberSet]);
|
||||
// Members scope: a row is the account's when one endpoint is a member and the other is a member or OpenRig's own.
|
||||
const accountRow = (source: string, destination: string) => (memberSet.has(source) || memberSet.has(destination))
|
||||
&& (memberSet.has(source) || isOpenRigSender(source)) && (memberSet.has(destination) || isOpenRigSender(destination));
|
||||
// A ledger replay applies only the batches that committed, by their own commit line or this database's record of
|
||||
// them. A rolled-back batch is skipped; one that is neither is reported and never replayed.
|
||||
let listed = scope.kind === "ids" ? scope.entries : [];
|
||||
@@ -496,8 +488,10 @@ export async function eraseQueue(db: Database.Database, opts: EraseOptions): Pro
|
||||
ORDER BY qitem_id LIMIT @limit`).all({ members, after, limit: batchSize }) as Array<Omit<Candidate, "action">>;
|
||||
const rows: Candidate[] = [];
|
||||
for (const row of found) {
|
||||
if (accountRow(row.source, row.destination)) rows.push({ ...row, action: "delete" });
|
||||
else report.mixed.push({ qitemId: row.qitemId, memberEndpoint: memberSet.has(row.source) ? "source" : "destination" });
|
||||
const fromMember = memberSet.has(row.source);
|
||||
const toMember = memberSet.has(row.destination);
|
||||
if (fromMember && toMember) rows.push({ ...row, action: "delete" });
|
||||
else report.mixed.push({ qitemId: row.qitemId, memberEndpoint: fromMember ? "source" : "destination" });
|
||||
}
|
||||
return { rows, last: found.at(-1)?.qitemId ?? null, seen: found.length };
|
||||
}
|
||||
@@ -517,14 +511,10 @@ export async function eraseQueue(db: Database.Database, opts: EraseOptions): Pro
|
||||
|
||||
// Whose copies these are: the account's (members scope), or the row's own participants (other scopes).
|
||||
const ownerOf = (candidate: Candidate) => scope.kind === "members" ? memberSet : new Set([candidate.source, candidate.destination]);
|
||||
// OpenRig's own sessions (its wake for the row, say) aren't counted when the copy has any other: an OpenRig wake to
|
||||
// the owner is the owner's, and one to no owner is foreign.
|
||||
const ownership = (copy: Copy, owners: Set<string>): "owned" | "mixed" | "foreign" => {
|
||||
const sessions = copy.sessions.filter((session): session is string => session !== null);
|
||||
const others = sessions.filter((session) => !isOpenRigSender(session));
|
||||
const counted = others.length > 0 ? others : sessions;
|
||||
const owned = counted.filter((session) => owners.has(session)).length;
|
||||
return owned === counted.length ? "owned" : owned > 0 ? "mixed" : "foreign";
|
||||
const owned = sessions.filter((session) => owners.has(session)).length;
|
||||
return owned === sessions.length ? "owned" : owned > 0 ? "mixed" : "foreign";
|
||||
};
|
||||
// Stream actions and dispositions this run deletes, so the unlinked pass plans on the same references either way.
|
||||
const plannedActions: string[] = [];
|
||||
@@ -645,7 +635,7 @@ export async function eraseQueue(db: Database.Database, opts: EraseOptions): Pro
|
||||
else plan.dropped.push({ code: "changed-during-run", qitemId: candidate.qitemId });
|
||||
} else if (referenced.has(candidate.qitemId)) {
|
||||
plan.dropped.push({ code: "workflow-reference", qitemId: candidate.qitemId });
|
||||
} else if (scope.kind === "members" && !accountRow(now.source, now.destination)) {
|
||||
} else if (scope.kind === "members" && !(memberSet.has(now.source) && memberSet.has(now.destination))) {
|
||||
// Rerouted since selection (a fallback, say): no longer the account's own row.
|
||||
plan.dropped.push({ code: "changed-during-run", qitemId: candidate.qitemId });
|
||||
} else if (scope.kind === "routine" && routineAction(now) !== candidate.action) {
|
||||
@@ -797,11 +787,10 @@ export async function eraseQueue(db: Database.Database, opts: EraseOptions): Pro
|
||||
return report;
|
||||
}
|
||||
|
||||
/** Account deletion's second pass: outbox and inbox entries no queue row owns between two members, or between a
|
||||
* member and OpenRig (its wake for a row erased earlier, say), and the members' stream items. An entry with one
|
||||
* member endpoint and the other outside the account, or a stream item something still references, is counted and
|
||||
* left. Rows and references this run erases are counted as they were before it, so a dry run and an apply report the
|
||||
* same set. */
|
||||
/** Account deletion's second pass: outbox and inbox entries between two members that no queue row owns, and the
|
||||
* members' stream items. An entry with one member endpoint, or a stream item something still references, is counted
|
||||
* and left. Rows and references this run erases are counted as they were before it, so a dry run and an apply report
|
||||
* the same set. */
|
||||
function eraseUnlinked(db: Database.Database, st: Statements,
|
||||
plan: { members: string; plannedActions: string[]; plannedDispositions: string[]; erasedRows: string[] }, apply: boolean): NonNullable<EraseReport["unlinked"]> {
|
||||
// A row this run erased still owns its copies here: they were reported with it (keptCopies), not as unowned.
|
||||
@@ -810,14 +799,9 @@ function eraseUnlinked(db: Database.Database, st: Statements,
|
||||
const ownedOutbox = `(COALESCE(audit_pointer, '') IN ${rows}
|
||||
OR (outbox_id LIKE 'wake-intent-%' AND substr(outbox_id, 13) IN ${rows}))`;
|
||||
const ownedInbox = `(COALESCE(absorbed_qitem_id, '') IN ${rows} OR COALESCE(audit_pointer, '') IN ${rows})`;
|
||||
// A member, or OpenRig's own session: isOpenRigSender in SQL. The prefix is compared exactly, since LIKE ignores
|
||||
// ASCII case and reads _ as a wildcard.
|
||||
const accountSide = (column: string) =>
|
||||
`(${column} IN ${MEMBERS} OR ${column} = '${OPENRIG_SENDER}' OR substr(${column}, 1, 7) = 'system:')`;
|
||||
const both = `${accountSide("sender_session")} AND ${accountSide("destination_session")}
|
||||
AND (sender_session IN ${MEMBERS} OR destination_session IN ${MEMBERS})`;
|
||||
const fromMember = `sender_session IN ${MEMBERS} AND NOT ${accountSide("destination_session")}`;
|
||||
const toMember = `destination_session IN ${MEMBERS} AND NOT ${accountSide("sender_session")}`;
|
||||
const both = `sender_session IN ${MEMBERS} AND destination_session IN ${MEMBERS}`;
|
||||
const fromMember = `sender_session IN ${MEMBERS} AND destination_session NOT IN ${MEMBERS}`;
|
||||
const toMember = `destination_session IN ${MEMBERS} AND sender_session NOT IN ${MEMBERS}`;
|
||||
// The same references the stream pass keeps an item for (queue-retention pruneStreamItems), less this run's own.
|
||||
const classificationColumns = new Set((db.prepare("PRAGMA table_info(project_classifications)").all() as Array<{ name: string }>)
|
||||
.map((column) => column.name));
|
||||
|
||||
@@ -42,9 +42,7 @@ export function freshRecoveryId(db: Database.Database, qitemId: string, overdueD
|
||||
* idx_queue_items_recovery_tags' WHERE clause (migration 099) byte for byte, which is what lets the
|
||||
* planner read that small index instead of scanning and parsing every row. */
|
||||
const RECOVERY_TAG_ROWS = `(tags LIKE '%"recovery-for:%' OR tags LIKE '%\\%')`;
|
||||
// Unary + preserves the numeric CASE order but prevents a prefix match on the full-history listing
|
||||
// index. Both standalone lookups and the batch need the small recovery-tag index instead.
|
||||
const RECOVERY_ORDER = "ORDER BY +CASE WHEN state IN ('pending','in-progress','blocked') THEN 0 ELSE 1 END, ts_updated DESC, qitem_id DESC LIMIT 1";
|
||||
const RECOVERY_ORDER = "ORDER BY CASE WHEN state IN ('pending','in-progress','blocked') THEN 0 ELSE 1 END, ts_updated DESC, qitem_id DESC LIMIT 1";
|
||||
/** A listing's recovery index, built by SQLite's own json_each (the same values, and the same truthy excludeTag
|
||||
* test, as the per-row query): for each string tag value, the rows that carry it in RECOVERY_ORDER, and each row's
|
||||
* string values. Built lazily, on the first lookup inside `withRecoveryIndex`, so a listing that never asks (a
|
||||
|
||||
@@ -105,6 +105,7 @@ import { armQueueWait, backOffQueueWait, refreshQueueWaits, evaluateQueueWait, r
|
||||
import { parseHumanQuestions, unansweredQuestions, describeTypedReplyPlacement, formatHumanAnswers, humanAnswerText, type HumanQuestion, type HumanAnswers, type TypedHumanReply, type RecordHumanAnswerResult } from "./human-questions.js";
|
||||
import { slackMicros } from "./gateway/slack/state-store.js";
|
||||
import { askBackRoute, RUNNER_CLOSE_WAITS, terminalAnswerMeaning } from "./receiver-context.js";
|
||||
import { runSyncSite, runSyncSiteWhenSlow } from "./sync-site-wrap.js";
|
||||
|
||||
/** A direct ask's answer row ID: from the ask, or from the ask and the park episode its answer belongs to. */
|
||||
function humanAnswerId(askId: string, episodeKey?: string): string {
|
||||
@@ -821,14 +822,14 @@ export function createLinkedSuccessorLookup(db: Database.Database, sourceQitemId
|
||||
const startedAt = performance.now();
|
||||
const map = new Map<string, Array<{ qitemId: string; destination: string | null }>>();
|
||||
const ids = JSON.stringify([...sources]);
|
||||
const rows = db.prepare(
|
||||
const rows = runSyncSite("queue.linked_successors.build", () => db.prepare(
|
||||
`SELECT s.qitem_id, s.destination_session, s.handed_off_from AS source FROM queue_items s
|
||||
WHERE s.handed_off_from IN (SELECT value FROM json_each(?))
|
||||
UNION
|
||||
SELECT s.qitem_id, s.destination_session, j.value AS source FROM queue_items s, json_each(s.chain_of_record) j
|
||||
WHERE s.chain_of_record IS NOT NULL AND json_valid(s.chain_of_record)
|
||||
AND j.value IN (SELECT value FROM json_each(?))`,
|
||||
).all(ids, ids) as Array<{ qitem_id: string; destination_session: string | null; source: string }>;
|
||||
).all(ids, ids)) as Array<{ qitem_id: string; destination_session: string | null; source: string }>;
|
||||
for (const r of rows) {
|
||||
const list = map.get(r.source);
|
||||
const entry = { qitemId: r.qitem_id, destination: r.destination_session };
|
||||
@@ -2634,8 +2635,13 @@ export class QueueRepository {
|
||||
}
|
||||
|
||||
/** {@link handoff}'s whole act, synchronously: its transaction commits before this returns, and the wake is delivered
|
||||
* after commit without being awaited, so a synchronous caller (an answer's close path) can hand a row on. */
|
||||
* after commit without being awaited, so a synchronous caller (an answer's close path) can hand a row on. Named in
|
||||
* the slow-operation log, so a stall during a handoff is attributed to it. */
|
||||
private handoffNow(input: QueueHandoffInput): { closed: QueueItem; created: QueueItem } {
|
||||
return runSyncSite("queue.handoff", () => this.handoffWithin(input));
|
||||
}
|
||||
|
||||
private handoffWithin(input: QueueHandoffInput): { closed: QueueItem; created: QueueItem } {
|
||||
const source = this.getById(input.qitemId);
|
||||
if (!source) {
|
||||
throw new QueueRepositoryError(
|
||||
@@ -4563,8 +4569,9 @@ export class QueueRepository {
|
||||
typeof opts?.excludeOperationReply === "string" && opts.excludeOperationReply.length > 0
|
||||
? mcOperationTag(opts.excludeOperationReply)
|
||||
: null;
|
||||
// Named only when slow: it runs on every row read and on each row of the attention read.
|
||||
const replies = this.hasReplyToColumn
|
||||
? (excludeOp
|
||||
? runSyncSiteWhenSlow("queue.decision_revision.replies", () => excludeOp
|
||||
? (this.db
|
||||
.prepare(
|
||||
"SELECT qitem_id FROM queue_items WHERE reply_to = ? AND NOT (tags IS NOT NULL AND json_valid(tags) AND EXISTS (SELECT 1 FROM json_each(tags) WHERE value = ?)) ORDER BY ts_created, rowid",
|
||||
|
||||
@@ -115,8 +115,6 @@ export const ATTENTION_REQUIRED_READINESS_CODES = new Set([
|
||||
"login_required",
|
||||
"mcp_gate",
|
||||
"bypass_consent_gate",
|
||||
// Claude's gated-grants backstop (#2820 item 2): approving the folder's pre-approved tool permissions is the person's call.
|
||||
"claude_gated_grants_gate",
|
||||
// Claude's resume chooser or picker waits for a person to choose a conversation; startup stops waiting and says so.
|
||||
"claude_resume_selection_prompt",
|
||||
// Codex auth refusal (stored OAuth token can no longer be refreshed).
|
||||
|
||||
@@ -48,6 +48,8 @@ export interface SlowOperationInstrumentation {
|
||||
classify?: (value: T) => "ok" | "failed",
|
||||
): Promise<T>;
|
||||
recordRequest?(site: string, durationMs: number): void;
|
||||
/** A synchronous site's duration, recorded only at or above the slow threshold (runSyncSiteWhenSlow). */
|
||||
recordSlowSync?(site: string, durationMs: number, outcome: "ok" | "failed"): void;
|
||||
/** Bounded nonblocking diagnostic append; false means observation was dropped. */
|
||||
recordDiagnostic?(record: Record<string, unknown>): boolean;
|
||||
snapshot?(): SlowOperationSnapshot;
|
||||
@@ -262,6 +264,11 @@ export class SlowOpRecorder implements SlowOperationInstrumentation {
|
||||
this.recordMeasurement(`request:${site}`, durationMs);
|
||||
}
|
||||
|
||||
recordSlowSync(site: string, durationMs: number, outcome: "ok" | "failed" = "ok"): void {
|
||||
if (!Number.isFinite(durationMs) || durationMs < this.slowThresholdMs) return;
|
||||
this.recordMeasurement(site, durationMs, outcome);
|
||||
}
|
||||
|
||||
recordDiagnostic(record: Record<string, unknown>): boolean {
|
||||
this.diagnostic.offered++;
|
||||
const coverage = { ...this.diagnostic, pending: this.diagnosticIds.size,
|
||||
|
||||
@@ -10,6 +10,26 @@ export function runSyncSite<T>(site: string, fn: () => T): T {
|
||||
return recorder?.runSync ? recorder.runSync(site, fn) : fn();
|
||||
}
|
||||
|
||||
/**
|
||||
* runSyncSite for a site on a hot path (per request, per row), where a begin and an end record per call would crowd
|
||||
* the bounded log: it records only a call that took at least the recorder's slow threshold, and writes no begin
|
||||
* record, so a call that wedges the loop is named once it ends rather than while it runs.
|
||||
*/
|
||||
export function runSyncSiteWhenSlow<T>(site: string, fn: () => T): T {
|
||||
const record = recorder?.recordSlowSync?.bind(recorder);
|
||||
if (!record) return fn();
|
||||
const startedAt = performance.now();
|
||||
let outcome: "ok" | "failed" = "failed";
|
||||
try {
|
||||
const value = fn();
|
||||
outcome = "ok";
|
||||
return value;
|
||||
} finally {
|
||||
// Measurement only: a failing record never replaces fn's own result or error.
|
||||
try { record(site, performance.now() - startedAt, outcome); } catch { /* the recorder reports its own health */ }
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Async twin of runSyncSite: instruments a NON-blocking site through the
|
||||
* recorder's async `runStage` seam (falls back to a bare call when no recorder
|
||||
|
||||
@@ -2,7 +2,7 @@ import { readFileSync } from "node:fs";
|
||||
import { createHash } from "node:crypto";
|
||||
import { join, isAbsolute } from "node:path";
|
||||
import { getOpenRigHome } from "../../openrig-compat.js";
|
||||
import { SETTINGS_VALID_KEYS, describeSettingKey, type SettingKeyDescription, type SettingsStore, type ResolvedSetting } from "./settings-store.js";
|
||||
import { SETTINGS_VALID_KEYS, type SettingsStore, type ResolvedSetting } from "./settings-store.js";
|
||||
import { connectionsProjection, readConnectionConfiguration } from "../gateway/connections-projection.js";
|
||||
import { DEFAULT_CONFIG, INHERIT_INBOUND_DESTINATION, LEGACY_INBOUND_DESTINATION } from "../gateway/slack/config.js";
|
||||
import { projectionPath } from "../gateway/human-registry.js";
|
||||
@@ -13,13 +13,7 @@ import { describeDefaultReceiver, type DefaultReceiver } from "../default-receiv
|
||||
type Value = string | number | boolean | null;
|
||||
type State = "available" | "missing" | "malformed" | "unavailable";
|
||||
type Kind = "scalar" | "text" | "path" | "identity" | "url" | "names" | "paths" | "withheld";
|
||||
/** Each is optional and separate: the rules a value must meet, whether a write route exists for the key, when a change is
|
||||
* known to take effect, and (above, on the entry) whether this caller is shown the value. None implies another. */
|
||||
export interface BrowserEntryMetadata extends SettingKeyDescription {
|
||||
/** "daemon_restart" when the application guidance says so; otherwise "unknown": OpenRig does not guess. */
|
||||
appliesAt: "daemon_restart" | "unknown";
|
||||
}
|
||||
export interface BrowserEntry extends BrowserEntryMetadata {
|
||||
export interface BrowserEntry {
|
||||
key: string;
|
||||
group: "general" | "slack" | "people" | "hosts" | "health";
|
||||
value: Value;
|
||||
@@ -96,8 +90,6 @@ function sourceFile(file: string): { state: State; bytes: string | null } {
|
||||
try { return { state: "available", bytes: readFileSync(file, "utf8") }; }
|
||||
catch (error) { return { state: (error as NodeJS.ErrnoException).code === "ENOENT" ? "missing" : "unavailable", bytes: null }; }
|
||||
}
|
||||
/** The keys whose guidance below says a daemon restart or startup applies them. The browser test ties this to that text. */
|
||||
const DAEMON_RESTART_KEYS = new Set(["terminal.tmux_server", "retention.enabled"]);
|
||||
function application(key: string): string {
|
||||
if (key === "terminal.tmux_server") return "Selected at daemon restart; surviving sessions keep their previous server until deliberately stopped. See terminal status for the effective choice.";
|
||||
if (key === "ui.terminal.max_live_terminals") return "Legacy web client; unset resolver value, consumer fallback 2. No TUI limit implied.";
|
||||
@@ -127,8 +119,7 @@ export function settingsBrowser(store: SettingsStore, gateway: Record<string, un
|
||||
const d = safeValue(defaultValue, kind, redact);
|
||||
entries.push({ key, group, value: v.value, defaultValue: d.value, defaultKnown: defaultValue !== undefined && !["people", "hosts"].includes(group), source,
|
||||
visibility: source === "unavailable" ? "unavailable" : v.value === null && v.reason ? "withheld" : "shown",
|
||||
reason: v.reason ?? d.reason, scope, application: applied,
|
||||
...describeSettingKey(key), appliesAt: DAEMON_RESTART_KEYS.has(key) ? "daemon_restart" : "unknown" });
|
||||
reason: v.reason ?? d.reason, scope, application: applied });
|
||||
}
|
||||
const file = sourceFile(store.configPath);
|
||||
let generalState = file.state;
|
||||
|
||||
@@ -842,20 +842,6 @@ function coerceValue(key: SettingsValidKey, raw: string, workspaceRoot: string):
|
||||
// in `set()`. Lockstep with cli/src/config-store.ts KEY_CONSTRAINTS so the
|
||||
// daemon's HTTP write surface (/api/config POST) rejects the same input
|
||||
// the CLI rejects.
|
||||
/** What a validator can say about the values it accepts, kept on the validator itself so it cannot drift from it. */
|
||||
interface ConstraintMeta { choices?: readonly string[]; format?: string }
|
||||
type KeyConstraint = ((raw: string, coerced: string | number | boolean) => void) & { meta?: ConstraintMeta };
|
||||
function described(meta: ConstraintMeta, check: (raw: string, coerced: string | number | boolean) => void): KeyConstraint {
|
||||
return Object.assign(check, { meta });
|
||||
}
|
||||
/** A closed list of accepted strings: the list is both what is enforced and what the browser view reports. */
|
||||
function choiceConstraint(choices: readonly string[], message: (raw: string) => string, trim = false): KeyConstraint {
|
||||
return described({ choices }, (raw) => {
|
||||
if (!choices.includes(trim ? (raw ?? "").trim() : raw)) throw new Error(message(raw));
|
||||
});
|
||||
}
|
||||
const PROVIDER_SELECTED_CHOICES: readonly string[] = ["", "claude", "codex", "claude,codex", "codex,claude"];
|
||||
|
||||
function positiveIntegerConstraint(key: string) {
|
||||
return (raw: string, coerced: string | number | boolean): void => {
|
||||
if (!/^\d+$/.test((raw ?? "").trim()) || typeof coerced !== "number" || !Number.isInteger(coerced) || coerced <= 0) {
|
||||
@@ -864,6 +850,12 @@ function positiveIntegerConstraint(key: string) {
|
||||
};
|
||||
}
|
||||
|
||||
function wakeHumanRungConstraint(raw: string): void {
|
||||
if (raw !== "always" && raw !== "explicit-only") {
|
||||
throw new Error(`Invalid value for queue.wake_human_rung: must be "always" or "explicit-only", got "${raw}"`);
|
||||
}
|
||||
}
|
||||
|
||||
function percentageConstraint(key: string) {
|
||||
return (raw: string, coerced: string | number | boolean): void => {
|
||||
if (!/^\d+$/.test((raw ?? "").trim())
|
||||
@@ -876,10 +868,15 @@ function percentageConstraint(key: string) {
|
||||
};
|
||||
}
|
||||
|
||||
const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
"terminal.tmux_server": choiceConstraint(["inherit", "isolated"],
|
||||
(raw) => `Invalid value for terminal.tmux_server: must be "inherit" or "isolated", got "${raw}"`),
|
||||
"daemon.db_conflict": choiceConstraint(["warn", "stop"], () => "daemon.db_conflict must be warn or stop"),
|
||||
const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, (raw: string, coerced: string | number | boolean) => void>> = {
|
||||
"terminal.tmux_server": (raw) => {
|
||||
if (raw !== "inherit" && raw !== "isolated") {
|
||||
throw new Error(`Invalid value for terminal.tmux_server: must be "inherit" or "isolated", got "${raw}"`);
|
||||
}
|
||||
},
|
||||
"daemon.db_conflict": (raw) => {
|
||||
if (raw !== "warn" && raw !== "stop") throw new Error("daemon.db_conflict must be warn or stop");
|
||||
},
|
||||
"daemon.seat_poll_interval_ms": (raw, value) => {
|
||||
// Startup-only: the seat pollers read it once when the daemon starts. Only slower than the 1 s default, up to the
|
||||
// ceiling the structural observation's expiry allows (seat-activity-service.ts MAX_SEAT_POLL_INTERVAL_MS).
|
||||
@@ -887,8 +884,9 @@ const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
throw new Error("Invalid daemon.seat_poll_interval_ms: must be a whole number of milliseconds in [1000, 2000]");
|
||||
}
|
||||
},
|
||||
"transport.draft_delivery": choiceConstraint(["refuse", "deliver"],
|
||||
(raw) => `Invalid value for transport.draft_delivery: must be "refuse" or "deliver", got "${raw}"`),
|
||||
"transport.draft_delivery": (raw) => {
|
||||
if (raw !== "refuse" && raw !== "deliver") throw new Error(`Invalid value for transport.draft_delivery: must be "refuse" or "deliver", got "${raw}"`);
|
||||
},
|
||||
"transcripts.lines": (raw, value) => {
|
||||
if (!/^\d+$/.test(raw.trim()) || typeof value !== "number" || !Number.isSafeInteger(value) || value < 1 || value > 1_000_000) {
|
||||
throw new Error("Invalid transcripts.lines: must be an integer in [1, 1000000]");
|
||||
@@ -930,34 +928,37 @@ const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
throw new Error(`Invalid value for daemon.port: must be an integer in [0, 65535], got "${raw}"`);
|
||||
}
|
||||
},
|
||||
"ui.timezone": described({ format: "iana-timezone" }, (_raw, value) => {
|
||||
"ui.timezone": (_raw, value) => {
|
||||
try {
|
||||
if (typeof value !== "string" || !value || /^[+-]/.test(value)) throw new Error();
|
||||
new Intl.DateTimeFormat("en-US", { timeZone: value });
|
||||
} catch { throw new Error("Invalid ui.timezone: use an IANA timezone such as America/Los_Angeles or Europe/London"); }
|
||||
}),
|
||||
},
|
||||
"health.context_pressure.warning_percent": percentageConstraint("health.context_pressure.warning_percent"),
|
||||
"health.context_pressure.critical_percent": percentageConstraint("health.context_pressure.critical_percent"),
|
||||
"policies.idle_gate_qitem.scan_interval_seconds": positiveIntegerConstraint("policies.idle_gate_qitem.scan_interval_seconds"),
|
||||
"policies.idle_gate_qitem.active_wake_interval_seconds": positiveIntegerConstraint("policies.idle_gate_qitem.active_wake_interval_seconds"),
|
||||
"policies.idle_gate_qitem.auto_register": choiceConstraint(["off", "all"],
|
||||
(raw) => `Invalid value for policies.idle_gate_qitem.auto_register: must be "off" or "all", got "${raw}"`, true),
|
||||
"policies.idle_gate_qitem.auto_register": (raw) => {
|
||||
const v = (raw ?? "").trim();
|
||||
if (v !== "off" && v !== "all") {
|
||||
throw new Error(`Invalid value for policies.idle_gate_qitem.auto_register: must be "off" or "all", got "${raw}"`);
|
||||
}
|
||||
},
|
||||
// Policy threshold: integer in [1, 100]. Documented contract from
|
||||
// slice 27 README. parseInt's permissive coercion ("80abc" → 80;
|
||||
// "80.5" → 80) is not safe for a key the daemon's compaction trigger
|
||||
// reads at every poll tick; runtime validator rejects what the
|
||||
// contract forbids per banked feedback_static_gates_mirror_runtime_validators.
|
||||
// Checks the typed value too: a config.json array would otherwise pass as its String() form.
|
||||
"provider.selected": described({ choices: PROVIDER_SELECTED_CHOICES }, (_raw, value) => {
|
||||
if (typeof value !== "string" || !PROVIDER_SELECTED_CHOICES.includes(value)) {
|
||||
"provider.selected": (_raw, value) => {
|
||||
if (typeof value !== "string" || !/^(|claude|codex|claude,codex|codex,claude)$/.test(value)) {
|
||||
throw new Error("Invalid provider.selected: use claude, codex, claude,codex, or an empty string for no recorded choice");
|
||||
}
|
||||
}),
|
||||
"policies.claude_compaction.preparation_root": described({ format: "absolute-path-or-empty" }, (_raw, value) => {
|
||||
},
|
||||
"policies.claude_compaction.preparation_root": (_raw, value) => {
|
||||
if (typeof value !== "string" || (value !== "" && (!path.isAbsolute(value) || value.includes("\0")))) {
|
||||
throw new Error("Invalid policies.claude_compaction.preparation_root: use an absolute path or an empty string for the default");
|
||||
}
|
||||
}),
|
||||
},
|
||||
"policies.claude_compaction.threshold_percent": (raw, coerced) => {
|
||||
const trimmed = (raw ?? "").trim();
|
||||
if (!/^-?\d+$/.test(trimmed)) {
|
||||
@@ -1048,12 +1049,12 @@ const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
}
|
||||
},
|
||||
// Empty (the default) keeps no erasure ledger; otherwise an absolute file path, kept outside the backed-up data.
|
||||
"retention.erasure_ledger": described({ format: "absolute-path-or-empty" }, (raw) => {
|
||||
"retention.erasure_ledger": (raw) => {
|
||||
const value = (raw ?? "").trim();
|
||||
if (value !== "" && !value.startsWith("/")) {
|
||||
throw new Error(`Invalid value for retention.erasure_ledger: must be empty or an absolute file path, got "${raw}"`);
|
||||
}
|
||||
}),
|
||||
},
|
||||
"retention.watchdog_keep_per_job": (raw, coerced) => {
|
||||
if (!/^-?\d+$/.test((raw ?? "").trim()) || typeof coerced !== "number" || !Number.isInteger(coerced) || coerced < 0) {
|
||||
throw new Error(`Invalid value for retention.watchdog_keep_per_job: must be an integer >= 0, got "${raw}"`);
|
||||
@@ -1069,12 +1070,12 @@ const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
throw new Error(`Invalid value for retention.stream_max_items: must be an integer >= 1, got "${raw}"`);
|
||||
}
|
||||
},
|
||||
"stream.intake": described({ format: "queue.worker, off, or member@rig" }, (raw) => {
|
||||
"stream.intake": (raw) => {
|
||||
const val = (raw ?? "").trim();
|
||||
if (val !== "off" && val !== "queue.worker" && !/^[a-zA-Z0-9\-_.]+@[a-zA-Z0-9\-_.]+$/.test(val)) {
|
||||
throw new Error(`Invalid value for stream.intake: must be "queue.worker", a canonical session (<seat>@<rig>), or "off", got "${raw}"`);
|
||||
}
|
||||
}),
|
||||
},
|
||||
"retention.batch_size": (raw, coerced) => {
|
||||
if (!/^-?\d+$/.test((raw ?? "").trim()) || typeof coerced !== "number" || !Number.isInteger(coerced) || coerced < 1) {
|
||||
throw new Error(`Invalid value for retention.batch_size: must be an integer >= 1, got "${raw}"`);
|
||||
@@ -1088,19 +1089,18 @@ const KEY_CONSTRAINTS: Partial<Record<SettingsValidKey, KeyConstraint>> = {
|
||||
"queue.wake_retry_cap": positiveIntegerConstraint("queue.wake_retry_cap"),
|
||||
"queue.wake_unconfirmed_window_minutes": positiveIntegerConstraint("queue.wake_unconfirmed_window_minutes"),
|
||||
"queue.wake_swap_grace_seconds": positiveIntegerConstraint("queue.wake_swap_grace_seconds"),
|
||||
"queue.wake_human_rung": choiceConstraint(["always", "explicit-only"],
|
||||
(raw) => `Invalid value for queue.wake_human_rung: must be "always" or "explicit-only", got "${raw}"`),
|
||||
"decisions.template_dir": described({ format: "absolute-path-or-empty" }, (_raw, value) => {
|
||||
"queue.wake_human_rung": wakeHumanRungConstraint,
|
||||
"decisions.template_dir": (_raw, value) => {
|
||||
if (typeof value !== "string" || (value !== "" && (!path.isAbsolute(value) || value.includes("\0")))) {
|
||||
throw new Error("Invalid decisions.template_dir: use an absolute path, or an empty string for the shipped templates only");
|
||||
}
|
||||
}),
|
||||
},
|
||||
// rig acp serve's receiver when --to isn't given: a team seat, member@rig, or empty for none.
|
||||
"acp.to": described({ format: "member@rig-or-empty" }, (_raw, value) => {
|
||||
"acp.to": (_raw, value) => {
|
||||
if (typeof value !== "string" || (value !== "" && !/^[^@\s]+@[^@\s]+$/.test(value))) {
|
||||
throw new Error("Invalid acp.to: use the seat that receives your ACP tasks as member@rig, or an empty string for none");
|
||||
}
|
||||
}),
|
||||
},
|
||||
};
|
||||
|
||||
function validateKeyConstraints(key: SettingsValidKey, raw: string, coerced: string | number | boolean): void {
|
||||
@@ -1126,58 +1126,6 @@ function validateTypedFileValue(key: SettingsValidKey, value: string | number |
|
||||
check(raw, value);
|
||||
}
|
||||
|
||||
/** What the browser view reports about a key's values, read from the rules that govern it. */
|
||||
export interface SettingKeyDescription {
|
||||
/** Whether POST and DELETE /api/config/:key accept this key. */
|
||||
writeRoute: boolean;
|
||||
type?: "boolean" | "integer" | "string" | "enum";
|
||||
choices?: string[];
|
||||
range?: { min?: number; max?: number };
|
||||
format?: string;
|
||||
}
|
||||
|
||||
const ACCEPTED_INTEGER_LIMIT = Number.MAX_SAFE_INTEGER;
|
||||
|
||||
/** The interval of whole numbers a key's validator accepts, found by asking the validator itself; a side it does not bound is left out. */
|
||||
function acceptedIntegerRange(key: SettingsValidKey, start: number): { min?: number; max?: number } | undefined {
|
||||
const check = KEY_CONSTRAINTS[key];
|
||||
if (!check) return undefined;
|
||||
const accepts = (n: number): boolean => {
|
||||
try { check(String(n), n); return true; } catch { return false; }
|
||||
};
|
||||
if (!accepts(start)) return undefined;
|
||||
const range: { min?: number; max?: number } = {};
|
||||
if (!accepts(ACCEPTED_INTEGER_LIMIT)) {
|
||||
let lo = start, hi = ACCEPTED_INTEGER_LIMIT;
|
||||
while (hi - lo > 1) { const mid = Math.floor(lo + (hi - lo) / 2); if (accepts(mid)) lo = mid; else hi = mid; }
|
||||
range.max = lo;
|
||||
}
|
||||
if (!accepts(-ACCEPTED_INTEGER_LIMIT)) {
|
||||
let lo = -ACCEPTED_INTEGER_LIMIT, hi = start;
|
||||
while (hi - lo > 1) { const mid = Math.floor(lo + (hi - lo) / 2); if (accepts(mid)) hi = mid; else lo = mid; }
|
||||
range.min = hi;
|
||||
}
|
||||
return range.min === undefined && range.max === undefined ? undefined : range;
|
||||
}
|
||||
|
||||
/** Derived from coerceValue (the type), KEY_CONSTRAINTS (choices, format, range) and the key grammar (write route); no second list. */
|
||||
export function describeSettingKey(key: string): SettingKeyDescription {
|
||||
if (parseFeedHostSubscriptionKey(key)) return { writeRoute: true, type: "boolean" };
|
||||
if (!isSettingsValidKey(key)) return { writeRoute: false };
|
||||
const fallback = getDefaultValue(key, "");
|
||||
const meta = KEY_CONSTRAINTS[key]?.meta;
|
||||
const out: SettingKeyDescription = { writeRoute: true };
|
||||
if (typeof fallback === "boolean") out.type = "boolean";
|
||||
else if (typeof fallback === "number") {
|
||||
out.type = "integer";
|
||||
const range = acceptedIntegerRange(key, fallback);
|
||||
if (range) out.range = range;
|
||||
} else out.type = meta?.choices ? "enum" : "string";
|
||||
if (meta?.choices) out.choices = [...meta.choices];
|
||||
if (meta?.format) out.format = meta.format;
|
||||
return out;
|
||||
}
|
||||
|
||||
/**
|
||||
* Slice 27 — projected Claude auto-compaction policy. ContextMonitor
|
||||
* consumes this snapshot per-poll; the PreCompact hook reads the same
|
||||
|
||||
@@ -361,22 +361,6 @@ export class WorkflowValidator {
|
||||
});
|
||||
}
|
||||
|
||||
// #3087: validate never resolves seats, so a harness pin is only
|
||||
// reconciled when a run resolves the step's owner. Say so, so a
|
||||
// clean result is not read as "every pin is satisfiable".
|
||||
spec.steps.forEach((step, idx) => {
|
||||
if (!step.harness) return;
|
||||
const binding = spec.target?.rig
|
||||
? `rig "${spec.target.rig}"`
|
||||
: "no rig is bound";
|
||||
issues.push({
|
||||
code: "harness_pin_unchecked",
|
||||
message: `step "${step.id}" pins harness "${step.harness}", but validate does not check harness pins against any seats (${binding}). The pin is checked when a run resolves the step's owner, and the run fails with harness_pin_unsatisfied if no preferred_target of role "${step.actor_role}" runs ${step.harness}.`,
|
||||
field: `workflow.steps[${idx}].harness`,
|
||||
severity: "warning",
|
||||
});
|
||||
});
|
||||
|
||||
// OPR.0.4.6.WF2 FR-5: gate target semantics — a HUMAN-seat target
|
||||
// requires summary + evidence_ref (the shipped human-route write
|
||||
// path enforces them at create; failing HERE is the fail-at-author-
|
||||
|
||||
@@ -6,7 +6,6 @@ import nodePath from "node:path";
|
||||
import { describe, it, expect, vi, afterEach } from "vitest";
|
||||
import { ClaudeCodeAdapter, type ClaudeAdapterFsOps } from "../src/adapters/claude-code-adapter.js";
|
||||
import type { NodeBinding, ResolvedStartupFile } from "../src/domain/runtime-adapter.js";
|
||||
import { isAttentionRequiredReadinessCode } from "../src/domain/runtime-adapter.js";
|
||||
import type { ProjectionPlan, ProjectionEntry } from "../src/domain/projection-planner.js";
|
||||
import type { TmuxAdapter } from "../src/adapters/tmux.js";
|
||||
import { claudePostureFlag } from "../src/adapters/yolo-mode.js";
|
||||
@@ -1102,7 +1101,7 @@ describe("Claude Code runtime adapter", () => {
|
||||
});
|
||||
|
||||
describe("with provider-prompt auto-driving on, a trust prompt in the longer wait", () => {
|
||||
const trust = "Accessing workspace:\n/fixture\n❯ 1. Yes, I trust this folder\n 2. No, exit";
|
||||
const trust = "Accessing workspace:\n/fixture\n1. Yes, I trust this folder\n2. No, exit";
|
||||
|
||||
it.each([["a Codex", codex], ["another conversation's Claude", otherClaude]])(
|
||||
"from %s that took the pane is not answered: main's result, no Enter", async (_label, arrival) => {
|
||||
@@ -1124,16 +1123,6 @@ describe("Claude Code runtime adapter", () => {
|
||||
expect((tmux.sendKeys as ReturnType<typeof vi.fn>).mock.calls.length).toBeGreaterThan(1);
|
||||
});
|
||||
|
||||
it("with no key to send (a prompt drawn without a cursor) ends the longer wait as it does without the auto-drive", async () => {
|
||||
const cursorless = "Accessing workspace:\n/fixture\n1. Yes, I trust this folder\n2. No, exit";
|
||||
const screen = (read: number) => (read < 20 ? "" : cursorless);
|
||||
const driven = await run({ autoDrive: true, screen });
|
||||
const plain = await run({ screen });
|
||||
expect(driven.result).toEqual(plain.result);
|
||||
expect(driven.reads).toBe(plain.reads);
|
||||
expect(driven.tmux.sendKeys).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("in the quick window is answered as before, whoever holds the pane", async () => {
|
||||
const { tmux } = await run({ autoDrive: true, rows: () => [...booting, codex], screen: (read) => (read < 3 ? trust : "") });
|
||||
expect((tmux.sendKeys as ReturnType<typeof vi.fn>).mock.calls.length).toBeGreaterThan(1);
|
||||
@@ -1470,127 +1459,3 @@ describe("Claude Code runtime adapter", () => {
|
||||
// grep confirms provisionActivityHooks/upsertCommandHook/etc. removed
|
||||
// from adapter source.
|
||||
});
|
||||
|
||||
// #2820 item 2: with recovery.auto_drive_provider_prompts on, the plain workspace trust prompt is answered with Enter,
|
||||
// but Claude Code's "gated grants" backstop never is: its default choice declines the folder's pre-approved tool
|
||||
// permissions (or exits), and approving them is the person's call. The launch stops as attention_required, with the
|
||||
// screen as evidence, and no key goes to the pane after the launch command.
|
||||
describe("Claude gated grants backstop is never auto-driven (#2820 item 2)", () => {
|
||||
const capture = JSON.parse(fs.readFileSync(new URL("./fixtures/claude-trust-git-root/trust-checks.json", import.meta.url), "utf8")) as { gatedGrantsScreen: string[] };
|
||||
const backstop = capture.gatedGrantsScreen.join("\n");
|
||||
|
||||
async function launch(screens: string[], cwd = "/project") {
|
||||
const tmux = mockTmux();
|
||||
(tmux.getPaneCommand as ReturnType<typeof vi.fn>).mockResolvedValue("claude");
|
||||
const capturePane = tmux.capturePaneContent as ReturnType<typeof vi.fn>;
|
||||
for (const screen of screens.slice(0, -1)) capturePane.mockResolvedValueOnce(screen);
|
||||
capturePane.mockResolvedValue(screens.at(-1));
|
||||
const adapter = new ClaudeCodeAdapter({ tmux, fsOps: mockFs(), sleep: async () => {}, autoDriveProviderPrompts: true });
|
||||
const result = await adapter.launchHarness(makeBinding(cwd), { name: "dev-impl@test-rig", resumeToken: "abc-123" });
|
||||
return { tmux, result };
|
||||
}
|
||||
|
||||
it("stops as attention_required and sends nothing after the launch command", async () => {
|
||||
const { tmux, result } = await launch([backstop]);
|
||||
expect(result).toMatchObject({ ok: false, recovery: "attention_required" });
|
||||
// The launch command is the only call (it ends with its own Enter); the plain trust prompt takes a 2nd one.
|
||||
expect(tmux.sendKeys).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("sends nothing when the seat's git root is the home folder", async () => {
|
||||
const { tmux, result } = await launch([backstop.replace("<lab>/repo/cadeiras/rig/seat", "/home/agent")], "/home/agent");
|
||||
expect(result).toMatchObject({ ok: false, recovery: "attention_required" });
|
||||
expect(tmux.sendKeys).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it("sends nothing while the backstop is still being drawn, nor once it is complete", async () => {
|
||||
const partial = capture.gatedGrantsScreen.slice(0, -3).join("\n");
|
||||
const { tmux, result } = await launch([partial, partial, backstop]);
|
||||
expect(result).toMatchObject({ ok: false, recovery: "attention_required" });
|
||||
expect(tmux.sendKeys).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
// Claude Code 2.1.322's plain trust prompt (no pre-approved permissions) opens with the focus on "No, exit": an
|
||||
// Enter there quits Claude. The auto-drive moves the selection down once and presses Enter only once the focused row
|
||||
// reads "Yes, I trust this folder".
|
||||
const plainCapture = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/plain-trust-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# ")).join("\n");
|
||||
const plainNo = plainCapture;
|
||||
const plainYes = plainCapture.replace("❯ No, exit", " No, exit").replace(" Yes, I trust this folder", "❯ Yes, I trust this folder");
|
||||
const ready = ["Claude Code v2.1.322", "❯ Ready"].join("\n");
|
||||
const keys = (tmux: TmuxAdapter) => (tmux.sendKeys as ReturnType<typeof vi.fn>).mock.calls.map(call => (call[1] as string[]).join(" "));
|
||||
|
||||
it("moves the plain trust prompt's focus from 'No, exit' to 'Yes' before pressing Enter (2.1.322)", async () => {
|
||||
const { tmux, result } = await launch([plainNo, plainYes, ready]);
|
||||
expect(result).toMatchObject({ ok: true });
|
||||
expect(keys(tmux)).toEqual(["Enter", "Down", "Enter"]);
|
||||
});
|
||||
|
||||
it("never presses Enter on 'No, exit', and moves it only once: a 2nd Down would wrap back to 'No, exit'", async () => {
|
||||
const { tmux, result } = await launch([plainNo]);
|
||||
expect(result).toMatchObject({ ok: false });
|
||||
expect(keys(tmux)).toEqual(["Enter", "Down"]);
|
||||
});
|
||||
|
||||
// A Claude-like select: Down moves the focus and wraps after the last option, and each key is drawn only some reads
|
||||
// later (stale frames). Enter on "No, exit" quits Claude; Enter on "Yes" goes on to the session.
|
||||
it("with stale frames and a wrapping select, sends one Down and presses Enter on 'Yes' only", async () => {
|
||||
const tmux = mockTmux();
|
||||
let calls = 0, focusYes = false, entered: "yes" | "no" | null = null, staleReads = 0, last = "";
|
||||
(tmux.capturePaneContent as ReturnType<typeof vi.fn>).mockImplementation(async () => {
|
||||
if (staleReads > 0 && last) { staleReads -= 1; return last; }
|
||||
last = entered === "yes" ? ready : entered === "no" ? "" : focusYes ? plainYes : plainNo;
|
||||
return last;
|
||||
});
|
||||
(tmux.getPaneCommand as ReturnType<typeof vi.fn>).mockImplementation(async () => (entered === "no" ? "zsh" : "claude"));
|
||||
(tmux.sendKeys as ReturnType<typeof vi.fn>).mockImplementation(async (_session: string, keysSent: string[]) => {
|
||||
calls += 1;
|
||||
if (calls === 1) return { ok: true as const }; // the launch command's own Enter
|
||||
if (keysSent.join(" ") === "Down") { focusYes = !focusYes; staleReads = 3; }
|
||||
if (keysSent.join(" ") === "Enter" && entered === null) { entered = focusYes ? "yes" : "no"; staleReads = 2; }
|
||||
return { ok: true as const };
|
||||
});
|
||||
const adapter = new ClaudeCodeAdapter({ tmux, fsOps: mockFs(), sleep: async () => {}, autoDriveProviderPrompts: true });
|
||||
const result = await adapter.launchHarness(makeBinding("/project"), { name: "dev-impl@test-rig", resumeToken: "abc-123" });
|
||||
expect(entered).toBe("yes");
|
||||
expect(keys(tmux).slice(1)).toEqual(["Down", "Enter"]);
|
||||
expect(result).toMatchObject({ ok: true });
|
||||
});
|
||||
|
||||
it("drives a plain prompt drawn below an earlier session that quoted the backstop's words", async () => {
|
||||
const earlier = ["⏺ The folder's backstop reads \"This folder pre-approves 2 tool permissions\" and focuses",
|
||||
" \"No, continue without these permissions\".", "", "────────────────", "❯ ", "────────────────", ""].join("\n");
|
||||
const { tmux, result } = await launch([earlier + plainNo, earlier + plainYes, ready]);
|
||||
expect(result).toMatchObject({ ok: true });
|
||||
expect(keys(tmux)).toEqual(["Enter", "Down", "Enter"]);
|
||||
});
|
||||
|
||||
it("sends nothing to the 40-column backstop whose warning a long permission list scrolled out", async () => {
|
||||
const rows = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/backstop-40col-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# "));
|
||||
const from = rows.findIndex(row => row.includes("⚠ This folder pre-approves"));
|
||||
const to = rows.findIndex(row => row.includes("configuration."));
|
||||
const { tmux, result } = await launch([[...rows.slice(0, from), ...rows.slice(to + 1)].join("\n")]);
|
||||
expect(result).toMatchObject({ ok: false, recovery: "attention_required" });
|
||||
expect(keys(tmux)).toEqual(["Enter"]);
|
||||
});
|
||||
|
||||
it("sends nothing to a trust prompt drawn without a cursor: the label cannot be checked", async () => {
|
||||
const cursorless = plainCapture.replace("❯ No, exit", " No, exit");
|
||||
const { tmux, result } = await launch([cursorless]);
|
||||
expect(result).toMatchObject({ ok: false });
|
||||
expect(keys(tmux)).toEqual(["Enter"]);
|
||||
});
|
||||
|
||||
it("sends nothing to the backstop in a 40-column pane, whose rows wrap and cut its marks (real capture)", async () => {
|
||||
const narrow = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/backstop-40col-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# ")).join("\n");
|
||||
const { tmux, result } = await launch([narrow]);
|
||||
expect(result).toMatchObject({ ok: false, recovery: "attention_required" });
|
||||
expect(keys(tmux)).toEqual(["Enter"]);
|
||||
});
|
||||
|
||||
it("is a readiness code that stops startup waiting for attention", () => {
|
||||
expect(isAttentionRequiredReadinessCode("claude_gated_grants_gate")).toBe(true);
|
||||
});
|
||||
});
|
||||
-32
@@ -1,32 +0,0 @@
|
||||
# Claude Code 2.1.322, the gated-grants backstop in a 40-column tmux pane (T-005154 lab: fake HOME, no credential,
|
||||
# no key sent): the warning and the decline option wrap across rows. Captured 2026-11-12 with tmux capture-pane -p.
|
||||
|
||||
────────────────────────────────────────
|
||||
Accessing workspace:
|
||||
|
||||
<lab>/backstop/rep
|
||||
o/cadeiras/rig/seat
|
||||
|
||||
Quick safety check: Is this a project
|
||||
you created or one you trust? (Like
|
||||
your own code, a well-known open
|
||||
source project, or work from your
|
||||
team). If not, take a moment to review
|
||||
what's in this folder first.
|
||||
|
||||
Claude Code'll be able to read, edit,
|
||||
and execute files here.
|
||||
|
||||
⚠ This folder pre-approves 2 tool
|
||||
permissions in .claude/settings.json:
|
||||
Bash(ls:*) and Bash(git status:*)
|
||||
These will apply without asking. Only
|
||||
proceed if you trust this
|
||||
configuration.
|
||||
|
||||
Security guide
|
||||
|
||||
❯ No, continue without these
|
||||
Yes, I trust this folder
|
||||
|
||||
Enter to confirm · Esc to cancel
|
||||
@@ -1,47 +0,0 @@
|
||||
# Real capture (12/11/2026): Claude Code 2.1.322, fresh HOME after OpenRig's pre-launch seed with no trust, a seat
|
||||
# without .claude/settings.json; tmux 150x45. The plain workspace trust prompt opens with the focus on 'No, exit'.
|
||||
|
||||
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
|
||||
Accessing workspace:
|
||||
|
||||
<lab>/simples/repo/cadeiras/rig/seat
|
||||
|
||||
Quick safety check: Is this a project you created or one you trust? (Like your own code, a well-known open source project, or work from your team).
|
||||
If not, take a moment to review what's in this folder first.
|
||||
|
||||
Claude Code'll be able to read, edit, and execute files here.
|
||||
|
||||
Security guide
|
||||
|
||||
❯ No, exit
|
||||
Yes, I trust this folder
|
||||
|
||||
Enter to confirm · Esc to cancel
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
@@ -188,7 +188,6 @@ export const migrationsForFullTestDb = [coreSchema, bindingsSessionsSchema, even
|
||||
* its exclusion); the guard's redundant-exclusion check then keeps the two in sync.
|
||||
*/
|
||||
export const migrationsForFullTestDbExclusions: Record<string, string> = {
|
||||
"166_queue_list_read_indexes.sql": "read indexes depend on owner-notification columns/archive omitted here (054/076); startup and queue-list-order-indexes.test.ts exercise ALL_MIGRATIONS.",
|
||||
"156_queue_erasure_link_indexes.sql": "indexes outbox_entries, inbox_entries and the stream tables (all excluded from the core edge) for queue erasure's lookups; erasure tests migrate the canonical full schema.",
|
||||
"082_archive_identity_provenance.sql": "archive extension; 054 is excluded from this core fixture. Archive identity regressions use ALL_MIGRATIONS.",
|
||||
"026_inbox_entries.sql": "inbox subsystem table — not on the shared core edge (inbox suites migrate it inline).",
|
||||
|
||||
@@ -4,7 +4,6 @@ import {
|
||||
assessNativeResumeProbe,
|
||||
buildNativeResumeCommand,
|
||||
buildCodexResumeCore,
|
||||
claudeTrustPromptFocus,
|
||||
isProbeShellReady,
|
||||
} from "../src/domain/native-resume-probe.js";
|
||||
|
||||
@@ -1419,185 +1418,3 @@ describe("Claude's Resume session picker", () => {
|
||||
.toMatchObject({ status: "resumed", code: "active_runtime" });
|
||||
});
|
||||
});
|
||||
|
||||
// #2820 item 2: Claude Code's "gated grants" backstop (2.1.319+). It looks like the workspace trust prompt
|
||||
// ("Accessing workspace:", "Yes, I trust this folder"), but it also asks to approve the tool permissions the folder's
|
||||
// .claude/settings.json pre-approves, and its default choice declines them ("No, continue without these permissions")
|
||||
// or exits ("No, exit"). OpenRig must never answer it, not even with recovery.auto_drive_provider_prompts.
|
||||
describe("Claude gated grants backstop (#2820 item 2)", () => {
|
||||
// A real capture: Claude Code 2.1.319 in a lab git repo (see claude-trust-git-root.test.ts).
|
||||
const capture = JSON.parse(fs.readFileSync(new URL("./fixtures/claude-trust-git-root/trust-checks.json", import.meta.url), "utf8")) as { gatedGrantsScreen: string[] };
|
||||
const screen = capture.gatedGrantsScreen.join("\n");
|
||||
const probe = (paneContent: string) => assessNativeResumeProbe({ runtime: "claude-code", paneCommand: "claude", paneContent });
|
||||
const gate = { status: "attention_required", code: "claude_gated_grants_gate" };
|
||||
|
||||
it("the captured screen, focus on 'No, continue without these permissions', is its own gate, never trust_gate", () => {
|
||||
expect(probe(screen)).toMatchObject(gate);
|
||||
expect(probe(screen).detail).toContain("OpenRig does not approve or bypass this review. No input was sent.");
|
||||
});
|
||||
|
||||
it("is the same gate with the focus moved to 'Yes, I trust this folder'", () => {
|
||||
const yes = screen.replace("❯ No, continue without these permissions", " No, continue without these permissions")
|
||||
.replace(" Yes, I trust this folder", "❯ Yes, I trust this folder");
|
||||
expect(probe(yes)).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("is the same gate in the variant with nothing trusted yet, whose default choice is 'No, exit'", () => {
|
||||
expect(probe(screen.replace("❯ No, continue without these permissions", "❯ No, exit"))).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("is the same gate when the git root is the home folder (the case item 1 deliberately does not seed)", () => {
|
||||
expect(probe(screen.replace("<lab>/repo/cadeiras/rig/seat", "/home/agent"))).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("is the same gate drawn with blank rows between its parts and a long permission list", () => {
|
||||
const rows = capture.gatedGrantsScreen.flatMap(row => [row, ""]);
|
||||
rows.splice(rows.findIndex(row => row.includes("Bash(ls:*)")) + 1, 0, ...Array.from({ length: 30 }, (_, n) => ` Bash(tool-${n}:*)`));
|
||||
expect(probe(rows.join("\n"))).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("a backstop still being drawn is not a trust prompt to drive: it waits for the next read", () => {
|
||||
const partial = capture.gatedGrantsScreen.slice(0, capture.gatedGrantsScreen.findIndex(row => row.includes("Security guide")));
|
||||
expect(probe(partial.join("\n"))).toMatchObject({ status: "inconclusive", code: "awaiting_runtime" });
|
||||
const noFooter = capture.gatedGrantsScreen.slice(0, -1).join("\n");
|
||||
expect(probe(noFooter)).toMatchObject({ status: "inconclusive", code: "awaiting_runtime" });
|
||||
});
|
||||
|
||||
it("a backstop left in the scrollback above a session that started is neither this gate nor trust_gate", () => {
|
||||
const later = [screen, "", " ▐▛███▜▌ Claude Code v2.1.319", "", "────────────────", "❯ ", "────────────────"].join("\n");
|
||||
expect(probe(later).code).not.toBe("claude_gated_grants_gate");
|
||||
expect(probe(later).code).not.toBe("trust_gate");
|
||||
});
|
||||
|
||||
it("is the same gate in a 40-column pane, whose rows wrap and cut its marks (real capture), never trust_gate", () => {
|
||||
const narrow = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/backstop-40col-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# ")).join("\n");
|
||||
expect(narrow).not.toMatch(/No, continue without these permissions/);
|
||||
expect(probe(narrow)).toMatchObject(gate);
|
||||
expect(claudeTrustPromptFocus(narrow)).toBe("unknown");
|
||||
});
|
||||
|
||||
it("a 40-column backstop captured before its wrapped warning is complete waits, never resumed", () => {
|
||||
const rows = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/backstop-40col-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# "));
|
||||
const partial = rows.slice(0, rows.findIndex(row => row.includes("⚠ This folder pre-approves")) + 1).join("\n");
|
||||
expect(partial).not.toMatch(/tool permissions/);
|
||||
expect(probe(partial)).toMatchObject({ status: "inconclusive", code: "awaiting_runtime" });
|
||||
});
|
||||
|
||||
it("is the same gate in 40 columns when a long permission list scrolled the whole warning out", () => {
|
||||
const rows = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/backstop-40col-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# "));
|
||||
const from = rows.findIndex(row => row.includes("⚠ This folder pre-approves"));
|
||||
const to = rows.findIndex(row => row.includes("configuration."));
|
||||
const scrolled = [...rows.slice(0, from), ...rows.slice(to + 1)].join("\n");
|
||||
expect(scrolled).not.toMatch(/pre-approves/);
|
||||
expect(probe(scrolled)).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("is the same gate drawn with numbered options", () => {
|
||||
const numbered = screen.replace("❯ No, continue without these permissions", "❯ 1. No, continue without these permissions")
|
||||
.replace(" Yes, I trust this folder", " 2. Yes, I trust this folder");
|
||||
expect(probe(numbered)).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("a reply quoting the backstop's words above a fresh plain prompt does not hide that prompt", () => {
|
||||
const plain = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/plain-trust-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# ")).join("\n");
|
||||
const earlier = ["⏺ It reads \"This folder pre-approves 2 tool permissions\" and \"No, continue without these permissions\".",
|
||||
"", "────────────────", "❯ ", "────────────────", ""].join("\n");
|
||||
expect(probe(earlier + plain)).toMatchObject({ status: "inconclusive", code: "trust_gate" });
|
||||
});
|
||||
|
||||
it("a draft in Claude's input box that reads like the backstop's option is never the gate", () => {
|
||||
const started = [" ▐▛███▜▌ Claude Code v2.1.322", "", "⏺ Done.", "", "────────────────────────────────",
|
||||
"❯ No, continue without the tests", "────────────────────────────────", " ⏵⏵ auto mode on (shift+tab to cycle)"].join("\n");
|
||||
expect(probe(started)).toMatchObject({ status: "resumed" });
|
||||
});
|
||||
|
||||
it("nor is that draft while the input frame's closing rule is not captured yet", () => {
|
||||
const drawing = [" ▐▛███▜▌ Claude Code v2.1.322", "", "⏺ Done.", "", "────────────────────────────────",
|
||||
"❯ No, continue without the tests"].join("\n");
|
||||
expect(probe(drawing)).toMatchObject({ status: "resumed" });
|
||||
});
|
||||
|
||||
// A draft's text never moves the cut: Claude draws its frame's rules from column 0 and a draft's continuation rows
|
||||
// indented under the ❯, so a rule, a reply or a header pasted into a draft is the draft's, not Claude's.
|
||||
const header = " ▐▛███▜▌ Claude Code v2.1.322";
|
||||
const rule = "────────────────────────────────";
|
||||
it.each([
|
||||
["a pasted rule", " ────────"],
|
||||
["a pasted reply", "⏺ Earlier output"],
|
||||
["a pasted header", " Claude Code v2.1.322"],
|
||||
])("a multi-line draft with %s above the backstop's words is never the gate", (_case, pasted) => {
|
||||
const draft = ["❯ Review this example:", pasted, " No, continue without the tests"];
|
||||
const closed = [header, "", "⏺ Done.", "", rule, ...draft, rule, " ⏵⏵ auto mode on (shift+tab to cycle)"].join("\n");
|
||||
expect(probe(closed)).toMatchObject({ status: "resumed" });
|
||||
const drawing = [header, "", "⏺ Done.", "", rule, ...draft].join("\n");
|
||||
expect(probe(drawing)).toMatchObject({ status: "resumed" });
|
||||
});
|
||||
|
||||
it("a draft that mentions a Claude Code version reads resumed, closed or still open (maintainer's case)", () => {
|
||||
const draft = ["Claude Code v2.1.322", rule, "❯ Explain this Claude Code v2.1.322 message:", " No, continue without the tests"];
|
||||
expect(probe([...draft, rule, " ⏵⏵ accept edits on (shift+tab to cycle)"].join("\n"))).toMatchObject({ status: "resumed" });
|
||||
expect(probe(draft.join("\n"))).toMatchObject({ status: "resumed" });
|
||||
});
|
||||
|
||||
it("a draft that starts with a pasted header is never the gate either", () => {
|
||||
const started = [header, "", "⏺ Done.", "", rule, "❯ Claude Code v2.1.322 asks:", " No, continue without the tests", rule].join("\n");
|
||||
expect(probe(started)).toMatchObject({ status: "resumed" });
|
||||
});
|
||||
|
||||
it("is the same gate below an old reply that quotes an input frame, with no input frame after it", () => {
|
||||
// a quoted frame is indented like the reply: it is no frame of Claude's, so it never blanks the rows below it
|
||||
const quoted = [header, "", "⏺ The screen looked like:", " ────────", " ❯ hi", " ────────", "", "$ claude --resume x", ""].join("\n");
|
||||
expect(probe(`${quoted}\n${capture.gatedGrantsScreen.join("\n")}`)).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("is the same gate below an old session whose input frame holds a draft (N1)", () => {
|
||||
const earlier = [header, "", "⏺ Done.", "", rule, "❯ Review this example:", " ────────", " more text", rule, ""].join("\n");
|
||||
expect(probe(`${earlier}\n${screen}`)).toMatchObject(gate);
|
||||
});
|
||||
|
||||
it("names the focused choice in the gate's detail", () => {
|
||||
expect(probe(screen).detail).toContain("\"No, continue without these permissions\"");
|
||||
const yes = screen.replace("❯ No, continue without these permissions", " No, continue without these permissions")
|
||||
.replace(" Yes, I trust this folder", "❯ Yes, I trust this folder");
|
||||
expect(probe(yes).detail).toContain("\"Yes, I trust this folder\"");
|
||||
});
|
||||
|
||||
it("the plain workspace trust prompt is still trust_gate (it stays auto-drivable)", () => {
|
||||
const plain = ["Accessing workspace:", "/some/workspace", "", "Quick safety check: Is this a project you created or one you trust?",
|
||||
"❯ 1. Yes, I trust this folder", " 2. No, exit"].join("\n");
|
||||
expect(probe(plain)).toMatchObject({ status: "inconclusive", code: "trust_gate" });
|
||||
});
|
||||
});
|
||||
|
||||
// #2820 item 2: the auto-drive presses a key on the trust prompt only for an allowlisted screen.
|
||||
describe("claudeTrustPromptFocus (#2820 item 2)", () => {
|
||||
const plain = fs.readFileSync(new URL("./fixtures/claude-trust-git-root/plain-trust-2.1.322.txt", import.meta.url), "utf8")
|
||||
.split("\n").filter(row => !row.startsWith("# ")).join("\n");
|
||||
const backstop = (JSON.parse(fs.readFileSync(new URL("./fixtures/claude-trust-git-root/trust-checks.json", import.meta.url), "utf8")) as { gatedGrantsScreen: string[] }).gatedGrantsScreen.join("\n");
|
||||
|
||||
it("reads 'no' on the real 2.1.322 prompt, focused on 'No, exit'", () => {
|
||||
expect(claudeTrustPromptFocus(plain)).toBe("no");
|
||||
});
|
||||
it("reads 'yes' once the focus is on 'Yes, I trust this folder'", () => {
|
||||
expect(claudeTrustPromptFocus(plain.replace("❯ No, exit", " No, exit").replace(" Yes, I trust this folder", "❯ Yes, I trust this folder"))).toBe("yes");
|
||||
});
|
||||
it("reads numbered prompts and the › cursor", () => {
|
||||
expect(claudeTrustPromptFocus("Accessing workspace:\n/w\n❯ 1. Yes, I trust this folder\n 2. No, exit")).toBe("yes");
|
||||
expect(claudeTrustPromptFocus("Accessing workspace:\n/w\n 1. Yes, I trust this folder\n› 2. No, exit")).toBe("no");
|
||||
});
|
||||
it("is 'unknown' without a cursor: the label cannot be checked", () => {
|
||||
expect(claudeTrustPromptFocus("Accessing workspace:\n/w\n1. Yes, I trust this folder\n2. No, exit")).toBe("unknown");
|
||||
});
|
||||
it("is 'unknown' on the backstop's options, even with the focus moved to 'Yes'", () => {
|
||||
expect(claudeTrustPromptFocus(backstop)).toBe("unknown");
|
||||
expect(claudeTrustPromptFocus(backstop.replace("❯ No, continue without these permissions", " No, continue without these permissions")
|
||||
.replace(" Yes, I trust this folder", "❯ Yes, I trust this folder"))).toBe("unknown");
|
||||
});
|
||||
it("is 'unknown' on any other option set", () => {
|
||||
expect(claudeTrustPromptFocus(plain.replace(" Yes, I trust this folder", " Yes, I trust this folder\n No, ask me later"))).toBe("unknown");
|
||||
});
|
||||
});
|
||||
@@ -39,13 +39,11 @@ beforeEach(() => {
|
||||
});
|
||||
afterEach(() => db.close());
|
||||
|
||||
/** A row whose every content field and linked copy carries `secret-<id>`, with its history at chosen ages. `openrig`:
|
||||
* OpenRig created it (a sweep finding, an escalation), so the create stages its wake from OpenRig's own session. */
|
||||
async function row(id: string, source: string, destination: string, history: Array<{ state: string; daysAgo: number }> = [],
|
||||
wakeTrigger?: "openrig") {
|
||||
/** A row whose every content field and linked copy carries `secret-<id>`, with its history at chosen ages. */
|
||||
async function row(id: string, source: string, destination: string, history: Array<{ state: string; daysAgo: number }> = []) {
|
||||
const secret = `secret-${id}`;
|
||||
await repo.create({ qitemId: id, sourceSession: source, destinationSession: destination, body: `${secret} body`, summary: `${secret} summary`,
|
||||
tags: [`${secret}-tag`], wakeTrigger });
|
||||
tags: [`${secret}-tag`] });
|
||||
db.prepare("UPDATE queue_transitions SET ts = ?, transition_note = ? WHERE qitem_id = ?").run(ago(400), `${secret} created`, id);
|
||||
for (const step of history) {
|
||||
const { transitionId } = log.append({ qitemId: id, state: step.state, actorSession: destination, transitionNote: `${secret} note` });
|
||||
@@ -684,110 +682,3 @@ describe("round 3 controls", () => {
|
||||
expect(everything()).toContain("secret-l2-new body");
|
||||
});
|
||||
});
|
||||
|
||||
describe("OpenRig's own wakes and notices", () => {
|
||||
const DAEMON = "daemon@kernel";
|
||||
const HEALTH = "system:health";
|
||||
const members = { kind: "members" as const, members: [A, B] };
|
||||
const wakeOf = (id: string) => db.prepare("SELECT sender_session AS from_, destination_session AS to_ FROM outbox_entries WHERE outbox_id = ?")
|
||||
.get(`wake-intent-${id}`);
|
||||
const loose = (table: "outbox_entries" | "inbox_entries", id: string, from: string, to: string, body: string) => {
|
||||
if (table === "outbox_entries") {
|
||||
db.prepare(`INSERT INTO outbox_entries (outbox_id, sender_session, destination_session, body, ts_dispatched) VALUES (?, ?, ?, ?, ?)`)
|
||||
.run(id, from, to, body, NOW);
|
||||
} else {
|
||||
db.prepare(`INSERT INTO inbox_entries (inbox_id, sender_session, destination_session, body, ts_dropped) VALUES (?, ?, ?, ?, ?)`)
|
||||
.run(id, from, to, body, NOW);
|
||||
}
|
||||
};
|
||||
|
||||
it("an OpenRig-triggered finding to a member erases clean, with OpenRig's wake for it and its notices", async () => {
|
||||
await row("f-finding", A, A, [], "openrig");
|
||||
// The premise: the finding's wake is staged from OpenRig, not from the member named as its source.
|
||||
expect(wakeOf("f-finding")).toEqual({ from_: DAEMON, to_: A });
|
||||
await row("f-escalation", DAEMON, B, [], "openrig");
|
||||
await row("f-health", HEALTH, A, [{ state: "done", daysAgo: 2 }], "openrig");
|
||||
loose("outbox_entries", "o-notice", DAEMON, A, "secret-loose-notice");
|
||||
loose("inbox_entries", "i-notice", HEALTH, B, "secret-loose-inbox");
|
||||
const dry = await eraseQueue(db, { scope: members, apply: false, nowIso: NOW });
|
||||
const report = await eraseQueue(db, { scope: members, apply: true, nowIso: NOW });
|
||||
expect({ ...report, applied: false }).toEqual(dry);
|
||||
expect(report.qitems.map((q) => q.qitemId)).toEqual(["f-escalation", "f-finding", "f-health"]);
|
||||
expect(report.mixed).toEqual([]);
|
||||
expect(report.keptCopies).toEqual([]);
|
||||
expect(report.unlinked).toMatchObject({ outbox: 1, inbox: 1, mixedEntries: 0 });
|
||||
expect(report.clean).toBe(true);
|
||||
const all = everything();
|
||||
expect(all).not.toContain("secret-f-");
|
||||
expect(all).not.toContain("secret-loose-");
|
||||
});
|
||||
|
||||
it("an OpenRig wake to another account's seat is kept, and a row OpenRig woke with one member endpoint stays mixed", async () => {
|
||||
await row("f-own", A, B, [], "openrig");
|
||||
await row("x-finding", OUT, OUT, [], "openrig");
|
||||
await row("x-escalation", DAEMON, OUT, [], "openrig");
|
||||
await row("x-mixed", OUT, A, [], "openrig");
|
||||
loose("outbox_entries", "o-elsewhere", DAEMON, OUT, "secret-loose-elsewhere");
|
||||
const report = await eraseQueue(db, { scope: members, apply: true, nowIso: NOW });
|
||||
expect(report.qitems.map((q) => q.qitemId)).toEqual(["f-own"]);
|
||||
expect(report.mixed).toEqual([{ qitemId: "x-mixed", memberEndpoint: "destination" }]);
|
||||
expect(report.unlinked).toMatchObject({ outbox: 0, mixedEntries: 0 });
|
||||
expect(report.clean).toBe(false);
|
||||
const all = everything();
|
||||
for (const id of ["x-finding", "x-escalation", "x-mixed"]) {
|
||||
expect(exists(id)).toBe(true);
|
||||
expect(all).toContain(`secret-${id} body`);
|
||||
}
|
||||
expect(wakeOf("x-finding")).toEqual({ from_: DAEMON, to_: OUT });
|
||||
expect(wakeOf("x-mixed")).toEqual({ from_: DAEMON, to_: A });
|
||||
expect(all).toContain("secret-loose-elsewhere");
|
||||
expect(all).not.toContain("secret-f-own");
|
||||
});
|
||||
|
||||
it("OpenRig's entries with itself are untouched, and a session that only looks like OpenRig's is outside the account", async () => {
|
||||
await row("f-own", A, B, [], "openrig");
|
||||
loose("outbox_entries", "o-self", DAEMON, DAEMON, "secret-loose-self");
|
||||
loose("outbox_entries", "o-health", HEALTH, DAEMON, "secret-loose-health");
|
||||
loose("inbox_entries", "i-self", HEALTH, DAEMON, "secret-loose-inbox-self");
|
||||
// isOpenRigSender is exact: "System:" isn't OpenRig's prefix.
|
||||
loose("outbox_entries", "o-lookalike", "System:health", A, "secret-loose-lookalike");
|
||||
const report = await eraseQueue(db, { scope: members, apply: true, nowIso: NOW });
|
||||
expect(report.qitems.map((q) => q.qitemId)).toEqual(["f-own"]);
|
||||
expect(report.unlinked).toMatchObject({ outbox: 0, inbox: 0, mixedEntries: 1 });
|
||||
expect(report.clean).toBe(false);
|
||||
const all = everything();
|
||||
for (const body of ["secret-loose-self", "secret-loose-health", "secret-loose-inbox-self", "secret-loose-lookalike"]) expect(all).toContain(body);
|
||||
expect(all).not.toContain("secret-f-own");
|
||||
});
|
||||
|
||||
it("rerunning the same plan over what an earlier daemon left removes it: the erased row's OpenRig wake, and its OpenRig rows", async () => {
|
||||
await row("r-finding", A, A, [], "openrig");
|
||||
await row("r-escalation", DAEMON, B, [], "openrig");
|
||||
// What an earlier daemon's run leaves: it deleted r-finding but kept OpenRig's wake for it as mixed, and left
|
||||
// r-escalation untouched as a mixed row. Built here by deleting r-finding and restoring its wake as it was.
|
||||
const wake = db.prepare("SELECT * FROM outbox_entries WHERE outbox_id = 'wake-intent-r-finding'").get() as Record<string, unknown>;
|
||||
await eraseQueue(db, { scope: { kind: "ids", entries: [{ qitemId: "r-finding", action: "delete" }] }, apply: true, nowIso: NOW });
|
||||
const columns = Object.keys(wake);
|
||||
db.prepare(`INSERT OR REPLACE INTO outbox_entries (${columns.join(", ")}) VALUES (${columns.map(() => "?").join(", ")})`)
|
||||
.run(...columns.map((c) => wake[c]));
|
||||
expect([exists("r-finding"), marker("r-finding") !== undefined, exists("r-escalation")]).toEqual([false, true, true]);
|
||||
expect(everything()).toContain("secret-r-finding summary");
|
||||
|
||||
const rerun = await eraseQueue(db, { scope: members, apply: true, nowIso: NOW });
|
||||
expect(rerun.qitems.map((q) => q.qitemId)).toEqual(["r-escalation"]);
|
||||
expect(rerun.unlinked).toMatchObject({ outbox: 1, mixedEntries: 0 });
|
||||
expect(rerun.clean).toBe(true);
|
||||
expect(everything()).not.toContain("secret-r-");
|
||||
});
|
||||
|
||||
it("routine retention deletes OpenRig's wake for a row with the row, and OpenRig's own rows keep theirs together", async () => {
|
||||
await row("t-old", A, B, [{ state: "done", daysAgo: 40 }], "openrig");
|
||||
await row("t-self", DAEMON, DAEMON, [{ state: "done", daysAgo: 40 }], "openrig");
|
||||
expect(wakeOf("t-old")).toEqual({ from_: DAEMON, to_: B });
|
||||
const report = await eraseQueue(db, { scope: { kind: "routine", contentDays: 0, metadataDays: 30 }, apply: true, nowIso: NOW });
|
||||
expect(report.qitems.map((q) => [q.qitemId, q.action])).toEqual([["t-old", "delete"], ["t-self", "delete"]]);
|
||||
expect(report.keptCopies).toEqual([]);
|
||||
expect(report.clean).toBe(true);
|
||||
expect(everything()).not.toContain("secret-t-");
|
||||
});
|
||||
});
|
||||
@@ -1,164 +0,0 @@
|
||||
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||
import Database from "better-sqlite3";
|
||||
import { migrate } from "../src/db/migrate.js";
|
||||
import { ALL_MIGRATIONS } from "../src/db/all-migrations.js";
|
||||
import { EventBus } from "../src/domain/event-bus.js";
|
||||
import { QueueRepository, type QueueListOptions } from "../src/domain/queue-repository.js";
|
||||
import { RECOVERY_INDEX_SQL, findQueueRecovery } from "../src/domain/queue-recovery.js";
|
||||
import { QueueTransitionLog } from "../src/domain/queue-transition-log.js";
|
||||
import { runStuckSweep } from "../src/domain/queue-stuck-sweep.js";
|
||||
import { OutboxHandler } from "../src/domain/outbox-handler.js";
|
||||
import { RigRepository } from "../src/domain/rig-repository.js";
|
||||
|
||||
describe("bounded queue lists use their ordering indexes", () => {
|
||||
let db: Database.Database;
|
||||
let repo: QueueRepository;
|
||||
|
||||
beforeEach(() => {
|
||||
db = new Database(":memory:");
|
||||
migrate(db, ALL_MIGRATIONS);
|
||||
repo = new QueueRepository(db, new EventBus(db), { loadHumanRegistry: () => ({ ok: true, entities: [] }) });
|
||||
const insert = db.prepare(`INSERT INTO queue_items
|
||||
(qitem_id, ts_created, ts_updated, source_session, destination_session, state, body, tags)
|
||||
VALUES (?, ?, ?, 'sender@r', 'worker@r', ?, ?, ?)`);
|
||||
db.transaction(() => {
|
||||
for (let i = 0; i < 240; i++) {
|
||||
// Equal timestamps across states exercise the existing scan's tie order too.
|
||||
const ts = new Date(Date.UTC(2026, 10, 12, 0, 0, Math.floor(i / 3))).toISOString();
|
||||
const tags = i % 7 === 0 ? ["first", "second"] : i % 2 ? ["first"] : ["second"];
|
||||
insert.run(`q-${i}`, ts, ts, ["pending", "done", "blocked"][i % 3], "body".repeat(256), JSON.stringify(tags));
|
||||
}
|
||||
})();
|
||||
});
|
||||
afterEach(() => { vi.restoreAllMocks(); db.close(); });
|
||||
|
||||
function selection(options: QueueListOptions) {
|
||||
const prepare = db.prepare.bind(db);
|
||||
let selected: { sql: string; args: unknown[] } | undefined;
|
||||
const spy = vi.spyOn(db, "prepare").mockImplementation((sql: string) => {
|
||||
const statement = prepare(sql);
|
||||
if (/^SELECT (?:\*|qitem_id,).* FROM queue_items\s+(?:WHERE\b|ORDER BY\b)/s.test(sql)) {
|
||||
const all = statement.all.bind(statement);
|
||||
statement.all = (...args: unknown[]) => { selected = { sql, args }; return all(...args); };
|
||||
}
|
||||
return statement;
|
||||
});
|
||||
let ids: string[];
|
||||
try { ids = repo.list(options).map((item) => item.qitemId); }
|
||||
finally { spy.mockRestore(); }
|
||||
expect(selected).toBeDefined();
|
||||
const { sql, args } = selected!;
|
||||
const legacy = prepare(sql.replace("FROM queue_items", "FROM queue_items NOT INDEXED"))
|
||||
.all(...args) as Array<{ qitem_id: string }>;
|
||||
expect(ids).toEqual(legacy.map((row) => row.qitem_id));
|
||||
const plan = prepare(`EXPLAIN QUERY PLAN ${sql}`).all(...args) as Array<{ detail: string }>;
|
||||
return { ids, details: plan.map((row) => row.detail).join("\n") };
|
||||
}
|
||||
|
||||
it.each([false, true])("does not scan and sort all rows for a bounded list (compact=%s)", (compact) => {
|
||||
const { ids, details } = selection({ compact, limit: 6 });
|
||||
expect(ids).toHaveLength(6);
|
||||
expect(details).toContain("USING INDEX");
|
||||
expect(details).not.toContain("TEMP B-TREE");
|
||||
});
|
||||
|
||||
it.each([false, true])("keeps active rows first without sorting all rig history (compact=%s)", (compact) => {
|
||||
const { ids, details } = selection({ rig: "r", compact, limit: 6 });
|
||||
expect(ids).toHaveLength(6);
|
||||
expect(details).toContain("USING INDEX");
|
||||
expect(details).not.toContain("TEMP B-TREE");
|
||||
});
|
||||
|
||||
it.each([false, true])("keeps scoped update-time ordering indexed (compact=%s)", (compact) => {
|
||||
const { ids, details } = selection({ rig: "r", sortByUpdated: true, compact, limit: 6 });
|
||||
expect(ids).toHaveLength(6);
|
||||
expect(details).toContain("USING INDEX");
|
||||
expect(details).not.toContain("TEMP B-TREE");
|
||||
});
|
||||
|
||||
it("looks for owner notifications without reading ordinary live or archived transitions", () => {
|
||||
const log = new QueueTransitionLog(db);
|
||||
const prepare = db.prepare.bind(db);
|
||||
let query = "";
|
||||
const spy = vi.spyOn(db, "prepare").mockImplementation((sql: string) => {
|
||||
if (sql.includes("ROW_NUMBER()") && sql.includes("owner_notification_level IS NOT NULL")) query = sql;
|
||||
return prepare(sql);
|
||||
});
|
||||
try { expect(log.ownerNotificationsForQitems(["q-0"])).toEqual(new Map()); }
|
||||
finally { spy.mockRestore(); }
|
||||
expect(query).not.toBe("");
|
||||
const plan = prepare(`EXPLAIN QUERY PLAN ${query}`).all(JSON.stringify(["q-0"])) as Array<{ detail: string }>;
|
||||
const details = plan.map((row) => row.detail).join("\n");
|
||||
expect(details).toContain("idx_queue_transitions_owner_notification_qitem");
|
||||
expect(details).toContain("idx_queue_transitions_archive_owner_notification_qitem");
|
||||
});
|
||||
|
||||
it("still applies both exact tags before the bound, including zero and unbounded limits", () => {
|
||||
for (const limit of [0, 1, 6, -1]) {
|
||||
const { ids } = selection({ rig: "r", tag: ["first", "second"], limit });
|
||||
expect(ids.every((id) => Number(id.slice(2)) % 7 === 0)).toBe(true);
|
||||
expect(ids).toHaveLength(limit < 0 ? 35 : Math.min(limit, 35));
|
||||
}
|
||||
});
|
||||
|
||||
it("keeps recovery lookup on its small partial index when listing indexes exist", () => {
|
||||
const plan = db.prepare(`EXPLAIN QUERY PLAN ${RECOVERY_INDEX_SQL}`).all() as Array<{ detail: string }>;
|
||||
expect(plan.some((row) => row.detail.includes("idx_queue_items_recovery_tags"))).toBe(true);
|
||||
});
|
||||
|
||||
async function pointPlan(prefix: string, run: () => unknown | Promise<unknown>) {
|
||||
const prepare = db.prepare.bind(db);
|
||||
let selected: { sql: string; args: unknown[] } | undefined;
|
||||
const spy = vi.spyOn(db, "prepare").mockImplementation((sql: string) => {
|
||||
const statement = prepare(sql);
|
||||
if (sql.startsWith(prefix)) {
|
||||
const get = statement.get.bind(statement);
|
||||
statement.get = (...args: unknown[]) => { selected = { sql, args }; return get(...args); };
|
||||
}
|
||||
return statement;
|
||||
});
|
||||
try { await run(); } finally { spy.mockRestore(); }
|
||||
expect(selected).toBeDefined();
|
||||
const plan = prepare(`EXPLAIN QUERY PLAN ${selected!.sql}`).all(...selected!.args) as Array<{ detail: string }>;
|
||||
expect(plan.some((row) => row.detail.includes("idx_queue_items_recovery_tags"))).toBe(true);
|
||||
}
|
||||
|
||||
it("keeps standalone recovery hits and misses on the recovery partial index", async () => {
|
||||
db.prepare("UPDATE queue_items SET tags = ? WHERE qitem_id = 'q-0'").run(JSON.stringify(["recovery-for:subject"]));
|
||||
for (const subject of ["subject", "no-match"]) {
|
||||
for (const exclude of [undefined, "excluded"]) {
|
||||
await pointPlan("SELECT qitem_id, state, ts_updated FROM queue_items", () => {
|
||||
expect(findQueueRecovery(db, subject, exclude)?.qitemId ?? null).toBe(subject === "subject" ? "q-0" : null);
|
||||
});
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
async function sweepForPlan(state: "pending" | "in-progress") {
|
||||
db.exec("DELETE FROM queue_items");
|
||||
repo.attachOutbox(new OutboxHandler(db));
|
||||
if (state === "pending") {
|
||||
const rigs = new RigRepository(db);
|
||||
const rig = rigs.createRig("r");
|
||||
const node = rigs.addNode(rig.id, "worker", { runtime: "claude-code" });
|
||||
db.prepare("INSERT INTO sessions (id,node_id,session_name,status) VALUES ('plan-session',?,'worker@r','running')").run(node.id);
|
||||
}
|
||||
const past = new Date(Date.now() - 120 * 60_000).toISOString();
|
||||
const insert = db.prepare(`INSERT INTO queue_items
|
||||
(qitem_id, ts_created, ts_updated, source_session, destination_session, state, body, claimed_at, closure_required_at)
|
||||
VALUES (?, ?, ?, 'sender@r', 'worker@r', ?, 'work', ?, ?)`);
|
||||
for (let i = 0; i < (state === "pending" ? 3 : 1); i++) {
|
||||
insert.run(`candidate-${i}`, past, past, state, state === "in-progress" ? past : null, state === "in-progress" ? past : null);
|
||||
}
|
||||
return runStuckSweep({ db, queueRepo: repo, resolveOrchestrator: () => null, resolveRecoveryAgentSeat: () => null,
|
||||
resolveOperatorSeat: () => null, isRegisteredHost: () => false, unclaimedAgeMinutes: 60, log: () => {} });
|
||||
}
|
||||
|
||||
it("keeps the per-row finding lookup on the recovery partial index", async () => {
|
||||
await pointPlan("SELECT qitem_id, source_session, state, ts_updated FROM queue_items", () => sweepForPlan("in-progress"));
|
||||
});
|
||||
|
||||
it("keeps the latest backlog finding lookup on the recovery partial index", async () => {
|
||||
await pointPlan("SELECT qitem_id, state, ts_updated, summary, body, destination_session, tags FROM queue_items", () => sweepForPlan("pending"));
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,69 @@
|
||||
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
||||
import type Database from "better-sqlite3";
|
||||
import { createDb } from "../src/db/connection.js";
|
||||
import { migrate } from "../src/db/migrate.js";
|
||||
import { ALL_MIGRATIONS } from "../src/db/all-migrations.js";
|
||||
import { EventBus } from "../src/domain/event-bus.js";
|
||||
import { QueueRepository, createLinkedSuccessorLookup } from "../src/domain/queue-repository.js";
|
||||
import { configureSyncSiteRecorder, runSyncSiteWhenSlow } from "../src/domain/sync-site-wrap.js";
|
||||
|
||||
// The queue's synchronous reads named in the slow-operation log, so an event-loop stall during one is attributed to it.
|
||||
// A fake recorder takes every call; the real recorder's slow threshold is pinned in slow-op-recorder.test.ts.
|
||||
describe("queue reads named in the slow-operation log", () => {
|
||||
let db: Database.Database;
|
||||
let repo: QueueRepository;
|
||||
const sync: string[] = [];
|
||||
const slow: Array<{ site: string; outcome: string }> = [];
|
||||
beforeEach(() => {
|
||||
db = createDb();
|
||||
migrate(db, ALL_MIGRATIONS);
|
||||
repo = new QueueRepository(db, new EventBus(db));
|
||||
configureSyncSiteRecorder({
|
||||
runSync<T>(site: string, fn: () => T): T { sync.push(site); return fn(); },
|
||||
recordSlowSync(site: string, _durationMs: number, outcome: "ok" | "failed"): void { slow.push({ site, outcome }); },
|
||||
});
|
||||
});
|
||||
afterEach(() => { configureSyncSiteRecorder(undefined); sync.length = 0; slow.length = 0; db.close(); });
|
||||
|
||||
it("names a handoff", async () => {
|
||||
const source = await repo.create({ sourceSession: "planner@r", destinationSession: "relay@r", body: "work", nudge: false });
|
||||
sync.length = 0;
|
||||
const { created } = await repo.handoff({ qitemId: source.qitemId, fromSession: "relay@r", toSession: "worker@r", nudge: false });
|
||||
expect(created.destinationSession).toBe("worker@r");
|
||||
expect(sync).toContain("queue.handoff");
|
||||
});
|
||||
|
||||
it("names decisionRevision's reply read through the slow-only site, once per revision", async () => {
|
||||
const ask = await repo.create({ sourceSession: "planner@r", destinationSession: "relay@r", body: "work", nudge: false });
|
||||
slow.length = 0;
|
||||
const revision = repo.decisionRevision(repo.getById(ask.qitemId)!);
|
||||
expect(typeof revision).toBe("string");
|
||||
expect(slow).toEqual([{ site: "queue.decision_revision.replies", outcome: "ok" }]);
|
||||
});
|
||||
|
||||
it("names the stuck sweep's linked-successor build when it is built", () => {
|
||||
const lookup = createLinkedSuccessorLookup(db, ["qitem-source"]);
|
||||
expect(sync).toEqual([]);
|
||||
expect(lookup.has("qitem-source", "worker@r")).toBe(false);
|
||||
expect(lookup.has("qitem-source", "other@r")).toBe(false);
|
||||
expect(sync).toEqual(["queue.linked_successors.build"]);
|
||||
});
|
||||
|
||||
it("keeps the wrapped call's result and error, and records each outcome", () => {
|
||||
expect(runSyncSiteWhenSlow("test.site", () => 7)).toBe(7);
|
||||
expect(() => runSyncSiteWhenSlow("test.site", () => { throw new Error("read failed"); })).toThrow("read failed");
|
||||
expect(slow).toEqual([{ site: "test.site", outcome: "ok" }, { site: "test.site", outcome: "failed" }]);
|
||||
});
|
||||
|
||||
it("never lets a failing record replace the wrapped call's result", () => {
|
||||
configureSyncSiteRecorder({ recordSlowSync(): void { throw new Error("recorder gone"); } });
|
||||
expect(runSyncSiteWhenSlow("test.site", () => "value")).toBe("value");
|
||||
expect(() => runSyncSiteWhenSlow("test.site", () => { throw new Error("read failed"); })).toThrow("read failed");
|
||||
});
|
||||
|
||||
it("runs the call bare when no recorder is configured", () => {
|
||||
configureSyncSiteRecorder(undefined);
|
||||
expect(runSyncSiteWhenSlow("test.site", () => "bare")).toBe("bare");
|
||||
expect(slow).toEqual([]);
|
||||
});
|
||||
});
|
||||
@@ -1,166 +0,0 @@
|
||||
import { beforeEach, afterEach, describe, expect, it, vi } from "vitest";
|
||||
import { Hono } from "hono";
|
||||
import { mkdtempSync, rmSync } from "node:fs";
|
||||
import { join } from "node:path";
|
||||
import { tmpdir } from "node:os";
|
||||
import { SettingsStore, SETTINGS_VALID_KEYS, isSettingsValidKey, parseFeedHostSubscriptionKey } from "../src/domain/user-settings/settings-store.js";
|
||||
import { settingsBrowser } from "../src/domain/user-settings/settings-browser.js";
|
||||
import { configRoutes } from "../src/routes/config.js";
|
||||
|
||||
let home: string;
|
||||
let n = 0;
|
||||
const freshStore = () => new SettingsStore(join(home, `config-${n++}.json`));
|
||||
const browse = () => settingsBrowser(freshStore(), null, home);
|
||||
/** The write path is the oracle: does the daemon's own set() accept this raw value for this key? */
|
||||
const accepts = (key: string, raw: string): boolean => {
|
||||
try { freshStore().set(key, raw); return true; } catch { return false; }
|
||||
};
|
||||
/** Each accepts 1 to 100 on its own, but set() also requires warning < critical: a cross-key rule these per-key fields do not describe. */
|
||||
const PAIRED = new Set(["health.context_pressure.warning_percent", "health.context_pressure.critical_percent"]);
|
||||
|
||||
beforeEach(() => {
|
||||
home = mkdtempSync(join(tmpdir(), "s06-browser-meta-"));
|
||||
for (const key of Object.keys(process.env).filter((k) => /^(OPENRIG_|RIGGED_|SLACK_)/.test(k))) vi.stubEnv(key, "");
|
||||
vi.stubEnv("OPENRIG_HOME", home);
|
||||
vi.stubEnv("OPENRIG_WORKSPACE_ROOT", join(home, "workspace"));
|
||||
});
|
||||
afterEach(() => { vi.unstubAllEnvs(); rmSync(home, { recursive: true, force: true }); });
|
||||
|
||||
describe("browser entry metadata", () => {
|
||||
it("adds type, choices, range, format, write route and timing without changing the existing fields", () => {
|
||||
const entries = browse().entries;
|
||||
expect(entries.find((e) => e.key === "terminal.history_limit")).toMatchObject({
|
||||
type: "integer", range: { min: 2000, max: 1_000_000 }, writeRoute: true, appliesAt: "unknown",
|
||||
value: expect.anything(), defaultKnown: true, application: expect.stringContaining("tmux"),
|
||||
});
|
||||
expect(entries.find((e) => e.key === "terminal.tmux_server")).toMatchObject({
|
||||
type: "enum", choices: ["inherit", "isolated"], writeRoute: true, appliesAt: "daemon_restart",
|
||||
});
|
||||
expect(entries.find((e) => e.key === "daemon.port")).toMatchObject({ type: "integer", range: { min: 0, max: 65535 } });
|
||||
expect(entries.find((e) => e.key === "retention.stream_days")).toMatchObject({ type: "integer", range: { min: 1 } });
|
||||
expect(entries.find((e) => e.key === "retention.stream_days")!.range).not.toHaveProperty("max");
|
||||
expect(entries.find((e) => e.key === "ui.timezone")).toMatchObject({ type: "string", format: "iana-timezone" });
|
||||
expect(entries.find((e) => e.key === "retention.enabled")).toMatchObject({ type: "boolean", appliesAt: "daemon_restart" });
|
||||
// A key with no validator reports a type and nothing it cannot back up.
|
||||
const free = entries.find((e) => e.key === "host.name")!;
|
||||
expect(free).toMatchObject({ type: "string", writeRoute: true });
|
||||
expect(free).not.toHaveProperty("choices");
|
||||
expect(free).not.toHaveProperty("range");
|
||||
expect(free).not.toHaveProperty("format");
|
||||
});
|
||||
|
||||
it("matches the daemon's own validator for every key it can be written under", () => {
|
||||
const entries = browse().entries.filter((e) => e.group === "general" && isSettingsValidKey(e.key));
|
||||
expect(entries.map((e) => e.key)).toEqual([...SETTINGS_VALID_KEYS]);
|
||||
for (const e of entries) {
|
||||
expect(e.writeRoute, e.key).toBe(true);
|
||||
expect(e.type, e.key).toBeDefined();
|
||||
if (e.type === "boolean") {
|
||||
expect(accepts(e.key, "true"), e.key).toBe(true);
|
||||
expect(accepts(e.key, "false"), e.key).toBe(true);
|
||||
expect(accepts(e.key, "not-a-boolean"), e.key).toBe(false);
|
||||
}
|
||||
if (e.type === "integer" && !PAIRED.has(e.key)) {
|
||||
expect(accepts(e.key, "not-a-number"), e.key).toBe(false);
|
||||
if (e.range?.min !== undefined) {
|
||||
expect(accepts(e.key, String(e.range.min)), `${e.key} min`).toBe(true);
|
||||
expect(accepts(e.key, String(e.range.min - 1)), `${e.key} below min`).toBe(false);
|
||||
}
|
||||
if (e.range?.max !== undefined) {
|
||||
expect(accepts(e.key, String(e.range.max)), `${e.key} max`).toBe(true);
|
||||
expect(accepts(e.key, String(e.range.max + 1)), `${e.key} above max`).toBe(false);
|
||||
}
|
||||
// Where a side is left out, the validator must accept a value far on that side.
|
||||
if (e.range?.max === undefined) expect(accepts(e.key, "1000000000"), `${e.key} no max`).toBe(true);
|
||||
if (e.range?.min === undefined) expect(accepts(e.key, "0") || accepts(e.key, "1"), `${e.key} no min`).toBe(true);
|
||||
}
|
||||
if (e.choices) {
|
||||
expect(e.type, e.key).toBe("enum");
|
||||
for (const choice of e.choices) expect(accepts(e.key, choice), `${e.key}=${choice}`).toBe(true);
|
||||
expect(accepts(e.key, "not-one-of-the-choices"), e.key).toBe(false);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("states a range only where the validator is an interval, at sample points across the whole line", () => {
|
||||
const samples = [-1_000_000_000, -100_001, -1000, -61, -60, -2, -1, 0, 1, 2, 59, 60, 100, 101, 599, 600, 601,
|
||||
999, 1000, 1999, 2000, 2001, 3600, 3601, 65535, 65536, 999_999, 1_000_000, 1_000_001, 1_000_000_000];
|
||||
const ranged = browse().entries.filter((x) => x.type === "integer" && x.range && !PAIRED.has(x.key));
|
||||
expect(ranged.length).toBeGreaterThan(25);
|
||||
for (const e of ranged) {
|
||||
for (const sample of samples) {
|
||||
const inside = (e.range!.min === undefined || sample >= e.range!.min) && (e.range!.max === undefined || sample <= e.range!.max);
|
||||
expect(accepts(e.key, String(sample)), `${e.key} at ${sample}`).toBe(inside);
|
||||
}
|
||||
}
|
||||
});
|
||||
|
||||
it("reports the per-key range of the paired percentages and leaves their cross-key rule out", () => {
|
||||
const entries = browse().entries;
|
||||
for (const key of PAIRED) expect(entries.find((e) => e.key === key)).toMatchObject({ type: "integer", range: { min: 1, max: 100 } });
|
||||
// Per key the bounds are the validator's: critical takes 100, nothing takes 0 or 101 ...
|
||||
expect(accepts("health.context_pressure.critical_percent", "100")).toBe(true);
|
||||
for (const key of PAIRED) for (const bad of ["0", "101"]) expect(accepts(key, bad), `${key}=${bad}`).toBe(false);
|
||||
expect(accepts("health.context_pressure.warning_percent", "1")).toBe(true);
|
||||
// ... while the pair rule (warning below critical) still refuses a value inside that range, and is not a field here.
|
||||
expect(accepts("health.context_pressure.warning_percent", "100")).toBe(false);
|
||||
expect(entries.find((e) => e.key === "health.context_pressure.warning_percent")).not.toHaveProperty("pair");
|
||||
});
|
||||
|
||||
it("names a format that agrees with what the validator accepts and refuses", () => {
|
||||
const cases: Record<string, { format: string; ok: string[]; bad: string[] }> = {
|
||||
"ui.timezone": { format: "iana-timezone", ok: ["Europe/London", "UTC"], bad: ["Not/AZone", "+01:00"] },
|
||||
"policies.claude_compaction.preparation_root": { format: "absolute-path-or-empty", ok: ["/var/lib/example", ""], bad: ["relative/path"] },
|
||||
"decisions.template_dir": { format: "absolute-path-or-empty", ok: ["/var/lib/example", ""], bad: ["relative/path"] },
|
||||
"retention.erasure_ledger": { format: "absolute-path-or-empty", ok: ["/var/lib/example/ledger", ""], bad: ["relative/ledger"] },
|
||||
"stream.intake": { format: "queue.worker, off, or member@rig", ok: ["off", "queue.worker", "seat@rig"], bad: ["no at sign"] },
|
||||
"acp.to": { format: "member@rig-or-empty", ok: ["seat@rig", ""], bad: ["no-at-sign", "a@b@c"] },
|
||||
};
|
||||
const entries = browse().entries;
|
||||
for (const [key, c] of Object.entries(cases)) {
|
||||
expect(entries.find((e) => e.key === key)!.format, key).toBe(c.format);
|
||||
for (const ok of c.ok) expect(accepts(key, ok), `${key}=${ok}`).toBe(true);
|
||||
for (const bad of c.bad) expect(accepts(key, bad), `${key}=${bad}`).toBe(false);
|
||||
}
|
||||
// Every key that reports a format is in this table, so a new one cannot ship unchecked.
|
||||
expect(entries.filter((e) => e.format).map((e) => e.key).sort()).toEqual(Object.keys(cases).sort());
|
||||
});
|
||||
|
||||
it("reports the write route as the daemon's own key rules decide, for every entry", () => {
|
||||
const store = freshStore();
|
||||
store.set("feed.subscriptions.fixture-host.enabled", "true");
|
||||
const entries = settingsBrowser(store, null, home).entries;
|
||||
for (const e of entries) {
|
||||
expect(e.writeRoute, e.key).toBe(isSettingsValidKey(e.key) || parseFeedHostSubscriptionKey(e.key) !== null);
|
||||
}
|
||||
expect(entries.find((e) => e.key === "feed.subscriptions.fixture-host.enabled")).toMatchObject({ type: "boolean", writeRoute: true });
|
||||
expect(entries.find((e) => e.key === "slack.enabled")).toMatchObject({ writeRoute: false });
|
||||
expect(entries.find((e) => e.key === "slack.enabled")).not.toHaveProperty("type");
|
||||
expect(entries.filter((e) => e.group !== "general" && e.writeRoute)).toEqual([]);
|
||||
});
|
||||
|
||||
it("agrees with the write route itself: the keys it reports writable are accepted, the others are unknown keys", async () => {
|
||||
const store = freshStore();
|
||||
const app = new Hono();
|
||||
app.use("*", async (c, next) => { c.set("settingsStore" as never, store as never); await next(); });
|
||||
app.route("/api/config", configRoutes({ home }));
|
||||
const post = (key: string, value: string) => app.request(`/api/config/${key}`, {
|
||||
method: "POST", headers: { "content-type": "application/json" }, body: JSON.stringify({ value }) });
|
||||
expect((await post("terminal.history_limit", "5000")).status).toBe(200);
|
||||
expect((await post("terminal.history_limit", "1999")).status).toBe(400);
|
||||
const refused = await post("slack.enabled", "true");
|
||||
expect(refused.status).toBe(400);
|
||||
expect((await refused.json()).error).toContain("Unknown config key");
|
||||
const browser = await (await app.request("/api/config?view=browser")).json();
|
||||
expect(browser.entries.find((e: { key: string }) => e.key === "terminal.history_limit")).toMatchObject({ writeRoute: true, range: { min: 2000, max: 1_000_000 } });
|
||||
expect(browser.entries.find((e: { key: string }) => e.key === "slack.enabled")).toMatchObject({ writeRoute: false });
|
||||
expect(browser.readOnly).toBe(true);
|
||||
});
|
||||
|
||||
it("marks timing only where the application guidance says a restart applies it, and says unknown otherwise", () => {
|
||||
for (const e of browse().entries) {
|
||||
const guidanceSaysRestart = /\bdaemon (?:restart|startup)\b/i.test(e.application);
|
||||
expect(e.appliesAt, e.key).toBe(guidanceSaysRestart ? "daemon_restart" : "unknown");
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -96,8 +96,6 @@ describe("Slack sweep selection", () => {
|
||||
it("keeps a legacy schema without owner classification quiet", async () => {
|
||||
row("legacy");
|
||||
for (const table of ["queue_transitions", "queue_transitions_archive"]) {
|
||||
// The simulated pre-classification schema also predates its partial index.
|
||||
db.exec(`DROP INDEX idx_${table}_owner_notification_qitem`);
|
||||
db.exec(`ALTER TABLE ${table} DROP COLUMN owner_notification_level; ALTER TABLE ${table} DROP COLUMN owner_notification_kind`);
|
||||
}
|
||||
repo = new QueueRepository(db, new EventBus(db), { loadHumanRegistry: () => registry });
|
||||
|
||||
@@ -21,6 +21,7 @@ const expectedSites = new Map<string, string[]>([
|
||||
["domain/codex-thread-id.ts", ["codex_thread_id.resolve_home"]],
|
||||
["domain/review/gather.ts", ["review.gather.git"]],
|
||||
["domain/tmux-option-defaults.ts", ["tmux_options.command_v"]],
|
||||
["domain/queue-repository.ts", ["queue.decision_revision.replies", "queue.linked_successors.build", "queue.handoff"]],
|
||||
]);
|
||||
|
||||
const pluginVendorUrl = "https://github.com/mvschwarz/openrig-plugins/releases/latest/download/openrig-core.tar.gz";
|
||||
@@ -290,6 +291,23 @@ describe("SlowOpRecorder locked instrumentation contract", () => {
|
||||
await recorder.close();
|
||||
});
|
||||
|
||||
it("records a slow synchronous site only at or above the slow threshold, with its outcome", async () => {
|
||||
const mod = await loadRecorderModule();
|
||||
expect(mod, "slow-op-recorder production module is missing").not.toBeNull();
|
||||
if (!mod) return;
|
||||
|
||||
const dir = tempDir();
|
||||
const logPath = path.join(dir, "slow-operations.jsonl");
|
||||
const recorder = new mod.SlowOpRecorder({ logPath, slowThresholdMs: 250 });
|
||||
recorder.recordSlowSync("queue.decision_revision.replies", 249, "ok");
|
||||
recorder.recordSlowSync("queue.decision_revision.replies", 250, "ok");
|
||||
recorder.recordSlowSync("queue.decision_revision.replies", 400, "failed");
|
||||
await recorder.flush();
|
||||
const records = (await readRecords(logPath)).filter((record) => record.site === "queue.decision_revision.replies");
|
||||
expect(records.map((record) => [record.phase, record.durationMs, record.outcome])).toEqual([["end", 250, "ok"], ["end", 400, "failed"]]);
|
||||
await recorder.close();
|
||||
});
|
||||
|
||||
// The request-timing MIDDLEWARE CONTRACT, hermetic + deterministic. The prior "real server" form
|
||||
// ran the full daemon (event-loop monitor + a globalThis.fetch monkey-patch), which is structurally
|
||||
// ambient-fragile under the concurrent-workspace gate: it intermittently returned 200 for an unmatched
|
||||
|
||||
@@ -625,19 +625,6 @@ describe("SettingsStore (User Settings v0)", () => {
|
||||
}
|
||||
});
|
||||
|
||||
it("a non-string provider.selected in config.json falls back to the default with a warning", () => {
|
||||
writeFileSync(configPath, JSON.stringify({ provider: { selected: ["claude"] } }));
|
||||
const stderrSpy = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
|
||||
try {
|
||||
const store = new SettingsStore(configPath);
|
||||
expect(store.resolveOne("provider.selected")).toMatchObject({ value: "", source: "default" });
|
||||
const warns = stderrSpy.mock.calls.map((c) => String(c[0]));
|
||||
expect(warns.some((w) => w.includes("file value for provider.selected rejected"))).toBe(true);
|
||||
} finally {
|
||||
stderrSpy.mockRestore();
|
||||
}
|
||||
});
|
||||
|
||||
it("a quoted in-range port in config.json keeps its port, and the CLI target and daemon bind agree", () => {
|
||||
writeFileSync(configPath, JSON.stringify({ daemon: { port: "7434" } }));
|
||||
const store = new SettingsStore(configPath);
|
||||
|
||||
@@ -577,23 +577,6 @@ describe("OPR.0.4.6.WF2 — spec language", () => {
|
||||
).rejects.toMatchObject({ code: "harness_pin_unsatisfied" });
|
||||
});
|
||||
|
||||
it("validate warns that a harness pin is unchecked instead of reporting a clean result (#3087)", () => {
|
||||
const spec = parseWorkflowSpec(HARNESS_SPEC, "harness.yaml");
|
||||
const result = new WorkflowValidator().validate(spec);
|
||||
expect(result.ok).toBe(true);
|
||||
const unchecked = result.issues.filter((i) => i.code === "harness_pin_unchecked");
|
||||
expect(unchecked).toHaveLength(1);
|
||||
expect(unchecked[0]).toMatchObject({ severity: "warning", field: "workflow.steps[0].harness" });
|
||||
expect(unchecked[0]!.message).toContain('"codex"');
|
||||
expect(unchecked[0]!.message).toContain("no rig is bound");
|
||||
});
|
||||
|
||||
it("validate adds no pin warning to a spec without harness pins", () => {
|
||||
const spec = parseWorkflowSpec(LINEAR_SPEC, "linear.yaml");
|
||||
const result = new WorkflowValidator().validate(spec);
|
||||
expect(result.issues.some((i) => i.code === "harness_pin_unchecked")).toBe(false);
|
||||
});
|
||||
|
||||
it("steps with no pin resolve preferred_targets[0] unchanged (zero regression)", async () => {
|
||||
const specPath = writeSpec(tmp, "linear.yaml", LINEAR_SPEC);
|
||||
const result = await runtime.instantiate({
|
||||
|
||||
@@ -1,49 +0,0 @@
|
||||
import { CHECK_IN_DISPLAY, describeCheckIn, type CheckInStatus } from "@openrig/daemon/connection-contract";
|
||||
import { wrapDetailLines, type ContentLine } from "./detail.js";
|
||||
import { displayTime } from "./time.js";
|
||||
import type { ConnectedAssistant } from "./types.js";
|
||||
|
||||
/** The hosted-members answer as connected assistants; null when it isn't one. A status this TUI doesn't know reads
|
||||
* unknown, as in `rig ps`. */
|
||||
export function toConnectedAssistants(body: unknown): ConnectedAssistant[] | null {
|
||||
const members = (body as { members?: unknown } | null)?.members;
|
||||
if (!Array.isArray(members)) return null;
|
||||
return members.flatMap((member: Record<string, unknown>) => {
|
||||
if (typeof member?.seat !== "string" || !member.seat) return [];
|
||||
const known = typeof member.status === "string" && member.status in CHECK_IN_DISPLAY;
|
||||
return [{ seat: member.seat, checkIn: {
|
||||
status: known ? member.status as CheckInStatus : "unknown",
|
||||
lastCheckInAt: typeof member.lastCheckInAt === "string" ? member.lastCheckInAt : null,
|
||||
expectedMinutes: typeof member.expectedMinutes === "number" ? member.expectedMinutes : null,
|
||||
onRequest: member.onRequest === true,
|
||||
...(known && typeof member.reason === "string" ? { reason: member.reason } : {}),
|
||||
} }];
|
||||
});
|
||||
}
|
||||
|
||||
/** The hosted-members read as the list, or why it couldn't be read, in `rig ps`'s words: an older daemon's 404, a failed
|
||||
* read, or an answer that isn't one. A failed read isn't an empty list. */
|
||||
export function connectedAssistantsOf(answer: { status: number; body: unknown }): { assistants: ConnectedAssistant[] } | { unavailable: string } {
|
||||
if (answer.status === 404) return { unavailable: "this daemon doesn't serve it" };
|
||||
if (answer.status >= 400) return { unavailable: `the read failed: HTTP ${answer.status}` };
|
||||
const assistants = toConnectedAssistants(answer.body);
|
||||
return assistants ? { assistants } : { unavailable: "the daemon's answer couldn't be read" };
|
||||
}
|
||||
|
||||
/** The connected assistants under a seat table, each with its check-in line in the daemon's words and the time in the
|
||||
* viewer's zone; only one rig's when `rig` is given. Nothing when there are none; one line saying check-in is
|
||||
* unavailable, with the reason, when the list couldn't be read. */
|
||||
export function connectedAssistantLines(assistants: ConnectedAssistant[] | undefined, unavailable: string | undefined, rig: string | null,
|
||||
filter: string | null, width: number, timeZone?: string): ContentLine[] {
|
||||
if (unavailable) return [{ text: "" }, ...wrapDetailLines([{ text: `Connected assistants: check-in unavailable (${unavailable})` }], width)];
|
||||
const shown = (assistants ?? [])
|
||||
.filter((a) => !rig || a.seat.endsWith(`@${rig}`))
|
||||
.filter((a) => !filter || a.seat.includes(filter));
|
||||
if (shown.length === 0) return [];
|
||||
return [
|
||||
{ text: "" },
|
||||
{ text: "Connected assistants (outside the terminal; each checks its own queue):" },
|
||||
...wrapDetailLines(shown.map((a) => ({ text: ` ${a.seat} ${describeCheckIn({ ...a.checkIn,
|
||||
lastCheckInAt: a.checkIn.lastCheckInAt === null ? null : displayTime(a.checkIn.lastCheckInAt, timeZone) })}` })), width),
|
||||
];
|
||||
}
|
||||
@@ -419,14 +419,6 @@ export class DaemonClient {
|
||||
const query = [item ? `item=${encodeURIComponent(item)}` : null, view ? `view=${encodeURIComponent(view)}` : null].filter(Boolean).join("&");
|
||||
return this.get(`/api/attention${query ? `?${query}` : ""}`);
|
||||
}
|
||||
/** Connected assistants (roster members outside any terminal) and their check-in. Optional: an older daemon has no
|
||||
* such route. */
|
||||
/** This daemon's connected assistants, as the status and body it answered; an older daemon answers 404. A failed read
|
||||
* isn't an empty list, so the caller is given the status to tell them apart. */
|
||||
async hostedMembers(): Promise<{ status: number; body: unknown }> {
|
||||
const res = await this.optionalFetchImpl(`${this.baseUrl}/api/queue/hosted-members`, { headers: this.headers, signal: AbortSignal.timeout(5_000) });
|
||||
return { status: res.status, body: res.ok ? await res.json().catch(() => null) : null };
|
||||
}
|
||||
queueItem(qitemId: string, options: { optional?: boolean } = {}) {
|
||||
return this.get(`/api/queue/${encodeURIComponent(qitemId)}`, options.optional ? this.optionalFetchImpl : this.fetchImpl);
|
||||
}
|
||||
|
||||
@@ -24,7 +24,6 @@ import { parse as parseYaml } from "yaml";
|
||||
import type { AgentRow, FleetSnapshot, HealthCoverage, HealthRecord, HostNode, NeedsItem, PodNode, QueueRead, RecentTransitionSnap, SeatActivitySummary, SeatEffortRead, SliceDetailSnap, SpecEntry, ViewState } from "./types.js";
|
||||
import { isHumanSeatSession } from "./pulse/pulse-model.js";
|
||||
import { sanitizeHostDisplayName } from "./topology/host-label.js";
|
||||
import { connectedAssistantsOf } from "./connected-assistants.js";
|
||||
|
||||
// Narrow read-shapes: just the served fields this module consumes (names match
|
||||
// the daemon's serialized output — see the Phase-2 endpoint-shape survey).
|
||||
@@ -573,15 +572,6 @@ export async function hydrateSnapshot(
|
||||
// A drilled-into host that isn't this one: its pages read none of this host's seats or queue changes.
|
||||
const drilledHost = viewContext?.section === "topology" ? viewContext.drill.find((segment) => segment.kind === "host")?.name : undefined;
|
||||
const remoteDrill = !!drilledHost && drilledHost !== (instanceHealth?.selfHostId?.trim() || "local");
|
||||
// Optional, like the Slack manifest: a failed read isn't a page failure. But it isn't an empty list either, so the seat
|
||||
// tables say check-in is unavailable, as `rig ps` does. Read only for the instance and rig tables that list them, and
|
||||
// only this daemon's, never a remote host's.
|
||||
const listsAssistants = !viewContext || (viewContext.section === "topology" && viewContext.viewTab === "table"
|
||||
&& (topologyLeaf?.kind === "host" || topologyLeaf?.kind === "rig"));
|
||||
const connectedAssistants = listsAssistants && !remoteDrill
|
||||
? await client.hostedMembers().then(connectedAssistantsOf,
|
||||
(error: unknown) => ({ unavailable: `the read failed: ${error instanceof Error ? error.message : String(error)}` }))
|
||||
: null;
|
||||
const recentTransitionsRig = currentRigName ?? (!viewContext ? summaries?.[0]?.name : null) ?? null;
|
||||
const recentTransitionsScope = topologyLeaf?.kind === "host"
|
||||
? { kind: "instance" } as const
|
||||
@@ -695,8 +685,6 @@ export async function hydrateSnapshot(
|
||||
displayName: ownName && ownName !== "localhost" ? ownName : undefined,
|
||||
reachable: true,
|
||||
rigs: rigs.sort(byRigName),
|
||||
...(connectedAssistants ? "unavailable" in connectedAssistants
|
||||
? { connectedAssistantsUnavailable: connectedAssistants.unavailable } : { connectedAssistants: connectedAssistants.assistants } : {}),
|
||||
};
|
||||
// A remote host is any registered host, or one the attention aggregate answered for. Its reachability is the aggregate's
|
||||
// answer where there is one, else the registry's probe. Only a drilled-into remote host's rigs are read, through this
|
||||
|
||||
@@ -31,7 +31,6 @@ import type { CrashCartModel } from "./crash-cart/crash-cart-model.js";
|
||||
import type { DaemonState, DaemonUnverifiedEvidence } from "./crash-cart/contract.js";
|
||||
import { runtimeMarkSegs } from "./topology/runtime-marks.js";
|
||||
import { hostLabel, hostReachabilityLabel } from "./topology/host-label.js";
|
||||
import { connectedAssistantLines } from "./connected-assistants.js";
|
||||
import { barCells, flashActive, reducedMotion, spinnerFrame } from "./motion.js";
|
||||
import { explorerWidth, MOTION_FRAME_MS } from "./visual-layout.js";
|
||||
import type { ColorMode, Token } from "./theme.js";
|
||||
@@ -868,7 +867,6 @@ function instanceContentLines(
|
||||
});
|
||||
}
|
||||
}
|
||||
lines.push(...connectedAssistantLines(host.connectedAssistants, host.connectedAssistantsUnavailable, null, state.filter, contentWidth, state.timeZone));
|
||||
lines.push({ text: "" }, { text: host.rigs.some(r => r.inventoryUnavailable) ? `${host.rigs.length} rigs · inventory incomplete · ${seatCount} seats read` : `${host.rigs.length} rigs · ${seatCount} seats · ${workingCount} working · ${attentionCount} need attention${attentionUnknown ? ` · ${attentionUnknown} attention unknown` : ""} · ${openCount}${queueIncomplete(snap) ? "+ sampled" : ""} open rows` });
|
||||
lines.push(...recentLines(snap, scope, contentWidth, false, state.timeZone));
|
||||
return lines;
|
||||
@@ -1109,7 +1107,6 @@ function contentLines(state: ViewState, snap: FleetSnapshot, contentWidth: numbe
|
||||
zones,
|
||||
});
|
||||
}
|
||||
if (!podFilter) lines.push(...connectedAssistantLines(host.connectedAssistants, host.connectedAssistantsUnavailable, rig.name, state.filter, contentWidth, state.timeZone));
|
||||
lines.push({ text: "" });
|
||||
const working = rows.filter((agent) => ["active", "working", "running"].includes(agent.status)).length;
|
||||
const attention = rows.filter((agent) => /attention|needs|blocked|unknown|failed/.test(agent.status)).length;
|
||||
|
||||
@@ -97,18 +97,6 @@ export interface HostNode {
|
||||
/** true/false only when a probe answered; null keeps missing or unknown distinct. */
|
||||
reachable: boolean | null;
|
||||
rigs: RigNode[];
|
||||
/** Roster members outside any terminal (assistants reaching the team over MCP) and their check-in, read from this
|
||||
* daemon only. Absent when not read, or when the read failed. */
|
||||
connectedAssistants?: ConnectedAssistant[];
|
||||
/** Why the connected assistants couldn't be read (an older daemon, a failed read, an unusable answer); absent when
|
||||
* they were read or not asked for. */
|
||||
connectedAssistantsUnavailable?: string;
|
||||
}
|
||||
|
||||
/** A connected assistant's check-in as this daemon reports it. */
|
||||
export interface ConnectedAssistant {
|
||||
seat: string;
|
||||
checkIn: Pick<import("@openrig/daemon/connection-contract").MemberCheckIn, "status" | "lastCheckInAt" | "expectedMinutes" | "onRequest" | "reason">;
|
||||
}
|
||||
|
||||
export type SpecKind = "rig" | "agent" | "workflow";
|
||||
|
||||
@@ -37,7 +37,6 @@ const SPEC_4A_ROUTES = [
|
||||
"/api/provider/status",
|
||||
"/api/provider/usage/hosts",
|
||||
"/api/telemetry/usage/cost",
|
||||
"/api/queue/hosted-members",
|
||||
];
|
||||
|
||||
describe("daemon client = the §4.A table, one module, nothing else (FR-8/FR-9)", () => {
|
||||
@@ -76,7 +75,6 @@ describe("daemon client = the §4.A table, one module, nothing else (FR-8/FR-9)"
|
||||
await c.providerStatus();
|
||||
await c.usageAcrossHosts();
|
||||
await c.usageCost();
|
||||
await c.hostedMembers();
|
||||
|
||||
expect(seen.sort()).toEqual([...SPEC_4A_ROUTES].sort());
|
||||
});
|
||||
|
||||
@@ -6,7 +6,6 @@ import { hydrateSnapshot } from "../src/hydrate.js";
|
||||
import { renderScreen } from "../src/render.js";
|
||||
import { createViewState } from "../src/state.js";
|
||||
import { rowStatusGlyph, statusGlyph } from "../src/topology/glyphs.js";
|
||||
import { displayTime } from "../src/time.js";
|
||||
|
||||
// Fixtures mirror the SERVED shapes traced firsthand at 5f3b5bd4 (Phase-2
|
||||
// endpoint-shape survey): real field names, real enum values, real evidence
|
||||
@@ -163,7 +162,6 @@ const FIXTURES: Record<string, unknown> = {
|
||||
"/api/queue/list?state=pending&limit=50": [],
|
||||
"/api/queue/list?state=done,handed-off&sort=updated&limit=20": [],
|
||||
"/api/queue/recent-transitions?scope=rig&rig=myrig&limit=20": [],
|
||||
"/api/queue/hosted-members": { hostId: "mm2-openrig1", members: [] },
|
||||
};
|
||||
|
||||
function fixtureClient(
|
||||
@@ -175,8 +173,6 @@ function fixtureClient(
|
||||
const route = String(url).replace("http://x", "");
|
||||
calls?.push(route);
|
||||
const failure = overrides[route];
|
||||
// Status 0 stands for a read that never got an answer, such as a dropped connection.
|
||||
if (failure?.status === 0) throw new Error("fetch failed");
|
||||
if (failure) return { ok: false, status: failure.status, json: async () => failure.body ?? null } as Response;
|
||||
if (route in responses) return { ok: true, json: async () => responses[route] } as Response;
|
||||
if (!(route in FIXTURES)) throw new Error(`unexpected route in test: ${route}`);
|
||||
@@ -756,65 +752,6 @@ describe("snapshot hydration over the §4.A reads (Phase 2)", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("lists connected assistants and their check-in under the seat tables, one rig's in the rig view", async () => {
|
||||
const hosted = { hostId: "mm2-openrig1", members: [
|
||||
{ seat: "chat@myrig", rung: false, status: "check-in-overdue", lastCheckInAt: "2026-11-12T13:05:00.000Z", expectedMinutes: 60, onRequest: false, reporter: "openrig-observed" },
|
||||
{ seat: "desk@myrig", rung: false, status: "on-request", lastCheckInAt: "2026-11-12T12:00:00.000Z", expectedMinutes: null, onRequest: true, reporter: "openrig-observed" },
|
||||
{ seat: "bot@downrig", rung: false, status: "a-newer-status", lastCheckInAt: null, expectedMinutes: null, onRequest: false, reporter: "openrig-observed", reason: "not shown" },
|
||||
] };
|
||||
const snap = await hydrateSnapshot(fixtureClient({}, { "/api/queue/hosted-members": hosted }));
|
||||
expect(snap.readErrors.some((error) => error.includes("hosted"))).toBe(false);
|
||||
|
||||
const rigView = createViewState({ instanceId: "t", getSnapshot: () => snap });
|
||||
rigView.dispatch({ type: "drill", resource: "rig", name: "myrig" });
|
||||
const rigLines = renderScreen(rigView.get(), snap, { cols: 220, rows: 60 }).lines.join("\n");
|
||||
expect(rigLines).toContain("Connected assistants (outside the terminal; each checks its own queue):");
|
||||
expect(rigLines).toContain(`chat@myrig overdue: last check-in ${displayTime("2026-11-12T13:05:00.000Z")}, expected every 60 min; its schedule may be off or waiting for an approval`);
|
||||
expect(rigLines).toContain(`desk@myrig on request: it checks its queue when a person asks it; last check-in ${displayTime("2026-11-12T12:00:00.000Z")}`);
|
||||
expect(rigLines).not.toContain("bot@downrig");
|
||||
|
||||
const instanceView = createViewState({ instanceId: "t", getSnapshot: () => snap });
|
||||
instanceView.dispatch({ type: "drill", resource: "host", name: snap.hosts[0]!.name });
|
||||
const instanceLines = renderScreen(instanceView.get(), snap, { cols: 160, rows: 60 }).lines.join("\n");
|
||||
expect(instanceLines).toContain("chat@myrig overdue:");
|
||||
// A status this TUI doesn't know reads unknown, without the newer daemon's reason.
|
||||
expect(instanceLines).toContain("bot@downrig unknown");
|
||||
expect(instanceLines).not.toContain("not shown");
|
||||
});
|
||||
|
||||
it("a known-empty list of connected assistants stays quiet", async () => {
|
||||
const snap = await hydrateSnapshot(fixtureClient());
|
||||
expect(snap.hosts[0]!.connectedAssistants).toEqual([]);
|
||||
expect(snap.hosts[0]!.connectedAssistantsUnavailable).toBeUndefined();
|
||||
const view = createViewState({ instanceId: "t", getSnapshot: () => snap });
|
||||
view.dispatch({ type: "drill", resource: "rig", name: "myrig" });
|
||||
expect(renderScreen(view.get(), snap, { cols: 160, rows: 60 }).lines.join("\n")).not.toContain("Connected assistants");
|
||||
});
|
||||
|
||||
it.each([
|
||||
["an older daemon without the route", { overrides: { "/api/queue/hosted-members": { status: 404 } } }, "this daemon doesn't serve it"],
|
||||
["a failed read", { overrides: { "/api/queue/hosted-members": { status: 500 } } }, "the read failed: HTTP 500"],
|
||||
["a dropped connection", { overrides: { "/api/queue/hosted-members": { status: 0 } } }, "the read failed: fetch failed"],
|
||||
["an answer without a members list", { responses: { "/api/queue/hosted-members": { hostId: "mm2-openrig1" } } }, "the daemon's answer couldn't be read"],
|
||||
])("%s says check-in is unavailable, not that there are none", async (_case, setup, reason) => {
|
||||
const snap = await hydrateSnapshot(fixtureClient("overrides" in setup ? setup.overrides : {}, "responses" in setup ? setup.responses : {}));
|
||||
expect(snap.hosts[0]!.connectedAssistants).toBeUndefined();
|
||||
expect(snap.hosts[0]!.connectedAssistantsUnavailable).toBe(reason);
|
||||
// Optional, like the other enrichment: the page itself still reads as whole.
|
||||
expect(snap.readErrors).toEqual([]);
|
||||
const line = `Connected assistants: check-in unavailable (${reason})`;
|
||||
|
||||
const rigView = createViewState({ instanceId: "t", getSnapshot: () => snap });
|
||||
rigView.dispatch({ type: "drill", resource: "rig", name: "myrig" });
|
||||
const rigLines = renderScreen(rigView.get(), snap, { cols: 160, rows: 60 }).lines.join("\n");
|
||||
expect(rigLines).toContain(line);
|
||||
expect(rigLines).not.toContain("each checks its own queue");
|
||||
|
||||
const instanceView = createViewState({ instanceId: "t", getSnapshot: () => snap });
|
||||
instanceView.dispatch({ type: "drill", resource: "host", name: snap.hosts[0]!.name });
|
||||
expect(renderScreen(instanceView.get(), snap, { cols: 160, rows: 60 }).lines.join("\n")).toContain(line);
|
||||
});
|
||||
|
||||
it("shows confirmed missing sessions as detached unless lifecycle still requires attention", async () => {
|
||||
const base = (FIXTURES["/api/rigs/01JRIG/nodes"] as Array<Record<string, unknown>>)[0]!;
|
||||
const nodes = [
|
||||
|
||||
@@ -66,9 +66,7 @@ it("a 24-rig landing fetches names only; a selected rig never reads unrelated in
|
||||
]);
|
||||
// The rig Table reads health once without fetching other rigs' node inventories.
|
||||
expect(calls.filter(c => c.startsWith("/api/health"))).toEqual(["/api/health?limit=200"]);
|
||||
// One read of this daemon's connected assistants, which the rig Table lists after its seats.
|
||||
expect(calls.filter(c => c === "/api/queue/hosted-members")).toHaveLength(1);
|
||||
expect(calls).toHaveLength(11);
|
||||
expect(calls).toHaveLength(10);
|
||||
expect(snap.health).toMatchObject({ availability: "loaded", total: 0, records: [] });
|
||||
expect(renderScreen(view.get(), snap, { cols: 220, rows: 60 }).lines.join("\n")).toContain("no findings served; not a healthy verdict");
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user