Handle ServiceTask responses without a Content-Type or body (#1387)

src/python/txtai/workflow/task/service.py

@@ -54,7 +54,10 @@ class ServiceTask(Task):
 
     def execute(self, elements, executor=None):
         if self.batch:
-            elements = self.request(elements)
+            response = self.request(elements)
+
+            # Empty response body returns None for each element, same as batch=False
+            elements = [None] * len(elements) if response is None else response
         else:
             elements = [self.request(element) for element in elements]
 
@@ -91,8 +94,12 @@ class ServiceTask(Task):
         else:
             response = requests.post(self.url, json=params, timeout=self.timeout)
 
+        # Empty response body (e.g. 204 No Content), nothing to parse
+        if not response.content:
+            return None
+
         # Parse data based on content-type
-        mimetype = response.headers["Content-Type"].split(";")[0]
+        mimetype = response.headers.get("Content-Type", "").split(";")[0]
         if mimetype.lower().endswith("xml"):
             data = xmltodict.parse(response.text)
         else:

test/python/testapi/testapiworkflow.py

@@ -85,6 +85,12 @@ workflow:
               url: http://127.0.0.1:8001/testpost
               params:
 
+    empty:
+        tasks:
+            - task: service
+              url: http://127.0.0.1:8001/empty
+              params:
+
     xml:
         tasks:
             - task: service
@@ -144,6 +150,12 @@ class RequestHandler(BaseHTTPRequestHandler):
         length = int(self.headers["content-length"])
         data = json.loads(self.rfile.read(length))
 
+        if self.path.startswith("/empty"):
+            # Respond without a body or content-type
+            self.send_response(204)
+            self.end_headers()
+            return
+
         response = json.dumps([[y for y in x.split(".") if y] for x in data]).encode("utf-8")
 
         self.send_response(200)
@@ -235,6 +247,16 @@ class TestWorkflow(unittest.TestCase):
         self.assertEqual(len(results), 1)
         self.assertEqual(len(results[0]), 2)
 
+    def testServiceEmpty(self):
+        """
+        Test workflow with ServiceTask POST via API and an empty response
+        """
+
+        text = "This is a test sentence. And another sentence to split."
+        results = self.client.post("workflow", json={"name": "empty", "elements": [text]}).json()
+
+        self.assertEqual(results, [None])
+
     def testServiceXml(self):
         """
         Test workflow with ServiceTask GET via API and XML response