openharmony/third_party_elfutils
1
0
Fork 0
mirror of https://github.com/openharmony/third_party_elfutils.git synced 2026-07-18 17:24:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix sanitize-undefined config check. Don't ALLOW_UNALIGNED when checking.

Browse Source 
The -fsanitize=undefined check need to use AC_LINK_IFELSE to make sure
libubsan is installed. When doing undefined checking we should disable
ALLOW_UNALIGNED memory accesses to catch issues where we do unaligned
accesses by accident.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
This commit is contained in:
Mark Wielaard
2015-05-31 22:37:19 +02:00
parent 616489da50
commit 170f1bb0a8
4 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ChangeLog
+5
View File
@@ -1,3 +1,8 @@
2015-05-31 Mark Wielaard <mjw@redhat.com>
* configure.ac (use_undefined): Use AC_LINK_IFELSE. AC_DEFINE
CHECK_UNDEFINED.
2015-05-30 Mark Wielaard <mjw@redhat.com>
* configure.ac: Check for bunzip2. Check flex and bison are
configure.ac
+9 -3
View File
@@ -202,13 +202,19 @@ if test "$use_undefined" = yes; then
old_CXXFLAGS="$CXXFLAGS"
# We explicitly use unaligned access when possible (see ALLOW_UNALIGNED)
# We want to fail immediately on first error, don't try to recover.
CFLAGS="$CFLAGS -fsanitize=undefined -fno-sanitize=alignment -fno-sanitize-recover"
CXXFLAGS="$CXXFLAGS -fsanitize=undefined -fno-sanitize=alignment -fno-sanitize-recover"
AC_COMPILE_IFELSE([AC_LANG_SOURCE([])], use_undefined=yes, use_undefined=no)
CFLAGS="$CFLAGS -fsanitize=undefined -fno-sanitize-recover"
CXXFLAGS="$CXXFLAGS -fsanitize=undefined -fno-sanitize-recover"
AC_LINK_IFELSE([AC_LANG_SOURCE([int main (int argc, char **argv) { return 0; }])], use_undefined=yes, use_undefined=no)
AS_IF([test "x$use_undefined" != xyes],
AC_MSG_WARN([gcc undefined behaviour sanitizer not available])
CFLAGS="$old_CFLAGS" CXXFLAGS="$old_CXXFLAGS")
fi
case $use_undefined in
yes) check_undefined_val=1 ;;
*) check_undefined_val=0 ;;
esac
AC_DEFINE_UNQUOTED(CHECK_UNDEFINED, $check_undefined_val,
[Building with -fsanitize=undefined or not])
AC_ARG_ENABLE([valgrind],
AS_HELP_STRING([--enable-valgrind],[run all tests under valgrind]),
lib/ChangeLog
+4
View File
@@ -1,3 +1,7 @@
2015-05-31 Mark Wielaard <mjw@redhat.com>
* eu-config.h (ALLOW_UNALIGNED): Define when ! CHECK_UNDEFINED.
2015-04-23 Max Filippov <jcmvbkbc@gmail.com>
* eu-config.h: Use SYMBOL_VERSIONING as guard.
lib/eu-config.h
+2 -1
View File
@@ -73,7 +73,8 @@
/* Define ALLOW_UNALIGNED if the architecture allows operations on
unaligned memory locations. */
#if defined __i386__ || defined __x86_64__
#define SANITIZE_UNDEFINED 1
#if (defined __i386__ || defined __x86_64__) && ! CHECK_UNDEFINED
# define ALLOW_UNALIGNED 1
#else
# define ALLOW_UNALIGNED 0