openharmony/third_party_elfutils
1
0
Fork 0
mirror of https://github.com/openharmony/third_party_elfutils.git synced 2026-07-15 07:28:18 -04:00
Code Issues Packages Projects Releases Wiki Activity

libelf: Check compression ratio before trying to allocate output buffer.

Browse Source 
The maximum compression factor (http://www.zlib.net/zlib_tech.html) is
1032:1. Add a sanity check for that before trying to allocate lots of
memory and trying to decompress lots of bogus data.

https://sourceware.org/bugzilla/show_bug.cgi?id=21301

Signed-off-by: Mark Wielaard <mark@klomp.org>
This commit is contained in:
Mark Wielaard
2017-03-24 15:06:04 +01:00
parent b0b58c5e0b
commit 8dcc4bf791
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libelf/ChangeLog
+5
View File
@@ -1,3 +1,8 @@
2017-03-24 Mark Wielaard <mark@klomp.org>
* elf_compress.c (__libelf_decompress): Check insane compression
ratios before trying to allocate output buffer.
2016-10-11 Akihiko Odaki <akihiko.odaki.4i@stu.hosei.ac.jp>
Mark Wielaard <mjw@redhat.com>
libelf/elf_compress.c
+9
View File
@@ -211,6 +211,15 @@ void *
internal_function
__libelf_decompress (void *buf_in, size_t size_in, size_t size_out)
{
/* Catch highly unlikely compression ratios so we don't allocate
some giant amount of memory for nothing. The max compression
factor 1032:1 comes from http://www.zlib.net/zlib_tech.html */
if (unlikely (size_out / 1032 > size_in))
{
__libelf_seterrno (ELF_E_INVALID_DATA);
return NULL;
}
void *buf_out = malloc (size_out);
if (unlikely (buf_out == NULL))
{