openharmony/third_party_meshoptimizer
1
0
Fork 0
mirror of https://github.com/openharmony/third_party_meshoptimizer.git synced 2026-07-19 12:03:07 -04:00
Code Issues Packages Projects Releases Wiki Activity

demo: Adjust simplifySeam test a bit to correct border misconceptions

Browse Source 
The seam vertices here have Z coordinate that is higher than zero;
because of this, positional errors are not exactly zero. This is a good
thing since it allows us to get a more stable result across fp
environments and algorithm changes. We adjust the data a little bit to
make the bump less pronounced and fix the comments accordingly.
This commit is contained in:
Arseny Kapoulkine
2024-08-19 18:23:20 -07:00
parent 56eae1dc56
commit 27de01a5cb
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
demo/tests.cpp
+6 -6
View File
@@ -1347,12 +1347,12 @@ static void simplifySeam()
0, 1, 0, 1,
0, 2, 0, 1,
1, 0, 0, 0,
1, 1, 1, 0,
1, 1, 1, 1,
1, 1, 0.3f, 0,
1, 1, 0.3f, 1,
1, 2, 0, 1,
2, 0, 0, 0,
2, 1, 0, 0,
2, 1, 0, 1,
2, 1, 0.1f, 0,
2, 1, 0.1f, 1,
2, 2, 0, 1,
3, 0, 0, 0,
3, 1, 0, 0,
@@ -1402,12 +1402,12 @@ static void simplifySeam()
assert(meshopt_simplify(res, ib, 36, vb, 16, 16, 18, 1.f, 0, &error) == 18);
assert(memcmp(res, expected, sizeof(expected)) == 0);
assert(fabsf(error - 0.22f) < 0.01f); // TODO: this is higher than normal due to border errors?
assert(fabsf(error - 0.04f) < 0.01f); // note: the error is not zero because there is a small difference in height between the seam vertices
float aw = 1;
assert(meshopt_simplifyWithAttributes(res, ib, 36, vb, 16, 16, vb + 3, 16, &aw, 1, NULL, 18, 2.f, 0, &error) == 18);
assert(memcmp(res, expected, sizeof(expected)) == 0);
assert(fabsf(error - 0.22f) < 0.01f); // note: this is the same error as above because the attribute is constant on either side of the seam
assert(fabsf(error - 0.04f) < 0.01f); // note: this is the same error as above because the attribute is constant on either side of the seam
}
static void adjacency()