Intentionally unused return values casted to (void) to fix Coverity warnings

airscan-os.c

@@ -141,7 +141,12 @@ os_mkdir (const char *path, mode_t mode)
 
     for (s = strchr(p + 1, '/'); s != NULL; s = strchr(s + 1, '/')) {
         *s = '\0';
-        mkdir(p, mode);
+
+        /* Note, we have nothing to do with errors in creation of
+         * intermediate directories, but status of creation of the
+         * final directory in the path is checked below
+         */
+        (void) mkdir(p, mode);
         *s = '/';
     }
 

airscan-pollable.c

@@ -92,7 +92,7 @@ pollable_reset (pollable *p)
 {
     uint64_t unused;
 
-    read(p->efd, &unused, sizeof(unused));
+    (void) read(p->efd, &unused, sizeof(unused));
 }
 
 /* Wait until pollable event is ready

airscan-rand.c

@@ -24,7 +24,10 @@ void
 rand_bytes (void *buf, size_t n)
 {
     log_assert(NULL, rand_fp != NULL);
-    fread(buf, 1, n, rand_fp);
+
+    /* Read from /dev/urandom never fails
+     * */
+    (void) fread(buf, 1, n, rand_fp);
 }
 
 /* Initialize random bytes generator

airscan-trace.c

@@ -85,7 +85,7 @@ trace_open (const char *device_name)
         return NULL;
     }
 
-    os_mkdir(conf.dbg_trace, 0755);
+    (void) os_mkdir(conf.dbg_trace, 0755);
     t = mem_new(trace, 1);
     t->refcnt = 1;
 

airscan-wsdd.c

@@ -1010,7 +1010,7 @@ wsdd_resolver_read_callback (int fd, void *data, ELOOP_FDPOLL_MASK mask)
     }
 
     str_from = ip_straddr_from_sockaddr((struct sockaddr*) &from, true);
-    getsockname(fd, (struct sockaddr*) &to, &tolen);
+    (void) getsockname(fd, (struct sockaddr*) &to, &tolen);
     str_to = ip_straddr_from_sockaddr((struct sockaddr*) &to, true);
 
     log_trace(wsdd_log, "%d bytes received: %s->%s", rc,
@@ -1148,7 +1148,7 @@ wsdd_resolver_new (const netif_addr *addr, bool initscan)
         }
 
         /* Note: error is not a problem here */
-        setsockopt(resolver->fd, IPPROTO_IPV6, IPV6_MULTICAST_LOOP,
+        (void) setsockopt(resolver->fd, IPPROTO_IPV6, IPV6_MULTICAST_LOOP,
                 &no, sizeof(no));
     } else {
         rc = setsockopt(resolver->fd, IPPROTO_IP, IP_MULTICAST_IF,
@@ -1167,7 +1167,7 @@ wsdd_resolver_new (const netif_addr *addr, bool initscan)
         }
 
         /* Note: error is not a problem here */
-        setsockopt(resolver->fd, IPPROTO_IP, IP_MULTICAST_LOOP,
+        (void) setsockopt(resolver->fd, IPPROTO_IP, IP_MULTICAST_LOOP,
                 &no, sizeof(no));
     }
 
@@ -1184,7 +1184,7 @@ wsdd_resolver_new (const netif_addr *addr, bool initscan)
 
         rc = bind(resolver->fd, (struct sockaddr*) &a, sizeof(a));
 
-        getsockname(resolver->fd, (struct sockaddr*) &a, &alen);
+        (void) getsockname(resolver->fd, (struct sockaddr*) &a, &alen);
         port = a.sin6_port;
         resolver->str_sockaddr = ip_straddr_from_sockaddr(
                 (struct sockaddr*) &a, true);
@@ -1201,7 +1201,7 @@ wsdd_resolver_new (const netif_addr *addr, bool initscan)
 
         rc = bind(resolver->fd, (struct sockaddr*) &a, sizeof(a));
 
-        getsockname(resolver->fd, (struct sockaddr*) &a, &alen);
+        (void) getsockname(resolver->fd, (struct sockaddr*) &a, &alen);
         port = a.sin_port;
         resolver->str_sockaddr = ip_straddr_from_sockaddr(
                 (struct sockaddr*) &a, true);