openharmony/third_party_tinyalsa
1
0
Fork 0
mirror of https://github.com/openharmony/third_party_tinyalsa.git synced 2026-07-19 23:33:30 -04:00
Code Issues Packages Projects Releases Wiki Activity

mixer: check for overflow and NULL return

Browse Source 
Signed-off-by: Ben Zhang <benzh@google.com>
This commit is contained in:
Ben Zhang
2016-04-22 17:59:40 -07:00
parent 9bad3fa00f
commit 7ed2ffb4dd
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mixer.c
+9
View File
@@ -28,6 +28,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <stdint.h>
#include <string.h>
#include <unistd.h>
#include <fcntl.h>
@@ -366,7 +367,11 @@ int mixer_ctl_get_array(struct mixer_ctl *ctl, void *array, size_t count)
struct snd_ctl_tlv *tlv;
int ret;
if (count > SIZE_MAX - sizeof(*tlv))
return -EINVAL;
tlv = calloc(1, sizeof(*tlv) + count);
if (!tlv)
return -ENOMEM;
tlv->numid = ctl->info.id.numid;
tlv->length = count;
ret = ioctl(ctl->mixer->fd, SNDRV_CTL_IOCTL_TLV_READ, tlv);
@@ -462,7 +467,11 @@ int mixer_ctl_set_array(struct mixer_ctl *ctl, const void *array, size_t count)
if (ctl->info.access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE) {
struct snd_ctl_tlv *tlv;
int ret = 0;
if (count > SIZE_MAX - sizeof(*tlv))
return -EINVAL;
tlv = calloc(1, sizeof(*tlv) + count);
if (!tlv)
return -ENOMEM;
tlv->numid = ctl->info.id.numid;
tlv->length = count;
memcpy(tlv->tlv, array, count);