firewall: small refactor from master to reduce diff

This commit is contained in:
Franco Fichtner
2026-09-21 08:05:21 +02:00
parent 522891a22e
commit 7164d0860c
@@ -32,7 +32,9 @@ use OPNsense\Core\Config;
use OPNsense\Firewall\Util;
use OPNsense\Firewall\Group;
use OPNsense\Base\FieldTypes\ArrayField;
use OPNsense\Base\FieldTypes\BooleanField;
use OPNsense\Base\FieldTypes\ContainerField;
use OPNsense\Base\FieldTypes\ProtocolField;
/**
* Class FilterRuleContainerField
@@ -59,9 +61,9 @@ class FilterRuleContainerField extends ContainerField
// 1-on-1 map (with type conversion if needed)
foreach ($this->iterateItems() as $key => $node) {
if (!in_array($key, $map_manual)) {
if (is_a($node, "OPNsense\\Base\\FieldTypes\\BooleanField")) {
if (is_a($node, BooleanField::class)) {
$result[$key] = !empty((string)$node);
} elseif (is_a($node, "OPNsense\\Base\\FieldTypes\\ProtocolField")) {
} elseif (is_a($node, ProtocolField::class)) {
if ((string)$node != 'any') {
$result[$key] = (string)$node;
}