If we want to allow a single network being routed through multiple next hops, we should alter our cleanup to use the actual gateway instead of always dropping the destination network.
This change only uniforms how we collect that information from the ui and implements proper locking, the logic itself (drop network when altered or removed) isn't changed yet.
This reverts commit 649bcb2186.
There is a bug in the old and new behaviour, but without a proper
test case this will not fix easily. stable/26.7 doesn't use this
yet so it's sane to hotfix.
PR: https://github.com/opnsense/core/issues/10992
Noticed while reviewing https://github.com/opnsense/core/pull/10942
This will prevent two submenus being open at the same time regardless
of depth, which seemed to happen particularly on second-level submenus.
This will cause more shifting around, but this consistency is already
applied on the first-level submenu.
The alternative is to allow multiple second-level submenus open
at the same time and only close when switching top-level sections.
Was modified in 4d495ea6cc, f129c4682b et al. to a state where
the option could still be enabled but never read. The /conf bound historic
log is still filled but nothing reads it. Let's retire it for 27.1.
One other goal here is to reduce the incoming impact of a MVC/API rewrite.
Discussed with: @swhite2
This is intended to fix bootup related issues with PPPoE, e.g. where it
retriggers DHCPv6 too many times. Essentially it's the same as deferring
the newwanip scripts, but one level below since mpd5 is much more allergic
to link state changes.
This also disables the CARP handling on bootup, but does not address
the backup starting up as well as the master. Essentially this is what
reconfigure_ppp.php is meant for.
This needs more work but for now just do what we already do
while wating for the PPP device to come up: wait for the parent
as well as some drivers may take the parent down for multiple
seconds.
Ideally dialing should be deferred to after bootup which we're
already working on... 30 seconds total delay for non-functional
situation is already a lot.
PR: https://forum.opnsense.org/index.php?topic=52824.0
When using "Dynamic gateway policy" on an interface, a route-to rule will omit the (unknown) address.
This logically means both protocols could be served by the same gateway entry.
To ease future migrations from PPP to MVC/API and reduce the
config field "localip" misuse we want to phase out PPTP and
reduce complexity of the implementation.
While L2TP may be still around the PPTP tunneling is very likely
not used anymore. A bit of a message to everyone still using this.
Only one way to find out.
PHP Warning: Undefined array key "localip" in /usr/local/etc/inc/interfaces.inc on line 1192
PHP Warning: Undefined array key "gateway" in /usr/local/etc/inc/interfaces.inc on line 1196
ErrorException: Using null as an array offset is deprecated, use an empty string instead in /usr/local/opnsense/mvc/app/controllers/OPNsense/Routing/Api/SettingsController.php:162
Stack trace:
The function is called via $reload hook so adding another
hook makes no sense. This may have changed since the original
commit below and since we need to priv-sep these calls the
easiest way is to remove it. ;)
See also: https://github.com/pfsense/pfsense/commit/8e11b23f541d
Franco Fichtner