Ad Schellevis
89a74ce83f
VPN: OpenVPN: Instances - default keepalive to 10 60 in server mode and explain in the help text. closes https://github.com/opnsense/core/pull/10174
2026-10-06 09:42:38 +02:00
Franco Fichtner
1a9e4794a0
src: style sweep
2026-10-06 09:09:56 +02:00
Franco Fichtner
ff90e9c9ec
system: refactor route deletion and use priv-sep in general settings page #9352 ( #10962 )
2026-10-06 09:01:13 +02:00
Franco Fichtner
63c8df0337
system: make "noroot" the standard option with 27.1 #9352
...
As discussed internally, we want to aim for this to be the new standard,
but we will not migrate any existing setups just yet. This may need more
documentation/annotation for components (mostly legacy plugins) where this
won't work, but it's a very good start to root these out via user reports.
2026-10-06 08:46:40 +02:00
ExpRam
8148bec9cf
interfaces: remove stale VIP address after update ( #10883 )
2026-10-06 08:45:17 +02:00
Franco Fichtner
609cc79992
mvc: also fix overrides of reconfigureForceRestart() regarding return type
2026-10-06 08:37:27 +02:00
Ad Schellevis
859c529186
Firewall: NAT: Destination NAT - fix destination for no-rdr rules, related to https://github.com/opnsense/core/pull/10945
...
Reported by: @fa1k3
2026-10-05 18:30:15 +02:00
Ad Schellevis
2320a83064
lockout: type safety fix.
2026-10-05 18:06:56 +02:00
Franco Fichtner
7a4294f20f
interfaces: add proper local/remote IP support to PPPoE IPCP; closes #10966
...
I added the remotenet field specifically so that we can do a remote IP /32
selection for people with HA issues getting the wrong gateway from the ISP.
2026-10-05 17:20:47 +02:00
IvanTheGeek
681a0fd644
monit: log from the first line, reconfigure through the base class
...
The local reconfigureAction() only started or reloaded monit when the
whole output of "monit -t" was exactly "Control file syntax OK", so the
first Apply on a new install ("New Monit id: ...") and any deprecation
warning left monit stopped or not reloaded while reporting "ok".
Drop it, and checkAction(), in favor of ApiMutableServiceControllerBase.
Move "set log" to the top of monitrc: monit only logs a parse error
after it has parsed "set log", so an invalid control file now leaves
its reason in the monit log, whether rc refused the reload or monit
refused to start.
Fixes https://github.com/opnsense/core/issues/10928
2026-10-05 11:34:59 +02:00
Ad Schellevis
196cb9ab84
Config: missing chown in backup call to prevent backend processes leaving unaccessible files for the frontend. closes https://github.com/opnsense/core/pull/10963
2026-10-04 15:22:58 +02:00
Franco Fichtner
92974f0802
mvc: trailing commas are cool so let's keep them
2026-10-03 15:32:49 +02:00
Franco Fichtner
ebed60e243
mvc: PortField: always return a string for normalizedPort()
2026-10-03 15:18:53 +02:00
Franco Fichtner
0405ed0f2e
mvc: do not force strict compare on any
2026-10-03 15:10:49 +02:00
Franco Fichtner
7647838324
system: reword previous
2026-10-03 15:05:20 +02:00
Greelan
a57f3cc39b
diagnostics: disable nginx reverse proxy buffering on configd streams ( #10818 )
...
* Disable buffering for all streams
2026-10-03 08:59:49 +02:00
Franco Fichtner
6c03b3170d
make: sorting found files makes more sense
2026-10-03 07:38:15 +02:00
Greelan
6cedecf83c
system: tighten language
2026-10-03 07:29:01 +02:00
Franco Fichtner
fa31068e35
interfaces: clean up after previous
2026-10-01 21:16:35 +02:00
Franco Fichtner
ea58b68b8e
interfaces: be more conservative with -no_dad #10951
...
In e0e1401f87 we're enabling it always which also affects
assigned tunnels such as WireGuard which tend to avoid wanting
DAD so make room for leaving the flag unchanged and change it
everywhere else explicitly per type.
2026-10-01 21:06:25 +02:00
Franco Fichtner
256d2784d4
interfaces: spurious return statement in interfaces_wlan_configure()
2026-10-01 13:31:50 +02:00
Ad Schellevis
f770a88b11
Firewall: NAT: Destination NAT - minor cleanup in previous preventing int's causing deprecation warnings in development mode
2026-10-01 11:32:48 +02:00
Ad Schellevis
9da4d852a7
Firewall: NAT: Destination NAT - add safety guards for calculated port ranges, closes https://github.com/opnsense/core/pull/10945
...
Minor cleanup ensuring proper handling of ranges for empty targets.
Reported by: @fa1k3
2026-10-01 11:22:00 +02:00
Franco Fichtner
c3100684f8
interfaces: add a new 'updateip' hook
...
'newwanip' is misused sometimes and never called in static configurations.
The only consumer is the RFC2136 plugin but maybe that changes in the
future. The plugin also listens on "bootup" and "local" so simply making
a global event for use at the spots where it exists is enough.
2026-10-01 11:06:23 +02:00
Ad Schellevis
57bc18fec9
Firewall: NAT: Destination NAT - add safety guards for calculated port ranges, closes https://github.com/opnsense/core/pull/10945
...
As normalizedPort() is only used to pass values in nat rules, it's more consistent to replace 'any' with empty as that's what the firewall parser would also do.
Next we need to make sure only numeric values are being used in calculations and the upper bound [65535] is respected in all cases.
2026-10-01 11:05:39 +02:00
fa1k3
a37badb156
MVC: PortField - keep the first well-known service in the option list ( #10947 )
2026-10-01 10:23:08 +02:00
Franco Fichtner
397ee8a9b2
make: repair full file matching introduced a while back
2026-10-01 09:53:31 +02:00
Franco Fichtner
d7d7076afe
mvc: dispatch failed message during reconfiguredAction()
...
We lose the stop result in start/reload case but it's not
missing critical.
Suggested by: @Monviech
2026-09-30 15:29:40 +02:00
Monviech
debc632f12
ui: do not add the spinner again when it fails
2026-09-30 15:27:59 +02:00
Franco Fichtner
4311c5a3b3
system: installer as a real user on demand ( #10888 )
...
This allows the installer to use authenticated integration
and SSH keys as a full root user overlay.
2026-09-29 10:34:54 +02:00
Franco Fichtner
97e503079c
system: switch password hashing from bcrypt to argon2id
...
A bit unfortunate both spots exist, but maybe that can change later on.
2026-09-29 10:32:13 +02:00
Monviech and Franco Fichtner
417f7e59ec
VPN: IPsec: Add replay_window to children ( #10938 )
...
* VPN: IPsec: Add replay_window to children
Co-authored-by: Franco Fichtner <[email protected] >
---------
Co-authored-by: Franco Fichtner <[email protected] >
2026-09-29 10:13:10 +02:00
Franco Fichtner
c4ebe6d086
system: add webgui PAM config to test with opnsense-login
2026-09-29 10:11:37 +02:00
Franco Fichtner
a2aeeaf554
system: add latency_avg as sanity check for running dpinger; closes #10937
...
The check was introduced in 0df1c0d so there's no technical background
to take into account. Indeed, latency_avg is probably the reading that
would least likely be 0 in this case.
Suggested by: @mbccd
2026-09-29 09:51:16 +02:00
Franco Fichtner
7441cc3811
interfaces: make a note for some post-merge work still not done
2026-09-28 13:49:41 +02:00
Stephan de Wit
cf4a74309f
ui: ditch font awesome 5 usage here
...
This also allows us to align the style better to what it was
2026-09-28 13:11:59 +02:00
Ad Schellevis
d05d8e1998
Services: Monit - merge most pressing part of https://github.com/opnsense/core/pull/10929 to avoid Monit complaining about an invalid config. for https://github.com/opnsense/core/issues/10928
...
We should rename logfile to log to prvent the deprecation messages, the rest of the PR needs some more work to align with the rest of the codebase.
2026-09-28 13:00:42 +02:00
Ad Schellevis
3fde92805c
Interfaces: Diagnostics: Packet Capture - stricten archive command a bit further
2026-09-28 12:53:16 +02:00
Stephan de Wit
cdde38bee1
bootgrid: upgrade Tabulator to version 6.5.3
2026-09-25 15:30:00 +02:00
Stephan de Wit
506abed86e
firewall: use fa elements for data tree controls to align with themes. Closes https://github.com/opnsense/core/issues/10892
2026-09-25 14:59:43 +02:00
Franco Fichtner
70c5c92263
interfaces: use batch reload in apply_pending_if_changes.php
...
This approach may be useful for rc.linkup as well. We basically
have all the code we need except for proper locking.
2026-09-25 10:57:38 +02:00
Franco Fichtner
d35bdb095e
interfaces: use 1d92dcda2 to customize the settings-changed trigger
...
This is not the final form, but it keeps the special page logic
contained herein while still being able to use the generic trigger.
2026-09-25 10:08:27 +02:00
Stephan de Wit
1d92dcda25
ui: make settings-changed overridable
2026-09-25 09:57:00 +02:00
Stephan de Wit
db0e230f0e
bootgrid: exclude header cells from status color rendering
2026-09-25 09:50:12 +02:00
Franco Fichtner
21923995f1
interfaces: save fields that don't matter to operation directly
...
This ignores the fields from the compare. There's still an issue
with the banner showing the apply message when no apply is needed
(and no todo file is added). This needs to be fixed in the UI,
but needs more glue first.
2026-09-24 15:14:27 +02:00
Franco Fichtner
7e5c2887aa
interfaces: compare first, then call the real toLegacy() when needed
...
Saves a few cycles after we have to pull the data twice.
2026-09-24 15:14:27 +02:00
Franco Fichtner
8de365a559
interfaces: make toLegacy() return the real legacy config
...
Addresses the workaround of 17bc925651 which makes the resulting
code a bit more condensed and failsafe.
2026-09-24 15:14:27 +02:00
Konstantinos Spartalis
31633a4a8c
ui: fix blank bottom UI space ( #10375 )
2026-09-24 14:31:03 +02:00
Stephan de Wit
95f552b3d6
interfaces: skip pfsync interface reconfiguration if peer unchanged ( #10924 )
...
also check if mtu actually changes before applying it on pfsync0
2026-09-24 13:24:40 +02:00
Franco Fichtner
8efb2fa645
interfaces: sync all configration before running configure loop
...
dhcpv6 depends on WAN<->LAN relationships which need a sync of
the whole interface config first.
While here enable output for diagnostic purposes when running
the script from the shell.
2026-09-24 10:06:11 +02:00